From: Andy Gospodarek [EMAIL PROTECTED]
Instead of using the default timeout of 3 minutes, this uses the timeout
specific to the protocol used for the connection. The 3 minute timeout
seems somewhat arbitrary (though I know it is used other places in the
ipvs code) and when failing over it would
Factor code out of sfq_init() so that the new function can be used
by sfq_change() later.
Actually, as the diff itself shows, most of the sfq_q_init() code
comes from the original sfq_change(), but sfq_change() is only
called by sfq_init() right now. Thus, it is safe to remove
sfq_change(); tc
Patchset try 2 addresses the review by Michael Buesch.
Patchset try 3 addresses the review by Patrick McHardy.
Patchset try 4 has a few cosmetic improvements.
Patchset try 5 addresses further review by Patrick McHardy.
This set of patches is substantially the same as my previous try, with
None of these are true anymore (hooray!).
Signed-off-by: Corey Hickey [EMAIL PROTECTED]
---
include/linux/pkt_sched.h |8
net/sched/sch_sfq.c | 13 +
2 files changed, 1 insertions(+), 20 deletions(-)
diff --git a/include/linux/pkt_sched.h
Make hash divisor user-configurable.
Signed-off-by: Corey Hickey [EMAIL PROTECTED]
---
net/sched/sch_sfq.c | 27 +--
1 files changed, 21 insertions(+), 6 deletions(-)
diff --git a/net/sched/sch_sfq.c b/net/sched/sch_sfq.c
index 1c1bf08..c74d5ce 100644
---
Re-implement sfq_change() and enable Qdisc_opts.change so tc qdisc
change will work.
Signed-off-by: Corey Hickey [EMAIL PROTECTED]
---
net/sched/sch_sfq.c | 67 ++-
1 files changed, 66 insertions(+), 1 deletions(-)
diff --git
This fixes the ambiguity between, for example:
tc qdisc change ... perturb 0
tc qdisc change ...
Without this patch, there is no way for SFQ to differentiate between
a parameter specified to be 0 and a parameter that was omitted.
Signed-off-by: Corey Hickey [EMAIL PROTECTED]
---
perturb_period is the only parameter that doesn't match 1:1 with the
value from userspace. Multiplying perturb_period by HZ when used rather
than when assigned makes it easy and clean to use a small function for
setting parameters (in a subsequent patch).
perturb_period is currently a signed
* replace #define with a parameter
* use old hardcoded value as a default
* kcalloc() arrays in sfq_q_init()
* free() arrays in new function sfq_q_destroy()
* move sfq_destroy() to near sfq_q_destroy(), for clarity
Signed-off-by: Corey Hickey [EMAIL PROTECTED]
---
net/sched/sch_sfq.c | 104
Make a new function sfq_q_enqueue() that operates directly on the
queue data. This will be useful for implementing sfq_change() in
a later patch. A pleasant side-effect is reducing most of the
duplicate code in sfq_enqueue() and sfq_requeue().
Similarly, make a new function sfq_q_dequeue().
These patches follow the ESFQ--SFQ kernel patches. See the kernel
patch summary for general information.
Thanks,
Corey
include/linux/pkt_sched.h | 23 ++-
tc/q_sfq.c| 42 +-
2 files changed, 51 insertions(+), 14
This corresponds to the kernel patch doing the same.
Here, too, this will technically break binary compatibility with older
kernels, but that shouldn't be a problem because negative perturb_period
values aren't usable anyway.
---
include/linux/pkt_sched.h |2 +-
tc/q_sfq.c|
This can safely be applied either before or after the kernel
patches because the tc_sfq_qopt struct is unchanged:
- old kernels will ignore the new parameters from new iproute2
- new kernels will use the same defaults for the new parameters
---
include/linux/pkt_sched.h |9 -
Note that I have left sfq_print_opt() alone. At this point, there
can be no difference between the data in the nested rtattrs and the
data in the compat rtattr, and I didn't want to add clutter that
isn't useful. Let me know if I should do differently.
Signed-off-by: Corey Hickey [EMAIL
On Tue, 23 Oct 2007 21:04:20 +0200 Giacomo Catenazzi [EMAIL PROTECTED] wrote:
Hello people,
I've still some kernel bug
ciao
cate
Oct 23 20:20:05 catee kernel: BUG: unable to handle kernel paging request at
virtual address 92184900
Oct 23 20:20:05 catee kernel: printing eip:
Corey Hickey wrote:
+/* SFQ parameters exist as individual rtattr attributes, with a nested
+ * struct tc_sfq_qopt for compatibility with older userspace tools. If an
+ * individual attribute is set, we want to use it; otherwise, fall back to
the
+ * nested struct.
+ * There is one caveat:
From: Simon Horman [EMAIL PROTECTED]
Date: Mon, 29 Oct 2007 16:05:55 +0900 (JST)
From: Andy Gospodarek [EMAIL PROTECTED]
Instead of using the default timeout of 3 minutes, this uses the timeout
specific to the protocol used for the connection. The 3 minute timeout
seems somewhat arbitrary
From: YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED]
Date: Mon, 29 Oct 2007 11:49:54 +0900 (JST)
This bug was introduced by the commit
d12af679bcf8995a237560bdf7a4d734f8df5dbb.
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED]
Patch applied, thank you!
-
To unsubscribe from this list: send the
On Mon, Oct 29, 2007 at 01:35:15AM -0700, David Miller wrote:
From: Simon Horman [EMAIL PROTECTED]
Date: Mon, 29 Oct 2007 16:05:55 +0900 (JST)
From: Andy Gospodarek [EMAIL PROTECTED]
Instead of using the default timeout of 3 minutes, this uses the timeout
specific to the protocol used
On 15-10-2007 17:39, Darko K. wrote:
Hello,
after recent upgrade to kernel 2.6.23 (from 2.6.20) I have started
seeing kernel oops-es in networking code. The problem is 100%
reproducible in my environment. I've seen two slightly different
backtraces but both seem to be caused by the same
From: Eliezer Tamir [EMAIL PROTECTED]
Date: Sun, 28 Oct 2007 22:21:14 +0200
Overall things look significantly better, thanks a lot!
However, there is still one set of magic constants in here
which I hope you can clear up:
+static const struct raw_op init_ops[] = {
+#define PRS_COMMON_START
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Mon, 29 Oct 2007 09:42:32 +0100
I hope you've found this by yourself by now, but:
1. These are warnings only - not oopses.
2. It seems this patch you've found to be responsible for this all
slightly changes some limits, which is not necessarily
On Fri, 2007-10-26 at 11:33 -0700, Stephen Hemminger wrote:
Don't call napi_disable if not configured.
And make sure that any misuse of napi_xxx in future fails
with a compile error.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
This fix the problem for me (at least, after 8
John W. Linville wrote:
Jeff,
A few fixes for 2.6.24...
Thanks,
John
---
Individual patches available here:
http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/fixes-jgarzik
---
The following changes since commit c9927c2bf4f45bb85e8b502ab3fb79ad6483c244:
Linus
Jan-Bernd Themann wrote:
eHEA resources that are allocated via H_CALLs have a unique identifier each.
These identifiers are necessary to free the resources. A reboot notifier
is used to free all eHEA resources before the indentifiers get lost, i.e
before kexec starts a new kernel.
Francois Romieu wrote:
Please pull from branch 'upstream-jeff' in repository
git://git.kernel.org/pub/scm/linux/kernel/git/romieu/netdev-2.6.git
upstream-jeff
to get the changes below.
Distance from 'master' (96fd4cd3e40e240f0c385af87f58e74da8b7099a)
Joakim Tjernlund wrote:
From 5761a9e5924b34615c748fba2dcb977ed04c1243 Mon Sep 17 00:00:00 2001
From: Joakim Tjernlund [EMAIL PROTECTED]
Date: Wed, 17 Oct 2007 11:01:44 +0200
Subject: [PATCH] Fix ethernet multicast for ucc_geth.
hw_add_addr_in_hash() already swaps byte
order, don't do it in
Auke Kok wrote:
Trivial replacement - use INT_MAX instead here.
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
---
drivers/net/sk98lin/skethtool.c |4 ++--
drivers/net/skge.c |8
drivers/net/sky2.c |8
3 files changed,
Domen Puncer wrote:
On 26/10/07 07:18 -0700, Dale Farnsworth wrote:
On Fri, Oct 26, 2007 at 01:59:09PM +0200, Domen Puncer wrote:
+static irqreturn_t mpc52xx_fec_tx_interrupt(int irq, void *dev_id)
+{
+ struct net_device *dev = dev_id;
+ struct mpc52xx_fec_priv *priv =
Sivakumar Subramani wrote:
- Fixed memory leak by freeing MSI-X local entry memories when vector allocation
fails in s2io_add_isr.
- Added two utility functions do_rem_msix_isr and do_rem_inta_isr to eliminate
code duplication.
Signed-off-by: Veena Parat [EMAIL PROTECTED]
Signed-off-by:
Auke Kok wrote:
Since data can never exceed u32, it can't even be larger than LONG_MAX/HZ.
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
---
drivers/net/pcnet32.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/pcnet32.c
@@ -2255,19 +2253,10 @@ static void
ucc_geth_set_multi(struct net_device *dev)
if (!(dmi-dmi_addr[0] 1))
continue;
- /* The address in dmi_addr is LSB first,
-*
Joakim Tjernlund wrote:
From 5761a9e5924b34615c748fba2dcb977ed04c1243 Mon Sep 17 00:00:00 2001
From: Joakim Tjernlund [EMAIL PROTECTED]
Date: Wed, 17 Oct 2007 11:01:44 +0200
Subject: [PATCH] Fix ethernet multicast for ucc_geth.
hw_add_addr_in_hash() already swaps byte
order, don't do it in
Jeff,
Is this patch reviewed/applied?
-srini
-Original Message-
From: Sreenivasa Honnur [mailto:[EMAIL PROTECTED]
Sent: Friday, October 19, 2007 11:23 AM
To: [EMAIL PROTECTED]; netdev@vger.kernel.org
Cc: support
Subject: [PATCH 2.6.24 1/1]S2io: Support for add/delete/store/restore
Denys wrote:
Hi All
During testing i found very strange thing.
After applying even example shaper:
http://linux-ip.net/tc/hfsc.en/
-
[...]
---
I had all traffic on eth0 stopped. Tried on br0 - same result. Even ARP
becoming non-functional.
After specifying correct
Denys wrote:
Additionally, it doesn't show rate in stats (so it is difficult to measure,
how much is really using each class).
qdisc hfsc 1: root default 200
Sent 1392761062 bytes 965768 pkt (dropped 52, overlimits 1620539 requeues 0)
rate 0bit 0pps backlog 0b 0p requeues 0
Thats what
On Mon, Oct 29, 2007 at 02:12:07PM +0800, Li Yang-r58472 wrote:
[...]
+#ifdef CONFIG_NET_POLL_CONTROLLER
+/*
+ * Polling 'interrupt' - used by things like netconsole to send
+skbs
+ * without having to re-enable interrupts. It's not called while
+ * the interrupt routine
After thinking about that, i can say only thanks.
I like your idea, and it is better to avoid mistakes and missed traffic, then
have a lot of complaints from users why my shaper not working well. And
seems i will try to switch to HFSC.
Thanks for explanation.
On Mon, 29 Oct 2007 11:55:31
On Mon, Oct 29, 2007 at 04:05:55PM +0900, Simon Horman wrote:
From: Andy Gospodarek [EMAIL PROTECTED]
Instead of using the default timeout of 3 minutes, this uses the timeout
specific to the protocol used for the connection. The 3 minute timeout
seems somewhat arbitrary (though I know it is
On Mon, Oct 29, 2007 at 03:33:20PM +0900, Mitsuru Chinen wrote:
Hello Herbert,
Let me ask a question about this patch.
After this patch was applied, 2 of the protocol stack behaviors were
changed when it receives a UDP datagram with broken checksum:
1. udp6InDatagrams is incremented
Em Sun, Oct 28, 2007 at 09:44:41AM +0100, Sam Ravnborg escreveu:
As a general rule, I think it better to use includes
than use naked forward declarations.
Quite the opposite - at least in the kernel source.
The general rule is that a .h file shall include the
.h files which contain
On Mon, Oct 29, 2007 at 01:41:47AM -0700, David Miller wrote:
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Mon, 29 Oct 2007 09:42:32 +0100
I hope you've found this by yourself by now, but:
1. These are warnings only - not oopses.
2. It seems this patch you've found to be responsible
Hi,
Are there any plans to add ICH9 support to the e1000 driver (I note
there is a patch floating around), or is the intention that ICH9 users
all move to e1000e?
Just wondering which approach to take in terms of getting this hardware
supported in Gentoo's 2.6.23 kernels.
Thanks!
Daniel
-
Daniel Drake wrote:
Are there any plans to add ICH9 support to the e1000 driver (I note
there is a patch floating around), or is the intention that ICH9 users
all move to e1000e?
They all should use e1000e.
Further, in 2.6.25 or so, some e1000 PCI IDs will be moved to e1000e,
and support
On Wed, Oct 24, 2007 at 06:25:03PM +0200, Adrian Bunk wrote:
According to git, the only one who touched this file during the last
5 years was me when removing drivers...
That's not the only obsolete thing there:
ncsa-telnet
- notes on how NCSA telnet (DOS) breaks with MTU discovery
On Mon, 29 Oct 2007 06:05:14 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
Auke Kok wrote:
Trivial replacement - use INT_MAX instead here.
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
---
drivers/net/sk98lin/skethtool.c |4 ++--
drivers/net/skge.c
On 10/29/07, Jeff Garzik [EMAIL PROTECTED] wrote:
Domen Puncer wrote:
drivers/net/Kconfig | 24
drivers/net/Makefile |4
drivers/net/fec_mpc52xx.c | 1112
++
drivers/net/fec_mpc52xx.h | 313 +++
Stephen Hemminger wrote:
Since these all use ethtool, shouldn't the checks be put into ethtool_phys_id
rather than having the driver check?
Seems quite reasonable to me.
Jeff
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL
e1000 is being frozen in time as pre-PCI Express e1000's.
Asking the question a different way, will the current e1000 driver
continue to get new features, performance / power / optimization tweaks,
etc. or is most of the primary development be moving only on the e1000e kit?
--David
-
To
David A. Ranch wrote:
e1000 is being frozen in time as pre-PCI Express e1000's.
Asking the question a different way, will the current e1000 driver
continue to get new features, performance / power / optimization tweaks,
etc. or is most of the primary development be moving only on the
From: Stephen Hemminger [EMAIL PROTECTED]
Fix sparse warnings and problems from e1000 driver.
Added a sparse fix for the module param array index
-- Auke
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/e1000.h |8
From: Stephen Hemminger [EMAIL PROTECTED]
Fix sparse warnings in ixgb driver for net-2.6.24.
Added a sparse fix for invalid declaration using non-constant value
in ixgb_set_multi. Added a fix for the module param array index
and allows int params in the array. --Auke
Signed-off-by: Stephen
Andrew Morton wrote:
On Tue, 23 Oct 2007 21:04:20 +0200 Giacomo Catenazzi [EMAIL PROTECTED]
wrote:
Oct 23 20:20:05 catee kernel: BUG: unable to handle kernel paging request at
virtual address 92184900
Is this still happening in the latest Linus tree?
If so, please send some more oops
Hi All
Does anyone have a reason why Linux allows one to configure
the same IP or IPv6 address on multiple interfaces?
For IPv4, since linux implements a weak host model, assigning
duplicate addresses doesn't make any sense, since the addresses
really belong to the host and not the interface.
From: Roel Kluin [EMAIL PROTECTED]
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000e/82571.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/e1000e/82571.c b/drivers/net/e1000e/82571.c
index
From: Stephen Hemminger [EMAIL PROTECTED]
Make strings const if possible, and fix includes so forward definitions
are seen.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/ixgbe/ixgbe.h |2 +-
https://bugzilla.redhat.com/show_bug.cgi?id=219488
Still happening in 2.6.22.9:
BUG: unable to handle kernel paging request at virtual address 66696674
printing eip:
d098d4de
*pde =
Oops: [#1]
SMP
last sysfs file: /class/net/lo/ifindex
Modules linked in: sch_teql netconsole
Jeff Garzik wrote:
Auke Kok wrote:
Since data can never exceed u32, it can't even be larger than
LONG_MAX/HZ.
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
---
Two comments:
1) I would prefer to pick a sane limit, like 1 day. The unit of
'data' is seconds, so IMO we
From: Stephen Hemminger [EMAIL PROTECTED]
Fix sparse warnings from e1000e driver in net-2.6.24.
Added a sparse fix for module param arrays which can have int values
but only the array index needs to be unsigned. --Auke
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
Signed-off-by: Auke Kok
On Mon, 29 Oct 2007 09:10:26 -0700 (PDT)
[EMAIL PROTECTED] wrote:
http://bugzilla.kernel.org/show_bug.cgi?id=9260
Summary: tipc_config.h is not installed when doing make
headers_install
Product: Other
Version: 2.5
KernelVersion:
Hi Aurelien,
This is a combination of your two patches into one, cleaned-up with all
my complaints. I also added an ipv6_addr_set_v4mapped() inline after
someone else here convinced me it gets rid of a lot of cruft from the
code. The DCCP, etc. code can be cleaned-up later if this gets
On Oct 29 2007 15:33, Jeff Garzik wrote:
+#if 0 /* info available elsewhere, but this is kept for reference */
It is available in the git history, yes, is it still needed for reference?
+static short ibmlana_adapter_ids[] __initdata = {
+ IBM_LANA_ID,
+ 0x
+};
+
+static char
Jan Engelhardt wrote:
On Oct 29 2007 15:33, Jeff Garzik wrote:
+#if 0 /* info available elsewhere, but this is kept for reference */
It is available in the git history, yes, is it still needed for reference?
it's there to see if anyone complains at its removal :)
+static short
[EMAIL PROTECTED] wrote on 10/29/2007 11:03:37 AM:
So, I am looking for technical reasons why this is permitted.
Vlad,
Is there a technical reason to disallow it? Rather than
anticipate all the possible uses for a machine, it's, of course,
generally better to restrict only the things
* move alloc_netdev() call, register_netdev() call, and associated failure
cleanup into ibmlana_probe()
* move per-net_device cleanup into ibmlana_remove_one()
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
drivers/net/ibmlana.c | 109 +
1
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
drivers/net/ibmlana.c | 119 +
1 files changed, 51 insertions(+), 68 deletions(-)
diff --git a/drivers/net/ibmlana.c b/drivers/net/ibmlana.c
index 006d0d7..188c0a9 100644
--- a/drivers/net/ibmlana.c
For v6, there are plenty of operational reasons to not allow this. You
really
turn unicast into anycast when you do this and there are special rules
to
be followed.
I don't see it that way. The only problem I can think of offhand
is that you can't use a multi-interface address to
On Fri, Oct 26 2007, Herbert Xu wrote:
[CRYPTO] tcrypt: Move sg_init_table out of timing loops
This patch moves the sg_init_table out of the timing loops for hash
algorithms so that it doesn't impact on the speed test results.
Wouldn't it be better to just make sg_init_one() call
hm, this seems to have popped up in the last few days, never had it
before:
sysfs: duplicate filename 'eth0' can not be created
WARNING: at fs/sysfs/dir.c:424 sysfs_add_one()
Call Trace:
[802de00a] sysfs_add_one+0x54/0xbd
[802dee61] sysfs_create_link+0xc6/0x11d
Hello!
net/decnet/dn_route.c in dn_rt_cache_get_next() is as follows:
static struct dn_route *dn_rt_cache_get_next(struct seq_file *seq, struct
dn_route *rt)
{
struct dn_rt_cache_iter_state *s = rcu_dereference(seq-private);
rt = rt-u.dst.dn_next;
while(!rt) {
Dave,
I didn't see a response for this one... in case it fell through
the
cracks. Just want to make sure my bone-headed error doesn't hang
around too long. :-)
+-DLS
- Forwarded by David Stevens/Beaverton/IBM on 10/29/2007 01:51 PM
Hello,
This is the latest patch set of UDP memory accounting and limitation.
The number of pages for socket buffer is limited up to
/proc/sys/net/ipv4/udp_mem. I removed the minimal limit number
to use the feature from the former patch set (take5). And udp_init()
is introduced to calculate
This patch introduces sndbuf size check before memory allocation for
send buffer.
--
Hideo Aoki
Hitachi Computer Products (America) Inc.
Signed-off-by: Satoshi Oshima [EMAIL PROTECTED]
Signed-off-by: Hideo Aoki [EMAIL PROTECTED]
ip_output.c |5 +
1 file changed, 5 insertions(+)
diff
This commit made an incorrect assumption:
--
Author: Lennert Buytenhek [EMAIL PROTECTED]
Date: Fri Oct 19 04:10:10 2007 +0200
mv643xx_eth: Move ethernet register definitions into private header
Move the mv643xx's ethernet-related register definitions from
This patch introduces global variable for UDP memory accounting.
The unit is page.
--
Hideo Aoki
Hitachi Computer Products (America) Inc.
Signed-off-by: Satoshi Oshima [EMAIL PROTECTED]
Signed-off-by: Hideo Aoki [EMAIL PROTECTED]
include/net/sock.h |7 +++
include/net/udp.h |2 ++
This patch introduces memory limitation for UDP.
--
Hideo Aoki
Hitachi Computer Products (America) Inc.
Signed-off-by: Satoshi Oshima [EMAIL PROTECTED]
Signed-off-by: Hideo Aoki [EMAIL PROTECTED]
Documentation/networking/ip-sysctl.txt |6
include/net/udp.h |3
This patch added /proc/sys/net/udp_rmem and /proc/sys/net/udp_rmem.
Each UDP packet is drooped when the number of pages for socket buffer
is beyond the limit and the socket already consumes minimum buffer.
--
Hideo Aoki
Hitachi Computer Products (America) Inc.
Cc: Satoshi Oshima [EMAIL
Em Mon, Oct 29, 2007 at 01:52:22PM -0700, Stephen Hemminger escreveu:
Fix possible race while waiting for connections in accept. I don't
know of a test case that could reproduce this directly.
The state of the socket should be checked before checking the queue.
If the socket has left the
This patch adds UDP memory usage accounting in IPv4.
--
Hideo Aoki
Hitachi Computer Products (America) Inc.
Signed-off-by: Satoshi Oshima [EMAIL PROTECTED]
Signed-off-by: Hideo Aoki [EMAIL PROTECTED]
af_inet.c | 30 +-
ip_output.c | 25
Ingo Molnar wrote:
hm, this seems to have popped up in the last few days, never had it
before:
sysfs: duplicate filename 'eth0' can not be created
WARNING: at fs/sysfs/dir.c:424 sysfs_add_one()
Call Trace:
[802de00a] sysfs_add_one+0x54/0xbd
[802dee61]
On Mon, 29 Oct 2007 19:29:06 -0200
Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote:
Em Mon, Oct 29, 2007 at 01:52:22PM -0700, Stephen Hemminger escreveu:
Fix possible race while waiting for connections in accept. I don't
know of a test case that could reproduce this directly.
The state
On Mon, 29 Oct 2007 22:17:46 +0100
Ingo Molnar [EMAIL PROTECTED] wrote:
hm, this seems to have popped up in the last few days, never had it
before:
sysfs: duplicate filename 'eth0' can not be created
WARNING: at fs/sysfs/dir.c:424 sysfs_add_one()
Call Trace:
Fix possible race while waiting for connections in accept. I don't
know of a test case that could reproduce this directly.
The state of the socket should be checked before checking the queue.
If the socket has left the TCP_LISTEN state, then the accept queue
is no longer valid.
Signed-off-by:
Hello!
While reviewing rcu_dereference() uses, I came across a number of cases
where I couldn't see how the rcu_dereference() helped. One class of
cases is where the variable is never subsequently dereferenced, so that
patches like the following one would be appropriate.
So, what am I missing
Jeff Garzik wrote:
Ingo Molnar wrote:
hm, this seems to have popped up in the last few days, never had it
before:
sysfs: duplicate filename 'eth0' can not be created
WARNING: at fs/sysfs/dir.c:424 sysfs_add_one()
Call Trace:
[802de00a] sysfs_add_one+0x54/0xbd
* Stephen Hemminger [EMAIL PROTECTED] wrote:
Already fixed post 2.6.24-rc1
commit c8d90dca3211966ba5189e0f3d4bccd558d9ae08
Author: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri Oct 26 03:53:42 2007 -0700
[NET] dev_change_name: ignore changes to same name
ah, nice - that explains
David Stevens wrote:
[EMAIL PROTECTED] wrote on 10/29/2007 11:03:37 AM:
So, I am looking for technical reasons why this is permitted.
Vlad,
Is there a technical reason to disallow it? Rather than
anticipate all the possible uses for a machine, it's, of course,
generally better to
From: Ingo Molnar [EMAIL PROTECTED]
Date: Mon, 29 Oct 2007 22:17:46 +0100
hm, this seems to have popped up in the last few days, never had it
before:
sysfs: duplicate filename 'eth0' can not be created
WARNING: at fs/sysfs/dir.c:424 sysfs_add_one()
I checked in a change from Stephen
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Mon, 29 Oct 2007 14:37:14 -0700
On Mon, 29 Oct 2007 19:29:06 -0200
Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote:
Em Mon, Oct 29, 2007 at 01:52:22PM -0700, Stephen Hemminger escreveu:
Fix possible race while waiting for connections in
On Mon, Oct 29, 2007 at 05:27:29PM -0400, Luis R. Rodriguez wrote:
This commit made an incorrect assumption:
--
Author: Lennert Buytenhek [EMAIL PROTECTED]
Date: Fri Oct 19 04:10:10 2007 +0200
mv643xx_eth: Move ethernet register definitions into private header
Move the
On Mon, Oct 29, 2007 at 05:27:29PM -0400, Luis R. Rodriguez wrote:
This commit made an incorrect assumption:
--
Author: Lennert Buytenhek [EMAIL PROTECTED]
Date: Fri Oct 19 04:10:10 2007 +0200
mv643xx_eth: Move ethernet register definitions into private header
Move the
This patch adds support for the RDC R6040 MAC we can find in the RDC R-321x
System-on-chips.
This driver really needs improvements especially on the NAPI part which
probably does not
fully use the new NAPI structure.
You will need the RDC PCI identifiers if you want to test this driver which are
On Oct 29 2007 15:10, David Miller wrote:
On Oct 29 2007 08:54, Tom Southerland wrote:
This patch provides a unique mac address for all interfaces
for the Sun QFE card (non-sparc). It takes the base mac from
the first interface and increments the mac address for the
other interfaces.
From: Jan Engelhardt [EMAIL PROTECTED]
Date: Mon, 29 Oct 2007 23:12:25 +0100 (CET)
The question was more like: if I put in a QFE (that was acquired together
with a SUN E250) into x86, would I get duplicate MACs? (Would be strange -
I would have supposed the OF on the card is independent.)
You
From: David Miller [EMAIL PROTECTED]
Date: Mon, 29 Oct 2007 15:25:59 -0700 (PDT)
Can you guys please just state upfront what virtualization
issue is made more difficult by features you want to remove?
Sorry, I mentioned virtualization because that's been the
largest majority of the cases being
On Mon, 29 Oct 2007 15:38:42 -0700 (PDT)
David Miller [EMAIL PROTECTED] wrote:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Mon, 29 Oct 2007 14:37:14 -0700
On Mon, 29 Oct 2007 19:29:06 -0200
Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote:
Em Mon, Oct 29, 2007 at 01:52:22PM
On Mon, Oct 29, 2007 at 09:16:27PM +0100, Jens Axboe wrote:
On Fri, Oct 26 2007, Herbert Xu wrote:
[CRYPTO] tcrypt: Move sg_init_table out of timing loops
This patch moves the sg_init_table out of the timing loops for hash
algorithms so that it doesn't impact on the speed test results.
Hi,
I previously contacted tun driver maintainer about a bug I found and
he suggested me to forward this to you.
so, look like there is a bug in the kernel when the VLAN code is
dealing with an interface like the tun interface.
see forwarded my original mail and Max reply.
thanks!
--
This patch provides a unique mac address for all interfaces
for the Sun QFE card (non-sparc). It takes the base mac from
the first interface and increments the mac address for the
other interfaces.
It still preserves the 'macaddr' parameter so if desired, it
can still be used.
Before patching:
From: Tom Southerland [EMAIL PROTECTED]
Date: Mon, 29 Oct 2007 19:53:52 -0600
This patch provides a unique mac address for all interfaces
for the Sun QFE card (non-sparc). It takes the base mac from
the first interface and increments the mac address for the
other interfaces.
It still
1 - 100 of 113 matches
Mail list logo
