Re: [PATCH 12/21] [TCP]: Introduce per skb fack_counts to retransmit queue

2007-12-01 Thread Herbert Xu
On Sun, Dec 02, 2007 at 12:48:07AM +0200, Ilpo Järvinen wrote: > > @@ -1220,6 +1221,11 @@ static inline struct sk_buff > *tcp_write_queue_next(struct sock *sk, struct sk_bu > return skb->next; > } > > +static inline struct sk_buff *tcp_write_queue_prev(struct sock *sk, struct > sk_buff *s

[PATCH] Fix buglets in mpc5200 FEC code that are corrupting memory.

2007-12-01 Thread Grant Likely
From: Jon Smirl <[EMAIL PROTECTED]> This is the reason I couldn't get user space started or connect to my nfs server. Patch is against current linus git. mpc5200 fec driver is corrupting memory. This patch fixes two bugs where the wrong skb buffer was being referenced. Signed-off-by: Jon Smirl <

[PATCH] gianfar driver: eliminate compiler warnings and unnecessary macros

2007-12-01 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> This patch eliminates the warning of unused return values when the driver registers it sysfs files. Now the driver will print an error if it is unable to register the sysfs files. It also eliminates the macros used to wrap the DEVICE_ATTR macro and the devi

[PATCH] gianfar: fix compile warning

2007-12-01 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Eliminate an uninitialized variable warning. The code is correct, but a pointer to the automatic variable 'addr' is passed to dma_alloc_coherent. Since addr has never been initialized, and the compiler doesn't know what dma_alloc_coherent will do with it, it

Re: namespace support requires network modules to say "GPL"

2007-12-01 Thread Stephen Hemminger
On Sat, 01 Dec 2007 22:34:09 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > On Sat, 1 Dec 2007 11:17:36 -0800 > > Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > > >> Then init_net needs to be not GPL limited. Sorry, we need to allow > >> non GPL network drivers. Ther

Re: namespace support requires network modules to say "GPL"

2007-12-01 Thread Mark Lord
Stephen Hemminger wrote: On Sat, 1 Dec 2007 11:17:36 -0800 Stephen Hemminger <[EMAIL PROTECTED]> wrote: Then init_net needs to be not GPL limited. Sorry, we need to allow non GPL network drivers. There is a fine line between keeping the binary seething masses from accessing random kernel funct

Re: [PATCH net-2.6.25 1/6][CORE] Remove unneeded ifdefs from sysctl_net_core.c

2007-12-01 Thread Eric W. Biederman
Pavel Emelyanov <[EMAIL PROTECTED]> writes: > They include the whole file, but it is already compiled > out when SYSCTL=n, since it is obj-$(CONFIG_SYSCTL) target > in the Makefile. Pavel thanks for sending these patches. Might I ask for some level of acknowledgement when you rework one of my pa

Re: namespace support requires network modules to say "GPL"

2007-12-01 Thread Eric W. Biederman
Stephen Hemminger <[EMAIL PROTECTED]> writes: > On Sat, 1 Dec 2007 11:17:36 -0800 > Stephen Hemminger <[EMAIL PROTECTED]> wrote: > >> Then init_net needs to be not GPL limited. Sorry, we need to allow >> non GPL network drivers. There is a fine line between keeping the >> binary seething masses f

Re: namespace support requires network modules to say "GPL"

2007-12-01 Thread Eric W. Biederman
Jiri Slaby <[EMAIL PROTECTED]> writes: > On 12/02/2007 12:13 AM, Eric W. Biederman wrote: >> Mark Lord <[EMAIL PROTECTED]> writes: >>> Fine. But all of them want to call sk_alloc(), >> >> network drivers should be calling sk_alloc less then they should >> call dev_get_by_. Only protocols ca

Re: namespace support requires network modules to say "GPL"

2007-12-01 Thread Eric W. Biederman
Mark Lord <[EMAIL PROTECTED]> writes: > Eric W. Biederman wrote: >> Mark Lord <[EMAIL PROTECTED]> writes: >> >>> Arjan van de Ven wrote: On Sat, 01 Dec 2007 15:21:12 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: > Eric W. Biederman wrote: >> Stephen Hemminger <[EMAIL PROTECTED]

Re: namespace support requires network modules to say "GPL"

2007-12-01 Thread Stephen Hemminger
On Sat, 1 Dec 2007 11:17:36 -0800 Stephen Hemminger <[EMAIL PROTECTED]> wrote: > Then init_net needs to be not GPL limited. Sorry, we need to allow > non GPL network drivers. There is a fine line between keeping the > binary seething masses from accessing random kernel functions, and allowing > r

Re: [PATCH 13/21] [TCP]: Store retransmit queue packets in RB tree.

2007-12-01 Thread Herbert Xu
On Sun, Dec 02, 2007 at 12:48:08AM +0200, Ilpo Järvinen wrote: > > This work was mostly done by David S. Miller. ... > @@ -253,6 +254,8 @@ struct sk_buff { > struct sk_buff *next; > struct sk_buff *prev; > > + struct rb_node rb; Did David really do th

Re: [RFC PATCH net-2.6.25 0/21]: TCP tweaks & RB-tree WIP preview

2007-12-01 Thread Herbert Xu
On Sun, Dec 02, 2007 at 12:47:55AM +0200, Ilpo Järvinen wrote: > > First, there are some rather trivial ones (up to [TCP]: Cleanup > local variables of clean _rtx_queue)... Thanks a lot of Ilpo. I've put it into net-2.6.25 so we'll see how it goes. Cheers, -- Visit Openswan at http://www.opens

Re: [LIKELY_SPAM][git patches] net driver fixes

2007-12-01 Thread Divy Le Ray
Jeff Garzik wrote: Notes: 1) Several of these are resends from the last submission. 2) That chelsio file mode change (644->755) is a bit annoying. Can git do chmod as a changeset by itself? Sorry for this. I had not noticed it. If any help, I just submitted a patch reverting the file mode

[PATCH] cxgb - revert file mode changes.

2007-12-01 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> revert inavertant file mode changes Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/chelsio/cxgb2.c |0 drivers/net/chelsio/pm3393.c |0 drivers/net/chelsio/sge.c|0 drivers/net/chelsio/sge.h|0 4 files changed, 0

Re: namespace support requires network modules to say "GPL"

2007-12-01 Thread Mark Lord
Eric W. Biederman wrote: Mark Lord <[EMAIL PROTECTED]> writes: Arjan van de Ven wrote: On Sat, 01 Dec 2007 15:21:12 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: Eric W. Biederman wrote: Stephen Hemminger <[EMAIL PROTECTED]> writes: Sure. We keep the updated dev_get_by_ that takes a netwo

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-12-01 Thread Stephen Rothwell
Just a little reminder ... On Sun, 2 Dec 2007 00:34:03 +0300 Anton Vorontsov <[EMAIL PROTECTED]> wrote: > > static int __init of_add_fixed_phys(void) > { > struct device_node *np; > const u32 *prop; > struct fixed_phy_status status = {}; > > while ((np = of_find_node_by_na

Re: [PATCH 0/3] cxgb - driver fixes.

2007-12-01 Thread Divy Le Ray
Ben Greear wrote: Divy Le Ray wrote: Jeff, I'm submitting a patch series for inclusion in 2.6.24 for the cxgb driver. The patches are built against Linus'git tree. Here is a brief description: - Ensure that GSO skbs have enough headroom before encapsulating them, - Fix a crash in NAPI mode,

Re: namespace support requires network modules to say "GPL"

2007-12-01 Thread Jiri Slaby
On 12/02/2007 12:13 AM, Eric W. Biederman wrote: > Mark Lord <[EMAIL PROTECTED]> writes: >> Fine. But all of them want to call sk_alloc(), > > network drivers should be calling sk_alloc less then they should > call dev_get_by_. Only protocols call sk_alloc. > >> and many want to do register

Re: namespace support requires network modules to say "GPL"

2007-12-01 Thread Eric W. Biederman
Mark Lord <[EMAIL PROTECTED]> writes: > Arjan van de Ven wrote: >> On Sat, 01 Dec 2007 15:21:12 -0500 >> Mark Lord <[EMAIL PROTECTED]> wrote: >> >>> Eric W. Biederman wrote: Stephen Hemminger <[EMAIL PROTECTED]> writes: Sure. We keep the updated dev_get_by_ that takes a network

[PATCH 21/21] [TCP]: Split write queue into two parts (SACKed and not)

2007-12-01 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]> Due to linked list implementation, which must occasionally spend huge effort to locate the correct skb, tagging per skb scoreboard information is all the time becoming heavier operation because the window sizes are growing. This processing

[PATCH 20/21] [TCP]: Introduce tcp_skb_adjacent to detect holes in wq

2007-12-01 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]> Soon the skbs in the write_queue won't necessary be adjacent ones because part of the queue is stored elsewhere. Verify that there isn't hole between skbs when trying to combine two of them. Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]

[PATCH 06/21] [TCP]: Remove local variable and use packets_in_flight directly

2007-12-01 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]> Lines won't be that long and it's compiler's job to optimize them. Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- net/ipv4/tcp_output.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/net/ipv4/tcp_o

[PATCH 19/21] [TCP]: Introduce tcp_real_queue_head(sk)

2007-12-01 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]> This is necessary when SACKed and non-SACKed spaces become separate in the later patch. However, callers should be converted to behave without this later on. Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- include/net/tcp.h|

[PATCH 13/21] [TCP]: Store retransmit queue packets in RB tree.

2007-12-01 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]> This work was mostly done by David S. Miller. Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- include/linux/skbuff.h |3 ++ include/linux/tcp.h |2 + include/net/tcp.h| 62 +++

[PATCH 18/21] [TCP]: Move tcp_advance_highest_sack call early enough

2007-12-01 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]> The call must be done before any queue moves occur (done in the later patch). Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- net/ipv4/tcp_input.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/ipv

[PATCH 15/21] [TCP]: Use per skb fack count instead of function argument

2007-12-01 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]> Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- net/ipv4/tcp_input.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 8a02de2..c

[PATCH 16/21] [TCP]: Move tcp_check_dsack

2007-12-01 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]> Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- net/ipv4/tcp_input.c | 66 +- 1 files changed, 33 insertions(+), 33 deletions(-) diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_inpu

[PATCH 17/21] [TCP]: Move tcp_write_queue_empty

2007-12-01 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]> Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- include/net/tcp.h | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/net/tcp.h b/include/net/tcp.h index 0883697..117fcc4 100644 --- a/include/net

[PATCH 14/21] [TCP]: Added queue parameter to _for_write_queue helpers

2007-12-01 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]> Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- include/net/tcp.h |8 net/ipv4/tcp_input.c | 18 +- net/ipv4/tcp_output.c |8 3 files changed, 17 insertions(+), 17 deletions(-) diff -

[PATCH 11/21] [TCP]: Abstract tp->highest_sack accessing & point to next skb

2007-12-01 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]> Pointing to the next skb is necessary to avoid referencing already SACKed skbs which will soon be on a separate list. Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- include/net/tcp.h | 35 ++-

[PATCH 12/21] [TCP]: Introduce per skb fack_counts to retransmit queue

2007-12-01 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]> The fack count of any skb in the retransmit queue at any given point in time is: (skb->fack_count - head_skb->fack_count) And we'll use this in the SACK processing loops and possibly elsewhere too. Original idea came from David S. M

[PATCH 07/21] [TCP]: Add tcp_for_write_queue_from_safe and use it in mtu_probe

2007-12-01 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]> Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- include/net/tcp.h |5 + net/ipv4/tcp_output.c |8 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/include/net/tcp.h b/include/net/tcp.h index cdd

[PATCH 08/21] [TCP]: Remove duplicated code block from clean_rtx_queue

2007-12-01 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]> Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- net/ipv4/tcp_input.c | 48 1 files changed, 20 insertions(+), 28 deletions(-) diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.

[PATCH 10/21] [TCP]: Cleanup local variables of clean_rtx_queue

2007-12-01 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]> Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- net/ipv4/tcp_input.c | 26 -- 1 files changed, 12 insertions(+), 14 deletions(-) diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 365c6d4..a43c8

[PATCH 09/21] [TCP]: Add unlikely() to urgent handling in clean_rtx_queue

2007-12-01 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]> Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- net/ipv4/tcp_input.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 3f0b6c7..365c6d4 100644 --- a/net/ipv4

[PATCH 05/21] [TCP] MTUprobe: prepare skb fields earlier

2007-12-01 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]> They better be valid when call to write_queue functions is made once things that follow are going in. Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- net/ipv4/tcp_output.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)

[PATCH 03/21] [TCP]: Unite identical code from two seqno split blocks

2007-12-01 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]> Bogus seqno compares just mislead, the code is identical for both sides of the seqno compare (and was even executed just once because of return in between). Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- net/ipv4/tcp_input.c |7

[PATCH 04/21] [TCP] Cong.ctrl modules: remove unused good_ack from cong_avoid

2007-12-01 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]> Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- include/net/tcp.h|4 ++-- net/ipv4/tcp_bic.c |3 +-- net/ipv4/tcp_cong.c |2 +- net/ipv4/tcp_cubic.c |3 +-- net/ipv4/tcp_highspeed.c |3 +--

[PATCH 02/21] [TCP]: Remove superflucious FLAG_DATA_SACKED

2007-12-01 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]> To get there, highest_sack must have advanced. When it advances, a new skb is SACKed, which already sets that FLAG. Besides, the original purpose of it has puzzled me, never understood why LOST bit setting of retransmitted skb is marked wi

[RFC PATCH net-2.6.25 0/21]: TCP tweaks & RB-tree WIP preview

2007-12-01 Thread Ilpo Järvinen
Hi all, First, there are some rather trivial ones (up to [TCP]: Cleanup local variables of clean _rtx_queue)... They're followed by my current efforts to improve SACK processing latencies with large windows, including RB-tree for fast searching, problem space split to provide tight bounds that re

[PATCH 01/21] [TCP]: Move LOSTRETRANS MIB outside !(L|S) check

2007-12-01 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]> Usually those skbs will have L set, not counting them as lost retransmissions is misleading. Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- net/ipv4/tcp_input.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --gi

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-12-01 Thread Vitaly Bordug
On Sun, 2 Dec 2007 00:34:03 +0300 Anton Vorontsov wrote: > > If i understand your code correctly, you seem to rely on the fact > > that fixed_phy_add() is called before the fixed MDIO bus is scanned > > for devices. > > Yes, indeed. The other name of "fixed phys" are "platform phys" > or "plat

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-12-01 Thread Vitaly Bordug
On Sat, 01 Dec 2007 16:59:52 -0500 Jeff Garzik wrote: > Vitaly Bordug wrote: > > With that patch fixed.c now fully emulates MDIO bus, thus no need > > to duplicate PHY layer functionality. That, in turn, drastically > > simplifies the code, and drops down line count. > > > > As an additional bonu

Re: namespace support requires network modules to say "GPL"

2007-12-01 Thread Mark Lord
Arjan van de Ven wrote: On Sat, 01 Dec 2007 15:21:12 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: Eric W. Biederman wrote: Stephen Hemminger <[EMAIL PROTECTED]> writes: Sure. We keep the updated dev_get_by_ that takes a network namespace parameter. .. And what should code be passing in wh

Re: namespace support requires network modules to say "GPL"

2007-12-01 Thread Mark Lord
Arjan van de Ven wrote: On Sat, 01 Dec 2007 15:21:12 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: Eric W. Biederman wrote: Stephen Hemminger <[EMAIL PROTECTED]> writes: Sure. We keep the updated dev_get_by_ that takes a network namespace parameter. .. And what should code be passing in wh

Re: [PATCHv7 iproute2 2/2] Interface group as new ip link option

2007-12-01 Thread Jarek Poplawski
Laszlo Attila Toth wrote, On 11/29/2007 05:11 PM: > Interfaces can be grouped and each group has an unique positive integer ID. > It can be set via ip link. Symbolic names can be specified in > /etc/iproute2/rt_ifgroup. Any value of unsigned int32 is valid. ... > diff --git a/lib/rt_names.c b/li

Re: Fw: [PATCH] Add the phy_device_release device method.

2007-12-01 Thread Jeff Garzik
Thierry, could you resend this patch to me? I do not seem to have an apply-able version of this patch anywhere. The copy DaveM forwarded to me had problems (though the technical content looks OK) Thanks, Jeff -- To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-12-01 Thread Jeff Garzik
Vitaly Bordug wrote: With that patch fixed.c now fully emulates MDIO bus, thus no need to duplicate PHY layer functionality. That, in turn, drastically simplifies the code, and drops down line count. As an additional bonus, now there is no need to register MDIO bus for each PHY, all emulated PHY

Re: [PATCH] ethtool: fix typo on setting speed 10000

2007-12-01 Thread Jeff Garzik
Auke Kok wrote: From: Jesse Brandeburg <[EMAIL PROTECTED]> fix the typo in speed 1 setting. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- ethtool.c |2 +- applied -- To unsubscribe from this list: send the line "unsubscribe netd

Re: Pull request for 'r6040' branch

2007-12-01 Thread Jeff Garzik
Francois Romieu wrote: Please pull from branch 'r6040' in repository git://git.kernel.org/pub/scm/linux/kernel/git/romieu/netdev-2.6.git r6040 to get the changes below. Distance from 'netdev-2.6-upstream' (02e063b58b7c7084bae3d599c54dcf26c8efa9b7) --

Re: [PATCH] SGISEEQ: use cached memory access to make driver work on IP28

2007-12-01 Thread Jeff Garzik
Thomas Bogendoerfer wrote: Following patch is clearly 2.6.25 material and is needed to get SGI IP28 machines supported. Thomas. SGI IP28 machines would need special treatment (enable adding addtional wait states) when accessing memory uncached. To avoid this pain I changed the driver to use onl

Re: [PATCH] [1/12] pasemi_mac: RX/TX ring management cleanup

2007-12-01 Thread Jeff Garzik
Olof Johansson wrote: pasemi_mac: RX/TX ring management cleanup Prepare a bit for supporting multiple TX queues by cleaning up some of the ring management and shuffle things around a bit. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> applied 1-12 -- To unsubscribe from this list: send t

Re: [PATCH 1/2] sky2: align IP header on Rx if possible

2007-12-01 Thread Jeff Garzik
Stephen Hemminger wrote: The sky2 driver was not aligning the IP header on receive buffers. This workaround is only needed on hardware with broken FIFO, newer chips without FIFO can just DMA to unaligned address. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> applied 1-2 -- To unsubscr

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-12-01 Thread Anton Vorontsov
On Sat, Dec 01, 2007 at 02:48:54PM +0100, Jochen Friedrich wrote: > Hi Vitaly, > > > With that patch fixed.c now fully emulates MDIO bus, thus no need > > to duplicate PHY layer functionality. That, in turn, drastically > > simplifies the code, and drops down line count. > > > > As an additional b

Re: [PATCH] LIB82596: correct data types for hardware addresses

2007-12-01 Thread Jeff Garzik
Thomas Bogendoerfer wrote: dma_addr_t is 64bit wide on some architectures (for example 64bit MIPS), so it's not a good idea to use it for 32bit wide addresses in descriptors. Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]> --- drivers/net/lib82596.c | 50 --

Re: [PATCH] via-velocity: don't oops on MTU change (resend)

2007-12-01 Thread Jeff Garzik
Stephen Hemminger wrote: The VIA veloicty driver needs the following to allow changing MTU when down. The buffer size needs to be computed when device is brought up, not when device is initialized. This also fixes a bug where the buffer size was computed differently on change_mtu versus initial

Re: [PATCH] Stop phy code from returning success to unknown ioctls.

2007-12-01 Thread Jeff Garzik
David Woodhouse wrote: This kind of sucks, and prevents the Fedora installer from using the device for network installs... [EMAIL PROTECTED] phy]# iwconfig eth0 Warning: Driver for dev

Re: [PATCH] SET_NETDEV_DEV() in fec_mpc52xx.c

2007-12-01 Thread Jeff Garzik
David Woodhouse wrote: This helps to allow the Fedora installer to use the built-in Ethernet on the Efika for a network install. Signed-off-by: David Woodhouse <[EMAIL PROTECTED]> --- a/drivers/net/fec_mpc52xx.c +++ b/drivers/net/fec_mpc52xx.c @@ -971,6 +971,8 @@ mpc52xx_fec_probe(struct of_dev

Re: [PATCH] e1000: Fix NAPI state bug when Rx complete

2007-12-01 Thread Jeff Garzik
Auke Kok wrote: Don't exit polling when we have not yet used our budget, this causes the NAPI system to end up with a messed up poll list. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dr

Re: [PATCH 1/3] sky2: revert to access PCI config via device space

2007-12-01 Thread Jeff Garzik
Stephen Hemminger wrote: Using the hardware window into PCI config space is more reliable and smaller/faster than using the pci_config routines. It avoids issues with MMCONFIG etc. Reverts: 167f53d05fccb47b6eeadac7f6705b3f2f042d03 Please apply for 2.6.24 Signed-off-by: Stephen Hemminger <[EMAI

Re: [PATCH 1/3] cxgb - fix T2 GSO

2007-12-01 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> The patch ensures that a GSO skb has enough headroom to push an encapsulating cpl_tx_pkt_lso header. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- applied 1-3 -- To unsubscribe from this list: send the line "unsubscribe netdev" i

Re: [PATCH 1/3][RESEND] phylib: add PHY interface modes for internal delay for tx and rx only

2007-12-01 Thread Jeff Garzik
Kim Phillips wrote: Allow phylib specification of cases where hardware needs to configure PHYs for Internal Delay only on either RX or TX (not both). Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> Tested-by: Anton Vorontsov <[EMAIL PROTECTED]> Acked-by: Li Yang <[EMAIL PROTECTED]> --- include/

Re: [PATCH 1/6] skge: FIFO Ram calculation error

2007-12-01 Thread Jeff Garzik
applied 1-6 and additional 1-2 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 1/1] ctc: make use of alloc_netdev()

2007-12-01 Thread Jeff Garzik
applied -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2.6.24 1/1]S2io: Fixed the case when the card initialization fails on mtu change

2007-12-01 Thread Jeff Garzik
Sreenivasa Honnur wrote: Fix the case when the card initialization fails on a mtu change and then close is called (due to ifdown), which frees non existent rx buffers. - Returning appropriate error codes in init_nic function. - In s2io_close function s2io_card_down is called only when device is

Re: [PATCHv7 iptables] Interface group match

2007-12-01 Thread Jarek Poplawski
Jarek Poplawski wrote, On 12/01/2007 10:19 PM: > Laszlo Attila Toth wrote, On 11/29/2007 05:11 PM: > ... > >> Index: extensions/libxt_ifgroup.man ... >> +Valid only in the in the +Valid only in the >> +.B FORWARD >> +and >> +.B OUTPUT >> +and >> +.B POSTROUTING >> +chains, and user-define

Re: Please pull 'fixes-jgarzik' branch of wireless-2.6

2007-12-01 Thread Jeff Garzik
John W. Linville wrote: Jeff, A few fixes intended for 2.6.24... Let me know if there are any problems! Thanks, John --- Individual patches are available here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6.git fixes-jgarzik --- The following changes since c

Re: [PATCHv7 iptables] Interface group match

2007-12-01 Thread Jarek Poplawski
Laszlo Attila Toth wrote, On 11/29/2007 05:11 PM: ... > Index: extensions/libxt_ifgroup.man > === > --- extensions/libxt_ifgroup.man (revision 0) > +++ extensions/libxt_ifgroup.man (revision 0) > @@ -0,0 +1,36 @@ > +Maches p

Re: namespace support requires network modules to say "GPL"

2007-12-01 Thread Eric W. Biederman
Mark Lord <[EMAIL PROTECTED]> writes: >>> Can we get this resolved before 2.6.24 is released? Going back and forth >>> on API's is just needless frottage. >> >> Sure. We keep the updated dev_get_by_ that takes a network >> namespace parameter. > .. > > And what should code be passing in when

Re: namespace support requires network modules to say "GPL"

2007-12-01 Thread Arjan van de Ven
On Sat, 01 Dec 2007 15:21:12 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: > Eric W. Biederman wrote: > > Stephen Hemminger <[EMAIL PROTECTED]> writes: > > Sure. We keep the updated dev_get_by_ that takes a network > > namespace parameter. > .. > > And what should code be passing in when "# CON

Re: SSB: No is not an answer

2007-12-01 Thread Michael Buesch
On Saturday 01 December 2007 20:00:23 Arnaldo Carvalho de Melo wrote: > Em Sat, Dec 01, 2007 at 12:45:32PM -0500, John W. Linville escreveu: > > On Sat, Dec 01, 2007 at 03:17:44PM -0200, Arnaldo Carvalho de Melo wrote: > > > Sonics Silicon Backplane support (SSB) [M/y/?] (NEW) n > > > > > > Suppor

Re: namespace support requires network modules to say "GPL"

2007-12-01 Thread Mark Lord
Eric W. Biederman wrote: Stephen Hemminger <[EMAIL PROTECTED]> writes: Actually, the whole mess would go away if the api for dev_get_by_ hadn't been changed in the namespace transition. IMHO the interface to dev_get_by_name() should not have added a namespace parameter, of the callers in th

Re: namespace support requires network modules to say "GPL"

2007-12-01 Thread Eric W. Biederman
Stephen Hemminger <[EMAIL PROTECTED]> writes: > Actually, the whole mess would go away if the api for dev_get_by_ hadn't > been changed in the namespace transition. IMHO the interface to > dev_get_by_name() > should not have added a namespace parameter, of the callers in the tree, only > two u

Re: namespace support requires network modules to say "GPL"

2007-12-01 Thread Eric W. Biederman
Stephen Hemminger <[EMAIL PROTECTED]> writes: > On Sat, 01 Dec 2007 08:10:17 -0500 > Mark Lord <[EMAIL PROTECTED]> wrote: > >> > Now that we have network namespace support merged it is time to >> > revisit the sysfs support so we can remove the dependency on !SYSFS. >> ... >> >> Now that the name

Re: namespace support requires network modules to say "GPL"

2007-12-01 Thread Alan Cox
> Then change the license, explicitly and get it approved, forcing license > changes by technically subversive means is bad policy. It is like Euro > bureaucrats I don't need to - the licence has been the same since about 0.12 Alan -- To unsubscribe from this list: send the line "unsubscribe net

Re: namespace support requires network modules to say "GPL"

2007-12-01 Thread Stephen Hemminger
On Sat, 1 Dec 2007 19:23:41 + Alan Cox <[EMAIL PROTECTED]> wrote: > > Then init_net needs to be not GPL limited. Sorry, we need to allow > > non GPL network drivers. There is a fine line between keeping the > > Why - they aren't exactly likely to be permissible by law Matter of debate in wh

Re: [PATCH 4/4 (resent) net-2.6.25][UNIX] Make the unix sysctl tables per-namespace

2007-12-01 Thread Eric W. Biederman
Pavel Emelyanov <[EMAIL PROTECTED]> writes: >>> But I gotta say this struct/file is going to be enormous. It's also >>> one of those files that causes everything to get recompiled. Maybe >>> we ought to make a rule that each subsystem only gets to have at most >>> one entry in it :) >>> >>> Than

Re: namespace support requires network modules to say "GPL"

2007-12-01 Thread Alan Cox
> Then init_net needs to be not GPL limited. Sorry, we need to allow > non GPL network drivers. There is a fine line between keeping the Why - they aren't exactly likely to be permissible by law > binary seething masses from accessing random kernel functions, and allowing > reasonable (but still

Re: Mcast packet loss 2.6.8.1 kernel

2007-12-01 Thread Bernd Eckenfels
On Fri, Nov 16, 2007 at 12:38:22PM +0100, Eric Dumazet wrote: > Hello Bernd > > I did some investigations on the "netstat -s" problem and one > fix is to change the size of char buf1[1024], buf2[1024]; I changed it now to 2048, and included your page aligend io buffer patch. It is available in n

Re: namespace support requires network modules to say "GPL"

2007-12-01 Thread Stephen Hemminger
On Sat, 01 Dec 2007 08:10:17 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: > > Now that we have network namespace support merged it is time to > > revisit the sysfs support so we can remove the dependency on !SYSFS. > ... > > Now that the namespace updates are part of 2.6.24, > there is a major inco

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-12-01 Thread Vitaly Bordug
On Sat, 01 Dec 2007 14:48:54 +0100 Jochen Friedrich wrote: > Hi Vitaly, > > > With that patch fixed.c now fully emulates MDIO bus, thus no need > > to duplicate PHY layer functionality. That, in turn, drastically > > simplifies the code, and drops down line count. > > > > As an additional bonus,

Re: SSB: No is not an answer

2007-12-01 Thread Arnaldo Carvalho de Melo
Em Sat, Dec 01, 2007 at 12:45:32PM -0500, John W. Linville escreveu: > On Sat, Dec 01, 2007 at 03:17:44PM -0200, Arnaldo Carvalho de Melo wrote: > > Sonics Silicon Backplane support (SSB) [M/y/?] (NEW) n > > > > Support for the Sonics Silicon Backplane bus. > > You only need to enable this option,

Re: SSB: No is not an answer

2007-12-01 Thread John W. Linville
On Sat, Dec 01, 2007 at 03:17:44PM -0200, Arnaldo Carvalho de Melo wrote: > Sonics Silicon Backplane support (SSB) [M/y/?] (NEW) n > > Support for the Sonics Silicon Backplane bus. > You only need to enable this option, if you are > configuring a kernel for an embedded system with > this bus. > It

SSB: No is not an answer

2007-12-01 Thread Arnaldo Carvalho de Melo
Sonics Silicon Backplane support (SSB) [M/y/?] (NEW) n Support for the Sonics Silicon Backplane bus. You only need to enable this option, if you are configuring a kernel for an embedded system with this bus. It will be auto-selected if needed in other environments. The module will be called ssb.

Re: [PATCH net-2.6.25 (resend) 3/3][IPV6] Use ctl paths to register addrconf sysctls

2007-12-01 Thread Herbert Xu
On Sat, Dec 01, 2007 at 04:46:41PM +0300, Pavel Emelyanov wrote: > This looks very much like the patch for ipv4's devinet. > > This is also intended to help us with the net namespaces > and saves the ipv6.ko size by ~320 bytes. > > The difference from the first version is just the patch > offsets

Re: [PATCH net-2.6.25 (resend) 3/3][IPV4] Use ctl paths to register devinet sysctls

2007-12-01 Thread Herbert Xu
On Sat, Dec 01, 2007 at 04:39:58PM +0300, Pavel Emelyanov wrote: > > The difference from the first version is just the patch > offsets, that changed due to changes in the patch #2. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> All applied to net-2.6.25. Thanks Pavel. -- Visit Openswan

Re: Please pull 'upstream-davem' branch of wireless-2.6

2007-12-01 Thread Herbert Xu
On Fri, Nov 30, 2007 at 09:23:06PM -0500, John W. Linville wrote: > Dave/Herbert, > > Here are a few intended for 2.6.25. The bulk of them are the beginnings > of support for 802.11n in mac80211. There is also a rework of the > support for devices which can run scans in hardware, and a couple of

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-12-01 Thread Jochen Friedrich
Hi Vitaly, With that patch fixed.c now fully emulates MDIO bus, thus no need to duplicate PHY layer functionality. That, in turn, drastically simplifies the code, and drops down line count. As an additional bonus, now there is no need to register MDIO bus for each PHY, all emulated PHYs placed

[PATCH net-2.6.25 (resend) 3/3][IPV6] Use ctl paths to register addrconf sysctls

2007-12-01 Thread Pavel Emelyanov
This looks very much like the patch for ipv4's devinet. This is also intended to help us with the net namespaces and saves the ipv6.ko size by ~320 bytes. The difference from the first version is just the patch offsets, that changed due to changes in the patch #2. Signed-off-by: Pavel Emelyanov

[PATCH net-2.6.25 (resend) 2/3][IPV6] Unify and cleanup calls to addrconf_sysctl_register

2007-12-01 Thread Pavel Emelyanov
Currently this call is (ab)used similar to devinet one - it registers sysctls for devices and for the "default" confs, while the "all" sysctls are registered separately. But unlike its devinet brother, the passed inet6_device is needed. The fix is to make a __addrconf_sysctl_register(), which re

Re: [PATCH 4/4 (resent) net-2.6.25][UNIX] Make the unix sysctl tables per-namespace

2007-12-01 Thread Denis V. Lunev
Herbert Xu wrote: > On Fri, Nov 30, 2007 at 07:37:28PM +0300, Pavel Emelyanov wrote: >> Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> > > All applied to net-2.6.25. > >> diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h >> index b0cf075..f97b2a4 100644 >> --- a/include/n

[PATCH net-2.6.25 (resend) 3/3][IPV4] Use ctl paths to register devinet sysctls

2007-12-01 Thread Pavel Emelyanov
This looks very much like the patch for neighbors. The path is also located on the stack and is prepared inside the function. This time, the call to the registering function is guarded with the RTNL lock, but I decided to keep it on the stack not to litter the devinet.c file with unneeded names an

[PATCH net-2.6.25 (resend) 2/3][IPV4] Unify and cleanup calls to devinet_sysctl_register

2007-12-01 Thread Pavel Emelyanov
Currently this call is used to register sysctls for devices and for the "default" confs. The "all" sysctls are registered separately. Besides, the inet_device is passed to this function, but it is not needed there at all - just the device name and ifindex are required. Thanks to Herbert, who no

Re: [PATCH net-2.6.25 2/3][IPV4] Unify and cleanup calls to devinet_sysctl_register

2007-12-01 Thread Herbert Xu
On Sat, Dec 01, 2007 at 04:25:21PM +0300, Pavel Emelyanov wrote: > > > How about just giving it in_dev instead? > > Hmm... Makes sense. Should I recreate the while set or > just make the incremental one? I've applied 1/3 for both cases so please just resend 2/3 and 3/3. Thanks, -- Visit Openswa

Re: [PATCH net-2.6.25 2/3][IPV4] Unify and cleanup calls to devinet_sysctl_register

2007-12-01 Thread Pavel Emelyanov
Herbert Xu wrote: > On Fri, Nov 30, 2007 at 09:26:58PM +0300, Pavel Emelyanov wrote: >> Besides, the inet_device is passed to this function, but >> it is not needed there at all - just the device name and >> ifindex are required. > > But it is called devinet_* so an in_dev kind of makes sense :) >

Re: [PATCH net-2.6.25 2/3][IPV6] Unify and cleanup calls to addrconf_sysctl_register

2007-12-01 Thread Herbert Xu
On Fri, Nov 30, 2007 at 09:54:51PM +0300, Pavel Emelyanov wrote: > > +static void addrconf_sysctl_register(struct inet6_dev *idev, > + struct ipv6_devconf *p) Due to your simplification you no longer need the second argument as it can now be derived from the first as is the case for IP

Re: [PATCH 4/4 (resent) net-2.6.25][UNIX] Make the unix sysctl tables per-namespace

2007-12-01 Thread Pavel Emelyanov
Denis V. Lunev wrote: > Herbert Xu wrote: >> On Fri, Nov 30, 2007 at 07:37:28PM +0300, Pavel Emelyanov wrote: >>> Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> >> All applied to net-2.6.25. >> >>> diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h >>> index b0cf075..f97b2a4

Re: [PATCH net-2.6.25 2/3][IPV4] Unify and cleanup calls to devinet_sysctl_register

2007-12-01 Thread Herbert Xu
On Fri, Nov 30, 2007 at 09:26:58PM +0300, Pavel Emelyanov wrote: > > Besides, the inet_device is passed to this function, but > it is not needed there at all - just the device name and > ifindex are required. But it is called devinet_* so an in_dev kind of makes sense :) > #ifdef CONFIG_SYSCTL

Re: [PATCH net-2.6.25 1/3][IPV4] Cleanup the devinet_sysctl_register

2007-12-01 Thread Herbert Xu
On Fri, Nov 30, 2007 at 09:21:00PM +0300, Pavel Emelyanov wrote: > I moved the call to kmalloc() from the *t declaration into > the code (this is confusing when a variable is initialized > with the result of some call) and removed unneeded comment > near the error path. Just like I did with the n

  1   2   >