Re: NAPI poll behavior in various Intel drivers

2008-01-07 Thread Jarek Poplawski
On 04-01-2008 12:40, David Miller wrote: ... That tx_cleaned thing clouds the logic in all of these driver's poll routines. The one necessary precondition is that when work_done budget we exit polling and return a value less than budget. If the -poll() returns a value less than budget,

Re: [PATCH 3/4] [XFRM]: Kill some bloat

2008-01-07 Thread Ilpo Järvinen
On Sun, 6 Jan 2008, Herbert Xu wrote: is definitely not a fast path. If a function ends up being called just once the compiler will most likely inline it anyway, making the use of the keyword inline redundant. Unexpected enough, even this logic seems to fail in a way with my gcc, I'm yet to

Re: [PATCH net-2.6.24][ATM]: [nicstar] delay irq setup until card is configured

2008-01-07 Thread David Miller
From: chas williams - CONTRACTOR [EMAIL PROTECTED] Date: Fri, 04 Jan 2008 16:29:15 -0500 [ATM]: [nicstar] delay irq setup until card is configured Signed-off-by: Chas Williams [EMAIL PROTECTED] Applied, thanks Chas. -- To unsubscribe from this list: send the line unsubscribe netdev in the

Re: [PATCH 1/3] [SCTP]: Fix the name of the authentication event.

2008-01-07 Thread David Miller
From: Vlad Yasevich [EMAIL PROTECTED] Date: Fri, 4 Jan 2008 14:45:44 -0500 The even should be called SCTP_AUTHENTICATION_INDICATION. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] Applied. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH 2/3] [SCTP]: Correctly handle AUTH parameters in unexpected INIT

2008-01-07 Thread David Miller
From: Vlad Yasevich [EMAIL PROTECTED] Date: Fri, 4 Jan 2008 14:45:45 -0500 When processing an unexpected INIT chunk, we do not need to do any preservation of the old AUTH parameters. In fact, doing such preservations will nullify AUTH and allow connection stealing. Signed-off-by: Vlad

Re: [PATCH 3/3] [SCTP]: Add back the code that accounted for FORWARD_TSN parameter in INIT.

2008-01-07 Thread David Miller
From: Vlad Yasevich [EMAIL PROTECTED] Date: Fri, 4 Jan 2008 14:45:46 -0500 Some recent changes completely removed accounting for the FORWARD_TSN parameter length in the INIT and INIT-ACK chunk. This is wrong and should be restored. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] Also

Re: [PATCH] IRDA: irda_create() nuke user triggable printk

2008-01-07 Thread David Miller
From: maximilian attems [EMAIL PROTECTED] Date: Mon, 7 Jan 2008 01:34:32 +0100 easy to trigger as user with sfuzz. irda_create() is quiet on unknown sock-type, match this behaviour for SOCK_DGRAM unknown protocol Signed-off-by: maximilian attems [EMAIL PROTECTED] Applied, thanks. -- To

Re: 2.6.24-rc6 oops in net_tx_action

2008-01-07 Thread David Miller
From: [EMAIL PROTECTED] Date: 7 Jan 2008 01:43:50 -0500 Thanks! I got the patch from http://marc.info/?l=linux-netdevm=119756785219214 (Which didn't make it into -rc7; please fix!) and am recompiling now. Jeff is busy so he's asked me to pick up the more important driver bug fixes that get

Re: [PATCH 3/4] [XFRM]: Kill some bloat

2008-01-07 Thread Herbert Xu
On Mon, Jan 07, 2008 at 10:21:47AM +0200, Ilpo Järvinen wrote: Unexpected enough, even this logic seems to fail in a way with my gcc, I'm yet to study it closer but it seems to me that e.g., uninlining only once called tcp_fastretrans_alert is worth of at least 100 bytes (note that it's

[PACKET]: Fix sparse warnings in af_packet.c

2008-01-07 Thread Eric Dumazet
CHECK net/packet/af_packet.c net/packet/af_packet.c:1876:14: warning: context imbalance in 'packet_seq_start' - wrong count at exit net/packet/af_packet.c:1888:13: warning: context imbalance in 'packet_seq_stop' - unexpected unlock Signed-off-by: Eric Dumazet [EMAIL PROTECTED] diff --git

[IPV4] ROUTE: Avoid sparse warnings

2008-01-07 Thread Eric Dumazet
CHECK net/ipv4/route.c net/ipv4/route.c:298:2: warning: context imbalance in 'rt_cache_get_first' - wrong count at exit net/ipv4/route.c:307:3: warning: context imbalance in 'rt_cache_get_next' - unexpected unlock net/ipv4/route.c:346:3: warning: context imbalance in 'rt_cache_seq_stop' -

Re: forcedeth: MAC-address reversed on resume from suspend

2008-01-07 Thread Adolfo R. Brandes
Hi, On Jan 6, 2008 10:46 PM, Björn Steinbrink [EMAIL PROTECTED] wrote: Any chance that you applied the patch on your modified sources and didn't get it right? It is perfectly possible that I messed something up, although I double checked what I was doing on the MCP51. However, on that

Re: [IPV4] ROUTE: Avoid sparse warnings

2008-01-07 Thread Herbert Xu
Eric Dumazet [EMAIL PROTECTED] wrote: CHECK net/ipv4/route.c net/ipv4/route.c:298:2: warning: context imbalance in 'rt_cache_get_first' - wrong count at exit net/ipv4/route.c:307:3: warning: context imbalance in 'rt_cache_get_next' - unexpected unlock net/ipv4/route.c:346:3: warning:

Re: [git patches] net driver fixes

2008-01-07 Thread Meelis Roos
JG A couple [minorly] notable wireless bug fixes, and plenty of viro fixes JG for obscure issues :) What about the tulip NAPI fix from Stephen Hemminger? Without this, my tulip is hosed easily. The thread where I reported it was Badness at net/core/dev.c:2199, around Dec 16.

[PATCH][LRO] Fix lro_mgr-features checks

2008-01-07 Thread Brice Goglin
Hi Dave, The LRO_F_* checks in inet_lro.c are buggy, the following patch is needed to check lro_mgr-features correctly. I decided to follow the NETIF_F_* convention and thus removed test_bit. Some people might like it better if we keep using test_bit and just set lro_mgr-features to 1LRO_F_NAPI

Re: [IPV4] ROUTE: Avoid sparse warnings

2008-01-07 Thread Eric Dumazet
On Mon, 07 Jan 2008 23:11:53 +1100 Herbert Xu [EMAIL PROTECTED] wrote: Eric Dumazet [EMAIL PROTECTED] wrote: CHECK net/ipv4/route.c net/ipv4/route.c:298:2: warning: context imbalance in 'rt_cache_get_first' - wrong count at exit net/ipv4/route.c:307:3: warning: context imbalance in

Re: [patch 5/9][NETNS][IPV6] make bindv6only sysctl per namespace

2008-01-07 Thread Benjamin Thery
Daniel, The kernel fails to build with this patch applied when CONFIG_SYSCTL=n See comment below. Daniel Lezcano wrote: This patch moves the bindv6only sysctl to the network namespace structure. Until the ipv6 protocol is not per namespace, the sysctl variable is always from the initial

Re: [patch 5/9][NETNS][IPV6] make bindv6only sysctl per namespace

2008-01-07 Thread Eric Dumazet
On Mon, 07 Jan 2008 17:36:35 +0100 Daniel Lezcano [EMAIL PROTECTED] wrote: Benjamin Thery wrote: Daniel, The kernel fails to build with this patch applied when CONFIG_SYSCTL=n See comment below. Daniel Lezcano wrote: This patch moves the bindv6only sysctl to the network namespace

Re: [patch 5/9][NETNS][IPV6] make bindv6only sysctl per namespace

2008-01-07 Thread Daniel Lezcano
Benjamin Thery wrote: Daniel, The kernel fails to build with this patch applied when CONFIG_SYSCTL=n See comment below. Daniel Lezcano wrote: This patch moves the bindv6only sysctl to the network namespace structure. Until the ipv6 protocol is not per namespace, the sysctl variable is always

[DCCP] [Announce]: Test tree updates

2008-01-07 Thread Gerrit Renker
This is an edited list of recent changes in the test tree git://eden-feed.erg.abdn.ac.uk/dccp_exp At the top of each block is the name of the patch, followed by a short description of the change, and the actual (or abridged if obvious) inter-diff. Some of these changes refer to

[PATCH 2/3] ethtool: update license field in specfile to be correctly defined

2008-01-07 Thread Auke Kok
RPM uses License as field and not Copyright. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- ethtool.spec.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ethtool.spec.in b/ethtool.spec.in index 1705d7f..4ff736a 100644

[PATCH 3/3] ethtool: correct man page for advertise mask value of 10gig

2008-01-07 Thread Auke Kok
10 gigabit is defined as 0x1000 in the advertise mask. The man page mistakenly lists 0x800. Signed-off-by: Auke Kok [EMAIL PROTECTED] --- ethtool.8 |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ethtool.8 b/ethtool.8 index af51056..cc6a46e 100644 --- a/ethtool.8 +++

[PATCH 1/3] ethtool: fix typo on setting speed 10000

2008-01-07 Thread Auke Kok
From: Jesse Brandeburg [EMAIL PROTECTED] fix the typo in speed 1 setting. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- ethtool.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ethtool.c b/ethtool.c index

Re: [PATCH] [IPv6]: IPV6_MULTICAST_IF setting is ignored on link-local connect()

2008-01-07 Thread Brian Haley
David Stevens wrote: Yeah, that's what I get for typing in off-the-cuff code. What I was thinking was the fl.oif assignment instead was: if (!sk-sk_bound_dev_if (addr_type IPV6_ADDR_MULTICAST)) sk-sk_bound_dev_if = np-mcast_oif; Which it

Re: Top 10 kernel oopses for the week ending January 5th, 2008

2008-01-07 Thread J. Bruce Fields
On Sat, Jan 05, 2008 at 09:39:35PM +, Al Viro wrote: On Sat, Jan 05, 2008 at 01:06:17PM -0800, Arjan van de Ven wrote: The http://www.kerneloops.org website collects kernel oops and warning reports from various mailing lists and bugzillas as well as with a client users can install to

Re: Atheros driver

2008-01-07 Thread Luis R. Rodriguez
On Jan 6, 2008 4:21 PM, John W. Linville [EMAIL PROTECTED] wrote: On Sun, Jan 06, 2008 at 09:04:02PM +0100, Ralph Spitzner wrote: With Kernel 2.6.23.12 ath5k I get this: -- Jan 6 20:42:44 meepmeep kernel: CPU:0 Jan

[RFC PATCH v2 0/2] Labeled networking core stack changes for 2.6.25

2008-01-07 Thread Paul Moore
Take #2 ... Once again, two patches. The first should be familiar as it is the same patch as before with feedback taken into account. The second patch is most likely new to the netdev crowd as it consists of the SELinux changes necessary to implement the network ingress/egress controls I talked

[RFC PATCH v2 1/2] NET: Clone the sk_buff 'iif' field in __skb_clone()

2008-01-07 Thread Paul Moore
Both NetLabel and SELinux (other LSMs may grow to use it as well) rely on the 'iif' field to determine the receiving network interface of inbound packets. Unfortunately, at present this field is not preserved across a skb clone operation which can lead to garbage values if the cloned skb is sent

[RFC PATCH v2 2/2] SELinux: Add network ingress and egress control permission checks

2008-01-07 Thread Paul Moore
This patch implements packet ingress/egress controls for SELinux which allow SELinux security policy to control the flow of all IPv4 and IPv6 packets into and out of the system. Currently SELinux does not have proper control over forwarded packets and this patch corrects this problem. Special

[PATCH] AX25: nuke user trigable printks

2008-01-07 Thread maximilian attems
sfuzz trigerrs any of those printk easily. things that should have gone in early 2.5.x aka years ago should not be thrown so easily to the user. Signed-off-by: maximilian attems [EMAIL PROTECTED] --- net/ax25/af_ax25.c | 15 +++ 1 files changed, 3 insertions(+), 12 deletions(-)

Re: [Bugme-new] [Bug 9543] New: RTNL: assertion failed at net/ipv6/addrconf.c (2164)/RTNL: assertion failed at net/ipv4/devinet.c (1055)

2008-01-07 Thread Krzysztof Oledzki
On Wed, 19 Dec 2007, Andy Gospodarek wrote: On Tue, Dec 18, 2007 at 08:53:39PM +0100, Krzysztof Oledzki wrote: On Fri, 14 Dec 2007, Andy Gospodarek wrote: On Fri, Dec 14, 2007 at 07:57:42PM +0100, Krzysztof Oledzki wrote: On Fri, 14 Dec 2007, Andy Gospodarek wrote: On Fri, Dec 14,

[IPV4] ROUTE: ip_rt_dump() is unecessary slow

2008-01-07 Thread Eric Dumazet
I noticed ip route list cache x.y.z.t can be *very* slow. While strace-ing -T it I also noticed that first part of route cache is fetched quite fast : recvmsg(3, {msg_name(12)={sa_family=AF_NETLINK, pid=0, groups=}, msg_iov(1)=[{p\0\0\0\30\0\2\0\254i\202 GXm\0\0\2

Re: 2.6.24-rc6 oops in net_tx_action

2008-01-07 Thread linux
Thanks! I got the patch from http://marc.info/?l=linux-netdevm=119756785219214 (Which didn't make it into -rc7; please fix!) and am recompiling now. Jeff is busy so he's asked me to pick up the more important driver bug fixes that get posted. I'll push this around, thanks. Much obliged.

Re: [Bugme-new] [Bug 9543] New: RTNL: assertion failed at net/ipv6/addrconf.c (2164)/RTNL: assertion failed at net/ipv4/devinet.c (1055)

2008-01-07 Thread Andy Gospodarek
On Mon, Jan 07, 2008 at 06:57:25PM +0100, Krzysztof Oledzki wrote: On Wed, 19 Dec 2007, Andy Gospodarek wrote: On Tue, Dec 18, 2007 at 08:53:39PM +0100, Krzysztof Oledzki wrote: On Fri, 14 Dec 2007, Andy Gospodarek wrote: On Fri, Dec 14, 2007 at 07:57:42PM +0100, Krzysztof Oledzki

Re: [IPV4] ROUTE: Avoid sparse warnings

2008-01-07 Thread Herbert Xu
On Mon, Jan 07, 2008 at 02:56:24PM +0100, Eric Dumazet wrote: AFAIK, this patch reduces complexity and text size. But if we had loads of empty hash buckets couldn't this potentially increase latency by disabling BH longer than before? Cheers, -- Visit Openswan at http://www.openswan.org/

Re: [Bugme-new] [Bug 9543] New: RTNL: assertion failed at net/ipv6/addrconf.c (2164)/RTNL: assertion failed at net/ipv4/devinet.c (1055)

2008-01-07 Thread Jay Vosburgh
Andy Gospodarek [EMAIL PROTECTED] wrote: On Mon, Jan 07, 2008 at 06:57:25PM +0100, Krzysztof Oledzki wrote: On Wed, 19 Dec 2007, Andy Gospodarek wrote: On Tue, Dec 18, 2007 at 08:53:39PM +0100, Krzysztof Oledzki wrote: On Fri, 14 Dec 2007, Andy Gospodarek wrote: On Fri, Dec 14,

Re: [IPV4] ROUTE: Avoid sparse warnings

2008-01-07 Thread Eric Dumazet
Herbert Xu a écrit : On Mon, Jan 07, 2008 at 02:56:24PM +0100, Eric Dumazet wrote: AFAIK, this patch reduces complexity and text size. But if we had loads of empty hash buckets couldn't this potentially increase latency by disabling BH longer than before? Well, we call

make ipv6_sysctl_register to return a value

2008-01-07 Thread Daniel Lezcano
Subject: make ipv6_sysctl_register to return a value From: Daniel Lezcano [EMAIL PROTECTED] This patch makes the function ipv6_sysctl_register to return a value. The af_inet6 init function is now able to handle an error and catch it from the initialization of the sysctl. Signed-off-by: Daniel

[PATCH net-2.6.25][NETNS][IPV6] make a subsystem for af_inet6

2008-01-07 Thread Daniel Lezcano
Subject: make a subsystem for af_inet6 From: Daniel Lezcano [EMAIL PROTECTED] This patch add a network namespace subsystem for the af_inet6 module. It does nothing right now, but one of its purpose is to receive the different variables for sysctl in order to initialize them. When the

[PATCH net-2.6.25][NETNS][IPV6] add ipv6 structure for netns

2008-01-07 Thread Daniel Lezcano
Subject: add ipv6 structure for netns From: Daniel Lezcano [EMAIL PROTECTED] Like the ipv4 part, this patch adds an ipv6 structure in the net structure to aggregate the different resources to make ipv6 per namespace. Signed-off-by: Daniel Lezcano [EMAIL PROTECTED] ---

Re: [IPV4] ROUTE: Avoid sparse warnings

2008-01-07 Thread Herbert Xu
On Mon, Jan 07, 2008 at 09:46:45PM +0100, Eric Dumazet wrote: Well, we call rcu_read_unlock_bh()/rcu_read_lock_bh() for each bucket, empty or not, before and after patch, so we dont change latency. Oh I see. Your patch looks good then. But we still need a solution in general unless we're to

Re: [RFC PATCH v2 1/2] NET: Clone the sk_buff 'iif' field in __skb_clone()

2008-01-07 Thread James Morris
On Mon, 7 Jan 2008, Paul Moore wrote: Both NetLabel and SELinux (other LSMs may grow to use it as well) rely on the 'iif' field to determine the receiving network interface of inbound packets. Unfortunately, at present this field is not preserved across a skb clone operation which can lead to

3c509: PnP resource management fix

2008-01-07 Thread Krzysztof Helt
From: Krzysztof Helt [EMAIL PROTECTED] In order to release PnP resources a card type must be set to EL3_PNP. Previously, it was never set hence the PnP resources were not released and device was left in incorrect state. Signed-off-by: Krzysztof Helt [EMAIL PROTECTED] --- The type value is set

Re: [git patches] net driver fixes

2008-01-07 Thread David Miller
From: Meelis Roos [EMAIL PROTECTED] Date: Mon, 7 Jan 2008 14:44:03 +0200 (EET) JG A couple [minorly] notable wireless bug fixes, and plenty of viro fixes JG for obscure issues :) What about the tulip NAPI fix from Stephen Hemminger? Without this, my tulip is hosed easily.

Re: sunhme x86 SMP issues

2008-01-07 Thread Jarek Poplawski
Costa Tsaousis wrote, On 12/27/2007 10:00 AM: Merry Christams, I would like to report incompatibilities of the sunhme driver with x86 SMP. Hi Costa, It seems your report has to wait for better times... I'm not driver's expert, but maybe you could try some of these: - since 'the list'

Re: [PATCH] via-velocity big-endian support

2008-01-07 Thread Francois Romieu
Al Viro [EMAIL PROTECTED] : [...] Point taken... * kill multibyte bitfields * annotate * add missing conversions * fix a couple of brainos in zerocopy stuff (fortunately, it's ifdef'ed out) Signed-off-by: Al Viro [EMAIL PROTECTED] Thanks a lot. After the usual xmas delay, split and

[PATCH] [NET] kaweth was forgotten in msec switchover of usb_start_wait_urb

2008-01-07 Thread Russell Dill
Back in 2.6.12-pre, usb_start_wait_urb was switched over to take milliseconds instead of jiffies. kaweth.c was never updated to match. Signed-off-by: Russ Dill [EMAIL PROTECTED] --- drivers/net/usb/kaweth.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [PATCH 3/4] [XFRM]: Kill some bloat

2008-01-07 Thread Andi Kleen
David Miller [EMAIL PROTECTED] writes: Similarly I question just about any inline usage at all in *.c files Don't forget the .h files. Especially a lot of stuff in tcp.h should be probably in some .c file and not be inline. -Andi -- To unsubscribe from this list: send the line unsubscribe

[PATCH] intel ethernet drivers: update MAINTAINERS

2008-01-07 Thread Auke Kok
Unfortunately Jeb decided to move away from our group. We wish Jeb good luck with his new group! Reordered people a bit so most active team members are on top. Signed-off-by: Auke Kok [EMAIL PROTECTED] --- MAINTAINERS | 18 -- 1 files changed, 8 insertions(+), 10 deletions(-)

Re: WARNING: at kernel/softirq.c:139 local_bh_enable()

2008-01-07 Thread Kok, Auke
[EMAIL PROTECTED] wrote: I am running 2.6.23 kernel on a DUAL core and QUAD core i386 boxes and after everyboot, when the ethernet traffic starts i get this warning. All the ports in the system are e1000 and i am using the kernel e1000 driver. [added netdev to the Cc:] can you repro this

[PATCH 001/001] ipv4: enable use of 240/4 address space

2008-01-07 Thread Vince Fuller
from Vince Fuller [EMAIL PROTECTED] This set of diffs modify the 2.6.20 kernel to enable use of the 240/4 (aka class-E) address space as consistent with the Internet Draft draft-fuller-240space-00.txt. Signed-off-by: Vince Fuller [EMAIL PROTECTED] --- --- include/linux/in.h.orig 2007-04-12

Re: [PATCH] [IPv6]: IPV6_MULTICAST_IF setting is ignored on link-local connect()

2008-01-07 Thread David Stevens
Brian, Looks good to me. +-DLS Acked-by: David L Stevens [EMAIL PROTECTED] How about the simple patch below? I just removed the ENINVAL check from my original patch, but it accomplishes the same thing. ... Signed-off-by: Brian Haley [EMAIL PROTECTED]

TCP cache performance

2008-01-07 Thread Tom Quetchenbach
I've been continuing off and on to investigate TCP performance issues. As has been noted before on this list, loss and subsequent processing can lead to spikes in the measured RTT which confuse delay-based congestion control algorithms. I've done some experiments that indicate that cache size is

Re: Top 10 kernel oopses for the week ending January 5th, 2008

2008-01-07 Thread Kevin Winchester
J. Bruce Fields wrote: On Sat, Jan 05, 2008 at 09:39:35PM +, Al Viro wrote: On Sat, Jan 05, 2008 at 01:06:17PM -0800, Arjan van de Ven wrote: The http://www.kerneloops.org website collects kernel oops and warning reports from various mailing lists and bugzillas as well as with a client

Re: [PATCH 3/4] [XFRM]: Kill some bloat

2008-01-07 Thread David Miller
From: Andi Kleen [EMAIL PROTECTED] Date: Tue, 08 Jan 2008 01:23:11 +0100 David Miller [EMAIL PROTECTED] writes: Similarly I question just about any inline usage at all in *.c files Don't forget the .h files. Especially a lot of stuff in tcp.h should be probably in some .c file and not be

[PATCH 0/3] bonding: 3 fixes for 2.6.24

2008-01-07 Thread Jay Vosburgh
Following are three fixes to fix locking problems and silence locking-related warnings in the current 2.6.24-rc. patch 1: fix locking in sysfs primary/active selection Call core network functions with expected locks to eliminate potential deadlock and silence warnings.

[PATCH 1/3] bonding: fix locking in sysfs primary/active selection

2008-01-07 Thread Jay Vosburgh
Fix the functions that store the primary and active slave options via sysfs to hold the correct locks in the correct order. The bond_change_active_slave and bond_select_active_slave functions both require rtnl, bond-lock for read and curr_slave_lock for write_bh, and no other

[PATCH 2/3] bonding: fix ASSERT_RTNL that produces spurious warnings

2008-01-07 Thread Jay Vosburgh
Move an ASSERT_RTNL down to where we should hold only RTNL; the existing check produces spurious warnings because we hold additional locks at _bh, tripping a debug warning in spin_lock_mutex(). Signed-off-by: Jay Vosburgh [EMAIL PROTECTED] --- drivers/net/bonding/bond_alb.c |5 ++---

[PATCH 3/3] bonding: fix locking during alb failover and slave removal

2008-01-07 Thread Jay Vosburgh
alb_fasten_mac_swap (actually rlb_teach_disabled_mac_on_primary) requries RTNL and no other locks. This could cause dev_set_promiscuity and/or dev_set_mac_address to be called with improper locking. Changed callers to hold only RTNL during calls to alb_fasten_mac_swap or

Re: TCP cache performance

2008-01-07 Thread David Miller
From: Tom Quetchenbach [EMAIL PROTECTED] Date: Mon, 07 Jan 2008 17:22:51 -0800 This suggests that efforts to improve TCP performance should focus on cache usage rather than just processing time. Thanks for reporting your data, but we very well know what the exact problem is. When we recover

Re: [PATCH 3/4] [XFRM]: Kill some bloat

2008-01-07 Thread Andi Kleen
On Mon, Jan 07, 2008 at 05:54:58PM -0800, David Miller wrote: From: Andi Kleen [EMAIL PROTECTED] Date: Tue, 08 Jan 2008 01:23:11 +0100 David Miller [EMAIL PROTECTED] writes: Similarly I question just about any inline usage at all in *.c files Don't forget the .h files. Especially

Re: [PATCH 3/4] [XFRM]: Kill some bloat II

2008-01-07 Thread Andi Kleen
% awk ' { line++ } ; /^{/ { start = line } ; /^}/ { n++; r += line-start-2; } ; END { print r/n }' include/net/tcp.h 9.48889 The average function length is 9 lines. Actually 8 -- the awk hack had a off by one. Still too long. -Andi -- To unsubscribe from this list: send the line

Re: Top 10 kernel oopses for the week ending January 5th, 2008

2008-01-07 Thread Linus Torvalds
On Mon, 7 Jan 2008, Kevin Winchester wrote: J. Bruce Fields wrote: Is there any good basic documentation on this to point people at? I would second this question. I see people decode oops on lkml often enough, but I've never been entirely sure how its done. Is it somewhere in

Re: [PATCH 3/4] [XFRM]: Kill some bloat

2008-01-07 Thread David Miller
From: Andi Kleen [EMAIL PROTECTED] Date: Tue, 8 Jan 2008 03:05:29 +0100 On Mon, Jan 07, 2008 at 05:54:58PM -0800, David Miller wrote: I explicitly left them out. Most of them are abstractions of common 2 or 3 instruction calculations, and thus should stay inline. Definitely not in

[PATCH][XFRM] Statistics: Add outbound-dropping error.

2008-01-07 Thread Masahide NAKAMURA
Hello, I found two more points where they should be incremented as XFRM packet dropping counter. Please apply it. P.S. I don't touch XFRM_LOOKUP_ICMP related error at __xfrm_lookup() since it may not drop the packet. Correct me if it is wrong or comments are welcomed. [PATCH][XFRM] Statistics:

Re: [PATCH][XFRM] Statistics: Add outbound-dropping error.

2008-01-07 Thread Herbert Xu
On Tue, Jan 08, 2008 at 01:29:28PM +0900, Masahide NAKAMURA wrote: P.S. I don't touch XFRM_LOOKUP_ICMP related error at __xfrm_lookup() since it may not drop the packet. Correct me if it is wrong or comments are welcomed. Right, whether the packet is dropped would be decided by the caller.

Re: [PATCH 3/4] [XFRM]: Kill some bloat

2008-01-07 Thread Andi Kleen
On Mon, Jan 07, 2008 at 07:37:00PM -0800, David Miller wrote: From: Andi Kleen [EMAIL PROTECTED] Date: Tue, 8 Jan 2008 03:05:29 +0100 On Mon, Jan 07, 2008 at 05:54:58PM -0800, David Miller wrote: I explicitly left them out. Most of them are abstractions of common 2 or 3 instruction

Re: [PATCH 3/4] [XFRM]: Kill some bloat

2008-01-07 Thread David Miller
From: Andi Kleen [EMAIL PROTECTED] Date: Tue, 8 Jan 2008 06:00:07 +0100 On Mon, Jan 07, 2008 at 07:37:00PM -0800, David Miller wrote: The vast majority of them are one, two, and three liners. % awk ' { line++ } ; /^{/ { total++; start = line } ; /^}/ { len=line-start-3; if (len 4) l++;

Please pull 'fixes-davem' branch of wireless-2.6

2008-01-07 Thread John W. Linville
Dave, Two more fixes for 2.6.24. I think they are self-explanatory -- let me know if I'm too optimistic! :-) Thanks, John --- Individual patches are available here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/fixes-davem --- The following changes since

Re: Please pull 'fixes-davem' branch of wireless-2.6

2008-01-07 Thread David Miller
From: John W. Linville [EMAIL PROTECTED] Date: Tue, 8 Jan 2008 00:14:25 -0500 Two more fixes for 2.6.24. I think they are self-explanatory -- let me know if I'm too optimistic! :-) Thanks John, I'll pull these in shortly. -- To unsubscribe from this list: send the line unsubscribe netdev in

Re: [PATCH] via-velocity big-endian support

2008-01-07 Thread linux
It doesn't look like you need a test report, but here's one anyway... I grabbed the patch series from git and am running it successfully right now. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH 0/7]: Fix napi_disable() wedge during packet flood.

2008-01-07 Thread David Miller
After going back and forth several times on how to fix this bug I finally think I have a clean solution. It is possible to clean up a ton of stuff, such as getting rid of netif_rx_schedule() et al. (none of these interfaces care about the netdev arg any long) but we should do that post 2.6.24

[PATCH 1/7]: [NET]: Do not grab device reference when scheduling a NAPI poll.

2008-01-07 Thread David Miller
[NET]: Do not grab device reference when scheduling a NAPI poll. It is pointless, because everything that can make a device go away will do a napi_disable() first. The main impetus behind this is that now we can legally do a NAPI completion in generic code like net_rx_action() which a following

[PATCH 2/7]: [NET]: Add NAPI_STATE_DISABLE.

2008-01-07 Thread David Miller
[NET]: Add NAPI_STATE_DISABLE. Create a bit to signal that a napi_disable() is in progress. This sets up infrastructure such that net_rx_action() can generically break out of the -poll() loop on a NAPI context that has a pending napi_disable() yet is being bombed with packets (and thus would

[PATCH 3/7]: [NET]: Do not check netif_running() and carrier state in -poll()

2008-01-07 Thread David Miller
[NET]: Do not check netif_running() and carrier state in -poll() Drivers do this to try to break out of the -poll()'ing loop when the device is being brought administratively down. Now that we have a napi_disable() pending state we are going to solve that problem generically. Signed-off-by:

[PATCH 4/7]: [NETXEN]: Fix -poll() done logic.

2008-01-07 Thread David Miller
[NETXEN]: Fix -poll() done logic. If work_done = budget we should always elide the NAPI completion. Signed-off-by: David S. Miller [EMAIL PROTECTED] --- drivers/net/netxen/netxen_nic_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH 5/7]: [NET]: Fix drivers to handle napi_disable() disabling interrupts.

2008-01-07 Thread David Miller
[NET]: Fix drivers to handle napi_disable() disabling interrupts. When we add the generic napi_disable_pending() breakout logic to net_rx_action() it means that napi_disable() can cause NAPI poll interrupt events to be disabled. And this is exactly what we want. If a napi_disable() is pending,

[PATCH 6/7]:

2008-01-07 Thread David Miller
[NET]: Stop polling when napi_disable() is pending. This finally adds the code in net_rx_action() to break out of the -poll()'ing loop when a napi_disable() is found to be pending. Now, even if a device is being flooded with packets it can be cleanly brought down. Signed-off-by: David S.

[PATCH 7/7]: [NET]: Make -poll() breakout consistent in Intel ethernet drivers.

2008-01-07 Thread David Miller
[NET]: Make -poll() breakout consistent in Intel ethernet drivers. This makes the -poll() routines of the E100, E1000, E1000E, IXGB, and IXGBE drivers complete -poll() consistently. Now they will all break out when the amount of RX work done is less than 'budget'. At a later time, we may want

Re: [PATCH][XFRM] Statistics: Add outbound-dropping error.

2008-01-07 Thread David Miller
From: Masahide NAKAMURA [EMAIL PROTECTED] Date: Tue, 8 Jan 2008 13:29:28 +0900 [PATCH][XFRM] Statistics: Add outbound-dropping error. o Increment PolError counter when flow_cache_lookup() returns errored pointer. o Increment NoStates counter at larval-drop. Signed-off-by: Masahide

Re: [PATCH] intel ethernet drivers: update MAINTAINERS

2008-01-07 Thread David Miller
From: Auke Kok [EMAIL PROTECTED] Date: Mon, 07 Jan 2008 16:54:14 -0800 Unfortunately Jeb decided to move away from our group. We wish Jeb good luck with his new group! Reordered people a bit so most active team members are on top. Signed-off-by: Auke Kok [EMAIL PROTECTED] Applied,

Re: [PATCH] [NET] kaweth was forgotten in msec switchover of usb_start_wait_urb

2008-01-07 Thread David Miller
From: Russell Dill [EMAIL PROTECTED] Date: Mon, 7 Jan 2008 16:20:20 -0700 Back in 2.6.12-pre, usb_start_wait_urb was switched over to take milliseconds instead of jiffies. kaweth.c was never updated to match. Signed-off-by: Russ Dill [EMAIL PROTECTED] Applied, thanks. -- To unsubscribe from

Re: [RFC PATCH v2 1/2] NET: Clone the sk_buff 'iif' field in __skb_clone()

2008-01-07 Thread David Miller
From: James Morris [EMAIL PROTECTED] Date: Tue, 8 Jan 2008 08:11:11 +1100 (EST) On Mon, 7 Jan 2008, Paul Moore wrote: Both NetLabel and SELinux (other LSMs may grow to use it as well) rely on the 'iif' field to determine the receiving network interface of inbound packets.

Please pull 'fixes-jgarzik' branch of wireless-2.6

2008-01-07 Thread John W. Linville
Jeff, One more fix for 2.6.24. Without this b43 passes the wrong channel number and frequency to mac80211 for received frames. The patch is a little big, but it is mostly some definitions related to other definitions used in the fix itself. Let me know if this is a problem! Thanks, John ---

Re: [IPV4] ROUTE: ip_rt_dump() is unecessary slow

2008-01-07 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Mon, 7 Jan 2008 19:30:02 +0100 I noticed ip route list cache x.y.z.t can be *very* slow. While strace-ing -T it I also noticed that first part of route cache is fetched quite fast : ... The following patch corrects this performance/latency

Re: [PATCH] AX25: nuke user trigable printks

2008-01-07 Thread David Miller
From: maximilian attems [EMAIL PROTECTED] Date: Mon, 7 Jan 2008 18:55:13 +0100 sfuzz trigerrs any of those printk easily. things that should have gone in early 2.5.x aka years ago should not be thrown so easily to the user. Signed-off-by: maximilian attems [EMAIL PROTECTED] Can you

Re: Top 10 kernel oopses for the week ending January 5th, 2008

2008-01-07 Thread Al Viro
On Mon, Jan 07, 2008 at 07:26:12PM -0800, Linus Torvalds wrote: I usually just compile a small program like const char array[]=\xnn\xnn\xnn...; int main(int argc, char **argv) { printf(%p\n, array); *(int *)0=0; } Heh. I prefer char

Re: [RFC PATCH v2 1/2] NET: Clone the sk_buff 'iif' field in __skb_clone()

2008-01-07 Thread David Miller
From: Paul Moore [EMAIL PROTECTED] Date: Mon, 07 Jan 2008 12:47:42 -0500 Both NetLabel and SELinux (other LSMs may grow to use it as well) rely on the 'iif' field to determine the receiving network interface of inbound packets. Unfortunately, at present this field is not preserved across a skb

Re: [RFC PATCH v2 2/2] SELinux: Add network ingress and egress control permission checks

2008-01-07 Thread David Miller
From: Paul Moore [EMAIL PROTECTED] Date: Mon, 07 Jan 2008 12:47:48 -0500 This patch implements packet ingress/egress controls for SELinux which allow SELinux security policy to control the flow of all IPv4 and IPv6 packets into and out of the system. Currently SELinux does not have proper

Re: Please pull 'fixes-jgarzik' branch of wireless-2.6

2008-01-07 Thread David Miller
From: John W. Linville [EMAIL PROTECTED] Date: Tue, 8 Jan 2008 00:15:23 -0500 git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git fixes-jgarzik Since Jeff is busy and asked me to take in driver fixes I'll pulled this into my net-2.6 tree. Thanks! -- To unsubscribe from

Re: [PATCH][LRO] Fix lro_mgr-features checks

2008-01-07 Thread David Miller
From: Brice Goglin [EMAIL PROTECTED] Date: Mon, 07 Jan 2008 14:33:32 +0100 [PATCH][LRO] Fix lro_mgr-features checks lro_mgr-features contains a bitmask of LRO_F_* values which are defined as power of two, not as bit indexes. They must be checked with xLRO_F_FOO, not with

Re: [IPV4] ROUTE: ip_rt_dump() is unecessary slow

2008-01-07 Thread Eric Dumazet
David Miller a écrit : From: Eric Dumazet [EMAIL PROTECTED] Date: Mon, 7 Jan 2008 19:30:02 +0100 I noticed ip route list cache x.y.z.t can be *very* slow. While strace-ing -T it I also noticed that first part of route cache is fetched quite fast : ... The following patch corrects this

Re: [Patch] xfrm_policy_destroy: rename and relative fixes

2008-01-07 Thread Herbert Xu
On Thu, Jan 03, 2008 at 08:05:50PM +0800, WANG Cong wrote: Since __xfrm_policy_destroy is used to destory the resources allocated by xfrm_policy_alloc. So using the name __xfrm_policy_destroy is not correspond with xfrm_policy_alloc. Rename it to xfrm_policy_destroy. And along with some

Re: [IPV4] ROUTE: ip_rt_dump() is unecessary slow

2008-01-07 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Tue, 08 Jan 2008 07:11:30 +0100 @@ -288,15 +288,15 @@ static struct rtable *rt_cache_get_first(struct seq_file *seq) static struct rtable *rt_cache_get_next(struct seq_file *seq, struct rtable *r) { - struct rt_cache_iter_state *st =

Re: [Patch] xfrm_policy_destroy: rename and relative fixes

2008-01-07 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Tue, 8 Jan 2008 17:15:16 +1100 On Thu, Jan 03, 2008 at 08:05:50PM +0800, WANG Cong wrote: Since __xfrm_policy_destroy is used to destory the resources allocated by xfrm_policy_alloc. So using the name __xfrm_policy_destroy is not correspond with

Re: [PATCH net-2.6.25] [IPV4] Remove unused member of dst_entry

2008-01-07 Thread David Miller
From: Rami Rosen [EMAIL PROTECTED] Date: Sun, 6 Jan 2008 12:15:35 +0200 The info placeholder member of dst_entry seems to be unused in the network stack. Signed-off-by: Rami Rosen [EMAIL PROTECTED] Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in the

Re: [IPV4] ROUTE: ip_rt_dump() is unecessary slow

2008-01-07 Thread Eric Dumazet
David Miller a écrit : From: Eric Dumazet [EMAIL PROTECTED] Date: Tue, 08 Jan 2008 07:11:30 +0100 @@ -288,15 +288,15 @@ static struct rtable *rt_cache_get_first(struct seq_file *seq) static struct rtable *rt_cache_get_next(struct seq_file *seq, struct rtable *r) { - struct

Re: [PACKET]: Fix sparse warnings in af_packet.c

2008-01-07 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Mon, 7 Jan 2008 12:01:08 +0100 CHECK net/packet/af_packet.c net/packet/af_packet.c:1876:14: warning: context imbalance in 'packet_seq_start' - wrong count at exit net/packet/af_packet.c:1888:13: warning: context imbalance in 'packet_seq_stop'

Re: 2.6.23-rc8 network problem. Mem leak? ip1000a?

2008-01-07 Thread linux
Just to keep the issue open, drivers/net/ipg.c currently in 2.6.24-rc6 still leaks skbuffs like a sieve. Run it for a few hours with network traffic and the machine swaps like crazy while the oom killer goes nuts. diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index d9107e5..4fa392c

Re: [IPV4] ROUTE: Avoid sparse warnings

2008-01-07 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Mon, 7 Jan 2008 12:01:17 +0100 CHECK net/ipv4/route.c net/ipv4/route.c:298:2: warning: context imbalance in 'rt_cache_get_first' - wrong count at exit net/ipv4/route.c:307:3: warning: context imbalance in 'rt_cache_get_next' - unexpected

  1   2   >