Hello all.
Some time in dmesg i see this:
[16121.400422] e1000: eth0: e1000_clean_tx_irq: Detected Tx Unit Hang
[16121.400426] Tx Queue 0
[16121.400427] TDH 28
[16121.400429] TDT 28
[16121.400430] next_to_use 28
[16121.400431] next_to_clean 7d
[16121.400433] buffer_info[next_to_clean]
Hello,
I tried to understand what XFRM_POLICY_LOCALOK is for. (include/linux/xfrm.h)
It is defined thus:
#define XFRM_POLICY_LOCALOK1 /* Allow user to override global policy
*/
is it part of flags of xfrm_userpolicy_info?? I doubt this, since we have
above flags two defines:
Wow! Now at another PC have this messages in dmesg:
[83646.646305] NETDEV WATCHDOG: eth0: transmit timed out
[83646.646391] e1000: eth0: e1000_clean_tx_irq: Detected Tx Unit Hang
[83646.646392] Tx Queue 0
[83646.646393] TDH eb
[83646.646394] TDT eb
[83646.646395] next_to_use eb
[83646.646396]
On Sat, Jan 12, 2008 at 06:57:24PM +1100, Benjamin Herrenschmidt wrote:
On Sat, 2008-01-12 at 08:26 +0100, Stefan Roese wrote:
We shouldn't make it too complicated. We can always select different
settings
in the defconfig file. My thinking here is to better wast a little
memory
Hi Dave,
First of all, I changed output encoding of git to utf-8, so I
guess the encoding should not cause the same trouble for you.
Here are couple of more to uninline things. Pretty
straightforward except the EXPORT_SYMBOLs, I've no idea which
is the right variant (feel free to fix them while
Hi Dave,
First of all, I changed output encoding to utf-8, so I guess
the encoding should not cause trouble for you.
Here are couple of more to uninline things. Pretty
straightforward except the EXPORT_SYMBOLs, I've no idea which
is the right variant (feel free to fix them while applying :-)).
net/ipv4/tcp_cong.c:
tcp_reno_cong_avoid | -65
1 function changed, 65 bytes removed, diff: -65
net/ipv4/arp.c:
arp_ignore | -5
1 function changed, 5 bytes removed, diff: -5
net/ipv4/tcp_bic.c:
bictcp_cong_avoid | -57
1 function changed, 57 bytes removed, diff: -57
net/core/pktgen.c:
pktgen_stop_device | -50
pktgen_run | -105
pktgen_if_show | -37
pktgen_thread_worker | -702
4 functions changed, 894 bytes removed, diff: -894
net/core/pktgen.c:
getCurUs | +36
1 function changed, 36 bytes added, diff: +36
net/core/pktgen.o:
5
net/ipv4/tcp.c:
tcp_close_state | -226
tcp_done| -145
tcp_close | -564
tcp_disconnect | -141
4 functions changed, 1076 bytes removed, diff: -1076
net/ipv4/tcp_input.c:
tcp_fin | -86
tcp_rcv_state_process | -164
2 functions changed, 250 bytes removed,
net/ipv6/route.c:
ip6_pkt_prohibit_out | -130
ip6_pkt_discard | -261
ip6_pkt_discard_out | -130
ip6_pkt_prohibit | -261
4 functions changed, 782 bytes removed, diff: -782
net/ipv6/route.c:
ip6_pkt_drop | +300
1 function changed, 300 bytes added, diff: +300
net/ipv6/route.o:
net/netlink/af_netlink.c:
netlink_realloc_groups| -46
netlink_insert| -49
netlink_autobind | -94
netlink_clear_multicast_users | -48
netlink_bind | -55
netlink_setsockopt| -54
netlink_release | -86
Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED]
---
net/core/pktgen.c | 94 -
1 files changed, 0 insertions(+), 94 deletions(-)
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index ede1fea..ebfb126 100644
--- a/net/core/pktgen.c
+++
net/netfilter/xt_policy.c:
policy_mt | -906
1 function changed, 906 bytes removed, diff: -906
net/netfilter/xt_policy.c:
match_xfrm_state | +427
1 function changed, 427 bytes added, diff: +427
net/netfilter/xt_policy.o:
2 functions changed, 427 bytes added, 906 bytes removed, diff: -479
net/xfrm/xfrm_policy.c:
xfrm_audit_policy_delete | -692
xfrm_audit_policy_add| -692
2 functions changed, 1384 bytes removed, diff: -1384
net/xfrm/xfrm_policy.c:
xfrm_audit_common_policyinfo | +704
1 function changed, 704 bytes added, diff: +704
net/xfrm/xfrm_policy.o:
3 functions
On Wed, 9 Jan 2008, Andy Gospodarek wrote:
On Wed, Jan 09, 2008 at 09:54:56AM -0800, Jay Vosburgh wrote:
CUT
This should silence the lockdep (if I'm understanding what
everybody's saying), and keep the change set to a minimum. This might
The lockdep problem is easy to trigger.
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 11:34:21 +0200
First of all, I changed output encoding of git to utf-8, so I
guess the encoding should not cause the same trouble for you.
I worked on a rebase of net-2.6.25 today and was able to
use emacs to fixup the encoding for
Stephen Hemminger a écrit :
Make FIB TRIE go through sparse checker without warnings.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
Hi Stephen
While reviewing your patches (and fib code) I had some questions :
1) I was wondering isn't trie_collect_stats() a potential cpu hog
(big
Ian Brown [EMAIL PROTECTED] wrote:
I tried to understand what XFRM_POLICY_LOCALOK is for. (include/linux/xfrm.h)
It is defined thus:
#define XFRM_POLICY_LOCALOK1 /* Allow user to override global
policy */
It isn't used anywhere.
Cheers,
--
Visit Openswan at
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 11:34:22 +0200
Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED]
Applied, thanks.
+#endif
+}
+EXPORT_SYMBOL_GPL(tcp_set_state);
I fixed up the trailing whitespace on the #endif line.
--
To unsubscribe from this list: send the
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 11:34:23 +0200
Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED]
Applied.
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 11:34:24 +0200
net/xfrm/xfrm_policy.c:
xfrm_audit_policy_delete | -692
xfrm_audit_policy_add| -692
2 functions changed, 1384 bytes removed, diff: -1384
net/xfrm/xfrm_policy.c:
xfrm_audit_common_policyinfo | +704
1
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 11:34:25 +0200
Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED]
Applied.
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 11:34:26 +0200
Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED]
Applied.
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 11:34:27 +0200
Ilpo, please post netfilter patches to netfilter-devel,
CC:'ing Patrick McHardy.
Patrick, please review, thanks.
net/netfilter/xt_policy.c:
policy_mt | -906
1 function changed, 906 bytes removed, diff: -906
On Jan 11 2008 17:49, David Miller wrote:
From: Vince Fuller [EMAIL PROTECTED]
Date: Fri, 11 Jan 2008 09:29:15 -0800
I leave it up to you, the developers, to decide if you want to use these
patches.
Vince, please just ignore these turkeys who are dismissing
your patch and respin it against
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 11:34:28 +0200
Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED]
These were leftovers from the ktime_t conversion of pktgen.
Applied, th anks!
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 11:34:29 +0200
net/core/pktgen.c:
pktgen_stop_device | -50
pktgen_run | -105
pktgen_if_show | -37
pktgen_thread_worker | -702
4 functions changed, 894 bytes removed, diff: -894
net/core/pktgen.c:
From: Eric Dumazet [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 12:16:13 +0100
We could use a better scheme with an extra indirection.
Unfortunately, indirection will likely have a negative
impact upon performance. We go only as fast as the
number of memory references made by this code.
3)
I fixed up some utf-8 encoding issues in changelog messages,
got rid of superfluous patches (X then revert X cases)
and combined bug fixes into the patches which introduced
them.
We are just over 700 patches, keep them coming :-)
--
To unsubscribe from this list: send the line unsubscribe netdev
Hi,
In net/xfrm.h:
- remove XFRM_STATE_VOID (not in use)
- correct 3 typos
Regards,
Rami Rosen
Signed-off-by: Rami Rosen [EMAIL PROTECTED]
diff --git a/include/net/xfrm.h b/include/net/xfrm.h
index 860fe4a..432c5c8 100644
--- a/include/net/xfrm.h
+++ b/include/net/xfrm.h
@@ -84,10
Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED]
---
net/sched/sch_htb.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c
index 72beb66..6a2352c 100644
--- a/net/sched/sch_htb.c
+++ b/net/sched/sch_htb.c
@@ -214,10 +214,6 @@
Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED]
---
net/core/utils.c | 11 ---
1 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/net/core/utils.c b/net/core/utils.c
index 34459c4..8031eb5 100644
--- a/net/core/utils.c
+++ b/net/core/utils.c
@@ -91,17 +91,6 @@
Patrick McHardy wrote:
Andrew Morton wrote:
Distribution: iptables 1.4.0 was used with kernel 2.6.23 and
iptables 1.3.8
with 2.6.22.15
Hardware Environment: 3 interfaces, 2 interfaces bridged to form
br0, and
another connects to internet using pppoe.
Software Environment: bridge, multipath
Rafael J. Wysocki wrote:
On Friday, 11 of January 2008, supersud501 wrote:
Rafael J. Wysocki wrote:
http://bugzilla.kernel.org/show_bug.cgi?id=9721
allright, didn't see that before, sorry, here are the results:
kernel 2.6.23.12 acpi=off: when shutting down the system doesn't
poweroff
Hi Ilpo:
On Sat, Jan 12, 2008 at 09:40:17AM +, Ilpo Järvinen wrote:
Your emails are now using UTF-8 encoding but it's still declaring
ISO-8859-1 as the charset. So you probably want to fix that up or
your name may show up as Jävinen on the reader's screen.
Thanks,
--
Visit Openswan at
On Sat, 12 Jan 2008, Herbert Xu wrote:
On Sat, Jan 12, 2008 at 09:40:17AM +, Ilpo Järvinen wrote:
Your emails are now using UTF-8 encoding but it's still declaring
ISO-8859-1 as the charset.
Thanks for trying to help but my situation is such that I think it got
also you confused (this
I in doubts only about action continue.
To and/or behaviour one of best usage are (example):
# set bit 2 of mark to 0 (mark0xfd|0) and continue
tc filter add ... prio 1 ... flowid fd:0 action continue
# continue
tc filter add ... prio 2 ...
- in current ingress_enqueue() code IMHO case
alg_key_len is currently defined as 'signed int'. This unfortunatly leads
to integer divides in several paths.
Converting it to unsigned is safe and saves 208 bytes of text on i386.
Signed-off-by: Eric Dumazet [EMAIL PROTECTED]
diff --git a/include/linux/xfrm.h b/include/linux/xfrm.h
index
Krzysztof Oledzki [EMAIL PROTECTED] wrote:
[...]
Exactly. All I need to do is to reboot my server, I have 100% probability
to get the warning.
I wish it were that easy for me; I'm not sure what magic thing
you've got on your server or network that I don't, but I haven't been
able to make
This is a patch from a while ago that I'm resending. Basically, in access
server configurations, a lot of routes have the same local ip address but on
different devices. This fixes the long chains that result from not including
the device index in the hash.
-ben
diff --git
David Miller wrote:
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 11:34:27 +0200
Ilpo, please post netfilter patches to netfilter-devel,
CC:'ing Patrick McHardy.
Patrick, please review, thanks.
This looks fine to me, thanks Ilpo.
net/netfilter/xt_policy.c:
policy_mt | -906
http://bugzilla.kernel.org/show_bug.cgi?id=9721
On Saturday, 12 of January 2008, supersud501 wrote:
I'll do the git-bisect (just downloading linux-2.6.git), but i forgot to
mention one little thing: i'm using x64 version of kernel - does this
play an important role?
No, it doesn't.
--
To
Jarek Poplawski wrote:
On Thu, Jan 10, 2008 at 09:22:42PM -0800, David Miller wrote:
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Sun, 30 Dec 2007 15:13:23 +0100
On Sat, Dec 29, 2007 at 07:14:43PM -0800, David Miller wrote:
...
I've removed the warning and made the branch back to 'again'
Hi,
I propose to drop the previously submitted patch for I performed more
investigations on ROSE frame routing and found that it was not
completely satisfactory.
Please find here another commit to net-2.6.25 with explanations.
From fd66cc115e058b2fc63a0e26aa73f1d27113105a Mon Sep 17 00:00:00
From 46bccce1e660a39bcc8f8cf87d4c17de33f4ba48 Mon Sep 17 00:00:00 2001
From: Bernard Pidoux [EMAIL PROTECTED]
Date: Thu, 10 Jan 2008 23:01:46 +0100
Subject: [PATCH 2/4] [ROSE] template declaration for rose_get_route()
Signed-off-by: Bernard Pidoux [EMAIL PROTECTED]
---
include/net/rose.h |1
From bc108e5ee0b0353c3707df25e12e40038da0160a Mon Sep 17 00:00:00 2001
From: Bernard Pidoux [EMAIL PROTECTED]
Date: Fri, 11 Jan 2008 10:23:55 +0100
Subject: [PATCH 3/4] [ROSE] return with lock held
Signed-off-by: Bernard Pidoux [EMAIL PROTECTED]
From 5c50971c6088f380eafdb1a6a7de5a5d3686c8c7 Mon Sep 17 00:00:00 2001
From: Bernard Pidoux [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 20:19:34 +0100
Subject: [PATCH 4/4] [ROSE] ENETUNREACH held rose_connect()
Initial connection to rose neighbour nodes was unusually,
t0 timer was blocked and
Bernard Pidoux a écrit :
From 46bccce1e660a39bcc8f8cf87d4c17de33f4ba48 Mon Sep 17 00:00:00 2001
From: Bernard Pidoux [EMAIL PROTECTED]
Date: Thu, 10 Jan 2008 23:01:46 +0100
Subject: [PATCH 2/4] [ROSE] template declaration for rose_get_route()
Signed-off-by: Bernard Pidoux [EMAIL PROTECTED]
---
On Sat, 12 Jan 2008 11:40:10 +0200
Ilpo Järvinen [EMAIL PROTECTED] wrote:
net/ipv4/tcp.c:
tcp_close_state | -226
tcp_done| -145
tcp_close | -564
tcp_disconnect | -141
4 functions changed, 1076 bytes removed, diff: -1076
net/ipv4/tcp_input.c:
tcp_fin
On Sat, 12 Jan 2008 12:16:13 +0100
Eric Dumazet [EMAIL PROTECTED] wrote:
Stephen Hemminger a écrit :
Make FIB TRIE go through sparse checker without warnings.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
Hi Stephen
While reviewing your patches (and fib code) I had some
On Sat, Jan 12, 2008 at 02:59:50PM +0200, Ilpo Järvinen wrote:
Here's one example...
From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= [EMAIL PROTECTED]
...
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Something still needed besides these to declare email utf-8?
If that's
Em Sat, Jan 12, 2008 at 01:03:55PM -0800, Stephen Hemminger escreveu:
On Sat, 12 Jan 2008 11:40:10 +0200
Ilpo Järvinen [EMAIL PROTECTED] wrote:
-
-#ifdef STATE_TRACE
- SOCK_DEBUG(sk, TCP sk=%p, State %s - %s\n,sk,
statename[oldstate],statename[state]);
-#endif
-}
Since
Eric Dumazet wrote:
Bernard Pidoux a écrit :
From 46bccce1e660a39bcc8f8cf87d4c17de33f4ba48 Mon Sep 17 00:00:00 2001
From: Bernard Pidoux [EMAIL PROTECTED]
Date: Thu, 10 Jan 2008 23:01:46 +0100
Subject: [PATCH 2/4] [ROSE] template declaration for rose_get_route()
Signed-off-by: Bernard
On Sat, 12 Jan 2008 12:16:13 +0100
Eric Dumazet [EMAIL PROTECTED] wrote:
Stephen Hemminger a écrit :
Make FIB TRIE go through sparse checker without warnings.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
Hi Stephen
While reviewing your patches (and fib code) I had some
Florian Fainelli wrote:
The following patch applies to Jeff's netdev-2.6 tree with Francois's r6040
recent changes pulled to this tree.
- remove unused private structure members
- functions to allocate/free TX and RX buffers
- recover from transmit timeout
- use netdev_alloc_skb instead of
Florian Fainelli wrote:
This patch adds me as maintainer of the RDC R6040 Fast Ethernet driver.
Signed-off-by: Florian Fainelli [EMAIL PROTECTED]
applied
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Thomas Bogendoerfer wrote:
- Use inline functions for dma_sync_* instead of macros
- added Kconfig change to make selection for similair SGI boxes easier
Signed-off-by: Thomas Bogendoerfer [EMAIL PROTECTED]
---
drivers/net/Kconfig |2 +-
drivers/net/sgiseeq.c | 64
Matti Linnanvuori wrote:
From: Matti Linnanvuori [EMAIL PROTECTED]
Add a guideline for hard_start_xmit method not to
modify SKB.
Signed-off-by: Matti Linnanvuori
[EMAIL PROTECTED]
---
--- a/Documentation/networking/driver.txt 2007-12-22
18:50:28.062169500 +0200
+++
applied 1-2 to #upstream-fixes
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
patch failed to apply (possibly because of recent NAPI updates)
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
applied
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
patch conflicted with
commit 1706287f6eb58726a9a0e5cbbde87f49757615e3
Author: David S. Miller [EMAIL PROTECTED]
Date: Mon Jan 7 20:51:29 2008 -0800
[NETXEN]: Fix -poll() done logic.
If work_done = budget we should always elide the NAPI
completion.
Signed-off-by: David S.
applied
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Emil Medve wrote:
This is probably a result of the changes from commit
854d836 - [NET]: Dynamically allocate the loopback device, part 2
Signed-off-by: Emil Medve [EMAIL PROTECTED]
---
linux-2.6 scripts/checkpatch.pl 0001-NET-Fixed-a-small-typo-in-the-loopback-driver.patch
total: 0 errors, 0
Francois Romieu wrote:
Spotted-by: Citizen Lee [EMAIL PROTECTED]
Signed-off-by: Francois Romieu [EMAIL PROTECTED]
---
drivers/net/r8169.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 5863190..6ee9db1 100644
---
Stephen Hemminger wrote:
Move the ip1000 driver into the expected place for gigabit cards
in the configuration menu structure. It should be under the gigabit
cards, not at the top level.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
--- a/drivers/net/Kconfig 2007-12-26
Anton Vorontsov wrote:
Otherwise oops will happen if ethernet device has not been opened:
Unable to handle kernel paging request for data at address 0x014c
Faulting instruction address: 0xc016f7f0
Oops: Kernel access of bad area, sig: 11 [#1]
MPC85xx
NIP: c016f7f0 LR: c01722a0 CTR:
Francois Romieu wrote:
Please pull from branch 'ipg-fixes' in repository
git://git.kernel.org/pub/scm/linux/kernel/git/romieu/netdev-2.6.git ipg-fixes
to get the changes below.
I have tested the driver with a PIV HT based motherboard. The network
controller is connected to a fast ethernet
applied
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
John W. Linville wrote:
[2nd try -- turns-out the Mattis Nissler patch needed an extra tweak.
It will probably also cause build breakage when you rebase since
rt2x00lib_txdone(...) becomes rt2x00pci_txdone(rt2x00dev,...) in 2.6.25,
so FYI... :-)
This also includes another patch (the 4 byte
applied
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Auke Kok wrote:
From: Jesse Brandeburg [EMAIL PROTECTED]
fix the typo in speed 1 setting.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
ethtool.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
patches 1 and 2 failed to
applied 1-2 to #upstream-fixes
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
When doing init_ring checking whether a new skb needs to be allocated
was wrong.
Signed-off-by: Thomas Bogendoerfer [EMAIL PROTECTED]
---
This is a bug fix for the 2.6.25 driver.
drivers/net/sgiseeq.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
upstream-linus
to receive the following updates:
MAINTAINERS | 10 ++-
drivers/net/3c509.c |4 +
drivers/net/Kconfig
Jay Vosburgh [EMAIL PROTECTED] wrote:
Can you test the following and let me know if it triggers the
warning? I believe this is the minimum locking needed, and based on
input from Herbert, we shouldn't need to hold the lock at _bh. If this
one works, and nobody sees any other issues
irias_new_object() can fail its memory allocation and will return NULL in
that case. I believe the proper thing to do is to catch this, free the
ias_opt that was allocated earlier but won't be used and then return
-ENOMEM.
There are assertions further on that check for a NULL ias_obj, but I
There are paths through the irda_setsockopt() function where we return and
may or may not have allocated a new ias_obj but in any case have not used
it for anything yet and we end up leaking memory.
As far as I can tell, in the case where we didn't allocate a new ias_ob
but simply were
On Sat, 12 Jan 2008 19:35:58 +0100
Andi Kleen [EMAIL PROTECTED] wrote:
On Saturday 12 January 2008 18:51:35 Benjamin LaHaise wrote:
On Sat, Jan 12, 2008 at 03:37:59AM +0100, Andi Kleen wrote:
And yes, the
network stack shouldn't call synchronize_rcu() quite so much, but
fixing
From: Rami Rosen [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 13:37:34 +0200
In net/xfrm.h:
- remove XFRM_STATE_VOID (not in use)
- correct 3 typos
Signed-off-by: Rami Rosen [EMAIL PROTECTED]
XFRM_STATE_VOID is there so that a freshly initialized
object does not have a valid state. So
From: Herbert Xu [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 23:17:40 +1100
Your emails are now using UTF-8 encoding but it's still declaring
ISO-8859-1 as the charset. So you probably want to fix that up or
your name may show up as Jävinen on the reader's screen.
Yes, for people using the GIT
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 14:59:50 +0200 (EET)
...Maybe I just fall-back to changing my last name, it's the only
full-proof solution... ;-)
Don't do this! Otherwise I won't have a frequent test case to make
sure my patch applying scripts are working
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 11 Jan 2008 22:45:14 -0800
trie_init is worthless it is just zeroing stuff that is already
zero! Move the memset() down to make it obvious.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
Applied.
--
To unsubscribe from this list:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 11 Jan 2008 22:45:15 -0800
The revision element must of been part of an earlier design,
because currently it is set but never used.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
Applied.
I suspect Robert wanted to play around with
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 11 Jan 2008 22:45:16 -0800
The size of structures is a debug thing, not something that needs to
be part of a /proc api.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
I don't necessarily agree with this one, the size of the
structures
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 11 Jan 2008 22:45:17 -0800
Turn the unused size field into a useful counter for the number
of routes.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
It's not useful if nothing reports it's value. I'm dropping
this.
Unless you add
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 11 Jan 2008 22:45:18 -0800
Use %u instead of %d when printing unsigned values.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 11 Jan 2008 22:45:19 -0800
The only error from fib_insert_node is if memory allocation fails,
so instead of passing by reference, just use the convention of returning
NULL.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
I'd be a
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 11 Jan 2008 22:45:20 -0800
printk related cleanups:
* Get rid of unused printk wrappers.
* Make bug checks into KERN_WARNING because KERN_DEBUG gets ignored
* Turn one cryptic old message into something real
* Make sure all messages
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 11 Jan 2008 22:45:21 -0800
The FIB TRIE code has a bunch of statistics, but the code is hidden
behind an ifdef that was never implemented. Since it was dead code,
it was broken as well.
This patch fixes that by making it a config option.
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 11 Jan 2008 22:45:22 -0800
Make FIB TRIE go through sparse checker without warnings.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
Also applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of
From: Patrick McHardy [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 20:03:31 +0100
David Miller wrote:
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 11:34:27 +0200
Ilpo, please post netfilter patches to netfilter-devel,
CC:'ing Patrick McHardy.
Patrick, please review,
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 13:09:46 -0800
On Sat, 12 Jan 2008 12:16:13 +0100
Eric Dumazet [EMAIL PROTECTED] wrote:
[FIB]: Reduce text size of net/ipv4/fib_trie.o
In struct tnode, we use two fields of 5 bits for 'pos' and 'bits'.
Switching to
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 13:53:35 +0200
Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED]
Applied.
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 13:53:36 +0200
Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED]
Applied.
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: Eric Dumazet [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 18:29:32 +0100
alg_key_len is currently defined as 'signed int'. This unfortunatly leads
to integer divides in several paths.
Converting it to unsigned is safe and saves 208 bytes of text on i386.
Signed-off-by: Eric Dumazet
From: Matti Linnanvuori [EMAIL PROTECTED]
Add a guideline for hard_start_xmit method not to
modify SKB.
Signed-off-by: Matti Linnanvuori [EMAIL PROTECTED]
---
--- a/Documentation/networking/driver.txt 2008-01-13 07:14:01.608291500 +0200
+++ b/Documentation/networking/driver.txt 2008-01-13
David Miller wrote:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 11 Jan 2008 22:45:17 -0800
Turn the unused size field into a useful counter for the number
of routes.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
It's not useful if nothing reports it's value. I'm
From: Benjamin LaHaise [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 13:58:19 -0500
This is a patch from a while ago that I'm resending. Basically, in
access server configurations, a lot of routes have the same local ip
address but on different devices. This fixes the long chains that
result
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 21:33:16 -0800
The size field is added to /proc/net/fib_triestat that was the point.
Not from what I can see.
[EMAIL PROTECTED]:~/src/GIT/net-2.6.25$ git grep -e -size net/ipv4/fib_trie.c
net/ipv4/fib_trie.c:t-size++;
1 - 100 of 102 matches
Mail list logo
