Re: [PATCH] fib_trie: rescan if key is lost during dump

2008-01-25 Thread Jarek Poplawski
On 24-01-2008 22:51, Stephen Hemminger wrote: Normally during a dump the key of the last dumped entry is used for continuation, but since lock is dropped it might be lost. In that case fallback to the old counter based N^2 behaviour. This means the dump will end up skipping some routes

Re: [Bugme-new] [Bug 9810] New: Bridge doesn't work with e1000e driver

2008-01-25 Thread Andrew Morton
On Fri, 25 Jan 2008 01:13:19 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9810 Summary: Bridge doesn't work with e1000e driver Product: Networking Version: 2.5 KernelVersion: 2.6.24-rc8 Platform: All

Re: [Bugme-new] [Bug 9811] New: Loopback address to eth0 interface changes scope permanently

2008-01-25 Thread Andrew Morton
On Fri, 25 Jan 2008 02:04:04 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9811 Summary: Loopback address to eth0 interface changes scope permanently Product: Networking Version: 2.5 KernelVersion:

Re: [PATCH 3/7 net-2.6.25] [IPV4]: Prohibit assignment of 0.0.0.0 as interface address.

2008-01-25 Thread Daniel Lezcano
Denis V. Lunev wrote: Daniel Lezcano wrote: Denis V. Lunev wrote: I could hardly imagine why sombady needs to assign 0.0.0.0 as an interface address or interface destination address. The kernel will behave in a strage way in several places if this is possible, as ifa_local != 0 is considered

[PATCH] [NET]: Remove PowerPC code from fec.c

2008-01-25 Thread Jochen Friedrich
fec.c is only used on M68k Coldfire CPUs. Remove leftover PowerPC code from this driver. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- drivers/net/fec.c | 136 +--- 1 files changed, 3 insertions(+), 133 deletions(-) diff --git

[PATCH for-2.6.25] [POWERPC] Rename commproc to cpm1 and cpm2_common.c to cpm2.c

2008-01-25 Thread Jochen Friedrich
Rename commproc.[ch] to cpm1.[ch] to be more consistent with cpm2. Also rename cpm2_common.c to cpm2.c as suggested by Scott Wood. Adjust the includes accordingly. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch/powerpc/platforms/8xx/ep88xc.c |1 +

Re: [PATCH] fib_trie: rescan if key is lost during dump

2008-01-25 Thread Stephen Hemminger
On Fri, 25 Jan 2008 09:23:00 +0100 Jarek Poplawski [EMAIL PROTECTED] wrote: On 24-01-2008 22:51, Stephen Hemminger wrote: Normally during a dump the key of the last dumped entry is used for continuation, but since lock is dropped it might be lost. In that case fallback to the old counter

ipcomp regression in 2.6.24?

2008-01-25 Thread Beschorner Daniel
With 2.6.24 IPSEC/ESP tunnels to older kernels establish fine, data flows in both directions, but no data comes out of the tunnel. Needed to disable ipcomp. Daniel -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info

[PATCH 2.6.24] fib: fix route replacement, fib_info is shared

2008-01-25 Thread Julian Anastasov
fib_info can be shared by many route prefixes but we don't want duplicate alternative routes for a prefix+tos+priority. Last change was not correct to check fib_treeref because it accounts usage from other prefixes. Signed-off-by: Julian Anastasov [EMAIL PROTECTED] --- ---

[PATCH] hamradio: fix dmascc section mismatch

2008-01-25 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] cc: Klaus Kudielka [EMAIL PROTECTED] hw[] is used in both init and exit functions so it cannot be initdata (section mismatch is when CONFIG_MODULES=n and CONFIG_DMASCC=y). WARNING: vmlinux.o(.exit.text+0xba7): Section mismatch: reference to .init.data:

Re: [Bugme-new] [Bug 9816] New: cannot replace route

2008-01-25 Thread Andrew Morton
On Sat, 26 Jan 2008 00:11:57 +0100 Jarek Poplawski [EMAIL PROTECTED] wrote: Andrew Morton wrote, On 01/25/2008 11:26 PM: On Fri, 25 Jan 2008 13:23:49 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9816 ... I'd agree with Andrea: replacing a route

[PATCH 2.6.24] fib_trie: apply fixes from fib_hash

2008-01-25 Thread Julian Anastasov
Update fib_trie with some fib_hash fixes: - check for duplicate alternative routes for prefix+tos+priority when replacing route - properly insert by matching tos together with priority - fix alias walking to use list_for_each_entry_continue for insertion and deletion when fa_head is not

[PATCH] [TIPC]: Supress minor sparse warnings.

2008-01-25 Thread Florian Westphal
cluster.c:145:2: warning: Using plain integer as NULL pointer link.c:3254:36: warning: Using plain integer as NULL pointer ref.c:151:15: warning: Using plain integer as NULL pointer socket.c:91:13: warning: context imbalance in 'sock_lock' - wrong count at exit socket.c:99:13: warning: context

Re: [PATCH 2.6.24] fib_trie: apply fixes from fib_hash

2008-01-25 Thread Joonwoo Park
2008/1/26, Joonwoo Park [EMAIL PROTECTED]: On Sat, Jan 26, 2008 at 04:40:30AM +0200, Julian Anastasov wrote: Signed-off-by: Julian Anastasov [EMAIL PROTECTED] --- Not tested, someone please check the findings --- linux-2.6.24/net/ipv4/fib_trie.c_orig 2008-01-25

Re: [Bugme-new] [Bug 9816] New: cannot replace route

2008-01-25 Thread Joonwoo Park
2008/1/26, Andrew Morton [EMAIL PROTECTED]: But whatever. It used to work. People's scripts will break. Regression. Also I thought that 'replace with itself' should be error as like Jarek. But it used to work and patch made a regression, it's my bad :( I think Julian's recent patches on

Re: [PATCH 2.6.24] fib_trie: apply fixes from fib_hash

2008-01-25 Thread Joonwoo Park
On Sat, Jan 26, 2008 at 04:40:30AM +0200, Julian Anastasov wrote: Signed-off-by: Julian Anastasov [EMAIL PROTECTED] --- Not tested, someone please check the findings --- linux-2.6.24/net/ipv4/fib_trie.c_orig 2008-01-25 10:45:06.0 +0200 + if

Re: iproute2 (addr flush) infinite loop when unprivileged users

2008-01-25 Thread Alon Bar-Lev
On 1/26/08, Stephen Hemminger [EMAIL PROTECTED] wrote: The issue is that iproute is just blindly sending the deletes and not asking for acknowledgment status. Here is a trivial patch to iproute to fix that, but the problem is that it means it will slow down bulk removal. Maybe it should just

[PATCH] [TIPC]: declare proto_ops structures as 'const'.

2008-01-25 Thread Florian Westphal
CC: Allan Stephens [EMAIL PROTECTED] CC: Jon Paul Maloy [EMAIL PROTECTED] Signed-off-by: Florian Westphal [EMAIL PROTECTED] --- net/tipc/socket.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/net/tipc/socket.c b/net/tipc/socket.c index 24ddfd2..2290903

Re: iproute2 (addr flush) infinite loop when unprivileged users

2008-01-25 Thread Stephen Hemminger
On Sat, 26 Jan 2008 01:00:34 +0200 Alon Bar-Lev [EMAIL PROTECTED] wrote: Hello, When executing the following command using unprivileged users there is an infinite loop... /sbin/ip route flush dev eth1 Execution with -s produces: *** Round 28153, deleting 2 entries *** *** Round

[PATCH] tc: oops in em_meta

2008-01-25 Thread Stephen Hemminger
If userspace passes a unknown match index into em_meta, then em_meta_change will return an error and the data for the match will not be set. This then causes an null pointer dereference when the cleanup is done in the error path via tcf_em_tree_destroy. Since the tree structure comes kzalloc, it

[PATCH 13/14] Move usbnet.h and rndis_host.h to include/linux/usb

2008-01-25 Thread Jussi Kivilinna
Move headers usbnet.h and rndis_host.h to include/linux/usb and fix includes for drivers/net/usb modules. Headers are moved because rndis_wlan will be outside drivers/net/usb in drivers/net/wireless and yet need these headers. Signed-off-by: Jussi Kivilinna [EMAIL PROTECTED] ---

[PATCH 11/14] [rndis_host] Add link_change function pointer to 'struct rndis_data'.

2008-01-25 Thread Jussi Kivilinna
Callback to signal link state changes from minidriver to 'subminidrivers'. Signed-off-by: Jussi Kivilinna [EMAIL PROTECTED] --- drivers/net/usb/rndis_host.c | 24 drivers/net/usb/usbnet.h |4 2 files changed, 24 insertions(+), 4 deletions(-) diff --git

[PATCH 08/14] [rndis_host] export functions

2008-01-25 Thread Jussi Kivilinna
Export rndis_host functions and also rename rndis_bind() to generic_rndis_bind() for modules using rndis_host as base. Signed-off-by: Jussi Kivilinna [EMAIL PROTECTED] --- drivers/net/usb/rndis_host.c | 20 +--- drivers/net/usb/rndis_host.h |9 + 2 files changed,

[PATCH 07/14] [rndis_host] Split up rndis_host.c

2008-01-25 Thread Jussi Kivilinna
Split up rndis_host.c into rndis_host.h and rndis_base.c. This is done so that rndis_wlan can reuse common parts with rndis_host. Signed-off-by: Jussi Kivilinna [EMAIL PROTECTED] --- drivers/net/usb/rndis_host.c | 223 -- drivers/net/usb/rndis_host.h | 248

[PATCH 01/14] Fix sparse warning: returning void-valued expression

2008-01-25 Thread Jussi Kivilinna
From: Bjorge Dijkstra [EMAIL PROTECTED] rndis_unbind and usbnet_cdc_unbind don't return anything. Signed-off-by: Bjorge Dijkstra [EMAIL PROTECTED] Signed-off-by: Jussi Kivilinna [EMAIL PROTECTED] --- drivers/net/usb/rndis_host.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

[PATCH 00/14][v3]: Driver for Wireless RNDIS USB devices.

2008-01-25 Thread Jussi Kivilinna
Hello, Here is the third try on wireless RNDIS patchset. Patches 1-9 are from second patchset (with name change rndis_wext - rndis_wlan in comments where needed): 1. Fix sparse warning: returning void valued expression 2. [cdc_ether] Hardwire CDC descriptors when missing 3. [rndis_host] Use

[PATCH v3][NET] gen_estimator: faster gen_kill_estimator

2008-01-25 Thread Jarek Poplawski
On Mon, Jan 21, 2008 at 04:29:18PM -0800, David Miller wrote: ... Fix this right, make a structure like: struct kernel_gnet_stats_rate_est { struct gnet_stats_rate_est est; void*gen_estimator; } And update all the code as needed. Hi, Here is

Re: [PATCH 2/5] [POWERPC][NET] ucc_geth_mii and users: get rid of device_type

2008-01-25 Thread Kumar Gala
On Thu, 24 Jan 2008, Anton Vorontsov wrote: device_type property is bogus, thus use proper compatible. Also change compatible property to fsl,ucc-mdio. Per http://ozlabs.org/pipermail/linuxppc-dev/2007-December/048388.html Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] ---

Re: [PATCH 00/14] RFC: Driver for Wireless RNDIS USB devices.

2008-01-25 Thread David Brownell
On Friday 25 January 2008, Jussi Kivilinna wrote: On Thu, 2008-01-24 at 17:19 -0800, David Brownell wrote: 13. [rndis_host] blacklist known wireless RNDIS devices That will be a headache over time though ... can't you just let the probe succeed enough to recogize it's wireless (using

Re: [PATCH UCC TDM 3/3 ] Modified Documentation to explain dtsentries for TDM driver

2008-01-25 Thread Scott Wood
Aggrwal Poonam wrote: The device tree already has a brg-frequency property in qe node which is the value of BRGCLK. Yes, I'm saying it belongs as brg/clock-frequency. :-) CPM1/2 already do this. -Scott -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a

[patch 08/11][NETNS][IPV6] fib6_rules - dynamically allocate the fib rules ops

2008-01-25 Thread Daniel Lezcano
The fib6_rules_ops structure is dynamically allocated, so that allows to make several instances of it per network namespace. The global static fib6_rules_ops structure is renamed to fib6_rules_ops_template in order to quickly memcopy it for the structure initialization. Signed-off-by: Daniel

[patch 07/11][NETNS][IPV6] make fib6_clean_node to use the network namespace

2008-01-25 Thread Daniel Lezcano
The fib6_clean_node function should have the network namespace it is working on. The fib6_cleaner_t structure is extended with the network namespace field to be passed to the fib6_clean_node function. The different functions calling the fib6_clean_node function are extended with the netns

[patch 04/11][NETNS][IPV6] ip6_fib - pass the network namespace parameter to timer callback

2008-01-25 Thread Daniel Lezcano
The fib tables are now relative to the network namespace. When the garbage collector timer expires, we must have a network namespace parameter in order to retrieve the tables. For now this is the init_net, but we should be able to have a timer per namespace and use the timer callback parameter

Re: [Lksctp-developers] [PATCH] SCTP: Fix kernel panic while received AUTH chunk with BAD shared key identifier

2008-01-25 Thread Vlad Yasevich
Neil Horman wrote: On Tue, Jan 22, 2008 at 05:29:20PM +0900, Wei Yongjun wrote: This patch fix this problem. Signed-off-by: Wei Yongjun [EMAIL PROTECTED] --- a/net/sctp/auth.c 2008-01-21 00:03:25.0 -0500 +++ b/net/sctp/auth.c 2008-01-21 21:31:47.0 -0500 @@ -420,15 +420,15

[PATCH 3/3] netns netfilter: create per-netns /proc/net/*_tables_*

2008-01-25 Thread Alexey Dobriyan
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- include/linux/netfilter/x_tables.h |4 ++-- net/ipv4/netfilter/arp_tables.c| 21 ++--- net/ipv4/netfilter/ip_tables.c | 21 ++--- net/ipv6/netfilter/ip6_tables.c| 22 +++---

Re: [PATCH] [NET]: Remove PowerPC code from fec.c

2008-01-25 Thread Frans Pop
On Friday 25 January 2008, Jochen Friedrich wrote: Jochen Friedrich wrote: +++ b/drivers/net/fec.c @@ -23,6 +23,9 @@ * * Bug fixes and cleanup by Philippe De Muyter ([EMAIL PROTECTED]) * Copyright (c) 2004-2006 Macq Electronique SA. + * + * This driver is now only used on

Re: [PATCH] [NET]: Remove PowerPC code from fec.c

2008-01-25 Thread Geert Uytterhoeven
On Fri, 25 Jan 2008, Jochen Friedrich wrote: fec.c is only used on M68k Coldfire CPUs. Remove leftover PowerPC code from this driver. As per MAINTAINERS, m68knommu is handled by: UCLINUX (AND M68KNOMMU) P: Greg Ungerer M: [EMAIL PROTECTED] L: [EMAIL PROTECTED]

[PATCH net-2.6.25] [XFRM]: Speed up xfrm_policy and xfrm_state walking

2008-01-25 Thread Timo Teräs
Change xfrm_policy and xfrm_state walking algorithm from O(n^2) to O(n). This is achieved adding the entries to one more list which is used solely for walking the entries. This also fixes some races where the dump can have duplicate or missing entries when the SPD/SADB is modified during an

Re: [PATCH 3/7 net-2.6.25] [IPV4]: Prohibit assignment of 0.0.0.0 as interface address.

2008-01-25 Thread Daniel Lezcano
Denis V. Lunev wrote: I could hardly imagine why sombady needs to assign 0.0.0.0 as an interface address or interface destination address. The kernel will behave in a strage way in several places if this is possible, as ifa_local != 0 is considered as initialized/non-initialized state of the

[PATCH 7/7 net-2.6.25] [NETNS]: Lookup in FIB semantic hashes taking into account the namespace.

2008-01-25 Thread Denis V. Lunev
The namespace is not available in the fib_sync_down_addr, add it as a parameter. Looking up a device by the pointer to it is OK. Looking up using a result from fib_trie/fib_hash table lookup is also safe. No need to fix that at all. So, just fix lookup by address and insertion to the hash table

Re: Slow OOM in netif_RX function

2008-01-25 Thread Andi Kleen
Ivan H. Dichev [EMAIL PROTECTED] writes: What could happen if I put different Lan card in every slot? In ex. to-private - 3com to-inet- VIA to-dmz - rtl8139 And then to look which RX function is consuming the memory. (boomerang_rx, rtl8139_rx, ... etc) The problem is

Re: [PATCH 00/14] RFC: Driver for Wireless RNDIS USB devices.

2008-01-25 Thread Jussi Kivilinna
On Thu, 2008-01-24 at 17:19 -0800, David Brownell wrote: 13. [rndis_host] blacklist known wireless RNDIS devices That will be a headache over time though ... can't you just let the probe succeed enough to recogize it's wireless (using the media flag) and then bail, so the next driver can

Re: iproute2 (addr flush) infinite loop when unprivileged users

2008-01-25 Thread Stephen Hemminger
On Sat, 26 Jan 2008 01:00:34 +0200 Alon Bar-Lev [EMAIL PROTECTED] wrote: Hello, When executing the following command using unprivileged users there is an infinite loop... /sbin/ip route flush dev eth1 Execution with -s produces: *** Round 28153, deleting 2 entries *** *** Round

Re: [Bugme-new] [Bug 9816] New: cannot replace route

2008-01-25 Thread Jarek Poplawski
Andrew Morton wrote, On 01/25/2008 11:26 PM: On Fri, 25 Jan 2008 13:23:49 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9816 ... I'd agree with Andrea: replacing a route with itself a) used to work and b) should still work (surely)? ...on the other hand:

iproute2 (addr flush) infinite loop when unprivileged users

2008-01-25 Thread Alon Bar-Lev
Hello, When executing the following command using unprivileged users there is an infinite loop... /sbin/ip route flush dev eth1 Execution with -s produces: *** Round 28153, deleting 2 entries *** *** Round 28154, deleting 2 entries *** *** Round 28155, deleting 2 entries *** *** Round 28156,

[PATCH 12/14] [rndis_host] Add RNDIS physical medium checking into generic_rndis_bind()

2008-01-25 Thread Jussi Kivilinna
Add RNDIS physical medium checking into generic_rndis_bind() and also make rndis_host to be only bind on every medium except wireless. Signed-off-by: Jussi Kivilinna [EMAIL PROTECTED] --- drivers/net/usb/rndis_host.c | 34 +++--- drivers/net/usb/rndis_host.h | 19

[PATCH 10/14] [rndis_host] Add early_init function pointer to 'struct rndis_data'.

2008-01-25 Thread Jussi Kivilinna
Function pointer is for 'subminidrivers' that need to do work on device right after minidriver has initialized hardware. For example, rndis_wlan setting device specific configuration parameters with OID_GEN_RNDIS_CONFIG_PARAMETER right after rndis_host has initialized hardware with RNDIS_INIT.

[PATCH 06/14] [usbnet] Use wlan device name for RNDIS wireless devices

2008-01-25 Thread Jussi Kivilinna
Use wlan device name for RNDIS wireless devices. Signed-off-by: Jussi Kivilinna [EMAIL PROTECTED] Signed-off-by: Bjorge Dijkstra [EMAIL PROTECTED] --- drivers/net/usb/usbnet.c |3 +++ drivers/net/usb/usbnet.h |2 ++ 2 files changed, 5 insertions(+), 0 deletions(-) diff --git

[PATCH 05/14] [rndis_host] Fix rndis packet filter flags.

2008-01-25 Thread Jussi Kivilinna
RNDIS packet filter flags are not exactly the same as CDC flags so we cannot reuse them. Signed-off-by: Jussi Kivilinna [EMAIL PROTECTED] Signed-off-by: Bjorge Dijkstra [EMAIL PROTECTED] --- drivers/net/usb/rndis_host.c | 23 ++- 1 files changed, 22 insertions(+), 1

[PATCH 03/14] [rndis_host] Use 1KB buffer in rndis_unbind

2008-01-25 Thread Jussi Kivilinna
rndis_command requires the caller to pass in a buffer of at least 1KB. Signed-off-by: Jussi Kivilinna [EMAIL PROTECTED] Signed-off-by: Bjorge Dijkstra [EMAIL PROTECTED] --- drivers/net/usb/rndis_host.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: 2.6.24-rc6-mm1

2008-01-25 Thread Torsten Kaiser
Sorry for the *really* late answer, but I did not have any time to do linux things the last weeks. :-( On Jan 7, 2008 7:16 AM, FUJITA Tomonori [EMAIL PROTECTED] wrote: On Sun, 6 Jan 2008 21:03:42 +0100 Torsten Kaiser [EMAIL PROTECTED] wrote: On Jan 6, 2008 2:33 PM, FUJITA Tomonori [EMAIL

Re: [Bugme-new] [Bug 9812] New: Kernel does not deliver packets going through the INPUT chain even if the app is listening on IN_ADDR_ANY

2008-01-25 Thread Andrew Morton
On Fri, 25 Jan 2008 03:59:27 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9812 Summary: Kernel does not deliver packets going through the INPUT chain even if the app is listening on IN_ADDR_ANY Product: Networking

Re: [PATCH 10/14] [rndis_host] Add rndis_early_init function pointer to 'struct rndis_data'.

2008-01-25 Thread Jussi Kivilinna
On Thu, 2008-01-24 at 17:10 -0800, David Brownell wrote: Could this -- and #11/14 -- instead be generalized a bit, so they're not RNDIS-specific? At least in name; the only user for now would be the rndis_host code. The generalization would presumably be early_init and link_change, paired

Re: [Bugme-new] [Bug 9812] New: Kernel does not deliver packets going through the INPUT chain even if the app is listening on IN_ADDR_ANY

2008-01-25 Thread Patrick McHardy
Andrew Morton wrote: On Fri, 25 Jan 2008 03:59:27 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9812 Problem Description: I have a farm of web servers behind a load balancer in DSR mode. I would like to be able to dump packets with any IP address on the web

[patch net-2.6.25][IPV4][FIB] fix fib_proc compilation error

2008-01-25 Thread Daniel Lezcano
Subject: fix fib_proc compilation error From: Daniel Lezcano [EMAIL PROTECTED] Fix fib_proc_[init|exit] definition when CONFIG_PROCFS=no Signed-off-by: Daniel Lezcano [EMAIL PROTECTED] --- include/net/ip_fib.h | 10 ++ 1 file changed, 10 insertions(+) Index:

[patch net-2.6.25][IPV6][SYSCTL] fix sysctl compilation error

2008-01-25 Thread Daniel Lezcano
Subject: fix sysctl compilation error From: Daniel Lezcano [EMAIL PROTECTED] Move ipv6_icmp_sysctl_init and ipv6_route_sysctl_init into the right ifdef section otherwise that does not compile when CONFIG_SYSCTL=yes and CONFIG_PROC_FS=no Signed-off-by: Daniel Lezcano [EMAIL PROTECTED] ---

Re: [patch net-2.6.25][IPV6][SYSCTL] fix sysctl compilation error

2008-01-25 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Fri, 25 Jan 2008 14:32:23 +0100), Daniel Lezcano [EMAIL PROTECTED] says: Move ipv6_icmp_sysctl_init and ipv6_route_sysctl_init into the right ifdef section otherwise that does not compile when CONFIG_SYSCTL=yes and CONFIG_PROC_FS=no Signed-off-by: Daniel

[PATCH 1/7 net-2.6.25] [IPV4]: Fix memory leak on error path during FIB initialization.

2008-01-25 Thread Denis V. Lunev
net-ipv4.fib_table_hash is not freed when fib4_rules_init failed. The problem has been introduced by the following commit. commit c8050bf6d84785a7edd2e81591e8f833231477e8 Author: Denis V. Lunev [EMAIL PROTECTED] Date: Thu Jan 10 03:28:24 2008 -0800 Signed-off-by: Denis V. Lunev [EMAIL

[PATCH 2/7 net-2.6.25] [IPV4]: Small style cleanup of the error path in rtm_to_ifaddr.

2008-01-25 Thread Denis V. Lunev
Remove error code assignment inside brackets on failure. The code looks better if the error is assigned before condition check. Also, the compiler treats this better. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/ipv4/devinet.c | 21 - 1 files changed, 8

[PATCH 6/7 net-2.6.25] [NETNS]: Add a namespace mark to fib_info.

2008-01-25 Thread Denis V. Lunev
This is required to make fib_info lookups namespace aware. In the other case initial namespace devices are marked as dead in the local routing table during other namespace stop. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- include/net/ip_fib.h |1 + net/ipv4/fib_semantics.c |8

[PATCH 4/7 net-2.6.25] [NETNS]: Process interface address manipulation routines in the namespace.

2008-01-25 Thread Denis V. Lunev
The namespace is available when required except rtm_to_ifaddr. Add namespace argument to it. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/ipv4/devinet.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index

[PATCH 5/7 net-2.6.25] [IPV4]: fib_sync_down rework.

2008-01-25 Thread Denis V. Lunev
fib_sync_down can be called with an address and with a device. In reality it is called either with address OR with a device. The codepath inside is completely different, so lets separate it into two calls for these two cases. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] ---

[PATCH 3/7 net-2.6.25] [IPV4]: Prohibit assignment of 0.0.0.0 as interface address.

2008-01-25 Thread Denis V. Lunev
I could hardly imagine why sombady needs to assign 0.0.0.0 as an interface address or interface destination address. The kernel will behave in a strage way in several places if this is possible, as ifa_local != 0 is considered as initialized/non-initialized state of the ifa. Signed-off-by: Denis

Re: Slow OOM in netif_RX function

2008-01-25 Thread Arnaldo Carvalho de Melo
Em Fri, Jan 25, 2008 at 02:21:08PM +0100, Andi Kleen escreveu: Ivan H. Dichev [EMAIL PROTECTED] writes: What could happen if I put different Lan card in every slot? In ex. to-private - 3com to-inet- VIA to-dmz - rtl8139 And then to look which RX function is

Re: [PATCH 3/7 net-2.6.25] [IPV4]: Prohibit assignment of 0.0.0.0 as interface address.

2008-01-25 Thread Denis V. Lunev
Daniel Lezcano wrote: Denis V. Lunev wrote: I could hardly imagine why sombady needs to assign 0.0.0.0 as an interface address or interface destination address. The kernel will behave in a strage way in several places if this is possible, as ifa_local != 0 is considered as

[patch 09/11][NETNS][IPV6] fib6_rules: make per network namespace

2008-01-25 Thread Daniel Lezcano
The fib6_rules_ops is moved to the network namespace structure. All references are changed to have it relatively to it. Each time a network namespace is created a new fib6_rules_ops is allocated, initialized and stored into the network namespace structure. The common part of the fib rules is

[patch 11/11][NETNS][IPV6] rt6_stats - make rt6_stats per namespace

2008-01-25 Thread Daniel Lezcano
The rt6_stats is now per namespace with this patch. It is allocated when a network namespace is created and freed when the network namespace exits and references are relative to the network namespace. Signed-off-by: Benjamin Thery [EMAIL PROTECTED] Signed-off-by: Daniel Lezcano [EMAIL PROTECTED]

[patch 02/11][NETNS][IPV6] ip6_fib - make the tables per namespace

2008-01-25 Thread Daniel Lezcano
The fib table for ipv6 are moved to the network namespace structure. All references to them are made relatively to the network namespace. All external calls to the ip6_fib functions taking the network namespace parameter are made using the init_net variable, so the ip6_fib engine is ready for

[patch 01/11][NETNS][IPV6] ip6_fib - dynamically allocate the tables

2008-01-25 Thread Daniel Lezcano
This patch changes the fib6 tables to be dynamically allocated. That provides the ability to make several instances of them when a new network namespace is created. Signed-off-by: Daniel Lezcano [EMAIL PROTECTED] Signed-off-by: Benjamin Thery [EMAIL PROTECTED] --- net/ipv6/ip6_fib.c | 71

Re: [PATCH 3/7 net-2.6.25] [IPV4]: Prohibit assignment of 0.0.0.0 as interface address.

2008-01-25 Thread Daniel Lezcano
Denis V. Lunev wrote: Daniel Lezcano wrote: Denis V. Lunev wrote: I could hardly imagine why sombady needs to assign 0.0.0.0 as an interface address or interface destination address. The kernel will behave in a strage way in several places if this is possible, as ifa_local != 0 is considered

[PATCH 2/3] netns netfilter: netns propagation for /proc/net/*_tables_names

2008-01-25 Thread Alexey Dobriyan
Propagate netns together with AF down to -start/-next/-stop iterators. Choose table based on netns and AF for showing. Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- net/netfilter/x_tables.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) ---

Re: [Bugme-new] [Bug 9811] New: Loopback address to eth0 interface changes scope permanently

2008-01-25 Thread Bjørn Mork
Latest working kernel version: none Earliest failing kernel version: 2.6.18 (verified, but most likely any) Looks like this was introduced in 2.1.68, which makes it a 10 year old bug :-) http://www.linuxhq.com/kernel/v2.1/68/net/ipv4/devinet.c Bjørn -- You sound like a real wimp -- To

Re: [PATCH 3/7 net-2.6.25] [IPV4]: Prohibit assignment of 0.0.0.0 as interface address.

2008-01-25 Thread Stephen Hemminger
On Fri, 25 Jan 2008 16:51:59 +0300 Denis V. Lunev [EMAIL PROTECTED] wrote: I could hardly imagine why sombady needs to assign 0.0.0.0 as an interface address or interface destination address. The kernel will behave in a strage way in several places if this is possible, as ifa_local != 0 is

Re: [patch net-2.6.25][IPV4][FIB] fix fib_proc compilation error

2008-01-25 Thread Stephen Hemminger
Nevermind, Patch looks fine for 2.6.25, it wasn't needed for 2.6.24 Sorry, need more coffee... -- Stephen Hemminger [EMAIL PROTECTED] -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] TCP:Fix a bug in strategy_allowed_congestion_control

2008-01-25 Thread Stephen Hemminger
On Fri, 25 Jan 2008 15:10:13 +0800 shanwei [EMAIL PROTECTED] wrote: hi all: In strategy_allowed_congestion_control of the 2.6.24 kernel, when sysctl_string return 1 on success,it should call tcp_set_allowed_congestion_control to set the allowed congestion control.But, it don't. the

Re: [PATCH 3/7 net-2.6.25] [IPV4]: Prohibit assignment of 0.0.0.0 as interface address.

2008-01-25 Thread Denis V. Lunev
Daniel Lezcano wrote: Denis V. Lunev wrote: Daniel Lezcano wrote: Denis V. Lunev wrote: I could hardly imagine why sombady needs to assign 0.0.0.0 as an interface address or interface destination address. The kernel will behave in a strage way in several places if this is possible, as

Re: [PATCH 3/7 net-2.6.25] [IPV4]: Prohibit assignment of 0.0.0.0 as interface address.

2008-01-25 Thread Daniel Lezcano
Denis V. Lunev wrote: Daniel Lezcano wrote: Denis V. Lunev wrote: Daniel Lezcano wrote: Denis V. Lunev wrote: I could hardly imagine why sombady needs to assign 0.0.0.0 as an interface address or interface destination address. The kernel will behave in a strage way in several places if this

Re: [PATCH for-2.6.25] [POWERPC] Rename commproc to cpm1 and cpm2_common.c to cpm2.c

2008-01-25 Thread Kumar Gala
On Fri, 25 Jan 2008, Jochen Friedrich wrote: Rename commproc.[ch] to cpm1.[ch] to be more consistent with cpm2. Also rename cpm2_common.c to cpm2.c as suggested by Scott Wood. Adjust the includes accordingly. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] ---

Re: [PATCH] [NET]: Remove PowerPC code from fec.c

2008-01-25 Thread Frans Pop
Jochen Friedrich wrote: +++ b/drivers/net/fec.c @@ -23,6 +23,9 @@ * * Bug fixes and cleanup by Philippe De Muyter ([EMAIL PROTECTED]) * Copyright (c) 2004-2006 Macq Electronique SA. + * + * This driver is now only used on ColdFire processors. Remove conditional + * Powerpc code.

Re: [PATCH] [NET]: Remove PowerPC code from fec.c

2008-01-25 Thread Jochen Friedrich
Hi Frans, Jochen Friedrich wrote: +++ b/drivers/net/fec.c @@ -23,6 +23,9 @@ * * Bug fixes and cleanup by Philippe De Muyter ([EMAIL PROTECTED]) * Copyright (c) 2004-2006 Macq Electronique SA. + * + * This driver is now only used on ColdFire processors. Remove conditional + *

Re: [patch net-2.6.25][IPV4][FIB] fix fib_proc compilation error

2008-01-25 Thread Stephen Hemminger
EBOGUSWHITESPACE +static inline void fib_proc_exit(struct net *net) +{ + return ; +} #endif Whole patch is unnecessary, since the fib_proc_init is gone in the tree going into 2.6.25 -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH 1/5] netns netfilter: per-netns ip6tables

2008-01-25 Thread Alexey Dobriyan
On Thu, Jan 24, 2008 at 06:33:37PM +0100, Patrick McHardy wrote: Alexey Dobriyan wrote: * Propagate netns from userspace down to xt_find_table_lock() * Register ip6 tables in netns (modules still use init_net) Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] ---

Re: [PATCH] SCTP: Fix kernel panic while received AUTH chunk while enabled auth

2008-01-25 Thread Vlad Yasevich
Sorry for the delay. Was on vacation without net access. Wei Yongjun wrote: This patch fix this probleam to treat AUTH chunk as unknow chunk if peer has initialized with no auth capable. Signed-off-by: Wei Yongjun [EMAIL PROTECTED] Acked-by: Vlad Yasevich [EMAIL PROTECTED] ---

[PATCH 1/3] netns netfilter: semi-rewrite of /proc/net/foo_tables_*

2008-01-25 Thread Alexey Dobriyan
Argh, there are many small but still wrong things with /proc/net/*_tables_* so I decided to do overhaul simultaneously making it more suitable for per-netns /proc/net/*_tables_* implementation. Fix a) xt_get_idx() duplicating now standard seq_list_start/seq_list_next iterators b)

[patch 00/11][NETNS][IPV6] make a subset of the routing per namespace

2008-01-25 Thread Daniel Lezcano
This patchset makes a subset of the routing to be per namespace. It takes into account fib tables, garbage collecting timer, fib rules and route statistics. The routing per namespace is not complete with this patchset, so there are some interactions between the init network namespace and other

[patch 03/11][NETNS][IPV6] ip6_fib - make fib6_clean_all per namespace

2008-01-25 Thread Daniel Lezcano
The function fib6_clean_all takes the network namespace as parameter. That allows to flush the routes related to a specific network namespace. Signed-off-by: Daniel Lezcano [EMAIL PROTECTED] Signed-off-by: Benjamin Thery [EMAIL PROTECTED] --- include/net/ip6_fib.h |3 ++-

[patch 06/11][NETNS][IPV6] ip6_fib - make the ip6 fib gc timer per network namespace

2008-01-25 Thread Daniel Lezcano
Move the timer initialization at the network namespace creation and store the network namespace in the timer argument. That enables multiple timers (one per network namespace) to do garbage collecting. Signed-off-by: Daniel Lezcano [EMAIL PROTECTED] Signed-off-by: Benjamin Thery [EMAIL

[patch 10/11][NETNS][IPV6] rt6_stats - dynamically allocate the rt6_stats

2008-01-25 Thread Daniel Lezcano
This patch allocates the rt6_stats struct dynamically when the fib6 is initialized. That provides the ability to create several instances of this structure for the network namespaces. Signed-off-by: Daniel Lezcano [EMAIL PROTECTED] Signed-off-by: Benjamin Thery [EMAIL PROTECTED] ---

[patch 05/11][NETNS][IPV6] ip6_fib - dynamically allocate the gc_timer

2008-01-25 Thread Daniel Lezcano
The ip6_fib_timer gc timer is dynamically allocated and initialized in the ip6 fib init function. There are no more references to a static global variable. That will allow to make multiple instance of the garbage collecting timer and make them per namespace. Signed-off-by: Daniel Lezcano [EMAIL

Re: [PATCH] fib_trie: rescan if key is lost during dump

2008-01-25 Thread Jarek Poplawski
On Fri, Jan 25, 2008 at 08:13:15AM -0800, Stephen Hemminger wrote: ... 2. RCU is unnecessary here because of use of RTNL. I am going to defer on this till after #1. That patch is much less important. Thanks! (I've started to suspect another advanced RCU trick already...) Jarek P. -- To

Re: [Bugme-new] [Bug 9816] New: cannot replace route

2008-01-25 Thread Andrew Morton
On Fri, 25 Jan 2008 13:23:49 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9816 Summary: cannot replace route Product: Networking Version: 2.5 KernelVersion: 2.6.24 Platform: All OS/Version: Linux

[PATCH 02/14] [cdc_ether] Hardwire CDC descriptors when missing

2008-01-25 Thread Jussi Kivilinna
From: Bjorge Dijkstra [EMAIL PROTECTED] Just as ActiveSync devices, some regular RNDIS devices also lack the CDC descriptors (e.g. devices based on BCM4320 WLAN chip). This patch hardwires the CDC descriptors for all RNDIS style devices when they are missing. Signed-off-by: Bjorge Dijkstra

[PATCH 04/14] [rndis_host] Halt device if rndis_bind fails.

2008-01-25 Thread Jussi Kivilinna
When bind fails after device was initialized, shutdown device properly by sending RNDIS_MSG_HALT. Signed-off-by: Jussi Kivilinna [EMAIL PROTECTED] Signed-off-by: Bjorge Dijkstra [EMAIL PROTECTED] --- drivers/net/usb/rndis_host.c | 12 +--- 1 files changed, 9 insertions(+), 3

[PATCH 09/14] [usbnet] add driver_priv pointer to 'struct usbnet'

2008-01-25 Thread Jussi Kivilinna
Add a private data pointer to usbnet for rndis_wlan module to use. Signed-off-by: Jussi Kivilinna [EMAIL PROTECTED] --- drivers/net/usb/usbnet.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/usb/usbnet.h b/drivers/net/usb/usbnet.h index 29ab92e..0b4bf09

[PATCH] [TIPC] Kill unused static inline (x5)

2008-01-25 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo=20J=E4rvinen?= [EMAIL PROTECTED] All these static inlines are unused: in_own_zone 1 (net/tipc/addr.h) msg_dataoctet 1 (net/tipc/msg.h) msg_direct 1 (include/net/tipc/tipc_msg.h) msg_options 1 (include/net/tipc/tipc_msg.h) tipc_nmap_get 1

Re: iproute2 (addr flush) infinite loop when unprivileged users

2008-01-25 Thread Alon Bar-Lev
Thanks for quick response! I tried to figure out how to do this, it looks like the libnelink does this anyway... I must missed something. Can you please help? On 1/26/08, Stephen Hemminger [EMAIL PROTECTED] wrote: On Sat, 26 Jan 2008 01:00:34 +0200 Alon Bar-Lev [EMAIL PROTECTED] wrote:

Re: [PATCH 00/14][v3]: Driver for Wireless RNDIS USB devices.

2008-01-25 Thread David Brownell
On Friday 25 January 2008, Jussi Kivilinna wrote: Hello, Here is the third try on wireless RNDIS patchset. Patches 1-9 are from second patchset (with name change rndis_wext - rndis_wlan in comments where needed): 1. Fix sparse warning: returning void valued expression 2. [cdc_ether]