Re: [patch] pegasus.c

2008-02-19 Thread Petko Manolov
This is another attempt on sending the pegasus patch with Alpine. I know it's even worse, but i've attached gzip-ed version just in case. Here goes a brief description of what's changed: --- This patch is fixing a driver bug triggered when malformed string is passed to the 'devid' module

Re: Linux 2.6.24.1 - kernel does not boot; IRQ trouble?

2008-02-19 Thread Kay Sievers
On Feb 18, 2008 9:06 PM, Stephen Hemminger [EMAIL PROTECTED] wrote: On Mon, 18 Feb 2008 19:42:25 + (GMT) Chris Rankin [EMAIL PROTECTED] wrote: --- Stephen Hemminger [EMAIL PROTECTED] wrote: sysfs: duplicate filename 'bridge' can not be created WARNING: at fs/sysfs/dir.c:424

AW: Problem receiving multicast/promiscuous-mode with kernel.2.6.24

2008-02-19 Thread Reither Robert
Visit AVD on prolight+sound in Frankfurt from 12.-15. March 2008 - Hall 8.0, Stand G16 Hi, ok, i managed to shrink down my code to show the behaviour in small size ;-) It shows the same effect as my app, sometimes i get

Re: tbench regression in 2.6.25-rc1

2008-02-19 Thread Zhang, Yanmin
On Tue, 2008-02-19 at 08:35 +0100, Eric Dumazet wrote: Zhang, Yanmin a �crit : On Mon, 2008-02-18 at 11:11 +0100, Eric Dumazet wrote: On Mon, 18 Feb 2008 16:12:38 +0800 Zhang, Yanmin [EMAIL PROTECTED] wrote: On Fri, 2008-02-15 at 15:22 -0800, David Miller wrote: From: Eric Dumazet

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-19 Thread James Chapman
David Miller wrote: From: James Chapman [EMAIL PROTECTED] Date: Mon, 18 Feb 2008 22:09:24 + Here's a new version of the patch. The patch avoids disabling irqs and fixes the sk_dst_get() usage that DaveM mentioned. But even with this patch, lockdep still complains if hundreds of ppp

Re: [PATCH 6/17 net-2.6.26] [NETNS]: Default arp parameters lookup.

2008-02-19 Thread Denis V. Lunev
On Tue, 2008-02-19 at 10:14 +0100, Daniel Lezcano wrote: Denis V. Lunev wrote: Default ARP parameters should be findable regardless of the context. Required to make inetdev_event working. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/core/neighbour.c |4 +--- 1 files

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-19 Thread James Chapman
Jarek Poplawski wrote: On Mon, Feb 18, 2008 at 10:09:24PM +, James Chapman wrote: Jarek Poplawski wrote: Hi, It seems, this nice report is still uncomplete: could you check if there could have been something more yet? Unfortunately the ISP's syslog stops. But I've been able to borrow two

Re: [PATCH 6/17 net-2.6.26] [NETNS]: Default arp parameters lookup.

2008-02-19 Thread Daniel Lezcano
Denis V. Lunev wrote: On Tue, 2008-02-19 at 10:14 +0100, Daniel Lezcano wrote: Denis V. Lunev wrote: Default ARP parameters should be findable regardless of the context. Required to make inetdev_event working. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/core/neighbour.c |4

Re: [PATCH 6/17 net-2.6.26] [NETNS]: Default arp parameters lookup.

2008-02-19 Thread Denis V. Lunev
On Tue, 2008-02-19 at 10:51 +0100, Daniel Lezcano wrote: Denis V. Lunev wrote: On Tue, 2008-02-19 at 10:14 +0100, Daniel Lezcano wrote: Denis V. Lunev wrote: Default ARP parameters should be findable regardless of the context. Required to make inetdev_event working. Signed-off-by:

Re: [PATCH 6/17 net-2.6.26] [NETNS]: Default arp parameters lookup.

2008-02-19 Thread Daniel Lezcano
Denis V. Lunev wrote: On Tue, 2008-02-19 at 10:51 +0100, Daniel Lezcano wrote: Denis V. Lunev wrote: On Tue, 2008-02-19 at 10:14 +0100, Daniel Lezcano wrote: Denis V. Lunev wrote: Default ARP parameters should be findable regardless of the context. Required to make inetdev_event working.

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-19 Thread Jarek Poplawski
On Tue, Feb 19, 2008 at 10:30:47AM +, Jarek Poplawski wrote: ... IMHO, just like I wrote earlier, the main problem is in ppp_generic(), ...or maybe ppp_generic.c? Whatever... Jarek P. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-19 Thread Jarek Poplawski
On Tue, Feb 19, 2008 at 09:03:12AM +, James Chapman wrote: David Miller wrote: From: James Chapman [EMAIL PROTECTED] Date: Mon, 18 Feb 2008 22:09:24 + Here's a new version of the patch. The patch avoids disabling irqs and fixes the sk_dst_get() usage that DaveM mentioned. But even

Re: [PATCH 6/17 net-2.6.26] [NETNS]: Default arp parameters lookup.

2008-02-19 Thread Daniel Lezcano
Denis V. Lunev wrote: Default ARP parameters should be findable regardless of the context. Required to make inetdev_event working. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/core/neighbour.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git

[PATCH net-2.6.26 1/5][SYSCTL]: Merge equal code in sysctl proc handlers.

2008-02-19 Thread Pavel Emelyanov
The -read and -write callbacks act in a very similar way, so merge these paths to reduce the number of places to patch later. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- fs/proc/proc_sysctl.c | 50 ++-- 1 files changed, 11 insertions(+), 39

Re: [Bugme-new] [Bug 9920] New: kernel panic when using ebtables redirect target

2008-02-19 Thread Patrick McHardy
David Miller wrote: From: Joonwoo Park [EMAIL PROTECTED] Date: Tue, 19 Feb 2008 11:53:24 +0900 [PATCH] netfilter: fix incorrect use of skb_make_writable http://bugzilla.kernel.org/show_bug.cgi?id=9920 The function skb_make_writable returns true or false. Signed-off-by: Joonwoo Park [EMAIL

[PATCH net-2.6.26 2/5][SYSCTL]: Clean sysctls from unneeded extern and forward declarations.

2008-02-19 Thread Pavel Emelyanov
The do_sysctl_strategy can be static since it's used in kernel/sysctl.c only. Besides, move it and parse_table above their callers and drop the forward declarations. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- include/linux/sysctl.h |5 -- kernel/sysctl.c| 144

[PATCH net-2.6.26 4/5][SYSCTL]: Create the net sysctl root for RO tables.

2008-02-19 Thread Pavel Emelyanov
This root keeps ctl tables in one global list, but doesn't allow for non-init namespaces to write into tables, stored in it. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- include/net/net_namespace.h |2 ++ net/sysctl_net.c| 33 + 2 files

[PATCH net-2.6.26 5/5][SYSCTL]: Move some net.core sysctls to RO root.

2008-02-19 Thread Pavel Emelyanov
There are many tables in net/core/sysctl_net_core.c that are to be read-only. Current implementation duplicates this array for each namespace just to clear the write bits in the permissions mask. Keep the writable tables to per-net ctl root and move the others to the read-only one. This saves

On the Top of the World~『Textile Industry』

2008-02-19 Thread 『Taiwan News Express』
http://www.taiwannews.com.tw/static/express/080219-01.pdf http://www.taiwannews.com.tw/static/express/080219-02.pdf http://www.taiwannews.com.tw/static/express/080219-03.pdf http://www.taiwannews.com.tw/static/express/080219-04.pdf -- Powered by PHPlist, www.phplist.com -- -- To

Re: [PATCH] net/8021q/vlan_dev.c - Use print_mac

2008-02-19 Thread Patrick McHardy
David Miller wrote: From: David Miller [EMAIL PROTECTED] Date: Mon, 18 Feb 2008 16:43:05 -0800 (PST) I think we can fix this easily by using __attribute_const_ on the print_mac() declaration. Let me play with that. Actually it seems the 'pure' attribute is more important here. Although

Re: [PATCH] cls_u32 u32_classify()

2008-02-19 Thread jamal
On Mon, 2008-18-02 at 21:46 -0800, David Miller wrote: Can some u32 expert review this? http://marc.info/?l=linux-netdevm=120178638323045w=2 cheers, jamal -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH net-2.6.26 0/5][SYSCTL]: Make some sysctl RO in net namespaces.

2008-02-19 Thread Pavel Emelyanov
Hi, David. Some time ago, when I made the net.core.somaxconn ctl per-namespace, you told that the approach I used to make some ctl tables read-only in namespace was not very good and said to improve it. After looking at other code, I decided, that many ctl variables will have to be read-only in

[PATCH net-2.6.26 3/5][SYSCTL]: Add the -permissions callback on the ctl_table_root.

2008-02-19 Thread Pavel Emelyanov
When the table came from some other root, this root may affect the table's permissions, depending on who is working with the table. The core hunk is at the bottom of this patch. All the rest is just pushing the ctl_table_root argument up to the sysctl_perm function. This will be mostly (only?)

[PATCH] [NETNS]: Namespace leak in pneigh_lookup.

2008-02-19 Thread Denis V. Lunev
release_net is missed on the error path in pneigh_lookup. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/core/neighbour.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/core/neighbour.c b/net/core/neighbour.c index 7bb6a9a..174e29e 100644 ---

Re: [NETFILTER]: Introduce nf_inet_address

2008-02-19 Thread David Woodhouse
On Tue, 2008-01-29 at 13:16 +, Linux Kernel Mailing List wrote: Commit: 643a2c15a407faf08101a20e1a3461160711899d [NETFILTER]: Introduce nf_inet_address A few netfilter modules provide their own union of IPv4 and IPv6 address storage. Will unify that in this patch

Re: [PATCH 3/17 net-2.6.26] [NETFILTER]: Consolidate masq_inet_event and masq_device_event.

2008-02-19 Thread Patrick McHardy
Denis V. Lunev wrote: They do exactly the same job. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/ipv4/netfilter/ipt_MASQUERADE.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) Looks fine. -- To unsubscribe from this list: send the line unsubscribe netdev

Re: protocol 0300 is buggy spam in dmesg when injectingcapturing on same interface

2008-02-19 Thread Pekka Pietikainen
On Mon, Feb 18, 2008 at 05:39:03PM +0200, Pekka Pietikainen wrote: When playing with some L2 level fuzzing I started getting lots of protocol 0300 is buggy, dev eth3 spew in dmesg. That interface is also capturing the traffic that's being sent, that's probably why the dev_queue_xmit_nit

[PATCH] [NETLABEL] Minor cleanup: remove unused method definition

2008-02-19 Thread Rami Rosen
Hi, This patch removes definition of netlbl_cfg_cipsov4_del() method in netlabel/netlabel_kapi.c and in include/net/netlabel.h as it is not used. Regards, Rami Rosen Signed-off-by: Rami Rosen [EMAIL PROTECTED] diff --git a/include/net/netlabel.h b/include/net/netlabel.h index 0ca67d7..911d8c6

Re: [NETFILTER]: Introduce nf_inet_address

2008-02-19 Thread David Woodhouse
On Tue, 2008-02-19 at 15:01 +0100, Patrick McHardy wrote: David Woodhouse wrote: +union nf_inet_addr { + u_int32_t all[4]; + __be32 ip; + __be32 ip6[4]; +}; + #ifdef __KERNEL__ #ifdef CONFIG_NETFILTER This breaks the busybox build: CC

Re: AW: AW: Problem receiving multicast with kernel.2.6.24 #3

2008-02-19 Thread Patrick McHardy
Reither Robert wrote: Visit AVD on prolight+sound in Frankfurt from 12.-15. March 2008 - Hall 8.0, Stand G16 OK, found one solution (but i think, this should not the normal way) MC joining first the VLAN device

Re: [NETFILTER]: Introduce nf_inet_address

2008-02-19 Thread Patrick McHardy
David Woodhouse wrote: +union nf_inet_addr { + u_int32_t all[4]; + __be32 ip; + __be32 ip6[4]; +}; + #ifdef __KERNEL__ #ifdef CONFIG_NETFILTER This breaks the busybox build: CC ipsvd/tcpudp.o In file included from

Re: [ANNOUNCE] ESFQ -- SFQ patches for Linux 2.6.24

2008-02-19 Thread Patrick McHardy
David Miller wrote: From: Brock Noland [EMAIL PROTECTED] Date: Sat, 9 Feb 2008 20:30:58 -0600 Is this going to be merged anytime soon? If it gets submitted to the proper mailing list, it might. 'linux-net' is for user questions, it is not where the networking developers hang out, 'netdev'

AW: AW: Problem receiving multicast with kernel.2.6.24 #3

2008-02-19 Thread Reither Robert
Visit AVD on prolight+sound in Frankfurt from 12.-15. March 2008 - Hall 8.0, Stand G16 OK, found one solution (but i think, this should not the normal way) MC joining first the VLAN device (eth0.3) and than the physical

Re: [NETFILTER]: Introduce nf_inet_address

2008-02-19 Thread Patrick McHardy
David Woodhouse wrote: On Tue, 2008-02-19 at 15:01 +0100, Patrick McHardy wrote: David Woodhouse wrote: +union nf_inet_addr { + u_int32_t all[4]; + __be32 ip; + __be32 ip6[4]; +}; + #ifdef __KERNEL__ #ifdef CONFIG_NETFILTER This breaks the busybox

AW: AW: AW: Problem receiving multicast with kernel.2.6.24, REAL solution

2008-02-19 Thread Reither Robert
Visit AVD on prolight+sound in Frankfurt from 12.-15. March 2008 - Hall 8.0, Stand G16 Hurray, your patch does the trick for me !!! Now join/leave und receiving of multicasts work like it should !! May i kiss you

Re: [PATCH 6/17 net-2.6.26] [NETNS]: Default arp parameters lookup.

2008-02-19 Thread Daniel Lezcano
Daniel Lezcano wrote: Denis V. Lunev wrote: On Tue, 2008-02-19 at 10:51 +0100, Daniel Lezcano wrote: Denis V. Lunev wrote: On Tue, 2008-02-19 at 10:14 +0100, Daniel Lezcano wrote: Denis V. Lunev wrote: Default ARP parameters should be findable regardless of the context. Required to make

[NET]: Messed multicast lists after dev_mc_sync/unsync

2008-02-19 Thread Patrick McHardy
commit 6548b91f39381b2c5f02f99c14734546354bff89 Author: Jorge Boncompte [DTI2] [EMAIL PROTECTED] Date: Mon Feb 18 16:02:01 2008 +0100 [NET]: Messed multicast lists after dev_mc_sync/unsync Commit a0a400d79e3dd7843e7e81baa3ef2957bdc292d0 from you introduced a new field

Re: [net-2.6][DRIVER][VETH] fix dev refcount race

2008-02-19 Thread Pavel Emelyanov
Daniel Lezcano wrote: Subject: veth fix dev refcount race From: Daniel Lezcano [EMAIL PROTECTED] When deleting the veth driver, veth_close calls netif_carrier_off for the two extremities of the network device. netif_carrier_off on the peer device will fire an event and hold a reference on

[PATCH][SCTP]: Pick up an orphaned sctp_sockets_allocated counter.

2008-02-19 Thread Pavel Emelyanov
This counter is currently write-only. Drawing an analogy with the similar tcp counter, I think that this one should be pointed by the sockets_allocated members of sctp_prot and sctpv6_prot. Or should it be instead removed at all? Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- diff --git

Re: [Lksctp-developers] [PATCH][SCTP]: Pick up an orphaned sctp_sockets_allocated counter.

2008-02-19 Thread Vlad Yasevich
Pavel Emelyanov wrote: This counter is currently write-only. Drawing an analogy with the similar tcp counter, I think that this one should be pointed by the sockets_allocated members of sctp_prot and sctpv6_prot. Or should it be instead removed at all? Signed-off-by: Pavel Emelyanov [EMAIL

Re: [2.6.25-rc2] e100: Trying to free already-free IRQ 11 during suspend ...

2008-02-19 Thread Kok, Auke
Andrew Morton wrote: On Sun, 17 Feb 2008 15:36:50 +0300 Andrey Borzenkov [EMAIL PROTECTED] wrote: ... and possibly reboot/poweroff (it flows by too fast to be legible). [ 8803.850634] ACPI: Preparing to enter system sleep state S3 [ 8803.853141] Suspending console(s) [ 8805.287505] serial

[PATCH] [2.6.25-rc2] igb: Fix panic with NICs with 1000BASE-SX PHY

2008-02-19 Thread Andy Gospodarek
From: Bill Hayes [EMAIL PROTECTED] Auke, Jeff and David, This patch eliminates a kernel panic with the igb driver in 2.6.25-rc2 when running on a Intel 82575 Ethernet controller with a 1000BASE-SX PHY. The panic does not happen with the 1000BASE-T PHY, only with a SX connection.

Re: [2.6.25-rc2, 2.6.24-rc8] page allocation failure...

2008-02-19 Thread Kok, Auke
Andrew Morton wrote: On Sun, 17 Feb 2008 13:20:59 + Daniel J Blueman [EMAIL PROTECTED] wrote: I'm still hitting this with e1000e on 2.6.25-rc2, 10 times again. are you sure? I don't think that's the case and you're seeing e1000 dumps here... It's clearly non-fatal, but then do we

Re: e1000: Detected Tx Unit Hang

2008-02-19 Thread Kok, Auke
Bernd Schubert wrote: On Saturday 16 February 2008, Kok, Auke wrote: Bernd Schubert wrote: Hello, I can't login to one of our servers and just got this in an ipmi sol session: [18169.209181] e1000: eth0: e1000_clean_tx_irq: Detected Tx Unit Hang [18169.209183] Tx Queue 0

Re: [PATCH 1/3] Support arbitrary initial TCP timestamps

2008-02-19 Thread Glenn Griffin
Adding yet another member to the already bloated tcp_sock structure to implement this is too high a cost. Yes, I was worried that would be deemed too high of a cost, but it was the most efficient way I could think to accomplish what I wanted. I would instead prefer that there be some

Re: TG3 network data corruption regression 2.6.24/2.6.23.4

2008-02-19 Thread Tony Battersby
Michael Chan wrote: On Mon, 2008-02-18 at 16:35 -0800, David Miller wrote: One consequence of Herbert's change is that the chip will see a different datastream. The initial skb-data linear area will be smaller, and the transition to the fragmented area of pages will be quicker.

[net-2.6][DRIVER][VETH] fix dev refcount race

2008-02-19 Thread Daniel Lezcano
Subject: veth fix dev refcount race From: Daniel Lezcano [EMAIL PROTECTED] When deleting the veth driver, veth_close calls netif_carrier_off for the two extremities of the network device. netif_carrier_off on the peer device will fire an event and hold a reference on the peer device. Just

Re: AW: AW: AW: Problem receiving multicast with kernel.2.6.24, REAL solution

2008-02-19 Thread Patrick McHardy
Reither Robert wrote: Visit AVD on prolight+sound in Frankfurt from 12.-15. March 2008 - Hall 8.0, Stand G16 Hurray, your patch does the trick for me !!! Now join/leave und receiving of multicasts work like it should

Re: [PATCH] [NETLABEL] Minor cleanup: remove unused method definition

2008-02-19 Thread Paul Moore
On Tuesday 19 February 2008 9:25:31 am Rami Rosen wrote: Hi, This patch removes definition of netlbl_cfg_cipsov4_del() method in netlabel/netlabel_kapi.c and in include/net/netlabel.h as it is not used. Regards, Rami Rosen Signed-off-by: Rami Rosen [EMAIL PROTECTED] This was added for

[PATCH] igb: Fix panic with NICs with 1000BASE-SX PHY

2008-02-19 Thread Auke Kok
From: Bill Hayes [EMAIL PROTECTED] This patch eliminates a kernel panic with the igb driver in 2.6.25-rc2 when running on a Intel 82575 Ethernet controller with a 1000BASE-SX PHY. The panic does not happen with the 1000BASE-T PHY, only with a SX connection. Signed-off-by: Bill Hayes [EMAIL

Re: TG3 network data corruption regression 2.6.24/2.6.23.4

2008-02-19 Thread Michael Chan
On Tue, 2008-02-19 at 11:16 -0500, Tony Battersby wrote: iSCSI performance drops to 6 - 15 MB/s when the 3Com NIC is doing heavy rx with light tx, That's strange. The patch should only affect TX performance slightly since we are just turning off SG for TX. Please take an ethereal trace to

Re: TG3 network data corruption regression 2.6.24/2.6.23.4

2008-02-19 Thread Tony Battersby
Michael Chan wrote: The SysKonnect NIC that does not exhibit this problem has a chip that says BCM5411KQM TT0128 P2Q and 56975E. I think this is the 5700, but please send me the tg3 output that identifies the chip and the revision. Something like this: eth2: Tigon3 [partno(BCM95705) rev

[RESEND/patch 2.6.25-rc2-git] net/enc28j60: low power mode

2008-02-19 Thread David Brownell
Keep enc28j60 chips in low-power mode when they're not in use. At typically 120 mA, these chips run hot even when idle; this low power mode cuts that power usage by a factor of around 100. This version provides a generic routine to poll a register until its masked value equals some value ... e.g.

[RESEND/patch 2.6.25-rc2-git] net/enc28j60: section fix

2008-02-19 Thread David Brownell
Minor bugfixes to the enc28j60 driver ... wrong section marking, indentation, and bogus use of spi_bus_type. There's still major overuse of printk; essentially every place it's used should switch to dev_*() messaging primitives. Signed-off-by: David Brownell [EMAIL PROTECTED] Acked-by: Claudio

[RESEND/patch 2.6.25-rc2-git] net/enc28j60: oops fix

2008-02-19 Thread David Brownell
Prevent oops on enc28j60 packet RX: make sure buffers are aligned. Not all architectures support unaligned accesses in kernel space. Signed-off-by: David Brownell [EMAIL PROTECTED] Acked-by: Claudio Lanconelli [EMAIL PROTECTED] --- Seems the enc28j60 patches didn't get picked up, ergo resend...

Re: Bonding support for eth1394?

2008-02-19 Thread Stefan Richter
Roland Dreier wrote on 2007-10-13: The bonding sources have a few occurrences of EOPNOTSUPP. Unless I missed something, they are all related to setting the hardware address of the interface. AFAICS this is impossible with IP over FireWire. If it is crucial to bonding to be able to

Re: TG3 network data corruption regression 2.6.24/2.6.23.4

2008-02-19 Thread Tony Battersby
Michael Chan wrote: On Tue, 2008-02-19 at 11:16 -0500, Tony Battersby wrote: iSCSI performance drops to 6 - 15 MB/s when the 3Com NIC is doing heavy rx with light tx, That's strange. The patch should only affect TX performance slightly since we are just turning off SG for TX.

Re: [NET]: Messed multicast lists after dev_mc_sync/unsync

2008-02-19 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Tue, 19 Feb 2008 15:56:59 +0100 [NET]: Messed multicast lists after dev_mc_sync/unsync Commit a0a400d79e3dd7843e7e81baa3ef2957bdc292d0 from you introduced a new field da_synced to struct dev_addr_list that is not properly

[2.6.25 patch] fix broken error handling in ieee80211_sta_process_addba_request()

2008-02-19 Thread Adrian Bunk
The Coverity checker spotted this buggy error handling added by commit 07db218396650933abff3c5c1ad1e2a6e0cfedeb. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 6003e3d899a8fd6425ff509363b776f8807df25d diff --git a/net/mac80211/ieee80211_sta.c b/net/mac80211/ieee80211_sta.c index

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-19 Thread Jarek Poplawski
On Mon, Feb 18, 2008 at 10:09:24PM +, James Chapman wrote: ... Unfortunately the ISP's syslog stops. But I've been able to borrow two Quad Xeon boxes and have reproduced the problem. Here's a new version of the patch. The patch avoids disabling irqs and fixes the sk_dst_get() usage that

[RFC: 2.6.25 patch] ipv4/fib_hash.c: fix NULL dereference

2008-02-19 Thread Adrian Bunk
Unless I miss a guaranteed relation between between f and new_fa-fa_info this patch is required for fixing a NULL dereference introduced by commit a6501e080c318f8d4467679d17807f42b3a33cd5 and spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] ---

Re: [RFC: 2.6.25 patch] ipv4/fib_hash.c: fix NULL dereference

2008-02-19 Thread Eric Dumazet
Adrian Bunk a écrit : Unless I miss a guaranteed relation between between f and new_fa-fa_info this patch is required for fixing a NULL dereference introduced by commit a6501e080c318f8d4467679d17807f42b3a33cd5 and spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED]

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-19 Thread Jarek Poplawski
On Wed, Feb 20, 2008 at 12:06:40AM +0100, Jarek Poplawski wrote: ... (testing patch #1) SORRY!!! take 2 (unlocking fixed) --- drivers/net/ppp_generic.c | 39 +-- 1 files changed, 29 insertions(+), 10 deletions(-) diff --git

Re: [RTNL]: Add missing link netlink attribute policy definitions

2008-02-19 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Wed, 20 Feb 2008 00:46:06 +0100 IFLA_LINK is no longer a write-only attribute on the kernel side and must thus be validated. Same goes for the newly introduced IFLA_LINKINFO. Fixes undefined behaviour if either of the attributes are not well

[2.6 patch] net/phy/mdio_bus.c: fix a check-after-use

2008-02-19 Thread Adrian Bunk
This patch fixes a check-after-use spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 6beeb3ac577d74d72b2f91bd654eecb904c3c17e diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 6e9f619..963630c 100644 --- a/drivers/net/phy/mdio_bus.c +++

kernel BUG at net/core/skbuff.c:95!

2008-02-19 Thread Jim Westfall
Hi I have a reproducible crash that can be triggered remotely at the layer2 level. Example crash outputs is as follows kernel: skb_over_panic: text:c0541fc7 len:1000 put:997 head:c166ac00 data:c166ac2f tail:0xc166b017 end:0xc166ac80 dev:eth0 kernel: [ cut here ]

Re: [RFC: 2.6.25 patch] ipv4/fib_hash.c: fix NULL dereference

2008-02-19 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Wed, 20 Feb 2008 00:06:14 +0100 Adrian Bunk a écrit : Unless I miss a guaranteed relation between between f and new_fa-fa_info this patch is required for fixing a NULL dereference introduced by commit a6501e080c318f8d4467679d17807f42b3a33cd5 and

Re: TG3 network data corruption regression 2.6.24/2.6.23.4

2008-02-19 Thread Michael Chan
On Tue, 2008-02-19 at 17:14 -0500, Tony Battersby wrote: Update: when I revert Herbert's patch in addition to applying your patch, the iSCSI performance goes back up to 115 MB/s again in both directions. So it looks like turning off SG for TX didn't itself cause the performance drop, but

[RTNL]: Add missing link netlink attribute policy definitions

2008-02-19 Thread Thomas Graf
IFLA_LINK is no longer a write-only attribute on the kernel side and must thus be validated. Same goes for the newly introduced IFLA_LINKINFO. Fixes undefined behaviour if either of the attributes are not well formed. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index:

Re: [PATCH 1/2] bluetooth : put hci dev after del conn

2008-02-19 Thread Dave Young
On Feb 19, 2008 12:44 PM, David Miller [EMAIL PROTECTED] wrote: From: Dave Young [EMAIL PROTECTED] Date: Mon, 18 Feb 2008 15:55:55 +0800 Move hci_dev_put to del_conn to avoid hci dev going away before hci conn. This looks correct so I have applied it. Signed-off-by: Dave Young [EMAIL

Re: [PATHCH 1/16] ServerEngines 10Gb NIC driver

2008-02-19 Thread Jay Cliburn
On Mon, 18 Feb 2008 10:00:51 -0800 Subbu Seetharaman [EMAIL PROTECTED] wrote: I have one question about bit fields. Several of headers in the common code are generated by srcgen from f/w source files. Some of the structures in these headers have bit fields (with separate definitions

Re: TG3 network data corruption regression 2.6.24/2.6.23.4

2008-02-19 Thread Matt Carlson
On Tue, Feb 19, 2008 at 05:14:26PM -0500, Tony Battersby wrote: Michael Chan wrote: On Tue, 2008-02-19 at 11:16 -0500, Tony Battersby wrote: iSCSI performance drops to 6 - 15 MB/s when the 3Com NIC is doing heavy rx with light tx, That's strange. The patch should only

Re: TG3 network data corruption regression 2.6.24/2.6.23.4

2008-02-19 Thread Herbert Xu
On Tue, Feb 19, 2008 at 05:14:26PM -0500, Tony Battersby wrote: Update: when I revert Herbert's patch in addition to applying your patch, the iSCSI performance goes back up to 115 MB/s again in both directions. So it looks like turning off SG for TX didn't itself cause the performance drop,

Re: [2.6.25 patch] fix broken error handling in ieee80211_sta_process_addba_request()

2008-02-19 Thread Jarek Poplawski
On 19-02-2008 23:58, Adrian Bunk wrote: ... --- a/net/mac80211/ieee80211_sta.c +++ b/net/mac80211/ieee80211_sta.c @@ -1116,9 +1116,10 @@ static void ieee80211_sta_process_addba_request(struct net_device *dev, ... + printk(KERN_ERR can not allocate reordering buffer +

Re: tbench regression in 2.6.25-rc1

2008-02-19 Thread Zhang, Yanmin
On Tue, 2008-02-19 at 08:40 +0100, Eric Dumazet wrote: Zhang, Yanmin a �crit : On Mon, 2008-02-18 at 12:33 -0500, [EMAIL PROTECTED] wrote: On Mon, 18 Feb 2008 16:12:38 +0800, Zhang, Yanmin said: I also think __refcnt is the key. I did a new testing by adding 2 unsigned long pading

Re: tbench regression in 2.6.25-rc1

2008-02-19 Thread Eric Dumazet
Zhang, Yanmin a écrit : On Tue, 2008-02-19 at 08:40 +0100, Eric Dumazet wrote: Zhang, Yanmin a �crit : On Mon, 2008-02-18 at 12:33 -0500, [EMAIL PROTECTED] wrote: On Mon, 18 Feb 2008 16:12:38 +0800, Zhang, Yanmin said: I also think __refcnt is the key. I did a new testing by adding 2

Re: e1000: Question about polling

2008-02-19 Thread Jarek Poplawski
On 18-02-2008 10:18, Badalian Vyacheslav wrote: Hello all. Hi, Interesting think: Have PC that do NAT. Bandwidth about 600 mbs. Have 4 CPU (2xCoRe 2 DUO HT OFF 3.2 HZ). irqbalance in kernel is off. nat2 ~ # cat /proc/irq/217/smp_affinity 0001 nat2 ~ # cat