On Fri, 2015-04-24 at 08:57 +0800, Herbert Xu wrote:
It seems that I lost track somewhere along the line. I meant
to add an explicit limit on the overall number of entries since
that was what users like netlink expected but never got around
to doing it. Instead it seems that we're currently
On 04/24/2015 05:37 AM, Cong Wang wrote:
On Thu, Apr 23, 2015 at 5:59 PM, Alexei Starovoitov a...@plumgrid.com wrote:
On 4/23/15 3:51 PM, Jamal Hadi Salim wrote:
...
agree. imo ifb approach is more flexible, since it has full hierarchy
of qdiscs. As you're saying above and from the old ifb
From: Li RongQing roy.qing...@gmail.com
Check x-km.state with XFRM_STATE_ACQ only when state is not
XFRM_STAT_VALID, not everytime
Signed-off-by: Li RongQing roy.qing...@gmail.com
---
net/xfrm/xfrm_input.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
From: Sergei Shtylyov
Sent: 22 April 2015 22:39
On 04/22/2015 11:42 PM, David Miller wrote:
Hmm, I've been digging in the net core, and was unable to see where TX
skb's get their NET_IP_ALIGN bytes reserved. Have I missed something?
Probably need to print out skb's fields...
On Fri, Apr 24, 2015 at 09:06:08AM +0100, Thomas Graf wrote:
Which users are you talking about? Both Netlink and TIPC still
have an upper limit. nft sets are controlled by privileged users.
There is no limit in netlink apart from UINT_MAX AFAICS. Allowing
UINT_MAX entries into a hash table
On Fri, Apr 24, 2015 at 09:15:39AM +0100, Thomas Graf wrote:
You are claiming that the rhashtable convertion removed a cap. I'm
not seeing such a change. Can you point me to where netlink_insert()
enforced a cap pre-rhashtable?
OK you are right. We never had such a limit. In that case I'm
Hi Richard,
At Fri, 24 Apr 2015 09:40:32 +0200,
Richard Weinberger wrote:
Hi!
Am 19.04.2015 um 15:28 schrieb Hajime Tazaki:
changes from v2:
- Patch 02/11 (slab: add private memory allocator header for arch/lib)
* add new allocator named SLIB (Library Allocator): Patch 04/11 is
It is hard to quickly find what you are looking for in the output of the
ip command. Color helps.
This patch adds a '-c' flag to highlight these with individual colors:
- interface name
- ip address
- mac address
- up/down state
Signed-off-by: Mathias Nyman m.ny...@iki.fi
---
v3 -
From: Chee Nouk Phoon cnph...@altera.com
This patch resolves false errors from MSGDMA in TX mSGDMA MM to ST
mode, and is a continuation of the patch recently submitted by Andrea
Oetken. The MSGDMA had a logic bug that masked detection of this issue
prior to Quartus 14.1/Build 164. When the MSGDMA
Hi!
Am 24.04.2015 um 10:22 schrieb Hajime Tazaki:
You *really* need to shape up wrt the build process.
at the moment, the implementation of libos can't automate to
follow such changes in the build process. but good news is
it's a trivial task to follow up the latest function.
my
On Fri, Apr 24, 2015 at 09:01:10AM +0200, Johannes Berg wrote:
As allowing 100% utilisation is potentially dangerous, the name
contains the word insecure.
Not sure I get this. So rhashtable is trying to actually never have
collisions? How could that possibly work?
Of course it's not to
On 04/24/15 at 08:57am, Herbert Xu wrote:
It seems that I lost track somewhere along the line. I meant
to add an explicit limit on the overall number of entries since
that was what users like netlink expected but never got around
to doing it. Instead it seems that we're currently relying on
At Fri, 24 Apr 2015 10:59:21 +0200,
Richard Weinberger wrote:
Am 24.04.2015 um 10:22 schrieb Hajime Tazaki:
You *really* need to shape up wrt the build process.
at the moment, the implementation of libos can't automate to
follow such changes in the build process. but good news is
it's
On 04/24/15 at 04:12pm, Herbert Xu wrote:
On Fri, Apr 24, 2015 at 09:06:08AM +0100, Thomas Graf wrote:
Which users are you talking about? Both Netlink and TIPC still
have an upper limit. nft sets are controlled by privileged users.
There is no limit in netlink apart from UINT_MAX AFAICS.
Hello.
On 4/23/2015 10:17 PM, Murali Karicheri wrote:
Currently when interface type is MAC to Phy, netif_carrier_(on/off)
is called which is not needed as Phy lib already updates the carrier
status to net stack. This is needed only for other interface types
Signed-off-by: Murali Karicheri
On 04/24/2015 12:03 PM, David Laight wrote:
Sent: 22 April 2015 22:39
On 04/22/2015 11:42 PM, David Miller wrote:
Hmm, I've been digging in the net core, and was unable to see where TX
skb's get their NET_IP_ALIGN bytes reserved. Have I missed something?
Probably need to print
On Fri, Apr 24, 2015 at 1:15 PM, Dan Williams d...@redhat.com wrote:
On Thu, 2015-04-23 at 14:29 -0700, Mahesh Bandewar wrote:
Processing multicast / broadcast in fast path is performance draining
and having more links means more clonning and bringing performance
down further.
Broadcast; in
-Original Message-
From: Joe Perches [mailto:j...@perches.com]
Sent: Friday, April 24, 2015 1:29 PM
To: Simon Xiao
Cc: KY Srinivasan; Haiyang Zhang; de...@linuxdriverproject.org;
netdev@vger.kernel.org; linux-ker...@vger.kernel.org
Subject: Re: [PATCH net-next,v2,1/1] hv_netvsc:
Hi,
On 24.04.2015 22:45, Gabriel Krisman Bertazi wrote:
@@ -544,30 +544,52 @@ static void bnx2x_set_gro_params(struct sk_buff *skb,
u16 parsing_flags,
static int bnx2x_alloc_rx_sge(struct bnx2x *bp, struct bnx2x_fastpath *fp,
u16 index, gfp_t gfp_mask)
{
-
Commit d81a44625b04d487c895473aa77af13420b7afdd added support for checking
the set*id calls, but would call syslog() before it had called openlog().
Move the call up earlier to fix that.
Signed-off-by: Mike Frysinger vap...@gentoo.org
---
tftpd.c | 3 ++-
1 file changed, 2 insertions(+), 1
On Fri, 2015-04-24 at 17:28 -0400, Sasha Levin wrote:
Hey Eric,
Your commit 79930f5892e (net: do not deplete pfmemalloc reserve) assumes
that
build_skb() will only handle contiguous allocations because of the
virt_to_head_page().
However, netlink_sendmsg() calls build_skb() with
On Fri, 2015-04-24 at 15:02 -0700, Eric Dumazet wrote:
On Fri, 2015-04-24 at 17:28 -0400, Sasha Levin wrote:
Hey Eric,
Your commit 79930f5892e (net: do not deplete pfmemalloc reserve) assumes
that
build_skb() will only handle contiguous allocations because of the
Signed-off-by: Mike Frysinger vap...@gentoo.org
---
Makefile | 5 -
iputils_md5dig.h | 4 +++-
ping6.c | 10 ++
3 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 54e5a6d..7147f08 100644
--- a/Makefile
+++ b/Makefile
@@ -36,7
On Fri, 2015-04-24 at 15:22 +1000, Gavin Shan wrote:
When having permanent EEH error, the PCI device will be removed
from the system. For this case, we shouldn't set pcierr_recovery
to true wrongly, which blocks the driver to release the allocated
interrupts and their handlers. Eventually, we
On Fri, 2015-04-24 at 15:40 -0700, Mahesh Bandewar wrote:
On Fri, Apr 24, 2015 at 1:15 PM, Dan Williams d...@redhat.com wrote:
On Thu, 2015-04-23 at 14:29 -0700, Mahesh Bandewar wrote:
Processing multicast / broadcast in fast path is performance draining
and having more links means more
On Fri, 2015-04-24 at 22:52 +, Simon Xiao wrote:
From: Joe Perches [mailto:j...@perches.com]
On Fri, 2015-04-24 at 11:34 -0700, six...@microsoft.com wrote:
From: Simon Xiao six...@microsoft.com
1. Introduce netif-msg to netvsc to control debug logging output and
keep msg_enable
On Fri, 2015-04-24 at 19:20 +0200, Michael Grzeschik wrote:
The macros SET_SUBADR, ARCRESET, ARCRESET0, ACOMMAND, ASTATUS, AINTMASK
and ADIAGSTATUS are unnecessary indirections to the use of registers.
This patch removes them and improves the readability of the code.
This breaks compilation.
: 16186 Comm: trinity-c182 Not tainted
4.0.0-next-20150424-sasha-00037-g4796e21 #2167
[ 1567.700067] task: 880127efb000 ti: 88024677 task.ti:
88024677
[ 1567.700067] RIP: __phys_addr (arch/x86/mm/physaddr.c:26 (discriminator 3))
[ 1567.700067] RSP: 0018:8802467779d8 EFLAGS
Always use #.# format for the -i flag even when the current locale uses
a different separator. Locale de_DE which uses #,# normally.
Simple testcase:
$ make USE_IDN=1
$ LANG=de_DE.UTF8 ./ping -i 0.5 localhost
Reported-by: Sergey Fionov fio...@gmail.com
Signed-off-by: Mike Frysinger
Commit 43d3ddf87a57 (net: pxa168_eth: add device tree support) starts
to use managed resources by adding devm_clk_get() and
devm_ioremap_resource(), but it leaves explicit iounmap() and clock_put()
in pxa168_eth_remove() and in failure handling code of pxa168_eth_probe().
As a result double free
On Wed, 2015-04-22 at 10:45 -0700, Cong Wang wrote:
The second parameter of eth_get_headlen() is the length of
the frame buffer, not the header length of skb.
Cc: Jeff Kirsher jeffrey.t.kirs...@intel.com
Signed-off-by: Cong Wang xiyou.wangc...@gmail.com
---
Signed-off-by: Jiri Pirko j...@resnulli.us
---
net/core/flow_dissector.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
index 1d4c54d..6a02b26 100644
--- a/net/core/flow_dissector.c
+++
This patch introduces a flow-based filter. So far, the very essential
packet fields are supported.
This patch is only the first step. There is a lot of potential performance
improvements possible to implement. Also a lot of features are missing
now. They will be addressed in follow-up patches.
The USB mini-driver in rtlwifi, which is used by rtl8192cu, issues a call to
usb_control_msg() with a timeout value of 0. In some instances where the
interface is shutting down, this infinite wait results in a CPU deadlock. A
one second timeout fixes this problem without affecting any normal
From: Eric Dumazet eric.duma...@gmail.com
Date: Thu, 23 Apr 2015 10:42:39 -0700
From: Eric Dumazet eduma...@google.com
Presence of an unbound loop in tcp_send_fin() had always been hard
to explain when analyzing crash dumps involving gigantic dying processes
with millions of sockets.
Signed-off-by: Jiri Pirko j...@resnulli.us
---
include/net/flow_dissector.h | 13 +
net/core/flow_dissector.c| 12
2 files changed, 25 insertions(+)
diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h
index 7c9e84c..1fa625b 100644
---
Signed-off-by: Jiri Pirko j...@resnulli.us
---
drivers/net/bonding/bond_main.c| 18 +--
drivers/net/ethernet/cisco/enic/enic_clsf.c| 27 ++--
drivers/net/ethernet/cisco/enic/enic_ethtool.c | 10 +-
drivers/net/hyperv/netvsc_drv.c| 8 +-
add couple of empty lines on the way.
Signed-off-by: Jiri Pirko j...@resnulli.us
---
drivers/net/bonding/bond_main.c | 2 +-
drivers/net/ethernet/cisco/enic/enic_clsf.c | 2 +-
include/linux/skbuff.h | 2 +-
include/net/flow_dissector.h| 53
Signed-off-by: Jiri Pirko j...@resnulli.us
---
include/net/flow_dissector.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h
index 32a7997..b67ce84 100644
--- a/include/net/flow_dissector.h
+++ b/include/net/flow_dissector.h
@@
Signed-off-by: Jiri Pirko j...@resnulli.us
---
net/core/flow_dissector.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
index 9c12692..5213d73 100644
--- a/net/core/flow_dissector.c
+++ b/net/core/flow_dissector.c
Signed-off-by: Jiri Pirko j...@resnulli.us
---
drivers/net/ethernet/cisco/enic/enic_clsf.c| 4 ++--
drivers/net/ethernet/cisco/enic/enic_ethtool.c | 4 ++--
include/net/flow_dissector.h | 9 ++---
include/net/ip.h | 4 ++--
Introduce dissector infrastructure which allows user to specify which
parts of skb he wants to dissect.
Signed-off-by: Jiri Pirko j...@resnulli.us
---
include/net/flow_dissector.h | 61
net/core/flow_dissector.c| 48
So far, only hashes made out of ipv6 addresses could be dissected. This
patch introduces support for dissection of full ipv6 addresses.
Signed-off-by: Jiri Pirko j...@resnulli.us
---
include/net/flow_dissector.h | 13 +
net/core/flow_dissector.c| 29 +
On 24/04/15 08:04, David Miller wrote:
From: Vivien Didelot vivien.dide...@savoirfairelinux.com
Date: Wed, 22 Apr 2015 13:06:54 -0400
Some systems using mdio-gpio may use gpio on message based busses, which
require sleeping (e.g. gpio from an I2C I/O expander).
Since this driver does not
From: Vivien Didelot vivien.dide...@savoirfairelinux.com
Date: Wed, 22 Apr 2015 13:06:54 -0400
Some systems using mdio-gpio may use gpio on message based busses, which
require sleeping (e.g. gpio from an I2C I/O expander).
Since this driver does not use IRQ handler, it is safe to use the
From: Felix Fietkau n...@openwrt.org
Date: Thu, 23 Apr 2015 21:00:04 +0200
On 2015-04-23 20:56, Rafał Miłecki wrote:
After d75b1ade567f (net: less interrupt masking in NAPI) polling
function has to return whole budget when it wants NAPI to call it again.
Signed-off-by: Rafał Miłecki
From: Florian Fainelli f.faine...@gmail.com
Date: Fri, 24 Apr 2015 08:56:34 -0700
On 24/04/15 08:04, David Miller wrote:
From: Vivien Didelot vivien.dide...@savoirfairelinux.com
Date: Wed, 22 Apr 2015 13:06:54 -0400
Some systems using mdio-gpio may use gpio on message based busses, which
On 04/24/2015 09:33 AM, Sergei Shtylyov wrote:
Hello.
On 4/23/2015 10:17 PM, Murali Karicheri wrote:
Currently when interface type is MAC to Phy, netif_carrier_(on/off)
is called which is not needed as Phy lib already updates the carrier
status to net stack. This is needed only for other
From: Eric Dumazet eric.duma...@gmail.com
Date: Thu, 23 Apr 2015 18:03:44 -0700
From: Eric Dumazet eduma...@google.com
[ 3897.923145] BUG: unable to handle kernel NULL pointer dereference at
0080
[ 3897.931025] IP: [a9f27686] reqsk_timer_handler+0x1a6/0x243
There is
From: Herbert Xu herb...@gondor.apana.org.au
Date: Fri, 24 Apr 2015 16:22:11 +0800
On Fri, Apr 24, 2015 at 09:15:39AM +0100, Thomas Graf wrote:
You are claiming that the rhashtable convertion removed a cap. I'm
not seeing such a change. Can you point me to where netlink_insert()
enforced a
From: Marc Kleine-Budde m...@pengutronix.de
Date: Fri, 24 Apr 2015 23:14:41 +0200
On 04/24/2015 08:47 PM, Joe Perches wrote:
On Fri, 2015-04-24 at 19:20 +0200, Michael Grzeschik wrote:
Hi!
Hello.
This patch series tries to reanimate the ARCNET hardware layer to be
somehow readable and
From: Joe Perches j...@perches.com
Date: Fri, 24 Apr 2015 16:04:45 -0700
On Fri, 2015-04-24 at 19:20 +0200, Michael Grzeschik wrote:
The macros SET_SUBADR, ARCRESET, ARCRESET0, ACOMMAND, ASTATUS, AINTMASK
and ADIAGSTATUS are unnecessary indirections to the use of registers.
This patch removes
On Fri, 2015-04-24 at 23:58 -0400, David Miller wrote:
From: Marc Kleine-Budde m...@pengutronix.de
Date: Fri, 24 Apr 2015 23:14:41 +0200
On 04/24/2015 08:47 PM, Joe Perches wrote:
On Fri, 2015-04-24 at 19:20 +0200, Michael Grzeschik wrote:
This patch series tries to reanimate the ARCNET
From: Simon Xiao six...@microsoft.com
1. Introduce netif-msg to netvsc to control debug logging output
and keep msg_enable in netvsc_device_context so that it is
kept persistently.
2. Only call dump_rndis_message() when NETIF_MSG_RX_ERR or above
is specified in netvsc module debug param.
In
On 24/04/15 09:01, David Miller wrote:
From: Florian Fainelli f.faine...@gmail.com
Date: Fri, 24 Apr 2015 08:56:34 -0700
On 24/04/15 08:04, David Miller wrote:
From: Vivien Didelot vivien.dide...@savoirfairelinux.com
Date: Wed, 22 Apr 2015 13:06:54 -0400
Some systems using mdio-gpio may
Summary: Broadcom 5762 NIC locks up under heavy load.
Description:
The tg3 Broadcom network driver that binds with chipset 5762 locks up
when under heavy network load. When this happens, a reboot is
necessary to recover network. Sometimes, bringing the interface
offline and online (via
This patch removes the use of the variable ioaddr in the macros
and uses it directly in the calling functions. This improves
the readability of the code and changes the macros to be used as
offsets.
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
---
drivers/net/arcnet/arc-rimi.c |
This patch changes the driver to properly work with the linux netif
interface. The controller gets enabled on open and disabled on close.
Therefor it removes every bogus start of the xceiver. It only gets
enabled on com20020_open and disabled on com20020_close.
Signed-off-by: Michael Grzeschik
This patch removes the obsolete macro BUS_ALIGN as the kernel option
CONFIG_SA1100_CT6001 is not longer available.
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
---
drivers/net/arcnet/com20020.c | 4 ++--
include/linux/com20020.h | 27 ++-
2 files
The simple macros ARCRESET, ACOMMAND, ASTATUS, AINTMASK are unnecessary
indirections to the use of registers. This patch removes them and improves the
readability of the code.
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
---
drivers/net/arcnet/arc-rimi.c | 24
The commit 9c7077622dd9 (packet: make packet_snd fail on len smaller
than l2 header) adds the check for minimum packet length of the used l2.
For arcnet the hardware header length is not the complete archdr which
includes hard + soft header. This patch changes the length to
sizeof(arc_hardware).
The simple macros ARCRESET, ACOMMAND, ASTATUS, AINTMASK are unnecessary
indirections to the use of registers. This patch removes them and
improves the readability of the code.
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
---
drivers/net/arcnet/com90xx.c | 35
On 04/24/2015 06:56 PM, Florian Fainelli wrote:
Some systems using mdio-gpio may use gpio on message based busses, which
require sleeping (e.g. gpio from an I2C I/O expander).
Since this driver does not use IRQ handler, it is safe to use the
_cansleep suffixed gpio accessors.
This patch cleans the capmode protocol module. It removes the obsolete
function arcnet_cap_init and uses the C99 struct definition. It also
replaces printk with pr_info.
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
---
drivers/net/arcnet/capmode.c | 28 +++-
From: Florian Fainelli f.faine...@gmail.com
Date: Fri, 24 Apr 2015 09:19:55 -0700
On 24/04/15 09:01, David Miller wrote:
From: Florian Fainelli f.faine...@gmail.com
Date: Fri, 24 Apr 2015 08:56:34 -0700
On 24/04/15 08:04, David Miller wrote:
From: Vivien Didelot
The commit 52edc17f94f7bd4d9 (bugfixes and new hardware support for
arcnet driver) adds fixes for the packet length calculations in
arc-rawmode. As the capmode protocol is derived from the arc-rawmode
code, the capmode also needs the fixes.
rx():
- Fixed error in received packet lengths; 256 byte
This patch removes the use of the variable ioaddr in the macros
and uses it directly in the calling functions. This improves
the readability of the code and changes the macros to be used as
offsets.
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
---
drivers/net/arcnet/com90io.c | 86
The macros SET_SUBADR, ARCRESET, ARCRESET0, ACOMMAND, ASTATUS, AINTMASK
and ADIAGSTATUS are unnecessary indirections to the use of registers.
This patch removes them and improves the readability of the code.
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
---
This patch sets the dev_port according to the index of
the card. This can be used by udev to name the ports
in userspace.
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
---
drivers/net/arcnet/com20020-pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git
This patch removes trailing whitespaces in the whole
the ARCNET layer. It also replaces the use of space
with tabs and changes fixes the codingstyle on those lines.
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
---
drivers/net/arcnet/arc-rawmode.c | 4 +-
The EAE PLX-PCI card has a special rotary encoder
to configure the address of every card individually.
We take this information for the initial setup of
the cards dev_id.
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
---
drivers/net/arcnet/com20020-pci.c | 28
Hi Jiri,
Thanks for this work, I think it's a good direction! Some comments below...
On Fri, Apr 24, 2015 at 8:51 AM, Jiri Pirko j...@resnulli.us wrote:
So far, only hashes made out of ipv6 addresses could be dissected. This
patch introduces support for dissection of full ipv6 addresses.
This patch removes the use of the variable ioaddr in the macros
and uses it directly in the calling functions. This improves
the readability of the code and changes the macros to be used as
offsets.
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
---
drivers/net/arcnet/com90xx.c | 52
The call for dev_free_skb is done only once. This patch
moves its call to its only user and removes the obsolete
condition variable.
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
---
drivers/net/arcnet/arcnet.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff
The simple macros ARCRESET, ACOMMAND, ASTATUS, AINTMASK are unnecessary
indirections to the use of registers. This patch removes them and
improves the readability of the code.
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
---
drivers/net/arcnet/com90io.c | 36
next to its user. No relation to flow_dissector so it makes no sense to
have it in flow_dissector.c
Signed-off-by: Jiri Pirko j...@resnulli.us
---
net/core/dev.c| 78 +++
net/core/flow_dissector.c | 78
__skb_tx_hash function has no relation to flow_dissect so just muve it
to skbuff.c (it is declared in skbuff.h)
Signed-off-by: Jiri Pirko j...@resnulli.us
---
net/core/flow_dissector.c | 28
net/core/skbuff.c | 28
2 files
Since these functions are defined in flow_dissector.c, move header
declarations from skbuff.h into flow_dissector.h
Signed-off-by: Jiri Pirko j...@resnulli.us
---
include/linux/skbuff.h | 4
include/net/flow_dissector.h | 3 +++
net/core/filter.c| 1 +
net/ethernet/eth.c
commit 56193d1bce (net: Add function for parsing the header length out
of linear ethernet frames) added this function declaration but it is
defined nowhere.
Signed-off-by: Jiri Pirko j...@resnulli.us
---
include/net/flow_dissector.h | 3 ---
1 file changed, 3 deletions(-)
diff --git
Per Davem's request, I prepared this patchset which introduces programmable
flow dissector. For current users of flow_keys, there is a wrapper
skb_flow_dissect_flow_keys which maintains the previous behaviour.
For purposes of cls_flower, couple of new dissection keys were introduced.
Note that
Since the definition of the function is in flow_dissector.c, it makes
sense to have the declaration in flow_dissector.h
Signed-off-by: Jiri Pirko j...@resnulli.us
---
include/linux/skbuff.h | 1 -
include/net/flow_dissector.h | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff
On 04/24/2015 06:18 PM, Murali Karicheri wrote:
Currently when interface type is MAC to Phy, netif_carrier_(on/off)
is called which is not needed as Phy lib already updates the carrier
status to net stack. This is needed only for other interface types
Signed-off-by: Murali Karicheri
This patch moves the module_init and module_exit patches to
the end of the file. It also replaces the printk with pr_info.
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
---
drivers/net/arcnet/arc-rawmode.c | 87 ++--
1 file changed, 38
This patch changes the macro definitions to match the C99
formating. This improves the readability.
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
---
drivers/net/arcnet/com20020-pci.c | 35 +--
1 file changed, 29 insertions(+), 6 deletions(-)
diff
This patch replaces all magic numbers in the driver with
proper named macros. For the case of XTOcfg and STARTIOcmd
it introduces the new macros.
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
---
drivers/net/arcnet/com20020.c | 21 +++--
include/linux/arcdevice.h
This patch removes the use of the variable ioaddr in the macros
and uses it directly in the calling functions. This improves
the readability of the code and changes the macros to be used as
offsets.
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
---
drivers/net/arcnet/com20020-isa.c
Hi!
This patch series tries to reanimate the ARCNET hardware layer to be
somehow readable and maintainable again. It includes a lot of cleanup
patches. It also adds some fixes which leads the layer to become usable
again. And as a special treatment it adds more features like correct
loading and
The simple macros ARCRESET, ACOMMAND, ASTATUS, AINTMASK are unnecessary
indirections to the use of registers. This patch removes them and improves the
readability of the code.
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
---
drivers/net/arcnet/arcnet.c | 68
On 24/04/15 10:25, Sergei Shtylyov wrote:
On 04/24/2015 06:56 PM, Florian Fainelli wrote:
Some systems using mdio-gpio may use gpio on message based busses,
which
require sleeping (e.g. gpio from an I2C I/O expander).
Since this driver does not use IRQ handler, it is safe to use the
On 04/24/2015 08:36 PM, Florian Fainelli wrote:
Some systems using mdio-gpio may use gpio on message based busses,
which
require sleeping (e.g. gpio from an I2C I/O expander).
Since this driver does not use IRQ handler, it is safe to use the
_cansleep suffixed gpio accessors.
Currently when interface type is MAC to Phy, netif_carrier_(on/off)
is called which is not needed as Phy lib already updates the carrier
status to net stack. This is needed only for other interface types
Signed-off-by: Murali Karicheri m-kariche...@ti.com
---
- Fixed comment against initial
On Fri, 2015-04-24 at 19:20 +0200, Michael Grzeschik wrote:
Hi!
Hello.
This patch series tries to reanimate the ARCNET hardware layer to be
somehow readable and maintainable again. It includes a lot of cleanup
patches. It also adds some fixes which leads the layer to become usable
again.
On 04/23/2015 02:22 AM, Florian Fainelli wrote:
[...]
+if (ecmd-duplex == DUPLEX_FULL)
+priv-duplex = 1;
+else
+priv-duplex = 0;
Why not use what priv-phydev-duplex has cached for you?
Because we compare 'priv-duplex' with 'priv-phydev-duplex' in
Hi!
Am 19.04.2015 um 15:28 schrieb Hajime Tazaki:
changes from v2:
- Patch 02/11 (slab: add private memory allocator header for arch/lib)
* add new allocator named SLIB (Library Allocator): Patch 04/11 is integrated
to 02 (commented by Christoph Lameter)
- Overall
* rewrite commit log
This code assumes that pages are consumed by the device in order. This
is not true. The pages are consumed according to packet arrival
order, which can be from different aggregations.
Thanks for your review. Here is a new version that fixes the issue you
pointed out and fixes some other
On Fri, 2015-04-24 at 12:33 -0400, Toan Pham wrote:
Summary: Broadcom 5762 NIC locks up under heavy load.
Can you provide lspci -vvvxxx -s 3:0.0
after it gets into this state?
Thanks.
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to
On Thu, 2015-04-23 at 14:29 -0700, Mahesh Bandewar wrote:
Processing multicast / broadcast in fast path is performance draining
and having more links means more clonning and bringing performance
down further.
Broadcast; in particular, need to be given to all the virtual links.
Earlier
On Fri, 2015-04-24 at 11:34 -0700, six...@microsoft.com wrote:
From: Simon Xiao six...@microsoft.com
1. Introduce netif-msg to netvsc to control debug logging output
and keep msg_enable in netvsc_device_context so that it is
kept persistently.
2. Only call dump_rndis_message() when
On 04/24/2015 08:47 PM, Joe Perches wrote:
On Fri, 2015-04-24 at 19:20 +0200, Michael Grzeschik wrote:
Hi!
Hello.
This patch series tries to reanimate the ARCNET hardware layer to be
somehow readable and maintainable again. It includes a lot of cleanup
patches. It also adds some fixes
/physaddr.c:26!
[ 1567.700067] invalid opcode: [#1] PREEMPT SMP KASAN
[ 1567.700067] Dumping ftrace buffer:
[ 1567.700067](ftrace buffer empty)
[ 1567.700067] Modules linked in:
[ 1567.700067] CPU: 9 PID: 16186 Comm: trinity-c182 Not tainted
4.0.0-next-20150424-sasha-00037-g4796e21 #2167
100 matches
Mail list logo
