[PATCH] ipv4: Missing sk_nulls_node_init() in ping_unhash().

2015-05-01 Thread David Miller
If we don't do that, then the poison value is left in the -pprev backlink. This can cause crashes if we do a disconnect, followed by a connect(). Tested-by: Linus Torvalds torva...@linux-foundation.org Reported-by: Wen Xu hotdog3...@gmail.com Signed-off-by: David S. Miller da...@davemloft.net

Re: [PATCH next v2 2/3] ipvlan: Process fragmented multicast frames correctly

2015-05-01 Thread David Miller
From: Mahesh Bandewar mahe...@google.com Date: Wed, 29 Apr 2015 11:19:18 -0700 Multicast processing in IPvlan was faulty as is. Eric Dumazet pointed out that fragmented packets won't be processed correctly unless defrag step is introduced. This patch adds the defrag step before driver

Re: [RFC] r8169 DMA failure with iommu=off

2015-05-01 Thread David Miller
From: Stephen Hemminger shemm...@brocade.com Date: Wed, 29 Apr 2015 16:58:13 -0700 In either case since this is a receive DMA buffer, it should set the appropriate GFP_DMA since that may matter on some platforms. Plain GFP_DMA is really only appropriate when used for ISA DMA situations where

Re: [PATCH next v2 1/3] ipvlan: Defer multicast / broadcast processing to a work-queue

2015-05-01 Thread David Miller
From: Mahesh Bandewar mahe...@google.com Date: Wed, 29 Apr 2015 11:19:16 -0700 + dev_queue_xmit(skb); + } else { + kfree_skb(skb); } } + return; } Please do not add trailing return statements to functions

[GIT] Networking

2015-05-01 Thread David Miller
1) Receive packet length needs to be adjust by 2 on RX to accomodate the two padding bytes in altera_tse driver. From Vlastimil Setka. 2) If rx frame is dropped due to out of memory in macb driver, we leave the receive ring descriptors in an undefined state. From Punnaiah Choudary

Re: [PATCH net-next] ipv4: speedup ip_idents_reserve()

2015-05-01 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Fri, 01 May 2015 10:37:49 -0700 From: Eric Dumazet eduma...@google.com Under stress, ip_idents_reserve() is accessing a contended cache line twice, with non optimal MESI transactions. If we place timestamps in separate location, we reduce

Re: [PATCH net-next 0/5] ipv6: Stop /128 route from disappearing after pmtu update

2015-05-01 Thread David Miller
From: Martin KaFai Lau ka...@fb.com Date: Tue, 28 Apr 2015 13:03:02 -0700 The series is separated from another patch series, 'ipv6: Only create RTF_CACHE route after encountering pmtu exception', which can be found here: Looks good, and the divorce of inetpeer from ipv6 routes is especially

Re: [PATCH v2 net-next] tc: remove unused redirect ttl

2015-05-01 Thread David Miller
From: Cong Wang cw...@twopensource.com Date: Fri, 1 May 2015 13:33:28 -0700 Quote from Documentation/SubmittingPatches: The from line must be the very first line in the message body, and has the form: From: Original Author aut...@example.com The from line specifies who will

[RFC PATCH net-next v3 8/9] ipv6: Break up ip6_rt_copy()

2015-05-01 Thread Martin KaFai Lau
This patch breaks up ip6_rt_copy() into ip6_rt_copy_init() and ip6_rt_cache_alloc(). In the later patch, we need to create a percpu rt6_info copy. Hence, refactor the common rt6_info init codes to ip6_rt_copy_init(). Signed-off-by: Martin KaFai Lau ka...@fb.com Cc: Hannes Frederic Sowa

Re: [PATCH net-next] net: rocker: Use ether_addr_equal

2015-05-01 Thread David Miller
From: Simon Horman simon.hor...@netronome.com Date: Thu, 30 Apr 2015 15:21:29 +0900 A small cleanup to make use of the ether_addr_equal helper. Signed-off-by: Simon Horman simon.hor...@netronome.com Applied. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [PATCH v2 net-next] tc: remove unused redirect ttl

2015-05-01 Thread David Miller
From: Alexei Starovoitov a...@plumgrid.com Date: Fri, 01 May 2015 20:15:49 -0700 On 5/1/15 4:48 PM, David Miller wrote: From: Cong Wang cw...@twopensource.com Date: Fri, 1 May 2015 13:33:28 -0700 Quote from Documentation/SubmittingPatches: The from line must be the very first line in the

Re: [PATCH 2/3] r8169: Use dev_kfree_skb in Tx cleanup path

2015-05-01 Thread David Miller
From: Lino Sanfilippo linosanfili...@gmx.de Date: Fri, 01 May 2015 14:15:42 +0200 On 01.05.2015 14:06, Lino Sanfilippo wrote: which did just the opposite: replace dev_kfree() with dev_kfree_any() for that reason. See Um, this should of course be dev_kfree_skb() and dev_kfree_skb_any().

Re: [PATCH 0/3] Stop using dev_kfree_skb_any in NAPI Tx clean-up

2015-05-01 Thread David Miller
From: Alexander Duyck alexander.h.du...@redhat.com Date: Thu, 30 Apr 2015 13:58:12 -0700 This change replaces the call to dev_kfree_skb_any in several NAPI based Tx clean-up paths with dev_kfree_skb. Where I made the replacement the function appeared to always be in softirq context so we can

[PATCH linux v1 net-next 1/4] bonding: Allow userspace to set actors' system_priority in AD system

2015-05-01 Thread Jonathan Toppins
From: Mahesh Bandewar mahe...@google.com This patch allows user to randomize the system-priority in an ad-system. The allowed range is 1 - 0x while default value is 0x. If user does not specify this value, the system defaults to 0x, which is what it was before this patch. Following

Re: [PATCH] Allow TCP connections to cache SYN packet for userspace inspection

2015-05-01 Thread Tom Herbert
On Fri, May 1, 2015 at 11:42 AM, Eric Dumazet eric.duma...@gmail.com wrote: On Fri, 2015-05-01 at 13:43 -0400, Eric B Munson wrote: In order to enable policy decisions in userspace, the data contained in the SYN packet would be useful for tracking or identifying connections. Only parts of this

[PATCH net-next #3 3/8] via-rhine: gotoize rhine_open error path.

2015-05-01 Thread Francois Romieu
Signed-off-by: Francois Romieu rom...@fr.zoreil.com --- drivers/net/ethernet/via/via-rhine.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/via/via-rhine.c b/drivers/net/ethernet/via/via-rhine.c index aa398ea..91661e0 100644 ---

[PATCH v2 net-next 1/7] net: Add skb_get_hash_perturb

2015-05-01 Thread Tom Herbert
This calls flow_disect and __skb_get_hash to procure a hash for a packet. Input includes a key to initialize jhash. This function does not set skb-hash. Signed-off-by: Tom Herbert t...@herbertland.com --- include/linux/skbuff.h| 2 ++ net/core/flow_dissector.c | 38

[PATCH 2/3] netconsole: make all dynamic netconsoles share a mutex

2015-05-01 Thread Tejun Heo
Currently, each dynamic netconsole_target uses its own separate mutex to synchronize the configuration operations. This patch replaces the per-netconsole_target mutexes with a single mutex - dynamic_netconsole_mutex. The reduced granularity doesn't hurt anything, the code is minutely simpler and

pull-request: can 2015-05-01

2015-05-01 Thread Marc Kleine-Budde
RGMII-ID mode (2015-04-30 16:48:53 -0400) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git tags/linux-can-fixes-for-4.1-20150501 for you to fetch changes up to 5793affe8c723ece8114b898ab9003c7d97f86d1: net: can: xilinx_can: fix extended

Re: [PATCH v2 net-next] tc: remove unused redirect ttl

2015-05-01 Thread Sergei Shtylyov
Hello. On 5/1/2015 6:11 AM, Alexei Starovoitov wrote: improves ingress+u32 performance from 22.4 Mpps to 22.9 Mpps Signed-off-by: Jamal Hadi Salim j...@mojatatu.com Signed-off-by: Alexei Starovoitov a...@plumgrid.com --- The code is from Jamal. I only did testing and benchmarking. Then

Re: [PATCH -next] net: sched: remove TC_MUNGED bits

2015-05-01 Thread Florian Westphal
Jamal Hadi Salim j...@mojatatu.com wrote: On 04/30/15 17:16, Alexei Starovoitov wrote: On Thu, Apr 30, 2015 at 12:12:00PM +0200, Florian Westphal wrote: Not used. pedit sets TC_MUNGED when packet content was altered, but all the core does is unset MUNGED again and then set OK2MUNGE. And

Re: [PATCH] net: can: xilinx_can: fix extended frame handling

2015-05-01 Thread Marc Kleine-Budde
On 04/29/2015 05:05 PM, Jeppe Ledet-Pedersen wrote: Using IDR_SRR in RXFIFO_ID to test for the presence of data is only valid for standard frames. For extended frames the bit is always 1 and IDR_RTR should be used instead. This patch switches the check to use CAN_RTR_FLAG which is correctly

Re: [PATCH net-next] net: sched: run ingress qdisc without locks

2015-05-01 Thread Jamal Hadi Salim
On 04/30/15 23:14, Alexei Starovoitov wrote: TC classifiers/actions were converted to RCU by John in the series: http://thread.gmane.org/gmane.linux.network/329739/focus=329739 and many follow on patches. This is the last patch from that series that finally drops ingress spin_lock. As the

Re: [RFC] r8169 DMA failure with iommu=off

2015-05-01 Thread Francois Romieu
Stephen Hemminger shemm...@brocade.com : This only fixes the Rx side, what about Tx? I think maybe just removing the whole use_dac flag completely ? Something simple would be welcome but I doubt it should be that simple. The problems that the use_dac comment (MODULE_PARM_DESC) relates to are