Re: [PATCH v5 3/3] ixgbe: Add new ndo to trust VF

2015-05-27 Thread Edward Cree
On 27/05/15 01:27, Hiroshi Shimamoto wrote: I think the VF shouldn't directly know whether it is trusted or not That's completely irrevelant. The person administering the PF will be the person who provided trusted privileges to the VF. He'll then *tell* or somehow other communicate to the

Re: [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface

2015-05-27 Thread Steffen Klassert
On Wed, May 27, 2015 at 04:01:05PM +0800, Herbert Xu wrote: Hi: The only changes from the last version are that set_ad no longer takes a cryptoff argument and testmgr has been updated to always supply space for the authentication tag. The algif_aead patch has been removed and will be

Re: [PATCH] sctp: Fix mangled IPv4 addresses on a IPv6 listening socket

2015-05-27 Thread Daniel Borkmann
On 05/27/2015 11:06 AM, David Laight wrote: From: Jason Gunthorpe ... Fixes: 299ee123e198 (sctp: Fixup v4mapped behaviour to comply with Sock API) ... This bugfix should be a candidate for -stable Anyone know off-hand which kernel releases are affected? I'm going to have to note this in

RE: [PATCH] sctp: Fix mangled IPv4 addresses on a IPv6 listening socket

2015-05-27 Thread David Laight
From: Daniel Borkmann Sent: 27 May 2015 10:34 ... Fixes: 299ee123e198 (sctp: Fixup v4mapped behaviour to comply with Sock API) ... This bugfix should be a candidate for -stable Anyone know off-hand which kernel releases are affected? I'm going to have to note this in the release

Re: [PATCH v4] bnx2x: Alloc 4k fragment for each rx ring buffer element

2015-05-27 Thread Michal Schmidt
On 05/21/2015 03:20 PM, Gabriel Krisman Bertazi wrote: +#define SGE_PAGE_SHIFT 12 +#define SGE_PAGE_SIZE(1 SGE_PAGE_SHIFT) ... +struct bnx2x_alloc_pool { + struct page *page; + dma_addr_t dma; + u8 offset; + u8

Re: [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface

2015-05-27 Thread Johannes Berg
On Wed, 2015-05-27 at 17:07 +0800, Herbert Xu wrote: On Wed, May 27, 2015 at 11:00:40AM +0200, Johannes Berg wrote: Right. Unfortunately, I can't typically rely on being able to make changes to the kernel our driver is built against, and I don't think we could do these changes otherwise.

Re: [PATCH net v2] xen/netback: Properly initialize credit_bytes

2015-05-27 Thread Wei Liu
On Wed, May 27, 2015 at 11:44:32AM +0100, Ross Lagerwall wrote: Commit e9ce7cb6b107 (xen-netback: Factor queue-specific data into queue struct) introduced a regression when moving queue-specific data into the queue struct by failing to set the credit_bytes field. This prevented bandwidth

Re: Looking for a lost patch

2015-05-27 Thread Steffen Klassert
On Thu, May 21, 2015 at 05:25:24PM -0400, David Miller wrote: From: Steffen Klassert steffen.klass...@secunet.com Date: Wed, 20 May 2015 08:32:23 +0200 On Tue, May 19, 2015 at 11:32:15AM -0700, Alexander Duyck wrote: On 05/19/2015 12:57 AM, Steffen Klassert wrote: The MTU should be 1500.

Re: [PATCH net-next] bridge: skip fdb add if the port shouldn't learn

2015-05-27 Thread Nikolay Aleksandrov
On Wed, May 27, 2015 at 9:59 AM, Scott Feldman sfel...@gmail.com wrote: On Wed, May 27, 2015 at 12:05 AM, Nikolay Aleksandrov niko...@cumulusnetworks.com wrote: On Tue, May 26, 2015 at 7:28 PM, Stephen Hemminger step...@networkplumber.org wrote: On Thu, 21 May 2015 03:42:57 -0700 Nikolay

Re: [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface

2015-05-27 Thread Johannes Berg
On Wed, 2015-05-27 at 16:39 +0800, Herbert Xu wrote: On Wed, May 27, 2015 at 10:15:50AM +0200, Johannes Berg wrote: Do you think it'd be feasible at all to somehow override the aead_request_set_crypt() and aead_request_set_ad() functions or so to do something that works on older kernels

[PATCH net v2] xen/netback: Properly initialize credit_bytes

2015-05-27 Thread Ross Lagerwall
Commit e9ce7cb6b107 (xen-netback: Factor queue-specific data into queue struct) introduced a regression when moving queue-specific data into the queue struct by failing to set the credit_bytes field. This prevented bandwidth limiting from working. Initialize the field as it was done before

Re: [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface

2015-05-27 Thread Herbert Xu
On Wed, May 27, 2015 at 11:25:33AM +0200, Steffen Klassert wrote: Not sure if I missed something in the flood of patches, but if I apply your v3 patchset on top of the cryptodev tree, it crashes like that buring boot: Sorry, I forgot to mention that v3 depends on the series of fixes posted

RE: [PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-27 Thread David Laight
From: Of Ido Yariv Sent: 26 May 2015 21:17 The Tail Loss Probe RFC specifies that the PTO value should be set to max(2 * SRTT, 10ms), where SRTT is the smoothed round-trip time. The PTO value is converted to jiffies, so the timer may expire prematurely. This is especially problematic on

[PATCH net-next 1/2] cxgb4: Add debugfs facility to inject FL starvation

2015-05-27 Thread Hariprasad Shenai
Add debugfs entry to inject Freelist starvation, used only for debugging purpose. Signed-off-by: Hariprasad Shenai haripra...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 1 + drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 56 ++

[PATCH net-next 2/2] cxgb4/cxgb4vf: function and argument name cleanup

2015-05-27 Thread Hariprasad Shenai
This patch changes variable name 'fn' to 'pf' of structure adapter. A 'fn' usually stands for PCI function which could be a PF or a VF. However, the use of this particular variable is explicitly limited to PF only. So, be specific about it in the variable name. Also corrects arguments passed for

Re: [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface

2015-05-27 Thread Herbert Xu
On Wed, May 27, 2015 at 11:00:40AM +0200, Johannes Berg wrote: Right. Unfortunately, I can't typically rely on being able to make changes to the kernel our driver is built against, and I don't think we could do these changes otherwise. You could provide your own version of crypto_aead_encrypt

Re: [PATCH] mlx4_core: Fix fallback from MSI-X to INTx

2015-05-27 Thread Yishai Hadas
On 5/23/2015 2:12 AM, Benjamin Poirier wrote: The test in mlx4_load_one() to remove MLX4_FLAG_MSI_X expects mlx4_NOP() to fail with -EBUSY. It is also necessary to avoid the reset since the device is not fully reinitialized before calling mlx4_start_hca() a second time. Note that this will also

Re: [PATCH 1/2] connector: add cgroup release event report to proc connector

2015-05-27 Thread Zefan Li
On 2015/5/27 6:07, Dimitri John Ledkov wrote: Add a kernel API to send a proc connector notification that a cgroup has become empty. A userspace daemon can then act upon such information, and usually clean-up and remove such a group as it's no longer needed. Currently there are two other

Re: [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface

2015-05-27 Thread Johannes Berg
The conversion of in-tree users is fairly straightforward. It is pretty much - but a related question (that you totally don't have to answer if you don't want to think about this). I'm going to have to (continue) backport(ing) this code to older kernels for customer support, and I prefer

Re: [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface

2015-05-27 Thread Herbert Xu
On Wed, May 27, 2015 at 10:15:50AM +0200, Johannes Berg wrote: Do you think it'd be feasible at all to somehow override the aead_request_set_crypt() and aead_request_set_ad() functions or so to do something that works on older kernels (and thus older crypto subsystems) or do you think I just

Re: [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface

2015-05-27 Thread Steffen Klassert
On Wed, May 27, 2015 at 05:29:22PM +0800, Herbert Xu wrote: On Wed, May 27, 2015 at 11:25:33AM +0200, Steffen Klassert wrote: Not sure if I missed something in the flood of patches, but if I apply your v3 patchset on top of the cryptodev tree, it crashes like that buring boot: Sorry,

RE: [PATCH] net: netxen: correct sysfs bin attribute return code

2015-05-27 Thread Manish Chopra
-Original Message- From: Vladimir Zapolskiy [mailto:v...@mleia.com] Sent: Tuesday, May 26, 2015 6:20 AM To: David Miller; Manish Chopra; Sony Chacko; Rajesh Borundia Cc: netdev Subject: [PATCH] net: netxen: correct sysfs bin attribute return code If read() syscall requests

Re: [RFC V7 PATCH 7/7] vhost_net: add interrupt coalescing support

2015-05-27 Thread Jason Wang
On 05/27/2015 02:02 AM, Stephen Hemminger wrote: On Mon, 25 May 2015 01:24:04 -0400 Jason Wang jasow...@redhat.com wrote: Signed-off-by: Jason Wang jasow...@redhat.com --- drivers/vhost/net.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/vhost/net.c

Re: [ovs-dev] [PATCH net] openvswitch: disable LRO unless stated otherwise

2015-05-27 Thread Flavio Leitner
On Wed, May 27, 2015 at 10:50:21AM +0200, Jiri Benc wrote: On Tue, 26 May 2015 15:03:56 -0700, Pravin Shelar wrote: OVS interface for generic networking device operation looks odd. have you considered adding new device ioctl to do this? New ioctls for networking configuration are generally

[PATCH net-next v4 0/3] sfc: add MCDI tracing

2015-05-27 Thread Edward Cree
This patchset adds support for logging MCDI (Management-Controller-to- Driver Interface) interactions between the sfc driver and a bound device, to aid in debugging. Solarflare has a tool to decode the resulting traces and will look to open-source this if there is any external interest, but the

Re: Bug in tcp timestamp option ? TSecr in SYN-ACK != TSval in SYN

2015-05-27 Thread Eric Dumazet
On Wed, 2015-05-27 at 06:33 -0700, Eric Dumazet wrote: The problem is in linux code itself. Please try the patch I sent ? (On the client) On the server, sorry for the typo. diff --git a/net/ipv4/tcp_minisocks.c b/net/ipv4/tcp_minisocks.c index

Re: Bug in tcp timestamp option ? TSecr in SYN-ACK != TSval in SYN

2015-05-27 Thread Eric Dumazet
On Wed, 2015-05-27 at 00:09 -0700, Gopakumar Choorakkot Edakkunni wrote: Hi Eric, Thanks a lot for the response, and sorry about the 3-times-email, was not sure whether majordomo accepted my subscription or not and hence the retx :) So if a sequence happens as below 1. Client sends the

Re: [PATCH 1/2] connector: add cgroup release event report to proc connector

2015-05-27 Thread Dimitri John Ledkov
On 27 May 2015 at 12:22, Zefan Li lize...@huawei.com wrote: On 2015/5/27 6:07, Dimitri John Ledkov wrote: Add a kernel API to send a proc connector notification that a cgroup has become empty. A userspace daemon can then act upon such information, and usually clean-up and remove such a group

Re: [PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-27 Thread Eric Dumazet
On Wed, 2015-05-27 at 11:36 +, David Laight wrote: From: Of Ido Yariv Sent: 26 May 2015 21:17 The Tail Loss Probe RFC specifies that the PTO value should be set to max(2 * SRTT, 10ms), where SRTT is the smoothed round-trip time. The PTO value is converted to jiffies, so the timer

[PATCH net-next 1/3] sfc: add tracing of MCDI commands

2015-05-27 Thread Edward Cree
MCDI tracing is conditional on CONFIG_SFC_MCDI_LOGGING, which is enabled by default. Each MCDI command will produce a console line like sfc dom:bus:dev:fn ifname: MCDI RPC REQ: [...] where etc. are the raw MCDI payload in 32-bit hex chunks. The response will then

[PATCH net-next 3/3] sfc: add module parameter to enable MCDI logging on new functions

2015-05-27 Thread Edward Cree
As many issues are encountered at probe time, where MCDI logging can't be enabled through the sysfs node, this change adds a module parameter 'mcdi_logging_default', which defaults to false. When set to true, newly- probed functions will have MCDI logging enabled. The setting can

[PATCH net-next 2/3] sfc: add sysfs entry to control MCDI tracing

2015-05-27 Thread Edward Cree
MCDI tracing is enabled per-function with a sysfs file /sys/class/net/NET_DEV/device/mcdi_logging Signed-off-by: Edward Cree ec...@solarflare.com --- drivers/net/ethernet/sfc/Kconfig | 3 ++- drivers/net/ethernet/sfc/efx.c | 49 ++--

Re: [PATCH net-next v4 0/3] sfc: add MCDI tracing

2015-05-27 Thread David Miller
From: Edward Cree ec...@solarflare.com Date: Wed, 27 May 2015 13:12:31 +0100 This patchset adds support for logging MCDI (Management-Controller-to- Driver Interface) interactions between the sfc driver and a bound device, to aid in debugging. Solarflare has a tool to decode the resulting

Re: Bug in tcp timestamp option ? TSecr in SYN-ACK != TSval in SYN

2015-05-27 Thread Eric Dumazet
On Wed, 2015-05-27 at 10:29 -0700, Gopakumar Choorakkot Edakkunni wrote: Thanks Eric. I will give this a spin. The issue doesnt happen all the time, I can keep the server running with this patch for a while and observe if the issue resurfaces or not Note that if the traffic on the server is

Re: Bug in tcp timestamp option ? TSecr in SYN-ACK != TSval in SYN

2015-05-27 Thread Eric Dumazet
On Wed, 2015-05-27 at 10:57 -0700, Eric Dumazet wrote: On Wed, 2015-05-27 at 10:29 -0700, Gopakumar Choorakkot Edakkunni wrote: Thanks Eric. I will give this a spin. The issue doesnt happen all the time, I can keep the server running with this patch for a while and observe if the issue

[PATCH V2 5/5] net: stmmac: ipq806x: document device tree bindings

2015-05-27 Thread Mathieu Olivari
Add the device tree bindings documentation for the QCA IPQ806x variant of the Synopsys DesignWare MAC. Signed-off-by: Mathieu Olivari math...@codeaurora.org --- .../devicetree/bindings/net/ipq806x-dwmac.txt | 35 ++ 1 file changed, 35 insertions(+) create mode 100644

Re: [PATCHv1] xen-netfront: properly destroy queues when removing device

2015-05-27 Thread David Miller
From: David Vrabel david.vra...@citrix.com Date: Wed, 27 May 2015 15:46:10 +0100 xennet_remove() freed the queues before freeing the netdevice which results in a use-after-free when free_netdev() tries to delete the napi instances that have already been freed. Fix this by fully destroy the

[PATCH V2 3/5] stmmac: add fixed-link device-tree support

2015-05-27 Thread Mathieu Olivari
In case DT is used, this change adds the ability to the stmmac driver to detect a fixed-link PHY, instanciate it, and use it during phy_connect(). Fixed link PHYs DT usage is described in: Documentation/devicetree/bindings/net/fixed-link.txt Signed-off-by: Mathieu Olivari math...@codeaurora.org

[PATCH V2 4/5] stmmac: add ipq806x glue layer

2015-05-27 Thread Mathieu Olivari
The ethernet controller available in IPQ806x is a Synopsys DesignWare Gigabit MAC IP core, already supported by the stmmac driver. This glue layer implements some platform specific settings required to get the controller working on an IPQ806x based platform. Signed-off-by: Mathieu Olivari

[PATCH V2 0/5] Add support for QCA IPQ806x Ethernet GMAC controller

2015-05-27 Thread Mathieu Olivari
This patch set adds support for the integrated Ethernet GMAC controller on QCA IPQ806x SoC. This controller is based on a Gigabit Synopsys DesignWare IP, already supported in the stmmac driver located in drivers/net/ethernet/stmicro/stmmac. This change is done as a follow-up to the following

[PATCH V2 2/5] stmmac: add phy-handle support to the platform layer

2015-05-27 Thread Mathieu Olivari
On stmmac driver, PHY specification in device-tree was done using the non-standard property snps,phy-addr. Specifying a PHY on a different MDIO bus that the one within the stmmac controller doesn't seem to be possible when device-tree is used. This change adds support for the phy-handle property,

[PATCH V2 1/5] clk: qcom: Add support for NSS/GMAC clocks and resets

2015-05-27 Thread Mathieu Olivari
From: Stephen Boyd sb...@codeaurora.org Add the NSS/GMAC clocks and the TCM clock and NSS resets. Signed-off-by: Stephen Boyd sb...@codeaurora.org Signed-off-by: Mathieu Olivari math...@codeaurora.org --- drivers/clk/qcom/gcc-ipq806x.c | 594 ++-

Re: [PATCH net-next] vxlan: release lock after each bucket in vxlan_cleanup

2015-05-27 Thread Sorin Dumitru
On Wed, May 27, 2015 at 8:44 PM, Cong Wang cw...@twopensource.com wrote: On Tue, May 26, 2015 at 12:42 AM, Sorin Dumitru so...@returnze.ro wrote: We're seeing some softlockups from this function when there are a lot fdb entries on a vxlan device. Taking the lock for each bucket instead of the

Re: [Patch net] net_sched: invoke -attach() after setting dev-qdisc

2015-05-27 Thread David Miller
From: Cong Wang xiyou.wangc...@gmail.com Date: Tue, 26 May 2015 16:08:48 -0700 For mq qdisc, we add per tx queue qdisc to root qdisc for display purpose, however, that happens too early, before the new dev-qdisc is finally set, this causes q-list points to an old root qdisc which is going to

Re: [PATCH net-next 1/1] hv_netvsc: Properly size the vrss queues

2015-05-27 Thread David Miller
From: K. Y. Srinivasan k...@microsoft.com Date: Tue, 26 May 2015 16:21:09 -0700 The current algorithm for deciding on the number of VRSS channels is not optimal since we open up the min of number of CPUs online and the number of VRSS channels the host is offering. So on a 32 VCPU guest we

Re: Bug in tcp timestamp option ? TSecr in SYN-ACK != TSval in SYN

2015-05-27 Thread Gopakumar Choorakkot Edakkunni
Doesnt seem so. This is the output from one of the servers I have where I periodically hit this TSval != TSecr condition. ubuntu@server:~$ sudo su root@server:/home/ubuntu# sysctl net.ipv4.tcp_tw_recycle net.ipv4.tcp_tw_recycle = 0 root@server:/home/ubuntu# sysctl net.ipv4.tcp_tw_reuse

Re: [PATCH net-next v2] test_bpf: add similarly conflicting jump test case only for classic

2015-05-27 Thread David Miller
From: Daniel Borkmann dan...@iogearbox.net Date: Tue, 26 May 2015 22:35:43 +0200 While 3b52960266a3 (test_bpf: add more eBPF jump torture cases) added the int3 bug test case only for eBPF, which needs exactly 11 passes to converge, here's a version for classic BPF with 11 passes, and one that

Re: [PATCH] sctp: Fix mangled IPv4 addresses on a IPv6 listening socket

2015-05-27 Thread David Miller
From: Jason Gunthorpe jguntho...@obsidianresearch.com Date: Tue, 26 May 2015 17:30:17 -0600 sctp_v4_map_v6 was subtly writing and reading from members of a union in a way the clobbered data it needed to read before it read it. Zeroing the v6 flowinfo overwrites the v4 sin_addr with 0,

Re: [PATCH v3] isdn: Use ktime_t instead of 'struct timeval'

2015-05-27 Thread David Miller
From: Tina Ruchandani ruchandani.t...@gmail.com Date: Wed, 27 May 2015 06:52:12 +0530 'struct timeval' uses 32-bit representation for seconds which will overflow in year 2038 and beyond. mISDN/clock.c needs to compute and store elapsed time in intervals of 125 microseconds. This patch replaces

Re: [PATCH net-next v6 0/2] Adding support for Cavium ThunderX network controller

2015-05-27 Thread David Miller
From: Aleksey Makarov aleksey.maka...@caviumnetworks.com Date: Tue, 26 May 2015 19:20:13 -0700 This patchset adds support for the Cavium ThunderX network controller. Series applied, thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

RE: [PATCH net-next 1/1] hv_netvsc: Properly size the vrss queues

2015-05-27 Thread KY Srinivasan
-Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: Wednesday, May 27, 2015 11:13 AM To: KY Srinivasan Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; jasow...@redhat.com Subject: Re:

Re: [PATCH net-next] qla4xxx: add a missing include

2015-05-27 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Tue, 26 May 2015 21:43:44 -0700 From: Eric Dumazet edum...@google.com vmalloc.h used to be included from include/net/inet_hashtables.h but it is no longer the case. Fixes: 095dc8e0c368 (tcp: fix/cleanup inet_ehash_locks_alloc())

Re: [PATCH net-next 0/2] cxgb4/cxgb4vf: Adds FL starvation support and cleanup

2015-05-27 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Wed, 27 May 2015 22:30:22 +0530 This patch series adds the following. Adds debugfs entry to inject freelist starvation and some function and argument cleanup This patch series has been created against net-next tree and includes patches

Re: [PATCH net-next] tcp: connect() from bound sockets can be faster

2015-05-27 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Wed, 27 May 2015 10:46:02 -0700 From: Eric Dumazet eduma...@google.com __inet_hash_connect() does not use its third argument (port_offset) if socket was already bound to a source port. No need to perform useless but expensive md5

Re: [PATCH net-next] vxlan: release lock after each bucket in vxlan_cleanup

2015-05-27 Thread David Miller
From: Cong Wang cw...@twopensource.com Date: Wed, 27 May 2015 10:44:26 -0700 On Tue, May 26, 2015 at 12:42 AM, Sorin Dumitru so...@returnze.ro wrote: We're seeing some softlockups from this function when there are a lot fdb entries on a vxlan device. Taking the lock for each bucket instead of

Re: [PATCH net-next] qla4xxx: add a missing include

2015-05-27 Thread James Bottomley
On Wed, 2015-05-27 at 14:21 -0400, David Miller wrote: From: Eric Dumazet eric.duma...@gmail.com Date: Tue, 26 May 2015 21:43:44 -0700 From: Eric Dumazet edum...@google.com vmalloc.h used to be included from include/net/inet_hashtables.h but it is no longer the case. Fixes:

[PATCH net-next] tcp/dccp: warn user for preferred ip_local_port_range

2015-05-27 Thread Eric Dumazet
From: Eric Dumazet eduma...@google.com After commit 07f4c90062f8f (tcp/dccp: try to not exhaust ip_local_port_range in connect()) it is advised to have an even number of ports described in /proc/sys/net/ipv4/ip_local_port_range This means start/end values should have a different parity. Let's

[PATCH net iproute2 v2 1/2] mpls: always set type as RTN_UNICAST for route add/deletes

2015-05-27 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com Kernel expects type RTN_UNICAST for mpls route/dels Signed-off-by: Vivek Venkataraman vi...@cumulusnetworks.com Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- ip/iproute.c |5 + 1 file changed, 5 insertions(+) diff --git

[PATCH net v2 0/2] mpls: fix route del errors on wrong scope and type

2015-05-27 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This patch fixes incorrect -EINVAL errors due to invalid scope and type during mpls route deletes. $ip -f mpls route add 100 as 200 via inet 10.1.1.2 dev swp1 $ip -f mpls route show 100 as to 200 via inet 10.1.1.2 dev swp1 $ip -f mpls route del 100

[PATCH net v2 2/2] mpls: fix mpls route deletes to not check for route scope

2015-05-27 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com Ignore scope for route del messages Signed-off-by: Vivek Venkataraman vi...@cumulusnetworks.com Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- net/mpls/af_mpls.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [PATCH net-next] tcp/dccp: warn user for preferred ip_local_port_range

2015-05-27 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Wed, 27 May 2015 11:34:37 -0700 From: Eric Dumazet eduma...@google.com After commit 07f4c90062f8f (tcp/dccp: try to not exhaust ip_local_port_range in connect()) it is advised to have an even number of ports described in

[PATCH RFC] 8139cp: make timeout HZ independent

2015-05-27 Thread Nicholas Mc Guire
is -next-20150527) Signed-off-by: Nicholas Mc Guire hof...@osadl.org --- As there is no documentation of the intended timeout it might be wrong to convert it with msecs_to_jiffies as this can reduces the actual jiffies value by at least a factor of 10 - so someone that knows this driver needs

[GIT] Networking

2015-05-27 Thread David Miller
1) Don't use MMIO on certain iwlwifi devices otherwise we get a firmware crash. 2) Don't corrupt the GRO lists of mac80211 contexts by doing sends via timer interrupt, from Johannes Berg. 3) SKB tailroom is miscalculated in AP_VLAN crypto code, from Michal Kazior. 4) Fix fw_status

[PATCH V2 net-next 1/1] hv_netvsc: Properly size the vrss queues

2015-05-27 Thread K. Y. Srinivasan
The current algorithm for deciding on the number of VRSS channels is not optimal since we open up the min of number of CPUs online and the number of VRSS channels the host is offering. So on a 32 VCPU guest we could potentially open 32 VRSS subchannels. Experimentation has shown that it is best to

Re: [PATCH iproute2] enable transparent LFS

2015-05-27 Thread Stephen Hemminger
On Tue, 26 May 2015 02:51:30 -0400 Mike Frysinger vap...@gentoo.org wrote: From: Mike Frysinger vap...@chromium.org Make sure we use 64-bit filesystem functions everywhere. This applies not only to being able to read large files (which generally doesn't apply to us), but also being able to

Re: [PATCH] pci: Use a bus-global mutex to protect VPD operations

2015-05-27 Thread Rustad, Mark D
On May 27, 2015, at 10:27 AM, Bjorn Helgaas bhelg...@google.com wrote: It sounds like there are real problems here that would be fixed by changing the mutex strategy and limiting VPD read lengths, but that we don't quite have consensus on how to solve them yet. I have a new pair of patches

Re: [PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-27 Thread Ido Yariv
Hi Eric, On Wed, May 27, 2015 at 10:24:16AM -0700, Eric Dumazet wrote: On Wed, 2015-05-27 at 12:54 -0400, Ido Yariv wrote: Hi Eric, That's a nice optimization ;) However, I think that with Nicholas Mc Guire's recent changes to msecs_to_jiffies

[PATCH net-next] net: limit tcp/udp rmem/wmem to SOCK_{RCV,SND}BUF_MIN

2015-05-27 Thread Sorin Dumitru
This is similar to b1cb59cf2efe(net: sysctl_net_core: check SNDBUF and RCVBUF for min length). I don't think too small values can cause crashes in the case of udp and tcp, but I've seen this set to too small values which triggered awful performance. It also makes the setting consistent across all

Re: Looking for a lost patch

2015-05-27 Thread David Miller
From: Steffen Klassert steffen.klass...@secunet.com Date: Wed, 27 May 2015 10:35:16 +0200 We currently check if a socket is attached to a skb and do socket error notification in this case, otherwise we do PMTU discovery if the packet is too big. Looks like this socket check is not sufficient

RE: [PATCH v5 3/3] ixgbe: Add new ndo to trust VF

2015-05-27 Thread Rose, Gregory V
-Original Message- From: Skidmore, Donald C Sent: Wednesday, May 27, 2015 8:34 AM To: Edward Cree; Hiroshi Shimamoto Cc: Rose, Gregory V; Kirsher, Jeffrey T; intel-wired-...@lists.osuosl.org; nhor...@redhat.com; jogre...@redhat.com; Linux Netdev List; Choi, Sy Jong; Rony Efraim;

RE: [PATCH v5 3/3] ixgbe: Add new ndo to trust VF

2015-05-27 Thread Rose, Gregory V
-Original Message- From: Skidmore, Donald C Sent: Wednesday, May 27, 2015 9:01 AM To: Rose, Gregory V; Hiroshi Shimamoto; Kirsher, Jeffrey T; intel-wired- l...@lists.osuosl.org Cc: nhor...@redhat.com; jogre...@redhat.com; Linux Netdev List; Choi, Sy Jong; Rony Efraim; David Miller;

RE: [PATCH] sctp: Fix mangled IPv4 addresses on a IPv6 listening socket

2015-05-27 Thread David Laight
From: Jason Gunthorpe Sent: 27 May 2015 16:32 On Wed, May 27, 2015 at 10:11:22AM +, David Laight wrote: In any case it looks like I can escape by turning off SCTP_I_WANT_MAPPED_V4_ADDR for kernels 3.17 through 4.0. Just be aware that option is unusable on kernels without 299ee. I

Re: __inet_hash_connect port_offset parameter

2015-05-27 Thread Eric Dumazet
On Wed, 2015-05-27 at 18:25 +0300, Crestez Dan Leonard wrote: Hello, I'm confused about the port_offset parameter to __inet_hash_connect. When allocating the local port for an outgoing TCP connection the port search looks something like this: static u32 hint; u32 offset = hint

Re: RE: [bisected regression] e1000e: Detected Hardware Unit Hang

2015-05-27 Thread Thomas Jarosch
Hi Aaron, On Monday, 23. March 2015 22:37:08 Brown, Aaron F wrote: And with an internal reproduction of the issue I have created an internal bug report, described my set of reproductions, referenced the similar external ones and assigned it to our current e1000e developer.

Re: [PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-27 Thread Eric Dumazet
On Wed, 2015-05-27 at 11:23 -0400, Ido Yariv wrote: Signed-off-by: Ido Yariv idox.ya...@intel.com --- include/net/tcp.h | 9 + net/ipv4/tcp_output.c | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/include/net/tcp.h b/include/net/tcp.h index

4.0.4 - bnx2x - DEBUG_LOCKS_WARN_ON(in_interrupt())

2015-05-27 Thread Nikola Ciprich
Hi, just wanted to report, that I'm getting following trace on 4.0.4 kernel: [ +0.301517] [ cut here ] [ +0.000227] WARNING: CPU: 0 PID: 0 at kernel/locking/mutex.c:877 mutex_trylock+0x15d/0x190() [ +0.000376] DEBUG_LOCKS_WARN_ON(in_interrupt()) [ +0.72] Modules

Re: [PATCH] sctp: Fix mangled IPv4 addresses on a IPv6 listening socket

2015-05-27 Thread Jason Gunthorpe
On Wed, May 27, 2015 at 10:11:22AM +, David Laight wrote: In any case it looks like I can escape by turning off SCTP_I_WANT_MAPPED_V4_ADDR for kernels 3.17 through 4.0. Just be aware that option is unusable on kernels without 299ee. I fixed everything wrong I saw, but that doesn't mean it

Re: [ovs-dev] [PATCH net] openvswitch: disable LRO unless stated otherwise

2015-05-27 Thread David Miller
From: Flavio Leitner f...@sysclose.org Date: Wed, 27 May 2015 10:24:14 -0300 On Wed, May 27, 2015 at 10:50:21AM +0200, Jiri Benc wrote: On Tue, 26 May 2015 15:03:56 -0700, Pravin Shelar wrote: OVS interface for generic networking device operation looks odd. have you considered adding new

Re: [PATCH net-next] bridge: skip fdb add if the port shouldn't learn

2015-05-27 Thread Scott Feldman
On Wed, May 27, 2015 at 1:35 AM, Nikolay Aleksandrov niko...@cumulusnetworks.com wrote: On Wed, May 27, 2015 at 9:59 AM, Scott Feldman sfel...@gmail.com wrote: On Wed, May 27, 2015 at 12:05 AM, Nikolay Aleksandrov niko...@cumulusnetworks.com wrote: On Tue, May 26, 2015 at 7:28 PM, Stephen

RE: [PATCH v5 3/3] ixgbe: Add new ndo to trust VF

2015-05-27 Thread Skidmore, Donald C
-Original Message- From: Edward Cree [mailto:ec...@solarflare.com] Sent: Wednesday, May 27, 2015 2:04 AM To: Hiroshi Shimamoto Cc: Rose, Gregory V; Skidmore, Donald C; Kirsher, Jeffrey T; intel-wired- l...@lists.osuosl.org; nhor...@redhat.com; jogre...@redhat.com; Linux Netdev

RE: [PATCH 4/5] stmmac: add ipq806x glue layer

2015-05-27 Thread Mathieu Olivari
My bad. This is ISC license. MODULE_LICENSE should actually be Dual BSD/GPL. Same license is used in other places in the kernel like drivers/net/wireless/ath/ath10k/pci.c. I'll post a v2. Thanks, Mathieu -Original Message- From: Paul Bolle [mailto:pebo...@tiscali.nl] Sent: Wednesday,

Re: [PATCH net-next] bridge: skip fdb add if the port shouldn't learn

2015-05-27 Thread Nikolay Aleksandrov
On Wed, May 27, 2015 at 6:01 PM, Scott Feldman sfel...@gmail.com wrote: On Wed, May 27, 2015 at 1:35 AM, Nikolay Aleksandrov niko...@cumulusnetworks.com wrote: On Wed, May 27, 2015 at 9:59 AM, Scott Feldman sfel...@gmail.com wrote: On Wed, May 27, 2015 at 12:05 AM, Nikolay Aleksandrov

__inet_hash_connect port_offset parameter

2015-05-27 Thread Crestez Dan Leonard
Hello, I'm confused about the port_offset parameter to __inet_hash_connect. When allocating the local port for an outgoing TCP connection the port search looks something like this: static u32 hint; u32 offset = hint + port_offset; inet_get_local_port_range(net, low, high);

[ipsec PATCH 3/3] ip_vti/ip6_vti: Preserve skb-mark after rcv_cb call

2015-05-27 Thread Alexander Duyck
The vti6_rcv_cb and vti_rcv_cb calls were leaving the skb-mark modified after completing the function. This resulted in the original skb-mark value being lost. Since we only need skb-mark to be set for xfrm_policy_check we can pull the assignment into the rcv_cb calls and then just restore the

Re: [PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-27 Thread Ido Yariv
Hi Eric, On Wed, May 27, 2015 at 07:56:25AM -0700, Eric Dumazet wrote: On Wed, 2015-05-27 at 10:40 -0400, Ido Yariv wrote: HZ=100 is used on some embedded platforms, so it's still something we have to deal with unfortunately.. Since the '2' here is a lower bound, and

Re: [PATCH] sctp: Fix mangled IPv4 addresses on a IPv6 listening socket

2015-05-27 Thread Neil Horman
On Tue, May 26, 2015 at 05:30:17PM -0600, Jason Gunthorpe wrote: sctp_v4_map_v6 was subtly writing and reading from members of a union in a way the clobbered data it needed to read before it read it. Zeroing the v6 flowinfo overwrites the v4 sin_addr with 0, meaning that every place that

[PATCHv1] xen-netfront: properly destroy queues when removing device

2015-05-27 Thread David Vrabel
xennet_remove() freed the queues before freeing the netdevice which results in a use-after-free when free_netdev() tries to delete the napi instances that have already been freed. Fix this by fully destroy the queues (which includes deleting the napi instances) before freeing the netdevice.

Re: [PATCHv1] xen-netfront: properly destroy queues when removing device

2015-05-27 Thread Boris Ostrovsky
On 05/27/2015 10:46 AM, David Vrabel wrote: xennet_remove() freed the queues before freeing the netdevice which results in a use-after-free when free_netdev() tries to delete the napi instances that have already been freed. Fix this by fully destroy the queues (which includes deleting the napi

[ipsec PATCH 0/3] Preserve skb-mark through VTI tunnels

2015-05-27 Thread Alexander Duyck
These patches are meant to try and address the fact the VTI tunnels are currently overwriting the skb-mark value. I am generally happy with the first two patches, however the third patch still modifies the skb-mark, though it undoes after the fact. The main problem I am trying to address is the

Re: [PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-27 Thread Ido Yariv
Hi Eric, On Wed, May 27, 2015 at 06:41:17AM -0700, Eric Dumazet wrote: On Wed, 2015-05-27 at 11:36 +, David Laight wrote: From: Of Ido Yariv Sent: 26 May 2015 21:17 The Tail Loss Probe RFC specifies that the PTO value should be set to max(2 * SRTT, 10ms), where SRTT is the

Re: [PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-27 Thread Eric Dumazet
On Wed, 2015-05-27 at 10:40 -0400, Ido Yariv wrote: HZ=100 is used on some embedded platforms, so it's still something we have to deal with unfortunately.. Since the '2' here is a lower bound, and msecs_to_jiffies(10) will return values greater than 2 for HZ100 anyway, always ensuring the

[ipsec PATCH 1/3] ip_vti/ip6_vti: Do not touch skb-mark on xmit

2015-05-27 Thread Alexander Duyck
Instead of modifying skb-mark we can simply modify the flowi_mark that is generated as a result of the xfrm_decode_session. By doing this we don't need to actually touch the skb-mark and it can be preserved as it passes out through the tunnel. Signed-off-by: Alexander Duyck

[ipsec PATCH 2/3] xfrm: Override skb-mark with tunnel-parm.i_key in xfrm_input

2015-05-27 Thread Alexander Duyck
This change makes it so that if a tunnel is defined we just use the mark from the tunnel instead of the mark from the skb header. By doing this we can avoid the need to set skb-mark inside of the tunnel receive functions. Signed-off-by: Alexander Duyck alexander.h.du...@redhat.com ---

Re: __inet_hash_connect port_offset parameter

2015-05-27 Thread Eric Dumazet
On Wed, 2015-05-27 at 09:18 -0700, Eric Dumazet wrote: On Wed, 2015-05-27 at 18:25 +0300, Crestez Dan Leonard wrote: Hello, I'm confused about the port_offset parameter to __inet_hash_connect. When allocating the local port for an outgoing TCP connection the port search looks

Re: [PATCH v5 3/3] ixgbe: Add new ndo to trust VF

2015-05-27 Thread Edward Cree
On 27/05/15 16:55, Rose, Gregory V wrote: There's nothing to prevent any vendor from notifying a VF that it has privileges and there's nothing that require that they do. This should be a vendor specific detail. Agreed - purely a driver implementation detail. So now that I've stated my

Re: [PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-27 Thread Eric Dumazet
On Wed, 2015-05-27 at 12:54 -0400, Ido Yariv wrote: Hi Eric, That's a nice optimization ;) However, I think that with Nicholas Mc Guire's recent changes to msecs_to_jiffies (http://marc.info/?l=linux-kernelm=143195210010666), we should get this for free, no? Well, on net and net-next tree

Re: [PATCH] pci: Use a bus-global mutex to protect VPD operations

2015-05-27 Thread Bjorn Helgaas
On Mon, May 18, 2015 at 05:00:37PM -0700, Mark D Rustad wrote: Some devices have a problem with concurrent VPD access to different functions of the same physical device, so move the protecting mutex from the pci_vpd structure to the pci_bus structure. There are a number of reports on support

RE: [PATCH] sctp: Fix mangled IPv4 addresses on a IPv6 listening socket

2015-05-27 Thread David Laight
From: Jason Gunthorpe Sent: 27 May 2015 17:32 On Wed, May 27, 2015 at 04:16:44PM +, David Laight wrote: From: Jason Gunthorpe Sent: 27 May 2015 16:32 On Wed, May 27, 2015 at 10:11:22AM +, David Laight wrote: In any case it looks like I can escape by turning off

[RFC 5/6] VSOCK: Introduce vhost-vsock.ko

2015-05-27 Thread Stefan Hajnoczi
From: Asias He as...@redhat.com VM sockets vhost transport implementation. This module runs in host kernel. Signed-off-by: Asias He as...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- drivers/vhost/vsock.c | 596 ++

[RFC 0/6] Add virtio transport for AF_VSOCK

2015-05-27 Thread Stefan Hajnoczi
This patch series adds a virtio transport for AF_VSOCK (net/vmw_vsock/). AF_VSOCK is designed for communication between virtual machines and hypervisors. It is currently only implemented for VMware's VMCI transport. This series implements the proposed virtio-vsock device specification from here:

  1   2   >