Re: [PATCH net-next] bpf: allow BPF programs access skb->skb_iif and skb->dev->ifindex fields

2015-05-28 Thread Daniel Borkmann
On 05/28/2015 12:30 AM, Alexei Starovoitov wrote: classic BPF already exposes skb->dev->ifindex via SKF_AD_IFINDEX extension. Allow eBPF program to access it as well. Note that classic aborts execution of the program if 'skb->dev == NULL' (which is inconvenient for program writers), whereas eBPF

Re: [PATCH] xfrm6: Do not use xfrm_local_error for path MTU issues in tunnels

2015-05-28 Thread Alexander Duyck
On 05/28/2015 01:40 AM, Steffen Klassert wrote: On Thu, May 28, 2015 at 12:18:51AM -0700, Alexander Duyck wrote: On 05/27/2015 10:36 PM, Steffen Klassert wrote: On Wed, May 27, 2015 at 10:40:32AM -0700, Alexander Duyck wrote: This change makes it so that we use icmpv6_send to report PMTU issue

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-05-28 Thread Or Gerlitz
On Thu, May 28, 2015 at 9:22 PM, Doug Ledford wrote: >> I don't think that is what Doug said. > Indeed. There is no need to scrap things, but if the design as it > stands, and the intended means of creating objects for use in > containers, is going to result in an unworkable network, then we ha

Re: linux-next: build failure after merge of most of the trees

2015-05-28 Thread Joe Perches
On Thu, 2015-05-28 at 11:42 -0700, David Miller wrote: > I've applied the following to net-next, thanks for your report. > > > [PATCH] treewide: Add missing vmalloc.h inclusion. > > All of these files were only building on non-x86 because of > the indirect of inclusion of vma

Re: linux-next: build failure after merge of most of the trees

2015-05-28 Thread David Miller
From: Stephen Rothwell Date: Thu, 28 May 2015 22:06:07 +1000 > Ouch :-( The only thing I will say on this matter is that the _only_ way this problem will go away is if someone does the work necessary to get rid of that implicit vmalloc.h include that happens on all x86 platform builds. So if yo

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-05-28 Thread Doug Ledford
On Thu, 2015-05-28 at 11:43 -0600, Jason Gunthorpe wrote: > On Thu, May 28, 2015 at 07:21:11PM +0300, Or Gerlitz wrote: > > > Anything else except for that (you said "reworking of the network scripts > > and NetworkManager assumptions to make it work")?? > > IPv6 becomes very broken, child interf

[PATCH v4 net-next 07/11] net: Get rid of IPv6 hash addresses flow keys

2015-05-28 Thread Tom Herbert
We don't need to return the IPv6 address hash as part of flow keys. In general, using the IPv6 address hash is risky in a hash value since the underlying use of xor provides no entropy. If someone really needs the hash value they can get it from the full IPv6 addresses in flow keys (e.g. from flow_

[PATCH v4 net-next 08/11] net: Add VLAN ID to flow_keys

2015-05-28 Thread Tom Herbert
In flow_dissector set vlan_id in flow_keys when VLAN is found. Signed-off-by: Tom Herbert --- include/net/flow_dissector.h | 6 ++ net/core/flow_dissector.c| 14 ++ 2 files changed, 20 insertions(+) diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h in

[PATCH v4 net-next 06/11] net: Add keys for TIPC address

2015-05-28 Thread Tom Herbert
Add a new flow key for TIPC addresses. Signed-off-by: Tom Herbert --- include/net/flow_dissector.h | 10 ++ net/core/flow_dissector.c| 18 +- 2 files changed, 23 insertions(+), 5 deletions(-) diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h in

[PATCH v4 net-next 11/11] mpls: Add MPLS entropy label in flow_keys

2015-05-28 Thread Tom Herbert
In flow dissector if an MPLS header contains an entropy label this is saved in the new keyid field of flow_keys. The entropy label is then represented in the flow hash function input. Signed-off-by: Tom Herbert --- include/net/flow_dissector.h | 1 + net/core/flow_dissector.c| 35 ++

[PATCH v4 net-next 05/11] net: Add full IPv6 addresses to flow_keys

2015-05-28 Thread Tom Herbert
This patch adds full IPv6 addresses into flow_keys and uses them as input to the flow hash function. The implementation supports either IPv4 or IPv6 addresses in a union, and selector is used to determine how may words to input to jhash2. We also add flow_get_u32_dst and flow_get_u32_src functions

[PATCH v4 net-next 09/11] net: Add IPv6 flow label to flow_keys

2015-05-28 Thread Tom Herbert
In flow_dissector set the flow label in flow_keys for IPv6. This also removes the shortcircuiting of flow dissection when a non-zero label is present, the flow label can be considered to provide additional entropy for a hash. Signed-off-by: Tom Herbert --- include/net/flow_dissector.h | 4 +++-

[PATCH v4 net-next 10/11] net: Add GRE keyid in flow_keys

2015-05-28 Thread Tom Herbert
In flow dissector if a GRE header contains a keyid this is saved in the new keyid field of flow_keys. The GRE keyid is then represented in the flow hash function input. Signed-off-by: Tom Herbert --- include/net/flow_dissector.h | 6 ++ net/core/flow_dissector.c| 24

[PATCH v4 net-next 01/11] net: Simplify GRE case in flow_dissector

2015-05-28 Thread Tom Herbert
Do break when we see routing flag or a non-zero version number in GRE header. Acked-by: Jiri Pirko Signed-off-by: Tom Herbert --- net/core/flow_dissector.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/net/core/flow_dissector.

[PATCH v4 net-next 04/11] net: Get skb hash over flow_keys structure

2015-05-28 Thread Tom Herbert
This patch changes flow hashing to use jhash2 over the flow_keys structure instead just doing jhash_3words over src, dst, and ports. This method will allow us take more input into the hashing function so that we can include full IPv6 addresses, VLAN, flow labels etc. without needing to resort to xo

[PATCH v4 net-next 03/11] net: Remove superfluous setting of key_basic

2015-05-28 Thread Tom Herbert
key_basic is set twice in __skb_flow_dissect which seems unnecessary. Remove second one. Acked-by: Jiri Pirko Signed-off-by: Tom Herbert --- net/core/flow_dissector.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index 7f69916..07

[PATCH v4 net-next 00/11] net: Increase inputs to flow_keys hashing

2015-05-28 Thread Tom Herbert
This patch set adds new fields to the flow_keys structure and hashes over these fields to get a better flow hash. In particular, these patches now include hashing over the full IPv6 addresses in order to defend against address spoofing that always results in the same hash. The new input also includ

[PATCH v4 net-next 02/11] mpls: Add definition for IPPROTO_MPLS

2015-05-28 Thread Tom Herbert
Add uapi define for MPLS over IP. Acked-by: Jiri Pirko Signed-off-by: Tom Herbert --- include/uapi/linux/in.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/linux/in.h b/include/uapi/linux/in.h index 589ced0..641338b 100644 --- a/include/uapi/linux/in.h +++ b/include/uapi/li

Re: Drops in qdisc on ifb interface

2015-05-28 Thread jsulli...@opensourcedevel.com
> On May 28, 2015 at 1:49 PM Eric Dumazet wrote: > > > On Thu, 2015-05-28 at 13:31 -0400, jsulli...@opensourcedevel.com wrote: > > > The overall product does but the video source feeds come over a different > > network via UDP. There are, however, RTMP quality control feeds coming > > across > >

Re: Drops in qdisc on ifb interface

2015-05-28 Thread Eric Dumazet
On Thu, 2015-05-28 at 13:31 -0400, jsulli...@opensourcedevel.com wrote: > The overall product does but the video source feeds come over a different > network via UDP. There are, however, RTMP quality control feeds coming across > this connection. There may also occasionally be test UDP source fee

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-05-28 Thread Jason Gunthorpe
On Thu, May 28, 2015 at 07:21:11PM +0300, Or Gerlitz wrote: > Anything else except for that (you said "reworking of the network scripts > and NetworkManager assumptions to make it work")?? IPv6 becomes very broken, child interfaces will generate the same IPv6 addreses for radv and link local resu

RE: [PATCH] net: qlcnic: clean up sysfs error codes

2015-05-28 Thread Rajesh Borundia
>-Original Message- >From: dept_hsg_linux_nic_dev-boun...@qlclistserver.qlogic.com >[mailto:dept_hsg_linux_nic_dev-boun...@qlclistserver.qlogic.com] On >Behalf Of Vladimir Zapolskiy >Sent: Tuesday, May 26, 2015 6:20 AM >To: David Miller; Shahed Shaikh; Dept-GE Linux NIC Dev >Cc: netdev >Sub

Re: Drops in qdisc on ifb interface

2015-05-28 Thread jsulli...@opensourcedevel.com
> On May 28, 2015 at 1:17 PM Eric Dumazet wrote: > > > On Thu, 2015-05-28 at 12:33 -0400, jsulli...@opensourcedevel.com wrote: > > > Our initial testing has been single flow but the ultimate purpose is > > processing > > real time video in a complex application which ingests associated meta data,

Re: [PATCH net-next] openvswitch: include datapath actions with sampled-packet upcall to userspace

2015-05-28 Thread Jesse Gross
On Wed, May 27, 2015 at 10:57 PM, Pravin Shelar wrote: > On Wed, May 27, 2015 at 9:16 PM, Jesse Gross wrote: >> On Wed, May 27, 2015 at 7:46 PM, Pravin Shelar wrote: >>> On Wed, May 27, 2015 at 2:10 PM, Jesse Gross wrote: On Fri, May 22, 2015 at 10:53 AM, Pravin Shelar wrote: > On Wed

Re: Drops in qdisc on ifb interface

2015-05-28 Thread Eric Dumazet
On Thu, 2015-05-28 at 12:33 -0400, jsulli...@opensourcedevel.com wrote: > Our initial testing has been single flow but the ultimate purpose is > processing > real time video in a complex application which ingests associated meta data, > post to consumer facing cloud, does reporting back - so lots

Re: [PATCH net] bridge: fix br_multicast_query_expired() bug

2015-05-28 Thread Linus Lüssing
On Thu, May 28, 2015 at 04:42:54AM -0700, Eric Dumazet wrote: > Intent of the code was to clear port field, not the pointer to querier. Acked-by: Linus Lüssing -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo

Re: Drops in qdisc on ifb interface

2015-05-28 Thread jsulli...@opensourcedevel.com
> On May 28, 2015 at 12:26 PM Eric Dumazet wrote: > > > On Thu, 2015-05-28 at 08:45 -0700, John Fastabend wrote: > > If your experimenting one thing you could do is create many > > ifb devices and load balance across them from tc. I'm not > > sure if this would be practical in your setup or not b

Re: iproute2: missing patches in branch net-next

2015-05-28 Thread Daniel Borkmann
On 05/28/2015 06:19 PM, Stephen Hemminger wrote: On Thu, 28 May 2015 13:31:08 +0200 Nicolas Dichtel wrote: Hi Stephen, some patches that were recently included in iproute2 branch net-next are not visible anymore on kernel.org. It seems that the branch has been overridden (note the "forced upd

Re: Drops in qdisc on ifb interface

2015-05-28 Thread jsulli...@opensourcedevel.com
> On May 28, 2015 at 11:45 AM John Fastabend wrote: > > > On 05/28/2015 08:30 AM, jsulli...@opensourcedevel.com wrote: > > > >> On May 28, 2015 at 11:14 AM Eric Dumazet wrote: > >> > >> > >> On Thu, 2015-05-28 at 10:38 -0400, jsulli...@opensourcedevel.com wrote: > >> > > > >> IFB has still a lo

Re: Drops in qdisc on ifb interface

2015-05-28 Thread Eric Dumazet
On Thu, 2015-05-28 at 08:45 -0700, John Fastabend wrote: > If your experimenting one thing you could do is create many > ifb devices and load balance across them from tc. I'm not > sure if this would be practical in your setup or not but might > be worth trying. > > One thing I've been debating a

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-05-28 Thread Or Gerlitz
On 5/28/2015 5:07 PM, Doug Ledford wrote: You would think that, but sometimes important information comes from totally different places. See mine and Jason's comments back and forth in the SRIOV thread started by Or. Long story short: ip link add dev ib0 name ib0.1 type ipoib is totally broke

Re: iproute2: missing patches in branch net-next

2015-05-28 Thread Stephen Hemminger
On Thu, 28 May 2015 13:31:08 +0200 Nicolas Dichtel wrote: > Hi Stephen, > > some patches that were recently included in iproute2 branch net-next are not > visible anymore on kernel.org. It seems that the branch has been overridden > (note the "forced update" when I've fetched it): > > $ git fet

Re: iproute2: missing patches in branch net-next

2015-05-28 Thread Stephen Hemminger
On Thu, 28 May 2015 13:31:08 +0200 Nicolas Dichtel wrote: > Hi Stephen, > > some patches that were recently included in iproute2 branch net-next are not > visible anymore on kernel.org. It seems that the branch has been overridden > (note the "forced update" when I've fetched it): > > $ git fet

Re: Lost network connectivity in 4.0.x

2015-05-28 Thread Ken Moffat
On Thu, May 28, 2015 at 03:41:49PM +0100, Ken Moffat wrote: > On Wed, May 27, 2015 at 10:53:00PM -0700, Cong Wang wrote: > > (Please always Cc netdev for networking bugs.) > > Sorry, didn't spot that. But anyway > > > For example: > > > > 1) What is your network setup? iptables? routes? etc. >

Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

2015-05-28 Thread John Fastabend
On 05/28/2015 08:40 AM, Scott Feldman wrote: On Thu, May 28, 2015 at 2:42 AM, Jiri Pirko wrote: Mon, May 18, 2015 at 10:19:16PM CEST, da...@davemloft.net wrote: From: Roopa Prabhu Date: Sun, 17 May 2015 16:42:05 -0700 On most systems where you can offload routes to hardware, doing routing i

Re: [PATCH] net: thunderx: add 64-bit dependency

2015-05-28 Thread David Daney
On 05/28/2015 07:00 AM, Arnd Bergmann wrote: The thunderx ethernet driver fails to build on architectures that do not have an atomic readq() and writeq() function for 64-bit PCI bus access: drivers/net/ethernet/cavium/thunder/thunder_bgx.c: In function 'bgx_reg_read': include/asm-generic/io.h:19

Re: [PATCH/RFC net-next] rocker: remove rocker parameter from functions that have rocker_port parameter

2015-05-28 Thread Scott Feldman
On Thu, May 28, 2015 at 2:18 AM, David Laight wrote: > From: Simon Horman >> Sent: 28 May 2015 04:23 >> The rocker (switch) of a rocker_port may be trivially obtained from >> the latter it seems cleaner not to pass the former to a function when >> the latter is being passed anyway. > > If the argu

Re: Drops in qdisc on ifb interface

2015-05-28 Thread John Fastabend
On 05/28/2015 08:30 AM, jsulli...@opensourcedevel.com wrote: On May 28, 2015 at 11:14 AM Eric Dumazet wrote: On Thu, 2015-05-28 at 10:38 -0400, jsulli...@opensourcedevel.com wrote: IFB has still a long way before being efficient. In the mean time, you could play with following patch, an

Re: Drops in qdisc on ifb interface

2015-05-28 Thread Eric Dumazet
On Thu, 2015-05-28 at 11:30 -0400, jsulli...@opensourcedevel.com wrote: > Interesting but this is destined to become a critical production system for a > high profile, internationally recognized product so I am hesitant to patch. I > doubt I can convince my company to do it but is improving IFB t

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-05-28 Thread Jason Gunthorpe
On Thu, May 28, 2015 at 04:22:36PM +0300, Haggai Eran wrote: > wouldn't care if they share the "QP number namespace", etc. RDMA CM > ports are different because they are chosen by the applications, but > they map directly to the network namespace, so they don't require their > own namespace. Diffe

Re: [PATCH v4 for-next 04/12] IB/ipoib: Return IPoIB devices matching connection parameters

2015-05-28 Thread Jason Gunthorpe
On Thu, May 28, 2015 at 02:51:51PM +0300, Haggai Eran wrote: > > But RDMA CM doesn't provide the QPN. So when RDMA CM searches the > > netdevs for an address it cannot *uniquely* map to a IPoIB interface. > This is technically true, but if someone configures their system that > way, they will als

[PATCH net-next 3/4] net/mlx4_core: Move affinity hints to mlx4_core ownership

2015-05-28 Thread Or Gerlitz
From: Ido Shamay Now that EQs management is in the sole responsibility of mlx4_core, the IRQ affinity hints configuration should be in its hands as well. request_irq is called only once by the first consumer (maybe mlx4_ib), so mlx4_en passes the affinity mask too late. We also need to request ve

Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

2015-05-28 Thread John Fastabend
On 05/28/2015 02:42 AM, Jiri Pirko wrote: Mon, May 18, 2015 at 10:19:16PM CEST, da...@davemloft.net wrote: From: Roopa Prabhu Date: Sun, 17 May 2015 16:42:05 -0700 On most systems where you can offload routes to hardware, doing routing in software is not an option (the cpu limitations make ro

[PATCH net-next 0/4] mlx4 driver update, May 28, 2015

2015-05-28 Thread Or Gerlitz
Hi Dave, The 1st patch fixes an issue with a function running DPDK overriding broadcast steering rules set by other functions. Please add this one to your -stable queue. The rest of the series from Matan and Ido deals with scaling the number of IRQs that serve RoCE applications to be in par wit

[PATCH net-next 1/4] net/mlx4_core: Demote simple multicast and broadcast flow steering rules

2015-05-28 Thread Or Gerlitz
From: Matan Barak In SRIOV, when simple (i.e - Ethernet L2 only) flow steering rules are created, always create them at MLX4_DOMAIN_NIC priority (instead of the real priority the function created them at). This is done in order to let multiple functions add broadcast/multicast rules without affec

[PATCH net-next 2/4] net/mlx4: Add EQ pool

2015-05-28 Thread Or Gerlitz
From: Matan Barak Previously, mlx4_en allocated EQs and used them exclusively. This affected RoCE performance, as applications which are events sensitive were limited to use only the legacy EQs. Change that by introducing an EQ pool. This pool is managed by mlx4_core. EQs are assigned to ports (

[PATCH net-next 4/4] net/mlx4_core: Make sure there are no pending async events when freeing CQ

2015-05-28 Thread Or Gerlitz
From: Matan Barak When freeing a CQ, we need to make sure there are no asynchronous events (on the ASYNC EQ) that could relate to this CQ before freeing it. This is done by introducing synchronize_irq. Signed-off-by: Matan Barak Signed-off-by: Ido Shamay Signed-off-by: Or Gerlitz --- driver

Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

2015-05-28 Thread Scott Feldman
On Thu, May 28, 2015 at 2:42 AM, Jiri Pirko wrote: > Mon, May 18, 2015 at 10:19:16PM CEST, da...@davemloft.net wrote: >>From: Roopa Prabhu >>Date: Sun, 17 May 2015 16:42:05 -0700 >> >>> On most systems where you can offload routes to hardware, >>> doing routing in software is not an option (the c

Re: Drops in qdisc on ifb interface

2015-05-28 Thread jsulli...@opensourcedevel.com
> On May 28, 2015 at 11:14 AM Eric Dumazet wrote: > > > On Thu, 2015-05-28 at 10:38 -0400, jsulli...@opensourcedevel.com wrote: > > IFB has still a long way before being efficient. > > In the mean time, you could play with following patch, and > setup /sys/class/net/eth0/gro_timeout to 2 > >

Re: linux-next: build failure after merge of most of the trees

2015-05-28 Thread Eric Dumazet
On Thu, 2015-05-28 at 22:06 +1000, Stephen Rothwell wrote: > Hi all, > > After merging the all the trees, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/vhost/scsi.c: In function 'vhost_scsi_open': > drivers/vhost/scsi.c:1422:3: error: implicit declaration of func

Re: Drops in qdisc on ifb interface

2015-05-28 Thread Eric Dumazet
On Thu, 2015-05-28 at 10:38 -0400, jsulli...@opensourcedevel.com wrote: > This has been an interesting exercise - thank you for your help along the way, > Eric. IFB did not seem to bottleneck in our initial testing but there was > really only one flow of traffic during the test at around 1 Gbps.

Re: Lost network connectivity in 4.0.x

2015-05-28 Thread Ken Moffat
On Wed, May 27, 2015 at 10:53:00PM -0700, Cong Wang wrote: > (Please always Cc netdev for networking bugs.) > > On Sat, May 23, 2015 at 8:29 PM, Ken Moffat wrote: > > On Sun, May 24, 2015 at 03:43:52AM +0100, Ken Moffat wrote: > >> Anybody else suffering frm lost network connectivity in 4.0.x > >

Re: [PATCH] sctp: fix ASCONF list handling

2015-05-28 Thread Marcelo Ricardo Leitner
On Thu, May 28, 2015 at 10:27:32AM -0300, Marcelo Ricardo Leitner wrote: > On Thu, May 28, 2015 at 08:17:27AM -0300, Marcelo Ricardo Leitner wrote: > > On Thu, May 28, 2015 at 06:15:11AM -0400, Neil Horman wrote: > > > On Wed, May 27, 2015 at 09:52:17PM -0300, mleit...@redhat.com wrote: > > > > Fro

Re: Drops in qdisc on ifb interface

2015-05-28 Thread jsulli...@opensourcedevel.com
> On May 25, 2015 at 6:31 PM Eric Dumazet wrote: > > > On Mon, 2015-05-25 at 16:05 -0400, John A. Sullivan III wrote: > > Hello, all. One one of our connections we are doing intensive traffic > > shaping with tc. We are using ifb interfaces for shaping ingress > > traffic and we also use ifb inte

Re: [PATCH net-next] neigh: Add missing rcu_assign_pointer

2015-05-28 Thread Eric Dumazet
On Thu, 2015-05-28 at 21:50 +0800, Herbert Xu wrote: > This patch is indeed bogus but accessing an RCU-protected like > this will trigger sparse warnings. So better make it an > RCU_INIT_POINTER. A = B; is perfectly fine since both A and B have the same __rcu attribute. Sparse has no warning

Fw: [Bug 99091] New: Kernel panic while sending network packets over TAP interface

2015-05-28 Thread Stephen Hemminger
Begin forwarded message: Date: Thu, 28 May 2015 11:44:58 + From: "bugzilla-dae...@bugzilla.kernel.org" To: "shemmin...@linux-foundation.org" Subject: [Bug 99091] New: Kernel panic while sending network packets over TAP interface https://bugzilla.kernel.org/show_bug.cgi?id=99091

Fw: [Bug 99081] New: Bridge multicast snooping breaks ICMPv6

2015-05-28 Thread Stephen Hemminger
Begin forwarded message: Date: Thu, 28 May 2015 10:34:55 + From: "bugzilla-dae...@bugzilla.kernel.org" To: "shemmin...@linux-foundation.org" Subject: [Bug 99081] New: Bridge multicast snooping breaks ICMPv6 https://bugzilla.kernel.org/show_bug.cgi?id=99081 Bug ID: 99081

Re: [net-next 01/14] ethtool: Add helper routines to pass vf to rx_flow_spec

2015-05-28 Thread John Fastabend
On 05/28/2015 06:18 AM, Or Gerlitz wrote: On Thu, May 28, 2015 at 2:25 PM, Jeff Kirsher wrote: From: John Fastabend The ring_cookie is 64 bits wide which is much larger than can be used for actual queue index values. So provide some helper routines to pack a VF index into the cookie. This is

Re: tc drop stats different between bond and slave interfaces

2015-05-28 Thread jsulli...@opensourcedevel.com
> On May 26, 2015 at 1:10 PM Cong Wang wrote: > > > On Mon, May 25, 2015 at 10:35 PM, jsulli...@opensourcedevel.com > wrote: > > > > I was also surprised to see that, although we are using a prio qdisc on the > > bond, the physical interface is showing pfifo_fast. > > > [...] > > > > So why the

Re: [PATCH] sctp: fix ASCONF list handling

2015-05-28 Thread Neil Horman
On Thu, May 28, 2015 at 10:27:32AM -0300, Marcelo Ricardo Leitner wrote: > On Thu, May 28, 2015 at 08:17:27AM -0300, Marcelo Ricardo Leitner wrote: > > On Thu, May 28, 2015 at 06:15:11AM -0400, Neil Horman wrote: > > > On Wed, May 27, 2015 at 09:52:17PM -0300, mleit...@redhat.com wrote: > > > > Fro

Re: [net-next 01/14] ethtool: Add helper routines to pass vf to rx_flow_spec

2015-05-28 Thread Sergei Shtylyov
Hello. On 5/28/2015 2:25 PM, Jeff Kirsher wrote: From: John Fastabend The ring_cookie is 64 bits wide which is much larger than can be used for actual queue index values. So provide some helper routines to pack a VF index into the cookie. This is useful to steer packets to a VF ring without

Re: DSA and underlying 802.1Q encapsulation

2015-05-28 Thread Guenter Roeck
On 05/28/2015 06:44 AM, Vivien Didelot wrote: Hi Guenter, If yes, the dsa code may need to move the tag into the header. If we are lucky, a call to vlan_hwaccel_push_inside() might do it. Thanks, I'm currently looking into it and doing some tests, I'm coming back to you asap. Issue fixed, t

Re: [PATCH] netevent: remove automatic variable in register_netevent_notifier()

2015-05-28 Thread Sergei Shtylyov
Hello. On 5/28/2015 1:00 PM, Wang Long wrote: Remove automatic variable 'err' in register_netevent_notifier() and return the return value of atomic_notifier_chain_register() directly. s/return value/result/, in order to avoid tautology. Signed-off-by: Wang Long [...] WBR, Sergei -- T

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-05-28 Thread Doug Ledford
On Thu, 2015-05-28 at 16:07 +0300, Haggai Eran wrote: > On 26/05/2015 16:34, Doug Ledford wrote: > > On Sun, 2015-05-17 at 08:50 +0300, Haggai Eran wrote: > > This is a core feature more than anything else. Namespaces for RDMA > > devices is not unique to IB or RoCE in any way. Yet no thought has

[PATCH] net: thunderx: add 64-bit dependency

2015-05-28 Thread Arnd Bergmann
The thunderx ethernet driver fails to build on architectures that do not have an atomic readq() and writeq() function for 64-bit PCI bus access: drivers/net/ethernet/cavium/thunder/thunder_bgx.c: In function 'bgx_reg_read': include/asm-generic/io.h:195:23: error: implicit declaration of function

Re: [PATCH net-next 1/1] hv_netvsc: Properly size the vrss queues

2015-05-28 Thread Dan Carpenter
On Thu, May 28, 2015 at 01:52:47PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > > Sent: Thursday, May 28, 2015 12:06 AM > > To: KY Srinivasan > > Cc: da...@davemloft.net; netdev@vger.kernel.org; linux- > > ker...@vger.k

RE: [PATCH net-next 1/1] hv_netvsc: Properly size the vrss queues

2015-05-28 Thread KY Srinivasan
> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Thursday, May 28, 2015 12:06 AM > To: KY Srinivasan > Cc: da...@davemloft.net; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com;

Re: [PATCH net-next] neigh: Add missing rcu_assign_pointer

2015-05-28 Thread Herbert Xu
Eric Dumazet wrote: > > This patch is not needed. > > You really should read Documentation/RCU , because it looks like you are > quite confused. > > When we remove an element from a RCU protected list, all the objects in > the chain are already ready to be caught by rcu readers. > > Therefore,

Re: DSA and underlying 802.1Q encapsulation

2015-05-28 Thread Vivien Didelot
Hi Guenter, >>> If yes, the dsa code may need to move the tag into the header. >>> If we are lucky, a call to vlan_hwaccel_push_inside() might do it. >> >> Thanks, I'm currently looking into it and doing some tests, I'm coming back >> to >> you asap. Issue fixed, thanks! vlan_hwaccel_push_inside

Re: linux-next: manual merge of the net-next tree with Linus' tree

2015-05-28 Thread Tom Lendacky
On 05/27/2015 11:17 PM, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the net-next tree got a conflict in drivers/net/phy/amd-xgbe-phy.c between commit 983942a5eaca ("amd-xgbe-phy: Fix initial mode when autoneg is disabled") from Linus' tree and commit 7c12aa08779c ("amd-xgbe: Move

Re: [PATCH] sctp: fix ASCONF list handling

2015-05-28 Thread Marcelo Ricardo Leitner
On Thu, May 28, 2015 at 08:17:27AM -0300, Marcelo Ricardo Leitner wrote: > On Thu, May 28, 2015 at 06:15:11AM -0400, Neil Horman wrote: > > On Wed, May 27, 2015 at 09:52:17PM -0300, mleit...@redhat.com wrote: > > > From: Marcelo Ricardo Leitner > > > > > > ->auto_asconf_splist is per namespace an

Re: [PATCH v4] bnx2x: Alloc 4k fragment for each rx ring buffer element

2015-05-28 Thread Gabriel Krisman Bertazi
Yuval Mintz writes: > Actually, this upsets me greatly. We didn't see it on a system with 4KB > pages, but this means you've actually tried to 'sell' us a fastpath fix that > was never tested on machines for which it was meant as an improvement. The iteration that inserted this bug was such a qu

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-05-28 Thread Haggai Eran
On 26/05/2015 20:46, Doug Ledford wrote: >> Remember, this isn't RDMA namespaces, this is netdev namespace support >> > for RDMA-CM -> very different things. > That was the point of my email. This is a very myopic view of the > feature. It *should* at least have an idea of these other things too.

Re: [PATCH net v2] openvswitch: disable LRO

2015-05-28 Thread Flavio Leitner
On Thu, May 28, 2015 at 03:04:53PM +0200, Jiri Benc wrote: > Currently, openvswitch tries to disable LRO from the user space. This does > not work correctly when the device added is a vlan interface, though. > Instead of dealing with possibly complex stacked cross name space relations > in the user

Re: [net-next 01/14] ethtool: Add helper routines to pass vf to rx_flow_spec

2015-05-28 Thread Or Gerlitz
On Thu, May 28, 2015 at 2:25 PM, Jeff Kirsher wrote: > From: John Fastabend > > The ring_cookie is 64 bits wide which is much larger than can be used > for actual queue index values. So provide some helper routines to > pack a VF index into the cookie. This is useful to steer packets to > a VF ri

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-05-28 Thread Haggai Eran
On 26/05/2015 19:59, Jason Gunthorpe wrote: > The big open question for ethernet is how to work without relying on > VLAN to create delgated netdevs - typically one would use a bridge and > veth's, which do not seem very RDMA compatible. But that doesn't need > to be answered right now. I think in

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-05-28 Thread Haggai Eran
On 26/05/2015 16:34, Doug Ledford wrote: > On Sun, 2015-05-17 at 08:50 +0300, Haggai Eran wrote: >> Thanks again everyone for the review comments. I've updated the patch set >> accordingly. The main changes are in the first patch to use a read-write >> semaphore instead of an SRCU, and with the ref

[PATCH net v2] openvswitch: disable LRO

2015-05-28 Thread Jiri Benc
Currently, openvswitch tries to disable LRO from the user space. This does not work correctly when the device added is a vlan interface, though. Instead of dealing with possibly complex stacked cross name space relations in the user space, do the same as bridging does and call dev_disable_lro in th

Re: [net-next 07/14] i40e: Remove unnecessary pf members

2015-05-28 Thread Or Gerlitz
On Thu, May 28, 2015 at 2:25 PM, Jeff Kirsher wrote: > From: Anjali Singhai Jain > > We can use the stat index macro directly, a variable is not required. Sorry, but while attempting to look on the patch, I wasn't able to decipher the change-log nor to somehow relate it to the patch title. Can

pull-request: mac80211 2015-05-28

2015-05-28 Thread Johannes Berg
Hi Dave, Please excuse the quick succession with another pull request - Ben pointed out to me that a fix I'd applied on -next is actually needed on 4.1 - we'll have to live with it being in both I suppose. Sorry about that. johannes The following changes since commit f9dca80b98caac8b4bfb43a2edf

[PATCH v6] net: tcp: Fix a PTO timing granularity issue

2015-05-28 Thread Ido Yariv
The Tail Loss Probe RFC specifies that the PTO value should be set to max(2 * SRTT, 10ms), where SRTT is the smoothed round-trip time. The PTO value is converted to jiffies, so the timer may expire prematurely. This is especially problematic on systems in which HZ <= 100, so work around this by s

Re: [PATCH net] bridge: fix br_multicast_query_expired() bug

2015-05-28 Thread Thadeu Lima de Souza Cascardo
On Thu, May 28, 2015 at 04:42:54AM -0700, Eric Dumazet wrote: > From: Eric Dumazet > > br_multicast_query_expired() querier argument is a pointer to > a struct bridge_mcast_querier : > > struct bridge_mcast_querier { > struct br_ip addr; > struct net_bridge_port __rcu*port; >

linux-next: build failure after merge of most of the trees

2015-05-28 Thread Stephen Rothwell
Hi all, After merging the all the trees, today's linux-next build (powerpc allyesconfig) failed like this: drivers/vhost/scsi.c: In function 'vhost_scsi_open': drivers/vhost/scsi.c:1422:3: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration] vs = vzalloc(s

Re: [PATCH net-next] vlan: Add GRO support for non hardware accelerated vlan

2015-05-28 Thread Eric Dumazet
On Thu, 2015-05-28 at 20:17 +0900, Toshiaki Makita wrote: > Currently packets with non-hardware-accelerated vlan cannot be handled > by GRO. This causes low performance for 802.1ad and stacked vlan, as their > vlan tags are currently not stripped by hardware. > > This patch adds GRO support for no

Re: [PATCH v4 for-next 04/12] IB/ipoib: Return IPoIB devices matching connection parameters

2015-05-28 Thread Haggai Eran
On 21/05/2015 20:43, Jason Gunthorpe wrote: > On Thu, May 21, 2015 at 08:33:53AM +0300, Haggai Eran wrote: > >> To create a new child interface on the default P_Key, its possible to >> use iproute: >> # ip link add link ib0 name ib0.1 type ipoib > > Uh.. > > A key invariant of the IP stack is th

[PATCH net] bridge: fix br_multicast_query_expired() bug

2015-05-28 Thread Eric Dumazet
From: Eric Dumazet br_multicast_query_expired() querier argument is a pointer to a struct bridge_mcast_querier : struct bridge_mcast_querier { struct br_ip addr; struct net_bridge_port __rcu*port; }; Intent of the code was to clear port field, not the pointer to querier. Fi

I Need Your Attention,Reply

2015-05-28 Thread Mr.Simon Isaac
I am Mr.Simon Isaac a regional managing director (Africa Development Bank) Ouagadougou Burkina Faso,If you are interested to help the orphans with US$9,500. million united state dollars around the world contact me and send your personal information for more details: Names... Country... Occupati

[PATCH iproute2] Fix changing tunnel remote and local address to any

2015-05-28 Thread Thadeu Lima de Souza Cascardo
If a tunnel is created with a local address, you can't change it to any. # ip tunnel add tunl1 mode ipip remote 10.16.42.37 local 10.16.42.214 ttl 64 # ip tunnel show tunl1 tunl1: ip/ip remote 10.16.42.37 local 10.16.42.214 ttl 64 # ip tunnel change tunl1 local any # echo $? 0 # ip tunne

iproute2: missing patches in branch net-next

2015-05-28 Thread Nicolas Dichtel
Hi Stephen, some patches that were recently included in iproute2 branch net-next are not visible anymore on kernel.org. It seems that the branch has been overridden (note the "forced update" when I've fetched it): $ git fetch remote: Counting objects: 65, done. remote: Compressing objects: 100%

[net-next 09/14] i40e: fix unrecognized FCOE EOF case

2015-05-28 Thread Jeff Kirsher
From: Vasu Dev Because i40e_fcoe_ctxt_eof should never be called without i40e_fcoe_eof_is_supported being called first, the EOF in fcoe_ctxt_eof should always be valid and therefore we do not need to print an error if it is not valid. However, a WARN ON to easily catch any calls to i40e_fcoe_ctx

[net-next 10/14] i40e: Move the FD ATR/SB messages to a higher debug level

2015-05-28 Thread Jeff Kirsher
From: Anjali Singhai Jain These are not useful unless SV is happening as there is a FD flush counter that tracks this. Change-ID: If2655b5a29687247d03a51d35f69854bbeb711ce Signed-off-by: Anjali Singhai Jain Tested-by: Jim Young Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/

[net-next 14/14] i40e: Bump version to 1.3.4

2015-05-28 Thread Jeff Kirsher
From: Catherine Sullivan Bump. Change-ID: I54ec2787a9fead5e18447078f26e5dd27f01da44 Signed-off-by: Catherine Sullivan Tested-by: Jim Young Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/n

[net-next 07/14] i40e: Remove unnecessary pf members

2015-05-28 Thread Jeff Kirsher
From: Anjali Singhai Jain We can use the stat index macro directly, a variable is not required. Change-ID: I19f08ac16353dc0cd87a1a8248d714e15a54aa8a Signed-off-by: Anjali Singhai Jain Tested-by: Jim Young Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e.h | 2 --

[net-next 13/14] i40e/i40evf: remove time_stamp member

2015-05-28 Thread Jeff Kirsher
From: Jesse Brandeburg The driver doesn't use the time_stamp member to determine if there is a tx_hang any more. There really isn't any point to the variable at all so just remove it. It was left over from a previous tx_hang design. Change-ID: I4c814827e1bcb46e45118fe37acdcfa814fb62a0 Signed-off

[net-next 08/14] i40e/i40evf: Remove unneeded TODO

2015-05-28 Thread Jeff Kirsher
From: Greg Rose There's no need for a counter so remove the TODO comment. Change-ID: I3321dda04934c4f5fda9b279ab666192bda44214 Signed-off-by: Greg Rose Tested-by: Jim Young Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 3 --- drivers/net/ethernet/intel/i40ev

[net-next 12/14] i40e/i40evf: force inline transmit functions

2015-05-28 Thread Jeff Kirsher
From: Jesse Brandeburg Inlining these functions gives us about 15% more 64 byte packets per second when using pktgen. 13.3 million to 15 million with a single queue. Also fix the function names in i40evf to i40evf not i40e while we are touching the function header. Change-ID: I3294ae9b085cf4386

[net-next 03/14] i40e: Collect PFC XOFF RX stats even in single TC case

2015-05-28 Thread Jeff Kirsher
From: Neerav Parikh When PFC is enabled for any UP in single TC configuration the driver didn't collect the PFC XOFF RX stats. Though a single TC with PFC enabled is not a common scenario do not prevent the driver from collecting stats if firmware indicates that PFC is enabled. Change-ID: Ie20bd

[net-next 00/14][pull request] Intel Wired LAN Driver Updates 2015-05-28

2015-05-28 Thread Jeff Kirsher
This series contains updates to ethtool, ixgbe, i40e and i40evf. John adds helper routines for ethtool to pass VF to rx_flow_spec. Since the ring_cookie is 64 bits wide which is much larger than what could be used for actual queue index values, provide helper routines to pack a VF index into the

[net-next 02/14] ixgbe: Allow flow director to use entire queue space

2015-05-28 Thread Jeff Kirsher
From: John Fastabend Flow director is exported to user space using the ethtool ntuple support. However, currently it only supports steering traffic to a subset of the queues in use by the hardware. This change allows flow director to specify queues that have been assigned to virtual functions by

[net-next 04/14] i40e: Disable offline diagnostics if VFs are enabled

2015-05-28 Thread Jeff Kirsher
From: Greg Rose Require the user to disable virtual functions before running the device offline diagnostics. The offline diagnostics are intended to ensure basic operation of the device - it is beyond the scope of the diagnostic test to handle the additional complexity of bringing all the virtua

<    1   2   3   >