RE: [PATCH] bnx2x: Update to FW version 7.12.30

2015-07-05 Thread Yuval Mintz
The new FW will allow us to utilize some new features in our driver, mainly adding vlan filtering offload and vxlan offload support. In addition, this fixes several issues: 1. Packets from a VF with pvid configured which were sent with a different vlan were transmitted instead of being

[PATCH] NET: hamradio: Fix IP over bpq encapsulation.

2015-07-05 Thread Ralf Baechle
Since 1d5da757da860a6916adbf68b09e868062b4b3b8 (ax25: Stop using magic neighbour cache operations.) any attempt to transmit IP packets over a bpqether device will result in a message like Dead loop on virtual device bpq0, fix it urgently! Fix suggested by Eric W. Biederman ebied...@xmission.com.

Re: Summary lightweight tunnel discussion at NFWS

2015-07-05 Thread roopa
On 7/3/15, 3:00 AM, Thomas Graf wrote: On 06/18/15 at 09:49pm, Roopa Prabhu wrote: +#ifdef CONFIG_LWTUNNEL + if (fi-fib_nh-nh_lwtstate) { + struct lwtunnel_state *lwtstate; + + lwtstate = fi-fib_nh-nh_lwtstate; + if

Re: [PATCH net-next] net: bail on sock_wfree, sock_rfree when we have a TCP_TIMEWAIT sk

2015-07-05 Thread Eric Dumazet
Looks like routing by definition can not divert skbs with early-demux socket because input routing is not called. Only if found socket has a valid sk-sk_rx_dst Early demux : 1) if TCP lookup found a matching socket, we do the attachment skb-sk = sk; skb-destructor = sock_edemux

Linux 4.2 build error in net/netfilter/ipset/ip_set_hash_netnet.c

2015-07-05 Thread Vinson Lee
Hi. With the latest Linux 4.2-rc1, I am hitting this build error with GCC 4.4.7 on CentOS 6. CC net/netfilter/ipset/ip_set_hash_netnet.o net/netfilter/ipset/ip_set_hash_netnet.c: In function ‘hash_netnet4_uadt’: net/netfilter/ipset/ip_set_hash_netnet.c:163: error: unknown field ‘cidr’

Re: [PATCH 4/6] net: mvneta: Handle per-cpu interrupts

2015-07-05 Thread Willy Tarreau
Hi Maxime, On Fri, Jul 03, 2015 at 04:25:49PM +0200, Maxime Ripard wrote: Now that our interrupt controller is allowing us to use per-CPU interrupts, actually use it in the mvneta driver. This involves obviously reworking the driver to have a CPU-local NAPI structure, and report for

Re: [PATCH 6/6] net: mvneta: Statically assign queues to CPUs

2015-07-05 Thread Willy Tarreau
Hi Thomas, On Fri, Jul 03, 2015 at 04:46:24PM +0200, Thomas Petazzoni wrote: Maxime, On Fri, 3 Jul 2015 16:25:51 +0200, Maxime Ripard wrote: +static void mvneta_percpu_enable(void *arg) +{ + struct mvneta_port *pp = arg; + + enable_percpu_irq(pp-dev-irq, IRQ_TYPE_NONE); +}

Re: [PATCH net-next] net: bail on sock_wfree, sock_rfree when we have a TCP_TIMEWAIT sk

2015-07-05 Thread Julian Anastasov
Hello, On Fri, 3 Jul 2015, Alex Gartrell wrote: - if packets go to local server IPVS should not touch skb-dst, skb-sk, etc (NF_ACCEPT case) Yeah, the thing is that early demux could totally match for a socket that existed before we created the service, and in

RE: [PATCH] xen-netback: remove duplicated function definition

2015-07-05 Thread Li, Liang Z
Cc: linux-ker...@vger.kernel.org; ian.campb...@citrix.com; wei.l...@citrix.com; xen-de...@lists.xenproject.org; netdev@vger.kernel.org Subject: Re: [PATCH] xen-netback: remove duplicated function definition From: Liang Li liang.z...@intel.com Date: Sat, 4 Jul 2015 03:33:00 +0800 There

Re: [PATCH V2] cdc_ncm: Add support for moving NDP to end of NCM frame

2015-07-05 Thread Enrico Mioso
When sending lots of small packets, this patch will generate an Unable to handle kernel paging request in the memset call: ndp16 = memset(ctx-delayed_ndp16, 0, ctx-max_ndp_size); And I don't know why. Any comment or suggestion would be greatly apreciated. This has been reproduced in a QEMU X86

Re: [PATCH net-next 3/6] net_sched: act: make tcfg_pval non zero

2015-07-05 Thread Eric Dumazet
Thanks guys for the review. For completeness, I'll add smp_wmb() here : gact-tcfg_pval= max_t(u16, 1, p_parm-pval); smp_wmb(); gact-tcfg_ptype = p_parm-ptype; And corresponding smp_rmb() On Fri, Jul 3, 2015 at 12:49 PM, Jamal Hadi Salim j...@mojatatu.com wrote: On 07/02/15

[PATCH] net: phy: add dependency on HAS_IOMEM to MDIO_BUS_MUX_MMIOREG

2015-07-05 Thread Rob Herring
On UML builds, mdio-mux-mmioreg.c fails to compile: drivers/net/phy/mdio-mux-mmioreg.c:50:3: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration] drivers/net/phy/mdio-mux-mmioreg.c:63:3: error: implicit declaration of function ‘iounmap’

Re: Linux 4.2 build error in net/netfilter/ipset/ip_set_hash_netnet.c

2015-07-05 Thread Guenter Roeck
On Sat, Jul 04, 2015 at 12:44:36AM -0700, Vinson Lee wrote: Hi. With the latest Linux 4.2-rc1, I am hitting this build error with GCC 4.4.7 on CentOS 6. CC net/netfilter/ipset/ip_set_hash_netnet.o net/netfilter/ipset/ip_set_hash_netnet.c: In function ‘hash_netnet4_uadt’:

Re: [PATCH net] mlx4: TCP/UDP packets have L4 hash

2015-07-05 Thread Eric Dumazet
On Mon, 2015-07-06 at 00:16 +0300, Ido Shamay wrote: We can have a relaxation of the condition by looking only at TCP/UDP CQE indication (without check-sum indications) This can cover us also when device rx-checksuming feature is off. Do we want it or a correlation between check-sum and

Re: [PATCH] xen-netback: remove duplicated function definition

2015-07-05 Thread Wei Liu
On Sat, Jul 04, 2015 at 03:33:00AM +0800, Liang Li wrote: There are two duplicated xenvif_zerocopy_callback() definitions. Remove one of them. Signed-off-by: Liang Li liang.z...@intel.com Acked-by: Wei Liu wei.l...@citrix.com Please fix the time of your computer and resend. Wei. ---

[PATCH,v2 net-next] ipvs: skb_orphan in case of forwarding

2015-07-05 Thread Alex Gartrell
It is possible that we bind against a local socket in early_demux when we are actually going to want to forward it. In this case, the socket serves no purpose and only serves to confuse things (particularly functions which implicitly expect sk_fullsock to be true, like ip_local_out).

Re: [PATCH net] mlx4: TCP/UDP packets have L4 hash

2015-07-05 Thread Ido Shamay
On 7/6/2015 12:33 AM, Eric Dumazet wrote: On Mon, 2015-07-06 at 00:16 +0300, Ido Shamay wrote: We can have a relaxation of the condition by looking only at TCP/UDP CQE indication (without check-sum indications) This can cover us also when device rx-checksuming feature is off. Do we want it or

Re: [PATCH net] mlx4: TCP/UDP packets have L4 hash

2015-07-05 Thread Ido Shamay
On 7/2/2015 2:24 PM, Eric Dumazet wrote: From: Eric Dumazet eduma...@google.com Mellanox driver has the knowledge if rxhash is a L4 hash, if it receives a non fragmented TCP or UDP frame and NETIF_F_RXCSUM is enabled on netdev. ip_summed value is CHECKSUM_UNNECESSARY in this case.

[PATCH net-next] ipvs: skb_orphan in case of forwarding

2015-07-05 Thread Alex Gartrell
It is possible that we bind against a local socket in early_demux when we are actually going to want to forward it. In this case, the socket serves no purpose and only serves to confuse things (particularly functions which implicitly expect sk_fullsock to be true, like ip_local_out).

Re: [PATCH net-next] ipvs: skb_orphan in case of forwarding

2015-07-05 Thread Julian Anastasov
Hello, On Sun, 5 Jul 2015, Alex Gartrell wrote: + /* Remove the early_demux association unless it's bound for the + * exact same port and address on this host after translation. + */ + if (!local || cp-vport != cp-dport || + !ip_vs_addr_equal(cp-af,

[RESEND] xen-netback: remove duplicated function definition

2015-07-05 Thread Liang Li
There are two duplicated xenvif_zerocopy_callback() definitions. Remove one of them. Signed-off-by: Liang Li liang.z...@intel.com --- drivers/net/xen-netback/common.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/xen-netback/common.h b/drivers/net/xen-netback/common.h index

Re: [PATCH,v2 net-next] ipvs: skb_orphan in case of forwarding

2015-07-05 Thread Julian Anastasov
Hello, On Sun, 5 Jul 2015, Alex Gartrell wrote: It is possible that we bind against a local socket in early_demux when we are actually going to want to forward it. In this case, the socket serves no purpose and only serves to confuse things (particularly functions which implicitly

Re: [PATCH,v2 net-next] ipvs: skb_orphan in case of forwarding

2015-07-05 Thread Alex Gartrell
On Sun, Jul 5, 2015 at 3:13 PM, Julian Anastasov j...@ssi.bg wrote: May be the patch fixes crashes? If yes, Simon should apply it for ipvs/net tree, otherwise after the merge window... Yeah this is definitely a crash-fix and it's existed since at least 3.10. -- Alex Gartrell

Re: [PATCH,v2 net-next] ipvs: skb_orphan in case of forwarding

2015-07-05 Thread Alex Gartrell
On Sun, Jul 5, 2015 at 8:50 PM, Simon Horman ho...@verge.net.au wrote: Is it possible to get a 'Fixes:' tag? I suppose it'd be appropriate to say Fixes: 41063e9dd119 (ipv4: Early TCP socket demux.) As that is what introduces tcp early_demux, but that's just a guess as I haven't bisected it

[PATCH] net: macb: Add SG support for Zynq SOC family

2015-07-05 Thread Punnaiah Choudary Kalluri
Enable SG support for Zynq SOC family devices. Signed-off-by: Punnaiah Choudary Kalluri punn...@xilinx.com --- drivers/net/ethernet/cadence/macb.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb.c

[PATCH v3 1/3] net: dsa: mv88e6xxx: add debugfs interface for VTU

2015-07-05 Thread Vivien Didelot
Implement the Get Next and Load Purge operations for the VLAN Table Unit, and a vtu debugfs file to read and write the hardware VLANs. A populated VTU look like this: # cat /sys/kernel/debug/dsa0/vtu VID FID SID 0 1 2 3 4 5 6 550 5620 x x x u x t x 1000

[PATCH v3 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-05 Thread Vivien Didelot
Hi all, This patchset brings full support for hardware VLANs in DSA, and the Marvell 88E6xxx compatible switch chips. The first patch adds the VTU operations to the mv88e6xxx code, as well as a vtu debugfs file to read and modify the hardware VLAN table. The second patch adds the glue between

[PATCH v3 2/3] net: dsa: add support for switchdev VLAN objects

2015-07-05 Thread Vivien Didelot
This patch adds the glue between DSA and switchdev operations to add, delete and dump SWITCHDEV_OBJ_PORT_VLAN objects. This is a first step to link the bridge vlan command with hardware entries for DSA compatible switch chips. Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com ---

[PATCH v3 3/3] net: dsa: mv88e6xxx: add switchdev VLAN operations

2015-07-05 Thread Vivien Didelot
This commit implements the switchdev operations to add, delete and dump VLANs for the Marvell 88E6352 and compatible switch chips. This allows to access the switch VLAN Table Unit from standard userspace commands such as bridge vlan. A configuration like 1t 2t 3t 4u for VLAN 10 is achieved like

[PATCH net-next v2] ipv6: sysctl to restrict candidate source addresses

2015-07-05 Thread Erik Kline
Per RFC 6724, section 4, Candidate Source Addresses: It is RECOMMENDED that the candidate source addresses be the set of unicast addresses assigned to the interface that will be used to send to the destination (the outgoing interface). Add a sysctl to enable this behaviour.

Re: [PATCH net-next] ipv6: sysctl to restrict candidate source addresses

2015-07-05 Thread Erik Kline
Reworked with use_oif_addr. Thanks, -Erik On 3 July 2015 at 16:03, YOSHIFUJI Hideaki hideaki.yoshif...@miraclelinux.com wrote: Hi, Erik Kline wrote: Per RFC 6724, section 4, Candidate Source Addresses: It is RECOMMENDED that the candidate source addresses be the set of unicast

Re: [PATCH,v2 net-next] ipvs: skb_orphan in case of forwarding

2015-07-05 Thread Simon Horman
On Sun, Jul 05, 2015 at 03:19:27PM -0700, Alex Gartrell wrote: On Sun, Jul 5, 2015 at 3:13 PM, Julian Anastasov j...@ssi.bg wrote: May be the patch fixes crashes? If yes, Simon should apply it for ipvs/net tree, otherwise after the merge window... Yeah this is definitely a