[PATCH net 1/1] sfc: Ensure down_write(filter_sem) and up_write() are matched before calling efx_net_open()

2015-07-08 Thread Shradha Shah
This patch avoids the double up_write to filter_sem if efx_net_open() fails. Resolves: 2d432f20d27c1813a2746008e16dd6ce12a14dc1 Signed-off-by: Shradha Shah ss...@solarflare.com --- drivers/net/ethernet/sfc/ef10_sriov.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-)

Re: [PATCH V2] cdc_ncm: Add support for moving NDP to end of NCM frame

2015-07-08 Thread Enrico Mioso
Hi Oliver and everybody reading this message. So V3 of this patch fixed the issue I reported recently. I wasn't properly accounting for the NDP size when writing new packets to the SKB: so i ended up writing past the end of SKB buffer. Thank you for your patience and help. Enrico -- To

Re: [PATCH net-next] ifb: add multiqueue operation

2015-07-08 Thread Jamal Hadi Salim
On 07/06/15 16:05, Eric Dumazet wrote: From: Eric Dumazet eduma...@google.com Add multiqueue capabilities to ifb netdevice. This removes last bottleneck for ingress when mq qdisc can be used to shard load from multiple RX queues on physical device. Looks good to me ;- Any perf numbers

[PATCH] rtnl_lock called twice in i40e_pci_error_resume()

2015-07-08 Thread Vasily Averin
Signed-off-by: Vasily Averin v...@virtuozzo.com --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index 48a52b3..ef091d4 100644 ---

Re: [PATCH net-next v2] ipv6: sysctl to restrict candidate source addresses

2015-07-08 Thread Erik Kline
I really would like to come up with a sane works-always behavior for this, but besides doing a retry on the complete source address selection algorithm I currently cannot come up with an idea. Maybe we can tweak saddr_eval a bit. I think it all comes down to this: source address selection

Re: [PATCH v2 1/1] Added additional callback to ptp_clock_info:

2015-07-08 Thread Josh Cartwright
On Wed, Jul 08, 2015 at 01:54:34PM +0200, Richard Cochran wrote: On Mon, Jul 06, 2015 at 03:44:58PM -0500, Josh Cartwright wrote: It's difficult to make too many judgements without seeing how a driver might implement this; is there another patchset that shows how a driver implements this?

Re: [PATCH net-next v2] ipv4: add support for linkdown sysctl to netconf

2015-07-08 Thread Andy Gospodarek
On Wed, Jul 08, 2015 at 11:43:50AM +0200, Nicolas Dichtel wrote: Le 07/07/2015 19:56, Andy Gospodarek a écrit : This kernel patch exports the value of the new ignore_routes_with_linkdown via netconf. v2: changes to notify userspace via netlink when sysctl values change and proposed for

[PATCH V3] cdc_ncm: Add support for moving NDP to end of NCM frame

2015-07-08 Thread Enrico Mioso
NCM specs are not actually mandating a specific position in the frame for the NDP (Network Datagram Pointer). However, some Huawei devices will ignore our aggregates if it is not placed after the datagrams it points to. Add support for doing just this, in a per-device configurable way. While at

Re: [PATCH 3/3] ipmr_free_table() should be called under taken rtnl_lock

2015-07-08 Thread Vasily Averin
On 08.07.2015 13:29, Vasily Averin wrote: On 07.07.2015 20:53, Vasily Averin wrote: On 07.07.2015 20:30, Cong Wang wrote: On Tue, Jul 7, 2015 at 10:25 AM, Vasily Averin v...@virtuozzo.com wrote: On 07.07.2015 20:13, Cong Wang wrote: On Tue, Jul 7, 2015 at 8:53 AM, Vasily Averin

Re: [PATCH v2 1/1] Added additional callback to ptp_clock_info:

2015-07-08 Thread Richard Cochran
On Mon, Jul 06, 2015 at 03:44:58PM -0500, Josh Cartwright wrote: It's difficult to make too many judgements without seeing how a driver might implement this; is there another patchset that shows how a driver implements this? The interface is certainly clear enough to me. The details of

Re: [PATCH net-next v2] ipv6: sysctl to restrict candidate source addresses

2015-07-08 Thread Lorenzo Colitti
On Wed, Jul 8, 2015 at 5:43 PM, Hannes Frederic Sowa han...@stressinduktion.org wrote: For example, consider the case where you have an IPv6 default route but not an IPv6 address on one interface (e.g., wifi), and a working configuration (IPv6 default route and IPv6 address) on another

RE: [PATCH] freescale:Make the function gfar_configure_coalescing_all static

2015-07-08 Thread Manoil Claudiu
-Original Message- From: Nicholas Krause [mailto:xerofo...@gmail.com] Sent: Tuesday, July 07, 2015 11:14 PM To: da...@davemloft.net Cc: Manoil Claudiu-B08782; haoke...@gmail.com; matei.paval...@freescale.com; u.kleine-koe...@pengutronix.de; jingchang...@freescale.com;

RE: [PATCH v5] net: fec: Ensure clocks are enabled while using mdio bus

2015-07-08 Thread Duan Andy
From: Andrew Lunn and...@lunn.ch Sent: Tuesday, July 07, 2015 2:35 AM To: David Miller Cc: Duan Fugang-B38611; Cory Tusar; netdev; Andrew Lunn Subject: [PATCH v5] net: fec: Ensure clocks are enabled while using mdio bus When a switch is attached to the mdio bus, the mdio bus can be used

Re: problems with L2TP

2015-07-08 Thread James Chapman
On 06/07/15 17:16, Sam Protsenko wrote: Thanks for your reply, Tom! How are you deriving the session and tunnel IDs? If you mean how they are generated at client side -- they are basically random values (I'm using modified mtpd tool from Android): - session ID -- see local_session variable

Re: [PATCH v2] add stealth mode

2015-07-08 Thread Hannes Frederic Sowa
On Tue, 2015-07-07 at 17:27 +0200, Matteo Croce wrote: 2015-07-07 10:07 GMT+02:00 Hannes Frederic Sowa han...@stressinduktion.org: On Mon, Jul 6, 2015, at 21:44, Matteo Croce wrote: 2015-07-06 12:49 GMT+02:00 valdis.kletni...@vt.edu: On Thu, 02 Jul 2015 10:56:01 +0200, Matteo

Re: [net PATCH 1/1] drivers: net: cpsw: fix disabling of tx interrupt in rx isr

2015-07-08 Thread Mugunthan V N
On Wednesday 08 July 2015 01:08 PM, Felipe Balbi wrote: Hi, On Wed, Jul 08, 2015 at 12:17:46PM +0530, Mugunthan V N wrote: With the below commit, common isr is split into tx and rx, but in rx isr tx interrupt is also disabled. So tx packets are not handled during rx interrupts and rx napi

Re: [PATCH 3/3] ipmr_free_table() should be called under taken rtnl_lock

2015-07-08 Thread Vasily Averin
On 07.07.2015 20:53, Vasily Averin wrote: On 07.07.2015 20:30, Cong Wang wrote: On Tue, Jul 7, 2015 at 10:25 AM, Vasily Averin v...@virtuozzo.com wrote: On 07.07.2015 20:13, Cong Wang wrote: On Tue, Jul 7, 2015 at 8:53 AM, Vasily Averin v...@virtuozzo.com wrote: ipmr_free_table() calls

Re: [RFC net-next 2/6] net: Preparation for vrf device

2015-07-08 Thread Nicolas Dichtel
Le 06/07/2015 17:03, David Ahern a écrit : Add a VRF_MASTER flag for interfaces and helper functions for determining if a device is a VRF_MASTER. Also, add link attribute for passing VRF_TABLE id. Both are used in the following patch that adds a VRF device driver. Signed-off-by: Shrijeet

[PATCH net 1/1] sfc: Report TX completions to BQL after all TX events in interrupt

2015-07-08 Thread Shradha Shah
From: Peter Dunning pdunn...@solarflare.com The limit for BQL is updated each time we call netdev_tx_completed_queue. Without this patch the BQL limit was updated for every TX event we see. The issue was that this only updated the limit to handle the data we complete in two events as the first

[PATCH 2/7] netfilter: bridge: fix CONFIG_NF_DEFRAG_IPV4/6 related warnings/errors

2015-07-08 Thread Pablo Neira Ayuso
From: Bernhard Thaler bernhard.tha...@wvnet.at br_nf_ip_fragment() is not needed when neither CONFIG_NF_DEFRAG_IPV4 nor CONFIG_NF_DEFRAG_IPV6 is set. struct brnf_frag_data must be available if either CONFIG_NF_DEFRAG_IPV4 or CONFIG_NF_DEFRAG_IPV6 is set. Fixes: efb6de9b4ba0 (netfilter: bridge:

[PATCH 0/7] Netfilter fixes for net

2015-07-08 Thread Pablo Neira Ayuso
Hi David, The following patchset contains Netfilter fixes for your net tree. This batch mostly comes with patches to address fallout from the previous merge window cycle, they are: 1) Use entry-state.hook_list from nf_queue() instead of the global nf_hooks which is not valid when used from

[PATCH 3/7] netfilter: arptables: use percpu jumpstack

2015-07-08 Thread Pablo Neira Ayuso
From: Florian Westphal f...@strlen.de commit 482cfc318559 (netfilter: xtables: avoid percpu ruleset duplication) Unlike ip and ip6tables, arp tables were never converted to use the percpu jump stack. It still uses the rule blob to store return address, which isn't safe anymore since we now

Re: [PATCH net-next v2] ipv4: add support for linkdown sysctl to netconf

2015-07-08 Thread Nicolas Dichtel
Le 07/07/2015 19:56, Andy Gospodarek a écrit : This kernel patch exports the value of the new ignore_routes_with_linkdown via netconf. v2: changes to notify userspace via netlink when sysctl values change and proposed for 'net' since this could be considered a bugfix Hmm, commit title contains

Re: [PATCH v2] net/bridge: Use __in6_dev_get rather than in6_dev_get in br_validate_ipv6

2015-07-08 Thread Pablo Neira Ayuso
On Tue, Jul 07, 2015 at 11:34:34AM -0700, Stephen Hemminger wrote: On Tue, 7 Jul 2015 15:55:21 +0100 Julien Grall julien.gr...@citrix.com wrote: The commit efb6de9b4ba0092b2c55f6a52d16294a8a698edd netfilter: bridge: forward IPv6 fragmented packets introduced a new function

Re: [RFC net-next 0/6] Proposal for VRF-lite - v2

2015-07-08 Thread Nicolas Dichtel
Le 06/07/2015 19:53, Shrijeet Mukherjee a écrit : No no problem, Just trying to get the functional aspects worked out. the global search replace will be easy. Was hoping to see some more responses on the naming suggestions here from the community. If there is not disagreement we can spin

Re: [PATCH net-next v2] ipv6: sysctl to restrict candidate source addresses

2015-07-08 Thread Lorenzo Colitti
On Wed, Jul 8, 2015 at 5:09 PM, Hannes Frederic Sowa han...@stressinduktion.org wrote: I wonder a little bit, because addresses which match the outgoing interface should get a higher score in saddr_eval, thus be automatically preferred. Is this check not strong enough? It isn't strong enough

[PATCH 5/7] netfilter: nfnetlink: keep going batch handling on missing modules

2015-07-08 Thread Pablo Neira Ayuso
After a fresh boot with no modules in place at all and a large rulesets, the existing nfnetlink_rcv_batch() funcion can take long time to commit the ruleset due to the many abort path. This is specifically a problem for the existing client of this code, ie. nf_tables, since it results in several

[PATCH 4/7] netfilter: bridge: don't leak skb in error paths

2015-07-08 Thread Pablo Neira Ayuso
From: Florian Westphal f...@strlen.de br_nf_dev_queue_xmit must free skb in its error path. NF_DROP is misleading -- its an okfn, not a netfilter hook. Fixes: 462fb2af9788a (bridge : Sanitize skb before it enters the IP stack) Fixes: efb6de9b4ba00 (netfilter: bridge: forward IPv6 fragmented

[PATCH 6/7] MAINTAINER: add bridge netfilter

2015-07-08 Thread Pablo Neira Ayuso
So scripts/get_maintainer.pl shows the Netfilter mailing lists. Reported-by: Julien Grall julien.gr...@citrix.com Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- MAINTAINERS |1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 993d4cf..8183b465 100644

[PATCH 7/7] netfilter: bridge: Use __in6_dev_get rather than in6_dev_get in br_validate_ipv6

2015-07-08 Thread Pablo Neira Ayuso
From: Julien Grall julien.gr...@citrix.com The commit efb6de9b4ba0092b2c55f6a52d16294a8a698edd netfilter: bridge: forward IPv6 fragmented packets introduced a new function br_validate_ipv6 which take a reference on the inet6 device. Although, the reference is not released at the end. This will

[PATCH 1/7] netfilter: nf_queue: Don't recompute the hook_list head

2015-07-08 Thread Pablo Neira Ayuso
From: Eric W. Biederman ebied...@xmission.com If someone sends packets from one of the netdevice ingress hooks to the a userspace queue, and then userspace later accepts the packet, the netfilter code can enter an infinite loop as the list head will never be found. Pass in the saved list_head to

Re: [net PATCH 1/1] drivers: net: cpsw: fix disabling of tx interrupt in rx isr

2015-07-08 Thread Felipe Balbi
Hi, On Wed, Jul 08, 2015 at 12:17:46PM +0530, Mugunthan V N wrote: With the below commit, common isr is split into tx and rx, but in rx isr tx interrupt is also disabled. So tx packets are not handled during rx interrupts and rx napi completion. Fixing by disabling on rx interrupt in rx isr.

[PATCH 4.1 11/56] mvneta: add forgotten initialization of autonegotiation bits

2015-07-08 Thread Greg Kroah-Hartman
4.1-stable review patch. If anyone has any objections, please let me know. -- From: Stas Sergeev s...@list.ru [ Upstream commit 538761b794c1542f1c6e31eadd9d7aae118889f7 ] The commit 898b2970e2c9 (mvneta: implement SGMII-based in-band link state signaling) changed

Re: [PATCH V2] cdc_ncm: Add support for moving NDP to end of NCM frame

2015-07-08 Thread Enrico Mioso
So, here is what I tried so far: 1 - Check if the pointer gets corrupted somehow (address change): it seems this doesn't happen at all. 2 - Size problems: I tried setting higher values of the size just in case, with absolutely no changei n behaviour. The code that assigns the pointer the

Re: [RFC net-next 2/6] net: Preparation for vrf device

2015-07-08 Thread Nicolas Dichtel
Le 08/07/2015 10:37, Nicolas Dichtel a écrit : [snip] Also, why calling this '_MASTER', is there a notion of SLAVE? Ok, just got it in the next patch ;-) -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-08 Thread Nicolas Dichtel
Le 06/07/2015 17:03, David Ahern a écrit : This driver borrows heavily from IPvlan and teaming drivers. Routing domains (VRF-lite) are created by instantiating a device and enslaving all routed interfaces that participate in the domain. As part of the enslavement, all local routes pointing to

Re: [PATCH net-next v2] ipv6: sysctl to restrict candidate source addresses

2015-07-08 Thread Hannes Frederic Sowa
On Wed, 2015-07-08 at 10:29 +0900, Lorenzo Colitti wrote: On Mon, Jul 6, 2015 at 12:05 PM, Erik Kline e...@google.com wrote: Per RFC 6724, section 4, Candidate Source Addresses: It is RECOMMENDED that the candidate source addresses be the set of unicast addresses assigned to the

Re: [PATCH net-next v2] ipv6: sysctl to restrict candidate source addresses

2015-07-08 Thread Hannes Frederic Sowa
On Wed, 2015-07-08 at 17:19 +0900, Lorenzo Colitti wrote: On Wed, Jul 8, 2015 at 5:09 PM, Hannes Frederic Sowa han...@stressinduktion.org wrote: I wonder a little bit, because addresses which match the outgoing interface should get a higher score in saddr_eval, thus be automatically

[net PATCH v2 1/1] drivers: net: cpsw: fix disabling of tx interrupt in rx isr

2015-07-08 Thread Mugunthan V N
In commit 'c03abd84634d (net: ethernet: cpsw: don't requests IRQs we don't use)', common isr is split into tx and rx, but in rx isr tx interrupt is also disabledi in cpsw_disable_irq(). So tx interrupts are not handled during rx interrupts and rx napi completion and results in poor tx performance

Re: [PATCH net-next] ifb: add multiqueue operation

2015-07-08 Thread Eric Dumazet
On Wed, 2015-07-08 at 08:29 -0400, Jamal Hadi Salim wrote: On 07/06/15 16:05, Eric Dumazet wrote: From: Eric Dumazet eduma...@google.com Add multiqueue capabilities to ifb netdevice. This removes last bottleneck for ingress when mq qdisc can be used to shard load from multiple RX

ip_forward_use_pmtu and forwarding to xfrm'ed gre

2015-07-08 Thread Timo Teras
Hi, It seems ip_forward_use_pmtu commit log says: Tunnel and ipsec output paths clear IPCB again, thus IPSKB_FORWARDED won't be set and further fragmentation logic will use the path mtu to determine the fragmentation size. They also recheck packet size with help of path mtu

Re: [PATCH v2] add stealth mode

2015-07-08 Thread Austin S Hemmelgarn
On 2015-07-06 15:44, Matteo Croce wrote: 2015-07-06 12:49 GMT+02:00 valdis.kletni...@vt.edu: On Thu, 02 Jul 2015 10:56:01 +0200, Matteo Croce said: Add option to disable any reply not related to a listening socket, like RST/ACK for TCP and ICMP Port-Unreachable for UDP. Also disables ICMP

[BUG ?] brcmsmac: condition with no effect

2015-07-08 Thread Nicholas Mc Guire
From: Nicholas Mc Guire hof...@osadl.org scanning for trivial bug-patters with coccinelle spatches returned: drivers/net/wireless/brcm80211/brcmsmac/phy/phy_lcn.c:3391 WARNING: condition with no effect (if branch == else) added in 'commit

[PATCH] rtlwifi: rtl8821ae: Fix an expression that is always false

2015-07-08 Thread Larry Finger
In routine _rtl8821ae_set_media_status(), an incorrect mask results in a test for AP status to always be false. Similar bugs were fixed in rtl8192cu and rtl8192de, but this instance was missed at that time. Reported-by: David Binderman dcb...@hotmail.com Signed-off-by: Larry Finger

[PATCH] macvtap: Destroy minor_idr on module_exit

2015-07-08 Thread Johannes Thumshirn
Destroy minor_idr on module_exit, reclaiming the allocated memory. This was detected by the following semantic patch (written by Luis Rodriguez mcg...@suse.com) SmPL @ defines_module_init @ declarer name module_init, module_exit; declarer name DEFINE_IDR; identifier init; @@ module_init(init);

Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-08 Thread Andrew Lunn
On Tue, Jul 07, 2015 at 05:18:17PM -0400, Vivien Didelot wrote: Hi all, This patchset brings full support for hardware VLANs in DSA, and the Marvell 88E6xxx compatible switch chips. Hi Vivien I would like to do a proper review and testing of these patchset, but i go on vacation this

Re: [PATCH] dsa: mv88e6352/mv88e6xxx: Add support for Marvell 88E6320 and 88E6321

2015-07-08 Thread Guenter Roeck
On 07/08/2015 07:52 AM, Andrew Lunn wrote: On Tue, Jul 07, 2015 at 08:38:15PM -0700, Guenter Roeck wrote: From: Aleksey S. Kazantsev io...@yandex.ru MV88E6320 and MV88E6321 are largely compatible to MV886352, but are members of a different chip family. Signed-off-by: Aleksey S. Kazantsev

[PATCH] mwifiex: drop condition with no effect

2015-07-08 Thread Nicholas Mc Guire
-20150708) drivers/net/wireless/mwifiex/sta_cmdresp.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/mwifiex/sta_cmdresp.c b/drivers/net/wireless/mwifiex/sta_cmdresp.c index b645884..e58f900 100644 --- a/drivers/net/wireless/mwifiex

Re: [PATCH] dsa: mv88e6352/mv88e6xxx: Add support for Marvell 88E6320 and 88E6321

2015-07-08 Thread Andrew Lunn
On Tue, Jul 07, 2015 at 08:38:15PM -0700, Guenter Roeck wrote: From: Aleksey S. Kazantsev io...@yandex.ru MV88E6320 and MV88E6321 are largely compatible to MV886352, but are members of a different chip family. Signed-off-by: Aleksey S. Kazantsev io...@yandex.ru Signed-off-by: Guenter

[patch iproute2] iproute2: ipa: show switch id

2015-07-08 Thread Jiri Pirko
We forgot to include this patch somehow. So do it now. Signed-off-by: Jiri Pirko j...@resnulli.us --- ip/ipaddress.c | 8 1 file changed, 8 insertions(+) diff --git a/ip/ipaddress.c b/ip/ipaddress.c index 85a81ba..b7b4e3e 100644 --- a/ip/ipaddress.c +++ b/ip/ipaddress.c @@ -688,6

Re: [net PATCH 1/1] drivers: net: cpsw: fix disabling of tx interrupt in rx isr

2015-07-08 Thread Felipe Balbi
Hi, On Wed, Jul 08, 2015 at 02:21:27PM +0530, Mugunthan V N wrote: On Wednesday 08 July 2015 01:08 PM, Felipe Balbi wrote: Hi, On Wed, Jul 08, 2015 at 12:17:46PM +0530, Mugunthan V N wrote: With the below commit, common isr is split into tx and rx, but in rx isr tx interrupt is also

Re: ip_forward_use_pmtu and forwarding to xfrm'ed gre

2015-07-08 Thread Hannes Frederic Sowa
Hello, On Wed, 2015-07-08 at 16:30 +0300, Timo Teras wrote: Hi, It seems ip_forward_use_pmtu commit log says: Tunnel and ipsec output paths clear IPCB again, thus IPSKB_FORWARDED won't be set and further fragmentation logic will use the path mtu to determine the fragmentation

Re: ip_forward_use_pmtu and forwarding to xfrm'ed gre

2015-07-08 Thread Timo Teras
On Wed, 08 Jul 2015 17:52:32 +0200 Hannes Frederic Sowa han...@stressinduktion.org wrote: On Wed, 2015-07-08 at 16:30 +0300, Timo Teras wrote: This probably is due to the way how the xfrm+gre work together. On first packet, the gre tunnel driver updates pmtu for the inner flow, which is

RE: [PATCH] freescale:Make the function gfar_clean_tx_ring static

2015-07-08 Thread Manoil Claudiu
-Original Message- From: Nicholas Krause [mailto:xerofo...@gmail.com] Sent: Tuesday, July 07, 2015 11:01 PM To: da...@davemloft.net Cc: Manoil Claudiu-B08782; haoke...@gmail.com; matei.paval...@freescale.com; u.kleine-koe...@pengutronix.de; jingchang...@freescale.com;

[net-next]Add Maximum Rx packet size supported(rx_buf_sz) variable on main structure

2015-07-08 Thread Marian Corcodel
Variable rx_buf_sz have different values on rt8101/8102 is 16000 bytes instead of 16383 and now is ready do set these. diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 9189da3..1a55057 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-08 Thread Sowmini Varadhan
On Mon, Jul 6, 2015 at 5:03 PM, David Ahern d...@cumulusnetworks.com wrote: This driver borrows heavily from IPvlan and teaming drivers. Routing domains (VRF-lite) are created by instantiating a device and enslaving all routed interfaces that participate in the domain. As part of the

Re: [PATCH 4.1 11/56] mvneta: add forgotten initialization of autonegotiation bits

2015-07-08 Thread Stas Sergeev
08.07.2015 20:36, Greg Kroah-Hartman пишет: On Wed, Jul 08, 2015 at 08:10:46PM +0300, Stas Sergeev wrote: 08.07.2015 10:35, Greg Kroah-Hartman пишет: 4.1-stable review patch. If anyone has any objections, please let me know. -- From: Stas Sergeev s...@list.ru [ Upstream

Re: [5/6] mvneta: implement SGMII-based in-band link state signaling

2015-07-08 Thread Sebastien Rannou
Hi Stas, On Fri, 27 Mar 2015, Stas Sergeev wrote: When MDIO bus is unavailable (common setup for SGMII), the in-band signaling must be used to correctly track link state. This patch enables the in-band status delivery and interrupts for links state changes, namely: - link up/down - link

Re: [PATCH 4.1 11/56] mvneta: add forgotten initialization of autonegotiation bits

2015-07-08 Thread Stas Sergeev
08.07.2015 10:35, Greg Kroah-Hartman пишет: 4.1-stable review patch. If anyone has any objections, please let me know. -- From: Stas Sergeev s...@list.ru [ Upstream commit 538761b794c1542f1c6e31eadd9d7aae118889f7 ] The commit 898b2970e2c9 (mvneta: implement SGMII-based

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-08 Thread David Ahern
On 7/8/15 3:27 AM, Nicolas Dichtel wrote: + +struct pcpu_dstats { +u64tx_pkts; +u64tx_bytes; +u64tx_drps; +u64rx_pkts; +u64rx_bytes; +struct u64_stats_syncsyncp; +}; Why not using 'struct pcpu_sw_netstats'

Re: [PATCH] tile:Remove unused marcos from the file tilepro.c

2015-07-08 Thread Chris Metcalf
On 07/06/2015 09:22 PM, Nicholas Krause wrote: This removes no longer used marcos at the top of the driver due tilepro.c due to having no proper values nor never being used by this driver code. Signed-off-by: Nicholas Krausexerofo...@gmail.com --- drivers/net/ethernet/tile/tilepro.c | 13

Re: [5/6] mvneta: implement SGMII-based in-band link state signaling

2015-07-08 Thread Stas Sergeev
08.07.2015 19:30, Sebastien Rannou пишет: Hi Stas, On Fri, 27 Mar 2015, Stas Sergeev wrote: When MDIO bus is unavailable (common setup for SGMII), the in-band signaling must be used to correctly track link state. This patch enables the in-band status delivery and interrupts for links state

Re: [patch iproute2] iproute2: ipa: show switch id

2015-07-08 Thread Andy Gospodarek
On Wed, Jul 08, 2015 at 05:08:18PM +0200, Jiri Pirko wrote: We forgot to include this patch somehow. So do it now. I noticed this the other day and wondered where it was. Thanks for posting it before I searched archives wondering why it was not. Signed-off-by: Jiri Pirko j...@resnulli.us

Re: [linuxwifi] [PATCH] iwlwifi:Make various functions void in the file rs.c

2015-07-08 Thread Grumbach, Emmanuel
Hi, On 07/08/2015 06:03 PM, Nicholas Krause wrote: This makes various functions in the file rs.c void due to these functions never returning a error code to signal to their callers if and how they have failed to complete their intended work. Signed-off-by: Nicholas Krause

Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-08 Thread Vivien Didelot
Hi Andrew, On Jul 8, 2015, at 10:38 AM, Andrew Lunn and...@lunn.ch wrote: On Tue, Jul 07, 2015 at 05:18:17PM -0400, Vivien Didelot wrote: Hi all, This patchset brings full support for hardware VLANs in DSA, and the Marvell 88E6xxx compatible switch chips. Hi Vivien I would like to do

Re: [PATCH 4.1 11/56] mvneta: add forgotten initialization of autonegotiation bits

2015-07-08 Thread Greg Kroah-Hartman
On Wed, Jul 08, 2015 at 08:10:46PM +0300, Stas Sergeev wrote: 08.07.2015 10:35, Greg Kroah-Hartman пишет: 4.1-stable review patch. If anyone has any objections, please let me know. -- From: Stas Sergeev s...@list.ru [ Upstream commit

Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-08 Thread Andrew Lunn
Vivien Didelot wrote: Hi Andrew, On Jul 8, 2015, at 10:38 AM, Andrew Lunn and...@lunn.ch wrote: On Tue, Jul 07, 2015 at 05:18:17PM -0400, Vivien Didelot wrote: Hi all, This patchset brings full support for hardware VLANs in DSA, and the Marvell 88E6xxx compatible switch chips.

Re: ip_forward_use_pmtu and forwarding to xfrm'ed gre

2015-07-08 Thread Hannes Frederic Sowa
Hello, On Wed, 2015-07-08 at 19:17 +0300, Timo Teras wrote: On Wed, 08 Jul 2015 17:52:32 +0200 Hannes Frederic Sowa han...@stressinduktion.org wrote: On Wed, 2015-07-08 at 16:30 +0300, Timo Teras wrote: This probably is due to the way how the xfrm+gre work together. On first packet,

Fighting out-of-order reception with RPS?

2015-07-08 Thread Oliver Hartkopp
I'm picking up the request 'Setting RPS affinities from network driver' from Sunil Kovvuri http://marc.info/?t=14242402351r=1w=2 as I assume to have the same issue here. When receiving CAN frames from a specific CAN network interface (e.g. can0) the frames are sporadically out-of-order on SMP

Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-08 Thread Vivien Didelot
Hi Andrew, On Jul 8, 2015, at 1:32 PM, Andrew Lunn and...@lunn.ch wrote: Vivien Didelot wrote: Hi Andrew, On Jul 8, 2015, at 10:38 AM, Andrew Lunn and...@lunn.ch wrote: On Tue, Jul 07, 2015 at 05:18:17PM -0400, Vivien Didelot wrote: Hi all, This patchset brings full support for

Re: [net-next]Disable writting on reg config1 value is read-only

2015-07-08 Thread Marian Corcodel
[net-next]resend Disable writting on reg config1 value is read-only On rtl8101/8102 MEMMAP | IOMAP | VPD | PMEnable is enabled on default and is read-only and is not need to write on these. 2015-07-08 21:55 GMT+03:00 Marian Corcodel corcodel.mar...@gmail.com: On rtl8101/8102 MEMMAP | IOMAP |

Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-08 Thread Andrew Lunn
I understand. However this whole VLAN thing represents a lot of code. Some other work depends on portions of it. Do you think it'd be OK if I resend the patch 1/3 alone? Having only the VTU operations and vtu debugfs file does not break the actual behavior, and will lighten up the following

net-next is OPEN

2015-07-08 Thread David Miller
Please feel free to bombard me with net-next changes, which some of you have been doing already ;-(, as net-next is now open. Thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH net-next RESEND] test_bpf: extend tests for 32-bit endianness conversion

2015-07-08 Thread Xi Wang
Currently ALU_END_FROM_BE 32 and ALU_END_FROM_LE 32 do not test if the upper bits of the result are zeros (the arm64 JIT had such bugs). Extend the two tests to catch this. Acked-by: Daniel Borkmann dan...@iogearbox.net Acked-by: Alexei Starovoitov a...@plumgrid.com Signed-off-by: Xi Wang

Re: [PATCH] NET: hamradio: Fix IP over bpq encapsulation.

2015-07-08 Thread David Miller
From: Ralf Baechle r...@linux-mips.org Date: Sat, 4 Jul 2015 11:22:30 +0200 Since 1d5da757da860a6916adbf68b09e868062b4b3b8 (ax25: Stop using magic neighbour cache operations.) any attempt to transmit IP packets over a bpqether device will result in a message like Dead loop on virtual device

Re: [PATCH,v2 net-next] ipvs: skb_orphan in case of forwarding

2015-07-08 Thread Eric Dumazet
On Wed, 2015-07-08 at 13:56 -0700, Alex Gartrell wrote: On Tue, Jul 7, 2015 at 6:33 PM, Simon Horman ho...@verge.net.au wrote: Is there any possibility you could investigate which stable trees are effected by this bug? Well this was certainly a problem in 3.10 (we had our own hacky

[PATCH 0/2] net: pktgen: fix race between pktgen_thread_worker() and kthread_stop()

2015-07-08 Thread Oleg Nesterov
Hello, I am not familiar with this code and I have no idea how to test these changes, so 2/2 comes as a separate change. 1/2 looks like the obvious bugfix, and probably candidate for -stable. Oleg. net/core/pktgen.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) -- To

[PATCH 1/2] net: pktgen: fix race between pktgen_thread_worker() and kthread_stop()

2015-07-08 Thread Oleg Nesterov
pktgen_thread_worker() is obviously racy, kthread_stop() can come between the kthread_should_stop() check and set_current_state(). Signed-off-by: Oleg Nesterov o...@redhat.com Reported-by: Jan Stancek jstan...@redhat.com Reported-by: Marcelo Leitner mleit...@redhat.com --- net/core/pktgen.c |

[PATCH 2/2] net: pktgen: kill the Wait for kthread_stop code in pktgen_thread_worker()

2015-07-08 Thread Oleg Nesterov
pktgen_thread_worker() doesn't need to wait for kthread_stop(), it can simply exit. Just pktgen_create_thread() and pg_net_exit() should do get_task_struct()/put_task_struct(). kthread_stop(dead_thread) is fine. Signed-off-by: Oleg Nesterov o...@redhat.com --- net/core/pktgen.c | 11

[PATCH v2] brcmsmac: Use kstrdup to simplify code

2015-07-08 Thread Christophe JAILLET
Replace a kmalloc+strcpy by an equivalent kstrdup in order to improve readability. Signed-off-by: Christophe JAILLET christophe.jail...@wanadoo.fr --- v2: fix the subject drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [PATCH 1/2] net: dsa: mv88e6xxx: add write access to debugfs regs file

2015-07-08 Thread Vivien Didelot
Hi Andrew, - On Jul 8, 2015, at 4:53 PM, Andrew Lunn and...@lunn.ch wrote: On Wed, Jul 08, 2015 at 04:36:18PM -0400, Vivien Didelot wrote: Allow write access to the regs file in the debugfs interface, with the following parameters: echo name reg value regs Where name is the

Re: [RESEND] xen-netback: remove duplicated function definition

2015-07-08 Thread David Miller
From: Liang Li liang.z...@intel.com Date: Mon, 6 Jul 2015 08:42:56 +0800 There are two duplicated xenvif_zerocopy_callback() definitions. Remove one of them. Signed-off-by: Liang Li liang.z...@intel.com Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in

Re: Fighting out-of-order reception with RPS?

2015-07-08 Thread Tom Herbert
On Wed, Jul 8, 2015 at 10:49 AM, Oliver Hartkopp socket...@hartkopp.net wrote: I'm picking up the request 'Setting RPS affinities from network driver' from Sunil Kovvuri http://marc.info/?t=14242402351r=1w=2 as I assume to have the same issue here. When receiving CAN frames from a

Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-08 Thread Andrew Lunn
This is a limitation of the switch. So the driver needs to keep track of which bridge a VLAN belongs to, if it is asked to accelerate the same VLAN for a different bridge, it needs to say to the kernel, sorry, cannot do that, and leave the kernel to do it in software. Scott, how do you

Re: [PATCH 4.1 11/56] mvneta: add forgotten initialization of autonegotiation bits

2015-07-08 Thread Stas Sergeev
08.07.2015 22:36, Arnaud Ebalard пишет: Hi, Stas Sergeev s...@list.ru writes: Another problem was reported: https://lkml.org/lkml/2015/7/8/865 So, while the above patch is correct and fixes what it should, the original patch has more problems to deal with. Maybe for stable it would be better

Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-08 Thread Vivien Didelot
Hi Andrew, - On Jul 8, 2015, at 4:12 PM, Andrew Lunn and...@lunn.ch wrote: I understand. However this whole VLAN thing represents a lot of code. Some other work depends on portions of it. Do you think it'd be OK if I resend the patch 1/3 alone? Having only the VTU operations and vtu

Re: [PATCH,v2 net-next] ipvs: skb_orphan in case of forwarding

2015-07-08 Thread Alex Gartrell
On Tue, Jul 7, 2015 at 6:33 PM, Simon Horman ho...@verge.net.au wrote: Is there any possibility you could investigate which stable trees are effected by this bug? Well this was certainly a problem in 3.10 (we had our own hacky solution at the time) and every kernel since then would have also

Re: [PATCH net-next] drivers: net: xgene: Fix the compilation error error: implicit declaration of function 'acpi_evaluate_integer' for CONFIG_ACPI=n.

2015-07-08 Thread David Miller
From: Suman Tripathi stripa...@apm.com Date: Mon, 6 Jul 2015 13:34:22 +0530 This patch guards the acpi_evaluate_interger function as it fails the build for CONFIG_ACPI=n. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Suman Tripathi stripa...@apm.com Reported-by:

Re: [PATCH] net: macb: Add SG support for Zynq SOC family

2015-07-08 Thread David Miller
From: Punnaiah Choudary Kalluri punnaiah.choudary.kall...@xilinx.com Date: Mon, 6 Jul 2015 10:02:53 +0530 Enable SG support for Zynq SOC family devices. Signed-off-by: Punnaiah Choudary Kalluri punn...@xilinx.com Applied to net-next, thanks. -- To unsubscribe from this list: send the line

Re: [PATCH 0/2 net-next] tcp: reducing lost retransmits in recovery

2015-07-08 Thread David Miller
From: Yuchung Cheng ych...@google.com Date: Wed, 1 Jul 2015 14:11:13 -0700 This patch series reduces lost retransmits in recovery, in particular when dealing with traffic policers. The main problem is that slow start in recovery under policing can cause massive lost and retransmit storms:

Re: [PATCH v3 net-next 0/7] net_sched: act: lockless operation

2015-07-08 Thread David Miller
From: Eric Dumazet eduma...@google.com Date: Mon, 6 Jul 2015 05:18:02 -0700 As mentioned by Alexei last week in Budapest, it is a bit weird to take a spinlock in order to drop a packet in a tc filter... Lets add percpu infra for tc actions and use it for gact mirred. Before changes, my

Re: [PATCH] samples: bpf: enable trace samples for s390x

2015-07-08 Thread David Miller
From: Michael Holzheu holz...@linux.vnet.ibm.com Date: Mon, 6 Jul 2015 16:20:07 +0200 The trace bpf samples do not compile on s390x because they use x86 specific fields from the pt_regs structure. Fix this and access the fields via new PT_REGS macros. Signed-off-by: Michael Holzheu

Re: [PATCH v1 01/12] IB/core: pass client data to remove() callbacks

2015-07-08 Thread Jason Gunthorpe
On Mon, Jun 22, 2015 at 03:42:30PM +0300, Haggai Eran wrote: An ib_client callback that is called with the lists_rwsem locked only for read is protected from changes to the IB client lists, but not from ib_unregister_device() freeing its client data. This is because ib_unregister_device() will

[PATCH 1/2] net: dsa: mv88e6xxx: add write access to debugfs regs file

2015-07-08 Thread Vivien Didelot
Allow write access to the regs file in the debugfs interface, with the following parameters: echo name reg value regs Where name is the register name (as shown in the header row), reg is the register address (as shown in the first column) and value is the 16-bit value. e.g.: echo

Re: [PATCH net] net_sched: gen_estimator: extend pps limit

2015-07-08 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Thu, 02 Jul 2015 15:57:19 +0200 From: Eric Dumazet eduma...@google.com rate estimators are limited to 4 Mpps, which was fine years ago, but too small with current hardware generation. Lets use 2^5 scaling instead of 2^10 to get 128 Mpps new

Re: [PATCH 1/2] net: dsa: mv88e6xxx: add write access to debugfs regs file

2015-07-08 Thread Andrew Lunn
On Wed, Jul 08, 2015 at 04:36:18PM -0400, Vivien Didelot wrote: Allow write access to the regs file in the debugfs interface, with the following parameters: echo name reg value regs Where name is the register name (as shown in the header row), reg is the register address (as shown in

Re: [PATCH 2/2] net: dsa: mv88e6xxx: add SERDES registers to debugfs

2015-07-08 Thread Andrew Lunn
On Wed, Jul 08, 2015 at 04:36:19PM -0400, Vivien Didelot wrote: Add read and write access to a SERDES column in the regs debugfs file for the Fiber/SERDES registers. Humm. I don't really like this. These SERDES registers are in a complete different address space to the port, globalX registers.

[PATCH net-next 1/3] inet: remove BUG_ON() in twsk_destructor()

2015-07-08 Thread Eric Dumazet
Kernel will crash the same if one of the pointer is NULL anyway. Signed-off-by: Eric Dumazet eduma...@google.com --- include/net/timewait_sock.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/net/timewait_sock.h b/include/net/timewait_sock.h index 68f0ecad6c6e..1a47946f95ba 100644

[PATCH net-next 0/3] inet: timewait cleanups

2015-07-08 Thread Eric Dumazet
Another round of patches to make tw handling simpler. Eric Dumazet (3): inet: remove BUG_ON() in twsk_destructor() inet: simplify timewait refcounting inet: inet_twsk_deschedule factorization include/net/inet_hashtables.h| 4 +-- include/net/inet_timewait_sock.h | 8 +++---

Re: [PATCH net-next] net/mlx4_core: Add extra check for total vfs for SRIOV

2015-07-08 Thread David Miller
From: cls...@linux.vnet.ibm.com Date: Mon, 6 Jul 2015 09:20:19 -0500 From: Carol Soto cls...@linux.vnet.ibm.com Add extra check for total vfs for SRIOV to check if that value is bigger than total vfs in pci SRIOV capabalities. Fix a check and print of the number of maximum vfs that hw

  1   2   >