RE: [RFC net-next] xfrm: refactory to avoid state tasklet scheduling errors

2015-07-14 Thread Du, Fan
-Original Message- From: Giuseppe Cantavenera [mailto:giuseppe.cantaven...@azcom.it] Sent: Tuesday, July 7, 2015 3:43 PM To: netdev@vger.kernel.org Cc: Giuseppe Cantavenera; Steffen Klassert; David S. Miller; Du, Fan; Alexander Sverdlin; Matija Glavinic Pecotic; Giuseppe Cantavenera;

Re: linux-4.2-rc2/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1993: possible bad error checking ?

2015-07-14 Thread Giuseppe CAVALLARO
Hello David thx to have looked at this. I'll check the code and eventually fix it, unless you already have a patch to propose. Kind Regards Peppe On 7/13/2015 11:48 AM, David Binderman wrote: Hello there, [linux-4.2-rc2/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1993]: (style)

[PATCH net] ipv6: lock socket in ip6_datagram_connect()

2015-07-14 Thread Eric Dumazet
From: Eric Dumazet eduma...@google.com ip6_datagram_connect() is doing a lot of socket changes without socket being locked. This looks wrong, at least for udp_lib_rehash() which could corrupt lists because of concurrent udp_sk(sk)-udp_portaddr_hash accesses. Signed-off-by: Eric Dumazet

Re: [PATCH/RFC net-next] rocker: forward packets to CPU when a port in promiscuous mode

2015-07-14 Thread Scott Feldman
On Wed, Jul 8, 2015 at 9:25 PM, Simon Horman simon.hor...@netronome.com wrote: This change allows the CPU to see all packets seen by a port when the netdev associated with the port is in promiscuous mode. This change was previously posted as part of a larger patch and in turn patchset which

Re: net: Fix skb csum races when peeking

2015-07-14 Thread Eric Dumazet
On Mon, 2015-07-13 at 20:01 +0800, Herbert Xu wrote: ---8--- When we calculate the checksum on the recv path, we store the result in the skb as an optimisation in case we need the checksum again down the line. This is in fact bogus for the MSG_PEEK case as this is done without any

Re: [PATCH net] ipv6: lock socket in ip6_datagram_connect()

2015-07-14 Thread Herbert Xu
Eric Dumazet eric.duma...@gmail.com wrote: From: Eric Dumazet eduma...@google.com ip6_datagram_connect() is doing a lot of socket changes without socket being locked. This looks wrong, at least for udp_lib_rehash() which could corrupt lists because of concurrent

Re: [Patch net] fq_codel: fix a use-after-free

2015-07-14 Thread Eric Dumazet
On Mon, 2015-07-13 at 12:30 -0700, Cong Wang wrote: Fixes: 25331d6ce42b (net: sched: implement qstat helper routines) Cc: John Fastabend john.fastab...@gmail.com Signed-off-by: Cong Wang xiyou.wangc...@gmail.com Signed-off-by: Cong Wang cw...@twopensource.com --- net/sched/sch_fq_codel.c |

[V2 4/7] Drivers: hv: vmbus: add APIs to register callbacks to process hvsock connection

2015-07-14 Thread Dexuan Cui
With the 2 APIs supplied by the VMBus driver, the coming net/hvsock driver can register 2 callbacks and can know when a new hvsock connection is offered by the host, and when a hvsock connection is being closed by the host. Signed-off-by: Dexuan Cui de...@microsoft.com --- drivers/hv/Makefile

[V2 3/7] Drivers: hv: vmbus: add APIs to send/recv hvsock packet and get the r/w-ability

2015-07-14 Thread Dexuan Cui
This will be used by the coming net/hvsock driver. Signed-off-by: Dexuan Cui de...@microsoft.com --- drivers/hv/channel.c | 131 ++ drivers/hv/hyperv_vmbus.h | 4 ++ drivers/hv/ring_buffer.c | 14 + include/linux/hyperv.h| 33

[V2 6/7] hvsock: introduce Hyper-V VM Sockets feature

2015-07-14 Thread Dexuan Cui
Hyper-V VM sockets (hvsock) supplies a byte-stream based communication mechanism between the host and a guest. It's kind of TCP over VMBus, but the transportation layer (VMBus) is much simpler than IP. With Hyper-V VM Sockets, applications between the host and a guest can talk with each other

Re: mmap()ed AF_NETLINK: lockdep and sleep-in-atomic warnings

2015-07-14 Thread Thomas Graf
On 07/13/15 at 10:11pm, Cong Wang wrote: Caused by: commit 21e4902aea80ef35afc00ee8d2abdea4f519b7f7 Author: Thomas Graf tg...@suug.ch Date: Fri Jan 2 23:00:22 2015 +0100 netlink: Lockless lookup with RCU grace period in socket release Defers the release of the socket

Re: [PATCH net-next 2/3] rhashtable: allow lookup function to have compare function agument

2015-07-14 Thread Thomas Graf
On 07/13/15 at 05:39pm, Tom Herbert wrote: Added rhashtable_lookup_fast_cmpfn which does a lookup in an rhash table with the compare function being taken from an argument. This allows different compare functions to be used on the same table. Signed-off-by: Tom Herbert t...@herbertland.com

Re: [PATCH net-next] tc: fix tc actions in case of shared skb

2015-07-14 Thread Daniel Borkmann
On 07/14/2015 12:26 AM, Alexei Starovoitov wrote: On 7/13/15 1:55 PM, Daniel Borkmann wrote: On 07/13/2015 10:17 PM, Alexei Starovoitov wrote: ... We cannot check tc actions from pktgen, since they can be added dynamically. So I see three options: 1 get rid of burst hack for both RX and TX in

Re: linux-next: manual merge of the net-next tree with Linus' tree

2015-07-14 Thread Nikolay Aleksandrov
On 07/14/2015 03:46 AM, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/bridge/br_mdb.c between commit: f1158b74e54f (bridge: mdb: zero out the local br_ip variable before use) from Linus' tree and commit: 74fe61f17e99

[V2 5/7] Drivers: hv: vmbus: add a helper function to set a channel's pending send size

2015-07-14 Thread Dexuan Cui
This will be used by the coming net/hvsock driver. Signed-off-by: Dexuan Cui de...@microsoft.com --- include/linux/hyperv.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h index 307910b3..c52f4cb 100644 --- a/include/linux/hyperv.h +++

[V2 2/7] Drivers: hv: vmbus: define a new VMBus message type for hvsock

2015-07-14 Thread Dexuan Cui
A function to send the type of message is also added. The coming net/hvsock driver will use this function to proactively request the host to offer a VMBus channel for a new hvsock connection. Signed-off-by: Dexuan Cui de...@microsoft.com --- drivers/hv/channel.c | 15 +++

Re: [PATCH v1 11/12] IB/cma: Share ib_cm_ids between rdma_cm_ids

2015-07-14 Thread Haggai Eran
On 13/07/2015 21:06, Jason Gunthorpe wrote: On Mon, Jun 22, 2015 at 03:42:40PM +0300, Haggai Eran wrote: Use ib_cm_id_create_and_listen to create listening IB CM IDs or share ^^^ Is that the wrong name? ib_cm_insert_listen perhaps? Yes, I missed that. Thanks. --

Re: [rhashtable] WARNING: CPU: 0 PID: 1 at lib/debugobjects.c:301 __debug_object_init()

2015-07-14 Thread Daniel Borkmann
On 07/14/2015 07:21 AM, Fengguang Wu wrote: Sorry please ignore -- this no longer happen in linux-next, so should be fine. Seen this before, this fixed it back then:

Re: [RFC net-next 18/22] openvswitch: Make tunnel set action attach a metadata dst

2015-07-14 Thread Thomas Graf
On 07/13/15 at 03:55pm, Joe Stringer wrote: It doesn't look like flow_free() is using this new function to properly free the actions. Also, some of the error cases that hit this code have sf_acts=NULL. Good catch. Will fix in next iteration. -- To unsubscribe from this list: send the line

4.1.0, kernel panic, pppoe_release

2015-07-14 Thread Denys Fedoryshchenko
Here is panic message from netconsole. Please let me know if any additional information required. Jul 14 13:49:16 10.0.252.10 [76078.867822] BUG: unable to handle kernel Jul 14 13:49:16 10.0.252.10 NULL pointer dereference Jul 14 13:49:16 10.0.252.10 at 03f0 Jul 14 13:49:16

[V2 0/7] introduce Hyper-V VM Sockets(hvsock)

2015-07-14 Thread Dexuan Cui
Changes since v1: - updated [V2 6/7] hvsock: introduce Hyper-V VM Sockets feature - added __init and __exit for the module init/exit functions - net/hv_sock/Kconfig: default m - default m if HYPERV - MODULE_LICENSE: Dual MIT/GPL - Dual BSD/GPL Hyper-V VM Sockets (hvsock)

[V2 1/7] Drivers: hv: vmbus: define the new offer type for Hyper-V socket (hvsock)

2015-07-14 Thread Dexuan Cui
A helper function is also added. Signed-off-by: Dexuan Cui de...@microsoft.com --- include/linux/hyperv.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h index 30d3a1f..aa21814 100644 --- a/include/linux/hyperv.h +++

Re: [PATCH v1 05/12] IB/cm: Share listening CM IDs

2015-07-14 Thread Haggai Eran
On 13/07/2015 20:48, Jason Gunthorpe wrote: On Mon, Jun 22, 2015 at 03:42:34PM +0300, Haggai Eran wrote: spin_lock_irq(cm.lock); +if (--cm_id_priv-listen_sharecount 0) { +/* The id is still shared. */ +

Re: mmap()ed AF_NETLINK: lockdep and sleep-in-atomic warnings

2015-07-14 Thread Florian Westphal
Thomas Graf tg...@suug.ch wrote: On 07/13/15 at 10:11pm, Cong Wang wrote: Caused by: commit 21e4902aea80ef35afc00ee8d2abdea4f519b7f7 Author: Thomas Graf tg...@suug.ch Date: Fri Jan 2 23:00:22 2015 +0100 netlink: Lockless lookup with RCU grace period in socket release

[PATCH net-tools] Fix stale references to axattach

2015-07-14 Thread Ralf Baechle
Rename all references to axattach to kissattach. Axattach has been renamed early to kissattach early in the history of the ax25-utils package which itself has been superseeded by libax25, ax25-tools and ax25-apps but stale references have remained. Signed-off-by: Ralf Baechle r...@linux-mips.org

RE: [PATCH] net: qlcnic: Deletion of unnecessary memset

2015-07-14 Thread Shahed Shaikh
-Original Message- From: Christophe JAILLET [mailto:christophe.jail...@wanadoo.fr] Sent: Tuesday, July 14, 2015 1:22 AM To: Shahed Shaikh; Dept-GE Linux NIC Dev Cc: netdev; linux-kernel; kernel-janit...@vger.kernel.org; Christophe JAILLET Subject: [PATCH] net: qlcnic: Deletion of

[PATCH v2] cfg80211-wext: deleting dead code

2015-07-14 Thread Rahul Jain
From e945737ef2e3a5b7198b9795d6375de85b2fac08 Mon Sep 17 00:00:00 2001 From: Rahul Jain rahul.j...@samsung.com Date: Tue, 14 Jul 2015 14:04:09 +0530 Subject: [PATCH] cfg80211-wext: deleting dead code In func cfg80211_wext_siwretry(), the value of changed is getting modified to non-zero value

[PATCH] brouted packet identified as PACKET_OTHERHOST blocked by higher protocol

2015-07-14 Thread Yigal Reiss (yreiss)
The problem I'm trying to solve is that when packets being sent from one bridged interface to the other are brouted they get dropped by the IP layer. The reason is that the packet being raised has pkt_type of type PACKET_OTHERHOST. The semantics of brouting a packet is that it is sent up to

Re: [PATCH] brouted packet identified as PACKET_OTHERHOST blocked by higher protocol

2015-07-14 Thread Florian Westphal
Yigal Reiss (yreiss) yre...@cisco.com wrote: The problem I'm trying to solve is that when packets being sent from one bridged interface to the other are brouted they get dropped by the IP layer. The reason is that the packet being raised has pkt_type of type PACKET_OTHERHOST. No, thats not

[V2 7/7] Drivers: hv: vmbus: disable local interrupt when hvsock's callback is running

2015-07-14 Thread Dexuan Cui
In the SMP guest case, when the per-channel callback hvsock_events() is running on virtual CPU A, if the guest tries to close the connection on virtual CPU B: we invoke vmbus_close() - vmbus_close_internal(), then we can have trouble: on B, vmbus_close_internal() will send IPI reset_channel_cb()

Re: [PATCH net-next 1/3] rhashtable: Add a function for in order insertion in buckets

2015-07-14 Thread Herbert Xu
Tom Herbert t...@herbertland.com wrote: The obj_orderfn function may be specified in the parameters for a rhashtable. When inserting an element this function is used to order objects in a bucket list (greatest to least ordering value).This allows entries to have wild card fields, where entries

[PATCH] net: stop endless flood about dst entry refcount underflow or overflow

2015-07-14 Thread Konstantin Khlebnikov
Kernel generates a lot of warnings when dst entry reference counter overflows and becomes negative. This patch prints address of dst entry, its refcount and then resets reference counter to INT_MAX/2. That bug was seen several times at machines with outdated 3.10.y kernels. Most like it's already

Re: [PATCH] brouted packet identified as PACKET_OTHERHOST blocked by higher protocol

2015-07-14 Thread Florian Westphal
Yigal Reiss (yreiss) yre...@cisco.com wrote: Florian Westphal [mailto:f...@strlen.de] wrote: Maybe, but if you broute everything you might as well just remove the bridge... I want to be selective. My setup is a home router. So I can have ebtables rules for which traffic to (b)route and

Re: [PATCH] iwlwifi: Deinline iwl_{read,write}{8,32}

2015-07-14 Thread Sergei Shtylyov
Hello. On 7/14/2015 3:22 PM, Denys Vlasenko wrote: With CONFIG_IWLWIFI_DEVICE_TRACING=y, these functions are rather large, too big for inlining. With this .config: http://busybox.net/~vda/kernel_config, after uninlining these functions have sizes and callsite counts as follows:

Re: [PATCH] iwlwifi: Deinline iwl_{read,write}{8,32}

2015-07-14 Thread Denys Vlasenko
On Tue, Jul 14, 2015 at 2:38 PM, Sergei Shtylyov sergei.shtyl...@cogentembedded.com wrote: +#define IWL_READ_WRITE(static_inline) \ +static_inline void iwl_write8(struct iwl_trans *trans, u32 ofs, u8 val) \ +{ \ + trace_iwlwifi_dev_iowrite8(trans-dev, ofs, val); \ +

RE: [PATCH] brouted packet identified as PACKET_OTHERHOST blocked by higher protocol

2015-07-14 Thread Yigal Reiss (yreiss)
Florian Westphal [mailto:f...@strlen.de] wrote: Maybe, but if you broute everything you might as well just remove the bridge... I want to be selective. My setup is a home router. So I can have ebtables rules for which traffic to (b)route and which to bridge, based on security/performance

Re: [PATCH] net: stop endless flood about dst entry refcount underflow or overflow

2015-07-14 Thread Eric Dumazet
On Tue, 2015-07-14 at 14:43 +0300, Konstantin Khlebnikov wrote: Kernel generates a lot of warnings when dst entry reference counter overflows and becomes negative. This patch prints address of dst entry, its refcount and then resets reference counter to INT_MAX/2. That bug was seen several

Re: [PATCH net-next] tc: fix tc actions in case of shared skb

2015-07-14 Thread Daniel Borkmann
On 07/14/2015 01:57 PM, Jamal Hadi Salim wrote: On 07/14/15 06:29, Daniel Borkmann wrote: On 07/14/2015 12:26 AM, Alexei Starovoitov wrote: On 7/13/15 1:55 PM, Daniel Borkmann wrote: On 07/13/2015 10:17 PM, Alexei Starovoitov wrote: ... We cannot check tc actions from pktgen, since they can

[PATCH] iwlwifi: Deinline iwl_{read,write}{8,32}

2015-07-14 Thread Denys Vlasenko
With CONFIG_IWLWIFI_DEVICE_TRACING=y, these functions are rather large, too big for inlining. With this .config: http://busybox.net/~vda/kernel_config, after uninlining these functions have sizes and callsite counts as follows: iwl_read32 475 bytes, 51 callsites iwl_write32 477 bytes, 90

[PATCH nf-next] netfilter: nf_ct_sctp: minimal multihoming support

2015-07-14 Thread Michal Kubecek
Currently nf_conntrack_proto_sctp module handles only packets between primary addresses used to establish the connection. Any packets between secondary addresses are classified as invalid so that usual firewall configurations drop them. Allowing HEARTBEAT and HEARTBEAT-ACK chunks to establish a

[PATCH V2 net-next 0/3] net: implement SMC-R solution

2015-07-14 Thread Ursula Braun
From: Ursula Braun ursula.br...@de.ibm.com Eric, this is V2 of my SMC-R patches, containing especially a new version of the required tcp changes. As you suggested, SMC-specific hooks in the TCP-code are built only for CONFIG_AFSMC. And I come up with helpers in include files to avoid spreading

[PATCH V2 net-next 1/3] tcp: introduce TCP experimental option for SMC

2015-07-14 Thread Ursula Braun
From: Ursula Braun ursula.br...@de.ibm.com The SMC-R protocol defines dynamic discovery of peers. This is done by implementing experimental TCP options as defined in RFC6994. The TCP code needs to be extended to support RFC6994. Setting the TCP experimental option for SMC-R [2] will be triggered

[PATCH V2 net-next 2/3] net: introduce socket family constants

2015-07-14 Thread Ursula Braun
From: Ursula Braun ursula.br...@de.ibm.com The new socket family is assigned the next available address / protocol family constant 41. Implementing SO_KEEPALIVE for SMC-R requires an extra hook in net/core/sock.c. Signed-off-by: Ursula Braun ursula.br...@de.ibm.com --- include/linux/socket.h |

Re: [PATCH 1/2] isdn/gigaset: reset tty-receive_room when attaching ser_gigaset

2015-07-14 Thread Sergei Shtylyov
Hello. On 7/14/2015 1:37 AM, Tilman Schmidt wrote: Commit 79901317ce80 (n_tty: Don't flush buffer when closing ldisc), first merged in kernel release 3.10, caused the following regression in the Gigaset M101 driver: Before that commit, when closing the N_TTY line discipline in preparation

Re: [PATCH] rfkill-gpio: Add support for the Realtek 8723 BT

2015-07-14 Thread Johannes Berg
On Tue, 2015-07-14 at 08:20 -0500, Larry Finger wrote: On 07/13/2015 05:11 PM, Bastien Nocera wrote: http://thread.gmane.org/gmane.linux.kernel.wireless.general/127706/ focu s=127896 Signed-off-by: Bastien Nocera had...@hadess.net Bastien, The subject of this patch needs a bit

RE: [PATCH] brouted packet identified as PACKET_OTHERHOST blocked by higher protocol

2015-07-14 Thread Yigal Reiss (yreiss)
Florian Westphal f...@strlen.de wrote: Yigal Reiss (yreiss) yre...@cisco.com wrote: The problem I'm trying to solve is that when packets being sent from one bridged interface to the other are brouted they get dropped by the IP layer. The reason is that the packet being raised has pkt_type of

Re: [PATCH] brouted packet identified as PACKET_OTHERHOST blocked by higher protocol

2015-07-14 Thread Florian Westphal
Yigal Reiss (yreiss) yre...@cisco.com wrote: No, thats not the problem you're trying to solve. If you want to move OTHERHOST skbs, don't (b)route them? Whats the real issue that you're trying to solve? I want to (b)route them because I want to be able to inspect the packets in

Re: [PATCH net-next] tc: fix tc actions in case of shared skb

2015-07-14 Thread Jamal Hadi Salim
On 07/14/15 06:29, Daniel Borkmann wrote: On 07/14/2015 12:26 AM, Alexei Starovoitov wrote: On 7/13/15 1:55 PM, Daniel Borkmann wrote: On 07/13/2015 10:17 PM, Alexei Starovoitov wrote: ... We cannot check tc actions from pktgen, since they can be added dynamically. So I see three options: 1

Re: [PATCH] ipv6: Fix finding best source address in ipv6_dev_get_saddr().

2015-07-14 Thread YOSHIFUJI Hideaki/吉藤英明
Hi, Tom Herbert wrote: I am testing this patch which may be a little simpler. Also idev needs to be checked after __in6_dev_get We have to select source address on *given* interface for link-local/ multicast destinations. Tom diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index

Re: [PATCH] net: stop endless flood about dst entry refcount underflow or overflow

2015-07-14 Thread Konstantin Khlebnikov
On 14.07.2015 15:04, Eric Dumazet wrote: On Tue, 2015-07-14 at 14:43 +0300, Konstantin Khlebnikov wrote: Kernel generates a lot of warnings when dst entry reference counter overflows and becomes negative. This patch prints address of dst entry, its refcount and then resets reference counter to

Re: [PATCH] net: stop endless flood about dst entry refcount underflow or overflow

2015-07-14 Thread Eric Dumazet
On Tue, 2015-07-14 at 15:15 +0300, Konstantin Khlebnikov wrote: Simple warn-once will hide a lot of information which could be useful. Also dst entry leak is better than freeing actually active entry. Then BUG_ON() . Really, we need to fix leaks, not brown paper them. -- To unsubscribe

Re: [PATCH] rfkill-gpio: Add support for the Realtek 8723 BT

2015-07-14 Thread Larry Finger
On 07/13/2015 05:11 PM, Bastien Nocera wrote: http://thread.gmane.org/gmane.linux.kernel.wireless.general/127706/focu s=127896 Signed-off-by: Bastien Nocera had...@hadess.net Bastien, The subject of this patch needs a bit more detail. I know that you mean the RTL8723B versions of the

Re: [PATCH v1 01/12] IB/core: pass client data to remove() callbacks

2015-07-14 Thread Haggai Eran
On 09/07/2015 00:34, Jason Gunthorpe wrote: On Wed, Jul 08, 2015 at 02:29:10PM -0600, Jason Gunthorpe wrote: On Mon, Jun 22, 2015 at 03:42:30PM +0300, Haggai Eran wrote: An ib_client callback that is called with the lists_rwsem locked only for read is protected from changes to the IB client

Re: [PATCH] rfkill-gpio: Add support for the Realtek 8723 BT

2015-07-14 Thread Marcel Holtmann
Hi Bastien, http://thread.gmane.org/gmane.linux.kernel.wireless.general/127706/focu s=127896 Signed-off-by: Bastien Nocera had...@hadess.net --- net/rfkill/rfkill-gpio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c index

Re: [PATCH v2] add stealth mode

2015-07-14 Thread Matteo Croce
2015-07-13 15:03 GMT+02:00 Austin S Hemmelgarn ahferro...@gmail.com: How about FIN/ACK and FIN/PSH/URG? Silent: root@debian64:~# hping3 192.168.0.2 -p 32 -FA HPING 192.168.0.2 (eth0 192.168.0.2): AF set, 40 headers + 0 data bytes ^C --- 192.168.0.2 hping statistic --- 3 packets transmitted, 0

Re: [PATCH] ipv6: Fix finding best source address in ipv6_dev_get_saddr().

2015-07-14 Thread Tom Herbert
On Tue, Jul 14, 2015 at 5:44 AM, YOSHIFUJI Hideaki/吉藤英明 hideaki.yoshif...@miraclelinux.com wrote: Hi, Tom Herbert wrote: I am testing this patch which may be a little simpler. Also idev needs to be checked after __in6_dev_get We have to select source address on *given* interface for

[PATCH net-next v6 1/4] net core: Add protodown support.

2015-07-14 Thread anuradhak
From: Anuradha Karuppiah anurad...@cumulusnetworks.com This patch introduces the proto_down flag that can be used by user space applications to notify switch drivers that errors have been detected on the device. The switch driver can react to protodown notification by doing a phys down on the

[PATCH net-next v6 0/4] net: Introduce protodown flag.

2015-07-14 Thread anuradhak
From: Anuradha Karuppiah anurad...@cumulusnetworks.com User space daemons can detect errors in the network that need to be notified to the switch device drivers. Drivers can react to this error state by doing a phy-down on the switch-port which would result in a carrier-off locally and on the

[PATCH net-next v6 2/4] netlink: changes for setting and clearing protodown via netlink.

2015-07-14 Thread anuradhak
From: Anuradha Karuppiah anurad...@cumulusnetworks.com Signed-off-by: Anuradha Karuppiah anurad...@cumulusnetworks.com Signed-off-by: Andy Gospodarek go...@cumulusnetworks.com Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com Signed-off-by: Wilson Kok w...@cumulusnetworks.com ---

[PATCH iproute2 v6 4/4] ip link: proto_down config and display.

2015-07-14 Thread anuradhak
From: Anuradha Karuppiah anurad...@cumulusnetworks.com This patch adds support to set and display protodown on a switch port. The switch driver can handle this error state by doing a phys down on the port. One example user space application setting this flag is a multi-chassis LAG application to

[PATCH net-next v6 3/4] rocker: Handle protodown notifications.

2015-07-14 Thread anuradhak
From: Anuradha Karuppiah anurad...@cumulusnetworks.com protodown can be set by user space applications like MLAG on detecting errors on a switch port. This patch provides sample switch driver changes for handling protodown. Rocker PHYS disables the port in response to protodown. Signed-off-by:

[PATCH net-next] ibmveth: add support for TSO6

2015-07-14 Thread Thomas Falcon
This patch adds support for a new method of signalling the firmware that TSO packets are being sent. The new method removes the need to alter the ip and tcp checksums and allows TSO6 support. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- drivers/net/ethernet/ibm/ibmveth.c | 145

Re: [PATCH nf-next] netfilter: nf_ct_sctp: minimal multihoming support

2015-07-14 Thread Pablo Neira Ayuso
On Tue, Jul 14, 2015 at 02:23:11PM +0200, Michal Kubecek wrote: @@ -658,6 +696,18 @@ static struct ctl_table sctp_sysctl_table[] = { .mode = 0644, .proc_handler = proc_dointvec_jiffies, }, + { + .procname =

Re: [PATCH net-next 2/3] rhashtable: allow lookup function to have compare function agument

2015-07-14 Thread Tom Herbert
On Tue, Jul 14, 2015 at 2:44 AM, Thomas Graf tg...@suug.ch wrote: On 07/13/15 at 05:39pm, Tom Herbert wrote: Added rhashtable_lookup_fast_cmpfn which does a lookup in an rhash table with the compare function being taken from an argument. This allows different compare functions to be used on

Re: [PATCH net-next] tc: fix tc actions in case of shared skb

2015-07-14 Thread Alexei Starovoitov
On 7/14/15 3:29 AM, Daniel Borkmann wrote: One other thing that comes to mind, not sure if it's worth it though, would be to split the skb-tc_verd's TC_NCLS itself into TC_NCLS/TC_NACT, so that you can go into the classifier, but skip the action part. Since in tcf_action_exec(), we already test

[PATCH v3 5/5] ipvlan: ignore addresses from ipv6 autoconfiguration

2015-07-14 Thread Konstantin Khlebnikov
Inet6addr notifier is atomic and runs in bh context without RTNL when ipv6 receives router advertisement packet and performs autoconfiguration. Proper fix still in discussion. Let's at least plug the bug. v1: http://lkml.kernel.org/r/20150514135618.14062.1969.stgit@buzz v2:

[PATCH v3 4/5] ipvlan: use rcu_deference_bh() in ipvlan_queue_xmit()

2015-07-14 Thread Konstantin Khlebnikov
From: WANG Cong xiyou.wangc...@gmail.com In tx path rcu_read_lock_bh() is held, so we need rcu_deference_bh(). This fixes the following warning: === [ INFO: suspicious RCU usage. ] 4.1.0-rc1+ #1007 Not tainted ---

[PATCH v3 0/5] ipvlan: cleanups and fixes

2015-07-14 Thread Konstantin Khlebnikov
v1: http://comments.gmane.org/gmane.linux.network/363346 v2: http://comments.gmane.org/gmane.linux.network/369086 v3 has reduced set of patches from ipvlan: fix ipv6 autoconfiguration. Here just cleanups and patch which ignores ipv6 notifications from RA. --- Konstantin Khlebnikov (4):

[PATCH v3 2/5] ipvlan: plug memory leak in ipvlan_link_delete

2015-07-14 Thread Konstantin Khlebnikov
Add missing kfree_rcu(addr, rcu); Signed-off-by: Konstantin Khlebnikov khlebni...@yandex-team.ru --- drivers/net/ipvlan/ipvlan_main.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c index 048ecf0c76fb..7d81e37c3f76 100644

[PATCH v3 1/5] ipvlan: remove counters of ipv4 and ipv6 addresses

2015-07-14 Thread Konstantin Khlebnikov
They are unused after commit f631c44bbe15 (ipvlan: Always set broadcast bit in multicast filter). Signed-off-by: Konstantin Khlebnikov khlebni...@yandex-team.ru --- drivers/net/ipvlan/ipvlan.h |2 -- drivers/net/ipvlan/ipvlan_main.c | 33 - 2 files

[PATCH v3 3/5] ipvlan: unhash addresses without synchronize_rcu

2015-07-14 Thread Konstantin Khlebnikov
All structures used in traffic forwarding are rcu-protected: ipvl_addr, ipvl_dev and ipvl_port. Thus we can unhash addresses without synchronization. We'll anyway hash it back into the same bucket: in worst case lockless lookup will scan hash once again. Signed-off-by: Konstantin Khlebnikov

Re: [PATCH net] rtnetlink: reject non-IFLA_VF_PORT attributes inside IFLA_VF_PORTS

2015-07-14 Thread roopa
On 7/12/15, 3:06 PM, Daniel Borkmann wrote: Similarly as in commit 4f7d2cdfdde7 (rtnetlink: verify IFLA_VF_INFO attributes before passing them to driver), we have a double nesting of netlink attributes, i.e. IFLA_VF_PORTS only contains IFLA_VF_PORT that is nested itself. While IFLA_VF_PORTS is a

Re: Fighting out-of-order reception with RPS?

2015-07-14 Thread Oliver Hartkopp
On 13.07.2015 06:57, Eric Dumazet wrote: On Sun, 2015-07-12 at 21:15 +0200, Oliver Hartkopp wrote: E.g. with skb_set_hash(skb, dev-ifindex, PKT_HASH_TYPE_L2); and echo f /sys/class/net/can0/queues/rx-0/rps_cpus I get properly ordered CAN frames - even with netif_rx()

[PATCH v3 0/3] net: enable inband link state negotiation only when explicitly requested

2015-07-14 Thread Stas Sergeev
Hello. Currently the link status auto-negotiation is enabled for any SGMII link with fixed-link DT binding. The regression was reported: https://lkml.org/lkml/2015/7/8/865 Apparently not all HW that implements SGMII protocol, generates the inband status for the auto-negotiation to work. More

[PATCH v2 1/2] sctp: add new getsockopt option SCTP_SOCKOPT_PEELOFF_KERNEL

2015-07-14 Thread Marcelo Ricardo Leitner
SCTP has this operation to peel off associations from a given socket and create a new socket using this association. We currently have two ways to use this operation: - via getsockopt(), on which it will also create and return a file descriptor for this new socket - via sctp_do_peeloff(), which

[PATCH v2 2/2] dlm: avoid using sctp_do_peeloff directly

2015-07-14 Thread Marcelo Ricardo Leitner
This patch reverts 2f2d76cc3e93 (dlm: Do not allocate a fd for peeloff) but also makes use of a new sockopt: SCTP_SOCKOPT_PEELOFF_KERNEL, which avoids allocating file descriptors while doing this operation. By this we avoid creating a direct dependency from dlm to sctp module, which can then be

Re: [PATCH net-next v6 3/4] rocker: Handle protodown notifications.

2015-07-14 Thread Sergei Shtylyov
Hello. On 07/14/2015 06:32 PM, anurad...@cumulusnetworks.com wrote: From: Anuradha Karuppiah anurad...@cumulusnetworks.com protodown can be set by user space applications like MLAG on detecting errors on a switch port. This patch provides sample switch driver changes for handling protodown.

Re: [PATCH net-next 1/3] rhashtable: Add a function for in order insertion in buckets

2015-07-14 Thread Tom Herbert
On Tue, Jul 14, 2015 at 2:57 AM, Herbert Xu herb...@gondor.apana.org.au wrote: Tom Herbert t...@herbertland.com wrote: The obj_orderfn function may be specified in the parameters for a rhashtable. When inserting an element this function is used to order objects in a bucket list (greatest to

[PATCH 1/3] fixed_phy: handle link-down case

2015-07-14 Thread Stas Sergeev
Currently fixed_phy driver recognizes only the link-up state. This simple patch adds an implementation of link-down state. It fixes the status registers when link is down, and also allows to register the fixed-phy with link down without specifying the speed. Signed-off-by: Stas Sergeev

[PATCH 3/3] mvneta: use inband status only when explicitly enabled

2015-07-14 Thread Stas Sergeev
The commit 898b2970e2c9 (mvneta: implement SGMII-based in-band link state signaling) implemented the link parameters auto-negotiation unconditionally. Unfortunately it appears that some HW that implements SGMII protocol, doesn't generate the inband status, so it is not possible to auto-negotiate

Re: [PATCH nf-next] netfilter: nf_ct_sctp: minimal multihoming support

2015-07-14 Thread Michal Kubecek
On Tue, Jul 14, 2015 at 05:38:47PM +0200, Pablo Neira Ayuso wrote: On Tue, Jul 14, 2015 at 02:23:11PM +0200, Michal Kubecek wrote: @@ -658,6 +696,18 @@ static struct ctl_table sctp_sysctl_table[] = { .mode = 0644, .proc_handler = proc_dointvec_jiffies,

Re: [PATCH nf-next] netfilter: nf_ct_sctp: minimal multihoming support

2015-07-14 Thread Michal Kubecek
On Tue, Jul 14, 2015 at 03:42:03PM +0200, Florian Westphal wrote: Michal Kubecek mkube...@suse.cz wrote: + case SCTP_CID_HEARTBEAT: + pr_debug(SCTP_CID_HEARTBEAT); + i = 9; + break; + case SCTP_CID_HEARTBEAT_ACK: +

[PATCH 2/3] of_mdio: add new DT property 'managed' to specify the PHY management type

2015-07-14 Thread Stas Sergeev
Currently the PHY management type is selected by the MAC driver arbitrary. The decision is based on the presence of the fixed-link node and on a will of the driver's authors. This caused a regression recently, when mvneta driver suddenly started to use the in-band status for auto-negotiation on

[PATCH v2 0/2] Avoid link dependency of dlm on sctp module

2015-07-14 Thread Marcelo Ricardo Leitner
Hi, I'm trying to remove a direct dependency of dlm module on sctp one. Currently dlm code is calling sctp_do_peeloff() directly and this call only is causing the load of sctp module together with dlm. For that, we have basically 3 options: - Doing a module split on dlm - which I'm avoiding

[Patch net] fq_codel: fix return value of fq_codel_drop()

2015-07-14 Thread Cong Wang
The -drop() is supposed to return the number of bytes it dropped, however fq_codel_drop() returns the index of the flow where it drops a packet from. Fix this by introducing a helper to wrap fq_codel_drop(). Cc: Eric Dumazet eduma...@google.com Signed-off-by: Cong Wang xiyou.wangc...@gmail.com

[Patch net] net_sched: fix a use-after-free in sfq

2015-07-14 Thread Cong Wang
Fixes: 25331d6ce42b (net: sched: implement qstat helper routines) Cc: John Fastabend john.fastab...@gmail.com Signed-off-by: Cong Wang xiyou.wangc...@gmail.com Signed-off-by: Cong Wang cw...@twopensource.com --- net/sched/sch_sfq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 1/3] fixed_phy: handle link-down case

2015-07-14 Thread Florian Fainelli
On 14/07/15 10:11, Stas Sergeev wrote: Currently fixed_phy driver recognizes only the link-up state. This simple patch adds an implementation of link-down state. It fixes the status registers when link is down, and also allows to register the fixed-phy with link down without specifying the

[PATCH] ravb: do not invalidate cache for RX buffer twice

2015-07-14 Thread Sergei Shtylyov
First, dma_sync_single_for_cpu() shouldn't have been called in the first place (it's a streaming DMA API). dma_unmap_single() should have been called instead. Second, dma_unmap_single() call after handing the buffer to napi_gro_receive() makes little sense. Signed-off-by: Sergei Shtylyov

Re: [PATCH v2] rhashtable: fix for resize events during table walk

2015-07-14 Thread Thomas Graf
On 07/15/15 at 12:35am, mr...@linux.ee wrote: Yes, this fixes the error, thank you. The new problem with the test - soft lockup - CPU#0 stuck for 22s! is still there on 360 MHz UltraSparc IIi. I understand it is harmless but is there some easy way to make the test avoid NMI watchdog? [

[PATCH net-next]r8169: Serialise some operations from open close

2015-07-14 Thread Corcodel Marian
This is a multi-part message in MIME format. --mine-boundary-string Content-Type: text/plain; charset=UTF-8; format=fixed Content-Transfer-Encoding: 8bit Serialize some operations from open close function especial when write read from main structure(struct rtl8169_private).Ensure

Re: [PATCH 2/3] of_mdio: add new DT property 'managed' to specify the PHY management type

2015-07-14 Thread Stas Sergeev
14.07.2015 20:51, Florian Fainelli пишет: On 14/07/15 10:13, Stas Sergeev wrote: Currently the PHY management type is selected by the MAC driver arbitrary. The decision is based on the presence of the fixed-link node and on a will of the driver's authors. This caused a regression recently, when

Re: [PATCH net-next v6 3/4] rocker: Handle protodown notifications.

2015-07-14 Thread Anuradha Karuppiah
On Tue, Jul 14, 2015 at 9:42 AM, Sergei Shtylyov sergei.shtyl...@cogentembedded.com wrote: Hello. On 07/14/2015 06:32 PM, anurad...@cumulusnetworks.com wrote: From: Anuradha Karuppiah anurad...@cumulusnetworks.com protodown can be set by user space applications like MLAG on detecting

Re: [PATCH v2] README: clarify redistribution requirements covering patents

2015-07-14 Thread Kyle McMartin
On Thu, Jun 11, 2015 at 06:02:56PM -0700, Luis R. Rodriguez wrote: On Thu, May 28, 2015 at 5:48 PM, Luis R. Rodriguez mcg...@suse.com wrote: On Tue, May 19, 2015 at 1:22 PM, Luis R. Rodriguez mcg...@do-not-panic.com wrote: This v2 just changes licence to license as requested by Arend.

[PATCH net] net: bcmgenet: Remove excessive PHY reset

2015-07-14 Thread Florian Fainelli
We are currently issuing multiple PHY resets during a suspend/resume, first during bcmgenet_power_up() which does a hardware reset, then a software reset by calling bcmgenet_mii_reset(). This is both unnecessary and can take as long as 10ms per MDIO transactions while we re-apply workarounds

[PATCH net-next v7 3/4] rocker: Handle protodown notifications.

2015-07-14 Thread anuradhak
From: Anuradha Karuppiah anurad...@cumulusnetworks.com protodown can be set by user space applications like MLAG on detecting errors on a switch port. This patch provides sample switch driver changes for handling protodown. Rocker PHYS disables the port in response to protodown. Signed-off-by:

[PATCH net-next v7 1/4] net core: Add protodown support.

2015-07-14 Thread anuradhak
From: Anuradha Karuppiah anurad...@cumulusnetworks.com This patch introduces the proto_down flag that can be used by user space applications to notify switch drivers that errors have been detected on the device. The switch driver can react to protodown notification by doing a phys down on the

Re: [PATCH] bnx2x: Update to FW version 7.12.30

2015-07-14 Thread Kyle McMartin
On Mon, Jul 13, 2015 at 10:17:24AM +, Yuval Mintz wrote: The new FW will allow us to utilize some new features in our driver, mainly adding vlan filtering offload and vxlan offload support. In addition, this fixes several issues: 1. Packets from a VF with pvid configured

Re: [PATCH v2] rhashtable: fix for resize events during table walk

2015-07-14 Thread mroos
If rhashtable_walk_next detects a resize operation in progress, it jumps to the new table and continues walking that one. But it misses to drop the reference to it's current item, leading it to continue traversing the new table's bucket in which the current item is sorted into, and after

[PATCH net] tc: act_bpf: fix memory leak

2015-07-14 Thread Alexei Starovoitov
prog-bpf_ops is populated when act_bpf is used with classic BPF and prog-bpf_name is optionally used with extended BPF. Fix memory leak when act_bpf is released. Fixes: d23b8ad8ab23 (tc: add BPF based action) Fixes: a8cb5f556b56 (act_bpf: add initial eBPF support for actions) Acked-by: Daniel

Re: [PATCH net-next]r8169: Serialise some operations from open close

2015-07-14 Thread David Miller
Please do not post patches as attachments. Instead, inline them as unmolested ASCII text in the main message body along with your commit message. From Documentation/email-clients.txt: General Preferences

  1   2   >