[PATCH] openvswitch: make for_each_node loops work with sparse numa systems

2015-07-21 Thread Chris J Arges
Some architectures like POWER can have a NUMA node_possible_map that contains sparse entries. This causes memory corruption with openvswitch since it allocates flow_cache with a multiple of num_possible_nodes() and assumes the node variable returned by for_each_node will index into

Re: [PATCH 1/1] ath10k: fixing wrong initialization of struct channel

2015-07-21 Thread Kalle Valo
Maninder Singh maninder...@samsung.com writes: chandef is initialized with NULL and on the very next line, we are using it to get channel, which is not correct. channel should be initialized after obtaining chandef. Signed-off-by: Maninder Singh maninder...@samsung.com How did you find

[PATCH v2 1/2] net: fec: use managed DMA API functions to allocate BD ring

2015-07-21 Thread Lucas Stach
So it gets freed when the device is going away. This fixes a DMA memory leak on driver probe() fail and driver remove(). Signed-off-by: Lucas Stach l.st...@pengutronix.de --- v2: Fix indentation of second line to fix alignment with opening bracket. --- drivers/net/ethernet/freescale/fec_main.c |

[PATCH v2 2/2] net: fec: introduce fec_ptp_stop and use in probe fail path

2015-07-21 Thread Lucas Stach
This function frees resources and cancels delayed work item that have been initialized in fec_ptp_init(). Use this to do proper error handling if something goes wrong in probe function after fec_ptp_init has been called. Signed-off-by: Lucas Stach l.st...@pengutronix.de ---

Re: [PATCH] openvswitch: make for_each_node loops work with sparse numa systems

2015-07-21 Thread Chris J Arges
On Tue, Jul 21, 2015 at 09:24:18AM -0700, Nishanth Aravamudan wrote: On 21.07.2015 [10:32:34 -0500], Chris J Arges wrote: Some architectures like POWER can have a NUMA node_possible_map that contains sparse entries. This causes memory corruption with openvswitch since it allocates

Re: [PATCH] netcp:Fix error handling in the function netcp_xgbe_serdes_config

2015-07-21 Thread Murali Karicheri
On 07/20/2015 11:54 AM, Nicholas Krause wrote: This fixes error handling in the function netcp_xgbe_serdes_config by putting the return value of netcp_xgbe_serdes_check_lane into the variable ret and return this value to the caller as this function can fail when called by returning the error

Re: [2/2] iwlegacy: convert hex_dump_to_buffer() to %*ph

2015-07-21 Thread Kalle Valo
There is no need to use hex_dump_to_buffer() in the cases like this: hexdump_to_buffer(buf, len, 16, 1, outbuf, outlen, false); /* len = 16 */ sprintf(%s\n, outbuf); since it maybe easily converted to simple: sprintf(%*ph\n, len, buf); Note: it seems in the

[PATCH] packet: Allow packets with only a header (but no payload)

2015-07-21 Thread Martin Blumenstingl
9c70776 added validation for the packet size in packet_snd. This change enforced that every packet needs a long enough header and at least one byte payload. However, when trying to establish a PPPoE connection the following message is printed every time a PPPoE discovery packet is sent: pppd:

Re: [PATCH] packet: Allow packets with only a header (but no payload)

2015-07-21 Thread Willem de Bruijn
On Tue, Jul 21, 2015 at 12:14 PM, Martin Blumenstingl martin.blumensti...@googlemail.com wrote: 9c70776 added validation for the packet size in packet_snd. This change enforced that every packet needs a long enough header and at least one byte payload. However, when trying to establish a

Re: rtlwifi: rtl8821ae: Fix an expression that is always false

2015-07-21 Thread Kalle Valo
In routine _rtl8821ae_set_media_status(), an incorrect mask results in a test for AP status to always be false. Similar bugs were fixed in rtl8192cu and rtl8192de, but this instance was missed at that time. Reported-by: David Binderman dcb...@hotmail.com Signed-off-by: Larry Finger

Re: [PATCH V2 net-next 0/3] ARM BPF JIT features

2015-07-21 Thread Alexei Starovoitov
On 7/21/15 5:16 AM, Nicolas Schichan wrote: This serie adds support for more instructions to the ARM BPF JIT namely skb netdevice type retrieval, skb payload offset retrieval, and skb packet type retrieval. This allows 35 tests to use the JIT instead of 29 before. This serie depends on the BPF

Re: [PATCH] packet: Allow packets with only a header (but no payload)

2015-07-21 Thread Martin Blumenstingl
Hi Willem, On Tue, Jul 21, 2015 at 6:28 PM, Willem de Bruijn will...@google.com wrote: Interesting. 9c7077622dd9 only extended the check from tpacket_snd to packet_snd to make the two paths equivalent. The existing check had the ominous statement /* net device doesn't like empty head */

Re: [PATCH] openvswitch: make for_each_node loops work with sparse numa systems

2015-07-21 Thread Nishanth Aravamudan
On 21.07.2015 [10:32:34 -0500], Chris J Arges wrote: Some architectures like POWER can have a NUMA node_possible_map that contains sparse entries. This causes memory corruption with openvswitch since it allocates flow_cache with a multiple of num_possible_nodes() and Couldn't this also be

[net-next:master 187/208] net/mpls/mpls_iptunnel.c:73:19: sparse: incompatible types in comparison expression (different address spaces)

2015-07-21 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 16040894b26af9f85d9395f072c53d76a44eba21 commit: e3e4712ec0961ed586a8db340bd994c4ad7f5dba [187/208] mpls: ip tunnel support reproduce: # apt-get install sparse git checkout

Re: [PATCH net-next] ipv6: Avoid rt6_probe() taking writer lock in the fast path

2015-07-21 Thread YOSHIFUJI Hideaki
Hi, Martin KaFai Lau wrote: The patch checks neigh-nud_state before acquiring the writer lock. Note that rt6_probe() is only used in CONFIG_IPV6_ROUTER_PREF. You have to take some lock when accessing neigh-nud_state theoretically. I also take this chance to re-arrange the code. No, please

Re: [RFC PATCH net-next] ebpf: Allow dereferences of PTR_TO_STACK registers

2015-07-21 Thread Alexei Starovoitov
On Tue, Jul 21, 2015 at 07:00:40PM -0700, Alex Gartrell wrote: mov %rsp, %r1 ; r1 = rsp add $-8, %r1; r1 = rsp - 8 store_q $123, -8(%rsp) ; *(u64*)r1 = 123 - valid store_q $123, (%r1) ; *(u64*)r1 = 123 - previously invalid

[PATCH] mac80211_hwsim: unregister genetlink family properly

2015-07-21 Thread Su Kang Yin
During hwsim_init_netlink(), we should call genl_unregister_family() if failed on netlink_register_notifier() since the genetlink is already registered. Signed-off-by: Su Kang Yin cant...@cantona.net --- drivers/net/wireless/mac80211_hwsim.c | 4 +++- 1 file changed, 3 insertions(+), 1

[PATCH nf] netfilter: Support expectations in different zones

2015-07-21 Thread Joe Stringer
When zones were originally introduced, the expectation functions were all extended to perform lookup using the zone. However, insertion was not modified to check the zone. This means that two expectations which are intended to apply for different connections that have the same tuple but exist in

[net-next:master 200/208] drivers/net/vxlan.c:1739:21: sparse: incorrect type in assignment (different base types)

2015-07-21 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 16040894b26af9f85d9395f072c53d76a44eba21 commit: 614732eaa12dd462c0ab274700bed14f36afea5e [200/208] openvswitch: Use regular VXLAN net_device device reproduce: # apt-get install sparse git checkout

Re: [PATCH] cgroup: net_cls: fix false-positive suspicious RCU usage

2015-07-21 Thread David Miller
From: Konstantin Khlebnikov khlebni...@yandex-team.ru Date: Tue, 21 Jul 2015 19:46:29 +0300 @@ -23,7 +23,8 @@ static inline struct cgroup_cls_state *css_cls_state(struct cgroup_subsys_state struct cgroup_cls_state *task_cls_state(struct task_struct *p) { - return

Re: [PATCH] net: phy: dp83867: Fix warning check for setting the internal delay

2015-07-21 Thread David Miller
From: Dan Murphy dmur...@ti.com Date: Tue, 21 Jul 2015 12:06:45 -0500 Fix warning: logical ‘or’ of collectively exhaustive tests is always true Change the internal delay check from an 'or' condition to an 'and' condition. Reported-by: David Binderman dcb...@hotmail.com Signed-off-by: Dan

Re: [PATCH net v2] macvtap: fix network header pointer for VLAN tagged pkts

2015-07-21 Thread Toshiaki Makita
On 15/07/21 (火) 16:18, Ivan Vecera wrote: Network header is set with offset ETH_HLEN but it is not true for VLAN (multiple-)tagged and results in checksum issues in lower devices. v2: leave skb-protocol untouched (thx Vlad), comment added Signed-off-by: Ivan Vecera ivec...@redhat.com ---

Re: [v2] brcmsmac: Use kstrdup to simplify code

2015-07-21 Thread Kalle Valo
Replace a kmalloc+strcpy by an equivalent kstrdup in order to improve readability. Signed-off-by: Christophe JAILLET christophe.jail...@wanadoo.fr Acked-by: Arend van Spriel ar...@broadcom.com Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send

[PATCH net-next] mpls: make RTA_OIF optional

2015-07-21 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com If user did not specify an oif, try and get it from the via address. If failed to get device, return with -ENODEV. Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- net/mpls/af_mpls.c | 67

Re: [PATCH] packet: Allow packets with only a header (but no payload)

2015-07-21 Thread Willem de Bruijn
On Tue, Jul 21, 2015 at 12:38 PM, Martin Blumenstingl martin.blumensti...@googlemail.com wrote: Hi Willem, On Tue, Jul 21, 2015 at 6:28 PM, Willem de Bruijn will...@google.com wrote: Interesting. 9c7077622dd9 only extended the check from tpacket_snd to packet_snd to make the two paths

[PATCH] net: phy: dp83867: Fix warning check for setting the internal delay

2015-07-21 Thread Dan Murphy
Fix warning: logical ‘or’ of collectively exhaustive tests is always true Change the internal delay check from an 'or' condition to an 'and' condition. Reported-by: David Binderman dcb...@hotmail.com Signed-off-by: Dan Murphy dmur...@ti.com --- drivers/net/phy/dp83867.c | 2 +- 1 file changed,

Re: [PATCH] net: phy: dp83867: Fix warning check for setting the internal delay

2015-07-21 Thread Florian Fainelli
On 21/07/15 10:06, Dan Murphy wrote: Fix warning: logical ‘or’ of collectively exhaustive tests is always true Change the internal delay check from an 'or' condition to an 'and' condition. Reported-by: David Binderman dcb...@hotmail.com Signed-off-by: Dan Murphy dmur...@ti.com Acked-by:

Re: [PATCH,v2 net] net: sched: validate that class is found in qdisc_tree_decrease_qlen

2015-07-21 Thread Cong Wang
On Tue, Jul 21, 2015 at 3:52 AM, Eric Dumazet eric.duma...@gmail.com wrote: On Tue, 2015-07-21 at 06:04 -0400, Jamal Hadi Salim wrote: It is worrisome to fix the core code for this. The root cause seems to be codel. Dont have time but in general, reset would be something like: struct

Re: [PATCH v2 net] inet: frags: fix defragmented packet's IP header for af_packet

2015-07-21 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Tue, 21 Jul 2015 09:43:59 +0200 From: Edward Hyunkoo Jee ed...@google.com When ip_frag_queue() computes positions, it assumes that the passed sk_buff does not contain L2 headers. However, when PACKET_FANOUT_FLAG_DEFRAG is used, IP reassembly

Re: [PATCH net-next 14/22] vxlan: Flow based tunneling

2015-07-21 Thread Thomas Graf
On 07/21/15 at 10:30am, Alexei Starovoitov wrote: RX: +info-mode = IP_TUNNEL_INFO_RX; +info-key.tun_flags = TUNNEL_KEY; +info-key.tun_id = cpu_to_be64(vni 8); ... TX: +dst_port = info-key.tp_dst ? : vxlan-dst_port; +vni =

[PATCH] cgroup: net_cls: fix false-positive suspicious RCU usage

2015-07-21 Thread Konstantin Khlebnikov
In dev_queue_xmit() net_cls protected with rcu-bh. [ 270.730026] === [ 270.730029] [ INFO: suspicious RCU usage. ] [ 270.730033] 4.2.0-rc3+ #2 Not tainted [ 270.730036] --- [ 270.730040] include/linux/cgroup.h:353 suspicious

Identifying underlying interface from struct sock

2015-07-21 Thread Guru Prasad
Hi, First, I apologize for posting on the netdev forum. Majordomo did not list any other network related mailing list. Is there a way to identify the underlying network interface from an instance of struct sock? I realize that the socket is abstract and shouldn't/doesn't necessarily depend on

Re: [PATCH net-next 14/22] vxlan: Flow based tunneling

2015-07-21 Thread Alexei Starovoitov
On 7/21/15 1:43 AM, Thomas Graf wrote: This prepares the VXLAN device to be steered by the routing and other subsystems which allows to support encapsulation for a large number of tunnel endpoints and tunnel ids through a single net_device which improves the scalability. +1. looks very useful.

[PATCH v2] openvswitch: allocate nr_node_ids flow_stats instead of num_possible_nodes

2015-07-21 Thread Chris J Arges
Some architectures like POWER can have a NUMA node_possible_map that contains sparse entries. This causes memory corruption with openvswitch since it allocates flow_cache with a multiple of num_possible_nodes() and assumes the node variable returned by for_each_node will index into

Re: [PATCH 1/1] drivers: net: cpsw: remove tx event processing in rx napi poll

2015-07-21 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Tue, 21 Jul 2015 16:00:42 +0530 With commit c03abd84634d (net: ethernet: cpsw: don't requests IRQs we don't use) common isr and napi are separated into separate tx isr and rx isr/napi, but still in rx napi tx events are handled. So removing the tx

Re: [PATCH net-next 1/2] tcp: don't extend RTO on failed loss probe attempts

2015-07-21 Thread Yuchung Cheng
On Fri, Jul 17, 2015 at 10:27 PM, Eric Dumazet eric.duma...@gmail.com wrote: On Fri, 2015-07-17 at 14:22 -0700, Yuchung Cheng wrote: If TLP was unable to send a probe, it extended the RTO to now + icsk_rto. But extending the RTO makes little sense if no TLP probe went out. With this

Re: [PATCH net-next 00/22 v2] Lightweight flow based encapsulation

2015-07-21 Thread David Miller
From: Thomas Graf tg...@suug.ch Date: Tue, 21 Jul 2015 10:43:44 +0200 This series combines the work previously posted by Roopa, Robert and myself. It's according to what we discussed at NFWS. The motivation of this series is to: * Consolidate code between OVS and the rest of the kernel and

Re: [PATCH iproute2 v2] ss: Fix crash when dump stats from /proc with '-p'

2015-07-21 Thread Stephen Hemminger
On Tue, 21 Jul 2015 16:18:36 +0300 Vadim Kochan vadi...@gmail.com wrote: From: Vadim Kochan vadi...@gmail.com It really partially reverts: ec4d0d8a9def35 (ss: Replace unixstat struct by new sockstat struct) but adds few fields (name peer_name) from removed unixstat to sockstat

[PATCH net] tcp: suppress a division by zero warning

2015-07-21 Thread Eric Dumazet
From: Eric Dumazet eduma...@google.com Andrew Morton reported following warning on one ARM build with gcc-4.4 : net/ipv4/inet_hashtables.c: In function 'inet_ehash_locks_alloc': net/ipv4/inet_hashtables.c:617: warning: division by zero Even guarded with a test on sizeof(spinlock_t), compiler

Re: [PATCH net] tcp: suppress a division by zero warning

2015-07-21 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Wed, 22 Jul 2015 07:02:00 +0200 From: Eric Dumazet eduma...@google.com Andrew Morton reported following warning on one ARM build with gcc-4.4 : net/ipv4/inet_hashtables.c: In function 'inet_ehash_locks_alloc':

Re: [PATCHv2 net-next] cxgb4: Add debugfs entry to enable backdoor access

2015-07-21 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Tue, 21 Jul 2015 22:39:40 +0530 Add debugfs entry 'use_backdoor' to enable backdoor access to read sge context. By default, we read sge context's via firmware. In case of FW issues, one can enable backdoor access via debugfs to dump sge

RE: [PATCH v2 2/2] net: fec: introduce fec_ptp_stop and use in probe fail path

2015-07-21 Thread Duan Andy
From: Lucas Stach l.st...@pengutronix.de Sent: Tuesday, July 21, 2015 11:11 PM To: David S. Miller Cc: Duan Fugang-B38611; Li Frank-B20596; netdev@vger.kernel.org; ker...@pengutronix.de; patchwork-...@pengutronix.de Subject: [PATCH v2 2/2] net: fec: introduce fec_ptp_stop and use in probe

Re: [PATCH] e1000e: Move e1000e_disable_aspm_locked() inside CONFIG_PM

2015-07-21 Thread Michael Ellerman
On Wed, 2015-07-15 at 03:30 -0700, Jeff Kirsher wrote: On Tue, 2015-07-14 at 13:54 +1000, Michael Ellerman wrote: e1000e_disable_aspm_locked() is only used in __e1000_resume() which is inside CONFIG_PM. So when CONFIG_PM=n we get a defined but not used warning for

Re: [PATCH,v2 net] net: sched: validate that class is found in qdisc_tree_decrease_qlen

2015-07-21 Thread Cong Wang
On Tue, Jul 21, 2015 at 1:57 PM, Eric Dumazet eric.duma...@gmail.com wrote: On Tue, 2015-07-21 at 11:12 -0700, Cong Wang wrote: - kfree_skb(skb); + INIT_LIST_HEAD(q-new_flows); + INIT_LIST_HEAD(q-old_flows); + for (i = 0; i q-flows_cnt; i++) { +

[RFC PATCH v2 net-next 2/3] tcp: add in_flight to tcp_skb_cb

2015-07-21 Thread Lawrence Brakmo
Based on comments by Neal Cardwell to tcp_nv patch: AFAICT this patch would not require an increase in the size of sk_buff cb[] if it were to take advantage of the fact that the tcp_skb_cb header.h4 and header.h6 fields are only used in the packet reception code path, and this in_flight

[RFC PATCH v2 net-next 0/3] tcp: add NV congestion control

2015-07-21 Thread Lawrence Brakmo
This patchset adds support for NV congestion control. The first patch replaces two arguments in the pkts_acked() function of the congestion control modules with a struct, making it easier to add more parameters later without modifying the existing congestion control modules. The second patch

Re: [PATCH net-next 0/9] sfc: support for cascaded multicast filtering

2015-07-21 Thread David Miller
From: Edward Cree ec...@solarflare.com Date: Tue, 21 Jul 2015 15:07:44 +0100 Recent versions of firmware for SFC9100 adapters add support for filter chaining, in which packets matching multiple filters are delivered to all filters' recipients, rather than only the highest match-priority

[RFC PATCH v2 net-next 1/3] tcp: replace cnt rtt with struct in pkts_acked()

2015-07-21 Thread Lawrence Brakmo
Replace 2 arguments (cnt and rtt) in the congestion control modules' pkts_acked() function with a struct. This will allow adding more information without having to modify existing congestion control modules (tcp_nv in particular needs bytes in flight when packet was sent). This was proposed by

[RFC PATCH v2 net-next 3/3] tcp: add NV congestion control

2015-07-21 Thread Lawrence Brakmo
This is a request for comments. TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of NV was presented at 2010's LPC (slides). It is a delayed based congestion avoidance for the data center. This version has been tested within a 10G rack where the HW RTTs are 20-50us. A

Re: [PATCH v2] openvswitch: allocate nr_node_ids flow_stats instead of num_possible_nodes

2015-07-21 Thread David Miller
From: Chris J Arges chris.j.ar...@canonical.com Date: Tue, 21 Jul 2015 12:36:33 -0500 Some architectures like POWER can have a NUMA node_possible_map that contains sparse entries. This causes memory corruption with openvswitch since it allocates flow_cache with a multiple of

Re: [PATCH net-next] mpls: make RTA_OIF optional

2015-07-21 Thread David Miller
From: Roopa Prabhu ro...@cumulusnetworks.com Date: Tue, 21 Jul 2015 09:16:24 -0700 From: Roopa Prabhu ro...@cumulusnetworks.com If user did not specify an oif, try and get it from the via address. If failed to get device, return with -ENODEV. Signed-off-by: Roopa Prabhu

[PATCH net-next] be2net: support ndo_get_phys_port_id()

2015-07-21 Thread Sriharsha Basavapatna
From: Sriharsha Basavapatna sriharsha.basavapa...@avagotech.com Add be_get_phys_port_id() function to report physical port id. The port id should be unique across different be2net devices in the system. We use the chip serial number along with the physical port number for this. Signed-off-by:

Re: [RFC PATCH v2 net-next 1/3] tcp: replace cnt rtt with struct in pkts_acked()

2015-07-21 Thread Eric Dumazet
On Tue, 2015-07-21 at 21:21 -0700, Lawrence Brakmo wrote: Replace 2 arguments (cnt and rtt) in the congestion control modules' pkts_acked() function with a struct. This will allow adding more information without having to modify existing congestion control modules (tcp_nv in particular needs

Re: [PATCH net-next v2] bridge: Fix setting a flag in br_fill_ifvlaninfo_range().

2015-07-21 Thread roopa
On 7/21/15, 9:57 PM, Rami Rosen wrote: This patch fixes setting of vinfo.flags in the br_fill_ifvlaninfo_range() method. The assignment of vinfo.flags = ~BRIDGE_VLAN_INFO_RANGE_BEGIN has no effect and is unneeded, as vinfo.flags value is overriden by the immediately following vinfo.flags =

Re: [PATCH net-next] ipv6: Avoid rt6_probe() taking writer lock in the fast path

2015-07-21 Thread Julian Anastasov
Hello, On Tue, 21 Jul 2015, Martin KaFai Lau wrote: The patch checks neigh-nud_state before acquiring the writer lock. Note that rt6_probe() is only used in CONFIG_IPV6_ROUTER_PREF. Locking usage is absolutely correct. + if (!(neigh-nud_state NUD_VALID) +

Re: [PATCH V2 net 0/3] BPF JIT fixes for ARM

2015-07-21 Thread David Miller
From: Nicolas Schichan nschic...@freebox.fr Date: Tue, 21 Jul 2015 14:14:11 +0200 These patches are fixing bugs in the ARM JIT and should probably find their way to a stable kernel. All 60 test_bpf tests in Linux 4.1 release are now passing OK (was 54 out of 60 before). Series applied,

[PATCH net-next] mpls_iptunnel: fix sparse warn: remove incorrect rcu_dereference

2015-07-21 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com fix for: net/mpls/mpls_iptunnel.c:73:19: sparse: incompatible types in comparison expression (different address spaces) remove incorrect rcu_dereference possibly left over from earlier revisions of the code. Reported-by: kbuild test robot

[RFC PATCH net-next] ebpf: Allow dereferences of PTR_TO_STACK registers

2015-07-21 Thread Alex Gartrell
mov %rsp, %r1 ; r1 = rsp add $-8, %r1; r1 = rsp - 8 store_q $123, -8(%rsp) ; *(u64*)r1 = 123 - valid store_q $123, (%r1) ; *(u64*)r1 = 123 - previously invalid mov $0, %r0 exit; Always need to exit

Re: [PATCH,v2 net] net: sched: validate that class is found in qdisc_tree_decrease_qlen

2015-07-21 Thread Eric Dumazet
On Tue, 2015-07-21 at 19:03 -0700, Cong Wang wrote: On Tue, Jul 21, 2015 at 1:57 PM, Eric Dumazet eric.duma...@gmail.com wrote: On Tue, 2015-07-21 at 11:12 -0700, Cong Wang wrote: - kfree_skb(skb); + INIT_LIST_HEAD(q-new_flows); +

[PATCH net-next v2] bridge: Fix setting a flag in br_fill_ifvlaninfo_range().

2015-07-21 Thread Rami Rosen
This patch fixes setting of vinfo.flags in the br_fill_ifvlaninfo_range() method. The assignment of vinfo.flags = ~BRIDGE_VLAN_INFO_RANGE_BEGIN has no effect and is unneeded, as vinfo.flags value is overriden by the immediately following vinfo.flags = flags | BRIDGE_VLAN_INFO_RANGE_END

Re: [PATCH net] netlink: don't hold mutex in rcu callback when releasing mmapd ring

2015-07-21 Thread David Miller
From: Florian Westphal f...@strlen.de Date: Tue, 21 Jul 2015 16:33:50 +0200 Kirill A. Shutemov says: This simple test-case trigers few locking asserts in kernel: ... Cong Wang says: We can't hold mutex lock in a rcu callback, [..] Thomas Graf says: The socket should be dead at this

Re: [PATCH net-next] net: track success and failure of TCP PMTU probing

2015-07-21 Thread David Miller
From: r...@tardy.usa.hp.com (Rick Jones) Date: Tue, 21 Jul 2015 16:14:13 -0700 (PDT) From: Rick Jones rick.jon...@hp.com Track success and failure of TCP PMTU probing. Signed-off-by: Rick Jones rick.jon...@hp.com Seems reasonable, applied, thanks Rick. -- To unsubscribe from this list:

Re: [PATCH] ravb: fix ring memory allocation

2015-07-21 Thread David Miller
From: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Date: Wed, 22 Jul 2015 01:31:59 +0300 The driver is written as if it can adapt to a low memory situation allocating less RX skbs and TX aligned buffers than the respective RX/TX ring sizes. In reality though the driver would

Re: [PATCH v2] openvswitch: allocate nr_node_ids flow_stats instead of num_possible_nodes

2015-07-21 Thread Pravin Shelar
On Tue, Jul 21, 2015 at 10:36 AM, Chris J Arges chris.j.ar...@canonical.com wrote: Some architectures like POWER can have a NUMA node_possible_map that contains sparse entries. This causes memory corruption with openvswitch since it allocates flow_cache with a multiple of num_possible_nodes()

Re: ARP response with link local IP, why not broadcast

2015-07-21 Thread Sowmini Varadhan
On Tue, Jul 21, 2015 at 4:38 PM, Sebastian Fett db_ext...@gmx.de wrote: Hello! According to RFC3927 every ARP packet (reply and request) should be sent as link layer broadcast as long as the sender IP is a link local address. (see chapter 2.5). Because broadcast replies are noisy and should

Re: [PATCH V4 0/2] pci: Provide a flag to access VPD through function 0

2015-07-21 Thread Bjorn Helgaas
[+cc Alex] On Mon, Jul 13, 2015 at 11:39:54AM -0700, Mark D Rustad wrote: Many multi-function devices provide shared registers in extended config space for accessing VPD. The behavior of these registers means that the state must be tracked and access locked correctly for accesses not to hang

Re: reproducable panic eviction work queue

2015-07-21 Thread Florian Westphal
Frank Schreuder fschreu...@transip.nl wrote: [ inet frag evictor crash ] We believe we found the bug. This patch should fix it. We cannot share list for buckets and evictor, the flag member is subject to race conditions so flags INET_FRAG_EVICTED test is not reliable. It would be great if

Re: [PATCH v2] openvswitch: allocate nr_node_ids flow_stats instead of num_possible_nodes

2015-07-21 Thread Nishanth Aravamudan
On 21.07.2015 [12:36:33 -0500], Chris J Arges wrote: Some architectures like POWER can have a NUMA node_possible_map that contains sparse entries. This causes memory corruption with openvswitch since it allocates flow_cache with a multiple of num_possible_nodes() and assumes the node variable

Re: [PATCH] openvswitch: make for_each_node loops work with sparse numa systems

2015-07-21 Thread Nishanth Aravamudan
On 21.07.2015 [11:30:58 -0500], Chris J Arges wrote: On Tue, Jul 21, 2015 at 09:24:18AM -0700, Nishanth Aravamudan wrote: On 21.07.2015 [10:32:34 -0500], Chris J Arges wrote: Some architectures like POWER can have a NUMA node_possible_map that contains sparse entries. This causes memory

Re: [PATCH iproute2] Use PATH_MAX instead of MAXPATHLEN

2015-07-21 Thread Yegor Yefremov
On Wed, Apr 29, 2015 at 6:52 PM, Felix Janda felix.ja...@posteo.de wrote: Florian Fainelli wrote: On 27/04/15 09:13, Stephen Hemminger wrote: On Sat, 25 Apr 2015 22:33:28 +0200 Felix Janda felix.ja...@posteo.de wrote: They are equivalent but the former is more common. PATH_MAX is

Re: Why return E2BIG from bpf map update?

2015-07-21 Thread Alexei Starovoitov
On 7/21/15 3:13 AM, Alex Gartrell wrote: But, the EINVAL errno has similarly been abused to death there was a thread few month ago trying to come up with a generic solution for aliased error codes, but unfortunately nothing concrete came out of it. The one I liked sounded that the kernel may

Re: [PATCH net v5 0/4] net: enable inband link state negotiation only when explicitly requested

2015-07-21 Thread Arnaud Ebalard
Hi guys, Florian Fainelli f.faine...@gmail.com writes: Changes in v5: - removed an invalid use of the link_update callback in the SF2 driver was appeared after merging net: phy: fixed_phy: handle link-down case - reworded the commit message for patch 2 to make it clear what it fixes and

Re: [PATCH,v2 net] net: sched: validate that class is found in qdisc_tree_decrease_qlen

2015-07-21 Thread Eric Dumazet
On Tue, 2015-07-21 at 11:12 -0700, Cong Wang wrote: - kfree_skb(skb); + INIT_LIST_HEAD(q-new_flows); + INIT_LIST_HEAD(q-old_flows); + for (i = 0; i q-flows_cnt; i++) { + struct fq_codel_flow *flow = q-flows + i; + + while

RE: [PATCH v2 1/2] net: fec: use managed DMA API functions to allocate BD ring

2015-07-21 Thread Duan Andy
From: Lucas Stach l.st...@pengutronix.de Sent: Tuesday, July 21, 2015 11:11 PM To: David S. Miller Cc: Duan Fugang-B38611; Li Frank-B20596; netdev@vger.kernel.org; ker...@pengutronix.de; patchwork-...@pengutronix.de Subject: [PATCH v2 1/2] net: fec: use managed DMA API functions to allocate

[PATCH] ravb: fix ring memory allocation

2015-07-21 Thread Sergei Shtylyov
The driver is written as if it can adapt to a low memory situation allocating less RX skbs and TX aligned buffers than the respective RX/TX ring sizes. In reality though the driver would malfunction in this case. Stop being overly smart and just fail in such situation -- this is achieved by

Re: [PATCHv2 net-next] net: #ifdefify sk_classid member of struct sock

2015-07-21 Thread David Miller
From: Mathias Krause mini...@googlemail.com Date: Sun, 19 Jul 2015 22:21:13 +0200 The sk_classid member is only required when CONFIG_CGROUP_NET_CLASSID is enabled. #ifdefify it to reduce the size of struct sock on 32 bit systems, at least. Signed-off-by: Mathias Krause

Re: pull-request: wireless-drivers 2015-07-20

2015-07-21 Thread David Miller
From: Kalle Valo kv...@codeaurora.org Date: Mon, 20 Jul 2015 18:36:30 +0300 here are few fixes for 4.2, should not have anything out of ordinary. Please let me know if there are any issues. Pulled, thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a

[PATCH net-next] net: track success and failure of TCP PMTU probing

2015-07-21 Thread Rick Jones
From: Rick Jones rick.jon...@hp.com Track success and failure of TCP PMTU probing. Signed-off-by: Rick Jones rick.jon...@hp.com --- Tested by loading-up into an OpenStack instance and kicking the MTU out from under it in the corresponding router namespace. diff --git

Re: [PATCH net-next v4] ipv6: sysctl to restrict candidate source addresses

2015-07-21 Thread David Miller
From: Erik Kline e...@google.com Date: Mon, 20 Jul 2015 16:06:34 +0200 I thought perhaps use_oif_addr_only was a slightly clearer sysctl name. (Maybe it should be plural, use_oif_addrs_only?) I think plural would be better too, please respin with that change. Thanks. -- To unsubscribe from

Re: [PATCH net v5 0/4] net: enable inband link state negotiation only when explicitly requested

2015-07-21 Thread David Miller
From: Florian Fainelli f.faine...@gmail.com Date: Mon, 20 Jul 2015 17:49:54 -0700 Changes in v5: - removed an invalid use of the link_update callback in the SF2 driver was appeared after merging net: phy: fixed_phy: handle link-down case - reworded the commit message for patch 2 to make

Re: [PATCH net-next 1/1] tipc: fix compatibility bug

2015-07-21 Thread David Miller
From: Jon Maloy jon.ma...@ericsson.com Date: Tue, 21 Jul 2015 06:42:28 -0400 In commit d999297c3dbbe7fdd832f7fa4ec84301e170b3e6 (tipc: reduce locking scope during packet reception) we introduced a new function tipc_link_proto_rcv(). This function contains a bug, so that it sometimes by error

[Patch net] sch_plug: purge buffered packets during reset

2015-07-21 Thread Cong Wang
Otherwise the skbuff related structures are not correctly refcount'ed. Cc: Jamal Hadi Salim j...@mojatatu.com Signed-off-by: Cong Wang xiyou.wangc...@gmail.com --- net/sched/sch_plug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sched/sch_plug.c b/net/sched/sch_plug.c index

[net-next:master 194/208] include/net/dst_metadata.h:39:4: error: implicit declaration of function 'lwt_tun_info'

2015-07-21 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 16040894b26af9f85d9395f072c53d76a44eba21 commit: 3093fbe7ff4bc7d1571fc217dade1cf80330a714 [194/208] route: Per route IP tunnel metadata via lightweight tunnel config: i386-randconfig-i0-201529 (attached as

[net-next:master 195/208] net/core/fib_rules.c:418:3: error: implicit declaration of function 'ip_tunnel_need_metadata'

2015-07-21 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 16040894b26af9f85d9395f072c53d76a44eba21 commit: e7030878fc8448492b6e5cecd574043f63271298 [195/208] fib: Add fib rule match on tunnel id config: i386-randconfig-r0-201529 (attached as .config) reproduce: git

[PATCH net-next] ipv6: Avoid rt6_probe() taking writer lock in the fast path

2015-07-21 Thread Martin KaFai Lau
The patch checks neigh-nud_state before acquiring the writer lock. Note that rt6_probe() is only used in CONFIG_IPV6_ROUTER_PREF. I also take this chance to re-arrange the code. 40 udpflood processes and a /64 gateway route are used. The gateway has NUD_PERMANENT. Each of them is run for 30s.

[Patch net] sch_choke: drop all packets in queue during reset

2015-07-21 Thread Cong Wang
Signed-off-by: Cong Wang xiyou.wangc...@gmail.com --- net/sched/sch_choke.c | 13 + 1 file changed, 13 insertions(+) diff --git a/net/sched/sch_choke.c b/net/sched/sch_choke.c index 93d5742..6a783af 100644 --- a/net/sched/sch_choke.c +++ b/net/sched/sch_choke.c @@ -385,6 +385,19 @@

Re: [PATCH net] caif: fix leaks and race in caif_queue_rcv_skb()

2015-07-21 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Fri, 17 Jul 2015 10:19:23 +0200 From: Eric Dumazet eduma...@google.com 1) If sk_filter() is applied, skb was leaked (not freed) 2) Testing SOCK_DEAD twice is racy : packet could be freed while already queued. 3) Remove obsolete comment

Re: [PATCH] sctp: fix cut and paste issue in comment

2015-07-21 Thread David Miller
From: Marcelo Ricardo Leitner marcelo.leit...@gmail.com Date: Fri, 17 Jul 2015 13:50:21 -0300 Cookie ACK is always received by the association initiator, so fix the comment to avoid confusion. Signed-off-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com Applied, thanks. -- To

Re: [PATCH 1/2] net: fec: use managed DMA API functions to allocate BD ring

2015-07-21 Thread David Miller
From: Lucas Stach l.st...@pengutronix.de Date: Mon, 20 Jul 2015 15:51:37 +0200 So it gets freed when the device is going away. This fixes a DMA memory leak on driver probe() fail and driver remove(). Signed-off-by: Lucas Stach l.st...@pengutronix.de ---

Re: [PATCH] net/mdio: fix mdio_bus_match for c45 PHY

2015-07-21 Thread David Miller
From: shh@gmail.com Date: Fri, 17 Jul 2015 18:07:19 +0800 From: Shaohui Xie shaohui@freescale.com We store c45 PHY's id information in c45_ids, so it should be used to check the matching between PHY driver and PHY device for c45 PHY. Signed-off-by: Shaohui Xie

Re: [PATCH v2] net: mvneta: fix refilling for Rx DMA buffers

2015-07-21 Thread David Miller
From: Simon Guinot simon.gui...@sequanux.org Date: Sun, 19 Jul 2015 13:00:53 +0200 With the actual code, if a memory allocation error happens while refilling a Rx descriptor, then the original Rx buffer is both passed to the networking stack (in a SKB) and let in the Rx ring. This leads to

Re: [PATCH] inet: frags: fix defragmented packet's IP header for af_packet

2015-07-21 Thread Eric Dumazet
This doesn't compile. net/ipv4/ip_fragment.c: In function ‘ip_frag_reasm’: net/ipv4/ip_fragment.c:644:23: error: ‘skb’ undeclared (first use in this function) ip_send_check(ip_hdr(skb)); This was meant to be ip_send_check(iph); Sorry, will send a v2 -- To unsubscribe from this list:

Re: [PATCH] phylib: add driver for Teranetics TN2020

2015-07-21 Thread David Miller
From: shh@gmail.com Date: Fri, 17 Jul 2015 11:19:46 +0800 From: Shaohui Xie shaohui@freescale.com Teranetics TN2020 is compliant with IEEE 802.3an 10 Gigabit. Signed-off-by: Shaohui Xie shaohui@freescale.com Applied to net-next, thanks. -- To unsubscribe from this list: send

Re: [PATCH net-next v2] rhashtable: Allow other tasks to be scheduled in large lookup loops

2015-07-21 Thread David Miller
From: Thomas Graf tg...@suug.ch Date: Fri, 17 Jul 2015 10:52:48 +0200 Depending on system speed, the large lookup/insert/delete loops of the testsuite can take a considerable amount of time to complete causing watchdog warnings to appear. Allow other tasks to be scheduled throughout the

Re: [PATCH net-next] inet: Always increment refcount in inet_twsk_schedule

2015-07-21 Thread Eric Dumazet
On Mon, 2015-07-20 at 19:14 +, subas...@codeaurora.org wrote: //Initialize time wait socket and setup timer inet_twsk_alloc() tw_refcnt = 0 __inet_twsk_hashdance() tw_refcnt = 3 inet_twsk_schedule() tw_refcnt = 4 inet_twsk_put() tw_refcnt = 3 //Receive packet 1 in timewait state

Re: [PATCH] bonding: correct the MAC address for follow fail_over_mac policy

2015-07-21 Thread Ding Tianhong
On 2015/7/21 11:30, David Miller wrote: From: Ding Tianhong dingtianh...@huawei.com Date: Thu, 16 Jul 2015 16:30:02 +0800 The follow fail_over_mac policy is useful for multiport devices that either become confused or incur a performance penalty when multiple ports are programmed with the

Re: [PATCH net] macvtap: fix network header pointer for VLAN tagged pkts

2015-07-21 Thread Ivan Vecera
On 07/20/2015 06:42 PM, Vlad Yasevich wrote: On 07/20/2015 11:44 AM, Ivan Vecera wrote: Network header is set with offset ETH_HLEN but it is not true for VLAN (multiple-)tagged and results in checksum issues in lower devices. Signed-off-by: Ivan Vecera ivec...@redhat.com ---

Re: [PATCH v2] net: ratelimit warnings about dst entry refcount underflow or overflow

2015-07-21 Thread David Miller
From: Konstantin Khlebnikov khlebni...@yandex-team.ru Date: Fri, 17 Jul 2015 14:01:11 +0300 Kernel generates a lot of warnings when dst entry reference counter overflows and becomes negative. That bug was seen several times at machines with outdated 3.10.y kernels. Most like it's already fixed

Re: [PATCH v2 net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

2015-07-21 Thread David Miller
From: Sowmini Varadhan sowmini.varad...@oracle.com Date: Mon, 20 Jul 2015 09:54:50 +0200 __vxlan_find_mac invokes ether_addr_equal on the eth_addr field, which triggers unaligned access messages, so rearrange vxlan_fdb to avoid this in the most non-intrusive way. Signed-off-by: Sowmini

Re: [PATCH net] stmmac: fix setting of driver data in stmmac_dvr_probe

2015-07-21 Thread David Miller
From: Joachim Eastwood manab...@gmail.com Date: Fri, 17 Jul 2015 23:48:17 +0200 Commit 803f8fc46274b (stmmac: move driver data setting into stmmac_dvr_probe) mistakenly set priv and not priv-dev as driver data. This meant that the remove, resume and suspend callbacks that fetched and tried to

  1   2   >