[PATCH 2/2] net: netcp: Allocate RX packet buffers using __GFP_DMA

2015-07-29 Thread WingMan Kwok
The Keystone II DMA hardware can only access addresses in the lower 2 GiB of SDRAM. This patch makes sure the RX buffers are allocated using the __GFP_DMA flag so they meet this requirement. Signed-off-by: WingMan Kwok w-kw...@ti.com Signed-off-by: Reece R. Pollack x0183...@ti.com ---

[PATCH 1/2] net: Export __netdev_alloc_frag() to allow gfp_mask flags

2015-07-29 Thread WingMan Kwok
This patch makes the function __netdev_alloc_frag() non-static and exports it so that drivers that need to specify additional flags, such as __GFP_DMA, can use it. The currently exported function, netdev_alloc_frag() doesn't allow passing in gfp_mask flags. Signed-off-by: WingMan Kwok

[PATCH] net/phy: micrel: Reenable interrupts during resume

2015-07-29 Thread Nathan Sullivan
The ksz9031 has a behavior where it will clear the interrupt enable bits when leaving power down. To work around this, make sure the interrupt bits are in the state they are expected to be when resuming. Signed-off-by: Nathan Sullivan nathan.sulli...@ni.com --- drivers/net/phy/micrel.c | 18

[PATCH net 02/11] net: thunderx: Fix memory leak while tearing down interface

2015-07-29 Thread Aleksey Makarov
From: Sunil Goutham sgout...@cavium.com Fixed 'tso_hdrs' memory not being freed properly. Also fixed SQ skbuff maintenance issues. Signed-off-by: Sunil Goutham sgout...@cavium.com Signed-off-by: Aleksey Makarov aleksey.maka...@caviumnetworks.com ---

[PATCH net 00/11] net: thunderx: Misc fixes

2015-07-29 Thread Aleksey Makarov
Miscellaneous fixes for the ThunderX VNIC driver All the patches can be applied individually. It's ok to drop some if the maintainer feels uncomfortable with applying for 4.2. Sunil Goutham (10): net: thunderx: Fix data integrity issues with LDWB net: thunderx: Fix memory leak while tearing

[PATCH net] act_bpf: fix memory leaks when replacing bpf programs

2015-07-29 Thread Daniel Borkmann
We currently trigger multiple memory leaks when replacing bpf actions, besides others: comm tc, pid 1909, jiffies 4294851310 (age 1602.796s) hex dump (first 32 bytes): 01 00 00 00 03 00 00 00 00 00 00 00 00 00 00 00 18 b0 98 6d 00 88 ff ff 00 00 00 00 00 00 00 00

[PATCH net 03/11] net: thunderx: Fix RQ_DROP miscalculation

2015-07-29 Thread Aleksey Makarov
From: Sunil Goutham sgout...@cavium.com With earlier configured value sufficient number of CQEs are not being reserved for transmitted packets. Hence under heavy incoming traffic load, receive notifications will take away most of the CQ thus transmit notifications will be lost resulting in tx

Re: [PATCH 1/2] net: Export __netdev_alloc_frag() to allow gfp_mask flags

2015-07-29 Thread Eric Dumazet
On Wed, 2015-07-29 at 11:10 -0400, WingMan Kwok wrote: This patch makes the function __netdev_alloc_frag() non-static and exports it so that drivers that need to specify additional flags, such as __GFP_DMA, can use it. The currently exported function, netdev_alloc_frag() doesn't allow passing

Re: [PATCH net-next 1/2] net: Set sk_txhash from a random number

2015-07-29 Thread Tom Herbert
On Wed, Jul 29, 2015 at 2:54 AM, Thomas Graf tg...@suug.ch wrote: On 07/29/15 at 11:29am, Eric Dumazet wrote: On Wed, 2015-07-29 at 11:13 +0200, Thomas Graf wrote: On 07/28/15 at 04:02pm, Tom Herbert wrote: This patch creates sk_set_txhash and eliminates protocol specific inet_set_txhash

[PATCH net 09/11] net: thunderx: Fix crash when changing rss with mutliple traffic flows

2015-07-29 Thread Aleksey Makarov
From: Sunil Goutham sgout...@cavium.com This fixes a crash when changing rss with multiple traffic flows. While interface teardown, disable tx queues after all NAPI threads are done. If done otherwise tx queues might be woken up inside NAPI if any CQE_TX are processed. Signed-off-by: Sunil

[PATCH net 05/11] net: thunderx: Fix TSO packet statistic

2015-07-29 Thread Aleksey Makarov
From: Sunil Goutham sgout...@cavium.com Fixing TSO packages not being counted. Signed-off-by: Sunil Goutham sgout...@cavium.com Signed-off-by: Aleksey Makarov aleksey.maka...@caviumnetworks.com --- drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH net 01/11] net: thunderx: Fix data integrity issues with LDWB

2015-07-29 Thread Aleksey Makarov
From: Sunil Goutham sgout...@cavium.com Switching back to LDD transactions from LDWB. While transmitting packets out with LDWB transactions data integrity issues are seen very frequently. hence switching back to LDD. Signed-off-by: Sunil Goutham sgout...@cavium.com Signed-off-by: Robert Richter

[PATCH net 11/11] net: thunderx: Fix for crash while BGX teardown

2015-07-29 Thread Aleksey Makarov
From: Thanneeru Srinivasulu tsrinivas...@caviumnetworks.com Cortina phy does not have kernel driver and we don't attach device with phy layer for intefaces like XFI, XLAUI etc, Hence check for interface type before calling disconnect. Signed-off-by: Thanneeru Srinivasulu

Re: [PATCH net-next v2] gianfar: Fix warnings when built on 64-bit

2015-07-29 Thread Scott Wood
On Wed, 2015-07-29 at 16:13 +0300, Claudiu Manoil wrote: From: Scott Wood scottw...@freescale.com As part of defconfig consolidation using fragments, we'd like to be able to have the same drivers enabled on 32-bit and 64-bit. Gianfar happens to only exist on 32-bit systems, and when

Re: [PATCH net-next v3] route: allow to route in a peer netns via lwt framework

2015-07-29 Thread Eric Dumazet
On Wed, 2015-07-29 at 15:16 +0200, Nicolas Dichtel wrote: This patch takes advantage of the newly added lwtunnel framework to allow the user to set routes that point to a peer netns. Packets are injected to the peer netns via the loopback device. It works only when the output device is 'lo'.

Re: [PATCH] gianfar: Fix warnings when built on 64-bit

2015-07-29 Thread Scott Wood
On Wed, 2015-07-29 at 10:02 +0200, Arnd Bergmann wrote: On Wednesday 29 July 2015 00:24:37 Scott Wood wrote: +#ifdef CONFIG_PM static void lock_tx_qs(struct gfar_private *priv) { int i; @@ -580,6 +581,7 @@ static void unlock_tx_qs(struct gfar_private *priv) for (i = 0; i

Re: [RFC PATCH 1/1] net/ipv4: Enable flow-based ECMP

2015-07-29 Thread Tom Herbert
On Tue, Jul 28, 2015 at 11:11 PM, Michal Kubecek mkube...@suse.cz wrote: On Tue, Jul 28, 2015 at 09:20:02PM +, Richard Laing wrote: diff --git a/include/net/flow.h b/include/net/flow.h index 8109a15..d1d933d 100644 --- a/include/net/flow.h +++ b/include/net/flow.h @@ -79,6 +79,10 @@

[PATCH net 07/11] net: thunderx: Wakeup TXQ only if CQE_TX are processed

2015-07-29 Thread Aleksey Makarov
From: Sunil Goutham sgout...@cavium.com Previously TXQ is wakedup whenever napi is executed and irrespective of if any CQE_TX are processed or not. Added 'txq_stop' and 'txq_wake' counters to aid in debugging if there are any future issues. Signed-off-by: Sunil Goutham sgout...@cavium.com

[PATCH net 06/11] net: thunderx: Suppress alloc_pages() failure warnings

2015-07-29 Thread Aleksey Makarov
From: Sunil Goutham sgout...@cavium.com Suppressing standard alloc_pages() warnings. Some kernel configs limit alloc size and the network driver may fail. Do not drop a kernel warning in this case, instead just drop a oneliner that the network driver could not be loaded since the buffer could not

Re: [PATCH net] bridge: Fix network header pointer for vlan tagged packets

2015-07-29 Thread David Miller
From: Toshiaki Makita makita.toshi...@lab.ntt.co.jp Date: Tue, 28 Jul 2015 19:05:37 +0900 There are several devices that can receive vlan tagged packets with CHECKSUM_PARTIAL like tap, possibly veth and xennet. When (multiple) vlan tagged packets with CHECKSUM_PARTIAL are forwarded by bridge

Re: [PATCH net-next] net/mlx4_en: Hardware accelerated 802.1ad works only on the first port

2015-07-29 Thread David Miller
From: Amir Vadai am...@mellanox.com Date: Tue, 28 Jul 2015 13:19:19 +0300 Fix mistakenly used, hard coded, port number in get_phv_bit() Fixes: 77fc29c (net/mlx4_core: Preparations for 802.1ad VLAN support) Signed-off-by: Amir Vadai am...@mellanox.com Applied. -- To unsubscribe from this

Re: [PATCH 2/2] net: netcp: Allocate RX packet buffers using __GFP_DMA

2015-07-29 Thread Eric Dumazet
On Wed, 2015-07-29 at 11:10 -0400, WingMan Kwok wrote: The Keystone II DMA hardware can only access addresses in the lower 2 GiB of SDRAM. This patch makes sure the RX buffers are allocated using the __GFP_DMA flag so they meet this requirement. Signed-off-by: WingMan Kwok w-kw...@ti.com

Re: [PATCH] gianfar: Fix warnings when built on 64-bit

2015-07-29 Thread Arnd Bergmann
On Wednesday 29 July 2015 11:02:41 Scott Wood wrote: On Wed, 2015-07-29 at 10:02 +0200, Arnd Bergmann wrote: On Wednesday 29 July 2015 00:24:37 Scott Wood wrote: +#ifdef CONFIG_PM static void lock_tx_qs(struct gfar_private *priv) { int i; @@ -580,6 +581,7 @@ static void

Re: [PATCH net] bridge: mcast: give fast leave precedence over multicast router and querier

2015-07-29 Thread David Miller
From: Nikolay Aleksandrov niko...@cumulusnetworks.com Date: Tue, 28 Jul 2015 03:28:27 -0700 From: Satish Ashok sas...@cumulusnetworks.com When fast leave is configured on a bridge port and an IGMP leave is received for a group, the group is not deleted immediately if there is a router

RE: [PATCH net-next 1/1] Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver

2015-07-29 Thread Woojung.Huh
Thanks for review and comment. Will repost after update. -Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: Wednesday, July 29, 2015 3:14 PM To: Woojung Huh - C21699 Cc: netdev@vger.kernel.org Subject: Re: [PATCH net-next 1/1] Microchip's LAN7800 family USB

Re: [PATCH net] bridge: mdb: fix delmdb state in the notification

2015-07-29 Thread David Miller
From: Nikolay Aleksandrov ra...@blackwall.org Date: Tue, 28 Jul 2015 13:10:44 +0200 From: Nikolay Aleksandrov niko...@cumulusnetworks.com Since mdb states were introduced when deleting an entry the state was left as it was set in the delete request from the user which leads to the following

Re: [PATCH net-next] packet: remove handling of tx_ring from prb_shutdown_retire_blk_timer()

2015-07-29 Thread David Miller
From: Tobias Klauser tklau...@distanz.ch Date: Tue, 28 Jul 2015 14:21:26 +0200 Follow e8e85cc5eb57 (packet: remove handling of tx_ring) and remove the tx_ring parameter from prb_shutdown_retire_blk_timer() as it is only called with tx_ring = 0. Signed-off-by: Tobias Klauser

[net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-07-29 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc --- net/Kconfig| 12 net/ethernet/eth.c | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/net/Kconfig b/net/Kconfig index 7021c1b..21c164f 100644 --- a/net/Kconfig +++ b/net/Kconfig @@ -48,6 +48,18 @@ config

[net-next PATCH 0/3] Backwards-compatible noqueue in virtual interfaces

2015-07-29 Thread Phil Sutter
This series is inspired by a patch sent[1] in from Jesper Brouer and the discussion it started. Basically it tries to provide a solution which is backwards compatible while still enabling the veth performance improvement by default. [1]: http://www.spinics.net/lists/netdev/msg299407.html Jesper

[net-next PATCH 2/3] net: sched: set tx_queue_len to default when changing noqueue device's qdisc

2015-07-29 Thread Phil Sutter
Virtual interfaces don't necessarily need a qdisc attached to them. This is signalled by setting dev-tx_queue_len to zero upon initialisation. The problems begin when a user still adds a qdisc, as then the special value is used as a regular one causing massive packet drops as soon as the device

[net-next PATCH 3/3] veth: don't assign a qdisc to veth

2015-07-29 Thread Phil Sutter
From: Jesper Dangaard Brouer bro...@redhat.com The veth driver is a virtual device, and should not have assigned the default qdisc. Verified (ndo_start_xmit) veth_xmit can only return NETDEV_TX_OK, thus this should be safe to bypass qdisc. Not assigning a qdisc is subtly done by setting

Re: [PATCH net-next v3] route: allow to route in a peer netns via lwt framework

2015-07-29 Thread Nicolas Dichtel
Le 29/07/2015 17:20, Eric Dumazet a écrit : On Wed, 2015-07-29 at 15:16 +0200, Nicolas Dichtel wrote: This patch takes advantage of the newly added lwtunnel framework to allow the user to set routes that point to a peer netns. Packets are injected to the peer netns via the loopback device. It

Re: [PATCH V4 4/7] Drivers: hv: vmbus: add APIs to register callbacks to process hvsock connection

2015-07-29 Thread David Miller
From: Dexuan Cui de...@microsoft.com Date: Tue, 28 Jul 2015 05:35:11 -0700 With the 2 APIs supplied by the VMBus driver, the coming net/hvsock driver can register 2 callbacks and can know when a new hvsock connection is offered by the host, and when a hvsock connection is being closed by the

[PATCH net-next 2/3] net: dsa: tag_brcm: Support extracting tags from HW

2015-07-29 Thread Florian Fainelli
In case an adapter advertises NETIF_F_HW_SWITCH_RX_TAG, proceed with extracting the 4-bytes Broadcom tag directly from skb-cb[] and utilize that instead of copying and memmoving() data around. To establish a contract between the Ethernet MAC advertisign NETIF_F_HW_SWITCH_RX_TAG and the Broadcom

[PATCH net-next 3/3] net: systemport: Add support for switch tag HW extraction

2015-07-29 Thread Florian Fainelli
The Broadcom SYSTEMPORT Ethernet controller is capable of extracting a switch tag (4-bytes Broadcom tag) and put it in the second 32-bits word of its pre-pended Receive Status Block. When this feature is requested, make sure that we can satisfy it by turning on receive checksum offload, and copy

[PATCH v2 0/2] igb/ixgbe: Fix ordering of SR-IOV teardown

2015-07-29 Thread Alex Williamson
v2: - Rebase to DaveM's net tree, context-only change - Add Mitch's Acks There's no functional change from v1, so the choice of v1 or v2 is just a matter of which maintainer wants to take these. Original description: When running a Windows 2012 R2 guest with a pair of VFs assigned through

[PATCH v2 1/2] igb: Teardown SR-IOV before unregister_netdev()

2015-07-29 Thread Alex Williamson
When the .remove() callback for a PF is called, SR-IOV support for the device is disabled, which requires unbinding and removing the VFs. The VFs may be in-use either by the host kernel or userspace, such as assigned to a VM through vfio-pci. In this latter case, the VFs may be removed either by

[PATCH v2 2/2] ixgbe: Teardown SR-IOV before unregister_netdev()

2015-07-29 Thread Alex Williamson
When the .remove() callback for a PF is called, SR-IOV support for the device is disabled, which requires unbinding and removing the VFs. The VFs may be in-use either by the host kernel or userspace, such as assigned to a VM through vfio-pci. In this latter case, the VFs may be removed either by

Re: [PATCH 1/2] net: Export __netdev_alloc_frag() to allow gfp_mask flags

2015-07-29 Thread Eric Dumazet
On Wed, 2015-07-29 at 16:22 -0400, Murali Karicheri wrote: Eric, On 07/29/2015 12:31 PM, Eric Dumazet wrote: On Wed, 2015-07-29 at 11:10 -0400, WingMan Kwok wrote: This patch makes the function __netdev_alloc_frag() non-static and exports it so that drivers that need to specify

Re: [PATCH] net: switchdev: restrict vid range abstraction

2015-07-29 Thread Scott Feldman
On Wed, Jul 29, 2015 at 12:14 PM, Vivien Didelot vivien.dide...@savoirfairelinux.com wrote: Hi Scott, David, On Jul 29, 2015, at 2:28 PM, David da...@davemloft.net wrote: From: Scott Feldman sfel...@gmail.com Date: Wed, 29 Jul 2015 00:31:44 -0700 Since the netlink request (for example vlan

Re: [PATCH net-next] flow_dissector: remove __flow_hash_consistentify

2015-07-29 Thread Eric Dumazet
On Wed, 2015-07-29 at 13:49 -0700, Tom Herbert wrote: The intent of this function was to produce a consistent hash for both directions of a flow. However, since we added more inputs to the flow hashing (IPv6 flow labels for instance) in a lot of cases we won't get the same hash computed for

[patch net-next v2 1/4] mlxsw: Introduce Mellanox switch driver core

2015-07-29 Thread Jiri Pirko
From: Jiri Pirko j...@mellanox.com Add core components of Mellanox switch driver infrastructure. Core infrastructure is designed so that it can be used by multiple bus drivers (PCI now, I2C and SGMII are planned to be implemented in the future). Multiple switch kind drivers can be registered as

[patch net-next v2 0/4] Introduce Mellanox Technologies Switch ASICs switchdev drivers

2015-07-29 Thread Jiri Pirko
From: Jiri Pirko j...@mellanox.com This patchset introduces Mellanox Technologies Switch driver infrastructure and support for SwitchX-2 ASIC. The driver is divided into 3 logical parts: 1) Bus - implements switch bus interface. Currently only PCI bus is implemented, but more buses will be

[patch net-next v2 2/4] mlxsw: Add PCI bus implementation

2015-07-29 Thread Jiri Pirko
From: Jiri Pirko j...@mellanox.com Add PCI bus implementation for Mellanox Technologies Switch ASICs. This includes firmware initialization, async queues manipulation and command interface implementation. Signed-off-by: Jiri Pirko j...@mellanox.com Signed-off-by: Ido Schimmel ido...@mellanox.com

Re: [PATCH net-next v2 0/5] s390/bpf: recache skb-data/hlen for skb_vlan_push/pop

2015-07-29 Thread David Miller
From: Michael Holzheu holz...@linux.vnet.ibm.com Date: Wed, 29 Jul 2015 21:15:13 +0200 Here the s390 backend for Alexei's patch 4e10df9a60d9 (bpf: introduce bpf_skb_vlan_push/pop() helpers) plus two bugfixes and two minor improvements. The first patch s390/bpf: clear correct BPF accumulator

Re: [PATCH net-next] flow_dissector: remove __flow_hash_consistentify

2015-07-29 Thread Tom Herbert
On Wed, Jul 29, 2015 at 3:15 PM, Eric Dumazet eric.duma...@gmail.com wrote: On Wed, 2015-07-29 at 14:47 -0700, Tom Herbert wrote: Hi Eric, So the scenario you're thinking is conntrack in the forwarding path, RPS enabled (RSS not relevant), no hash from device, no IPv6 flow labels or any

[PATCH net-next 0/3] net: Switch tag HW extraction/insertion

2015-07-29 Thread Florian Fainelli
Hi all, This patch series adds two new feature flags to allow Ethernet controllers capable of doing Ethernet switch proprietary tag insertion/extraction to benefit from that. The last two patches modify the Broadcom tag parsing code in DSA to utilize that feature and finally, the SYSTEMPORT

[PATCH net-next 1/3] net: add flags for HW assisted extraction/insertions of switch tags

2015-07-29 Thread Florian Fainelli
Some hardware (e.g: Broadcom's SYSTEMPORT) is capable of automatically extracting and inserting a proprietary switch tag (e.g: Broadcom tag) which saves us packet modifications when using DSA. Add the required ethtool changes and netdevice feature bits to support such devices. Signed-off-by:

Re: [net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-07-29 Thread Florian Westphal
Phil Sutter p...@nwl.cc wrote: Signed-off-by: Phil Sutter p...@nwl.cc --- net/Kconfig| 12 net/ethernet/eth.c | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/net/Kconfig b/net/Kconfig index 7021c1b..21c164f 100644 --- a/net/Kconfig +++

Re: [net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-07-29 Thread Phil Sutter
On Wed, Jul 29, 2015 at 11:06:18PM +0200, Florian Westphal wrote: Phil Sutter p...@nwl.cc wrote: [...] +config DEFAULT_TX_QUEUE_LEN + prompt Default TX queue length (in packets) if EXPERT + int + default 1000# Ethernet wants good queues + help + Set the default value

[patch net-next v2 3/4] mlxsw: Add interface to access registers and process events

2015-07-29 Thread Jiri Pirko
From: Ido Schimmel ido...@mellanox.com Ethernet Management Datagrams (EMADs) are Ethernet packets sent between the host and the device in order to configure the available device registers. Another use case is notifications sent from the device to the host, letting it know about certain events,

[PATCH net] net: sched: fix refcount imbalance in actions

2015-07-29 Thread Daniel Borkmann
Since commit 55334a5db5cd (net_sched: act: refuse to remove bound action outside), we end up with a wrong reference count for a tc action. Test case 1: FOO=1,6 0 0 4294967295, BAR=1,6 0 0 4294967294, tc filter add dev foo parent 1: bpf bytecode $FOO flowid 1:1 \ action bpf bytecode

[patch net-next v2 4/4] mlxsw: Introduce Mellanox SwitchX-2 ASIC support

2015-07-29 Thread Jiri Pirko
From: Jiri Pirko j...@mellanox.com Benefit from the previously introduced Mellanox Switch infrastructure and add driver for SwitchX-2 ASIC. Note that this driver is very simple now. It implements bare minimum for getting device to work on slow-path. Fast-path offload functionality is going to be

Re: [net-next PATCH 2/3] net: sched: set tx_queue_len to default when changing noqueue device's qdisc

2015-07-29 Thread Phil Sutter
On Wed, Jul 29, 2015 at 11:10:45PM +0200, Eric Dumazet wrote: On Wed, 2015-07-29 at 22:51 +0200, Phil Sutter wrote: [...] diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c index f06aa01..79b8900 100644 --- a/net/sched/sch_api.c +++ b/net/sched/sch_api.c @@ -1315,6 +1315,10 @@

Re: [PATCH net-next] flow_dissector: remove __flow_hash_consistentify

2015-07-29 Thread Eric Dumazet
On Wed, 2015-07-29 at 14:47 -0700, Tom Herbert wrote: Hi Eric, So the scenario you're thinking is conntrack in the forwarding path, RPS enabled (RSS not relevant), no hash from device, no IPv6 flow labels or any other asymmetric inputs into the flow hash? I can look at that, but it does

[PATCH net-next] flow_dissector: remove __flow_hash_consistentify

2015-07-29 Thread Tom Herbert
The intent of this function was to produce a consistent hash for both directions of a flow. However, since we added more inputs to the flow hashing (IPv6 flow labels for instance) in a lot of cases we won't get the same hash computed for each direction anyway. Also, there is no defined correlation

Re: [net-next PATCH 2/3] net: sched: set tx_queue_len to default when changing noqueue device's qdisc

2015-07-29 Thread Florian Westphal
Phil Sutter p...@nwl.cc wrote: Virtual interfaces don't necessarily need a qdisc attached to them. This is signalled by setting dev-tx_queue_len to zero upon initialisation. The problems begin when a user still adds a qdisc, as then the special value is used as a regular one causing massive

Re: [net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-07-29 Thread David Miller
From: Phil Sutter p...@nwl.cc Date: Wed, 29 Jul 2015 23:34:28 +0200 On Wed, Jul 29, 2015 at 11:06:18PM +0200, Florian Westphal wrote: Phil Sutter p...@nwl.cc wrote: [...] +config DEFAULT_TX_QUEUE_LEN + prompt Default TX queue length (in packets) if EXPERT + int + default 1000#

Re: [PATCH net-next] flow_dissector: remove __flow_hash_consistentify

2015-07-29 Thread Tom Herbert
On Wed, Jul 29, 2015 at 2:19 PM, Eric Dumazet eric.duma...@gmail.com wrote: On Wed, 2015-07-29 at 13:49 -0700, Tom Herbert wrote: The intent of this function was to produce a consistent hash for both directions of a flow. However, since we added more inputs to the flow hashing (IPv6 flow

Re: [PATCH 2/2] net: netcp: Allocate RX packet buffers using __GFP_DMA

2015-07-29 Thread Murali Karicheri
On 07/29/2015 04:59 PM, Eric Dumazet wrote: On Wed, 2015-07-29 at 11:10 -0400, WingMan Kwok wrote: The Keystone II DMA hardware can only access addresses in the lower 2 GiB of SDRAM. This patch makes sure the RX buffers are allocated using the __GFP_DMA flag so they meet this requirement.

[PATCH iproute2] bridge fdb: add 'use' option to set NTF_USE flag in fdb add requests

2015-07-29 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This is similar to command options corresponding to other NTF_* flags already exposed to the user space (examples self/master). Also updates bridge man page (The man page patch also includes a fix to the 'self' entry and documents 'master' for fdb

Xen-unstable + Linux 4.2-rc4: GPF RIP: e030:[ffffffff8110ea98] [ffffffff8110ea98] detach_if_pending+0x18/0x80

2015-07-29 Thread linux
Hi, Running on Xen testing a 4.2-rc4 kernel it got the crash below. Could this be related to the changes in 3bb475a3446facd0425d3f2fe7e85bf03c5c6c05 ? It crashes dom0 when i put some strain onto the network + bridge. -- Sander [ 2108.078763] general protection fault: [#1] SMP [

Re: [PATCH 0/2] igb/ixgbe: Fix ordering of SR-IOV teardown

2015-07-29 Thread David Miller
From: Alex Williamson alex.william...@redhat.com Date: Wed, 29 Jul 2015 13:33:07 -0600 I expect that's because of this patch that's in Jeff's dev-queue branch: http://git.kernel.org/cgit/linux/kernel/git/jkirsher/next-queue.git/commit/?h=dev-queueid=ddf766a812a13eca1116b5905e902184904266f9

[PATCH] net: phy: spi_ks8995: clean up ks8995_registers_read/write

2015-07-29 Thread Vladimir Zapolskiy
The change removes redundant sysfs binary file boundary checks, since this task is already done on caller side in fs/sysfs/file.c Signed-off-by: Vladimir Zapolskiy v...@mleia.com --- drivers/net/phy/spi_ks8995.c | 22 -- 1 file changed, 22 deletions(-) diff --git

[PATCH net-next 1/1] tipc: fix bug in broadcast synch message create function

2015-07-29 Thread Jon Maloy
In commit d999297c3dbbe7fdd832f7fa4ec84301e170b3e6 (tipc: reduce locking scope during packet reception) we introduced a new function tipc_build_bcast_sync_msg(), which carries initial synchronization data between two nodes at first contact and at re-contact. In this function, we missed to add

Re: [PATCH V4 7/7] Drivers: hv: vmbus: disable local interrupt when hvsock's callback is running

2015-07-29 Thread David Miller
From: Dexuan Cui de...@microsoft.com Date: Tue, 28 Jul 2015 05:35:30 -0700 In the SMP guest case, when the per-channel callback hvsock_events() is running on virtual CPU A, if the guest tries to close the connection on virtual CPU B: we invoke vmbus_close() - vmbus_close_internal(), then we

Re: [PATCH V4 6/7] hvsock: introduce Hyper-V VM Sockets feature

2015-07-29 Thread David Miller
From: Dexuan Cui de...@microsoft.com Date: Tue, 28 Jul 2015 05:35:23 -0700 +/* hvsock_release() can be invoked in 2 paths: + * 1. on process termination: + * hvsock_sk_destruct+0x1a/0x20 + * __sk_free+0x1d/0x130 + * sk_free+0x19/0x20 + * hvsock_release+0x138/0x160 + *

Re: IPsec maintenance during the next weeks

2015-07-29 Thread David Miller
From: Steffen Klassert steffen.klass...@secunet.com Date: Wed, 29 Jul 2015 12:47:20 +0200 On Tue, Jul 07, 2015 at 10:58:17PM -0700, David Miller wrote: From: Steffen Klassert steffen.klass...@secunet.com Date: Wed, 8 Jul 2015 07:04:32 +0200 I'll be off without mail access for the next two

[PATCH net-next v2 2/5] s390/bpf: Fix multiple macro expansions

2015-07-29 Thread Michael Holzheu
The EMIT6_DISP_LH macro passes the disp parameter to the _EMIT6_DISP_LH macro. The _EMIT6_DISP_LH macro uses the disp parameter twice: unsigned int __disp_h = ((u32)disp) 0xff000; unsigned int __disp_l = ((u32)disp) 0x00fff; The EMIT6_DISP_LH is used several times with EMIT_CONST_U64() as

[PATCH net-next v2 0/5] s390/bpf: recache skb-data/hlen for skb_vlan_push/pop

2015-07-29 Thread Michael Holzheu
Here the s390 backend for Alexei's patch 4e10df9a60d9 (bpf: introduce bpf_skb_vlan_push/pop() helpers) plus two bugfixes and two minor improvements. The first patch s390/bpf: clear correct BPF accumulator register will also go upstream via Martin's fixes branch. * v2: Integrated suggestions from

[PATCH net-next v2 3/5] s390/bpf: increase BPF_SIZE_MAX

2015-07-29 Thread Michael Holzheu
Currently we have the restriction that jitted BPF programs can have a maximum size of one page. The reason is that we use short displacements for the literal pool. The 20 bit displacements are available since z990 and BPF requires z196 as minimum. Therefore we can remove this restriction and use

[PATCH net-next v2 5/5] s390/bpf: recache skb-data/hlen for skb_vlan_push/pop

2015-07-29 Thread Michael Holzheu
Allow eBPF programs attached to TC qdiscs call skb_vlan_push/pop via helper functions. These functions may change skb-data/hlen. This data is cached by s390 JIT to improve performance of ld_abs/ld_ind instructions. Therefore after a change we have to reload the data. In case of usage of

[PATCH net-next v2 4/5] s390/bpf: Only clear A and X for converted BPF programs

2015-07-29 Thread Michael Holzheu
Only classic BPF programs that have been converted to eBPF need to clear the A and X registers. We can check for converted programs with: bpf_prog-type == BPF_PROG_TYPE_UNSPEC So add the check and skip initialization for real eBPF programs. Signed-off-by: Michael Holzheu

[PATCH net-next v2 1/5] s390/bpf: clear correct BPF accumulator register

2015-07-29 Thread Michael Holzheu
Currently we assumed the following BPF to eBPF register mapping: - BPF_REG_A - BPF_REG_7 - BPF_REG_X - BPF_REG_8 Unfortunately this mapping is wrong. The correct mapping is: - BPF_REG_A - BPF_REG_0 - BPF_REG_X - BPF_REG_7 So clear the correct registers and use the BPF_REG_A and BPF_REG_X

Re: [PATCH net-next v2 2/5] s390/bpf: Fix multiple macro expansions

2015-07-29 Thread Michael Holzheu
On Wed, 29 Jul 2015 11:31:25 -0700 (PDT) David Miller da...@davemloft.net wrote: Please, when updating patches in a series, always resubmit the entire series not just the patches you want to change. Thank you. Sure, I will do that. Sorry for the trouble! Michael -- To unsubscribe from

Re: [PATCH 0/2] igb/ixgbe: Fix ordering of SR-IOV teardown

2015-07-29 Thread David Miller
From: Alex Williamson alex.william...@redhat.com Date: Mon, 27 Jul 2015 17:18:28 -0600 When running a Windows 2012 R2 guest with a pair of VFs assigned through vfio-pci, we run into a problem trying to hot-unplug those VFs after the PF has unregistered the netdev. This is a common scenario

Re: [PATCH net-next] lwtunnel: Make lwtun_encaps[] static

2015-07-29 Thread roopa
On 7/29/15, 12:45 AM, Thomas Graf wrote: Any external user should use the registration API instead of accessing this directly. Cc: Roopa Prabhu ro...@cumulusnetworks.com Signed-off-by: Thomas Graf tg...@suug.ch Acked-by: Roopa Prabhu ro...@cumulusnetworks.com thanks. ---

Re: [PATCH] net: switchdev: restrict vid range abstraction

2015-07-29 Thread David Miller
From: Scott Feldman sfel...@gmail.com Date: Wed, 29 Jul 2015 00:31:44 -0700 Since the netlink request (for example vlan add) includes the range, I'm not seeing how we can response with success for the satisfied vlans in the range, and also respond with an error for the unsatisfied vlans in

Re: [PATCH 0/2] igb/ixgbe: Fix ordering of SR-IOV teardown

2015-07-29 Thread Alex Williamson
On Wed, 2015-07-29 at 12:16 -0700, David Miller wrote: From: Alex Williamson alex.william...@redhat.com Date: Mon, 27 Jul 2015 17:18:28 -0600 When running a Windows 2012 R2 guest with a pair of VFs assigned through vfio-pci, we run into a problem trying to hot-unplug those VFs after the

Re: [PATCH net-next 1/2] net: Set sk_txhash from a random number

2015-07-29 Thread Thomas Graf
On 07/29/15 at 08:58am, Tom Herbert wrote: The salient property of both sk_txhash and skb-hash is that they provide a uniform distribution over flows. It is incorrect to assume that either of these immutable during the lifetime of a flow, so yes this means that packets of a flow may go to

Re: [PATCH] net: switchdev: restrict vid range abstraction

2015-07-29 Thread Vivien Didelot
Hi Scott, David, On Jul 29, 2015, at 2:28 PM, David da...@davemloft.net wrote: From: Scott Feldman sfel...@gmail.com Date: Wed, 29 Jul 2015 00:31:44 -0700 Since the netlink request (for example vlan add) includes the range, I'm not seeing how we can response with success for the satisfied

Re: [PATCH net-next] openvswitch: Re-add CONFIG_OPENVSWITCH_VXLAN

2015-07-29 Thread Thomas Graf
On 07/29/15 at 12:05pm, Pravin Shelar wrote: On Wed, Jul 29, 2015 at 4:52 AM, Thomas Graf tg...@suug.ch wrote: This readds the config option CONFIG_OPENVSWITCH_VXLAN to avoid a hard dependency of OVS on VXLAN. It moves the VXLAN config compat code to vport-vxlan.c and allows compliation as

Re: [PATCH 1/2] net: Export __netdev_alloc_frag() to allow gfp_mask flags

2015-07-29 Thread Murali Karicheri
Eric, On 07/29/2015 12:31 PM, Eric Dumazet wrote: On Wed, 2015-07-29 at 11:10 -0400, WingMan Kwok wrote: This patch makes the function __netdev_alloc_frag() non-static and exports it so that drivers that need to specify additional flags, such as __GFP_DMA, can use it. The currently exported

bridge vlan range, kernel 4.1 : message truncated warning when too much vlans defined

2015-07-29 Thread Alexandre DERUMIER
Hi, I'm currently testing vlan range on bridge filtering with kernel 4.1. If I defined too much vlans, or too big vlan range, I have a warning message truncated, even if I'm using -c # bridge -c vlan Message truncated port vlan ids eth2 1 PVID Egress Untagged bond0 1 PVID Egress

Re: [PATCH net-next v2 2/5] s390/bpf: Fix multiple macro expansions

2015-07-29 Thread David Miller
Please, when updating patches in a series, always resubmit the entire series not just the patches you want to change. Thank you. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH net-next] openvswitch: Re-add CONFIG_OPENVSWITCH_VXLAN

2015-07-29 Thread Pravin Shelar
On Wed, Jul 29, 2015 at 4:52 AM, Thomas Graf tg...@suug.ch wrote: This readds the config option CONFIG_OPENVSWITCH_VXLAN to avoid a hard dependency of OVS on VXLAN. It moves the VXLAN config compat code to vport-vxlan.c and allows compliation as a module. Fixes: 614732eaa12d (openvswitch: Use

Re: [PATCH net-next 1/1] Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver

2015-07-29 Thread David Miller
From: woojung@microchip.com Date: Mon, 27 Jul 2015 19:59:30 + +static int lan78xx_read_stats(struct lan78xx_net *dev, + struct lan78xx_statstage *data) +{ + int ret = 0; + struct lan78xx_statstage *stats; + + BUG_ON(!dev); + BUG_ON(!data);

Re: [PATCH] net: switchdev: restrict vid range abstraction

2015-07-29 Thread David Miller
From: Vivien Didelot vivien.dide...@savoirfairelinux.com Date: Wed, 29 Jul 2015 15:14:05 -0400 (EDT) While a range might be convenient to a user, exposing it to drivers is likely to end up writing the same vid_begin to vid_end for loop. It is impossible not to expose this to the driver. We

Re: [PATCH v2 0/3] Add MDIO support to ThunderX NIC driver

2015-07-29 Thread David Miller
From: mohun...@gmail.com Date: Tue, 28 Jul 2015 15:12:10 -0700 This patch series adds MDIO support to ThunderX NIC driver by making use of existing mdio-octeon driver. In the process modified the mdio-octeon driver to work on both Octeon and ThunderX platforms. * From v1: - Removed

Re: [PATCH 0/3] net: netcp: bug fixes for dynamic module support

2015-07-29 Thread David Miller
From: Murali Karicheri m-kariche...@ti.com Date: Tue, 28 Jul 2015 18:20:11 -0400 This series fixes few bugs to allow keystone netcp modules to be dynamically loaded and removed. Currently it allows following sequence multiple times ... Series applied, thanks. -- To unsubscribe from this

Re: [PATCH net] net: sched: fix refcount imbalance in actions

2015-07-29 Thread Daniel Borkmann
On 07/30/2015 02:33 AM, Cong Wang wrote: ... diff --git a/net/sched/act_api.c b/net/sched/act_api.c index af427a3..bd63a39 100644 --- a/net/sched/act_api.c +++ b/net/sched/act_api.c @@ -53,8 +53,11 @@ int tcf_hash_release(struct tc_action *a, int bind) if (p) { if

Re: [net-next PATCH 0/3] Backwards-compatible noqueue in virtual interfaces

2015-07-29 Thread Cong Wang
On Wed, Jul 29, 2015 at 1:51 PM, Phil Sutter p...@nwl.cc wrote: This series is inspired by a patch sent[1] in from Jesper Brouer and the discussion it started. Basically it tries to provide a solution which is backwards compatible while still enabling the veth performance improvement by

Re: [PATCH net-next 1/1] tipc: fix bug in broadcast synch message create function

2015-07-29 Thread David Miller
From: Jon Maloy jon.ma...@ericsson.com Date: Wed, 29 Jul 2015 18:28:01 -0400 In commit d999297c3dbbe7fdd832f7fa4ec84301e170b3e6 (tipc: reduce locking scope during packet reception) we introduced a new function tipc_build_bcast_sync_msg(), which carries initial synchronization data between two

Re: [PATCH net] sctp: fix sockopt size check

2015-07-29 Thread David Miller
From: Marcelo Ricardo Leitner marcelo.leit...@gmail.com Date: Tue, 28 Jul 2015 11:16:23 -0300 The problem is not on being bigger than what we want, but on being smaller, as it causes read of invalid memory. Note that the struct changes on commit 7e8616d8e773 didn't affect

Re: [PATCH iproute2] bridge fdb: add 'use' option to set NTF_USE flag in fdb add requests

2015-07-29 Thread roopa
On 7/29/15, 2:26 PM, Roopa Prabhu wrote: From: Roopa Prabhu ro...@cumulusnetworks.com This is similar to command options corresponding to other NTF_* flags already exposed to the user space (examples self/master). Also updates bridge man page (The man page patch also includes a fix to the

Re: [RFC PATCH 1/1] net/ipv4: Enable flow-based ECMP

2015-07-29 Thread Richard Laing
On 07/30/2015 04:12 AM, Tom Herbert wrote: On Tue, Jul 28, 2015 at 11:11 PM, Michal Kubecek mkube...@suse.cz wrote: On Tue, Jul 28, 2015 at 09:20:02PM +, Richard Laing wrote: diff --git a/include/net/flow.h b/include/net/flow.h index 8109a15..d1d933d 100644 --- a/include/net/flow.h +++

Re: [net-next PATCH 2/2] drivers: net: cpsw: add separate napi for tx packet handling for performance improvment

2015-07-29 Thread Francois Romieu
Mugunthan V N mugunthan...@ti.com : On Wednesday 29 July 2015 04:00 AM, Francois Romieu wrote: Mugunthan V N mugunthan...@ti.com : On Tuesday 28 July 2015 02:52 AM, Francois Romieu wrote: [...] cpsw_ndo_stop calls napi_disable: you can remove netif_running. This netif_running check is

Re: [PATCH net] ebpf, x86: fix general protection fault when tail call is invoked

2015-07-29 Thread David Miller
From: Daniel Borkmann dan...@iogearbox.net Date: Tue, 28 Jul 2015 15:26:36 +0200 With eBPF JIT compiler enabled on x86_64, I was able to reliably trigger the following general protection fault out of an eBPF program with a simple tail call, f.e. tracex5 (or a stripped down version of it): ...

Re: Panic with demuxed ipv4 multicast udp sockets on 4.0.4

2015-07-29 Thread Gregory Hoggarth
Hi, My company has also started having what appears to be the same problem, since we upgraded our embedded system to linux kernel 3.16. I tried applying the suggested fix of READ_ONCE (and also had to add in the necessary code to compiler.h as 3.16 didn't have it) and unfortunately it did not

linux-next: manual merge of the net-next tree with the net tree

2015-07-29 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/bridge/br_multicast.c between commit: 544586f742b4 (bridge: mcast: give fast leave precedence over multicast router and querier) from the net tree and commit: 09cf0211f970 (bridge: mdb: fill state in

  1   2   >