[PATCH] usbnet: dereference after null check in usbnet_start_xmit() and __usbnet_read_cmd()

2015-08-19 Thread Vivek Kumar Bhagat
usbnet_start_xmit() - If info-tx_fixup is not defined by class driver, NULL check does not happen for skb pointer and leads to NULL dereference. __usbnet_read_cmd() - if data pointer is passed as NULL, memcpy will dereference NULL pointer. Signed-off-by: Vivek Kumar Bhagat

[RFC v2 1/3] iwlwifi: mvm: add real TSO implementation

2015-08-19 Thread Emmanuel Grumbach
The segmentation is done completely in software. The driver creates several MPDUs out of a single large send. Each MPDU is a newly allocated SKB. A page is allocated to create the headers that need to be duplicated (SNAP / IP / TCP). The WiFi header is in the header of the newly created SKBs.

[RFC v2 0/3] add TSO / A-MSDU TX for iwlwifi

2015-08-19 Thread Emmanuel Grumbach
We enable TSO to get a lot of data at once to build A-MSDUs. Our hardware doesn't have (yet) TCP CSUM offload, so we do it manually. TSO won't be enabled on hardware that don't support CSUM offload in release code, computing TCP CSUM in the driver is just a way to start coding the flows. This is

[RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

2015-08-19 Thread Emmanuel Grumbach
This allows to release the backpressure on the socket only when the last segment is released. Now the truesize looks like this: if the truesize of the original skb is 65420, all the segments will have a truesize of 704 (skb itself) and the last one will have 65420. Change-Id:

[RFC v2 2/3] iwlwifi: mvm: allow to create A-MSDUs from a large send

2015-08-19 Thread Emmanuel Grumbach
Now that we can get a big chunk of data from the network stack, we can create an A-MSDU out of it. The purpose is to get a throughput improvement since sending one single A-MSDU is more efficient than sending several MSDUs at least under ideal link conditions. type=feature Change-Id:

Re: [PATCH] usbnet: dereference after null check in usbnet_start_xmit() and __usbnet_read_cmd()

2015-08-19 Thread Bjørn Mork
Vivek Kumar Bhagat vivek.bha...@samsung.com writes: usbnet_start_xmit() - If info-tx_fixup is not defined by class driver, NULL check does not happen for skb pointer and leads to NULL dereference. __usbnet_read_cmd() - if data pointer is passed as NULL, memcpy will dereference NULL pointer.

Re: [PATCH] veth: replace iflink by a dedicated symlink in sysfs

2015-08-19 Thread Jiri Benc
On Wed, 19 Aug 2015 14:13:00 +0200, Vincent Bernat wrote: That's the main goal of this patch: advertising the peer link as IFLA_LINK attribute triggers an infinite loop in userland software when they follow iflink to discover network devices topology. iflink has always been the index of a

Re: [PATCH] veth: replace iflink by a dedicated symlink in sysfs

2015-08-19 Thread Vincent Bernat
❦ 19 août 2015 14:38 +0200, Jiri Benc jb...@redhat.com : That's the main goal of this patch: advertising the peer link as IFLA_LINK attribute triggers an infinite loop in userland software when they follow iflink to discover network devices topology. iflink has always been the index of a

Re: pull-request: wireless-drivers-next 2015-08-19

2015-08-19 Thread Kalle Valo
Kalle Valo kv...@codeaurora.org writes: here's one more pull request for 4.3. More info in the signed tag below. This time I had to merge mac80211-next.git due to some iwlwifi dependencies and apparently that broke git-request-pull's diffstat again, it was showing changes which were not

Re: [PATCH] r8169: Add values missing in @get_stats64 from HW counters

2015-08-19 Thread Corinna Vinschen
On Aug 19 09:31, Hayes Wang wrote: Corinna Vinschen [mailto:vinsc...@redhat.com] Sent: Wednesday, August 19, 2015 5:13 PM [...] It could be cleared by setting bit 0, such as rtl_tally_reset() of r8152. Is it safe to assume that this is implemented in all NICs covered by r8169? It

Re: [PATCH] rtlwifi: rtl8192cu: Add new device ID

2015-08-19 Thread Larry Finger
On 08/19/2015 08:51 AM, Adrien Schildknecht wrote: The v2 of NetGear WNA1000M uses a different idProduct: USB ID 0846:9043 Signed-off-by: Adrien Schildknecht adrien+...@schischi.me --- Has this ID been tested with the Netgear device? Larry drivers/net/wireless/rtlwifi/rtl8192cu/sw.c | 1

Telegrafische Überweisung HINWEIS

2015-08-19 Thread Standard Charterd Bank UAE
Standard Chartered Bank Dubai Main Branch, Al Fardan Gebäude, Al Mankhool Road, P.O. Box 999, Dubai, Vereinigte Arabische Emirate Sehr geehrte Kunden, Telegrafische Überweisung HINWEIS. Wir sind hiermit offiziell informieren Sie über Ihre Fondstelegrafische Überweisung durch unsere Bank,

[PATCH] rtlwifi: rtl8192cu: Add new device ID

2015-08-19 Thread Adrien Schildknecht
The v2 of NetGear WNA1000M uses a different idProduct: USB ID 0846:9043 Signed-off-by: Adrien Schildknecht adrien+...@schischi.me --- drivers/net/wireless/rtlwifi/rtl8192cu/sw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c

Re: [PATCH v2 1/2] virtio-net: rephrase devconf fields description

2015-08-19 Thread Victor Kaplansky
On Mon, Aug 17, 2015 at 10:43:46AM +0800, Jason Wang wrote: On 08/16/2015 09:42 PM, Victor Kaplansky wrote: Clarify general description of the mac, status and max_virtqueue_pairs fields. Specifically, the old description is vague about configuration layout and fields offsets when some

Re: [PATCH] usbnet: dereference after null check in usbnet_start_xmit() and __usbnet_read_cmd()

2015-08-19 Thread Bjørn Mork
Bjørn Mork bj...@mork.no writes: Vivek Kumar Bhagat vivek.bha...@samsung.com writes: @@ -1906,7 +1908,8 @@ static int __usbnet_read_cmd(struct usbnet *dev, u8 cmd, u8 reqtype, buf = kmalloc(size, GFP_KERNEL); if (!buf) goto out; -} +

Re: [RFC v2 1/3] iwlwifi: mvm: add real TSO implementation

2015-08-19 Thread Eric Dumazet
On Wed, 2015-08-19 at 15:59 +0300, Emmanuel Grumbach wrote: The segmentation is done completely in software. The driver creates several MPDUs out of a single large send. Each MPDU is a newly allocated SKB. A page is allocated to create the headers that need to be duplicated (SNAP / IP / TCP).

Re: [PATCH v2 2/2] virtio-net: add default_mtu configuration field

2015-08-19 Thread Victor Kaplansky
On Mon, Aug 17, 2015 at 11:07:15AM +0800, Jason Wang wrote: On 08/16/2015 09:42 PM, Victor Kaplansky wrote: @@ -3128,6 +3134,7 @@ struct virtio_net_config { u8 mac[6]; le16 status; le16 max_virtqueue_pairs; +le16 default_mtu; Looks like mtu is

Re: [PATCH] usbnet: Fix two races between usbnet_stop() and the BH

2015-08-19 Thread Eugene Shatokhin
19.08.2015 13:54, Bjørn Mork пишет: Eugene Shatokhin eugene.shatok...@rosalab.ru writes: 19.08.2015 04:54, David Miller пишет: From: Eugene Shatokhin eugene.shatok...@rosalab.ru Date: Fri, 14 Aug 2015 19:58:36 +0300 2. The second race is on dev-flags. dev-flags is set to 0 here: *0

Re: [PATCH] usbnet: Fix two races between usbnet_stop() and the BH

2015-08-19 Thread Bjørn Mork
Eugene Shatokhin eugene.shatok...@rosalab.ru writes: The problem is not in the reordering but rather in the fact that dev-flags = 0 is not necessarily atomic w.r.t. clear_bit(EVENT_RX_KILL, dev-flags), and vice versa. So the following might be possible, although unlikely: CPU0

Re: [PATCH ipsec-next] xfrm: Use VRF master index if output device is enslaved

2015-08-19 Thread Nikolay Aleksandrov
On Aug 18, 2015, at 6:54 PM, David Ahern d...@cumulusnetworks.com wrote: Directs route lookups to VRF table. Compiles out if NET_VRF is not enabled. With this patch able to successfully bring up ipsec tunnels in VRFs, even with duplicate network configuration (IPv4 tested).

Re: [PATCH net-next] r8169:Set RxConfig on same func. with TxConfig

2015-08-19 Thread Eric Dumazet
On Wed, 2015-08-19 at 08:39 +0300, Marian Corcodel wrote: It s not mandatory to accept these patches, if you wish to apply good if you not ,not problem. How can we apply a patch that does not compile ? You are going to piss all netdev people for good. -- To unsubscribe from this list: send

Re: [RFC v2 0/3] add TSO / A-MSDU TX for iwlwifi

2015-08-19 Thread Eric Dumazet
On Wed, 2015-08-19 at 15:59 +0300, Emmanuel Grumbach wrote: We could have enabled A-MSDU based on xmit-more, but the rationale of using LSO is that when using pfifo-fast, the Qdisc gets one packet and dequeues is straight away which limits the possibility to get a lot of packets at once. (Am

Re: [PATCHv1 net-next 0/5] netlink: mmap: kernel panic and some issues

2015-08-19 Thread Daniel Borkmann
On 08/17/2015 11:02 PM, David Miller wrote: From: Daniel Borkmann dan...@iogearbox.net Date: Fri, 14 Aug 2015 12:38:21 +0200 diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 67d2104..4307446 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -238,6

Clarification on rtnetlink requests

2015-08-19 Thread David Chappelle
I am a bit confused with respect to the structure of rtnetlink requests. It seems that in some circumstances a request can look like: struct request { struct nlmsghdr header; struct rtgenmsg body; }; and in other cases it can look like: struct request {

Re: [PATCH v2] rtlwifi: rtl8192cu: Add new device ID

2015-08-19 Thread Larry Finger
On 08/19/2015 10:33 AM, Adrien Schildknecht wrote: The v2 of NetGear WNA1000M uses a different idProduct: USB ID 0846:9043 Signed-off-by: Adrien Schildknecht adrien+...@schischi.me Cc: Stable sta...@vger.kernel.org --- drivers/net/wireless/rtlwifi/rtl8192cu/sw.c | 1 + 1 file changed, 1

Re: [PATCH v2 net-next 01/13] ip_tunnels: remove custom alignment and packing

2015-08-19 Thread Thomas Graf
On 08/19/15 at 12:09pm, Jiri Benc wrote: The custom alignment of struct ip_tunnel_key is unnecessary. In struct sw_flow_key, it starts at offset 256, in struct ip_tunnel_info it's the first field. The structure is also packed even without the __packed keyword. Signed-off-by: Jiri Benc

Re: [RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

2015-08-19 Thread Eric Dumazet
On Wed, 2015-08-19 at 15:59 +0300, Emmanuel Grumbach wrote: This allows to release the backpressure on the socket only when the last segment is released. Now the truesize looks like this: if the truesize of the original skb is 65420, all the segments will have a truesize of 704 (skb itself)

[PATCH net-next] vrf: plug skb leaks

2015-08-19 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov niko...@cumulusnetworks.com Currently whenever a packet different from ETH_P_IP is sent through the VRF device it is leaked so plug the leaks and properly drop these packets. Signed-off-by: Nikolay Aleksandrov niko...@cumulusnetworks.com --- drivers/net/vrf.c | 13

Re: inet_hashtables.c: warning: division by zero

2015-08-19 Thread Eric Dumazet
On Wed, 2015-08-19 at 18:24 +0300, Meelis Roos wrote: Noticed this while compiling 4.2-rc7+git on i386 with gcc 4.9.2: CC net/ipv4/inet_hashtables.o In file included from include/linux/list.h:8:0, from include/linux/module.h:9, from

Re: [RFC v2 1/3] iwlwifi: mvm: add real TSO implementation

2015-08-19 Thread Eric Dumazet
On Wed, 2015-08-19 at 07:17 -0700, Eric Dumazet wrote: On Wed, 2015-08-19 at 15:59 +0300, Emmanuel Grumbach wrote: The segmentation is done completely in software. The driver creates several MPDUs out of a single large send. Each MPDU is a newly allocated SKB. A page is allocated to

Re: [PATCH v2 net-next 02/13] ip_tunnels: use u8/u16/u32

2015-08-19 Thread Thomas Graf
On 08/19/15 at 12:09pm, Jiri Benc wrote: The ip_tunnels.h include file uses mixture of __u16 and u16 (etc.) types. Unify it to the non-underscore variants. Signed-off-by: Jiri Benc jb...@redhat.com Acked-by: Thomas Graf tg...@suug.ch -- To unsubscribe from this list: send the line

Re: [PATCH] r8169: Add values missing in @get_stats64 from HW counters

2015-08-19 Thread Corinna Vinschen
On Aug 19 15:07, Corinna Vinschen wrote: On Aug 19 09:31, Hayes Wang wrote: Corinna Vinschen [mailto:vinsc...@redhat.com] Sent: Wednesday, August 19, 2015 5:13 PM [...] It could be cleared by setting bit 0, such as rtl_tally_reset() of r8152. Is it safe to assume that this

Re: [RFC v2 0/3] add TSO / A-MSDU TX for iwlwifi

2015-08-19 Thread Grumbach, Emmanuel
Hi Eric, First, thank you a lot for your comments. On 08/19/2015 05:14 PM, Eric Dumazet wrote: On Wed, 2015-08-19 at 15:59 +0300, Emmanuel Grumbach wrote: We could have enabled A-MSDU based on xmit-more, but the rationale of using LSO is that when using pfifo-fast, the Qdisc gets one

Re: [RFC v2 0/3] add TSO / A-MSDU TX for iwlwifi

2015-08-19 Thread Eric Dumazet
On Wed, 2015-08-19 at 15:07 +, Grumbach, Emmanuel wrote: I'll look at it. I was almost starting to implement that but then I thought with another (good?) reason to use LSO. LSO gives me the guarantee that the packet is directed to one peer, which might not be the case with xmit_more since

Re: [PATCH] rtlwifi: rtl8192cu: Add new device ID

2015-08-19 Thread Adrien Schildknecht
Has this ID been tested with the Netgear device? Yes, I have been using the device and the patch for 2 days. -- Adrien Schildknecht -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH v2] rtlwifi: rtl8192cu: Add new device ID

2015-08-19 Thread Adrien Schildknecht
The v2 of NetGear WNA1000M uses a different idProduct: USB ID 0846:9043 Signed-off-by: Adrien Schildknecht adrien+...@schischi.me Cc: Stable sta...@vger.kernel.org --- drivers/net/wireless/rtlwifi/rtl8192cu/sw.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: Problem with fragmented packets on tun/tap interface

2015-08-19 Thread Eric Dumazet
On Wed, 2015-08-19 at 15:44 +0530, Prashant Upadhyaya wrote: Hi Eric, For some reason, the dropping in the raw table does not work for me for the usecase, though I recognize that the raw table operations theory, when matched with my usecase theory, is the apparent solution. I think the

inet_hashtables.c: warning: division by zero

2015-08-19 Thread Meelis Roos
Noticed this while compiling 4.2-rc7+git on i386 with gcc 4.9.2: CC net/ipv4/inet_hashtables.o In file included from include/linux/list.h:8:0, from include/linux/module.h:9, from net/ipv4/inet_hashtables.c:16: net/ipv4/inet_hashtables.c: In function

Re: [PATCH] rtlwifi: rtl8192cu: Add new device ID

2015-08-19 Thread Larry Finger
On 08/19/2015 08:51 AM, Adrien Schildknecht wrote: The v2 of NetGear WNA1000M uses a different idProduct: USB ID 0846:9043 Signed-off-by: Adrien Schildknecht adrien+...@schischi.me Add a Cc: Stable sta...@vger.kernel.org line here. That way the new ID will be available with older kernels.

[PATCH net-next 4/4] vrf: ndo_add|del_slave drop unnecessary checks

2015-08-19 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov niko...@cumulusnetworks.com When ndo_add|del_slave ops are used, they're taken from the respective master device's netdev ops, so if the master device is a VRF only then the VRF ops will get called thus no need to check the type of the master. Signed-off-by: Nikolay

[PATCH net-next 1/4] vrf: don't panic on cache create failure

2015-08-19 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov niko...@cumulusnetworks.com It's pointless to panic on cache create failure when that case is handled and even more so since it's not a kernel-wide fatal problem so don't panic. Signed-off-by: Nikolay Aleksandrov niko...@cumulusnetworks.com --- drivers/net/vrf.c | 2 +-

[PATCH net-next 3/4] vrf: move vrf_insert_slave so we can drop a goto label

2015-08-19 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov niko...@cumulusnetworks.com We can simplify do_vrf_add_slave by moving vrf_insert_slave in the end of the enslaving and thus eliminate an error goto label. It always succeeds and isn't needed before that anyway. Signed-off-by: Nikolay Aleksandrov

[PATCH net-next 0/4] vrf: cleanups part 2

2015-08-19 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov niko...@cumulusnetworks.com Hi, This is the next part of vrf cleanups, patch 1 drops the SLAB_PANIC when creating kmem cache since it's handled, patch 02 removes a slave duplicate check which is already done by the lower/upper code, patch 3 moves the ndo_add_slave code

[PATCH net-next 2/4] vrf: remove unnecessary duplicate check

2015-08-19 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov niko...@cumulusnetworks.com The upper/lower functions already check for duplicate slaves so no need to do it again. Signed-off-by: Nikolay Aleksandrov niko...@cumulusnetworks.com --- drivers/net/vrf.c | 8 1 file changed, 8 deletions(-) diff --git

Re: [PATCH v2 net-next 03/13] ip_tunnels: use offsetofend

2015-08-19 Thread Thomas Graf
On 08/19/15 at 12:09pm, Jiri Benc wrote: Signed-off-by: Jiri Benc jb...@redhat.com Acked-by: Thomas Graf tg...@suug.ch -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] veth: replace iflink by a dedicated symlink in sysfs

2015-08-19 Thread Nicolas Dichtel
Le 19/08/2015 14:48, Vincent Bernat a écrit : ❦ 19 août 2015 14:38 +0200, Jiri Benc jb...@redhat.com : That's the main goal of this patch: advertising the peer link as IFLA_LINK attribute triggers an infinite loop in userland software when they follow iflink to discover network devices

Re: [PATCH v2 net-next 08/13] ipv6: ndisc: inherit metadata dst when creating ndisc requests

2015-08-19 Thread Thomas Graf
On 08/19/15 at 12:09pm, Jiri Benc wrote: If output device wants to see the dst, inherit the dst of the original skb in the ndisc request. This is an IPv6 counterpart of commit 0accfc268f4d (arp: Inherit metadata dst when creating ARP requests). Signed-off-by: Jiri Benc jb...@redhat.com

Re: [PATCH net] sctp: donot reset the overall_error_count in SHUTDOWN_RECEIVE state

2015-08-19 Thread Marcelo Ricardo Leitner
On Wed, Aug 19, 2015 at 12:38:03PM +0800, Xin Long wrote: commit f8d960524 fix the 0 peer.rwnd issue in SHUTDOWN_PENING state through not reseting the overall_error_count when recevie a heartbeat, but the same issue also exists in SHUTDOWN_RECEIVE state. Please fix the typos on changelog,

Re: [PATCH net-next v2 7/9] geneve: Consolidate Geneve functionality in single module.

2015-08-19 Thread Pravin Shelar
On Wed, Aug 19, 2015 at 11:18 AM, Jesse Gross je...@nicira.com wrote: On Mon, Aug 17, 2015 at 2:11 PM, Pravin B Shelar pshe...@nicira.com wrote: diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index e58468b..18ff83b 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -181,7

Re: [PATCH v2 net-next 07/13] ipv6: drop metadata dst in ip6_route_input

2015-08-19 Thread Thomas Graf
On 08/19/15 at 12:09pm, Jiri Benc wrote: The fix in commit 48fb6b554501 is incomplete, as now ip6_route_input can be called with non-NULL dst if it's a metadata dst and the reference is leaked. Drop the reference. Fixes: 48fb6b554501 (ipv6: fix crash over flow-based vxlan device) Fixes:

Re: [PATCH v2 net-next 09/13] vxlan: provide access function for vxlan socket address family

2015-08-19 Thread Thomas Graf
On 08/19/15 at 12:09pm, Jiri Benc wrote: Signed-off-by: Jiri Benc jb...@redhat.com Acked-by: Thomas Graf tg...@suug.ch -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH net-next] bridge: fix netlink max attr size

2015-08-19 Thread sfeldma
From: Scott Feldman sfel...@gmail.com .maxtype should match .policy. Probably just been getting lucky here because IFLA_BRPORT_MAX IFLA_BR_MAX. Fixes: 13323516 (bridge: implement rtnl_link_ops-changelink) Signed-off-by: Scott Feldman sfel...@gmail.com --- net/bridge/br_netlink.c |2 +- 1

Re: [PATCH v2 net-next 06/13] route: move lwtunnel state to dst_entry

2015-08-19 Thread Thomas Graf
On 08/19/15 at 12:09pm, Jiri Benc wrote: Currently, the lwtunnel state resides in per-protocol data. This is a problem if we encapsulate ipv6 traffic in an ipv4 tunnel (or vice versa). The xmit function of the tunnel does not know whether the packet has been routed to it by ipv4 or ipv6, yet

[PATCH 0/2] Small cleanups for smsc and device property

2015-08-19 Thread Jeremy Linton
These patches are against net-next. This patch set adds a length check to device_get_mac_addr() before calling is_valid_ether_addr(), it also removes an unisssary dev==null check. The remainder is updates to the comments. Jeremy Linton (2): device property: Add ETH_ALEN check, update

[PATCH 1/2] device property: Add ETH_ALEN check, update comments.

2015-08-19 Thread Jeremy Linton
This patch adds MAC address length check back into the device_get_mac_addr() function before calling is_valid_ether_addr() similar to the way the OF routine does it. Update the comments for the two new functions. Signed-off-by: Jeremy Linton jeremy.lin...@arm.com --- drivers/base/property.c |

[PATCH 2/2] smsc911x: Remove dev==NULL check.

2015-08-19 Thread Jeremy Linton
The dev==NULL check in smsc911x_probe_config is useless and isn't providing any additional protection. If a fwnode doesn't exist then an appropriate error should be returned by device_get_phy_mode() covering the original case of a missing of/fwnode. Signed-off-by: Jeremy Linton

Re: [PATCH v2 net-next 05/13] ip_tunnels: use tos and ttl fields also for IPv6

2015-08-19 Thread Thomas Graf
On 08/19/15 at 12:09pm, Jiri Benc wrote: Rename the ipv4_tos and ipv4_ttl fields to just 'tos' and 'ttl', as they'll be used with IPv6 tunnels, too. Signed-off-by: Jiri Benc jb...@redhat.com Acked-by: Thomas Graf tg...@suug.ch -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH net] sctp: start t5 timer only when peer.rwnd == 0 and in SHUTDOWN_PENDING

2015-08-19 Thread Marcelo Ricardo Leitner
On Wed, Aug 19, 2015 at 12:39:06PM +0800, Xin Long wrote: when A send a data to B, A close() to be in SHUTDOWN_PENDING state, but B neither claim his rwnd is 0 nor SACK this data, then A keep retransmiting this data. it should send abord after Max.Retrans times, only when peer.rwnd == 0 and

Re: [RFC v2 0/3] add TSO / A-MSDU TX for iwlwifi

2015-08-19 Thread Grumbach, Emmanuel
On 08/19/2015 07:08 PM, Eric Dumazet wrote: On Wed, 2015-08-19 at 15:07 +, Grumbach, Emmanuel wrote: I'll look at it. I was almost starting to implement that but then I thought with another (good?) reason to use LSO. LSO gives me the guarantee that the packet is directed to one peer,

Re: [RFC v2 0/3] add TSO / A-MSDU TX for iwlwifi

2015-08-19 Thread Eric Dumazet
On Wed, 2015-08-19 at 17:00 +, Grumbach, Emmanuel wrote: On 08/19/2015 07:08 PM, Eric Dumazet wrote: On Wed, 2015-08-19 at 15:07 +, Grumbach, Emmanuel wrote: I'll look at it. I was almost starting to implement that but then I thought with another (good?) reason to use LSO.

Re: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-19 Thread Scott Feldman
On Wed, Aug 19, 2015 at 2:34 AM, Premkumar Jonnala pjonn...@broadcom.com wrote: Hello Scott, Thank you for the diff and comments. Please see my comments inline. -Original Message- From: Scott Feldman [mailto:sfel...@gmail.com] Sent: Tuesday, August 18, 2015 12:48 PM To: Premkumar

Re: [RFC v2 0/3] add TSO / A-MSDU TX for iwlwifi

2015-08-19 Thread Eric Dumazet
On Wed, 2015-08-19 at 17:56 +, Grumbach, Emmanuel wrote: So I feel that making net/core/tso.c more complicated just because of our craziness seems an overkill to me. I'll try a bit harder to see how I can use net/core/tso.c, but I have to say I am pessimistic. net/core/tso.c is WIP,

netlink_route kernel data dump size increased

2015-08-19 Thread tej parkash
All, We are running application on Linux Kernel 3.10 to collect network interface information using NETLINK_ROUTE protocol. earlier (kernel 2.6.32) we were having 8K buffer allocated to collect all data but with new kernel (3.10) we are seeing read socket error, as buffer size is not sufficient

Re: [PATCH v2 net-next 04/13] ip_tunnels: add IPv6 addresses to ip_tunnel_key

2015-08-19 Thread Thomas Graf
On 08/19/15 at 12:09pm, Jiri Benc wrote: Add the IPv6 addresses as an union with IPv4 ones. When using IPv4, the newly introduced padding after the IPv4 addresses needs to be zeroed out. Signed-off-by: Jiri Benc jb...@redhat.com --- v1-v2: Fix incorrect IP_TUNNEL_KEY_IPV4_PAD_LEN

Re: [RFC v2 0/3] add TSO / A-MSDU TX for iwlwifi

2015-08-19 Thread Grumbach, Emmanuel
On 08/19/2015 09:02 PM, Eric Dumazet wrote: On Wed, 2015-08-19 at 17:56 +, Grumbach, Emmanuel wrote: So I feel that making net/core/tso.c more complicated just because of our craziness seems an overkill to me. I'll try a bit harder to see how I can use net/core/tso.c, but I have to

Re: [RFC v2 1/3] iwlwifi: mvm: add real TSO implementation

2015-08-19 Thread Grumbach, Emmanuel
On 08/19/2015 05:18 PM, Eric Dumazet wrote: On Wed, 2015-08-19 at 15:59 +0300, Emmanuel Grumbach wrote: The segmentation is done completely in software. The driver creates several MPDUs out of a single large send. Each MPDU is a newly allocated SKB. A page is allocated to create the headers

Re: [PATCH net-next] vrf: plug skb leaks

2015-08-19 Thread David Ahern
Hi Nikolay: On 8/18/15 8:12 PM, Nikolay Aleksandrov wrote: diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index ed208317cbb5..4aa06450fafa 100644 --- a/drivers/net/vrf.c +++ b/drivers/net/vrf.c @@ -97,6 +97,12 @@ static bool is_ip_rx_frame(struct sk_buff *skb) return false; }

Re: [PATCH net-next 0/4] vrf: cleanups part 2

2015-08-19 Thread David Ahern
On 8/18/15 8:27 PM, Nikolay Aleksandrov wrote: From: Nikolay Aleksandrov niko...@cumulusnetworks.com Hi, This is the next part of vrf cleanups, patch 1 drops the SLAB_PANIC when creating kmem cache since it's handled, patch 02 removes a slave duplicate check which is already done by the

Re: [RFC v2 0/3] add TSO / A-MSDU TX for iwlwifi

2015-08-19 Thread Grumbach, Emmanuel
On 08/19/2015 08:20 PM, Eric Dumazet wrote: On Wed, 2015-08-19 at 17:00 +, Grumbach, Emmanuel wrote: On 08/19/2015 07:08 PM, Eric Dumazet wrote: On Wed, 2015-08-19 at 15:07 +, Grumbach, Emmanuel wrote: I'll look at it. I was almost starting to implement that but then I thought

RE: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-19 Thread Wilson, Daniel G
-Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of Scott Feldman Sent: Wednesday, August 19, 2015 12:54 PM To: Premkumar Jonnala Cc: netdev@vger.kernel.org Subject: Re: [PATCH] bridge: Enable configuration of ageing interval for

Re: [PATCH net-next v2 7/9] geneve: Consolidate Geneve functionality in single module.

2015-08-19 Thread Jesse Gross
On Mon, Aug 17, 2015 at 2:11 PM, Pravin B Shelar pshe...@nicira.com wrote: diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index e58468b..18ff83b 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -181,7 +181,7 @@ config VXLAN config GENEVE tristate Generic

[PATCH 02/15] netfilter: xt_TEE: get rid of WITH_CONNTRACK definition

2015-08-19 Thread Pablo Neira Ayuso
Use IS_ENABLED(CONFIG_NF_CONNTRACK) instead. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/xt_TEE.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/net/netfilter/xt_TEE.c b/net/netfilter/xt_TEE.c index c5d6556..0ed9fb6 100644 ---

[PATCH 10/15] netfilter: nft_limit: add per-byte limiting

2015-08-19 Thread Pablo Neira Ayuso
This patch adds a new NFTA_LIMIT_TYPE netlink attribute to indicate the type of limiting. Contrary to per-packet limiting, the cost is calculated from the packet path since this depends on the packet length. The burst attribute indicates the number of bytes in which the rate can be exceeded.

[PATCH 14/15] netfilter: nf_conntrack: add efficient mark to zone mapping

2015-08-19 Thread Pablo Neira Ayuso
From: Daniel Borkmann dan...@iogearbox.net This work adds the possibility of deriving the zone id from the skb-mark field in a scalable manner. This allows for having only a single template serving hundreds/thousands of different zones, for example, instead of the need to have one match for each

[PATCH 03/15] netfilter: factor out packet duplication for IPv4/IPv6

2015-08-19 Thread Pablo Neira Ayuso
Extracted from the xtables TEE target. This creates two new modules for IPv4 and IPv6 that are shared between the TEE target and the new nf_tables dup expressions. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- include/net/netfilter/ipv4/nf_dup_ipv4.h |7 ++

[PATCH 01/15] netfilter: nft_counter: convert it to use per-cpu counters

2015-08-19 Thread Pablo Neira Ayuso
This patch converts the existing seqlock to per-cpu counters. Suggested-by: Eric Dumazet eric.duma...@gmail.com Suggested-by: Patrick McHardy ka...@trash.net Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/nft_counter.c | 97 ++- 1

Re: [PATCH net-next v2 9/9] geneve: Implement rtnl changelink

2015-08-19 Thread Pravin Shelar
On Wed, Aug 19, 2015 at 12:40 PM, Jesse Gross je...@nicira.com wrote: On Mon, Aug 17, 2015 at 2:11 PM, Pravin B Shelar pshe...@nicira.com wrote: diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index e47cdd9..0d7fbef 100644 --- a/drivers/net/geneve.c +++ b/drivers/net/geneve.c

Re: [RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

2015-08-19 Thread Eric Dumazet
On Wed, 2015-08-19 at 19:17 +, Grumbach, Emmanuel wrote: Hm.. how would net/core/tso.c avoid this? Because a driver using these helpers keep around the original LSO packet and frees it normally at TX completion time. I can't see anything related to truesize there. Note that this work

Re: [PATCH net-next v2 7/9] geneve: Consolidate Geneve functionality in single module.

2015-08-19 Thread Pravin Shelar
On Wed, Aug 19, 2015 at 11:37 AM, Jesse Gross je...@nicira.com wrote: On Wed, Aug 19, 2015 at 11:29 AM, Pravin Shelar pshe...@nicira.com wrote: On Wed, Aug 19, 2015 at 11:18 AM, Jesse Gross je...@nicira.com wrote: My guess is that if the issue from the earlier patch about overlapping

Re: [PATCH v2 net-next 11/13] vxlan: metadata based tunneling for IPv6

2015-08-19 Thread Alexei Starovoitov
On Wed, Aug 19, 2015 at 12:10:01PM +0200, Jiri Benc wrote: Support metadata based (formerly flow based) tunneling also for IPv6. This complements commit ee122c79d422 (vxlan: Flow based tunneling). Signed-off-by: Jiri Benc jb...@redhat.com --- drivers/net/vxlan.c | 69

[PATCH 07/15] netfilter: nft_limit: factor out shared code with per-byte limiting

2015-08-19 Thread Pablo Neira Ayuso
This patch prepares the introduction of per-byte limiting. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/nft_limit.c | 86 - 1 file changed, 53 insertions(+), 33 deletions(-) diff --git a/net/netfilter/nft_limit.c

[PATCH 11/15] netfilter: nfacct: per network namespace support

2015-08-19 Thread Pablo Neira Ayuso
From: Andreas Schultz aschu...@tpip.net - Move the nfnl_acct_list into the network namespace, initialize and destroy it per namespace - Keep track of refcnt on nfacct objects, the old logic does not longer work with a per namespace list - Adjust xt_nfacct to pass the namespace when registring

[PATCH 13/15] netfilter: nf_conntrack: add direction support for zones

2015-08-19 Thread Pablo Neira Ayuso
From: Daniel Borkmann dan...@iogearbox.net This work adds a direction parameter to netfilter zones, so identity separation can be performed only in original/reply or both directions (default). This basically opens up the possibility of doing NAT with conflicting IP address/port tuples from

[PATCH 12/15] netfilter: nf_conntrack: push zone object into functions

2015-08-19 Thread Pablo Neira Ayuso
From: Daniel Borkmann dan...@iogearbox.net This patch replaces the zone id which is pushed down into functions with the actual zone object. It's a bigger one-time change, but needed for later on extending zones with a direction parameter, and thus decoupling this additional information from all

[PATCH 00/15] Netfilter updates for net-next

2015-08-19 Thread Pablo Neira Ayuso
Hi David, The following patchset contains Netfilter updates for your net-next tree, they are: 1) Rework the existing nf_tables counter expression to make it per-cpu. 2) Prepare and factor out common packet duplication code from the TEE target so it can be reused from the new dup expression.

[PATCH 06/15] netfilter: nft_limit: convert to token-based limiting at nanosecond granularity

2015-08-19 Thread Pablo Neira Ayuso
Rework the limit expression to use a token-based limiting approach that refills the bucket gradually. The tokens are calculated at nanosecond granularity instead jiffies to improve precision. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/nft_limit.c | 42

[PATCH 04/15] netfilter: nf_tables: add nft_dup expression

2015-08-19 Thread Pablo Neira Ayuso
This new expression uses the nf_dup engine to clone packets to a given gateway. Unlike xt_TEE, we use an index to indicate output interface which should be fine at this stage. Moreover, change to the preemtion-safe this_cpu_read(nf_skb_duplicated) from nf_dup_ipv{4,6} to silence a lockdep splat.

[PATCH 15/15] netfilter: nft_payload: work around vlan header stripping

2015-08-19 Thread Pablo Neira Ayuso
From: Florian Westphal f...@strlen.de make payload expression aware of the fact that VLAN offload may have removed a vlan header. When we encounter tagged skb, transparently insert the tag into the register so that vlan header matching can work without userspace being aware of offload features.

[PATCH 05/15] netfilter: nft_limit: rename to nft_limit_pkts

2015-08-19 Thread Pablo Neira Ayuso
To prepare introduction of bytes ratelimit support. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/nft_limit.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/netfilter/nft_limit.c b/net/netfilter/nft_limit.c index 435c1cc..d0788e1

Re: [PATCH net-next v2 9/9] geneve: Implement rtnl changelink

2015-08-19 Thread Jesse Gross
On Mon, Aug 17, 2015 at 2:11 PM, Pravin B Shelar pshe...@nicira.com wrote: diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index e47cdd9..0d7fbef 100644 --- a/drivers/net/geneve.c +++ b/drivers/net/geneve.c -static int geneve_configure(struct net *net, struct net_device *dev, -

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

2015-08-19 Thread Scott Feldman
On Tue, Aug 18, 2015 at 1:47 PM, David Miller da...@davemloft.net wrote: From: Scott Feldman sfel...@gmail.com Date: Tue, 18 Aug 2015 13:37:56 -0700 Hi Scott David is not so keen no debugfs stuff. He already NACKed adding more than what is currently in DSA:

[PATCH net-next] 3c59x: Add BQL support for 3c59x ethernet driver.

2015-08-19 Thread Loganaden Velvindron
--- drivers/net/ethernet/3com/3c59x.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/3com/3c59x.c b/drivers/net/ethernet/3com/3c59x.c index 753887d..2839af0 100644 --- a/drivers/net/ethernet/3com/3c59x.c +++

Re: linux-next: unregister_netdevice: waiting for lo to become free. Usage count = 1

2015-08-19 Thread Andrey Wagin
2015-08-18 18:27 GMT+03:00 David Ahern d...@cumulusnetworks.com: On 8/18/15 9:24 AM, Andrey Wagin wrote: Hello David, CRIU tests detetect that references on net devices leak on 4.2.0-rc6-next-20150817. Looks like it started with v4.2-rc6-882-g3bfd847.

Re: [PATCH 20/21] net: warn if drivers set tx_queue_len = 0

2015-08-19 Thread Eric Dumazet
On Wed, 2015-08-19 at 13:31 -0700, Eric Dumazet wrote: lpaa5:~# tc qd sh dev eth1 qdisc mq 0: root qdisc fq 0: parent :4 limit 1p flow_limit 1000p buckets 1024 bands 3 priomap 1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1 quantum 3028 initial_quantum 15140 qdisc fq 0: parent :3 limit 1p

Re: [PATCH v2 net-next 10/13] vxlan: do not shadow flags variable

2015-08-19 Thread Thomas Graf
On 08/19/15 at 12:10pm, Jiri Benc wrote: The 'flags' variable is already defined in the outer scope. Signed-off-by: Jiri Benc jb...@redhat.com Acked-by: Thomas Graf tg...@suug.ch -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH v2 net-next 04/13] ip_tunnels: add IPv6 addresses to ip_tunnel_key

2015-08-19 Thread Alexei Starovoitov
On Wed, Aug 19, 2015 at 12:09:54PM +0200, Jiri Benc wrote: Add the IPv6 addresses as an union with IPv4 ones. When using IPv4, the newly introduced padding after the IPv4 addresses needs to be zeroed out. Signed-off-by: Jiri Benc jb...@redhat.com --- v1-v2: Fix incorrect

RE: Clarification on rtnetlink requests

2015-08-19 Thread Anish Bhatt
-Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev- ow...@vger.kernel.org] On Behalf Of David Chappelle Sent: Wednesday, August 19, 2015 8:05 AM To: netdev@vger.kernel.org Subject: Clarification on rtnetlink requests I am a bit confused with respect to the

Re: [RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

2015-08-19 Thread Sergei Shtylyov
Hello. On 08/19/2015 03:59 PM, Emmanuel Grumbach wrote: This allows to release the backpressure on the socket only when the last segment is released. Now the truesize looks like this: if the truesize of the original skb is 65420, all the segments will have a truesize of 704 (skb itself) and

Re: [RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

2015-08-19 Thread Grumbach, Emmanuel
On 08/19/2015 05:24 PM, Eric Dumazet wrote: On Wed, 2015-08-19 at 15:59 +0300, Emmanuel Grumbach wrote: This allows to release the backpressure on the socket only when the last segment is released. Now the truesize looks like this: if the truesize of the original skb is 65420, all the

Re: [PATCH net-next v2 7/9] geneve: Consolidate Geneve functionality in single module.

2015-08-19 Thread Jesse Gross
On Wed, Aug 19, 2015 at 11:49 AM, Pravin Shelar pshe...@nicira.com wrote: On Wed, Aug 19, 2015 at 11:37 AM, Jesse Gross je...@nicira.com wrote: On Wed, Aug 19, 2015 at 11:29 AM, Pravin Shelar pshe...@nicira.com wrote: On Wed, Aug 19, 2015 at 11:18 AM, Jesse Gross je...@nicira.com wrote: My

  1   2   3   >