Re: [PATCH net 3/3] r8169: increase the lifespan of the hardware counters dump area.

From: Francois Romieu Date: Sun, 6 Sep 2015 22:21:53 +0200 > Corinna Vinschen : >> On Sep 5 14:18, rom...@fr.zoreil.com wrote: > [...] >> > - rtl_reset_counters_cond induced failures in open() are also considered >> > fatal: it takes acceptable work

Re: [RFC PATCH 1/3] net: introduce kfree_skb_bulk() user of kmem_cache_free_bulk()

On Fri, 4 Sep 2015 11:47:17 -0700 Tom Herbert wrote: > On Fri, Sep 4, 2015 at 10:00 AM, Jesper Dangaard Brouer > wrote: > > Introduce the first user of SLAB bulk free API kmem_cache_free_bulk(), > > in the network stack in form of function

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

On Sep 7 09:13, poma wrote: > On 06.09.2015 12:19, Corinna Vinschen wrote: > > On Sep 4 22:59, Francois Romieu wrote: > >> Applies against davem's net as of > >> f1ccbfce2fc787981d1182d09c1f6b67766783a8. > >> > >> drivers/net/ethernet/realtek/r8169.c | 2 +- > >> 1 file changed, 1

Re: [RFC PATCH 0/3] Network stack, first user of SLAB/kmem_cache bulk free API.

On Fri, 4 Sep 2015 11:09:21 -0700 Alexander Duyck wrote: > This is an interesting start. However I feel like it might work better > if you were to create a per-cpu pool for skbs that could be freed and > allocated in NAPI context. So for example we already have >

RE: [PATCH] net: tipc: fix stall during bclink wakeup procedure

If an attempt to wake up users of broadcast link is made when there is no enough place in send queue than it may hang up inside the tipc_sk_rcv() function since the loop breaks only after the wake up queue becomes empty. This can lead to complete CPU stall with the following message generated by

Re: slab-nomerge (was Re: [git pull] device mapper changes for 4.3)

On Thu, 3 Sep 2015 20:51:09 -0700 Linus Torvalds wrote: > On Thu, Sep 3, 2015 at 8:26 PM, Dave Chinner wrote: > > > > The double standard is the problem here. No notification, proof, > > discussion or review was needed to turn on slab

Re: [PATCH net 3/3] r8169: increase the lifespan of the hardware counters dump area.

On Sep 6 22:21, Francois Romieu wrote: > Corinna Vinschen : > > On Sep 5 14:18, rom...@fr.zoreil.com wrote: > [...] > > > - rtl_reset_counters_cond induced failures in open() are also considered > > > fatal: it takes acceptable work to unwind comfortably. > > > > Why? >

Re: [PATCH net] openvswitch: Remove conntrack Kconfig option.

From: Joe Stringer Date: Fri, 4 Sep 2015 13:07:40 -0700 > There's no particular desire to have conntrack action support in Open > vSwitch as an independently configurable bit, rather just to ensure > there is not a hard dependency. This exposed option doesn't accurately

Re: [PATCH] fixed_phy: pass 'irq' to fixed_phy_add()

From: Sergei Shtylyov Date: Thu, 03 Sep 2015 23:22:16 +0300 > I've noticed that fixed_phy_register() ignores its 'irq' parameter instead of > passing it to fixed_phy_add(). Luckily, fixed_phy_register() seems to always > be called with PHY_POLL for

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

On 06.09.2015 12:19, Corinna Vinschen wrote: > On Sep 4 22:59, Francois Romieu wrote: >> net/core/net-sysfs.c::netstat_show fetches statistics under dev_base_lock. >> >> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=104031 >> Fixes: 6e85d5ad36a2 ("r8169: Add values missing in @get_stats64

[net-next PATCH v3] drivers: net: cpsw: Add support to drive gpios for ethernet to be functional

In DRA72x EVM, by default slave 1 is connected to the onboard phy, but slave 2 pins are also muxed with video input module which is controlled by pcf857x gpio and currently to select slave 0 to connect to phy gpio hogging is used, but with omap2plus_defconfig the pcf857x gpio is built as module.

RE: [GIT] Networking

From: Rustad, Mark D ... > >> static int smp_ah(struct crypto_blkcipher *tfm, const u8 irk[16], > >> const u8 r[3], u8 res[3]) > > > > Expect that it looks like you are passing arrays by value, > > but instead you are passing by reference. > > > > Explicitly pass by reference and

[PATCH net] cxgb4: Changes for new firmware 1.14.4.0

Incorporate fw_ldst_cmd structure change for new firmware and also update version string for the same Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h | 33 +-- drivers/net/ethernet/chelsio/cxgb4/t4fw_version.h |

Re: [PATCH] x86: Wire up 32-bit direct socket calls

On Wednesday 02 September 2015 13:16:19 H. Peter Anvin wrote: > On 09/02/2015 02:48 AM, Geert Uytterhoeven wrote: > > > > Should all other architectures follow suit? > > Or should we follow the s390 approach: > > > > It is up to the maintainer(s), largely dependent on how likely you are > going

Re: [PATCH net v3] ipv6: fix multipath route replace error recovery

Le 06/09/2015 22:46, Roopa Prabhu a écrit : From: Roopa Prabhu I've sent you some comments about the v2, so please keep me in CC for the next versions. Problem: The ecmp route replace support for ipv6 in the kernel, deletes the existing ecmp route too early, ie

Re: IPv6 xfrm GSO fragmentation bug

On Fri, Sep 04, 2015 at 01:21:06PM +0800, Herbert Xu wrote: > On Mon, Aug 31, 2015 at 03:35:26PM +0800, Herbert Xu wrote: > > > > I see where the bug came from. Indeed IPv6 does do fragmentation > > but only for tunnel mode. While your patch added a check that also > > affected transport mode.

Re: [PATCH] ip link/addr show: add empty line between interfaces

On Sun, 6 Sep 2015 13:01:09 +0200, Felix Kaiser wrote: > This improves the readability of the output. Or makes the readability worse by requiring more scrolling, depending on number of interfaces you have and your taste. Many users prefer the current format. Also, as sad as it is, there are

Re: [PATCH net-next v2] ipv6: fix multipath route replace error recovery

+ Michal Kubecek Le 06/09/2015 22:46, roopa a écrit : On 9/4/15, 1:12 AM, Nicolas Dichtel wrote: Le 03/09/2015 01:44, Roopa Prabhu a écrit : [snip] Fixes: 4a287eba2de3 ("IPv6 routing, NLM_F_* flag support: REPLACE and EXCL flags support, warn about missing CREATE flag") ECMP was added one

Re: [PATCH net 3/3] r8169: increase the lifespan of the hardware counters dump area.

On Sep 6 12:37, Corinna Vinschen wrote: > On Sep 5 14:18, rom...@fr.zoreil.com wrote: > > From: Francois Romieu > > > > net/core/net-sysfs.c::netstat_show retrieves stats with spinlock held. > > > > This change avoids sleepable allocation and performs some housekeeping:

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

On 07.09.2015 10:50, Corinna Vinschen wrote: > On Sep 7 09:13, poma wrote: >> On 06.09.2015 12:19, Corinna Vinschen wrote: >>> On Sep 4 22:59, Francois Romieu wrote: Applies against davem's net as of f1ccbfce2fc787981d1182d09c1f6b67766783a8.

Re: [PATCHv1 net-next 0/5] netlink: mmap: kernel panic and some issues

On 08/17/2015 11:02 PM, David Miller wrote: ... I would seriously rather see us do an expensive full copy of the SKB than to have traffic which is unexpectedly invisible to taps. I've been looking into this issue a bit further, so the copy for the tap seems doable, but while further going

Re: [RFC PATCH 1/3] net: introduce kfree_skb_bulk() user of kmem_cache_free_bulk()

>> What not pass a list of skbs (e.g. using skb->next)? > > Because the next layer, the slab API needs an array: > kmem_cache_free_bulk(struct kmem_cache *s, size_t size, void **p) > I suppose we could ask the same question of that function. IMO encouraging drivers to define arrays of pointers

Re: [PATCH] ip link/addr show: add empty line between interfaces

Excerpts from Jiri Benc's message of 2015-09-07 14:46:09 +0200: > Or makes the readability worse by requiring more scrolling, depending > on number of interfaces you have and your taste. Of course it's slightly subjective, but I think it improves readability quite a bit *especially* on servers

[PATCH v4 01/20] net/xen-netback: xenvif_gop_frag_copy: move GSO check out of the loop

The skb doesn't change within the function. Therefore it's only necessary to check if we need GSO once at the beginning. Signed-off-by: Julien Grall Acked-by: Wei Liu --- Cc: Ian Campbell Cc: netdev@vger.kernel.org

[PATCH v4 17/20] net/xen-netfront: Make it running on 64KB page granularity

The PV network protocol is using 4KB page granularity. The goal of this patch is to allow a Linux using 64KB page granularity using network device on a non-modified Xen. It's only necessary to adapt the ring size and break skb data in small chunk of 4KB. The rest of the code is relying on the

[PATCH v4 18/20] net/xen-netback: Make it running on 64KB page granularity

The PV network protocol is using 4KB page granularity. The goal of this patch is to allow a Linux using 64KB page granularity working as a network backend on a non-modified Xen. It's only necessary to adapt the ring size and break skb data in small chunk of 4KB. The rest of the code is relying on

Re: [PATCH] ip link/addr show: add empty line between interfaces

On Mon, 07 Sep 2015 17:38:48 +0200, Felix Kaiser wrote: > My opinion is that if someone parses that, they deserve the opportunity > to fix their code. At the very least they could have used -oneline! No doubt. I also don't like scripts that parse the default "ip a" output. I just pointed out

[PATCH v2] 9p: trans_fd, bail out if recv fcall if missing

req->rc is pre-allocated early on with p9_tag_alloc and shouldn't be missing Signed-off-by: Dominique Martinet --- net/9p/trans_fd.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) Feel free to adapt error code/message if you can think of

[PATCH] ath6kl: remove redundant null pointer check on send_pkt

From: Colin Ian King The check for send_pkt being NULL is redundant before the call to htc_reclaim_txctrl_buf, therefore it should be removed. This was detected by static analysis by cppcheck. Signed-off-by: Colin Ian King ---

Re: [V9fs-developer] [PATCH] 9p: trans_fd, initialize recv fcall properly if not set

I thought the nature of trans_fd would have prevented any sort of true zero copy, but I suppose one less is always welcome :) -eric On Sun, Sep 6, 2015 at 1:55 AM, Dominique Martinet wrote: > Eric Van Hensbergen wrote on Sat, Sep 05, 2015: >> On Thu, Sep 3,

Re: [PATCH v4 18/20] net/xen-netback: Make it running on 64KB page granularity

You might need to rebase you patch. A patch to netback went it recently. On Mon, Sep 07, 2015 at 04:33:56PM +0100, Julien Grall wrote: > The PV network protocol is using 4KB page granularity. The goal of this > patch is to allow a Linux using 64KB page granularity working as a > network backend

Fw: [Bug 104161] New: DLNA services disappear on bridge device shortly after starting the dlna service

Begin forwarded message: Date: Mon, 7 Sep 2015 13:31:54 + From: "bugzilla-dae...@bugzilla.kernel.org" To: "shemmin...@linux-foundation.org" Subject: [Bug 104161] New: DLNA services disappear on bridge device shortly

Re: [PATCH] iproute: print more verbose error on route cache flush

On Sat, 5 Sep 2015 10:40:50 +0300 Denis Kirjanov wrote: > Before: > kda@vfirst ~/devel/iproute2 $ ./ip/ip route flush cache > Cannot open "/proc/sys/net/ipv4/route/flush" > > After: > kda@vfirst ~/devel/iproute2/ip $ ./ip route flush cache > Cannot open

[PATCH] stmmac: fix check for phydev being open

Current implementation via IS_ERR(phydev) may make no sense because of_phy_attach() returns NULL on failure instead of error value. Still for checking result of phy_connect() IS_ERR() is useful. So adding explicit check for NULL. Cc: Giuseppe Cavallaro Cc:

Re: [PATCH] stmmac: fix check for phydev being open

Hello. On 09/07/2015 09:15 PM, Alexey Brodkin wrote: Current implementation via IS_ERR(phydev) may make no sense because of_phy_attach() returns NULL on failure instead of error value. Still for checking result of phy_connect() IS_ERR() is useful. So adding explicit check for NULL.

Re: [PATCH] ip link/addr show: add empty line between interfaces

On Mon, 7 Sep 2015 17:54:11 +0200 Jiri Benc wrote: > On Mon, 07 Sep 2015 17:38:48 +0200, Felix Kaiser wrote: > > My opinion is that if someone parses that, they deserve the opportunity > > to fix their code. At the very least they could have used -oneline! > > No doubt. I also

Re: [PATCH net 3/3] r8169: increase the lifespan of the hardware counters dump area.

Francois Romieu : [...] > Updated patch is on the way. Fixed memcpy in patch 0001, moved counters allocation from open() to probe(), returned open() to its original state but something is still wrong: the link does not come up. Patches attached. I'll try again tomorrow.

Re: parsing the output of ethtool programmatically

On 9/5/15, 2:53 AM, Ben Hutchings wrote: On Thu, 2015-06-25 at 03:28 +0200, Robert Urban wrote: Hello, there doesn't seem to be any flag to request ethtool to present its output in a script-friendly form. Things like: Link partner advertised link modes: 10baseT/Half 10baseT/Full

Re: [PATCH net 3/3] r8169: increase the lifespan of the hardware counters dump area.

Corinna Vinschen : [...] > I have a bit of a problem with this patch. It crashes when loading the > driver manually w/ modprobe. For some reason dev_get_stats is called > during rtl_init_one and at that time the counters pointer is NULL, so > the kernel gets a SEGV. > >

Re: [PATCH net 3/3] r8169: increase the lifespan of the hardware counters dump area.

From: Corinna Vinschen Date: Mon, 7 Sep 2015 11:29:49 +0200 > Still wondering though. Given that the driver never failed before if > the counter values couldn't be updated, and given that these counter > values only have statistical relevance, why should this suddenly

Re: [PATCH net-next v2] ipv6: fix multipath route replace error recovery

On 9/7/15, 5:03 AM, Nicolas Dichtel wrote: The bug you're trying to fix has been introduced by the commit 51ebd3181572 ("ipv6: add support of equal cost multipath (ECMP)"). Commit 27596472473a ("ipv6: fix ECMP route replacement") didn't try to fix this problem. The reason I say "27596472473a

Re: [PATCH net v3] ipv6: fix multipath route replace error recovery

On 9/6/15, 1:46 PM, Roopa Prabhu wrote: From: Roopa Prabhu Problem: The ecmp route replace support for ipv6 in the kernel, deletes the existing ecmp route too early, ie when it installs the first nexthop. If there is an error in installing the subsequent nexthops,

Re: [PATCH net v3] ipv6: fix multipath route replace error recovery

On 9/7/15, 5:37 AM, Nicolas Dichtel wrote: Le 06/09/2015 22:46, Roopa Prabhu a écrit : From: Roopa Prabhu I've sent you some comments about the v2, so please keep me in CC for the next versions. Problem: The ecmp route replace support for ipv6 in the kernel,

[PATCH v2] stmmac: fix check for phydev being open

Current implementation via IS_ERR(phydev) may make no sense because of_phy_attach() returns NULL on failure instead of error value. Still for checking result of phy_connect() IS_ERR() is useful. To address both situations we use combined IS_ERR_OR_NULL() check. Cc: Giuseppe Cavallaro

Re: [PATCH v2] stmmac: fix check for phydev being open

On 09/07/2015 11:50 PM, Alexey Brodkin wrote: Current implementation via IS_ERR(phydev) may make no sense because of_phy_attach() returns NULL on failure instead of error value. Still for checking result of phy_connect() IS_ERR() is useful. To address both situations we use combined

Re: [PATCH v2] stmmac: fix check for phydev being open

Hi Sergei, On Mon, 2015-09-07 at 23:53 +0300, Sergei Shtylyov wrote: > On 09/07/2015 11:50 PM, Alexey Brodkin wrote: > > > Current implementation via IS_ERR(phydev) may make no sense because > > of_phy_attach() returns NULL on failure instead of error value. > > > > Still for checking result of

Re: slab-nomerge (was Re: [git pull] device mapper changes for 4.3)

On Mon, 7 Sep 2015 13:22:13 -0700 Linus Torvalds wrote: > On Mon, Sep 7, 2015 at 2:30 AM, Jesper Dangaard Brouer > wrote: > > > > The slub allocator have a faster "fastpath", if your workload is > > fast-reusing within the same per-cpu

Re: [RFC PATCH 0/3] Network stack, first user of SLAB/kmem_cache bulk free API.

On 09/07/2015 01:16 AM, Jesper Dangaard Brouer wrote: On Fri, 4 Sep 2015 11:09:21 -0700 Alexander Duyck wrote: This is an interesting start. However I feel like it might work better if you were to create a per-cpu pool for skbs that could be freed and allocated in

Re: [PATCH v2] stmmac: fix check for phydev being open

On 09/07/2015 11:50 PM, Alexey Brodkin wrote: Current implementation via IS_ERR(phydev) may make no sense because of_phy_attach() returns NULL on failure instead of error value. Not of_phy_connect()? Still for checking result of phy_connect() IS_ERR() is useful. To address both

Re: [PATCH v2] stmmac: fix check for phydev being open

Hi Sergei, On Tue, 2015-09-08 at 00:24 +0300, Sergei Shtylyov wrote: > On 09/07/2015 11:50 PM, Alexey Brodkin wrote: > > > Current implementation via IS_ERR(phydev) may make no sense because > > of_phy_attach() returns NULL on failure instead of error value. > > Not of_phy_connect()? I

Re: [PATCH] ip link/addr show: add empty line between interfaces

Excerpts from Stephen Hemminger's message of 2015-09-07 11:09:32 -0700: > Agreed with Jiri. I prefer the new shorter brief format, not longer format. As long as it requires extra typing, few are going to use it. It's about the default. Did you try the brief format with a few v6 addresses on an

Re: [RFC PATCH 1/3] net: introduce kfree_skb_bulk() user of kmem_cache_free_bulk()

On Mon, 7 Sep 2015 09:25:49 -0700 Tom Herbert wrote: > >> What not pass a list of skbs (e.g. using skb->next)? > > > > Because the next layer, the slab API needs an array: > > kmem_cache_free_bulk(struct kmem_cache *s, size_t size, void **p) > > > > I suppose we could

Re: slab-nomerge (was Re: [git pull] device mapper changes for 4.3)

On Mon, Sep 7, 2015 at 2:30 AM, Jesper Dangaard Brouer wrote: > > The slub allocator have a faster "fastpath", if your workload is > fast-reusing within the same per-cpu page-slab, but once the workload > increases you hit the slowpath, and then slab catches up. Slub looks >