Re: [PATCH net-next] Revert "net/ipv6: add sysctl option accept_ra_min_hop_limit"

2015-09-10 Thread Sabrina Dubroca
Hello, 2015-09-10, 10:54:38 +0800, Hangbin Liu wrote: > > Can we still modify the behavior of this sysctl? It's already been in > > Linus's tree for a while, but if we can, I would rather restrict the > > values we let the user write to accept_ra_min_hop_limit, as anything > > outside [0..255]

Re: [PATCH 2/3] rhashtable-test: retry insert operations in threads

2015-09-10 Thread Phil Sutter
On Thu, Sep 10, 2015 at 04:03:44PM +0800, Herbert Xu wrote: > On Tue, Sep 01, 2015 at 04:51:24PM +0200, Thomas Graf wrote: > > > > 1. The current in-kernel self-test > > 2. bind_netlink.c: https://github.com/tgraf/rhashtable > > I can't reproduce it: I can't speak for netlink, but if you apply

Re: [PATCH net v2 0/2] xen-net{front,back}: respect user provided max_queues

2015-09-10 Thread Wei Liu
On Wed, Sep 09, 2015 at 10:05:53PM -0700, David Miller wrote: > From: David Miller > Date: Wed, 09 Sep 2015 21:53:22 -0700 (PDT) > > > From: Wei Liu > > Date: Wed, 9 Sep 2015 11:23:04 +0100 > > > >> Wei Liu (2): > >> xen-netback: respect user

Re: [PATCH 2/3] rhashtable-test: retry insert operations in threads

2015-09-10 Thread Herbert Xu
On Tue, Sep 01, 2015 at 04:51:24PM +0200, Thomas Graf wrote: > > 1. The current in-kernel self-test > 2. bind_netlink.c: https://github.com/tgraf/rhashtable I can't reproduce it: $ while :; do ./bind_netlink 1 12345; done Ports successfully created, terminating Create 1 ports Created

Re: [Xen-devel] [PATCHv1 net] xen-netback: require fewer guest Rx slots when not using GSO

2015-09-10 Thread David Vrabel
On 09/09/15 20:34, Konrad Rzeszutek Wilk wrote: > On Tue, Sep 08, 2015 at 02:25:14PM +0100, David Vrabel wrote: >> Commit f48da8b14d04ca87ffcffe68829afd45f926ec6a (xen-netback: fix >> unlimited guest Rx internal queue and carrier flapping) introduced a >> regression. >> >> The PV frontend in IPXE

Re: [PATCH net-next] Revert "net/ipv6: add sysctl option accept_ra_min_hop_limit"

2015-09-10 Thread Sabrina Dubroca
2015-09-10, 14:52:45 +0900, YOSHIFUJI Hideaki wrote: > Sabrina Dubroca wrote: > > 2015-09-02, 16:11:10 -0700, David Miller wrote: > >> The only thing I would entertain is potentially an adjustment of the > >> default, working in concert with the TAHI folks to make sure their > >> tests still pass

[PATCH net v3 1/2] xen-netback: respect user provided max_queues

2015-09-10 Thread Wei Liu
Originally that parameter was always reset to num_online_cpus during module initialisation, which renders it useless. The fix is to only set max_queues to num_online_cpus when user has not provided a value. Reported-by: Johnny Strom Signed-off-by: Wei Liu

Re: [pve-devel] bridge vlan range, kernel 4.1 : "message truncated" warning when too much vlans defined

2015-09-10 Thread Alexandre DERUMIER
Hi, This still not fixed in iproute 4.2. Is they any plan to increase the rtnl_dump_filter buffer size soon ? Regards, Alexandre Derumier - Mail original - De: "aderumier" À: "Arad, Ronen" Cc: "netdev" , "pve-devel"

Re: [PATCH] net/mac80211/rate.c: fix wrong sizeof()

2015-09-10 Thread Johannes Berg
On Wed, 2015-09-09 at 21:56 +0100, Sergei Trofimovich wrote: > From: Sergei Trofimovich > > Noticed by gcc-5.2.0: > > net/mac80211/rate.c: In function 'rate_control_cap_mask': > net/mac80211/rate.c:719:25: warning: 'sizeof' on array function > parameter 'mcs_mask'

[PATCH 2/4] vhost: move features to core

2015-09-10 Thread Michael S. Tsirkin
virtio 1 and any layout are core features, move them there. This fixes vhost test. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vhost.h | 4 +++- drivers/vhost/net.c | 3 +-- drivers/vhost/scsi.c | 4 +--- drivers/vhost/test.c | 3 +++ 4 files changed, 8

Re: [PATCH v2] r8169: Fix sleeping function called during get_stats64

2015-09-10 Thread Corinna Vinschen
On Sep 9 20:31, David Miller wrote: > From: Corinna Vinschen > Date: Wed, 9 Sep 2015 23:16:40 +0200 > > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=104031 > > Fixes: 6e85d5ad36a26debc23a9a865c029cbe242b2dc8 > > > > Based on the discussion starting at > >

[PATCH v3] r8169: Fix sleeping function called during get_stats64, v2

2015-09-10 Thread Corinna Vinschen
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=104031 Fixes: 6e85d5ad36a26debc23a9a865c029cbe242b2dc8 Based on the discussion starting at http://www.spinics.net/lists/netdev/msg342193.html Tested locally on RTL8168evl/8111evl with various concurrent processes accessing /proc/net/dev while

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-10 Thread Corinna Vinschen
On Sep 10 01:51, poma wrote: > [PATCH v2] r8169: Fix sleeping function called during get_stats64 > http://www.spinics.net/lists/netdev/msg342490.html > - the noise is still present > > Corinna, care to share kernel-core & kernel-modules you are testing with, > to unravel the Gordian Knot?

[PATCH net v3 0/2] xen-net{front,back}: respect user provided max_queues

2015-09-10 Thread Wei Liu
Wei Liu (2): xen-netback: respect user provided max_queues xen-netfront: respect user provided max_queues drivers/net/xen-netback/netback.c | 7 +-- drivers/net/xen-netfront.c| 7 +-- 2 files changed, 10 insertions(+), 4 deletions(-) -- 2.1.4 -- To unsubscribe from this

[PATCH net v3 2/2] xen-netfront: respect user provided max_queues

2015-09-10 Thread Wei Liu
Originally that parameter was always reset to num_online_cpus during module initialisation, which renders it useless. The fix is to only set max_queues to num_online_cpus when user has not provided a value. Signed-off-by: Wei Liu Cc: David Vrabel

Re: [PATCH] Remove #ifdef CONFIG_64BIT from all asm-generic/fcntl.h

2015-09-10 Thread David Howells
David Howells wrote: > Rather than iterating through all the rest of your patches and saying the same > thing, if there's something in a UAPI header that needs wrapping in __KERNEL__ > to exclude it from userspace's use, then it should be transferred to the > non-UAPI

[PATCH v2 4/5] stmmac: Fix simple style problem

2015-09-10 Thread LABBE Corentin
This patch fix the following warnings: - braces {} should be used on all arms of this statement - Prefer seq_puts to seq_printf - No space is necessary after a cast - Missing a blank line after declarations - Please don't use multiple blank lines - Comparison to NULL could be written - networking

[PATCH v2 2/5] stmmac: replace hardcoded function name by __func__

2015-09-10 Thread LABBE Corentin
Some printing have the function name hardcoded. It is better to use __func__ instead. Signed-off-by: LABBE Corentin --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

stmmac: improve logging

2015-09-10 Thread LABBE Corentin
Hello This patch series try to improve logging of the stmmac driver. Changes since v1 - Use netdev_xxx instead of dev_xxx - Use netif_xxx instead of "if (netif_msg_type) dev_xxx" Regards -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

[PATCH v2 1/5] stmmac: replace all pr_xxx by their netdev_xxx counterpart

2015-09-10 Thread LABBE Corentin
The stmmac driver use lots of pr_xxx functions to print information. This is bad since we cannot know which device logs the information. (moreover if two stmmac device are present) Furthermore, it seems that it assumes wrongly that all logs will always be subsequent by using a dev_xxx then some

Re: [Xen-devel] [PATCH net v3 2/2] xen-netfront: respect user provided max_queues

2015-09-10 Thread David Vrabel
On 10/09/15 11:18, Wei Liu wrote: > Originally that parameter was always reset to num_online_cpus during > module initialisation, which renders it useless. > > The fix is to only set max_queues to num_online_cpus when user has not > provided a value. Reviewed-by: David Vrabel

Re: [PATCH] Remove #ifdef CONFIG_64BIT from all asm-generic/fcntl.h

2015-09-10 Thread David Howells
Rather than iterating through all the rest of your patches and saying the same thing, if there's something in a UAPI header that needs wrapping in __KERNEL__ to exclude it from userspace's use, then it should be transferred to the non-UAPI variant of that header (which should #include the UAPI

Re: [PATCH 12/13] Hide AT_VECTOR_SIZE_ARCH behind #ifdef __KERNEL__

2015-09-10 Thread David Howells
Palmer Dabbelt wrote: > I think this actually isn't a good idea, but I can't find anything > outside of the kernel that's using this so I'm going to hide it. It should be in arch/x86/include/asm/auxvec.h then. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 1/4] stmmac: replace all pr_xxx by their dev_xxx counterpart

2015-09-10 Thread LABBE Corentin
On Wed, Sep 09, 2015 at 09:14:42AM -0700, Joe Perches wrote: > On Wed, 2015-09-09 at 15:14 +0200, LABBE Corentin wrote: > > The stmmac driver use lots of pr_xxx functions to print information. > > This is bad since we cannot know which device logs the information. > > (moreover if two stmmac

[PATCH v2 5/5] stmmac: replace if (netif_msg_type) by their netif_xxx counterpart

2015-09-10 Thread LABBE Corentin
As sugested by Joe Perches, we could replace all if (netif_msg_type(priv)) dev_xxx(priv->devices, ...) by the simplier macro netif_xxx(priv, hw, priv->dev, ...) Signed-off-by: LABBE Corentin --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 62

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-10 Thread Vlad Yasevich
On 09/09/2015 05:06 PM, Marcelo Ricardo Leitner wrote: > Em 09-09-2015 17:30, Vlad Yasevich escreveu: >> On 09/09/2015 04:03 PM, Marcelo Ricardo Leitner wrote: >>> Consider sctp module is unloaded and is being requested because an user >>> is creating a sctp socket. >>> >>> During initialization,

[PATCH v2 3/5] stmmac: remove some __func__ printing

2015-09-10 Thread LABBE Corentin
Now that stmmac use netdev_xxx, some __func__ are not necessary since their use was to clearly identify which driver was logging. This patch remove __func__ where such printing is useless. Signed-off-by: LABBE Corentin ---

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-10 Thread Marcelo Ricardo Leitner
Em 09-09-2015 21:16, David Miller escreveu: From: Marcelo Ricardo Leitner Date: Wed, 9 Sep 2015 17:03:01 -0300 So the fix then is to invert the initialization order inside register_pernet_subsys() so that the control socket is created by last and also block socket

Re: [PATCH 09/13] Hide bp_type_idx behind #ifdef __KERNEL__

2015-09-10 Thread David Howells
Palmer Dabbelt wrote: > +#ifdef __KERNEL__ > enum bp_type_idx { > TYPE_INST = 0, > -#ifdef CONFIG_HAVE_MIXED_BREAKPOINTS_REGS > +#if defined(CONFIG_HAVE_MIXED_BREAKPOINTS_REGS) > TYPE_DATA = 0, > #else > TYPE_DATA = 1, > #endif >

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-10 Thread poma
On 10.09.2015 10:47, Corinna Vinschen wrote: > On Sep 10 01:51, poma wrote: >> [PATCH v2] r8169: Fix sleeping function called during get_stats64 >> http://www.spinics.net/lists/netdev/msg342490.html >> - the noise is still present >> >> Corinna, care to share kernel-core & kernel-modules you are

Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel

2015-09-10 Thread Robert Jarzmik
Petr Cvek writes: > Dne 9.9.2015 v 08:25 Robert Jarzmik napsal(a): >> Petr Cvek writes: >> >>> Dne 8.9.2015 v 22:24 Petr Cvek napsal(a): Did you defined resources somewhere? Actual resources are in "pxa_ir_resources" variable at: >> I have

RE: [PATCH net] add microchip LAN88xx phy driver

2015-09-10 Thread Woojung.Huh
Thanks. > -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, September 09, 2015 8:19 PM > To: Woojung Huh - C21699 > Cc: f.faine...@gmail.com; netdev@vger.kernel.org > Subject: Re: [PATCH net] add microchip LAN88xx phy driver > > From:

Re: [PATCH 10/13] Hide USE_WCACHING behind #ifdef __KERNEL__

2015-09-10 Thread David Howells
Palmer Dabbelt wrote: > I don't think this was ever intended to be exposed to userspace. Then it should be in include/linux/pktcdvd.h David -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 11/13] Hide MAX_RAW_MINORS behind #ifdef __KERNEL__

2015-09-10 Thread David Howells
Palmer Dabbelt wrote: > I don't think this was ever meant to be exposed to userspace. Then it should be in include/linux/raw.h David -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo

RE: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-10 Thread David Laight
From: Marcelo Ricardo Leitner > Sent: 10 September 2015 13:54 > Em 09-09-2015 21:16, David Miller escreveu: > > From: Marcelo Ricardo Leitner > > Date: Wed, 9 Sep 2015 17:03:01 -0300 > > > >> So the fix then is to invert the initialization order inside > >>

[RFC net-next 06/10] qede: classification configuration

2015-09-10 Thread Yuval Mintz
From: Sudarsana Kalluru Add the ability to configure basic classification in driver by implementing ndo_set_mac_address() and ndo_set_rx_mode(). Signed-off-by: Sudarsana Kalluru Signed-off-by: Yuval Mintz

[RFC net-next 07/10] qed: Add link support

2015-09-10 Thread Yuval Mintz
Physical link is handled by the management Firmware. This patch lays the infrastructure for attention handling in the driver, as link change notifications arrive via async. attentions, as well the handling of such notifications. This patch also extends the API with the protocol drivers by adding

Re: IFLA_INET6_[ICMP6]STATS

2015-09-10 Thread Raghavendra K T
On 09/10/2015 03:13 AM, David Miller wrote: From: Sowmini Varadhan Date: Wed, 9 Sep 2015 17:34:44 -0400 So the question is- who uses IFLA_INET6_STATS/IFLA_INET6_ICMP6STATS? Is this intended for some ND/ripngd etc daemon? Doesnt seem to be documented in

[RFC net-next 04/10] qed: Add slowpath L2 support

2015-09-10 Thread Yuval Mintz
From: Manish Chopra This patch adds to the qed the support to configure various L2 elements, such as channels and basic filtering conditions. It also enhances its public API to allow qede to later utilize this functionality. Signed-off-by: Manish Chopra

[RFC net-next 08/10] qede: Add support for link

2015-09-10 Thread Yuval Mintz
From: Sudarsana Kalluru This adds basic link functionality to qede - driver still doesn't provide users with an API to change any link property, but it does request qed to initialize the link using default configuration, and registers a callback that allows it to

[iproute2 PATCH] tc: fq: allow setting and retrieving flow refill delay

2015-09-10 Thread Phil Sutter
Code to parse and export this tuneable via netlink is already present in sched_fq.c of the kernel, so not making it accessible for users would be a waste of resources. Signed-off-by: Phil Sutter --- tc/q_fq.c | 20 +++- 1 file changed, 19 insertions(+), 1

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-10 Thread Corinna Vinschen
On Sep 10 14:36, poma wrote: > On 10.09.2015 10:47, Corinna Vinschen wrote: > > On Sep 10 01:51, poma wrote: > >> [PATCH v2] r8169: Fix sleeping function called during get_stats64 > >> http://www.spinics.net/lists/netdev/msg342490.html > >> - the noise is still present > >> > >> Corinna, care to

RE: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-10 Thread David Laight
From: Marcelo Ricardo > Sent: 10 September 2015 15:36 ... > > Given that the first ->create() blocks while the protocol code loads > > it really wouldn't be right to error a subsequent ->create() because > > the load hasn't completed. > > Can't say I don't agree with you, but at the same time,

Re: [PATCH v2 1/5] stmmac: replace all pr_xxx by their netdev_xxx counterpart

2015-09-10 Thread Joe Perches
On Thu, 2015-09-10 at 14:37 +0200, LABBE Corentin wrote: > So this patch replace all pr_xxx by their dev_xxx counterpart. Minor mismatch between subject and commit message. Maybe not worth resending. Thanks -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

[RFC net-next 02/10] qed: Add basic L2 interface

2015-09-10 Thread Yuval Mintz
From: Manish Chopra This patch adds a public API for a network driver to work on top of QED. The interface itself is very minimal - it's mostly infrastructure, as the only content it has after this patch is a query for HW-based information required for the creation of a

[RFC net-next 05/10] qede: Add basic network device support

2015-09-10 Thread Yuval Mintz
From: Sudarsana Kalluru This patch includes the basic Rx/Tx support for the driver [although carrier will still never be turned on]. Following this patch the driver registers a network device, initializes it and prepares it for traffic. Signed-off-by: Sudarsana

[RFC net-next 10/10] qede: Add basic ethtool support

2015-09-10 Thread Yuval Mintz
From: Sudarsana Kalluru This adds basic ethtool operations to the qed driver, allowing support in: - Statistics gathering [ethtool -S] - Setting of debug level [ethtool -s msglvl] - Getting basic information [ethtool, ethtool -i] In addition it adds the ability

[RFC net-next 03/10] qede: Add basic Network driver

2015-09-10 Thread Yuval Mintz
The Qlogic Everest Driver for Ethernet is the Ethernet specifc module for 579xx ethernet products by Qlogic. This patch adds a very minimal PCI driver, one that doesn't yet register a network device, but one that does interact with qed and does a basic initialization of the HW. Signed-off-by:

[RFC net-next 09/10] qed: Add statistics support

2015-09-10 Thread Yuval Mintz
From: Manish Chopra Device statistics can be gathered on-demand. This adds the qed support for reading the statistics [both function and port] from the device, and adds to the public API a method for requesting the current statistics. Signed-off-by: Manish Chopra

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-10 Thread Marcelo Ricardo Leitner
Em 10-09-2015 10:24, Vlad Yasevich escreveu: On 09/09/2015 05:06 PM, Marcelo Ricardo Leitner wrote: Em 09-09-2015 17:30, Vlad Yasevich escreveu: On 09/09/2015 04:03 PM, Marcelo Ricardo Leitner wrote: Consider sctp module is unloaded and is being requested because an user is creating a sctp

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-10 Thread Marcelo Ricardo Leitner
Em 10-09-2015 10:02, David Laight escreveu: From: Marcelo Ricardo Leitner Sent: 10 September 2015 13:54 Em 09-09-2015 21:16, David Miller escreveu: From: Marcelo Ricardo Leitner Date: Wed, 9 Sep 2015 17:03:01 -0300 So the fix then is to invert the initialization

[ANNOUNCE] Netdev 1.1 conference

2015-09-10 Thread Pablo Neira Ayuso
Following the lastest successful Netdev 0.1 in Ottawa, Canada. We are happy to announce a new round of the Netdev conference series: Netdev 1.1 (year 1, conference 1) from 10th to 12th February 2016 in Seville, Spain (http://www.netdevconf.org/1.1/). Netdev 1.1 is a community-driven conference

Re: IFLA_INET6_[ICMP6]STATS

2015-09-10 Thread roopa
On 9/9/15, 2:45 PM, Sowmini Varadhan wrote: On (09/09/15 14:43), David Miller wrote: But what we could do is add a flag in the netlink request which elides the stats. GLIBC et al. could then start setting the flag. Yes, interestingly that's what I was experimenting with myself (though I was

RE: [Intel-wired-lan] [PATCH] igb: don't unmap hw_addr if its NULL

2015-09-10 Thread Fujinaka, Todd
Thanks! I tried testing this sort of thing last spring, but there just wasn't a lot of hardware available to me and things weren't breaking with my setup (not sure why). ACK. Todd Fujinaka Software Application Engineer Networking Division (ND) Intel Corporation todd.fujin...@intel.com (503)

Re: [PATCH v2 5/5] stmmac: replace if (netif_msg_type) by their netif_xxx counterpart

2015-09-10 Thread Joe Perches
On Thu, 2015-09-10 at 14:37 +0200, LABBE Corentin wrote: > replace all > if (netif_msg_type(priv)) dev_xxx(priv->devices, ...) > by the simplier macro netif_xxx(priv, hw, priv->dev, ...) Thanks. Trivia: > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >

Re: [RFC net-next 01/10] qed: Add module with basic common support

2015-09-10 Thread David Miller
From: Yuval Mintz Date: Thu, 10 Sep 2015 16:54:12 +0300 > Documentation/networking/LICENSE.qlogic| 288 ++ I do not want to get into the habit of having to add copy after copy of the GPL v2 to the source tree, so this is rather inappropriate. Everything

Re: IFLA_INET6_[ICMP6]STATS

2015-09-10 Thread David Miller
From: Sowmini Varadhan Date: Thu, 10 Sep 2015 11:48:19 -0400 > On (09/10/15 08:43), roopa wrote: >> If you decide to use a flag, there is IFLA_EXT_MASK which is used to >> specify such filters from userspace today. >> >> /* New extended info filters for

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-10 Thread Vlad Yasevich
On 09/10/2015 10:22 AM, Marcelo Ricardo Leitner wrote: > Em 10-09-2015 10:24, Vlad Yasevich escreveu: >> On 09/09/2015 05:06 PM, Marcelo Ricardo Leitner wrote: >>> Em 09-09-2015 17:30, Vlad Yasevich escreveu: On 09/09/2015 04:03 PM, Marcelo Ricardo Leitner wrote: > Consider sctp module is

Re: IFLA_INET6_[ICMP6]STATS

2015-09-10 Thread David Miller
From: Sowmini Varadhan Date: Thu, 10 Sep 2015 13:16:30 -0400 > On (09/10/15 10:13), David Miller wrote: >> I don't think using such a generic netlink flag works best, the >> IFLA_EXT_MASK is definitely more suitable. > > Ok, though this more of a IFLA_TRUNCATE_MASK

Re: IFLA_INET6_[ICMP6]STATS

2015-09-10 Thread Sowmini Varadhan
On (09/10/15 08:43), roopa wrote: > If you decide to use a flag, there is IFLA_EXT_MASK which is used to > specify such filters from userspace today. > > /* New extended info filters for IFLA_EXT_MASK */ > #define RTEXT_FILTER_VF (1 << 0) > #define RTEXT_FILTER_BRVLAN (1 << 1) >

Re: [PATCH net v3 0/2] xen-net{front,back}: respect user provided max_queues

2015-09-10 Thread David Miller
From: Wei Liu Date: Thu, 10 Sep 2015 11:18:56 +0100 > Wei Liu (2): > xen-netback: respect user provided max_queues > xen-netfront: respect user provided max_queues This looks better, series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe

Re: IFLA_INET6_[ICMP6]STATS

2015-09-10 Thread Sowmini Varadhan
On (09/10/15 10:13), David Miller wrote: > I don't think using such a generic netlink flag works best, the > IFLA_EXT_MASK is definitely more suitable. Ok, though this more of a IFLA_TRUNCATE_MASK than a IFLA_EXT_MASK. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: 4.1.0, kernel panic, pppoe_release

2015-09-10 Thread Guillaume Nault
On Fri, Jul 17, 2015 at 09:16:14PM +0300, Denys Fedoryshchenko wrote: > Probably my knowledge of kernel is not sufficient, but i will try few > approaches. > One of them to add to pppoe_unbind_sock_work: > > pppox_unbind_sock(sk); > +/* Signal the death of the socket. */ >

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-10 Thread Marcelo Ricardo Leitner
On Thu, Sep 10, 2015 at 11:50:06AM -0400, Vlad Yasevich wrote: > On 09/10/2015 10:22 AM, Marcelo Ricardo Leitner wrote: > > Em 10-09-2015 10:24, Vlad Yasevich escreveu: ... > >> Then you can order sctp_net_init() such that it happens first, then > >> protosw registration > >> happens, then

Re: [PATCH] igb: don't unmap hw_addr if its NULL

2015-09-10 Thread Rustad, Mark D
> On Sep 9, 2015, at 9:07 PM, Jarod Wilson wrote: > > diff --git a/drivers/net/ethernet/intel/igb/igb_main.c > b/drivers/net/ethernet/intel/igb/igb_main.c > index e174fbb..a5e0022 100644 > --- a/drivers/net/ethernet/intel/igb/igb_main.c > +++

Re: [PATCH] igb: don't unmap hw_addr if its NULL

2015-09-10 Thread Jarod Wilson
Rustad, Mark D wrote: On Sep 9, 2015, at 9:07 PM, Jarod Wilson wrote: diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index e174fbb..a5e0022 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-10 Thread Marcelo Ricardo Leitner
On Thu, Sep 10, 2015 at 01:24:54PM -0300, Marcelo Ricardo Leitner wrote: > On Thu, Sep 10, 2015 at 11:50:06AM -0400, Vlad Yasevich wrote: > > On 09/10/2015 10:22 AM, Marcelo Ricardo Leitner wrote: > > > Em 10-09-2015 10:24, Vlad Yasevich escreveu: > ... > > >> Then you can order sctp_net_init()

Re: [PATCH net 1/2] tcp: generate CA_EVENT_TX_START on data frames

2015-09-10 Thread David Miller
From: Eric Dumazet Date: Wed, 09 Sep 2015 21:54:37 -0700 > From: Neal Cardwell > > Issuing a CC TX_START event on control frames like pure ACK > is a waste of time, as a CC should not care. > > Following patch needs this change, as we want CUBIC

Re: [PATCH net 2/2] tcp_cubic: better follow cubic curve after idle period

2015-09-10 Thread David Miller
From: Eric Dumazet Date: Wed, 09 Sep 2015 21:55:07 -0700 > From: Eric Dumazet > > Jana Iyengar found an interesting issue on CUBIC : > > The epoch is only updated/reset initially and when experiencing losses. > The delta "t" of now - epoch_start

[PATCH net] netlink, mmap: transform mmap skb into full skb on taps

2015-09-10 Thread Daniel Borkmann
Ken-ichirou reported that running netlink in mmap mode for receive in combination with nlmon will throw a NULL pointer dereference in __kfree_skb() on nlmon_xmit(), in my case I can also trigger an "unable to handle kernel paging request". The problem is the skb_clone() in

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-10 Thread Marcelo Ricardo Leitner
On Thu, Sep 10, 2015 at 03:35:20PM -0300, Marcelo Ricardo Leitner wrote: > On Thu, Sep 10, 2015 at 01:24:54PM -0300, Marcelo Ricardo Leitner wrote: > > On Thu, Sep 10, 2015 at 11:50:06AM -0400, Vlad Yasevich wrote: > > > On 09/10/2015 10:22 AM, Marcelo Ricardo Leitner wrote: > > > > Em 10-09-2015

Re: [PATCH 3/5] lan78xx: Add PHYLIB and MICROCHIP_PHY as default config.

2015-09-10 Thread Florian Fainelli
On 10/09/15 13:48, woojung@microchip.com wrote: > Add PHYLIB and MICROCHIP_PHY as default configuration for lan78xx. You would want to swap this patch and patch 2 to make sure that there is no user-visible breakage in between. > > Signed-off-by: Woojung Huh >

Re: [PATCH net-next] Revert "net/ipv6: add sysctl option accept_ra_min_hop_limit"

2015-09-10 Thread Hangbin Liu
Hi Sabrina, 2015-09-10 17:19 GMT+08:00 Sabrina Dubroca : > Hello, > > 2015-09-10, 10:54:38 +0800, Hangbin Liu wrote: >> > Can we still modify the behavior of this sysctl? It's already been in >> > Linus's tree for a while, but if we can, I would rather restrict the >> >

[PATCH v2 4/5] seccomp: add a way to access filters via bpf fds

2015-09-10 Thread Tycho Andersen
This patch adds a way for a process that is "real root" to access the seccomp filters of another process. The process first does a PTRACE_SECCOMP_GET_FILTER_FD to get an fd with that process' seccomp filter attached, and then iterates on this with PTRACE_SECCOMP_NEXT_FILTER using

[PATCH v2 5/5] seccomp: add a way to attach a filter via eBPF fd

2015-09-10 Thread Tycho Andersen
This is the final bit needed to support seccomp filters created via the bpf syscall. The patch adds a new seccomp operation SECCOMP_MODE_FILTER_EBPF, which takes exactly one command (presumably to be expanded upon later when seccomp EBPFs support more interesting things) and an argument struct

[PATCH v2 3/5] ebpf: add a way to dump an eBPF program

2015-09-10 Thread Tycho Andersen
This commit adds a way to dump eBPF programs. The initial implementation doesn't support maps, and therefore only allows dumping seccomp ebpf programs which themselves don't currently support maps. v2: don't export a prog_id for the filter Signed-off-by: Tycho Andersen

Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel

2015-09-10 Thread Petr Cvek
Dne 10.9.2015 v 13:14 Robert Jarzmik napsal(a): > Petr Cvek writes: > >> Dne 9.9.2015 v 08:25 Robert Jarzmik napsal(a): >>> Petr Cvek writes: >>> Dne 8.9.2015 v 22:24 Petr Cvek napsal(a): > > Did you defined resources somewhere? Actual resources

[PATCH/RFC v2 net-next 2/4] ravb: Provide dev parameter to DMA API

2015-09-10 Thread Simon Horman
From: Kazuya Mizuguchi This patch is in preparation for using this driver on arm64 where the implementation of __dma_alloc_coherent fails if a device parameter is not provided. Signed-off-by: Kazuya Mizuguchi Signed-off-by:

[PATCH/RFC v2 net-next 4/4] ravb: Add support for r8a7795 SoC

2015-09-10 Thread Simon Horman
From: Kazuya Mizuguchi This patch supports the r8a7795 SoC by: - Using two interrupts + One for E-MAC + One for everything else + Both can be handled by the existing common interrupt handler, which affords a simpler update to support the new SoC. In

[PATCH/RFC v2 net-next 3/4] ravb: Document binding for r8a7795 SoC

2015-09-10 Thread Simon Horman
From: Kazuya Mizuguchi This patch updates the ravb binding to support the r8a7795 SoC by: - Adding a compat string for the new hardware - Adding 25 named interrupts to binding for the new SoC; older SoCs continue to use a single multiplexed interrupt The

[PATCH/RFC v2 net-next 0/4] ravb: Add support for r8a7795 SoC

2015-09-10 Thread Simon Horman
This series enhances the ravb driver to support the r8a7795 SoC. Changes: v1 -> v2 * Address extensive review from Sergei Shtylyov and Geert Uytterhoeven - In particular mandate all 25 interrupts in binding * Broke brinding change into a separate patch * New 100Mbit/s limit implementation in

[PATCH/RFC v2 net-next 1/4] phylib: Add phy_set_max_speed helper

2015-09-10 Thread Simon Horman
Add a helper to allow ethernet drivers to limit the speed of a phy (that they are attached to). This mainly involves factoring out the business-end of of_set_phy_supported() and exporting a new symbol. This code seems to be open coded in several places, in several different variants. This code

[PATCH v2 1/5] ebpf: add a seccomp program type

2015-09-10 Thread Tycho Andersen
seccomp uses eBPF as its underlying storage and execution format, and eBPF has features that seccomp would like to make use of in the future. This patch adds a formal seccomp type to the eBPF verifier. The current implementation of the seccomp eBPF type is very limited, and doesn't support some

[PATCH v2 2/5] seccomp: make underlying bpf ref counted as well

2015-09-10 Thread Tycho Andersen
In the next patch, we're going to add a way to access the underlying filters via bpf fds. This means that we need to ref-count both the struct seccomp_filter objects and the struct bpf_prog objects separately, in case a process dies but a filter is still referred to by another process.

[PATCHv2 RFC] RTEXT_FILTER_SKIP_STATS support to avoid dumping inet/inet6 stats

2015-09-10 Thread Sowmini Varadhan
Many commonly used functions like getifaddrs() invoke RTM_GETLINK to dump the interface information, and do not need the the AF_INET6 statististics that are always returned by default from rtnl_fill_ifinfo(). Computing the statistics can be an expensive operation that impacts scaling, so it is

RE: [PATCH 3/5] lan78xx: Add PHYLIB and MICROCHIP_PHY as default config.

2015-09-10 Thread Woojung.Huh
Thanks. Will repost as order you commented. > -Original Message- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Thursday, September 10, 2015 5:47 PM > To: Woojung Huh - C21699; da...@davemloft.net > Cc: netdev@vger.kernel.org > Subject: Re: [PATCH 3/5] lan78xx: Add PHYLIB

Re: [pve-devel] bridge vlan range, kernel 4.1 : "message truncated" warning when too much vlans defined

2015-09-10 Thread David Miller
From: roopa Date: Thu, 10 Sep 2015 15:26:30 -0700 > On 9/9/15, 11:40 PM, Alexandre DERUMIER wrote: >> Hi, >> >> This still not fixed in iproute 4.2. >> >> Is they any plan to increase the rtnl_dump_filter buffer size soon ? > > Instead of increasing the default size,

[PATCH 5/5] lan78xx: create lan78xx_get_mdix_status() & and lan78xx_set_mdix_status() for MDIX control

2015-09-10 Thread Woojung.Huh
Create lan78xx_get_mdix_status() and lan78xx_set_mdix_status() for MDIX control. Repost with new order of patches. Signed-off-by: Woojung Huh --- drivers/net/usb/lan78xx.c | 88 +++ 1 file changed, 50 insertions(+), 38

[PATCH 2/5] lan78xx: Add PHYLIB and MICROCHIP_PHY as default config.

2015-09-10 Thread Woojung.Huh
Add PHYLIB and MICROCHIP_PHY as default configuration for lan78xx. Repost with new order of patches. Signed-off-by: Woojung Huh --- drivers/net/usb/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig index

[PATCH 3/5] lan78xx: update to use phylib

2015-09-10 Thread Woojung.Huh
Update to use phylib instead of mii_if_info. Repost with new order of patches. Signed-off-by: Woojung Huh --- drivers/net/usb/lan78xx.c | 610 +++--- 1 file changed, 250 insertions(+), 360 deletions(-) diff --git

[PATCH 4/5] lan78xx: Remove phy defines in lan78xx.h and use defines in microchipphy.h

2015-09-10 Thread Woojung.Huh
Remove phy defines in lan78xx.h and use defines in include/linux/microchipphy.h. Repost with new order of patches. Signed-off-by: Woojung Huh --- drivers/net/usb/lan78xx.c | 79 +-- drivers/net/usb/lan78xx.h | 192

[PATCH 1/5] lan78xx: check device ready bit (PMT_CTL_READY_) after reset phy

2015-09-10 Thread Woojung.Huh
Check device ready bit (PMT_CTL_READY_) after reset the PHY. Device may not be ready even if PHY_RST_ is cleared depends on configuration. Repost with new order of patches. Signed-off-by: Woojung Huh --- drivers/net/usb/lan78xx.c | 2 +- 1 file changed, 1

[PATCH net] openvswitch: Fix mask generation for nested attributes.

2015-09-10 Thread Jesse Gross
Masks were added to OVS flows in a way that was backwards compatible with userspace programs that did not generate masks. As a result, it is possible that we may receive flows that do not have a mask and we need to synthesize one. Generating a mask requires iterating over attributes and

Re: [pve-devel] bridge vlan range, kernel 4.1 : "message truncated" warning when too much vlans defined

2015-09-10 Thread roopa
On 9/9/15, 11:40 PM, Alexandre DERUMIER wrote: Hi, This still not fixed in iproute 4.2. Is they any plan to increase the rtnl_dump_filter buffer size soon ? Instead of increasing the default size, it would be nicer if this was configurable for iproute2 (I haven't looked yet). -- To

Re: [pve-devel] bridge vlan range, kernel 4.1 : "message truncated" warning when too much vlans defined

2015-09-10 Thread roopa
On 9/10/15, 3:58 PM, David Miller wrote: From: roopa Date: Thu, 10 Sep 2015 15:26:30 -0700 On 9/9/15, 11:40 PM, Alexandre DERUMIER wrote: Hi, This still not fixed in iproute 4.2. Is they any plan to increase the rtnl_dump_filter buffer size soon ? Instead of

[PATCH] ebpf: emit correct src_reg for conditional jumps

2015-09-10 Thread Tycho Andersen
Instead of always emitting BPF_REG_X, let's emit BPF_REG_X only when the source actually is BPF_X. This causes programs generated by the classic converter to not be importable via bpf(), as the eBPF verifier checks that the src_reg is correct or 0. While not a problem yet, this will be a problem

v2 of seccomp filter c/r patches

2015-09-10 Thread Tycho Andersen
Hi all, Here is v2 of the seccomp filter c/r set. The patch notes have individual changes from the last series, but there are two points not noted: * The series still does not allow us to correctly restore state for programs that will use SECCOMP_FILTER_FLAG_TSYNC in the future. Given that we

Re: [PATCH v2 3/5] ebpf: add a way to dump an eBPF program

2015-09-10 Thread Alexei Starovoitov
On Thu, Sep 10, 2015 at 06:21:00PM -0600, Tycho Andersen wrote: > +static int bpf_prog_dump(union bpf_attr *attr, union bpf_attr __user *uattr) > +{ > + int ufd = attr->prog_fd; > + struct fd f = fdget(ufd); > + struct bpf_prog *prog; > + int ret = -EINVAL; > + > + prog =

Fwd: man pages for traceroute6

2015-09-10 Thread Geof Sawaya
Refer to traceroute man page, and mentions that 'it is needless to copy the description from there' However, my system doesn't include traceroute Is there a buglist? Many thanks -- Geof -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH net] netlink, mmap: transform mmap skb into full skb on taps

2015-09-10 Thread David Miller
From: Daniel Borkmann Date: Thu, 10 Sep 2015 20:05:46 +0200 > Ken-ichirou reported that running netlink in mmap mode for receive in > combination with nlmon will throw a NULL pointer dereference in > __kfree_skb() on nlmon_xmit(), in my case I can also trigger an "unable >

  1   2   >