Re: [PATCH] - gre: add eth_p_teb gro-handler for OVS with gre tunnels

On Mon, Oct 12, 2015 at 3:26 PM, Ramu Ramamurthy wrote: > > Problem: > > > When using OVS with GRE tunnels, and GRO is enabled on the nic, > We find that GRO doesnt really take effect. As a result, TCP stream > performance on a 10G nic is around 2-3Gbps. > >

Re: [PATCH net-next v2] ipv6 route: use err pointers instead of returning pointer by reference

From: Roopa Prabhu Date: Sat, 10 Oct 2015 08:26:36 -0700 > From: Roopa Prabhu > > This patch makes ip6_route_info_create return err pointer instead of > returning the rt pointer by reference as suggested by Dave > > Signed-off-by: Roopa

Re: [PATCH net-next] net: hns: fix the unknown phy_nterface_t type error

From: huangdaode Date: Sat, 10 Oct 2015 17:20:38 +0800 > This patch fix the building error reported by Jiri Pirko > > drivers/net/ethernet/hisilicon/hns/hnae.h:465:2: error: unknown type > name 'phy_interface_t' > phy_interface_t phy_if; >

Re: [patch net-next v4 1/7] switchdev: introduce switchdev workqueue

On Mon, Oct 12, 2015 at 10:54 AM, Jiri Pirko wrote: > From: Jiri Pirko > > This is going to be used for deferred operations. > > Signed-off-by: Jiri Pirko Acked-by: Scott Feldman -- To unsubscribe from this list: send

Re: [patch net-next v4 3/7] switchdev: remove pointers from switchdev objects

On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: > From: Jiri Pirko > > When object is used in deferred work, we cannot use pointers in > switchdev object structures because the memory they point at may be already > used by someone else. So rather do local

Re: [patch net-next v4 5/7] bridge: defer switchdev fdb del call in fdb_del_external_learn

On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Since spinlock is held here, defer the switchdev operation. > > Signed-off-by: Jiri Pirko > --- > net/bridge/br_fdb.c | 5 - > net/bridge/br_if.c | 3 +++ > 2

Re: [RFC PATCH 2/2] bpf: Implement bpf_perf_event_sample_enable/disable() helpers

On 2015/10/13 3:29, Alexei Starovoitov wrote: On 10/12/15 2:02 AM, Kaixu Xia wrote: +extern const struct bpf_func_proto bpf_perf_event_sample_enable_proto; +extern const struct bpf_func_proto bpf_perf_event_sample_disable_proto; externs are unnecessary. Just make them static. Also I prefer

Re: [RFC PATCH 2/2] bpf: Implement bpf_perf_event_sample_enable/disable() helpers

On 2015/10/13 12:16, Alexei Starovoitov wrote: On 10/12/15 8:51 PM, Wangnan (F) wrote: why 'set disable' is needed ? the example given in cover letter shows the use case where you want to receive samples only within sys_write() syscall. The example makes sense, but sys_write() is running on

Re: [patch net-next v4 3/7] switchdev: remove pointers from switchdev objects

On 15-10-12 08:01 PM, Scott Feldman wrote: > On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> When object is used in deferred work, we cannot use pointers in >> switchdev object structures because the memory they point at may be

Re: [PATCH net] switchdev: check if the vlan id is in the proper vlan range

On Mon, Oct 12, 2015 at 5:31 AM, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > VLANs 0 and 4095 are reserved and shouldn't be used, add checks to > switchdev similar to the bridge. Also make sure ids above 4095 cannot > be passed

[net-next 07/17] i40e: remove redundant call

From: Mitch Williams This function call isn't needed here; the same function is already called by i40e_reset_vf. Change-ID: I96ccbf91b752965c9e28fe895d4c7d4c46e3ba44 Signed-off-by: Mitch Williams Tested-by: Andrew Bowers

[net-next 06/17] i40e: Convert CEE App TLV selector to IEEE selector

From: Greg Bowers Changes the parsing of CEE App TLVs to fill in the App selector in struct i40e_dcbx_config with the IEEE App selector so the caller doesn't have to consider whether the App came from a CEE or IEEE DCBX negotiation. Change-ID:

[net-next 12/17] i40e/i40evf: Add module_types and update_link_info

From: Catherine Sullivan Add a module_types variable to the link_info struct to save the module information from get_phy_capabilities. This information can be used to determine which speeds the module supports. Also add a new function update_link_info which updates

[net-next 05/17] i40e/i40evf: Add info to nvm info struct for OEM version data

From: Carolyn Wyborny This patch adds a member to the nvm_info struct for oem_ver info to be output either by OID or ethtool. Change-ID: I1e5d513ae67622e2af17042924fdb4b5d6d85366 Signed-off-by: Carolyn Wyborny Tested-by: Andrew Bowers

[net-next 03/17] i40e: Use BIT() macro for priority map parsing

From: Neerav Parikh Replace one left over (1 << up) in the i40e_dcb.c file with the BIT() macro. Change-ID: I39492a400a2cee5ac566143a5b436cc478bea0db Signed-off-by: Neerav Parikh Tested-by: Andrew Bowers

[net-next 15/17] ixgbe: add flow control ethertype to the anti-spoofing filter

From: Emil Tantilov This patch makes sure that flow control packets initiated by the VF are dropped and reported as spoofed. Flow control packets can be used to limit the throughput or as DOS attack when generated from a VF. Flow control is not supported per VF hence

[net-next 02/17] i40e: Make it clear a parameter is never used

From: Carolyn Wyborny Flag the filter_mask parameter as __always_unused in the ndo_bridge_getlink function. Change-ID: Ifc1e99c7fb84bcbf81cf7b0ac891ad8ca956ffb2 Signed-off-by: Carolyn Wyborny Tested-by: Andrew Bowers

[net-next 09/17] i40e: update fw version text string per previous product formats

From: Carolyn Wyborny This patch moves the internal fw version and fw api version info to be output in probe. The nvm version, etrack and oem version info are now configured for output via ethtool -i. Change-ID: I05d490093a7137dbefcdef263d014d1e5c9e83d0

Re: [PATCH v3 net-next 0/4] tcp: better smp listener behavior

From: Eric Dumazet Date: Thu, 8 Oct 2015 19:33:20 -0700 > As promised in last patch series, we implement a better SO_REUSEPORT > strategy, based on cpu affinities if selected by the application. > > We also moved sk_refcnt out of the cache line containing the lookup >

Re: [PATCH v2 net-next 0/4] tcp: better smp listener behavior

From: Eric Dumazet Date: Thu, 8 Oct 2015 14:58:53 -0700 > As promised in last patch series, we implement a better SO_REUSEPORT > strategy, based on cpu hints if given by the application. > > We also moved sk_refcnt out of the cache line containing the lookup > keys, as it

Re: [PATCH v4 4/4] Adds hardware supported cross timestamp

Hi Christopher, [auto build test ERROR on net/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url:

Re: [patch net-next v4 5/7] bridge: defer switchdev fdb del call in fdb_del_external_learn

On 15-10-12 08:28 PM, Scott Feldman wrote: > On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Since spinlock is held here, defer the switchdev operation. >> >> Signed-off-by: Jiri Pirko >> --- >>

Re: [RFC PATCH 2/2] bpf: Implement bpf_perf_event_sample_enable/disable() helpers

On 10/12/15 8:51 PM, Wangnan (F) wrote: why 'set disable' is needed ? the example given in cover letter shows the use case where you want to receive samples only within sys_write() syscall. The example makes sense, but sys_write() is running on this cpu, so just disabling it on the current one

Re: [patch net-next v4 2/7] switchdev: allow caller to explicitly request attr_set as deferred

On 15-10-12 07:52 PM, Scott Feldman wrote: > On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Caller should know if he can call attr_set directly (when holding RTNL) >> or if he has to defer the att_set processing for later. >> >>

Re: [RFC PATCH 2/2] bpf: Implement bpf_perf_event_sample_enable/disable() helpers

On 10/12/15 9:34 PM, Wangnan (F) wrote: On 2015/10/13 12:16, Alexei Starovoitov wrote: On 10/12/15 8:51 PM, Wangnan (F) wrote: why 'set disable' is needed ? the example given in cover letter shows the use case where you want to receive samples only within sys_write() syscall. The example

Re: Issue with /proc/sys/net/ipv4/tcp_mem

Eric Dumazet writes: > On Mon, 2015-10-12 at 11:37 -0500, Eric W. Biederman wrote: >> wangyufen writes: >> >> > Hi, >> > >> > I tried on linux-4.1: >> > linux:~# cat /proc/sys/net/ipv4/tcp_mem >> > 83886081258291216777216

Re: [patch net-next v4 5/7] bridge: defer switchdev fdb del call in fdb_del_external_learn

On 15-10-12 09:19 PM, Scott Feldman wrote: > On Mon, Oct 12, 2015 at 8:31 PM, John Fastabend > wrote: >> On 15-10-12 08:28 PM, Scott Feldman wrote: >>> On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: From: Jiri Pirko

Re: [patch net-next v4 2/7] switchdev: allow caller to explicitly request attr_set as deferred

On 15-10-12 10:45 PM, Jiri Pirko wrote: > Tue, Oct 13, 2015 at 06:40:25AM CEST, john.fastab...@gmail.com wrote: >> On 15-10-12 07:52 PM, Scott Feldman wrote: >>> On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: From: Jiri Pirko Caller should

Re: [PATCH net-next 0/3] net: Pass net into defragmentation

From: ebied...@xmission.com (Eric W. Biederman) Date: Fri, 09 Oct 2015 13:42:20 -0500 > > This is the next installment of my work to pass struct net through the > output path so the code does not need to guess how to figure out which > network namespace it is in, and ultimately routes can have

Re: [RFC PATCH 1/2] perf: Add the flag sample_disable not to output data on samples

于 2015/10/13 3:20, Alexei Starovoitov 写道: > On 10/12/15 2:02 AM, Kaixu Xia wrote: >> diff --git a/include/linux/bpf.h b/include/linux/bpf.h >> index f57d7fe..25e073d 100644 >> --- a/include/linux/bpf.h >> +++ b/include/linux/bpf.h >> @@ -39,6 +39,7 @@ struct bpf_map { >> u32 max_entries; >>

Re: [PATCH net-next] tun: use sk_fullsock() before reading sk->sk_tsflags

From: Eric Dumazet Date: Fri, 09 Oct 2015 15:42:21 -0700 > From: Eric Dumazet > > timewait or request sockets are small and do not contain sk->sk_tsflags > > Without this fix, we might read garbage, and crash later in > >

Re: [PATCH 2/2] atm: iphase: fix misleading indention

From: Tillmann Heidsieck Date: Sat, 10 Oct 2015 21:47:19 +0200 > Fix a smatch warning: > drivers/atm/iphase.c:1178 rx_pkt() warn: curly braces intended? > > The code is correct, the indention is misleading. In case the allocation > of skb fails, we want to skip to the end.

Re: [PATCH 1/2] atm: iphase: return -ENOMEM instead of -1 in case of failed kmalloc()

From: Tillmann Heidsieck Date: Sat, 10 Oct 2015 21:47:18 +0200 > Smatch complains about returning hard coded error codes, silence this > warning. > > drivers/atm/iphase.c:115 ia_enque_rtn_q() warn: returning -1 instead of > -ENOMEM is sloppy > > Signed-off-by: Tillmann

Re: [RFC PATCH 2/2] bpf: Implement bpf_perf_event_sample_enable/disable() helpers

On 10/12/15 8:27 PM, Wangnan (F) wrote: Then how to avoid racing? For example, when one core disabling all events in a map, another core is enabling all of them. This racing may causes sereval perf events in a map dump samples while other events not. To avoid such racing I think some locking

RE: [PATCH net-next v5 01/10] qed: Add module with basic common support

> 500 ko of a basic something is mildly reviewable for mere mortals. Undertood, obviously. Thanks for the time you've put into this. > [...] > > +/* forward */ > > +struct qed_ptt_pool; > > +struct qed_spq; > > +struct qed_sb_info; > > +struct qed_sb_attn_info; > > +struct qed_cxt_mngr; > >

Re: [PATCH v4 1/4] Produce system time from correlated clocksource

On Mon, Oct 12, 2015 at 11:45:19AM -0700, Christopher S. Hall wrote: > Another representative use case of time sync and the correlated > clocksource (in addition to PTP noted above) is PTP synchronized > audio. The added explanations of the audio use case do help. However, you did not address my

Re: [PATCH v4 1/4] Produce system time from correlated clocksource

On Mon, Oct 12, 2015 at 11:45:19AM -0700, Christopher S. Hall wrote: > +int get_correlated_timestamp(struct correlated_ts *crt, > + struct correlated_cs *crs) > +{ > + struct timekeeper *tk = _core.timekeeper; > + unsigned long seq; > + cycles_t cycles,

Re: [patch net-next] bridge: try switchdev op first in __vlan_vid_add/del

From: Jiri Pirko Date: Fri, 9 Oct 2015 13:54:11 +0200 > From: Jiri Pirko > > Some drivers need to implement both switchdev vlan ops and > vid_add/kill ndos. For that to work in bridge code, we need to try > switchdev op first when adding/deleting vlan id.

Re: [PATCH net] ipv4/icmp: redirect messages can use the ingress daddr as source

From: Paolo Abeni Date: Fri, 9 Oct 2015 14:34:31 +0200 > This patch allows configuring how the source address of ICMP > redirect messages is selected; by default the old behaviour is > retained, while setting icmp_redirects_use_orig_daddr force the > usage of the destination

Re: [patch net-next v4 4/7] switchdev: introduce possibility to defer obj_add/del

On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Similar to the attr usecase, the caller knows if he is holding RTNL and is > in atomic section. So let the called to decide the correct call variant. > > This allows drivers to sleep

RE: [PATCH] qlcnic: constify qlcnic_mbx_ops structure

> From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Julia Lawall > Sent: Sunday, October 11, 2015 4:48 AM > To: Dept-GE Linux NIC Dev > Cc: kernel-janit...@vger.kernel.org; netdev ; linux- >

Re: [RFC PATCH 2/2] bpf: Implement bpf_perf_event_sample_enable/disable() helpers

On 2015/10/13 11:39, Alexei Starovoitov wrote: On 10/12/15 8:27 PM, Wangnan (F) wrote: Then how to avoid racing? For example, when one core disabling all events in a map, another core is enabling all of them. This racing may causes sereval perf events in a map dump samples while other events

Re: [patch net-next v4 6/7] rocker: remove nowait from switchdev callbacks.

On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: > From: Jiri Pirko > > No need to avoid sleeping in switchdev callbacks now, as the switchdev > core allows it. > > Signed-off-by: Jiri Pirko > --- > drivers/net/ethernet/rocker/rocker.c

Re: [patch net-next v4 5/7] bridge: defer switchdev fdb del call in fdb_del_external_learn

On Mon, Oct 12, 2015 at 8:31 PM, John Fastabend wrote: > On 15-10-12 08:28 PM, Scott Feldman wrote: >> On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Since spinlock is held here, defer the switchdev

[PATCH] net: phy: smsc: disable energy detect mode

On some boards the energy enable detect mode leads in trouble with some switches, so make the enabling of this mode configurable through DT. Signed-off-by: Heiko Schocher --- .../devicetree/bindings/net/smsc-lan87xx.txt | 19 + drivers/net/phy/smsc.c

Re: [PATCH net-next v3 3/4] bridge: push bridge setting ageing_time down to switchdev

On Sat, Oct 10, 2015 at 8:56 AM, Vivien Didelot wrote: > Scott, didn't you have a plan to add a struct device for the parent of > switchdev ports? I had sent out a rough RFC for a switch device in the last window. I have continued working on it, and I plan

<    1   2   3