Re: [PATCH] net: hisilicon: add OF dependency

2015-10-16 Thread kbuild test robot
Hi Arnd, [auto build test ERROR on net-next/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Arnd-Bergmann/net-hisilicon-add-OF-dependency/20151016-173818 config: um-allyesconfig (attached

Re: SoCFPGA ethernet broken

2015-10-16 Thread Florian Fainelli
On 16/10/15 08:56, Andrew Lunn wrote: >> So I think I'll move to inspect what Florian had suggested, and that was to >> look >> at: drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c::stmmac_mdio_register > > I have a suspicion. If you look at the phy driver it does: > > static int

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-16 Thread Eric W. Biederman
Daniel Borkmann writes: > On 10/16/2015 07:42 PM, Alexei Starovoitov wrote: >> On 10/16/15 10:21 AM, Hannes Frederic Sowa wrote: >>> Another question: >>> Should multiple mount of the filesystem result in an empty fs (a new >>> instance) or in one were one can see other

Re: [PATCH net v2] openvswitch: Allocate memory for ovs internal device stats.

2015-10-16 Thread Pravin Shelar
On Fri, Oct 16, 2015 at 4:07 AM, James Morse wrote: > "openvswitch: Remove vport stats" removed the per-vport statistics, in > order to use the netdev's statistics fields. > "openvswitch: Fix ovs_vport_get_stats()" fixed the export of these stats > to user-space, by using the

Re: [PATCH] net: hisilicon: add OF dependency

2015-10-16 Thread kbuild test robot
Hi Arnd, [auto build test ERROR on net-next/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Arnd-Bergmann/net-hisilicon-add-OF-dependency/20151016-173818 config: x86_64-allmodconfig reproduce

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-16 Thread Alexei Starovoitov
On 10/16/15 10:21 AM, Hannes Frederic Sowa wrote: Another question: Should multiple mount of the filesystem result in an empty fs (a new instance) or in one were one can see other ebpf-fs entities? I think Daniel wanted to already use the mountpoint as some kind of hierarchy delimiter. I would

Re: [PATCH] net: hix5hd2_gmac: avoid integer overload warning

2015-10-16 Thread Joe Perches
On Fri, 2015-10-16 at 13:28 +0200, Arnd Bergmann wrote: > On Friday 16 October 2015 11:14:44 David Laight wrote: > > From: Arnd Bergmann > > > Sent: 16 October 2015 11:01 > > > BITS_RX_EN is an 'unsigned long' constant, so the ones complement of that > > > has bits set that do not fit into a

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-16 Thread Alexei Starovoitov
On 10/16/15 9:43 AM, Hannes Frederic Sowa wrote: Hi Alexei, On Fri, Oct 16, 2015, at 18:18, Alexei Starovoitov wrote: On 10/16/15 3:25 AM, Hannes Frederic Sowa wrote: Namespaces at some point dealt with the same problem, they nowadays use bind mounts of/proc/$$/ns/* to some place in the file

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-16 Thread Thomas Graf
On 10/16/15 at 10:32am, Alexei Starovoitov wrote: > On 10/16/15 9:43 AM, Hannes Frederic Sowa wrote: > >Oh, tracing does not allow daemons. Why? I can only imagine embedded > >users, no? > > yes and for networking: restartability and HA. > cannot really do that with fuse/daemons. Right, the

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-16 Thread Alexei Starovoitov
On 10/16/15 10:27 AM, Daniel Borkmann wrote: but don't know how flexible we are in terms of adding S_IFBPF to the UAPI. I don't think it should be a problem. You referred to POSIX Standard in your other mail but I can't see any reason why not to establish a new file mode. Anyway, FreeBSD (e.g.

[PATCHv2 net] openvswitch: Scrub skb between namespaces

2015-10-16 Thread Joe Stringer
If OVS receives a packet from another namespace, then the packet should be scrubbed. However, people have already begun to rely on the behaviour that skb->mark is preserved across namespaces, so retain this one field. This is mainly to address information leakage between namespaces when using OVS

[PATCHv2 net 2/3] openvswitch: Treat IP_CT_RELATED as new

2015-10-16 Thread Joe Stringer
New, related connections are marked as such as part of ovs_ct_lookup(), but they are not marked as "new" if the commit flag is used. Make this consistent by treating IP_CT_RELATED as new as well. Reported-by: Jarno Rajahalme Signed-off-by: Joe Stringer

[PATCHv2 net 1/3] openvswitch: Reject ct_state masks for unknown bits

2015-10-16 Thread Joe Stringer
Currently, 0-bits are generated in ct_state where the bit position is undefined, and matches are accepted on these bit-positions. If userspace requests to match the 0-value for this bit then it may expect only a subset of traffic to match this value, whereas currently all packets will have this

[PATCHv2 net 3/3] openvswitch: Serialize nested ct actions if provided

2015-10-16 Thread Joe Stringer
If userspace provides a ct action with no nested mark or label, then the storage for these fields is zeroed. Later when actions are requested, such zeroed fields are serialized even though userspace didn't originally specify them. Fix the behaviour by ensuring that no action is serialized in this

Re: [PATCHv2 net 3/3] openvswitch: Serialize nested ct actions if provided

2015-10-16 Thread Pravin Shelar
On Fri, Oct 16, 2015 at 11:08 AM, Joe Stringer wrote: > If userspace provides a ct action with no nested mark or label, then the > storage for these fields is zeroed. Later when actions are requested, > such zeroed fields are serialized even though userspace didn't >

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-16 Thread Alexei Starovoitov
On 10/16/15 11:41 AM, Eric W. Biederman wrote: Daniel Borkmann writes: On 10/16/2015 07:42 PM, Alexei Starovoitov wrote: On 10/16/15 10:21 AM, Hannes Frederic Sowa wrote: Another question: Should multiple mount of the filesystem result in an empty fs (a new instance)

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-16 Thread Daniel Borkmann
On 10/16/2015 07:42 PM, Alexei Starovoitov wrote: On 10/16/15 10:21 AM, Hannes Frederic Sowa wrote: Another question: Should multiple mount of the filesystem result in an empty fs (a new instance) or in one were one can see other ebpf-fs entities? I think Daniel wanted to already use the

Re: [PATCH] net: hisilicon: add OF dependency

2015-10-16 Thread Joe Perches
On Sat, 2015-10-17 at 02:16 +0800, kbuild test robot wrote: > All errors (new ones prefixed by >>): >drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c: In function > 'hns_dsaf_get_cfg': > >> drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:151:3: error: implicit > >> declaration of

Re: [PATCH nf-next 1/6] netfilter-ipv4: Line layout whitespace fixes

2015-10-16 Thread Pablo Neira Ayuso
On Wed, Oct 14, 2015 at 11:17:03PM +0100, Ian Morris wrote: > Cleanses some whitespace issues by removing a leading space before a tab. > > No changes detected by objdiff. > > Signed-off-by: Ian Morris > --- > net/ipv4/netfilter/ipt_ECN.c | 2 +- >

Re: SoCFPGA ethernet broken

2015-10-16 Thread Dinh Nguyen
On Fri, 16 Oct 2015, David Daney wrote: > On 10/16/2015 08:56 AM, Andrew Lunn wrote: > > > So I think I'll move to inspect what Florian had suggested, and that was > > > to look > > > at: > > > drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c::stmmac_mdio_register > > > > I have a suspicion. If

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-16 Thread Daniel Borkmann
On 10/16/2015 06:36 PM, Hannes Frederic Sowa wrote: On Fri, Oct 16, 2015, at 15:36, Daniel Borkmann wrote: On 10/16/2015 12:25 PM, Hannes Frederic Sowa wrote: On Fri, Oct 16, 2015, at 03:09, Daniel Borkmann wrote: This eventually leads us to this patch, which implements a minimal eBPF file

Re: [PATCH] net: hisilicon: add OF dependency

2015-10-16 Thread Arnd Bergmann
/net-hisilicon-add-OF-dependency/20151016-173818 > config: ia64-allmodconfig (attached as .config) > reproduce: > wget > https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross > -O ~/bin/make.cross > chmod +x ~/bin/make.cross >

[PATCH net-next] tcp: do not set queue_mapping on SYNACK

2015-10-16 Thread Eric Dumazet
From: Eric Dumazet At the time of commit fff326990789 ("tcp: reflect SYN queue_mapping into SYNACK packets") we had little ways to cope with SYN floods. We no longer need to reflect incoming skb queue mappings, and instead can pick a TX queue based on cpu cooking the

Re: [PATCH net-next 1/2] drivers: net: xgene: Add support RGMII TX/RX delay configuration

2015-10-16 Thread Florian Fainelli
On 16/10/15 13:35, Iyappan Subramanian wrote: > Add RGMII TX/RX delay configuration support. RGMII standard requires 2ns > delay to help the RGMII bridge receiver to sample data correctly. If the > default value does not provide proper centering of the data sample, the > TX/RX delay parameters can

Re: SoCFPGA ethernet broken

2015-10-16 Thread Andrew Lunn
> > Maybe we need to walk up the hierarchy. > > > > Perhaps something like: > > > > const struct device *dev_walker; > > > > dev_walker = >dev; > > do { > >of_node = dev_walker->of_node; > >dev_walker = dev_walker->parent; > > } while (!of_node && dev_walker); > > > > The above code

Re: [PATCH] net: hix5hd2_gmac: avoid integer overload warning

2015-10-16 Thread Arnd Bergmann
On Friday 16 October 2015 14:22:15 Joe Perches wrote: > On Fri, 2015-10-16 at 21:50 +0300, Sergei Shtylyov wrote: > > On 10/16/2015 09:04 PM, Joe Perches wrote: > > > > BITS_RX_EN is an 'unsigned long' constant, so the ones complement of > > that > > has bits set that do not fit

Re: [PATCH] net: hix5hd2_gmac: avoid integer overload warning

2015-10-16 Thread Joe Perches
On Fri, 2015-10-16 at 21:50 +0300, Sergei Shtylyov wrote: > On 10/16/2015 09:04 PM, Joe Perches wrote: > > BITS_RX_EN is an 'unsigned long' constant, so the ones complement of that > has bits set that do not fit into a 32-bit variable on 64-bit > architectures, > which causes

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-16 Thread Eric W. Biederman
Alexei Starovoitov writes: > On 10/16/15 11:41 AM, Eric W. Biederman wrote: [...] >> I am missing something. >> >> When I suggested using a filesystem it was my thought there would be >> exactly one superblock per map, and the map would be specified at mount >> time. You

[PATCH net-next 1/2] drivers: net: xgene: Add support RGMII TX/RX delay configuration

2015-10-16 Thread Iyappan Subramanian
Add RGMII TX/RX delay configuration support. RGMII standard requires 2ns delay to help the RGMII bridge receiver to sample data correctly. If the default value does not provide proper centering of the data sample, the TX/RX delay parameters can be used to adjust accordingly. Signed-off-by:

[PATCH net-next 2/2] Documentation: dts: xgene: Add TX/RX delay field

2015-10-16 Thread Iyappan Subramanian
Signed-off-by: Iyappan Subramanian --- Documentation/devicetree/bindings/net/apm-xgene-enet.txt | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/devicetree/bindings/net/apm-xgene-enet.txt

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-16 Thread Alexei Starovoitov
On 10/16/15 12:53 PM, Eric W. Biederman wrote: Alexei Starovoitov writes: On 10/16/15 11:41 AM, Eric W. Biederman wrote: [...] I am missing something. When I suggested using a filesystem it was my thought there would be exactly one superblock per map, and the map would

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-16 Thread Daniel Borkmann
On 10/16/2015 09:27 PM, Alexei Starovoitov wrote: On 10/16/15 11:41 AM, Eric W. Biederman wrote: Daniel Borkmann writes: On 10/16/2015 07:42 PM, Alexei Starovoitov wrote: On 10/16/15 10:21 AM, Hannes Frederic Sowa wrote: Another question: Should multiple mount of the

Re: [patch net-next 00/15] mlxsw: Driver update, cleanups

2015-10-16 Thread David Miller
From: Jiri Pirko Date: Thu, 15 Oct 2015 17:43:14 +0200 > This patchset contains various cleanups and improvements in mlxsw driver. Series applied, thanks Jiri. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [net-next 00/17][pull request] Intel Wired LAN Driver Updates 2015-10-15

2015-10-16 Thread David Miller
From: Jeff Kirsher Date: Thu, 15 Oct 2015 14:43:07 -0700 > This series contains updates to e1000, e1000e, igb, igbvf, ixgbe, ixgbevf, > i40e, i40evf and fm10k. Please fix the missing space issue pointed out by Sergei and resend this pull request, thanks. -- To

Re: [RFC PATCH net-next 0/9] netlink: strict attribute checking option

2015-10-16 Thread David Miller
From: Jiri Benc Date: Fri, 16 Oct 2015 09:39:45 +0200 > I'm targeting net-next only and don't intend to bring this to older > kernels. The patchset is designed in the way that it's possible to > detect that the kernel does not support strict attribute checking. When > this is

Re: [PATCH iproute2] ip monitor neigh: Change 'delete' to 'Deleted' to be consistent with ip route

2015-10-16 Thread Nicolas Dichtel
Le 15/10/2015 20:47, Roopa Prabhu a écrit : From: Roopa Prabhu It helps to grep for one string "Deleted" when monitoring all events. Fixes: 6ea3ebafe077 ("iproute2: inform user when a neighbor is removed") Signed-off-by: Roopa Prabhu

Re: [PATCH net 0/2] ipv6: Initialize rt6_info properly in ip6_blackhole_route()

2015-10-16 Thread David Miller
From: Martin KaFai Lau Date: Thu, 15 Oct 2015 16:39:56 -0700 > This patchset ensures the rt6_info's fields are initialized properly > in ip6_blackhole_route() where xfrm_policy is the primarily user. > The first patch is a prep work. The second patch is the fix. It > fixes

Re: [PATCH net 1/2] overflow-arith: begin to add support for overflow builtin functions

2015-10-16 Thread David Miller
From: Hannes Frederic Sowa Date: Thu, 15 Oct 2015 14:07:04 +0200 > The idea of the overflow-arith.h header is to collect overflow checking > functions in one central place. > > If gcc compiler supports the __builtin_overflow_* builtins we use them > because they

Re: [patch net-next v5 3/8] switchdev: allow caller to explicitly request attr_set as deferred

2015-10-16 Thread Jiri Pirko
Thu, Oct 15, 2015 at 05:21:22PM CEST, john.fastab...@gmail.com wrote: >On 15-10-14 10:40 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Caller should know if he can call attr_set directly (when holding RTNL) >> or if he has to defer the att_set processing for later. >> >>

Re: [PATCH net-next V16 0/3] openvswitch: Add support for 802.1ad

2015-10-16 Thread David Miller
From: Thomas F Herbert Date: Thu, 15 Oct 2015 10:01:52 -0400 > This patch accompanies version 14 of the user level openvswitch patch > submitted to openvswitch dev list. > > V16,15: Implement reviewer comments. Missing signoffs, missed handling of feedback from

Re: [RFC PATCH net-next 0/9] netlink: strict attribute checking option

2015-10-16 Thread David Miller
From: Jiri Benc Date: Thu, 15 Oct 2015 18:39:05 +0200 > When sending a netlink request (NLM_F_REQUEST), any unknown attributes are > ignored. This behavior is problematic in some situations. For example if the > user asks for a particular config, the request finishes

Re: [PATCH net-next 0/7] tipc: some link level code improvements

2015-10-16 Thread David Miller
From: Jon Maloy Date: Thu, 15 Oct 2015 14:52:39 -0400 > Extensive testing has revealed some weaknesses and non-optimal solutions > in the link level code. > > This commit series addresses those issues. Series applied, thanks Jon. -- To unsubscribe from this list: send

[PATCH V3 2/2] bpf: control all the perf events stored in PERF_EVENT_ARRAY maps

2015-10-16 Thread Kaixu Xia
This patch implements the function that controlling all the perf events stored in PERF_EVENT_ARRAY maps by setting the parameter 'index' to maps max_entries. Signed-off-by: Kaixu Xia --- kernel/trace/bpf_trace.c | 20 ++-- 1 file changed, 18 insertions(+), 2

[PATCH V3 0/2] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling

2015-10-16 Thread Kaixu Xia
Previous patch V2 url: https://lkml.org/lkml/2015/10/14/347 This patchset introduces the new perf_event_attr attribute 'dump_enable'. The already existed 'disabled' flag doesn't meet the requirements. The cpu_function_call is too much to do from bpf program and we control the perf_event stored

Re: [PATCH] xen-netback: corretly check failed allocation

2015-10-16 Thread David Miller
From: Insu Yun Date: Thu, 15 Oct 2015 12:26:16 -0400 > Since vzalloc can be failed in memory pressure, > return value should be checked and return ENOMEM. > > Signed-off-by: Insu Yun > --- > drivers/net/xen-netback/xenbus.c | 5 + > 1 file changed, 5

Re: [PATCH 2/2] isdn: correctly check failed allocation

2015-10-16 Thread David Miller
From: Insu Yun Date: Thu, 15 Oct 2015 12:29:28 -0400 > Since skb_clone is memory allocation, it could be failed when lack of > resource. > Therefore, return value of skb_clone needs to be checked and handle error. > > Signed-off-by: Insu Yun > --- >

Re: [PATCH] mlx4: corretly check failed allocation

2015-10-16 Thread David Miller
From: Insu Yun Date: Thu, 15 Oct 2015 12:24:09 -0400 > When allocation fails, mlx4_alloc_cmd_mailbox returns -ENOMEM. > Since there is no case that mlx4_alloc_cmd_mailbox returns NULL, > it needs to be checked by IS_ERR, not IS_ERR_OR_NULL > > Signed-off-by: Insu Yun

[PATCH v3] netfilter: ipset: Fix sleeping memory allocation in atomic context

2015-10-16 Thread Nikolay Borisov
Commit 00590fdd5be0 introduced RCU locking in list type and in doing so introduced a memory allocation in list_set_add, which is done in an atomic context, due to the fact that ipset rcu list modifications are serialised with a spin lock. The reason why we can't use a mutex is that in addition

Re: [PATCH net-next v3] drivers/net: get rid of unnecessary initializations in .get_drvinfo()

2015-10-16 Thread David Miller
From: Ivan Vecera Date: Thu, 15 Oct 2015 21:28:52 +0200 > Many drivers initialize uselessly n_priv_flags, n_stats, testinfo_len, > eedump_len & regdump_len fields in their .get_drvinfo() ethtool op. > It's not necessary as these fields is filled in ethtool_get_drvinfo(). > >

Re: [PATCH net 1/1] via-rhine: fix VLAN receive handling regression.

2015-10-16 Thread David Miller
From: Francois Romieu Date: Thu, 15 Oct 2015 00:14:37 +0200 > From: Andrej Ota > > Because eth_type_trans() consumes ethernet header worth of bytes, a call > to read TCI from end of packet using rhine_rx_vlan_tag() no longer works > as it's reading from an

Re: [PATCH v2 net-next 0/3] tcp/dccp: make our listener code more robust

2015-10-16 Thread David Miller
From: Eric Dumazet Date: Wed, 14 Oct 2015 11:16:25 -0700 > This patch series addresses request sockets leaks and listener dismantle > phase. This survives a stress test with listeners being added/removed > quite randomly. Series applied, thanks Eric. -- To unsubscribe from

Re: [RFC PATCH net-next 0/9] netlink: strict attribute checking option

2015-10-16 Thread David Miller
From: Jiri Benc Date: Fri, 16 Oct 2015 09:49:51 +0200 > On Fri, 16 Oct 2015 00:07:12 +0200, Hannes Frederic Sowa wrote: >> Do you plan to update rfc3549, too? :} > > No. > > While I think we need to have a detailed documentation on netlink, > I believe it should reside in

Re: [RFC PATCH net-next 0/9] netlink: strict attribute checking option

2015-10-16 Thread Jiri Benc
On Fri, 16 Oct 2015 01:06:44 -0700 (PDT), David Miller wrote: > No, it's definitely not OK, because lwtunnel support exists in > Linus's tree. > > And tools should be able to work on all kernels where lwtunnel support > is available. You can consider the lwtunnels feature as not finished in the

Re: [RFC PATCH net-next 0/9] netlink: strict attribute checking option

2015-10-16 Thread Jiri Benc
On Fri, 16 Oct 2015 01:08:26 -0700 (PDT), David Miller wrote: > I think his point is that you'll be making changes to an RFC specified > protocol. The RFC is only informational, it has never became an Internet standard (under the RFC terms). And no other OS picked it up. Keeping kernel uAPI

Re: [PATCH net 1/2] isdn_ppp: Add checks for allocation failure in isdn_ppp_open()

2015-10-16 Thread David Miller
From: Ben Hutchings Date: Wed, 14 Oct 2015 18:51:14 +0100 > Compile-tested only. > > Signed-off-by: Ben Hutchings > --- >  drivers/isdn/i4l/isdn_ppp.c | 6 ++ >  1 file changed, 6 insertions(+) > > diff --git a/drivers/isdn/i4l/isdn_ppp.c

Re: [RFC PATCH net-next 0/9] netlink: strict attribute checking option

2015-10-16 Thread Jiri Benc
On Thu, 15 Oct 2015 23:50:07 -0700 (PDT), David Miller wrote: > Although we are probably stuck with this, it was probably a bad idea > to have this behavior as the default. I agree. But we have what we have. > Better would have been to always error on unrecognized attributes, and > in the ACK

Re: [PATCH net-next] bpf: Need to call bpf_prog_uncharge_memlock from bpf_prog_put

2015-10-16 Thread David Miller
From: Tom Herbert Date: Wed, 14 Oct 2015 14:40:44 -0700 > Currently, is only called from __prog_put_rcu in the bpf_prog_release > path. Need this to call this from bpf_prog_put also to get correct > accounting. > > Fixes: commit aaac3ba95e4c8b49 ("bpf: charge user for

Re: [PATCH net-next] net: Fix suspicious RCU usage in fib_rebalance

2015-10-16 Thread David Miller
From: David Ahern Date: Wed, 14 Oct 2015 16:44:00 -0700 > This command: > ip route add 192.168.1.0/24 nexthop via 10.2.1.5 dev eth1 nexthop via > 10.2.2.5 dev eth2 > > generated this suspicious RCU usage message: ... > It looks like all of the code paths to

Re: [RFC PATCH net-next 0/9] netlink: strict attribute checking option

2015-10-16 Thread Thomas Graf
On 10/16/15 at 10:02am, Jiri Benc wrote: > On Fri, 16 Oct 2015 01:06:44 -0700 (PDT), David Miller wrote: > > No, it's definitely not OK, because lwtunnel support exists in > > Linus's tree. > > > > And tools should be able to work on all kernels where lwtunnel support > > is available. > > You

Re: [PATCH iproute2] ip route get: change exit to return to support batch commands

2015-10-16 Thread Vadim Kochan
On Thu, Oct 15, 2015 at 08:13:23PM -0700, roopa wrote: > On 10/15/15, 7:38 PM, David Ahern wrote: > > Hi Roopa: > > > > On 10/15/15 4:23 PM, Roopa Prabhu wrote: > >> From: Roopa Prabhu > >> > >> replace exit with return -2 on rtnl_talk failure > >> > >> Signed-off-by:

Re: [PATCH net-next] bonding: support encapsulated ipv6 TSO

2015-10-16 Thread David Miller
From: Eric Dumazet Date: Thu, 15 Oct 2015 09:22:11 -0700 > From: Eric Dumazet > > If using a sixtofour device on top of a bonding device, > skb segmentation of TCP traffic is done right before calling > bonding xmit, because bonding only enables TSO

[PATCH V3 1/2] bpf: control the trace data output on current cpu when perf sampling

2015-10-16 Thread Kaixu Xia
This patch adds the flag dump_enable to control the trace data output process when perf sampling. By setting this flag and integrating with ebpf, we can control the data output process and get the samples we are most interested in. The bpf helper bpf_perf_event_dump_control() can control the

[PATCH] net: hisilicon: add OF dependency

2015-10-16 Thread Arnd Bergmann
The HNS MDIO driver fails to build on older ARM machines that are not yet converted to CONFIG_OF: drivers/net/ethernet/hisilicon/hns_mdio.c: In function 'hns_mdio_bus_name': drivers/net/ethernet/hisilicon/hns_mdio.c:405:14: error: 'OF_BAD_ADDR' undeclared (first use in this function) u64 taddr

Re: [RFC PATCH net-next 0/9] netlink: strict attribute checking option

2015-10-16 Thread Hannes Frederic Sowa
Hi, On Fri, Oct 16, 2015, at 10:08, Jiri Benc wrote: > On Fri, 16 Oct 2015 01:08:26 -0700 (PDT), David Miller wrote: > > I think his point is that you'll be making changes to an RFC specified > > protocol. > > The RFC is only informational, it has never became an Internet > standard (under the

Re: [PATCH net-next v3 1/2] net: hisilicon rm hnae sysfs interface

2015-10-16 Thread Arnd Bergmann
On Friday 16 October 2015 11:54:16 huangdaode wrote: > This patch removes the hns driver hnae sysfs interface according to > Arnd's review comments. > > Signed-off-by: huangdaode > Reviewed-by: Arnd Bergmann Thanks! Arnd -- To unsubscribe

[PATCH net-next 1/2] net: hns: fixes the issue by using ethtool -s

2015-10-16 Thread yankejian
From: Chenny Xu before this patch, hns driver only permits user to set the net device by using ethtool -s when the device is link up. it is obviously not so good. it needs to be set no matter it is link up or down. so this patch fixes this issue. Signed-off-by: yankejian

Re: [PATCH] xen-netback: correctly check failed allocation

2015-10-16 Thread Wei Liu
On Thu, Oct 15, 2015 at 02:02:47PM -0400, Insu Yun wrote: > I changed patch with valid format. > > On Thu, Oct 15, 2015 at 2:02 PM, Insu Yun wrote: > > > Since vzalloc can be failed in memory pressure, > > writes -ENOMEM to xenstore to indicate error. > > > > Signed-off-by:

Re: [PATCH net-next v3 0/2] net: hisilicon fix some bugs in HNS drivers

2015-10-16 Thread Arnd Bergmann
On Friday 16 October 2015 11:54:15 huangdaode wrote: > This patchset fixes the two bugs in HNS driver, one is remove the hnae sysfs > interface > according to the review comments from Arnd Bergmann , another > is fixing the wrong mac_id judgement bug which is found during internal

[PATCH] net: hisilicon: include linux/vmalloc.h in dsaf

2015-10-16 Thread Arnd Bergmann
Some configurations fail to build the hns dsaf code because of a missing header file: ethernet/hisilicon/hns/hns_dsaf_main.c: In function 'hns_dsaf_init': ethernet/hisilicon/hns/hns_dsaf_main.c:1096:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]

[PATCH iproute2] ip-address: fix oneline mode for interfaces with VF

2015-10-16 Thread Phil Sutter
From: Phil Sutter --- ip/ipaddress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/ipaddress.c b/ip/ipaddress.c index e864ca6..f290205 100644 --- a/ip/ipaddress.c +++ b/ip/ipaddress.c @@ -345,7 +345,7 @@ static void

[PATCH net-next 2/2] net: hns: fixes a bug about timeout by pause frame

2015-10-16 Thread yankejian
From: lisheng this patch fixes the bug triggered timeout sequence. when the connective ports cannot accept the packets with higher speed, they will send out the pause frame to the Soc's mac. At that time, the driver resets the relevant of the Soc, then it causes the

Re: [RFC PATCH net-next 0/9] netlink: strict attribute checking option

2015-10-16 Thread Jiri Benc
On Fri, 16 Oct 2015 11:40:11 +0200, Hannes Frederic Sowa wrote: > I would suggest you simply add a description to the rfc via the errata > process here: > > The original cover letter should be enough to post there. I am also not > sure if people do

[PATCH] ipv6: no addrconf for slave devices

2015-10-16 Thread Jan Blunck
If a device without the IFF_SLAVE flag set (e.g. team, bridge, openvswitch vport, batman) is enslaved and IPv6 is active then addrconf will be initiated and a link-local address is added to the slave interface. This patch alters the behavior so that addrconf will only run on the master device

[PATCH v2 iproute2] ip-address: fix oneline mode for interfaces with VF

2015-10-16 Thread Phil Sutter
Signed-off-by: Phil Sutter --- Changed since v1: Fix commit message - typo in From: header confused git-send-email. --- ip/ipaddress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/ipaddress.c b/ip/ipaddress.c index e864ca6..f290205 100644

[PATCH 6/6] arcnet: add netif_carrier_on/off for reconnect

2015-10-16 Thread Michael Grzeschik
The arcnet device has no interrupt to detect if the link has changed from disconnected to connected. This patch adds an timer to toggle the link detection. The timer will get retriggered as long as the reconnection interrupts accure. If the recon interrupts hold off for >1s we define the

[PATCH 2/6] arcnet: com20020: add enable and disable device on open/close

2015-10-16 Thread Michael Grzeschik
This patch changes the driver to properly work with the linux netif interface. The controller gets enabled on open and disabled on close. Therefor it removes every bogus start of the xceiver. It only gets enabled on com20020_open and disabled on com20020_close. Signed-off-by: Michael Grzeschik

[PATCH 5/6] arcnet: com20020-pci: add led trigger support

2015-10-16 Thread Michael Grzeschik
The EAE PLX-PCI card has special leds on the the main io pci resource bar. This patch adds support to trigger the conflict and data leds with the packages. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/arcdevice.h| 19 ++

[PATCH 1/6] arcnet: move dev_free_skb to its only user

2015-10-16 Thread Michael Grzeschik
The call for dev_free_skb is done only once. This patch moves its call to its only user and removes the obsolete condition variable. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/arcnet.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-)

Re: [PATCH net-next V16 0/3] openvswitch: Add support for 802.1ad

2015-10-16 Thread Thomas F Herbert
On 10/16/15 2:16 AM, David Miller wrote: From: Thomas F Herbert Date: Thu, 15 Oct 2015 10:01:52 -0400 This patch accompanies version 14 of the user level openvswitch patch submitted to openvswitch dev list. V16,15: Implement reviewer comments. Missing

[PATCH 4/6] arcnet: com20020-pci: add rotary index support

2015-10-16 Thread Michael Grzeschik
The EAE PLX-PCI card has a special rotary encoder to configure the address of every card individually. We take this information for the initial setup of the cards dev_id. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com20020-pci.c | 33

[GIT PULL] ARCNET: features and fixes

2015-10-16 Thread Michael Grzeschik
The following changes since commit 51161aa98d0aa4eb20952e16d6c6dbb1d085330e: net: Fix suspicious RCU usage in fib_rebalance (2015-10-16 00:57:55 -0700) are available in the git repository at: git://git.pengutronix.de/git/mgr/linux.git tags/arcnet-v4.3-rc5 for you to fetch changes up to

Re: [PATCH v2] netfilter: ipset: Fix sleeping memory allocation in atomic context

2015-10-16 Thread Pablo Neira Ayuso
On Thu, Oct 15, 2015 at 01:53:11PM -0700, Eric Dumazet wrote: > On Thu, 2015-10-15 at 23:20 +0300, Nikolay Borisov wrote: > > > While GFP_ATOMIC does indeed look the correct solution for this particular > > case I was wondering whether something like (GFP_KERNEL & ~__GFP_WAIT) > > wouldn't also

Re: [PATCH] xen-netback: correctly check failed allocation

2015-10-16 Thread Wei Liu
On Fri, Oct 16, 2015 at 10:05:21AM +0100, Wei Liu wrote: > On Thu, Oct 15, 2015 at 02:02:47PM -0400, Insu Yun wrote: > > I changed patch with valid format. > > > > On Thu, Oct 15, 2015 at 2:02 PM, Insu Yun wrote: > > > > > Since vzalloc can be failed in memory pressure, > > >

Re: [PATCH 1/1] xen-netfront: update num_queues to real created

2015-10-16 Thread Wei Liu
CC David and Boris (Konrad was already a recipient). On Thu, Oct 15, 2015 at 10:34:15AM +0800, Joe Jin wrote: > Sometimes xennet_create_queues() may failed to created all requested > queues, we need to update num_queues to real created to avoid NULL > pointer dereference. > > Signed-off-by: Joe

Re: [PATCH v2] netfilter: ipset: Fix sleeping memory allocation in atomic context

2015-10-16 Thread Jozsef Kadlecsik
On Thu, 15 Oct 2015, Eric Dumazet wrote: > On Thu, 2015-10-15 at 23:20 +0300, Nikolay Borisov wrote: > > > While GFP_ATOMIC does indeed look the correct solution for this particular > > case I was wondering whether something like (GFP_KERNEL & ~__GFP_WAIT) > > wouldn't also make the cut without

[PATCH net RESEND 0/2] overflow-arith: begin to add support for overflow builtins functions

2015-10-16 Thread Hannes Frederic Sowa
Hello, I add a new header, linux/overflow-arith.h, as the central place to add overflow and wrap-around checking functions. The reason I am doing so is that it can make use of compiler supported builtin functions which can leverage hardware. As I need this for a fix in the ipv6 stack, which is

[PATCH net RESEND 1/2] overflow-arith: begin to add support for overflow builtin functions

2015-10-16 Thread Hannes Frederic Sowa
The idea of the overflow-arith.h header is to collect overflow checking functions in one central place. If gcc compiler supports the __builtin_overflow_* builtins we use them because they might give better performance, otherwise the code falls back to normal overflow checking functions. The

[PATCH net RESEND 2/2] ipv6: protect mtu calculation of wrap-around and infinite loop by rounding issues

2015-10-16 Thread Hannes Frederic Sowa
Raw sockets with hdrincl enabled can insert ipv6 extension headers right into the data stream. In case we need to fragment those packets, we reparse the options header to find the place where we can insert the fragment header. If the extension headers exceed the link's MTU we actually cannot make

Re: [Xen-devel] [PATCH] xen-netback: correctly check failed allocation

2015-10-16 Thread David Vrabel
On 16/10/15 10:05, Wei Liu wrote: > On Thu, Oct 15, 2015 at 02:02:47PM -0400, Insu Yun wrote: >> I changed patch with valid format. >> >> On Thu, Oct 15, 2015 at 2:02 PM, Insu Yun wrote: >> >>> Since vzalloc can be failed in memory pressure, >>> writes -ENOMEM to xenstore to

[PATCH] net: hix5hd2_gmac: avoid integer overload warning

2015-10-16 Thread Arnd Bergmann
BITS_RX_EN is an 'unsigned long' constant, so the ones complement of that has bits set that do not fit into a 32-bit variable on 64-bit architectures, which causes a harmless gcc warning: drivers/net/ethernet/hisilicon/hix5hd2_gmac.c: In function 'hix5hd2_port_disable':

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-16 Thread Hannes Frederic Sowa
On Fri, Oct 16, 2015, at 03:09, Daniel Borkmann wrote: > This eventually leads us to this patch, which implements a minimal > eBPF file system. The idea is a bit similar, but to the point that > these inodes reside at one or multiple mount points. A directory > hierarchy can be tailored to a

Re: [PATCH v3] netfilter: ipset: Fix sleeping memory allocation in atomic context

2015-10-16 Thread Jozsef Kadlecsik
On Fri, 16 Oct 2015, Nikolay Borisov wrote: > Commit 00590fdd5be0 introduced RCU locking in list type and in > doing so introduced a memory allocation in list_set_add, which > is done in an atomic context, due to the fact that ipset rcu > list modifications are serialised with a spin lock. The

[patch net-next 01/16] net: introduce pre-change upper device notifier

2015-10-16 Thread Jiri Pirko
From: Jiri Pirko This newly introduced netdevice notifier is called before actual change upper happens. That provides a possibility for notifier handlers to know upper change will happen and react to it, including possibility to forbid the change. That is valuable for drivers

[net-next v2 01/17] i40e/i40evf: Fix handling of napi budget

2015-10-16 Thread Jeff Kirsher
From: Alexander Duyck The polling routine for i40e was rounding up the budget for Rx cleanup to 1. This is incorrect as the netpoll poll call is expecting no Rx to be processed as the budget passed was 0. Signed-off-by: Alexander Duyck Tested-by:

[net-next v2 06/17] i40e/i40evf: Fix compile issue related to const string

2015-10-16 Thread Jeff Kirsher
From: Jingjing Wu Add const to functions that return strings that aren't going to be modified. This addresses some reported compile complaints. Change-ID: Ic56b1e814ab4d23a50480e7fdec652445f776ee8 Signed-off-by: Jingjing Wu Tested-by: Andrew Bowers

[net-next v2 08/17] i40e: Removed unused defines

2015-10-16 Thread Jeff Kirsher
From: Greg Rose Two defines that are not used are causing customer confusion - remove them. Change-ID: Icef0325aca8e0f4fcdfc519e026bdd375e791200 Signed-off-by: Greg Rose Tested-by: Andrew Bowers Signed-off-by: Jeff

[net-next v2 05/17] i40e: generate fewer startup messages

2015-10-16 Thread Jeff Kirsher
From: Shannon Nelson Cut down on the number of startup log entries by putting a couple behind debug flags and combining a couple others into a single line. Change-ID: I708089f086308f84d43f8b6f0e8a634a02d058fb Signed-off-by: Shannon Nelson

[net-next v2 11/17] i40e/i40evf: moderate interrupts differently

2015-10-16 Thread Jeff Kirsher
From: Jesse Brandeburg The XL710 hardware has a different interrupt moderation design that can support a limit of total interrupts per second per vector, in addition to the "number of interrupts per second" controls already established in the driver. This combination

[net-next v2 13/17] i40evf: correctly populate vlan_features

2015-10-16 Thread Jeff Kirsher
From: Mitch Williams The vlan_features field was correctly being set to the same value as the netdev features field. However, this was being done before the features were actually being set up, leaving the vlan_features empty. Also, after a reset, vlan_features will

[net-next v2 12/17] i40e: reset the invalid msg counter in vf when a valid msg is received

2015-10-16 Thread Jeff Kirsher
From: Jingjing Wu When the number of invalid messages from a VF is exceeded, the VF will be disabled, due to the invalid messages. This happens if other VF drivers (like DPDK) send a message through the driver's mailbox (aka virtchannel) interface, but the message is not

  1   2   3   >