Re: [PATCH] usbnet: removed USB_USBNET as a config option

2015-10-20 Thread Oliver Neukum
On Mon, 2015-10-19 at 21:16 +0200, Bjørn Mork wrote: > Oliver Neukum writes: > > > usbnet drives no devices of its own. It makes more sense to > > select it whenever a driver for actual hardware that needs > > it is chosen rather than offer it as an option of its own. > > > >

Re: [PATCH] intel: i40e: fix confused code

2015-10-20 Thread Rasmus Villemoes
On Mon, Oct 19 2015, "Nelson, Shannon" wrote: >> From: Rasmus Villemoes [mailto:li...@rasmusvillemoes.dk] >> Sent: Saturday, October 17, 2015 1:58 PM >> Subject: [PATCH] intel: i40e: fix confused code >> >> This code is pretty confused. The variable name

[PATCH] net: hisilicon: fix ptr_ret.cocci warnings

2015-10-20 Thread kbuild test robot
drivers/net/ethernet/hisilicon/hns/hnae.c:442:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci CC: Arnd Bergmann Signed-off-by: Fengguang Wu ---

[net-next:master 241/245] drivers/net/ethernet/hisilicon/hns/hnae.c:442:1-3: WARNING: PTR_ERR_OR_ZERO can be used

2015-10-20 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 7b4b000951f09cfe3604a6fdf5469894b4e75adb commit: 876133d3161dcb743983d1f9e5bf247aea2fb0f1 [241/245] net: hisilicon: add OF dependency coccinelle warnings: (new ones prefixed by >>) >>

[PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling

2015-10-20 Thread Kaixu Xia
This patch adds the flag soft_enable to control the trace data output process when perf sampling. By setting this flag and integrating with ebpf, we can control the data output process and get the samples we are most interested in. The bpf helper bpf_perf_event_control() can control either the

[PATCH net] ipv4: implement support for NOPREFIXROUTE ifa flag for ipv4 address

2015-10-20 Thread Paolo Abeni
Currently adding a new ipv4 address always cause the creation of the related network route, with default metric. When a host has multiple interfaces on the same network, multiple routes with the same metric are created. If the userspace wants to set specific metric on each routes, i.e. giving

Re: [PATCHv3 net 2/4] openvswitch: Clarify conntrack COMMIT behaviour

2015-10-20 Thread Thomas Graf
On 10/19/15 at 07:18pm, Joe Stringer wrote: > The presence of this attribute does not modify the ct_state for the > current packet, only future packets. Make this more clear in the header > definition. > > Signed-off-by: Joe Stringer Acked-by: Thomas Graf

[PATCH resend] net: sun4i-emac: Properly free resources on probe failure and remove

2015-10-20 Thread Hans de Goede
Fix sun4i-emac not releasing the following resources: -iomapped memory not released on probe-failure nor on remove -clock not getting disabled on probe-failure nor on remove -sram not being released on remove And while at it also add error checking to the clk_prepare_enable call done on probe.

Re: [PATCH] usbnet: removed USB_USBNET as a config option

2015-10-20 Thread Bjørn Mork
Oliver Neukum writes: > On Mon, 2015-10-19 at 21:16 +0200, Bjørn Mork wrote: > >> This looks incomplete. > > Yes, it is against the earlier patch set which introduces the CDC > parser in cdc-acm and cdc-wdm. In hindsight I should have reversed > the order of patches. Ah, right,

[PATCH resend 0/1] net: sun4i-emac: Properly free resources on probe failure

2015-10-20 Thread Hans de Goede
Hi Davem, IIRC you said you would pick this up, but I'm not seeing it in net-next, hence this resend. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-20 Thread Daniel Borkmann
On 10/20/2015 02:30 AM, Alexei Starovoitov wrote: On 10/19/15 3:17 PM, Daniel Borkmann wrote: On 10/19/2015 10:48 PM, Alexei Starovoitov wrote: On 10/19/15 1:03 PM, Hannes Frederic Sowa wrote: I doubt it will stay a lightweight feature as it should not be in the responsibility of user space

Re: [PATCH v4 1/4] Produce system time from correlated clocksource

2015-10-20 Thread Richard Cochran
On Mon, Oct 19, 2015 at 05:36:56PM -0700, John Stultz wrote: > If we're only tracking 4ms of history, how does this solution > measurably improve the error over using the timestamps to generate > MONOTONIC_RAW clock deltas (which doesn't require keeping any history) > and using

Re: [PATCH resend] net: sun4i-emac: Properly free resources on probe failure and remove

2015-10-20 Thread Maxime Ripard
On Tue, Oct 20, 2015 at 10:42:24AM +0200, Hans de Goede wrote: > Fix sun4i-emac not releasing the following resources: > -iomapped memory not released on probe-failure nor on remove > -clock not getting disabled on probe-failure nor on remove > -sram not being released on remove > > And while at

Re: [PATCHv3 net 3/4] openvswitch: Mark connections new when not confirmed.

2015-10-20 Thread Thomas Graf
On 10/19/15 at 07:18pm, Joe Stringer wrote: > New, related connections are marked as such as part of ovs_ct_lookup(), > but they are not marked as "new" if the commit flag is used. Make this > consistent by setting the "new" flag whenever !nf_ct_is_confirmed(ct). > > Reported-by: Jarno Rajahalme

Re: Routing Policy Database Rule 0

2015-10-20 Thread Thomas Graf
On 10/20/15 at 01:58am, Richard Laing wrote: > Hi, > > We recently found a bug in our code which resulted in rule 0 in the > routing policy database being deleted, this is a bad thing and the man > page documentation for "ip rule" indicates > > Rule 0 is special. It cannot be deleted or

Re: [PATCH v2 net-next 3/4] ipv6: Add gro functions to sit_offloads

2015-10-20 Thread Wolfgang Walter
Hello Eric! Am Freitag, 16. Oktober 2015, 08:23:49 schrieb Eric Dumazet: > On Thu, 2015-08-06 at 17:15 -0700, Jesse Gross wrote: > > On Mon, Aug 3, 2015 at 10:11 AM, Tom Herbert wrote: > > > For GRO to work with sit we need gro_receive and gro_complete populated > > > in

Re: [PATCH nf-next 0/4] netfilter: rework netfilter ipv6 defrag

2015-10-20 Thread Joe Stringer
On 17 October 2015 at 13:14, Florian Westphal wrote: > [ CC netdev since patch #2 isn't nf-specific. Dave, if you want > I can resubmit that one after the next nf-pull request; let me know if > you would prefer that ]. > > Openvswitch seems broken wrt. to defragmentation, it

Re: [PATCH] usbnet: removed USB_USBNET as a config option

2015-10-20 Thread Oliver Neukum
On Tue, 2015-10-20 at 10:43 +0200, Bjørn Mork wrote: > Oliver Neukum writes: > > On Mon, 2015-10-19 at 21:16 +0200, Bjørn Mork wrote: > > > >> This looks incomplete. > > > > Yes, it is against the earlier patch set which introduces the CDC > > parser in cdc-acm and cdc-wdm. In

Re: [PATCH 1/2] crypto/x509: Fix unaligned access in x509_get_sig_params()

2015-10-20 Thread David Howells
Sowmini Varadhan wrote: > x509_get_sig_params() has the same code pattern as the one in > pkcs7_verify() that is fixed by commit 62f57d05e287 ("crypto: pkcs7 - Fix > unaligned access in pkcs7_verify()") so apply a similar fix here: make > sure that desc is pointing

[Bug] Linux 4.1.9, NULL pointer dereference in pppoe_release+0x120/0x150

2015-10-20 Thread Andrew
Hi. After BRAS software upgrading (PPPoE daemon + kernel from 3.2.x to 4.1.x) I have different kernel bugs/crashes - some of them don't hurt system, other crashes - cause network subsystem lockup (commands like 'ip a' just hungs; and sometimes even 'reboot -f' doesn't help). It seems like

Re: [PATCH resend 0/1] net: sun4i-emac: Properly free resources on probe failure

2015-10-20 Thread David Miller
From: Hans de Goede Date: Tue, 20 Oct 2015 10:42:23 +0200 > > IIRC you said you would pick this up, but I'm not seeing it in > net-next, hence this resend. If it's not in my tree, and it's not active on patchwork, you really have to resend your patches. Asking me to dig

Re: [PATCH] net: Really fix vti6 with oif in dst lookups

2015-10-20 Thread Steffen Klassert
On Mon, Oct 19, 2015 at 08:26:05AM -0700, David Ahern wrote: > 6e28b000825d ("net: Fix vti use case with oif in dst lookups for IPv6") > is missing the checks on FLOWI_FLAG_SKIP_NH_OIF. Add them. > > Fixes: 42a7b32b73d6 ("xfrm: Add oif to dst lookups") > Cc: Steffen Klassert

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-20 Thread David Miller
From: Alan Burlison Date: Tue, 20 Oct 2015 10:59:46 +0100 > The bug goes into quite some detail about how Solaris behaves. The > issue here is that we have two implementations, Linux and Solaris, > both claiming to be POSIX-conformant but both showing different >

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-20 Thread Hannes Frederic Sowa
Hello Alexei, On Tue, Oct 20, 2015, at 03:09, Alexei Starovoitov wrote: > On 10/19/15 4:02 PM, Hannes Frederic Sowa wrote: > > I bet commercial software will make use of this ebpf framework, too. And > > the kernel always helped me and gave me a way to see what is going on, > > debug which part

Re: [PATCH net] netfilter: xt_TEE: fix NULL dereference

2015-10-20 Thread Pablo Neira Ayuso
On Mon, Oct 19, 2015 at 06:02:01PM -0700, Eric Dumazet wrote: > From: Eric Dumazet > > iptables -I INPUT ... -j TEE --gateway 10.1.2.3 > > because --oif was not specified > > tee_tg_check() sets ->priv pointer to NULL in this case. Applied here, will push it out after

Re: [PATCH v4 1/4] Produce system time from correlated clocksource

2015-10-20 Thread Thomas Gleixner
On Tue, 20 Oct 2015, Richard Cochran wrote: > On Mon, Oct 19, 2015 at 05:36:56PM -0700, John Stultz wrote: > > If we're only tracking 4ms of history, how does this solution > > measurably improve the error over using the timestamps to generate > > MONOTONIC_RAW clock deltas (which doesn't require

Re: [PATCH] usbnet: removed USB_USBNET as a config option

2015-10-20 Thread Bjørn Mork
Oliver Neukum writes: > On Tue, 2015-10-20 at 10:43 +0200, Bjørn Mork wrote: > >> So we might need to move cdc_parse_cdc_header() out of usbnet.c after >> all. Keeping it there creates an unnecessary "select" mess. But I don't >> know where to put it... Either a common CDC

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-20 Thread Hannes Frederic Sowa
Hey Alexei, On Tue, Oct 20, 2015, at 02:30, Alexei Starovoitov wrote: > On 10/19/15 3:17 PM, Daniel Borkmann wrote: > > On 10/19/2015 10:48 PM, Alexei Starovoitov wrote: > >> On 10/19/15 1:03 PM, Hannes Frederic Sowa wrote: > >>> > >>> I doubt it will stay a lightweight feature as it should not

Re: Fw: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-20 Thread Alan Burlison
On 20/10/2015 02:45, Eric Dumazet wrote: On Tue, 2015-10-20 at 02:12 +0100, Alan Burlison wrote: Another problem is that if I call close() on a Linux socket that's in accept() the accept call just sits there until there's an incoming connection, which succeeds even though the socket is

[no subject]

2015-10-20 Thread Andrew
subscribe -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[iproute PATCH] Add ip rule save/restore

2015-10-20 Thread Kirill Tkhai
This patch adds save and restore commands to "ip rule" similar the same is made in commit f4ff11e3e298 for "ip route". The feature is useful in checkpoint/restore for container migration, also it may be helpful in some normal situations. Signed-off-by: Kirill Tkhai ---

Re: [PATCH resend 0/1] net: sun4i-emac: Properly free resources on probe failure

2015-10-20 Thread Hans de Goede
Hi, On 20-10-15 13:17, David Miller wrote: From: Hans de Goede Date: Tue, 20 Oct 2015 10:42:23 +0200 IIRC you said you would pick this up, but I'm not seeing it in net-next, hence this resend. If it's not in my tree, and it's not active on patchwork, you really have to

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-20 Thread Alan Burlison
On 20/10/2015 12:24, David Miller wrote: With two decades of precendence, applications will need to find a way to cope with the behavior on every existing Linux kernel out there. Even if we were to propose something here and change things, it won't be available on real sites for 6 months at a

Re: [PATCH v4 1/4] Produce system time from correlated clocksource

2015-10-20 Thread Richard Cochran
On Tue, Oct 20, 2015 at 12:48:03PM +0200, Thomas Gleixner wrote: > On Tue, 20 Oct 2015, Richard Cochran wrote: > > > On Mon, Oct 19, 2015 at 05:36:56PM -0700, John Stultz wrote: > > > If we're only tracking 4ms of history, how does this solution > > > measurably improve the error over using the

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

2015-10-20 Thread Hajime Tazaki
Hello David, sorry for the delay. At Sun, 11 Oct 2015 12:01:30 -0600, David Ahern wrote: > > On 10/11/15 8:24 AM, Hajime Tazaki wrote: > > > > I've faced this issue since the following patch was applied. > > > > commit 741a11d9e4103a8e1c590ef1280143fe654e4e33 > > Author: David Ahern

Re: [PATCH nf-next 4/4] netfilter: ipv6: avoid nf_iterate recursion

2015-10-20 Thread Joe Stringer
On 17 October 2015 at 13:14, Florian Westphal wrote: > @@ -606,19 +599,22 @@ struct sk_buff *nf_ct_frag6_gather(struct net *net, > struct sk_buff *skb, u32 use > spin_unlock_bh(>q.lock); > pr_debug("Can't insert skb to queue\n"); >

Re: [PATCH nf-next 0/4] netfilter: rework netfilter ipv6 defrag

2015-10-20 Thread Florian Westphal
Joe Stringer wrote: > On 17 October 2015 at 13:14, Florian Westphal wrote: > > [ CC netdev since patch #2 isn't nf-specific. Dave, if you want > > I can resubmit that one after the next nf-pull request; let me know if > > you would prefer that ]. > >

Re: [PATCH nf-next 4/4] netfilter: ipv6: avoid nf_iterate recursion

2015-10-20 Thread Florian Westphal
Joe Stringer wrote: > On 17 October 2015 at 13:14, Florian Westphal wrote: > > @@ -606,19 +599,22 @@ struct sk_buff *nf_ct_frag6_gather(struct net *net, > > struct sk_buff *skb, u32 use > > spin_unlock_bh(>q.lock); > >

[PATCH V5 0/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling

2015-10-20 Thread Kaixu Xia
Previous patch V4 url: https://lkml.org/lkml/2015/10/19/247 This patchset introduces the new perf_event_attr attribute 'soft_disable'. The already existed 'disabled' flag doesn't meet the requirements. The cpu_function_call is too much to do from bpf program and we control the perf_event stored

Re: [PATCH net-next V17 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-10-20 Thread Thomas F Herbert
On 10/19/15 2:28 PM, Pravin Shelar wrote: On Sat, Oct 17, 2015 at 6:12 PM, Thomas F Herbert wrote: Add support for 802.1ad including the ability to push and pop double tagged vlans. Add support for 802.1ad to netlink parsing and flow conversion. Uses double nested

Re: [PATCH 1/2] crypto/x509: Fix unaligned access in x509_get_sig_params()

2015-10-20 Thread Herbert Xu
On Mon, Oct 19, 2015 at 05:23:28PM -0400, Sowmini Varadhan wrote: > x509_get_sig_params() has the same code pattern as the one in > pkcs7_verify() that is fixed by commit 62f57d05e287 ("crypto: pkcs7 - Fix > unaligned access in pkcs7_verify()") so apply a similar fix here: make > sure that desc is

[PATCH net] ipv6: don't use CHECKSUM_PARTIAL on MSG_MORE/UDP_CORK sockets

2015-10-20 Thread Hannes Frederic Sowa
MSG_MORE might cause the packet to get fragmented in the end when passed down to the flush function and the transhdrlen check alone is not sufficient to protect against fragmentation. Instead check if the socket user intends to add more data to the socket on the first packet. This broke checksum

[PATCH v2] net, can, ti_hecc: fix a run time warn_on.

2015-10-20 Thread Anton Glukhov
This patch fixes a warning in clk_enable by calling clk_prepare_enable instead. Signed-off-by: Heiko Schocher Signed-off-by: Anton Glukhov --- drivers/net/can/ti_hecc.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git

[PATCH net-next 3/4] net:hns: Add Hip06 "TSO(TCP Segment Offload)" support HNS Driver

2015-10-20 Thread Salil
From: Salil Mehta This patch adds the support of "TSO (TCP Segment Offload)" feature provided by the Hip06 ethernet hardware to the HNS ethernet driver. Enabling this feature would help offload the TCP Segmentation process to the Hip06 ethernet hardware. This eventually

[PATCH net-next 4/4] net:hns: Add the init code to disable Hip06 "Hardware VLAN assist"

2015-10-20 Thread Salil
From: Salil Mehta This patch adds the initializzation code to disable the hardware vlan support for VLAN Tag stripping by default for now. Proper support of "hardware VLAN assitance" feature would soon come in the next coming patches. Signed-off-by: Salil Mehta

[PATCH net-next 1/2] ARM: gemini: remove unnecessary mdio-gpio includes

2015-10-20 Thread Vivien Didelot
Remove the inclusion of linux/mdio-gpio.h in nas4220b, wbd111 and wbd222 boards since mdio-gpio is not used. Signed-off-by: Vivien Didelot --- arch/arm/mach-gemini/board-nas4220b.c | 1 - arch/arm/mach-gemini/board-wbd111.c | 1 -

[PATCH net-next 2/2] net: mdio-gpio: move platform data header

2015-10-20 Thread Vivien Didelot
This header file only contains the platform data structure definition, so move it to the include/linux/platform_data/ directory. Signed-off-by: Vivien Didelot --- drivers/net/phy/mdio-gpio.c | 2 +- include/linux/{ =>

Re: [PATCH v2] net, can, ti_hecc: fix a run time warn_on.

2015-10-20 Thread Marc Kleine-Budde
On 10/20/2015 04:39 PM, Anton Glukhov wrote: > This patch fixes a warning in clk_enable by calling > clk_prepare_enable instead. > > Signed-off-by: Heiko Schocher > Signed-off-by: Anton Glukhov > --- > drivers/net/can/ti_hecc.c | 13 +++-- > 1

[PATCH net-next 1/4] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem

2015-10-20 Thread Salil
From: Salil Mehta This patchset adds support of Hisilicon Hip06 SoC to the existing HNS ethernet driver. The changes in the driver are mainly due to changes in the DMA descriptor provided by the Hip06 ethernet hardware. These changes need to co-exist with already present

Re: Fw: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-20 Thread Alan Burlison
On 20/10/2015 16:30, Eric Dumazet wrote: A close() does _not_ wakeup an accept() or a poll() (this is exactly the same problem), or any blocking system call using the same 'file' Not waking up the accept() is one thing, allowing the accept() to successfully complete some indeterminate time

Re: [PATCH v4 1/4] Produce system time from correlated clocksource

2015-10-20 Thread Thomas Gleixner
On Tue, 20 Oct 2015, Richard Cochran wrote: > On Tue, Oct 20, 2015 at 01:51:13PM +0200, Richard Cochran wrote: > > You can, in fact, achieve "proper" correlation by sampling. As John > > said, the question is whether the method in the patch set "measurably > > improves the error" over using

Re: Fw: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-20 Thread Eric Dumazet
On Tue, 2015-10-20 at 19:31 +0100, Alan Burlison wrote: > No, the race issue with file descriptor reuse and the close() behaviour > are not the same thing. The manpage comment is correct, but not relevant. Ok, it seems you know better than me, I will be stop the discussion and wait for your

[PATCH v4 1/2] geneve: implement support for IPv6-based tunnels

2015-10-20 Thread John W. Linville
Signed-off-by: John W. Linville --- v4: - treat mode field of ip_tunnel_info as flags - add a missing IS_ENABLED(CONFIG_IPV6) to geneve_rx - remove unneeded flags field in geneve_dev - NULL-check parameter for __geneve_sock_release - check remote socket family for

[PATCH net-next 3/3] switchdev: split switchdev_attr into individual structs

2015-10-20 Thread sfeldma
From: Scott Feldman This was already done for switchdev_objs. Changing switchdev_attrs to new style makes switchdev API consistent for both attrs and objs. No functional changes here. Signed-off-by: Scott Feldman ---

[PATCH net-next 2/3] switchdev: fix: pass correct obj size when deferring obj add

2015-10-20 Thread sfeldma
From: Scott Feldman Fixes: 0bc05d585d ("switchdev: allow caller to explicitly request attr_set as deferred") Signed-off-by: Scott Feldman --- net/switchdev/switchdev.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git

[PATCH net-next 1/3] switchdev: fix: erasing too much of vlan obj when handling multiple vlan specs

2015-10-20 Thread sfeldma
From: Scott Feldman When adding vlans with multiple IFLA_BRIDGE_VLAN_INFO attrs set in AFSPEC, we would wipe the vlan obj struct after the first IFLA_BRIDGE_VLAN_INFO. Fix this by only clearing what's necessary on each IFLA_BRIDGE_VLAN_INFO iteration. Fixes: 9e8f4a54

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-20 Thread Alexei Starovoitov
On 10/20/15 3:07 AM, Hannes Frederic Sowa wrote: Just a pretty obvious idea is accurate sampling of flows. ok, so you want to time out flows. Makes sense, but it should be done by user space with little or none help from the kernel. fdinfo tells me where my position in a file is and which

Re: [PATCH v4 1/4] Produce system time from correlated clocksource

2015-10-20 Thread Richard Cochran
On Tue, Oct 20, 2015 at 09:11:21PM +0200, Thomas Gleixner wrote: > Darn, we don't want to have that kind of sampling in every driver > which has this kind of problem even if it looks like the simpler > choice for this particular use case. This is going to be something > which next generation chips

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

2015-10-20 Thread David Ahern
On 10/20/15 6:31 AM, Hajime Tazaki wrote: yes, this sendmsg uses non-zero flowi6_oif. the conditions are - sendmsg () with INET6/RAW socket (with IPPROTO_MH) - ip6_pktinfo.ipi6_addr (fl6.saddr) and ipi6_oif (fl6.flowi6_oif) are non-NULL. => ipi6_addr (fl6.saddr) is not the IP address of

Re: [PATCH nf-next 0/4] netfilter: rework netfilter ipv6 defrag

2015-10-20 Thread Joe Stringer
On 20 October 2015 at 01:17, Florian Westphal wrote: > Joe Stringer wrote: >> On 17 October 2015 at 13:14, Florian Westphal wrote: >> > [ CC netdev since patch #2 isn't nf-specific. Dave, if you want >> > I can resubmit that one after

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-20 Thread Eric W. Biederman
Alexei Starovoitov writes: > On 10/20/15 1:46 AM, Daniel Borkmann wrote: >>> as we discussed in this thread and earlier during plumbers I think >>> it would be good to expose key/values somehow in this fs. >>> 'how' is a big question. >> >> Yes, it is a big question, and

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-20 Thread Alexei Starovoitov
On 10/20/15 1:46 AM, Daniel Borkmann wrote: as we discussed in this thread and earlier during plumbers I think it would be good to expose key/values somehow in this fs. 'how' is a big question. Yes, it is a big question, and probably best left to the domain-specific application itself, which

Re: [PATCH nf-next 3/4] netfilter: ipv6: in-place replacement of last skb

2015-10-20 Thread Joe Stringer
On 17 October 2015 at 13:14, Florian Westphal wrote: > @@ -425,6 +425,35 @@ nf_ct_frag6_reasm(struct frag_queue *fq, struct > net_device *dev) > add_frag_mem_limit(fq->q.net, clone->truesize); > } > > + /* morph head into last received skb: prev. > +

Re: [PATCH v2] net, can, ti_hecc: fix a run time warn_on.

2015-10-20 Thread Marc Kleine-Budde
On 10/20/2015 06:30 PM, Anton.Glukhov wrote: >>> + clk_disable_unprepare(priv->clk); >>> + priv->clk = NULL; >>> res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >>> iounmap(priv->base); >>> release_mem_region(res->start, resource_size(res)); >>> @@ -1009,7 +1010,7 @@ static

Re: [PATCH-v2 1/2] mac80211: Take bitrates into account when building IEs.

2015-10-20 Thread Ben Greear
On 10/20/2015 10:22 AM, gree...@candelatech.com wrote: From: Ben Greear If a user restricts the rateset for some reason, then the probe requests should not advertise rates that are not selected by the user. I meant to send these to linux-wireless. Plz ignore.

[PATCH 2/2] geneve: handle ipv6 priority like ipv4 tos

2015-10-20 Thread John W. Linville
Other callers of udp_tunnel6_xmit_skb just pass 0 for the prio argument. Jesse Gross suggested that prio is really the same as IPv4's tos and should be handled the same, so this is my interpretation of that suggestion. Signed-off-by: John W. Linville

RE: [PATCH] intel: i40e: fix confused code

2015-10-20 Thread Nelson, Shannon
> From: Rasmus Villemoes [mailto:li...@rasmusvillemoes.dk] > Sent: Tuesday, October 20, 2015 12:22 AM > > On Mon, Oct 19 2015, "Nelson, Shannon" wrote: > > >> From: Rasmus Villemoes [mailto:li...@rasmusvillemoes.dk] > >> Sent: Saturday, October 17, 2015 1:58 PM > >>

Re: [PATCH] net, can, ti_hecc: add DT support for the ti,hecc controller

2015-10-20 Thread Marc Kleine-Budde
On 10/20/2015 05:09 PM, Anton.Glukhov wrote: >>> It's OMAP3 based arch, but HECC is implemented only in AM3505 and AM3517 >>> SoCs. >>> So, I'm confused about what's "name" should I use. >> >> Which SoC was available first? Pick that. > What do you mean available? I know only that HECC appear in

Re: [PATCH] net, can, ti_hecc: add DT support for the ti,hecc controller

2015-10-20 Thread Anton.Glukhov
On 20.10.2015 18:20, Marc Kleine-Budde wrote: > On 10/20/2015 05:18 PM, Marc Kleine-Budde wrote: >> On 10/20/2015 05:09 PM, Anton.Glukhov wrote: > It's OMAP3 based arch, but HECC is implemented only in AM3505 and AM3517 > SoCs. > So, I'm confused about what's "name" should I use.

Re: [net-next 11/17] i40e: Add promiscuous on VLAN support

2015-10-20 Thread Or Gerlitz
On Tue, Oct 20, 2015 at 6:31 PM, Rose, Gregory V wrote: >> > NFV use cases require the ability to steer packets to VSIs by VLAN tag >> > alone while being in promiscuous mode for multicast and unicast MAC >> > addresses. These two new functions support that ability. >>

RE: [PATCH] intel: i40e: fix confused code

2015-10-20 Thread Nelson, Shannon
> -Original Message- > From: Rasmus Villemoes [mailto:li...@rasmusvillemoes.dk] > Sent: Saturday, October 17, 2015 1:58 PM > Subject: [PATCH] intel: i40e: fix confused code > > This code is pretty confused. The variable name 'bytes_not_copied' > clearly indicates that the programmer knew

Re: [PATCH v2] net, can, ti_hecc: fix a run time warn_on.

2015-10-20 Thread Anton.Glukhov
Thank you for review Marc! On 20.10.2015 17:46, Marc Kleine-Budde wrote: > On 10/20/2015 04:39 PM, Anton Glukhov wrote: >> This patch fixes a warning in clk_enable by calling >> clk_prepare_enable instead. >> >> Signed-off-by: Heiko Schocher >> Signed-off-by: Anton Glukhov

[PATCH net-next v3 3/6] net: dsa: mv88e6xxx: write MAC outside of ATU Get Next code

2015-10-20 Thread Vivien Didelot
There is no need to write the MAC address before every Get Next operation, since ATU MAC registers are not cleared between calls. Move the _mv88e6xxx_atu_mac_write call outside of _mv88e6xxx_atu_getnext so future code could call ATU Get Next multiple times and save a few register access. ---

[PATCH net-next v3 0/6] net: dsa: implement port_fdb_dump in drivers

2015-10-20 Thread Vivien Didelot
Not all switch chips provide a Get Next kind of operation to dump FDB entries. It is preferred to let the driver handle the dump operation the way it works best for the chip. Thus, drop port_fdb_getnext and implement the port_fdb_dump operation in DSA, which pushes the switchdev FDB dump callback

[PATCH net-next v3 1/6] net: dsa: add port_fdb_dump function

2015-10-20 Thread Vivien Didelot
Not all switch chips support a Get Next operation to iterate on its FDB. So add a more simple port_fdb_dump function for them. Signed-off-by: Vivien Didelot --- include/net/dsa.h | 4 net/dsa/slave.c | 3 +++ 2 files changed, 7 insertions(+) diff

[PATCH-v2 2/2] mac80211: ensure association req uses configured ratemask.

2015-10-20 Thread greearb
From: Ben Greear When sending the association request, pay attention to the legacy rates configured by the user, and do not advertise support for any that are not configured. This makes the assoc request packet look more correct when making modern hardware act like a /b

[PATCH-v2 1/2] mac80211: Take bitrates into account when building IEs.

2015-10-20 Thread greearb
From: Ben Greear If a user restricts the rateset for some reason, then the probe requests should not advertise rates that are not selected by the user. To implement this, we save the requested bitrates at the mac80211 level and take it into account when building the

[PATCH net-next v3 2/6] net: dsa: mv88e6xxx: write VID outside of VTU Get Next code

2015-10-20 Thread Vivien Didelot
There is no need to write the VLAN ID before every Get Next operation, since the VTU VID register is not cleared between calls. Move the VID write call in a _mv88e6xxx_vtu_vid_write function outside of _mv88e6xxx_vtu_getnext so future code could call VTU Get Next multiple times and save a few

[PATCH net-next v3 6/6] net: dsa: remove port_fdb_getnext

2015-10-20 Thread Vivien Didelot
No driver implements port_fdb_getnext anymore, and port_fdb_dump is preferred anyway, so remove this function from DSA. Signed-off-by: Vivien Didelot --- include/net/dsa.h | 3 --- net/dsa/slave.c | 25 + 2 files changed, 1

Re: [PATCH] net, can, ti_hecc: add DT support for the ti,hecc controller

2015-10-20 Thread Marc Kleine-Budde
On 10/20/2015 05:18 PM, Marc Kleine-Budde wrote: > On 10/20/2015 05:09 PM, Anton.Glukhov wrote: It's OMAP3 based arch, but HECC is implemented only in AM3505 and AM3517 SoCs. So, I'm confused about what's "name" should I use. >>> >>> Which SoC was available first? Pick that. > >>

[RFC PATCH] net:hns: hns_aev2_toggle_ring_irq() can be static

2015-10-20 Thread kbuild test robot
Signed-off-by: Fengguang Wu --- hns_ae_adapt.c |2 +- hns_enet.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c b/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c index

Re: [PATCH net-next 1/4] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem

2015-10-20 Thread kbuild test robot
Hi Salil, [auto build test WARNING on net-next/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Salil/net-hns-Add-support-of-Hip06-SoC-to-the-Hislicon-Network-Subsystem/20151020-225151 reproduce

[PATCH net-next v3 4/6] net: dsa: mv88e6xxx: implement port_fdb_dump

2015-10-20 Thread Vivien Didelot
Implement the port_fdb_dump DSA operation. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6171.c | 1 + drivers/net/dsa/mv88e6352.c | 1 + drivers/net/dsa/mv88e6xxx.c | 65 + drivers/net/dsa/mv88e6xxx.h |

[PATCH net-next v3 5/6] net: dsa: mv88e6xxx: remove port_fdb_getnext

2015-10-20 Thread Vivien Didelot
Now that port_fdb_dump is implemented and even simpler, get rid of port_fdb_getnext. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6171.c | 1 - drivers/net/dsa/mv88e6352.c | 1 - drivers/net/dsa/mv88e6xxx.c | 73

RE: [PATCH net-next v3] bnxt_en: New Broadcom ethernet driver.

2015-10-20 Thread David Laight
From: Stephen Hemminger ... > On Sat, 17 Oct 2015 00:21:44 -0400 > Michael Chan wrote: > > > +static bool bnxt_vf_pciid(int idx) > > +{ > > + if (idx == BCM57304_VF || idx == BCM57404_VF) > > + return true; > > + return false; > > +} > > + > > I prefer just

Re: [PATCH] net, can, ti_hecc: add DT support for the ti,hecc controller

2015-10-20 Thread Anton.Glukhov
Hello Marc, Heiko! I'm sorry for the delay! On 19.10.2015 10:31, Marc Kleine-Budde wrote: > On 10/19/2015 09:27 AM, Heiko Schocher wrote: .../devicetree/bindings/net/can/ti_hecc-can.txt| 20 ++ arch/arm/boot/dts/am3517.dtsi | 13 +++

Re: Fw: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-20 Thread Eric Dumazet
On Tue, 2015-10-20 at 14:45 +0100, Alan Burlison wrote: > And I still haven't seen any reasoning behind the Linux close() and > poll() behaviour on sockets that are in the listen state. Same answer. A close() does _not_ wakeup an accept() or a poll() (this is exactly the same problem), or any

RE: [net-next 11/17] i40e: Add promiscuous on VLAN support

2015-10-20 Thread Rose, Gregory V
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, October 13, 2015 4:14 AM > To: Kirsher, Jeffrey T > Cc: Rose, Gregory V; netdev@vger.kernel.org; nhor...@redhat.com; > sassm...@redhat.com; jogre...@redhat.com > Subject: Re: [net-next 11/17] i40e: Add

Re: sh_eth.c::sh_eth_rx(): mdp->rx_skbuff[entry] can be NULL

2015-10-20 Thread Sergei Shtylyov
Hello. On 10/19/2015 06:01 PM, Yasushi SHOJI wrote: In a low memory situation with netdev_alloc_skb() failure, mdp->rx_skbuff[entry] can be left NULL, however, sh_eth_rx() seems to access it without checking NULL or not in the following code: skb =

Re: [PATCH nf-next 3/4] netfilter: ipv6: in-place replacement of last skb

2015-10-20 Thread Florian Westphal
Joe Stringer wrote: > This hunk looks very similar to the logic in ip_frag_reasm(). Did you > consider refactoring to share it? Could be done but I did not plan to do that. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH nf-next 0/4] netfilter: rework netfilter ipv6 defrag

2015-10-20 Thread Florian Westphal
Joe Stringer wrote: > > Good point. No, I don't. Any suggestions? > > I can try to just re-target -nf tree (sans patch #2). Pablo? > > The smallest change seems to be adding the nf_ct_frag6_consume_orig() > call to OVS, plus the morph logic from patch 3. Alternatively

Re: [PATCH] allow dctcp alpha to drop to zero

2015-10-20 Thread Andrew Shewmaker
On Mon, Oct 19, 2015 at 8:01 AM, Florian Westphal wrote: > Andrew Shewmaker wrote: >> If alpha is strictly reduced by alpha >> dctcp_shift_g and if alpha is less >> than 1 << dctcp_shift_g, then alpha may never reach zero. For example, >> given shift_g=4 and

Re: [PATCH net] ipv6: don't use CHECKSUM_PARTIAL on MSG_MORE/UDP_CORK sockets

2015-10-20 Thread Vlad Yasevich
On 10/20/2015 10:38 AM, Hannes Frederic Sowa wrote: > MSG_MORE might cause the packet to get fragmented in the end when > passed down to the flush function and the transhdrlen check alone is > not sufficient to protect against fragmentation. Instead check if the > socket user intends to add more

Re: [PATCH v4 1/4] Produce system time from correlated clocksource

2015-10-20 Thread John Stultz
On Tue, Oct 20, 2015 at 12:11 PM, Thomas Gleixner wrote: > On Tue, 20 Oct 2015, Richard Cochran wrote: >> On Tue, Oct 20, 2015 at 01:51:13PM +0200, Richard Cochran wrote: >> > You can, in fact, achieve "proper" correlation by sampling. As John >> > said, the question is

RE: [net-next 11/17] i40e: Add promiscuous on VLAN support

2015-10-20 Thread Rose, Gregory V
> -Original Message- > From: Or Gerlitz [mailto:gerlitz...@gmail.com] > Sent: Tuesday, October 20, 2015 8:47 AM > To: Rose, Gregory V > Cc: David Miller; Kirsher, Jeffrey T; Singhai, Anjali; > netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; > jogre...@redhat.com > Subject:

[PATCH net-next] tcp: fastopen: limit max_qlen

2015-10-20 Thread Eric Dumazet
From: Eric Dumazet Allowing an application to set whatever limit for the list of recently RST fastopen sessions [1] is not wise, as it open ways to deplete kernel memory. Cap the user provided limit by somaxconn sysctl, like listen() backlog. [1]

Re: [PATCH net-next V17 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-10-20 Thread Pravin Shelar
On Tue, Oct 20, 2015 at 7:26 AM, Thomas F Herbert wrote: > On 10/19/15 2:28 PM, Pravin Shelar wrote: >> >> On Sat, Oct 17, 2015 at 6:12 PM, Thomas F Herbert >> wrote: >>> >>> Add support for 802.1ad including the ability to push and pop double

Re: [Bug] Linux 4.1.9, NULL pointer dereference in pppoe_release+0x120/0x150

2015-10-20 Thread Matt Bennett
On Tue, 2015-10-20 at 14:00 +0300, Andrew wrote: > Hi. > > After BRAS software upgrading (PPPoE daemon + kernel from 3.2.x to > 4.1.x) I have different kernel bugs/crashes - some of them don't hurt > system, other crashes - cause network subsystem lockup (commands like > 'ip a' just hungs; and

[PATCH] net: phy: dp83848: Add TI DP83848 Ethernet PHY

2015-10-20 Thread Andrew F. Davis
Add support for the TI DP83848 Ethernet PHY device. The DP83848 is a highly reliable, feature rich, IEEE 802.3 compliant single port 10/100 Mb/s Ethernet Physical Layer Transceiver supporting the MII and RMII interfaces. Signed-off-by: Andrew F. Davis Signed-off-by: Dan Murphy

Re: [PATCH] net: phy: dp83848: Add TI DP83848 Ethernet PHY

2015-10-20 Thread Florian Fainelli
On 20/10/15 14:28, Andrew F. Davis wrote: > Add support for the TI DP83848 Ethernet PHY device. > > The DP83848 is a highly reliable, feature rich, IEEE 802.3 compliant > single port 10/100 Mb/s Ethernet Physical Layer Transceiver supporting > the MII and RMII interfaces. > > Signed-off-by:

  1   2   >