RE: [PATCH net-next v7 01/10] qed: Add module with basic common support

> > +/* counts the iids for the CDU/CDUC ILT client configuration */ > > +struct qed_cdu_iids { > > + u32 pf_cids; > > +}; Actually, this will [in future] also include a `per_vf_cids' field; I've extracted it and all its usages when preparing this patch series [As our initial submission

Re: [PATCH] net/mlx4: Memcpy at slave_event should copy sizeof mlx4_eqe

On Fri, Oct 23, 2015 at 4:19 PM, wrote: > From: Carol L Soto > > If the caps.eqe_size is bigger than the struct mlx4_eqe then there > is a potential for corrupting data at the master context. We can see > the message "Master failed to

Re: [RFC Patch 03/12] IXGBE: Add sysfs interface for Qemu to migrate VF status in the PF driver

On 10/22/2015 4:45 AM, Alexander Duyck wrote: +/* Record states hold by PF */ +memcpy(>vf_data, >vfinfo[vfn], sizeof(struct vf_data_storage)); + +vf_shift = vfn % 32; +reg_offset = vfn / 32; + +reg = IXGBE_READ_REG(hw, IXGBE_VFTE(reg_offset)); +reg &= ~(1 << vf_shift);

Re: [RFC Patch 05/12] IXGBE: Add new sysfs interface of "notify_vf"

On 10/25/2015 2:03 PM, Alexander Duyck wrote: On 10/24/2015 08:43 AM, Lan, Tianyu wrote: On 10/22/2015 4:52 AM, Alexander Duyck wrote: Also have you even considered the MSI-X configuration on the VF? I haven't seen anything anywhere that would have migrated the VF's MSI-X configuration

Re: [RFC Patch 05/12] IXGBE: Add new sysfs interface of "notify_vf"

On 10/24/2015 08:43 AM, Lan, Tianyu wrote: On 10/22/2015 4:52 AM, Alexander Duyck wrote: Also have you even considered the MSI-X configuration on the VF? I haven't seen anything anywhere that would have migrated the VF's MSI-X configuration from BAR 3 on one system to the new system. MSI-X

Re: IPv6 and private net with masquerading not working correctly

Any update on this issue? Thank you. Ciao, Gerhard On 10.08.2015 19:39, Cong Wang wrote: (Cc'ing netdev and netfilter-devel) On Fri, Aug 7, 2015 at 6:00 AM, Gerhard Wiesinger wrote: On 06.08.2015 20:43, Gerhard Wiesinger wrote: Hello, I'm having the following problem

Re: [PATCH net-next] bpf: make tracing helpers gpl only

* Alexei Starovoitov wrote: > exported perf symbols are GPL only, mark eBPF helper functions > used in tracing as GPL only as well. > > Suggested-by: Peter Zijlstra > Signed-off-by: Alexei Starovoitov > --- > this is on top of this

Re: [PATCH] net/mlx4: Memcpy at slave_event should copy sizeof mlx4_eqe

Hi Carol, Good catch! Need to add an additional chunk to your fix -- see below. On Sun, 25 Oct 2015 10:26:07 +0200 Or Gerlitz wrote: > > > --- > > drivers/net/ethernet/mellanox/mlx4/eq.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git

Re: [RFC PATCH net-next] tipc: tipc_link_is_active() can be static

From: kbuild test robot Date: Sat, 24 Oct 2015 23:11:00 +0800 > TO: "David S. Miller" > CC: netdev@vger.kernel.org > CC: Jon Maloy > CC: Ying Xue > CC: tipc-discuss...@lists.sourceforge.net > CC:

Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper

* Alexei Starovoitov wrote: > On 10/23/15 5:03 AM, Peter Zijlstra wrote: > >So the bpf_perf_event_read() returns the count value, does this not also > >mean that returning -EINVAL here is also 'wrong'? > > > >I mean, sure an actual count value that high is unlikely, but its

Re: [PATCH net-next v7 01/10] qed: Add module with basic common support

From: Yuval Mintz Date: Sun, 25 Oct 2015 06:18:51 + > I'd rather leave this as-is instead of making changes I'd have to revert > later on, but if your 'code buds' reject this, I'll make the change. Add facilities and flexibility when you need it rather than

Re: [RFC PATCH net-next] tipc: link_is_bc_sndlink() can be static

From: kbuild test robot Date: Sat, 24 Oct 2015 22:56:01 +0800 > TO: "David S. Miller" > CC: netdev@vger.kernel.org > CC: Jon Maloy > CC: Ying Xue > CC: tipc-discuss...@lists.sourceforge.net > CC:

Re: [PATCH net] ipv6: no CHECKSUM_PARTIAL on skbs with extension headers and recalc checksum during fragmentation

> Anyway, currently it is easy to generate broken checksums on the wire > and would like to solve that for net, we certainly can improve that in > net-next. > Hannes, The IPv4 fragment code is very similar to IPv6 in that both will perform skb_checksum_help only in the slow_path, so it seems like

Re: Linux 4.2.4

On 25.10.2015 10:46, Willy Tarreau wrote: ipset *triggered* the problem. The whole stack dump would tell more. OK, find the stack traces in the bug report: https://bugzilla.redhat.com/show_bug.cgi?id=1272645 Kernel 4.1.10 triggered also a kernel dump when playing with ipset commands and

Re: [PATCH net-next] af_unix: do not report POLLOUT on listeners

From: Eric Dumazet Date: Fri, 23 Oct 2015 10:59:16 -0700 > From: Eric Dumazet > > poll(POLLOUT) on a listener should not report fd is ready for > a write(). > > This would break some applications using poll() and pfd.events = -1, > as they would

Re: [PATCH 1/2] can: xilinx: use readl/writel instead of ioread/iowrite

On Sunday 25 October 2015, Marc Kleine-Budde wrote: > On 10/22/2015 10:58 AM, Arnd Bergmann wrote: > >>> The two should really do the same thing: iowrite32() is just a static > >>> inline > >>> calling writel() on both ARM32 and ARM64. On which kernel version did you > >>> observe the difference?

Re: [PATCH v3 0/2] mvneta ethtool statistics

From: Russell King - ARM Linux Date: Thu, 22 Oct 2015 18:37:11 +0100 > Sorry for v3 - I forgot to update the commit message on patch 1 as > requested by Marcin. > > This short series adds ethtool statistics reporting to mvneta. Having > discussed with Andrew on IRC, we

Re: [PATCH v2] net: tso: add support for IPv6

On 2015/10/26 5:02, Emmanuel Grumbach wrote: > Adding IPv6 for the TSO helper API is trivial: > * Don't play with the id (which doesn't exist in IPv6) > * Correctly update the payload_len (don't include the > length of the IP header itself) ... > memcpy(hdr, skb->data, hdr_len); > -

Re: [PATCH] net: tso: add support for IPv6

Hello. On 10/25/2015 10:58 PM, Emmanuel Grumbach wrote: Adding IPv6 for the TSO helper API is trivial: * Don't play with the id (which doesn't exist in IPv6) * Correctly update the payload_len (don't include the length of the IP header itself) Signed-off-by: Emmanuel Grumbach

[PATCH v2 net-next 2/4] e1000e: Add ndo_enc_hdr_len

e1000e has 4 bytes additional room for vlan header, so set default enc_hdr_len to 4. Note that e1000e uses mtu to validate frame size in some places, which are needed to be modified to use max_frame_size as extra header room became variable. Signed-off-by: Toshiaki Makita

[PATCH v2 net-next 0/4] Automatic adjustment of max frame size

This patch set tries to resolve packet drop by oversize error on receiving double tagged packets and possibly other encapsulated packets. Problem description: Currently most NICs have 4 bytes room of receive buffer for vlan header and can receive 1522 bytes frame at maximum. This is, however, not

[PATCH v2 net-next 4/4] bridge: Notify port device of encap header length

If vlan is assigned to a port, notify the port of 4 bytes header length, or 8 bytes if 802.1ad. Signed-off-by: Toshiaki Makita --- net/bridge/br_vlan.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/net/bridge/br_vlan.c

[PATCH v2 net-next 1/4] net: Add ndo_enc_hdr_len to notify extra header room for encapsulated frames

Currently most NICs reserve 1522 bytes space for frames to handle 4 bytes VLAN header in addition to 1518, maximum size of ethernet frame. This is, however, not sufficient when stacked vlan or other encapsulation protocols are used. To accommodate this, add .ndo_enc_hdr_len() and inform drivers of

[PATCH v2 net-next 3/4] vlan: Notify real device of encap header length

Reserve extra 4 bytes on real_dev in addition to the length notified from upper device. In 802.1ad mode, set enc_hdr_len to 4 bytes by default, since it is likely to send already tagged frame. Signed-off-by: Toshiaki Makita --- net/8021q/vlan.c | 16

[PATCH net-next V18 0/3] openvswitch: Add support for 802.1ad

V18: Patches 1 and 2 in this series have been acked from V17. Patch 3 in the series includes some significant changes. The patch includes fixes the decoding of the flow for the outer tpid. Also, netlink parsing code has been consolidated to generalize inner and outer vlans and non-mask and masked

[PATCH net-next V18 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

Add support for 802.1ad including the ability to push and pop double tagged vlans. Add support for 802.1ad to netlink parsing and flow conversion. Uses double nested encap attributes to represent double tagged vlan. Inner TPID encoded along with ctci in nested attributes. Outer TPID is also

[PATCH net-next V17 1/3] openvswitch: 802.1ad uapi changes.

openvswitch: Add support for 8021.AD Change the description of the VLAN tpid field. Signed-off-by: Thomas F Herbert --- include/uapi/linux/openvswitch.h | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git

[PATCH net-next V17 2/3] Check for vlan ethernet types for 8021.q or 802.1ad

Signed-off-by: Thomas F Herbert --- include/linux/if_vlan.h | 16 1 file changed, 16 insertions(+) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 67ce5bd..d2494b5 100644 --- a/include/linux/if_vlan.h +++ b/include/linux/if_vlan.h

Re: [PATCH 0/4] net: thunderx: Support pass-2 revision hardware.

From: David Daney Date: Fri, 23 Oct 2015 17:14:06 -0700 > With the availability of a new revision of the ThunderX NIC hardware a > few changes to the driver are required. With these, the driver works > on all currently available hardware revisions. Series applied,

Re: [PATCH net-next 2/3] bpf: introduce bpf_perf_event_output() helper

On 2015/10/24 1:25, Alexei Starovoitov wrote: On 10/23/15 9:42 AM, Peter Zijlstra wrote: On Fri, Oct 23, 2015 at 08:02:00AM -0700, Alexei Starovoitov wrote: On 10/23/15 7:39 AM, Peter Zijlstra wrote: On Tue, Oct 20, 2015 at 08:02:34PM -0700, Alexei Starovoitov wrote: +static const struct

Re: [PATCH v6 1/2] geneve: implement support for IPv6-based tunnels

On Fri, Oct 23, 2015 at 10:40 PM, John W. Linville wrote: > NOTE: Link-local IPv6 addresses for remote endpoints are not supported, > since the driver currently has no capacity for binding a geneve > interface to a specific link. > > Signed-off-by: John W. Linville

Re: Linux 4.2.4

On 25.10.2015 21:08, Gerhard Wiesinger wrote: On 25.10.2015 20:46, Jozsef Kadlecsik wrote: Hi, On Sun, 25 Oct 2015, Gerhard Wiesinger wrote: On 25.10.2015 10:46, Willy Tarreau wrote: ipset *triggered* the problem. The whole stack dump would tell more. OK, find the stack traces in the bug

Re: [PATCH net 0/4] gianfar: Misc. fixes and updates

From: Claudiu Manoil Date: Fri, 23 Oct 2015 11:41:57 +0300 > Various fixes for some older issues, including having a > MAINTAINERS entry for this driver. > I'd recommend applying them on top of net, thanks. Series applied, thanks. -- To unsubscribe from this list:

Re: [RFC PATCH net-next] tipc: tipc_link_is_active() can be static

On Sun, Oct 25, 2015 at 06:33:18AM -0700, David Miller wrote: > From: kbuild test robot > Date: Sat, 24 Oct 2015 23:11:00 +0800 > > > TO: "David S. Miller" > > CC: netdev@vger.kernel.org > > CC: Jon Maloy > > CC: Ying Xue

Re: [Intel-wired-lan] [PATCH net-next 0/4] Automatic adjustment of max frame size

On 2015/10/23 13:46, ND Linux CI Server wrote: ... > checkpatch.pl has some complaints: > > > > checkpatch.pl results for patch "[PATCH 2/4] e1000e: Add ndo_enc_hdr_len" > > WARNING:LONG_LINE: line over 80

[PATCHv3 net 2/3] ipv6: Export nf_ct_frag6_consume_orig()

This is needed in openvswitch to fix an skb leak in the next patch. Signed-off-by: Joe Stringer --- v2-v3: No change. --- net/ipv6/netfilter/nf_conntrack_reasm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/netfilter/nf_conntrack_reasm.c

[PATCHv3 net 1/3] openvswitch: Fix double-free on ip_defrag() errors

If ip_defrag() returns an error other than -EINPROGRESS, then the skb is freed. When handle_fragments() passes this back up to do_execute_actions(), it will be freed again. Prevent this double free by never freeing the skb in do_execute_actions() for errors returned by ovs_ct_execute. Always free

[PATCHv3 net 3/3] openvswitch: Fix skb leak using IPv6 defrag

nf_ct_frag6_gather() makes a clone of each skb passed to it, and if the reassembly is successful, expects the caller to free all of the original skbs using nf_ct_frag6_consume_orig(). This call was previously missing, meaning that the original fragments were never freed (with the exception of the

Re: Linux 4.2.4

On Sun, 25 Oct 2015, Gerhard Wiesinger wrote: > On 25.10.2015 21:08, Gerhard Wiesinger wrote: > > On 25.10.2015 20:46, Jozsef Kadlecsik wrote: > > > Hi, > > > > > > On Sun, 25 Oct 2015, Gerhard Wiesinger wrote: > > > > > > > On 25.10.2015 10:46, Willy Tarreau wrote: > > > > > ipset *triggered*

[PATCH net-next] bnxt_en: Fix compile warnings when CONFIG_INET is not set.

bnxt_gro_skb() has unused variables when CONFIG_INET is not set. We really cannot support hardware GRO if CONFIG_INET is not set, so compile out bnxt_gro_skb() completely and define BNXT_FLAG_GRO to be 0 if CONFIG_INET is not set. This will effectively always disable hardware GRO if CONFIG_INET

Re: [PATCH net] macvtap: unbreak receiving of gro skb with frag list

On 10/23/2015 09:37 PM, Michael S. Tsirkin wrote: > On Fri, Oct 23, 2015 at 12:57:05AM -0400, Jason Wang wrote: >> We don't have fraglist support in TAP_FEATURES. This will lead >> software segmentation of gro skb with frag list. Fixes by having >> frag list support in TAP_FEATURES. >> >> With

Re: [PATCH net-next 0/4] Automatic adjustment of max frame size

On 2015/10/24 17:50, Toshiaki Makita wrote: > David, > > I found my patch set is marked with Changes Requested, but I haven't > seen any feedback. > > Could you give me your feedback? Somehow the mail from LD Linux CI Server did not reach netdev mailing list so I could not have seen it from

Re: [PATCH net-next] bnxt_en: Fix compile warnings when CONFIG_INET is not set.

From: Michael Chan Date: Sun, 25 Oct 2015 22:27:57 -0400 > bnxt_gro_skb() has unused variables when CONFIG_INET is not set. We > really cannot support hardware GRO if CONFIG_INET is not set, so > compile out bnxt_gro_skb() completely and define BNXT_FLAG_GRO to be 0 > if

Re: [PATCH net-next] net: encx24j600: Fix mask to update LED configuration

From: j...@ringle.org Date: Thu, 22 Oct 2015 15:09:04 -0400 > From: Jon Ringle > > This fixes the mask used to update the LED configuration so that it clears > the necessary bits as well as setting the bits according to the mask. > Also reverse the LED configuration to

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

On 2015年10月24日 02:36, Alexander Duyck wrote: > I was thinking about it and I am pretty sure the dummy write approach is > problematic at best. Specifically the issue is that while you are > performing a dummy write you risk pulling in descriptors for data that > hasn't been dummy written to yet.

[PATCH 3/8] netdev/phy: add missing of_node_put

for_each_available_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. A simplified version of the semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // @@ local idexpression r.n; expression r,e; @@

[PATCH 1/8] net: thunderx: add missing of_node_put

for_each_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. A simplified version of the semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // @@ local idexpression r.n; expression r,e; @@

Re: Linux 4.2.4

On 25.10.2015 17:29, Greg KH wrote: On Sun, Oct 25, 2015 at 11:48:54AM +0100, Gerhard Wiesinger wrote: On 25.10.2015 10:46, Willy Tarreau wrote: ipset *triggered* the problem. The whole stack dump would tell more. OK, find the stack traces in the bug report:

Re: [PATCH v7] can: xilinx: Convert to runtime_pm

On 10/23/2015 07:23 AM, Kedareswara rao Appana wrote: > Instead of enabling/disabling clocks at several locations in the driver, > Use the runtime_pm framework. This consolidates the actions for runtime PM > In the appropriate callbacks and makes the driver more readable and > mantainable. > >

Re: [PATCH 1/2] can: xilinx: use readl/writel instead of ioread/iowrite

On 10/22/2015 10:58 AM, Arnd Bergmann wrote: >>> The two should really do the same thing: iowrite32() is just a static inline >>> calling writel() on both ARM32 and ARM64. On which kernel version did you >>> observe the difference? It's possible that an older version used >>> CONFIG_GENERIC_IOMAP,

[PATCH 2/8] net: netcp: add missing of_node_put

for_each_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. A simplified version of the semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // @@ local idexpression r.n; expression r,e; @@

[PATCH 0/8] add missing of_node_put

The various for_each device_node iterators performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. The complete semantic patch that fixes this problem is (http://coccinelle.lip6.fr): // @r@ local idexpression n; expression e1,e2; iterator name

Re: Linux 4.2.4

On Sun, Oct 25, 2015 at 11:48:54AM +0100, Gerhard Wiesinger wrote: > On 25.10.2015 10:46, Willy Tarreau wrote: > >ipset *triggered* the problem. The whole stack dump would tell more. > > OK, find the stack traces in the bug report: > https://bugzilla.redhat.com/show_bug.cgi?id=1272645 > > Kernel

[PATCH 7/8] ath6kl: add missing of_node_put

for_each_compatible_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. A simplified version of the semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // @@ expression e; local idexpression n; @@

[PATCH 4/8] net: phy: mdio: add missing of_node_put

for_each_available_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. A simplified version of the semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local idexpression child; @@

[PATCH 8/8] net: mv643xx_eth: add missing of_node_put

for_each_available_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. A simplified version of the semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local idexpression child; @@

Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper

On 10/25/15 2:21 AM, Ingo Molnar wrote: Then old crap can be de-emphasised and eventually removed, instead of having to live with crap forever ... strongly disagree. none of the helpers are 'crap'. bpf_perf_event_read() muxes of -EINVAL into return value, but it's non ambiguous to the program

Re: [PATCH net-next] bpf: make tracing helpers gpl only

On 10/25/15 2:14 AM, Ingo Molnar wrote: so I don't know the netfilter ones, but in particular the tracing ones I'm sure should be gpl-only. Do we really, really want proprietary modules mucking with such internals?? of course, not. Therefore bpf_probe_read() was gpl_only from very beginning.

[PATCH] net: tso: add support for IPv6

Adding IPv6 for the TSO helper API is trivial: * Don't play with the id (which doesn't exist in IPv6) * Correctly update the payload_len (don't include the length of the IP header itself) Signed-off-by: Emmanuel Grumbach --- net/core/tso.c | 17 -

[PATCH v2] net: tso: add support for IPv6

Adding IPv6 for the TSO helper API is trivial: * Don't play with the id (which doesn't exist in IPv6) * Correctly update the payload_len (don't include the length of the IP header itself) Signed-off-by: Emmanuel Grumbach --- v2: add else if NOTE: instead of

Re: Linux 4.2.4

On 25.10.2015 20:46, Jozsef Kadlecsik wrote: Hi, On Sun, 25 Oct 2015, Gerhard Wiesinger wrote: On 25.10.2015 10:46, Willy Tarreau wrote: ipset *triggered* the problem. The whole stack dump would tell more. OK, find the stack traces in the bug report:

Re: Linux 4.2.4

Hi, On Sun, 25 Oct 2015, Gerhard Wiesinger wrote: > On 25.10.2015 10:46, Willy Tarreau wrote: > > ipset *triggered* the problem. The whole stack dump would tell more. > > OK, find the stack traces in the bug report: > https://bugzilla.redhat.com/show_bug.cgi?id=1272645 > > Kernel 4.1.10

Re: [PATCH 08/11] net: bluetooth: change the len parameter of sco_send_frame() to size_t

Hi Corentin, > len is used in operation/function that wait for unsigned value. > Furthermore the only one call of sco_send_frame give a size_t as argument. > So the parameter need to be set as size_t. > > Signed-off-by: LABBE Corentin > --- > net/bluetooth/sco.c | 2