Re: [PATCH] bpf: add mod default A and X test cases

2015-11-04 Thread Alexei Starovoitov
On Wed, Nov 04, 2015 at 11:36:37AM -0800, Yang Shi wrote: > When running "mod X" operation, if X is 0 the filter has to be halt. > Add new test cases to cover A = A mod X if X is 0, and A = A mod 1. > > CC: Xi Wang > CC: Zi Shen Lim > Signed-off-by: Yang

Re: [PATCH v5] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-04 Thread Andy Shevchenko
On Wed, Nov 4, 2015 at 10:06 PM, Sowmini Varadhan wrote: > On (11/04/15 21:59), Andy Shevchenko wrote: >> > See earlier response. So, if maintainer is okay I'm also okay with those and you may take my tag. -- With Best Regards, Andy Shevchenko -- To unsubscribe

[PATCH 7/8] mm: memcontrol: account socket memory in unified hierarchy memory controller

2015-11-04 Thread Johannes Weiner
Socket memory can be a significant share of overall memory consumed by common workloads. In order to provide reasonable resource isolation in the unified hierarchy, this type of memory needs to be included in the tracking/accounting of a cgroup under active memory resource control. Overhead is

[PATCH 5/8] net: tcp_memcontrol: consolidate socket buffer tracking and accounting

2015-11-04 Thread Johannes Weiner
The tcp memory controller has extensive provisions for future memory accounting interfaces that won't materialize after all. Cut the code base down to what's actually used, now and in the likely future. - There won't be any different protocol counters in the future, so a direct sock->sk_memcg

[PATCH 8/8] mm: memcontrol: hook up vmpressure to socket pressure

2015-11-04 Thread Johannes Weiner
Let the networking stack know when a memcg is under reclaim pressure so that it can clamp its transmit windows accordingly. Whenever the reclaim efficiency of a cgroup's LRU lists drops low enough for a MEDIUM or HIGH vmpressure event to occur, assert a pressure state in the socket and tcp memory

[PATCH net] net: dsa: mv88e6xxx: isolate unbridged ports

2015-11-04 Thread Vivien Didelot
The DSA documentation specifies that each port must be capable of forwarding frames to the CPU port. The last changes on bridging support for the mv88e6xxx driver broke this requirement for non-bridged ports. So as for the bridged ports, reserve a few VLANs (4000+) in the switch to isolate ports

RE: [PATCH v5] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-04 Thread Nelson, Shannon
> From: Sowmini Varadhan [mailto:sowmini.varad...@oracle.com] > Sent: Wednesday, November 04, 2015 11:40 AM > > > This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC > address in Open Firmware or IDPROM"). > > As with that fix, attempt to look up the MAC address in Open

Re: [PATCH net v4] ipv6: clean up dev_snmp6 proc entry when we fail to initialize inet6_dev

2015-11-04 Thread Cong Wang
On Wed, Nov 4, 2015 at 9:30 AM, Sabrina Dubroca wrote: > In ipv6_add_dev, when addrconf_sysctl_register fails, we do not clean up > the dev_snmp6 entry that we have already registered for this device. > Call snmp6_unregister_dev in this case. > > Fixes: a317a2f19da7d ("ipv6:

Re: [PATCH v2 1/4] ipv4: add option to drop unicast encapsulated in L2 multicast

2015-11-04 Thread Johannes Berg
On Wed, 2015-11-04 at 22:59 +0200, Julian Anastasov wrote: >  > Patches 1 and 3 look correct to me, > > Reviewed-by: Julian Anastasov Thanks for checking! > If the patches are lost in the merge window you > can also consider one minor optimization, see below...

Re: [PATCH] bpf: add mod default A and X test cases

2015-11-04 Thread Z Lim
On Wed, Nov 4, 2015 at 11:36 AM, Yang Shi wrote: > When running "mod X" operation, if X is 0 the filter has to be halt. > Add new test cases to cover A = A mod X if X is 0, and A = A mod 1. > > CC: Xi Wang > CC: Zi Shen Lim >

RE: [PATCH v5] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-04 Thread Nelson, Shannon
> From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > Sent: Wednesday, November 04, 2015 11:59 AM > > On Wed, Nov 4, 2015 at 9:39 PM, Sowmini Varadhan > wrote: > > > > This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC > > address in Open

[PATCH 3/8] mm: page_counter: let page_counter_try_charge() return bool

2015-11-04 Thread Johannes Weiner
page_counter_try_charge() currently returns 0 on success and -ENOMEM on failure, which is surprising behavior given the function name. Make it follow the expected pattern of try_stuff() functions that return a boolean true to indicate success, or false for failure. Signed-off-by: Johannes Weiner

[PATCH 4/8] net: tcp_memcontrol: remove bogus hierarchy pressure propagation

2015-11-04 Thread Johannes Weiner
When a cgroup currently breaches its socket memory limit, it enters memory pressure mode for itself and its *parents*. This throttles transmission in unrelated groups that have nothing to do with the breached limit. On the contrary, breaching a limit should make that group and its *children*

[PATCH 1/8] mm: memcontrol: export root_mem_cgroup

2015-11-04 Thread Johannes Weiner
A later patch will need this symbol in files other than memcontrol.c, so export it now and replace mem_cgroup_root_css at the same time. Signed-off-by: Johannes Weiner Acked-by: Michal Hocko --- include/linux/memcontrol.h | 3 ++- mm/backing-dev.c

[PATCH 6/8] mm: memcontrol: prepare for unified hierarchy socket accounting

2015-11-04 Thread Johannes Weiner
The unified hierarchy memory controller will account socket memory. Move the infrastructure functions accordingly. Signed-off-by: Johannes Weiner Acked-by: Michal Hocko --- mm/memcontrol.c | 140 1

[PATCH 2/8] mm: vmscan: simplify memcg vs. global shrinker invocation

2015-11-04 Thread Johannes Weiner
Letting shrink_slab() handle the root_mem_cgroup, and implicitely the !CONFIG_MEMCG case, allows shrink_zone() to invoke the shrinkers unconditionally from within the memcg iteration loop. Signed-off-by: Johannes Weiner Acked-by: Michal Hocko ---

[PATCH 0/8] mm: memcontrol: account socket memory in unified hierarchy v2

2015-11-04 Thread Johannes Weiner
Hi, this is version 2 of the patches to add socket memory accounting to the unified hierarchy memory controller. Changes from v1 include: - No accounting overhead unless a dedicated cgroup is created and the memory controller instructed to track that group's memory footprint. Distribution

Re: [PATCH] bpf: add mod default A and X test cases

2015-11-04 Thread Xi Wang
On Wed, Nov 4, 2015 at 11:36 AM, Yang Shi wrote: > When running "mod X" operation, if X is 0 the filter has to be halt. > Add new test cases to cover A = A mod X if X is 0, and A = A mod 1. > > CC: Xi Wang > CC: Zi Shen Lim >

Re: [PATCH net] net: dsa: mv88e6xxx: isolate unbridged ports

2015-11-04 Thread Florian Fainelli
On 04/11/15 14:23, Vivien Didelot wrote: > The DSA documentation specifies that each port must be capable of > forwarding frames to the CPU port. The last changes on bridging support > for the mv88e6xxx driver broke this requirement for non-bridged ports. > > So as for the bridged ports, reserve

Re: [PATCH v2 1/4] ipv4: add option to drop unicast encapsulated in L2 multicast

2015-11-04 Thread Julian Anastasov
Hello, On Wed, 4 Nov 2015, Johannes Berg wrote: > From: Johannes Berg > > In order to solve a problem with 802.11, the so-called hole-196 attack, > add an option (sysctl) called "drop_unicast_in_l2_multicast" which, if > enabled, causes the stack to drop IPv4

Re: [PATCH] sh_eth: merge sh_eth_free_dma_buffer() into sh_eth_ring_free()

2015-11-04 Thread David Miller
From: Sergei Shtylyov Date: Wed, 04 Nov 2015 00:55:13 +0300 > While the ring allocation is done by a single function, sh_eth_ring_init(), > the ring deallocation was split into two functions (almost always called > one after the other) for no good reason.

Re: [PATCH] sh_eth: kill 'ret' variable in sh_eth_ring_init()

2015-11-04 Thread David Miller
From: Sergei Shtylyov Date: Wed, 04 Nov 2015 00:17:08 +0300 > The 'ret' local variable in sh_eth_ring_init() serves no useful purpose as > the only values it gets assigned are 0 and -ENOMEM both of which could be > returned directly... > > Signed-off-by:

Re: [PATCH 1/1] commit c6825c0976fa7893692e0e43b09740b419b23c09 upstream.

2015-11-04 Thread Ani Sinha
(removed a bunch of people from CC list) On Mon, Oct 26, 2015 at 1:06 PM, Pablo Neira Ayuso wrote: > Then we can review and, if no major concerns, I can submit this to > -stable. Now that Neal has sufficiently tested the patches, is it OK to apply to -stable or do you guys

Re: [PATCH] drivers: net: cpsw: Add support for fixed-link PHY

2015-11-04 Thread David Miller
From: Markus Brunner Date: Tue, 03 Nov 2015 22:09:51 +0100 > Add support for a fixed-link devicetree sub-node in case the the > cpsw MAC is directly connected to a non-mdio PHY/device. > > Signed-off-by: Markus Brunner

Re: [PATCH v5] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-04 Thread Andy Shevchenko
On Thu, Nov 5, 2015 at 12:53 AM, Nelson, Shannon wrote: >> From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] >> Sent: Wednesday, November 04, 2015 11:59 AM >> >> On Wed, Nov 4, 2015 at 9:39 PM, Sowmini Varadhan >> wrote: >> > >> >

Re: [Patch net v2] ipv4: fix a potential deadlock in mcast getsockopt() path

2015-11-04 Thread David Miller
From: Cong Wang Date: Tue, 3 Nov 2015 15:41:16 -0800 > Sasha reported the following lockdep warning: > > Possible unsafe locking scenario: > > CPU0CPU1 > >lock(sk_lock-AF_INET); >

[PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-04 Thread Sowmini Varadhan
This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC address in Open Firmware or IDPROM"). As with that fix, attempt to look up the MAC address in Open Firmware on systems that support it, and use IDPROM on SPARC if no OF address is found. In the case of the i40e there is an

Re: [PATCH v2 2/4] e1000e: Do not read icr in Other interrupt

2015-11-04 Thread Benjamin Poirier
On 2015/10/30 12:19, Alexander Duyck wrote: > On 10/30/2015 10:31 AM, Benjamin Poirier wrote: > >Using eiac instead of reading icr allows us to avoid interference with > >rx and tx interrupts in the Other interrupt handler. > > > >According to the 82574 datasheet section 10.2.4.1, interrupt causes

Re: [PATCH v2 2/4] e1000e: Do not read icr in Other interrupt

2015-11-04 Thread Alexander Duyck
On 11/04/2015 03:19 PM, Benjamin Poirier wrote: On 2015/10/30 12:19, Alexander Duyck wrote: On 10/30/2015 10:31 AM, Benjamin Poirier wrote: Using eiac instead of reading icr allows us to avoid interference with rx and tx interrupts in the Other interrupt handler. According to the 82574

Re: [PATCH RFC net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2015-11-04 Thread Bendik Rønning Opstad
On Monday, November 02, 2015 09:37:54 AM David Laight wrote: > From: Bendik Rønning Opstad > > Sent: 23 October 2015 21:50 > > RDB is a mechanism that enables a TCP sender to bundle redundant > > (already sent) data with TCP packets containing new data. By bundling > > (retransmitting) already

Re: [Patch net] ipv4: disable BH when changing ip local port range

2015-11-04 Thread David Miller
From: Cong Wang Date: Tue, 3 Nov 2015 14:32:57 -0800 > This fixes the following lockdep warning: ... > Fixes: b8f1a55639e6 ("udp: Add function to make source port for UDP tunnels") > Cc: Tom Herbert > Signed-off-by: Cong Wang

RE: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-04 Thread Nelson, Shannon
> From: Sowmini Varadhan [mailto:sowmini.varad...@oracle.com] > Sent: Wednesday, November 04, 2015 3:21 PM > > This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC > address in Open Firmware or IDPROM"). > > As with that fix, attempt to look up the MAC address in Open Firmware

Re: [PATCH] bpf: fix trivial comment typo

2015-11-04 Thread Matthew Fernandez
On 03/11/15 20:48, Daniel Borkmann wrote: On 11/02/2015 10:48 PM, Matthew Fernandez wrote: On 03/11/15 08:31, David Miller wrote: From: Matthew Fernandez Date: Mon, 2 Nov 2015 11:59:03 +1100 bpf: fix trivial comment typo Signed-off-by: Matthew Fernandez

[PATCH net v2] bpf: fix trivial comment typo

2015-11-04 Thread Matthew Fernandez
bpf: fix trivial comment typo Signed-off-by: Matthew Fernandez diff --git a/kernel/bpf/core.c b/kernel/bpf/core.c index 334b1bd..0bd41f5 100644 --- a/kernel/bpf/core.c +++ b/kernel/bpf/core.c @@ -462,7 +462,7 @@ select_insn: /* ARG1 at this point

Re: [PATCH 0/3] Netfilter fixes for net

2015-11-04 Thread David Miller
From: Pablo Neira Ayuso Date: Wed, 4 Nov 2015 15:00:35 +0100 > The following patchset contains Netfilter fixes for your net tree, > they are: > > 1) Fix crash when TEE target is used with no --oif, from Eric Dumazet. > > 2) Oneliner to fix a crash on the redirect traffic

Re: [PATCH net] net: dsa: mv88e6xxx: isolate unbridged ports

2015-11-04 Thread Andrew Lunn
> > +int mv88e6xxx_port_bridge_join(struct dsa_switch *ds, int port, u32 > > members) > > +{ > > + struct mv88e6xxx_priv_state *ps = ds_to_priv(ds); > > + const u16 pvid = 4000 + ds->index * DSA_MAX_PORTS + port; > > + int err; > > + > > + /* The port joined a bridge, so leave its

Re: [PATCH v2 net-next] net/core: ensure features get disabled on new lower devs

2015-11-04 Thread David Miller
From: Jarod Wilson Date: Tue, 3 Nov 2015 23:09:32 -0500 > With moving netdev_sync_lower_features() after the .ndo_set_features > calls, I neglected to verify that devices added *after* a flag had been > disabled on an upper device were properly added with that flag disabled as

AF_PACKET mmap() v4...

2015-11-04 Thread David Miller
As part of fixing y2038 problems, Arnd is going to have to make a new version fo the AF_PACKET mmap() tpacker descriptors in order to extend the time values to 64-bit. So I want everyone to think about whether there are any other changes we might want to make given that we have to make a v4

Re: [PATCH net v2] bpf: fix trivial comment typo

2015-11-04 Thread David Miller
From: Matthew Fernandez Date: Thu, 5 Nov 2015 11:09:52 +1100 > bpf: fix trivial comment typo > > Signed-off-by: Matthew Fernandez This does not apply. It looks like your email client has corrupted the patch. -- To unsubscribe from

Re: AF_PACKET mmap() v4...

2015-11-04 Thread Richard Cochran
On Thu, Nov 05, 2015 at 12:04:14AM -0500, David Miller wrote: > So I want everyone to think about whether there are any other changes > we might want to make given that we have to make a v4 anyways. One thing I would like to see is a field for a desired transmit time. Time based scheduling is a

Re: [PATCH] bnxt_en: add VXLAN dependency

2015-11-04 Thread David Miller
From: Arnd Bergmann Date: Wed, 04 Nov 2015 16:00:32 +0100 > VXLAN may be a loadable module, and this driver cannot be built-in > in that case, or we get a link error: > > drivers/built-in.o: In function `__bnxt_open_nic': > drivers/net/ethernet/broadcom/bnxt/bnxt.c:4581:

Re: [patch net-next] net: add forgotten IFF_L3MDEV_SLAVE define

2015-11-04 Thread David Miller
From: Jiri Pirko Date: Wed, 4 Nov 2015 14:59:06 +0100 > From: Jiri Pirko > > Fixes: fee6d4c77 ("net: Add netif_is_l3_slave") > Signed-off-by: Jiri Pirko Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH net v3] ipv6: clean up dev_snmp6 proc entry when we fail to initialize inet6_dev

2015-11-04 Thread David Miller
From: Sabrina Dubroca Date: Wed, 4 Nov 2015 18:00:13 +0100 > In ipv6_add_dev, when addrconf_sysctl_register fails, we do not clean up > the dev_snmp6 entry that we have already registered for this device. > Call snmp6_unregister_dev in this case. > > Fixes: a317a2f19da7d

Re: [PATCH net] tun_dst: Fix potential NULL dereference

2015-11-04 Thread David Miller
From: Tobias Klauser Date: Wed, 4 Nov 2015 13:49:49 +0100 > In tun_dst_unclone() the return value of skb_metadata_dst() is checked > for being NULL after it is dereferenced. Fix this by moving the > dereference after the NULL check. > > Found by the Coverity scanner (CID

Re: [patch -next] qlogic: qed: fix a test for MODE_MF_SI

2015-11-04 Thread David Miller
From: Dan Carpenter Date: Wed, 4 Nov 2015 16:29:11 +0300 > MODE_MF_SI is 9. We should be testing bit 9 instead of AND 0x9. > > Fixes: fe56b9e6a8d9 ('qed: Add module with basic common support') > Signed-off-by: Dan Carpenter Applied. -- To

Re: [patch -next] qlogic/qed: remove bogus NULL check

2015-11-04 Thread David Miller
From: Dan Carpenter Date: Wed, 4 Nov 2015 16:27:16 +0300 > We check if "p_hwfn" is NULL and then dereference it in the error > handling code. I read the code and it isn't NULL so let's remove the > check. > > Signed-off-by: Dan Carpenter

Re: [MM PATCH V4 6/6] slub: optimize bulk slowpath free by detached freelist

2015-11-04 Thread Joonsoo Kim
On Wed, Oct 21, 2015 at 09:57:09AM +0200, Jesper Dangaard Brouer wrote: > On Wed, 14 Oct 2015 14:15:25 +0900 > Joonsoo Kim wrote: > > > On Tue, Sep 29, 2015 at 05:48:26PM +0200, Jesper Dangaard Brouer wrote: > > > This change focus on improving the speed of object freeing

Re: [PATCH] net: Fix prefsrc lookups

2015-11-04 Thread David Miller
From: David Ahern Date: Tue, 3 Nov 2015 15:59:28 -0800 > A bug report (https://bugzilla.kernel.org/show_bug.cgi?id=107071) noted > that the follwoing ip command is failing with v4.3: > > $ ip route add 10.248.5.0/24 dev bond0.250 table vlan_250 src 10.248.5.154 >

Re: [PATCH] VSOCK: call sk->sk_data_ready() on accept()

2015-11-04 Thread David Miller
From: Stefan Hajnoczi Date: Wed, 4 Nov 2015 12:58:42 + > When a listen socket enqueues a connection for userspace to accept(), > the sk->sk_data_ready() callback should be invoked. In-kernel socket > users rely on this callback to detect when incoming connections are >

Re: [PATCH] bpf: add mod default A and X test cases

2015-11-04 Thread David Miller
From: Yang Shi Date: Wed, 4 Nov 2015 11:36:37 -0800 > When running "mod X" operation, if X is 0 the filter has to be halt. > Add new test cases to cover A = A mod X if X is 0, and A = A mod 1. > > CC: Xi Wang > CC: Zi Shen Lim >

Re: [PATCH] net: stmmac: remove unneeded phy_iface variable

2015-11-04 Thread David Miller
From: LABBE Corentin Date: Wed, 4 Nov 2015 21:08:12 +0100 > The variable phy_iface is double-initialized and finally is not necessary > at all. > > Reported-by: coverity (CID 1271141) > Signed-off-by: LABBE Corentin The value is used in

pull request: bluetooth 2015-11-05

2015-11-04 Thread Johan Hedberg
Hi Dave, The following set of Bluetooth patches would be good to get into 4.4-rc1 if possible: - Fix for missing LE CoC parameter validity checks - Fix for potential deadlock in btusb - Fix for issuing unsupported commands during HCI init Please let me know if there are any issues pulling.

RE: kernel 3.14.53 + bnx2x loss of connectivity / parity errors / MCP SCPAD

2015-11-04 Thread Yuval Mintz
> on a production server (HP DL380 Gen9 with HP 10GE dual port card - bnx2x > driver), I just encountered a full loss of connectivity through the 10 GE > ports. > Kernel in use is vanilla 3.14.53. > > On the console I could see this (timestamps omitted, have to type by hand, > damn ILO console

Re: [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

2015-11-04 Thread Johannes Weiner
On Wed, Nov 04, 2015 at 11:42:40AM +0100, Michal Hocko wrote: > On Thu 29-10-15 09:10:09, Johannes Weiner wrote: > > On Thu, Oct 29, 2015 at 04:25:46PM +0100, Michal Hocko wrote: > > > On Tue 27-10-15 09:42:27, Johannes Weiner wrote: > [...] > > > > You carefully skipped over this part. We can

Re: 4.1.12 kernel crash in rtnetlink_put_metrics

2015-11-04 Thread Daniel Borkmann
Hi Andrew, thanks for the report! On 11/04/2015 05:00 PM, Andrew wrote: Hi all. Today I've got a crash on one of servers (PPPoE BRAS with BGP/OSPF). This server becomes unstable after updating from 3.2.x kernel to 4.1.x (other servers with slightly different CPUs/MBs also have troubles -

[PATCH] bpf: add mod default A and X test cases

2015-11-04 Thread Yang Shi
When running "mod X" operation, if X is 0 the filter has to be halt. Add new test cases to cover A = A mod X if X is 0, and A = A mod 1. CC: Xi Wang CC: Zi Shen Lim Signed-off-by: Yang Shi --- lib/test_bpf.c | 30

Re: [PATCH v5] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-04 Thread Andy Shevchenko
On Wed, Nov 4, 2015 at 9:39 PM, Sowmini Varadhan wrote: > > This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC > address in Open Firmware or IDPROM"). > > As with that fix, attempt to look up the MAC address in Open Firmware > on systems that

Re: [PATCH v5] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-04 Thread Sowmini Varadhan
On (11/04/15 21:59), Andy Shevchenko wrote: > > Usually the structure of kernel doc is something like following > > /** > * func - summary > * @paramx: desc > * > * Description: > * Long description in many lines and / or paragraphs > * > * Returns: > * 0 on success or errno otherwise. >

[PATCH] net: stmmac: remove unneeded phy_iface variable

2015-11-04 Thread LABBE Corentin
The variable phy_iface is double-initialized and finally is not necessary at all. Reported-by: coverity (CID 1271141) Signed-off-by: LABBE Corentin --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff

Re: [PATCH] bpf: add mod default A and X test cases

2015-11-04 Thread Daniel Borkmann
On 11/04/2015 08:36 PM, Yang Shi wrote: When running "mod X" operation, if X is 0 the filter has to be halt. Add new test cases to cover A = A mod X if X is 0, and A = A mod 1. CC: Xi Wang CC: Zi Shen Lim Signed-off-by: Yang Shi

[PATCH v5] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-04 Thread Sowmini Varadhan
This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC address in Open Firmware or IDPROM"). As with that fix, attempt to look up the MAC address in Open Firmware on systems that support it, and use IDPROM on SPARC if no OF address is found. In the case of the i40e there is an

Re: [Patch net v2] ipv4: fix a potential deadlock in mcast getsockopt() path

2015-11-04 Thread Marcelo Ricardo Leitner
Em 03-11-2015 21:41, Cong Wang escreveu: Sasha reported the following lockdep warning: Possible unsafe locking scenario: CPU0CPU1 lock(sk_lock-AF_INET); lock(rtnl_mutex);

Re: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-04 Thread Sowmini Varadhan
On (11/02/15 14:57), Sowmini Varadhan wrote: > On (11/02/15 17:26), Nelson, Shannon wrote: > > > I assume you mean .1q > > > > Yes, this is what I had in mind. > > I dont think we're quite there yet, even without vlans. > Ok finally got all the .1q stuff verified (took a bit longer than it

NETIF_F_GSO_SOFTWARE vs NETIF_F_GSO

2015-11-04 Thread Jason A. Donenfeld
Hello, I am making a network device driver that receives packets in ndo_start_xmit, "does something to them", and then sends the resultant packet out of a kernelspace UDP socket. The routine looks something along the lines of: size_t outgoing_len = calculate_outgoing_length(skb); struct

Re: [PATCH net-next] ipv6: gro: support sit protocol

2015-11-04 Thread Eric Dumazet
On Wed, 2015-11-04 at 13:19 +0100, Wolfgang Walter wrote: > Today I found a problem: on a router forwarding GRE-packets (ipv4) (it is not > the endpount) the interface (intel igb) stops sending packets after some > time. > I think this happens when an ISATAP packet is inside the GRE-packet. >

Re: [patch net-next] net: add forgotten IFF_L3MDEV_SLAVE define

2015-11-04 Thread David Ahern
On 11/4/15 6:59 AM, Jiri Pirko wrote: From: Jiri Pirko Fixes: fee6d4c77 ("net: Add netif_is_l3_slave") Signed-off-by: Jiri Pirko --- include/linux/netdevice.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/netdevice.h

Re: [kbuild-all] [PATCH] mpls: fix semicolon.cocci warnings

2015-11-04 Thread David Miller
From: Julia Lawall Date: Wed, 4 Nov 2015 07:50:05 +0100 (CET) > The whole idea of a macro that declares variables some of which are then > used in the code under the macro also seems quite unpleasant. Other > iterators don't do this, and so they don't need the end

Re: [PATCH net-next] ipv6: gro: support sit protocol

2015-11-04 Thread Eric Dumazet
On Wed, 2015-11-04 at 15:09 +0100, Wolfgang Walter wrote: > > Yes, maybe igb has a problem sending a gro-packet if it is an isatap in gre. We might detect this condition properly from igb ndo_features_check method. It currently uses plain passthru_features_check() > > igb has no problem

Re: [RFC][PATCH] net: arinc429: Add ARINC-429 stack

2015-11-04 Thread Marek Vasut
On Wednesday, November 04, 2015 at 04:03:16 PM, Vostrikov Andrey wrote: > Hi, Marek. Hi, > > About the parity -- can we add some flag into the datagram to indicate we > > want hardware to calculate the parity for that particular datagram for > > us? And we'd also need to indicate what type of

Re: [PATCH net-next] ipv6: gro: support sit protocol

2015-11-04 Thread Wolfgang Walter
Am Mittwoch, 4. November 2015, 04:40:51 schrieb Eric Dumazet: > On Wed, 2015-11-04 at 13:19 +0100, Wolfgang Walter wrote: > > Today I found a problem: on a router forwarding GRE-packets (ipv4) (it is > > not the endpount) the interface (intel igb) stops sending packets after > > some time. I think

Re: [RFC][PATCH] net: arinc429: Add ARINC-429 stack

2015-11-04 Thread Vostrikov Andrey
Hi, Marek. > About the parity -- can we add some flag into the datagram to indicate we > want hardware to calculate the parity for that particular datagram for us? > And we'd also need to indicate what type of parity. I dunno if this is worth > the hassle. This is HW configuration property, it

Re: [RFC][PATCH] net: arinc429: Add ARINC-429 stack

2015-11-04 Thread Vostrikov Andrey
Hi, Marek. >> > About the parity -- can we add some flag into the datagram to indicate we >> > want hardware to calculate the parity for that particular datagram for >> > us? And we'd also need to indicate what type of parity. I dunno if this >> > is worth the hassle. >> >> This is HW

[PATCH] bnxt_en: add VXLAN dependency

2015-11-04 Thread Arnd Bergmann
VXLAN may be a loadable module, and this driver cannot be built-in in that case, or we get a link error: drivers/built-in.o: In function `__bnxt_open_nic': drivers/net/ethernet/broadcom/bnxt/bnxt.c:4581: undefined reference to `vxlan_get_rx_port' This adds a Kconfig dependency that ensures that

Re: [RFC][PATCH] net: arinc429: Add ARINC-429 stack

2015-11-04 Thread Aleksander Morgado
On Wed, Nov 4, 2015 at 4:18 PM, Vostrikov Andrey wrote: >>> > About the parity -- can we add some flag into the datagram to indicate we >>> > want hardware to calculate the parity for that particular datagram for >>> > us? And we'd also need to indicate what

Re: [PATCH net v2] ipv6: clean up dev_snmp6 proc entry when we fail to initialize inet6_dev

2015-11-04 Thread Eric Dumazet
On Wed, 2015-11-04 at 14:47 +0100, Sabrina Dubroca wrote: > In ipv6_add_dev, when addrconf_sysctl_register fails, we do not clean up > the dev_snmp6 entry that we have already registered for this device. > Call snmp6_unregister_dev in this case. > > Reported-by: Dmitry Vyukov

[patch -next] qlogic: qed: fix a test for MODE_MF_SI

2015-11-04 Thread Dan Carpenter
MODE_MF_SI is 9. We should be testing bit 9 instead of AND 0x9. Fixes: fe56b9e6a8d9 ('qed: Add module with basic common support') Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/qlogic/qed/qed_dev.c b/drivers/net/ethernet/qlogic/qed/qed_dev.c index

[PATCH net v2] ipv6: clean up dev_snmp6 proc entry when we fail to initialize inet6_dev

2015-11-04 Thread Sabrina Dubroca
In ipv6_add_dev, when addrconf_sysctl_register fails, we do not clean up the dev_snmp6 entry that we have already registered for this device. Call snmp6_unregister_dev in this case. Reported-by: Dmitry Vyukov Signed-off-by: Sabrina Dubroca --- v2: we

[PATCH 1/3] netfilter: xt_TEE: fix NULL dereference

2015-11-04 Thread Pablo Neira Ayuso
From: Eric Dumazet iptables -I INPUT ... -j TEE --gateway 10.1.2.3 because --oif was not specified tee_tg_check() sets ->priv pointer to NULL in this case. Fixes: bbde9fc1824a ("netfilter: factor out packet duplication for IPv4/IPv6") Signed-off-by: Eric Dumazet

[PATCH 2/3] netfilter: nf_nat_redirect: add missing NULL pointer check

2015-11-04 Thread Pablo Neira Ayuso
From: Munehisa Kamata Commit 8b13eddfdf04cbfa561725cfc42d6868fe896f56 ("netfilter: refactor NAT redirect IPv4 to use it from nf_tables") has introduced a trivial logic change which can result in the following crash. BUG: unable to handle kernel NULL pointer dereference at

[PATCH 3/3] netfilter: nfnetlink: don't probe module if it exists

2015-11-04 Thread Pablo Neira Ayuso
From: Florian Westphal nfnetlink_bind request_module()s all the time as nfnetlink_get_subsys() shifts the argument by 8 to obtain the subsys id. So using type instead of type << 8 always returns NULL. Fixes: 03292745b02d11 ("netlink: add nlk->netlink_bind hook for module

[PATCH 0/3] Netfilter fixes for net

2015-11-04 Thread Pablo Neira Ayuso
Hi David, The following patchset contains Netfilter fixes for your net tree, they are: 1) Fix crash when TEE target is used with no --oif, from Eric Dumazet. 2) Oneliner to fix a crash on the redirect traffic to localhost infrastructure when interface has not yet an address, from Munehisa

[PATCH net] tun_dst: Fix potential NULL dereference

2015-11-04 Thread Tobias Klauser
In tun_dst_unclone() the return value of skb_metadata_dst() is checked for being NULL after it is dereferenced. Fix this by moving the dereference after the NULL check. Found by the Coverity scanner (CID 1338068). Fixes: fc4099f17240 ("openvswitch: Fix egress tunnel info.") Cc: Pravin B Shelar

[PATCH] VSOCK: call sk->sk_data_ready() on accept()

2015-11-04 Thread Stefan Hajnoczi
When a listen socket enqueues a connection for userspace to accept(), the sk->sk_data_ready() callback should be invoked. In-kernel socket users rely on this callback to detect when incoming connections are available. Currently the sk->sk_state_change() callback is invoked by vmci_transport.c.

[patch -next] qlogic/qed: remove bogus NULL check

2015-11-04 Thread Dan Carpenter
We check if "p_hwfn" is NULL and then dereference it in the error handling code. I read the code and it isn't NULL so let's remove the check. Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/qlogic/qed/qed_int.c

[PATCH net] ipv6: allow routes to be configured with expire values

2015-11-04 Thread Xin Long
Add the support for adding expire value to routes, requested by Tom Gundersen for systemd-networkd, and NetworkManager wants it too. add it by using the field rta_expires of rta_cacheinfo Signed-off-by: Xin Long Signed-off-by: Hannes Frederic Sowa

RE: [patch -next] qlogic: qed: fix a test for MODE_MF_SI

2015-11-04 Thread Yuval Mintz
> MODE_MF_SI is 9. We should be testing bit 9 instead of AND 0x9. > > Fixes: fe56b9e6a8d9 ('qed: Add module with basic common support') > Signed-off-by: Dan Carpenter True indeed. Thanks. Acked-by: Yuval Mintz -- To unsubscribe from this list:

[patch net-next] net: add forgotten IFF_L3MDEV_SLAVE define

2015-11-04 Thread Jiri Pirko
From: Jiri Pirko Fixes: fee6d4c77 ("net: Add netif_is_l3_slave") Signed-off-by: Jiri Pirko --- include/linux/netdevice.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 4ac653b..2c00772 100644

Re: [RFC][PATCH] net: arinc429: Add ARINC-429 stack

2015-11-04 Thread Marek Vasut
On Wednesday, November 04, 2015 at 10:34:50 AM, Aleksander Morgado wrote: > On Tue, Nov 3, 2015 at 10:43 PM, Marek Vasut wrote: > > On Tuesday, November 03, 2015 at 08:28:43 PM, Oliver Hartkopp wrote: > >> On 11/03/2015 08:19 PM, Marek Vasut wrote: > >> > On Tuesday, November 03,

kernel 3.14.53 + bnx2x loss of connectivity / parity errors / MCP SCPAD

2015-11-04 Thread Patrick Schaaf
Dear netdevs, on a production server (HP DL380 Gen9 with HP 10GE dual port card - bnx2x driver), I just encountered a full loss of connectivity through the 10 GE ports. Kernel in use is vanilla 3.14.53. On the console I could see this (timestamps omitted, have to type by hand, damn ILO

Re: [PATCH net-next] ipv6: gro: support sit protocol

2015-11-04 Thread Wolfgang Walter
Am Dienstag, 3. November 2015, 05:07:33 schrieb Eric Dumazet: > On Tue, 2015-11-03 at 13:57 +0100, Wolfgang Walter wrote: > > Am Montag, 19. Oktober 2015, 20:40:17 schrieb Eric Dumazet: > > > From: Eric Dumazet > > > > > > Tom Herbert added SIT support to GRO with commit > >

RE: [patch -next] qlogic/qed: remove bogus NULL check

2015-11-04 Thread Yuval Mintz
> We check if "p_hwfn" is NULL and then dereference it in the error handling > code. I read the code and it isn't NULL so let's remove the check. > > Signed-off-by: Dan Carpenter Our current interrupt handling logic is being uber-defensive. Thanks. Acked-by: Yuval

Re: [RFC][PATCH] net: arinc429: Add ARINC-429 stack

2015-11-04 Thread Marek Vasut
On Wednesday, November 04, 2015 at 04:19:45 PM, Aleksander Morgado wrote: > On Wed, Nov 4, 2015 at 4:18 PM, Vostrikov Andrey > > wrote: > >>> > About the parity -- can we add some flag into the datagram to > >>> > indicate we want hardware to calculate the

Re: [iproute PATCH] iproute: fix filter_nlmsg

2015-11-04 Thread Phil Sutter
On Tue, Nov 03, 2015 at 04:33:59PM -0800, Stephen Hemminger wrote: > On Thu, 29 Oct 2015 12:15:47 +0100 > Phil Sutter wrote: > > > This patch is based upon an old Fedora bug[1] regarding the routing > > setup of PPP links. I'm not quite sure if it still applies today or how > > to

4.1.12 kernel crash in rtnetlink_put_metrics

2015-11-04 Thread Andrew
Hi all. Today I've got a crash on one of servers (PPPoE BRAS with BGP/OSPF). This server becomes unstable after updating from 3.2.x kernel to 4.1.x (other servers with slightly different CPUs/MBs also have troubles - but they hang less frequently). Place in kernel code: (gdb) list

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-11-04 Thread Al Viro
On Wed, Nov 04, 2015 at 03:54:09PM +, David Laight wrote: > > Sigh... The kernel has no idea when other threads are done with "all > > io activities using that fd" - it can wait for them to leave the > > kernel mode, but there's fuck-all it can do about e.g. a userland > > loop doing write()

Re: [PATCH] bnxt_en: add VXLAN dependency

2015-11-04 Thread Michael Chan
On Wed, 2015-11-04 at 16:00 +0100, Arnd Bergmann wrote: > VXLAN may be a loadable module, and this driver cannot be built-in > in that case, or we get a link error: > > drivers/built-in.o: In function `__bnxt_open_nic': > drivers/net/ethernet/broadcom/bnxt/bnxt.c:4581: undefined reference to >

Re: [PATCH net v2] ipv6: clean up dev_snmp6 proc entry when we fail to initialize inet6_dev

2015-11-04 Thread Sabrina Dubroca
2015-11-04, 07:23:14 -0800, Eric Dumazet wrote: > On Wed, 2015-11-04 at 14:47 +0100, Sabrina Dubroca wrote: > > In ipv6_add_dev, when addrconf_sysctl_register fails, we do not clean up > > the dev_snmp6 entry that we have already registered for this device. > > Call snmp6_unregister_dev in this

Expected behaviour of `tc qdisc replace`?

2015-11-04 Thread Toke Høiland-Jørgensen
Hi I recently noticed that the behaviour of `tc qdisc replace` differs depending on whether the qdisc being replaced is of the same kind as the replacement. I.e.: # tc qdisc del dev eno1 root # tc qdisc replace dev eno1 root fq_codel target 100ms interval 200ms # tc qdisc replace dev eno1 root

Re: [PATCH] drivers: net: cpsw: Add support for fixed-link PHY

2015-11-04 Thread Mugunthan V N
On Wednesday 04 November 2015 02:39 AM, Markus Brunner wrote: > Add support for a fixed-link devicetree sub-node in case the the > cpsw MAC is directly connected to a non-mdio PHY/device. > > Signed-off-by: Markus Brunner Looks good to me. Acked-by:

[PATCH v2 2/4] ipv6: add option to drop unicast encapsulated in L2 multicast

2015-11-04 Thread Johannes Berg
From: Johannes Berg In order to solve a problem with 802.11, the so-called hole-196 attack, add an option (sysctl) called "drop_unicast_in_l2_multicast" which, if enabled, causes the stack to drop IPv6 unicast packets encapsulated in link-layer multi- or broadcast

  1   2   >