[PATCH v3 3/5] stmmac: remove some __func__ printing

Now that stmmac use netdev_xxx, some __func__ are not necessary since their use was to clearly identify which driver was logging. Moreover, as pointed by Joe Perches, using __func__ in xxx_dbg functions is relatively low value and dynamic debug can add it. This patch remove __func__ where such

hallo

Привет, дорогой друг, Do you speak English I'M Кристина М Гамак. Я единого государства Военные / НАСА. Из единого государства Америки. Могу поддержку и заботу, с нетерпением жду, чтобы получить хороший друг. Я прочитал ваш профиль из facebook.com и забрать интерес на вас. Я хотел бы установить

Re: AF_PACKET mmap() v4...

On Nov 4, 2015, at 9:04 PM, David Miller wrote: > As part of fixing y2038 problems, Arnd is going to have to make a new > version fo the AF_PACKET mmap() tpacker descriptors in order to extend > the time values to 64-bit. > > So I want everyone to think about whether there

[PATCH v3 4/4] ipv6: add option to drop unsolicited neighbor advertisements

From: Johannes Berg In certain 802.11 wireless deployments, there will be NA proxies that use knowledge of the network to correctly answer requests. To prevent unsolicitd advertisements on the shared medium from being a problem, on such deployments wireless needs to drop

[PATCH v3 2/4] ipv4: add option to drop gratuitous ARP packets

From: Johannes Berg In certain 802.11 wireless deployments, there will be ARP proxies that use knowledge of the network to correctly answer requests. To prevent gratuitous ARP frames on the shared medium from being a problem, on such deployments wireless needs to drop

[PATCH v3 1/4] ipv4: add option to drop unicast encapsulated in L2 multicast

From: Johannes Berg In order to solve a problem with 802.11, the so-called hole-196 attack, add an option (sysctl) called "drop_unicast_in_l2_multicast" which, if enabled, causes the stack to drop IPv4 unicast packets encapsulated in link-layer multi- or broadcast

[patch -next] qlogic: qed: fix error codes in qed_resc_alloc()

We accidentally return success instead of -ENOMEM here. Fixes: fe56b9e6a8d9 ('qed: Add module with basic common support') Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/qlogic/qed/qed_dev.c b/drivers/net/ethernet/qlogic/qed/qed_dev.c index

RE: [patch -next] qlogic: qed: fix error codes in qed_resc_alloc()

> We accidentally return success instead of -ENOMEM here. > > Fixes: fe56b9e6a8d9 ('qed: Add module with basic common support') > Signed-off-by: Dan Carpenter > Thanks. Although you might also argue that it's good enough for this function to always return -ENOMEM

[PATCH] net: stmmac: fix double-initialization of phy_iface

The variable phy_iface is double-initialized to itself. This patch remove that. Reported-by: coverity (CID 1271141) Signed-off-by: LABBE Corentin --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2 1/4] ipv4: add option to drop unicast encapsulated in L2 multicast

Hello, On Wed, 4 Nov 2015, Johannes Berg wrote: > On Wed, 2015-11-04 at 22:59 +0200, Julian Anastasov wrote: > >  > > } else if (unlikely(skb->pkt_type != PACKET_HOST)) { > > > > May be such check can save some cycles because > > it is more common to see PACKET_HOST

[PATCH v3] stmmac: improve logging

Hello This patch series try to improve logging of the stmmac driver. Changes since v2 - Rollback to dev_ for some early init printing - rebased on 4.4-rc1 Changes since v1 - Use netdev_xxx instead of dev_xxx - Use netif_xxx instead of "if (netif_msg_type) dev_xxx" Regards -- To unsubscribe

[PATCH v3 1/5] stmmac: replace all pr_xxx by their netdev_xxx counterpart

The stmmac driver use lots of pr_xxx functions to print information. This is bad since we cannot know which device logs the information. (moreover if two stmmac device are present) Furthermore, it seems that it assumes wrongly that all logs will always be subsequent by using a dev_xxx then some

[PATCH v3 3/4] ipv6: add option to drop unicast encapsulated in L2 multicast

From: Johannes Berg In order to solve a problem with 802.11, the so-called hole-196 attack, add an option (sysctl) called "drop_unicast_in_l2_multicast" which, if enabled, causes the stack to drop IPv6 unicast packets encapsulated in link-layer multi- or broadcast

Re: [PATCH v3 1/4] ipv4: add option to drop unicast encapsulated in L2 multicast

Hello, On Thu, 5 Nov 2015, Johannes Berg wrote: > From: Johannes Berg > > In order to solve a problem with 802.11, the so-called hole-196 attack, > add an option (sysctl) called "drop_unicast_in_l2_multicast" which, if > enabled, causes the stack to drop IPv4

Re: AF_PACKET mmap() v4...

On Thursday 05 November 2015 00:04:14 David Miller wrote: > As part of fixing y2038 problems, Arnd is going to have to make a new > version fo the AF_PACKET mmap() tpacker descriptors in order to extend > the time values to 64-bit. > > So I want everyone to think about whether there are any other

Re: AF_PACKET mmap() v4...

On 11/05/2015 10:07 AM, Arnd Bergmann wrote: On Thursday 05 November 2015 00:04:14 David Miller wrote: As part of fixing y2038 problems, Arnd is going to have to make a new version fo the AF_PACKET mmap() tpacker descriptors in order to extend the time values to 64-bit. So I want everyone to

Re: kernel 3.14.53 + bnx2x loss of connectivity / parity errors / MCP SCPAD

Hi Yuval, thanks for your notes. > 4. The patch you've listed merely removes the MCP SCPAD prints, as they're > unavoidable in certain scenarios; It doesn't actually solve anything. I also thought so, thanks for confirming. Do you know whether the messages might have hidden earlier messages

[PATCH v3 4/5] stmmac: Fix simple style problem

This patch fix the following warnings: - braces {} should be used on all arms of this statement - Prefer seq_puts to seq_printf - No space is necessary after a cast - Missing a blank line after declarations - Please don't use multiple blank lines - Comparison to NULL could be written - networking

[PATCH v3 5/5] net: stmmac: replace if (netif_msg_type) by their netif_xxx counterpart

As sugested by Joe Perches, we could replace all if (netif_msg_type(priv)) dev_xxx(priv->devices, ...) by the simplier macro netif_xxx(priv, hw, priv->dev, ...) Signed-off-by: LABBE Corentin --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 58

[PATCH v3 2/5] stmmac: replace hardcoded function name by __func__

Some printing have the function name hardcoded. It is better to use __func__ instead. Signed-off-by: LABBE Corentin --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] glibc: Terminate process on invalid netlink response from kernel [BZ #12926]

Hello, On Tue, Nov 3, 2015, at 15:00, Florian Weimer wrote: > On 11/03/2015 02:48 PM, Hannes Frederic Sowa wrote: > > Hello, > > > > On Fri, Oct 23, 2015, at 21:07, Florian Weimer wrote: > >> (By the way, we'd also love to have a better kernel interface to fulfill > >> the needs for getaddrinfo

Re: [PATCH] sh_eth: merge sh_eth_free_dma_buffer() into sh_eth_ring_free()

Hello. On 11/5/2015 4:59 AM, David Miller wrote: While the ring allocation is done by a single function, sh_eth_ring_init(), the ring deallocation was split into two functions (almost always called one after the other) for no good reason. Merge sh_eth_free_dma_buffer() into sh_eth_ring_free()

Re: AF_PACKET mmap() v4...

On 11/05/2015 12:38 PM, Eric Dumazet wrote: On Thu, 2015-11-05 at 10:39 +0100, Daniel Borkmann wrote: On 11/05/2015 10:07 AM, Arnd Bergmann wrote: On Thursday 05 November 2015 00:04:14 David Miller wrote: As part of fixing y2038 problems, Arnd is going to have to make a new version fo the

[PATCH v4 5/5] net: stmmac: replace if (netif_msg_type) by their netif_xxx counterpart

As sugested by Joe Perches, we could replace all if (netif_msg_type(priv)) dev_xxx(priv->devices, ...) by the simplier macro netif_xxx(priv, hw, priv->dev, ...) Signed-off-by: LABBE Corentin --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 58

[PATCH v4 1/5] net: stmmac: replace all pr_xxx by their netdev_xxx counterpart

The stmmac driver use lots of pr_xxx functions to print information. This is bad since we cannot know which device logs the information. (moreover if two stmmac device are present) Furthermore, it seems that it assumes wrongly that all logs will always be subsequent by using a dev_xxx then some

[PATCH v4 2/5] net: stmmac: replace hardcoded function name by __func__

Some printing have the function name hardcoded. It is better to use __func__ instead. Signed-off-by: LABBE Corentin --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v4 3/5] net: stmmac: remove some __func__ printing

Now that stmmac use netdev_xxx, some __func__ are not necessary since their use was to clearly identify which driver was logging. Moreover, as pointed by Joe Perches, using __func__ in xxx_dbg functions is relatively low value and dynamic debug can add it. This patch remove __func__ where such

[PATCH v4] stmmac: improve logging

Hello This patch series try to improve logging of the stmmac driver. Changes since v3 - Fix a missing comma for letting patch to be used atomaticly. Changes since v2 - Rollback to dev_ for some early init printing - rebased on 4.4-rc1 Changes since v1 - Use netdev_xxx instead of dev_xxx - Use

Re: [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

On Wed 04-11-15 14:50:37, Johannes Weiner wrote: [...] > Because it goes without saying that once the cgroupv2 interface is > released, and people use it in production, there is no way we can then > *add* dentry cache, inode cache, and others to memory.current. That > would be an unacceptable

[PATCH] decnet: remove macro-local declarations

Move the variable declarations from the for_nexthops macro to the surrounding context, so that it is clear where these variables are declared. This also makes it possible to remove the endfor_nexthops macro. This change adds new arguments to the macro for_nexthops. They are ordered such that a

Re: AF_PACKET mmap() v4...

On Thu, 2015-11-05 at 10:39 +0100, Daniel Borkmann wrote: > On 11/05/2015 10:07 AM, Arnd Bergmann wrote: > > On Thursday 05 November 2015 00:04:14 David Miller wrote: > >> As part of fixing y2038 problems, Arnd is going to have to make a new > >> version fo the AF_PACKET mmap() tpacker descriptors

Re: [PATCH v3 1/5] stmmac: replace all pr_xxx by their netdev_xxx counterpart

On Thu, Nov 05, 2015 at 06:58:17PM +0800, kbuild test robot wrote: > Hi LABBE, > > [auto build test ERROR on: net/master] > [also build test ERROR on: v4.3 next-20151105] > > url: > https://github.com/0day-ci/linux/commits/LABBE-Corentin/stmmac-replace-all-pr_xx

[PATCH v4 4/5] net: stmmac: Fix simple style problem

This patch fix the following warnings: - braces {} should be used on all arms of this statement - Prefer seq_puts to seq_printf - No space is necessary after a cast - Missing a blank line after declarations - Please don't use multiple blank lines - Comparison to NULL could be written - networking

[PATCH] [BACKPORT] [3.14.56] bnx2x: Don't notify about scratchpad parities

bnx2x: Don't notify about scratchpad parities This is a (trivial) "backport" of ad6afbe9578d1fa26680faf78c846bd8c00d1d6e to stable kernel 3.14.56. Original commit message: The scratchpad is a shared block between all functions of a given device. Due to HW limitations, we can't properly close

GSO with udp_tunnel_xmit_skb

Hi folks, When sending arbitrary SKBs with udp_tunnel_xmit_skb, the networking stack does not appear to be utilizing UFO on the outgoing UDP packets, which significantly caps the transmission speed. I see about 50% CPU usage in this send path, triggered for every single outgoing packet. Is there

Re: [PATCH v3 1/5] stmmac: replace all pr_xxx by their netdev_xxx counterpart

Hi LABBE, [auto build test ERROR on: net/master] [also build test ERROR on: v4.3 next-20151105] url: https://github.com/0day-ci/linux/commits/LABBE-Corentin/stmmac-replace-all-pr_xxx-by-their-netdev_xxx-counterpart/20151105-163344 config: m68k-allyesconfig (attached as .config) reproduce

[PATCH v2] USB: qmi_wwan: Add quirk for Quectel EC20 Mini PCIe module

This device has same vendor and product IDs as G2K devices, but it has different number of interfaces(4 vs 5) and also different interface layout where EC20 has QMI on interface 4 instead of 0. lsusb output: Bus 002 Device 003: ID 05c6:9215 Qualcomm, Inc. Acer Gobi 2000 Device

Re: NETIF_F_GSO_SOFTWARE vs NETIF_F_GSO

On Wed, Nov 04, 2015 at 12:24:47PM +0100, Jason A. Donenfeld wrote: > > Strangely, the performance does not change at all regardless of > whether or not NETIF_F_GSO is specified. The NETIF_F_GSO flag turns on software GSO which should be on anyway. So that could be why it seems to make no

Re: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

From: David Miller Date: Thu, 05 Nov 2015 10:31:26 -0500 (EST) > I'll see if I can cook something up. How does this look? net: Add eth_platform_get_mac_address() helper. A repeating pattern in drivers has become to use OF node information and, if not

Re: NETIF_F_GSO_SOFTWARE vs NETIF_F_GSO

On Thu, Nov 5, 2015 at 4:56 PM, Eric Dumazet wrote: > It is a performance benefit only if you use the helpers from > net/core/tso.c as some drivers already do. > > Otherwise, calling the skb_gso_segment() from your driver has no gain > compared to the one done from core

Re: [PATCH v2] USB: qmi_wwan: Add quirk for Quectel EC20 Mini PCIe module

From: Petr Štetiar Date: Thu, 5 Nov 2015 12:55:01 +0100 > This device has same vendor and product IDs as G2K devices, but it has > different number of interfaces(4 vs 5) and also different interface > layout where EC20 has QMI on interface 4 instead of 0. > > lsusb output: ...

Re: AF_PACKET mmap() v4...

On Thu, 2015-11-05 at 13:56 +0100, Daniel Borkmann wrote: > On 11/05/2015 12:38 PM, Eric Dumazet wrote: > > If I am not mistaken, af_packet also lacks the ability to properly set > > skb->protocol > > > > I noticed this using trafgen on a bonding device, when I did my SYNFLOOD > > tests for TCP

Re: [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

On Thu 05-11-15 11:16:09, David S. Miller wrote: > From: Michal Hocko > Date: Thu, 5 Nov 2015 15:40:02 +0100 > > > On Wed 04-11-15 14:50:37, Johannes Weiner wrote: > > [...] > >> Because it goes without saying that once the cgroupv2 interface is > >> released, and people use

Re: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

On (11/05/15 11:29), David Miller wrote: > > The intention is to let your patch go in as-is, then try and update > ixgbe/i40e later in net-next or similar. Sounds good, I can take care of ixgbe/i40e after that happens. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: [PATCH] sh_eth: merge sh_eth_free_dma_buffer() into sh_eth_ring_free()

Hello. On 11/05/2015 07:13 PM, David Miller wrote: While the ring allocation is done by a single function, sh_eth_ring_init(), the ring deallocation was split into two functions (almost always called one after the other) for no good reason. Merge sh_eth_free_dma_buffer() into

Re: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

On (11/05/15 11:05), David Miller wrote: > From: David Miller > Date: Thu, 05 Nov 2015 10:31:26 -0500 (EST) > > > I'll see if I can cook something up. > > How does this look? Looks good to me, Do you want me to respin patch v7 with this? Or update ixgbe/i40e to use this

Re: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

From: Sowmini Varadhan Date: Thu, 5 Nov 2015 11:28:31 -0500 > On (11/05/15 11:05), David Miller wrote: >> From: David Miller >> Date: Thu, 05 Nov 2015 10:31:26 -0500 (EST) >> >> > I'll see if I can cook something up. >> >> How does this look?

RE: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

> From: David Miller [mailto:da...@davemloft.net] > Sent: Thursday, November 05, 2015 8:29 AM > > From: Sowmini Varadhan > Date: Thu, 5 Nov 2015 11:28:31 -0500 > > > On (11/05/15 11:05), David Miller wrote: > >> From: David Miller > >> Date:

Re: [PATCH] sh_eth: merge sh_eth_free_dma_buffer() into sh_eth_ring_free()

On 11/05/2015 08:19 PM, Sergei Shtylyov wrote: You guys really make an enormous amount of work and stress for me when you submit net-next patches when I _CLEARLY_ and _EXPLICITLY_ state that the tree is closed right now. Hmm, I hadn't seen your announcement, else I would have refrained

Re: [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

From: Michal Hocko Date: Thu, 5 Nov 2015 15:40:02 +0100 > On Wed 04-11-15 14:50:37, Johannes Weiner wrote: > [...] >> Because it goes without saying that once the cgroupv2 interface is >> released, and people use it in production, there is no way we can then >> *add* dentry

Re: pull request: bluetooth 2015-11-05

From: Johan Hedberg Date: Thu, 5 Nov 2015 08:19:29 +0200 > The following set of Bluetooth patches would be good to get into 4.4-rc1 > if possible: > > - Fix for missing LE CoC parameter validity checks > - Fix for potential deadlock in btusb > - Fix for issuing

Re: NETIF_F_GSO_SOFTWARE vs NETIF_F_GSO

On Thu, 2015-11-05 at 16:00 +0100, Jason A. Donenfeld wrote: > Right -- I saw the expansion in the header file -- it gets the various > TSOs plus UFO. So what this means is that the packet hasn't yet been > split up? So were I to add this option, then my driver would have to > be responsible for

Re: [PATCH] sh_eth: merge sh_eth_free_dma_buffer() into sh_eth_ring_free()

From: Sergei Shtylyov Date: Thu, 5 Nov 2015 15:53:24 +0300 > Hello. > > On 11/5/2015 4:59 AM, David Miller wrote: > >>> While the ring allocation is done by a single function, >>> sh_eth_ring_init(), >>> the ring deallocation was split into two functions

[PATCH 1/1] packet: race condition in packet_bind

There is a race conditions between packet_notifier and packet_bind{_spkt}. It happens if packet_notifier(NETDEV_UNREGISTER) executes between the time packet_bind{_spkt} takes a reference on the new netdevice and the time packet_do_bind sets po->ifindex. In this case the notification can be

Re: [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

From: Michal Hocko Date: Thu, 5 Nov 2015 17:28:03 +0100 > Yes, that part is clear and Johannes made it clear that the kmem tcp > part is disabled by default. Or are you considering also all the slab > usage by the networking code as well? I'm still thinking about the

Re: [PATCH net] net: dsa: mv88e6xxx: isolate unbridged ports

From: Vivien Didelot Date: Wed, 4 Nov 2015 17:23:40 -0500 > The DSA documentation specifies that each port must be capable of > forwarding frames to the CPU port. The last changes on bridging support > for the mv88e6xxx driver broke this requirement for

Re: [PATCH] net: stmmac: fix double-initialization of phy_iface

From: LABBE Corentin Date: Thu, 5 Nov 2015 10:26:46 +0100 > The variable phy_iface is double-initialized to itself. > This patch remove that. > > Reported-by: coverity (CID 1271141) > Signed-off-by: LABBE Corentin Applied. -- To

Re: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

On Thu, Nov 5, 2015 at 6:05 PM, David Miller wrote: > From: David Miller > Date: Thu, 05 Nov 2015 10:31:26 -0500 (EST) > >> I'll see if I can cook something up. > > How does this look? I like it, though couple of style related comments. > >

Re: [PATCH] decnet: remove macro-local declarations

From: Julia Lawall Date: Thu, 5 Nov 2015 11:18:16 +0100 > Move the variable declarations from the for_nexthops macro to the > surrounding context, so that it is clear where these variables are > declared. This also makes it possible to remove the endfor_nexthops macro. >

Re: [PATCH] pptp: use idr for allocation of callids

From: Sasha Levin Date: Thu, 5 Nov 2015 15:07:44 -0500 > The current implementation used a bitfield with a corresponding array to > manage assignment of call ids. Rather than open-coding it, use IDR for > this. > > Signed-off-by: Sasha Levin

Re: [PATCH] sh_eth: merge sh_eth_free_dma_buffer() into sh_eth_ring_free()

On 11/05/2015 09:29 PM, David Miller wrote: Hmm, I hadn't seen your announcement, else I would have refrained from sending. Will look for it now... I really don't know how to better get people's attention than this: http://marc.info/?l=linux-netdev=144652382428132=2 Umm,

Re: [PATCH] sh_eth: merge sh_eth_free_dma_buffer() into sh_eth_ring_free()

On Thu, Nov 05, 2015 at 01:29:15PM -0500, David Miller wrote: > From: Sergei Shtylyov > Date: Thu, 5 Nov 2015 20:19:17 +0300 > > >Hmm, I hadn't seen your announcement, else I would have refrained from > >sending. Will look for it now... > > I

Use-after-free in selinux_ip_postroute_compat

Hello, I've updated from bcee19f424a0d8c26ecf2607b73c690802658b29 (Sep 21) to 8e483ed1342a4ea45b70f0f33ac54eff7a33d918 (Nov 4) and start seeing the following use-after-free reports: BUG: KASan: use after free in selinux_ip_postroute_compat+0x2af/0x2d0 at addr 88003dbdc148 Read of size 8 by

Re: [PATCH net] tcp: fix req->saved_syn race

From: Eric Dumazet Date: Thu, 05 Nov 2015 11:07:13 -0800 > From: Eric Dumazet > > For the reasons explained in commit ce1050089c96 ("tcp/dccp: fix > ireq->pktopts race"), we need to make sure we do not access > req->saved_syn unless we own the

Re: [PATCH net] ipv4: use sk_fullsock() in ipv4_conntrack_defrag()

From: Eric Dumazet Date: Thu, 05 Nov 2015 11:34:06 -0800 > From: Eric Dumazet > > Before converting a 'socket pointer' into inet socket, > use sk_fullsock() to detect timewait or request sockets. > > Fixes: ca6fb0651883 ("tcp: attach SYNACK

Re: [PATCH] decnet: remove macro-local declarations

From: Julia Lawall Date: Thu, 5 Nov 2015 21:08:17 +0100 (CET) > On Thu, 5 Nov 2015, David Miller wrote: > >> From: Julia Lawall >> Date: Thu, 5 Nov 2015 11:18:16 +0100 >> >> > Move the variable declarations from the for_nexthops macro to the >> >

Re: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

On Thu, Nov 5, 2015 at 8:31 PM, David Miller wrote: > From: Andy Shevchenko > Date: Thu, 5 Nov 2015 20:13:21 +0200 > >> What about >> >> if (!addr) >> return -ENODATA; > > I totally disagree. of_get_phy_mode() and other similar attribute >

[PATCH net-next V20 2/3] Check for vlan ethernet types for 8021.q or 802.1ad

This is to simplify using double tagged vlans. This function allows all valid vlan ethertypes to be checked in a single function call. Signed-off-by: Thomas F Herbert --- include/linux/if_vlan.h | 16 1 file changed, 16 insertions(+) diff --git

[PATCH net] ipv4: use sk_fullsock() in ipv4_conntrack_defrag()

From: Eric Dumazet Before converting a 'socket pointer' into inet socket, use sk_fullsock() to detect timewait or request sockets. Fixes: ca6fb0651883 ("tcp: attach SYNACK messages to request sockets instead of listener") Signed-off-by: Eric Dumazet

Re: [PATCH 1/1] packet: race condition in packet_bind

From: frugg...@aristanetworks.com (Francesco Ruggeri) Date: Thu, 05 Nov 2015 08:16:14 -0800 > There is a race conditions between packet_notifier and packet_bind{_spkt}. > > It happens if packet_notifier(NETDEV_UNREGISTER) executes between the > time packet_bind{_spkt} takes a reference on the

[PATCH] pptp: use idr for allocation of callids

The current implementation used a bitfield with a corresponding array to manage assignment of call ids. Rather than open-coding it, use IDR for this. Signed-off-by: Sasha Levin --- drivers/net/ppp/pptp.c | 67 +--- 1 file

Re: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

From: Andy Shevchenko Date: Thu, 5 Nov 2015 20:13:21 +0200 > What about > > if (!addr) > return -ENODATA; I totally disagree. of_get_phy_mode() and other similar attribute probing mechanisms use -ENODEV. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] sh_eth: merge sh_eth_free_dma_buffer() into sh_eth_ring_free()

From: Sergei Shtylyov Date: Thu, 5 Nov 2015 20:19:17 +0300 >Hmm, I hadn't seen your announcement, else I would have refrained from >sending. Will look for it now... I really don't know how to better get people's attention than this:

Re: [patch -next] qlogic: qed: fix error codes in qed_resc_alloc()

From: Dan Carpenter Date: Thu, 5 Nov 2015 11:41:28 +0300 > We accidentally return success instead of -ENOMEM here. > > Fixes: fe56b9e6a8d9 ('qed: Add module with basic common support') > Signed-off-by: Dan Carpenter Applied, thanks Dan. --

[PATCH net] tcp: fix req->saved_syn race

From: Eric Dumazet For the reasons explained in commit ce1050089c96 ("tcp/dccp: fix ireq->pktopts race"), we need to make sure we do not access req->saved_syn unless we own the request sock. This fixes races for listeners using TCP_SAVE_SYN option. Fixes: e994b2f0fb92

Re: Use-after-free in ipv4_conntrack_defrag

+netdev, lkml Adding public lists as requested. Below is a use-after-free report in ipv4_conntrack_defrag and a fix from Eric. On Thu, Nov 5, 2015 at 7:57 PM, Eric Dumazet wrote: > On Thu, Nov 5, 2015 at 10:33 AM, Dmitry Vyukov wrote: >> Hello, >> >>

Re: [PATCH] decnet: remove macro-local declarations

On Thu, 5 Nov 2015, David Miller wrote: > From: Julia Lawall > Date: Thu, 5 Nov 2015 11:18:16 +0100 > > > Move the variable declarations from the for_nexthops macro to the > > surrounding context, so that it is clear where these variables are > > declared. This also

[PATCH] iproute2: Ignore EADDRNOTAVAIL errors during address flush operation

I found recently that, if I disabled address promotion in the kernel, that ip addr flush dev would fail with an EADDRNOTAVAIL errno (though the flush operation would in fact flush all addresses from an interface properly) Whats happening is that, if I add a primary and multiple secondary

[PATCH net-dev V20 1/3] openvswitch: 802.1ad uapi changes.

openvswitch: Add support for 8021.AD Change the description of the VLAN tpid field. Signed-off-by: Thomas F Herbert --- include/uapi/linux/openvswitch.h | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git

[PATCH net-next V20 3/3] openvswitch: 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

Add support for 802.1ad including the ability to push and pop double tagged vlans. Add support for 802.1ad to netlink parsing and flow conversion. Uses double nested encap attributes to represent double tagged vlan. Inner TPID encoded along with ctci in nested attributes. vport has vlan mtu

[PATCH net-next V20 0/3] openvswitch: Add support for 802.1ad

V20: Added attribute parsing of inner vlan to consolidated vlan parsing fn. Added vport vlan mtu size changes to vport from vport-netdev.c in V18. All changes are in Pacch 3 of the series. Patches 1 and 2 have already been acked to V18 submission. V19: Rebased to latest net-next 4.3.0-rc6+ commit

Re: Use-after-free in selinux_ip_postroute_compat

On Thu, 2015-11-05 at 20:36 +0100, Dmitry Vyukov wrote: > Hello, > > I've updated from bcee19f424a0d8c26ecf2607b73c690802658b29 (Sep 21) to > 8e483ed1342a4ea45b70f0f33ac54eff7a33d918 (Nov 4) and start seeing the > following use-after-free reports: > Thanks for your report, I will add a followup

Re: [PATCH] decnet: remove macro-local declarations

On Thu, 5 Nov 2015, David Miller wrote: > From: Julia Lawall > Date: Thu, 5 Nov 2015 11:18:16 +0100 > > > Move the variable declarations from the for_nexthops macro to the > > surrounding context, so that it is clear where these variables are > > declared. This also

Re: [PATCH] pptp: use idr for allocation of callids

On 11/05/2015 03:12 PM, David Miller wrote: > From: Sasha Levin > Date: Thu, 5 Nov 2015 15:07:44 -0500 > >> > The current implementation used a bitfield with a corresponding array to >> > manage assignment of call ids. Rather than open-coding it, use IDR for >> > this.

Re: [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

On Thu, Nov 05, 2015 at 03:55:22PM -0500, Johannes Weiner wrote: > On Thu, Nov 05, 2015 at 03:40:02PM +0100, Michal Hocko wrote: > > This would be true if they moved on to the new cgroup API intentionally. > > The reality is more complicated though. AFAIK sysmted is waiting for > > cgroup2 already

Re: AF_PACKET mmap() v4...

On 11/05/2015 05:17 PM, Eric Dumazet wrote: On Thu, 2015-11-05 at 13:56 +0100, Daniel Borkmann wrote: On 11/05/2015 12:38 PM, Eric Dumazet wrote: If I am not mistaken, af_packet also lacks the ability to properly set skb->protocol I noticed this using trafgen on a bonding device, when I did

Re: Regression in bonding driver - devices without set_mac

OK, wow, this list is super high traffic. I'm going to unsubscribe now. Feel free to get in contact with me directly (not via the list) if you like. It'd be lovely if someone wants to fix the regression I reported, especially as it looks pretty simple to achieve. (Just don't silently fail if you

Re: [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

On Thu, Nov 05, 2015 at 05:28:03PM +0100, Michal Hocko wrote: > On Thu 05-11-15 11:16:09, David S. Miller wrote: > > From: Michal Hocko > > Date: Thu, 5 Nov 2015 15:40:02 +0100 > > > > > On Wed 04-11-15 14:50:37, Johannes Weiner wrote: > > > [...] > > >> Because it goes

[PATCH net] tcp: use correct req pointer in tcp_move_syn() calls

From: Eric Dumazet I mistakenly took wrong request sock pointer when calling tcp_move_syn() @req_unhash is either a copy of @req, or a NULL value for FastOpen connexions (as we do not expect to unhash the temporary request sock from ehash table) Fixes: 805c4bc05705 ("tcp:

Re: [PATCH net] net: bcmgenet: Software reset EPHY after power on

From: Florian Fainelli Date: Tue, 03 Nov 2015 15:44:14 -0800 > On 29/10/15 18:11, Florian Fainelli wrote: >> The EPHY on GENET v1->v3 is extremely finicky, and will show occasional >> failures based on the timing and reset sequence, ranging from duplicate >> packets, to

[PATCH net] selinux: fix random read in selinux_ip_postroute_compat()

From: Eric Dumazet In commit e446f9dfe17b ("net: synack packets can be attached to request sockets"), I missed one remaining case of invalid skb->sk->sk_security access. Dmitry Vyukov got a KASan report pointing to it. Add selinux_skb_sk() helper that is responsible to get

Re: [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

On Thu, Nov 05, 2015 at 03:40:02PM +0100, Michal Hocko wrote: > On Wed 04-11-15 14:50:37, Johannes Weiner wrote: > [...] > > Because it goes without saying that once the cgroupv2 interface is > > released, and people use it in production, there is no way we can then > > *add* dentry cache, inode

Re: [PATCH] decnet: remove macro-local declarations

On Thu, 5 Nov 2015, Joe Perches wrote: > On Thu, 2015-11-05 at 20:38 +0100, Julia Lawall wrote: > > On Thu, 5 Nov 2015, David Miller wrote: > > > From: Julia Lawall > > > Date: Thu, 5 Nov 2015 11:18:16 +0100> > > > > Move the variable declarations from the for_nexthops

Re: [PATCH net] tcp: fix req->saved_syn race

On Thu, 2015-11-05 at 11:07 -0800, Eric Dumazet wrote: > From: Eric Dumazet > > For the reasons explained in commit ce1050089c96 ("tcp/dccp: fix > ireq->pktopts race"), we need to make sure we do not access > req->saved_syn unless we own the request sock. > > This fixes

[PATCH net 4/5] bnxt_en: Fix comparison of u16 sw_id against negative value.

Assign the return value from bitmap_find_free_region() to an integer variable and check for negative error codes first, before assigning the bit ID to the unsigned sw_id field. Reported-by: Dan Carpenter Cc: Dan Carpenter Signed-off-by:

[PATCH net 3/5] bnxt_en: map CAG_REG_LEGACY_INT_STATUS_MASK to GRC window #4

From: Jeffrey Huang In order to use offset 0x4014 for reading CAG interrupt status, the actual CAG register must be mapped to GRC bar0 window #4. Otherwise, the driver is reading garbage. This patch corrects this issue. Signed-off-by: Jeffrey Huang

[PATCH net 2/5] bnxt_en: Determine tcp/ipv6 RSS hash type correctly.

The profile ID in the completion record needs to be ANDed with the profile ID mask of 0x1f. This bug was causing the SKB hash type and the gso_type to be wrong in some cases. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 12 +++- 1 file

Re: [PATCH] decnet: remove macro-local declarations

On Thu, 2015-11-05 at 20:38 +0100, Julia Lawall wrote: > On Thu, 5 Nov 2015, David Miller wrote: > > From: Julia Lawall > > Date: Thu, 5 Nov 2015 11:18:16 +0100> > > > Move the variable declarations from the for_nexthops macro to the > > > surrounding context, so that it

[PATCH net 5/5] bnxt_en: More robust SRIOV cleanup sequence.

From: Jeffrey Huang Instead of always calling pci_sriov_disable() in remove_one(), the driver should detect whether VFs are currently assigned to the VMs. If the VFs are active in VMs, then it should not disable SRIOV as it is catastrophic to the VMs. Instead, it just

[PATCH net 0/5] bnxt_en: Bug fixes.

Miscellaneous small bug fixes. Michael Chan (5): bnxt_en: Change sp events definitions to represent bit position. bnxt_en: Determine tcp/ipv6 RSS hash type correctly. bnxt_en: map CAG_REG_LEGACY_INT_STATUS_MASK to GRC window #4 bnxt_en: Fix comparison of u16 sw_id against negative value.

  1   2   >