Re: [PATCH net-next] Driver: Vmxnet3: Fix use of mfTableLen for big endian architectures

From: Shrikrishna Khare Date: Fri, 13 Nov 2015 15:42:10 -0800 > Signed-off-by: Shrikrishna Khare > Reported-by: Masao Uebayashi > Signed-off-by: Bhavesh Davda You guys really have to stop targetting simple,

Re: [PATCH net] rtnetlink: fix frame size warning in rtnl_fill_ifinfo

From: Hannes Frederic Sowa Date: Mon, 16 Nov 2015 12:05:03 +0100 > By declaring the huge stack allocations as static. We can do so > because we hold rtnl. Look across the tree, this is an idiom copied all over the place. If putting a rtnl_link_stats64 object on the

[PATCH 1/2] vlan: Fix untag operations of stacked vlans with REORDER_HEADER off

When we have multiple stacked vlan devices all of which have turned off REORDER_HEADER flag, the untag operation does not locate the ethernet addresses correctly for nested vlans. The reason is that in case of REORDER_HEADER flag being off, the outer vlan headers are put back and the mac_len is

[PATCH 0/2] Fix issues with vlans without REORDER_HEADER

A while ago Phil Sutter brought up an issue with vlans without REORDER_HEADER and bridges. The problem was that if a vlan without REORDER_HEADER was a port in the bridge, the bridge ended up forwarding corrupted packets that still contained the vlan header. The same issue exists for bridge mode

[PATCH 2/2] vlan: Do not put vlan headers back on bridge and macvlan ports

When a vlan is configured with REORDER_HEADER set to 0, the vlan header is put back into the packet and makes it appear that the vlan header is still there even after it's been processed. This posses a problem for bridge and macvlan ports. The packets passed to those device may be forwarded and

Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

David Miller writes: > From: Mans Rullgard > Date: Mon, 16 Nov 2015 18:23:35 + > >> +static int nb8800_alloc_rx(struct net_device *dev, int i, bool napi) > > "i" is passed in as a signed int here, but: > >> +static void nb8800_receive(struct net_device

Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

From: Måns Rullgård Date: Mon, 16 Nov 2015 20:59:18 + > Anything else? Sorry, when I find one problem I give you the feedback for that and move on to the 100s of other patches I have in my queue. Or would you like me to devote all of my time to just your driver instead of

Re: [PATCH] net/core: use netdev name in warning if no parent

From: Bjørn Mork Date: Mon, 16 Nov 2015 19:16:40 +0100 > A recent flaw in the netdev feature setting resulted in warnings > like this one from VLAN interfaces: > > WARNING: CPU: 1 PID: 4975 at net/core/dev.c:2419 > skb_warn_bad_offload+0xbc/0xcb() > : caps=(0x001b5820,

How to do TCP tx checksums

Hello! I'm hacking on (my already hacked) pktgen, trying to get it to send TCP frames. And, having issues getting checksums to work properly. I'm trying this: struct iphdr *iph = ip_hdr(skb); struct net_device *odev = pkt_dev->odev; if (pkt_dev->flags & F_TCP) {

Re: irq_fpu_usable() is false in ndo_start_xmit() for UDP packets

On Tue, Nov 17, 2015 at 12:57 AM, Jason A. Donenfeld wrote: > 2. irq_fpu_usable() is FALSE for UDP! Since in_interrupt() is always > true in ndo_start_xmit, this means that in this case, both > interrupted_user_mode() and interrupted_kernel_fpu_idle() are false! > Investigating

Re: [PATCH] dl2k: Implement suspend

Ondrej Zary : [...] > diff --git a/drivers/net/ethernet/dlink/dl2k.c > b/drivers/net/ethernet/dlink/dl2k.c > index ccca479..23d13c5 100644 > --- a/drivers/net/ethernet/dlink/dl2k.c > +++ b/drivers/net/ethernet/dlink/dl2k.c [..] > @@ -522,6 +515,28 @@ rio_open (struct

[PATCH net] qlcnic: Fix mailbox completion handling during spurious interrupt

o While the driver is in the middle of a MB completion processing and it receives a spurious MB interrupt, it is mistaken as a good MB completion interrupt leading to premature completion of the next MB request. Fix the driver to guard against this by checking the current state of MB processing

Re: Kernel 4.1 hang, apparently in __inet_lookup_established

On Sunday 15 November 2015 16:58:33 Grant Zhang wrote: > > Have you tried the two patches Eric mentioned? One of my 4.1.11 server > just hanged with very similar stack trace and I am wondering whether the > aforementioned patches would help. Sorry, Grant - I'm sticking to 3.14.xx for now. best

Re: [PATCH net] bpf, arm: start flushing icache range from header

On Sat, Nov 14, 2015 at 01:26:53AM +0100, Daniel Borkmann wrote: > During review I noticed that the icache range we're flushing should > start at header already and not at ctx.image. > > Reason is that after 55309dd3d4cd ("net: bpf: arm: address randomize > and write protect JIT code"), we also

[PATCH] cxgb3: Delete unnecessary checks before the function call "kfree_skb"

From: Markus Elfring Date: Mon, 16 Nov 2015 12:46:41 +0100 The kfree_skb() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software.

Re: [PATCH net] bpf, arm: start flushing icache range from header

On Mon, Nov 16, 2015 at 11:40:55AM +, Mark Rutland wrote: > On Sat, Nov 14, 2015 at 01:26:53AM +0100, Daniel Borkmann wrote: > > During review I noticed that the icache range we're flushing should > > start at header already and not at ctx.image. > > > > Reason is that after 55309dd3d4cd

Re: [PATCH V4 2/2] arm64: bpf: make BPF prologue and epilogue align with ARM64 AAPCS

On Mon, Nov 16, 2015 at 2:35 PM, Yang Shi wrote: > Save and restore FP/LR in BPF prog prologue and epilogue, save SP to FP > in prologue in order to get the correct stack backtrace. > > However, ARM64 JIT used FP (x29) as eBPF fp register, FP is subjected to > change during

Re: [PATCH V4 2/2] arm64: bpf: make BPF prologue and epilogue align with ARM64 AAPCS

On 11/16/2015 8:41 PM, Alexei Starovoitov wrote: On Mon, Nov 16, 2015 at 08:37:11PM -0800, Z Lim wrote: On Mon, Nov 16, 2015 at 2:35 PM, Yang Shi wrote: Save and restore FP/LR in BPF prog prologue and epilogue, save SP to FP in prologue in order to get the correct stack

Re: [PATCH V4 2/2] arm64: bpf: make BPF prologue and epilogue align with ARM64 AAPCS

On Mon, Nov 16, 2015 at 08:37:11PM -0800, Z Lim wrote: > On Mon, Nov 16, 2015 at 2:35 PM, Yang Shi wrote: > > Save and restore FP/LR in BPF prog prologue and epilogue, save SP to FP > > in prologue in order to get the correct stack backtrace. ... > > CC: Zi Shen Lim

Re: How to do TCP tx checksums

On Mon, Nov 16, 2015 at 4:20 PM, Ben Greear wrote: > Hello! > > I'm hacking on (my already hacked) pktgen, trying to get it to send TCP > frames. > > And, having issues getting checksums to work properly. > > I'm trying this: > struct iphdr *iph = ip_hdr(skb); >

Re: irq_fpu_usable() is false in ndo_start_xmit() for UDP packets

Hi Hannes, Thanks for your response. On Mon, Nov 16, 2015 at 11:27 PM, Hannes Frederic Sowa wrote: > Use the irqsoff tracer to find the problematic functions which disable > interrupts and try to work around it in case of UDP. This could benefit > the whole stack. I

Re: Routing loops & TTL tracking with tunnel devices

On Mon, Nov 16, 2015 at 11:25 PM, Hannes Frederic Sowa wrote: > Have a look at __dev_queue_xmit and the per_cpu recursion limits > implemented there: > > if (__this_cpu_read(xmit_recursion) > > RECURSION_LIMIT) >

Re: [PATCH net] tcp: ensure proper barriers in lockless contexts

On Sun, Nov 15, 2015 at 6:37 PM, David Miller wrote: > From: Eric Dumazet > Date: Thu, 12 Nov 2015 08:43:18 -0800 > >> From: Eric Dumazet >> >> Some functions access TCP sockets without holding a lock and >> might output non

Re: [PATCH net] tcp: ensure proper barriers in lockless contexts

From: Paul Gortmaker Date: Mon, 16 Nov 2015 20:45:25 -0500 > Just a heads up that this breaks all arm64 builds in linux-next from > Monday; bisect says: > > 00fd38d938db3f1ab1c486549afc450cb7e751b1 is the first bad commit > commit

Re: r8169 regression: UDP packets dropped intermittantly

Hi all Back in March/April 2013 I instigated this thread in connection with what appeared to be a regression in the r8169 driver. To briefly recap, we have external hardware which transfers data at moderate rates (150-300 Mbits/sec) to a Linux system using UDP packets. The transfer stream lasts

Re: Routing loops & TTL tracking with tunnel devices

Hi Eric, On Mon, Nov 16, 2015 at 11:28 PM, Eric Dumazet wrote: > There is very little chance we'll accept a new member in sk_buff, unless > proven needed. I actually have no intention of doing this! I'm wondering if there already is a member in sk_buff that moonlights as

Re: xen-netfront crash when detaching network while some network activity

On Wed, Oct 21, 2015 at 08:57:34PM +0200, Marek Marczykowski-Górecki wrote: > On Wed, May 27, 2015 at 12:03:12AM +0200, Marek Marczykowski-Górecki wrote: > > On Tue, May 26, 2015 at 11:56:00AM +0100, David Vrabel wrote: > > > On 22/05/15 12:49, Marek Marczykowski-Górecki wrote: > > > > Hi all, > >

Re: [PATCH] vhost: relax log address alignment

On 11/16/2015 11:00 PM, Michael S. Tsirkin wrote: > commit 5d9a07b0de512b77bf28d2401e5fe3351f00a240 ("vhost: relax used > address alignment") fixed the alignment for the used virtual address, > but not for the physical address used for logging. > > That's a mistake: alignment should clearly be

Re: How to do TCP tx checksums

On Mon, 2015-11-16 at 21:02 -0800, Tom Herbert wrote: > It's really hard to tell what is happening without seeing the full > patch your using. Maybe you're not setting the TCP correctly or > transport header is not set right in skb. BTW, using trafgen from netsniff-ng would save you Ben lots of

Re: [PATCH net-next RFC V3 0/3] basic busy polling support for vhost_net

On 11/13/2015 05:20 PM, Jason Wang wrote: > > On 11/12/2015 08:02 PM, Felipe Franciosi wrote: >> Hi Jason, >> >> I understand your busy loop timeout is quite conservative at 50us. Did you >> try any other values? > I've also tried 20us. And results shows 50us was better in: > > - very small

Re: Hit regression with TCP_TW REUSE/RECYCLE

Tested the same case with 4.4-RC1, it was fixed in 4.4-RC1. But don't know which commit fixed it. # echo 1024 65535 > /proc/sys/net/ipv4/ip_local_port_range # cat /proc/sys/net/ipv4/ip_local_port_range 102465535 # echo 1 > /proc/sys/net/ipv4/tcp_tw_reuse # cat

Re: [PATCH 1/2 v2] dl2k: Add support for IP1000A-based cards

On Sun, Nov 15, 2015 at 11:36 PM, Ondrej Zary wrote: > Add support for IP1000A chips to dl2k driver. > IP1000A chip looks like a TC9020 with integrated PHY. > > This allows IP1000A chips to work reliably because the ipg driver is > buggy - it loses packets under load

Re: [PATCH net-next 1/2] be2net: remove unused local rsstable array

On Fri, Nov 13, 2015 at 4:06 PM, Ivan Vecera wrote: > > Remove rsstable array and its initialization from be_set_rss_hash_opts(). > The array became unused after "e255787 be2net: Support for configurable > RSS hash key". The initial RSS table is now filled and stored for later

Re: [PATCH net] be2net: check properly status in lancer_cmd_get_file_len()

On Fri, Nov 13, 2015 at 3:22 PM, Ivan Vecera wrote: > The lancer_cmd_get_file_len() calls lancer_cmd_read_object() to get > the current size of registers for ethtool registers dump. The size > is stored in data_read but only when the returned status is 0 otherwise > it is

[PATCH v2 net-next] net: hisilicon: fix binding document of mdio

This patch explains the occasion of "hisilcon,mdio" and "hisilicon,hns-mdio" according to Arnd's comments. and reformat it according to comments from Rob. chang log: v2: 1) reformat the style. 2) make it more clearity. v1: initial version. Signed-off-by: huangdaode

Hardware capabilities and bonding offload

Hello, I am looking to offload bond interfaces to hardware for forwarding. Linux allows for configuring a variety of parameters on bonds or slave interfaces. Not all configurations can be offloaded to hardware. For example, certain hardware cannot support bonds with mode of adaptive load

Re: [PATCH v2 net-next] net: hisilicon: fix binding document of mdio

On Monday 16 November 2015 17:38:24 huangdaode wrote: > This patch explains the occasion of "hisilcon,mdio" and > "hisilicon,hns-mdio" according to Arnd's comments. > and reformat it according to comments from Rob. > > chang log: > > v2: > 1) reformat the style. > 2) make it

[PATCH 2/2] mISDN: One function call less in mISDN_sock_sendmsg() after error detection

From: Markus Elfring Date: Mon, 16 Nov 2015 10:30:29 +0100 The kfree_skb() function was called in one case by the mISDN_sock_sendmsg() function during error handling even if a call of the _l2_alloc_skb() function returned a null pointer. This implementation detail

[PATCH] net: switchdev: fix return code of fdb_dump stub

rtnl_fdb_dump always expects an index to be returned by the ndo_fdb_dump op, but when CONFIG_NET_SWITCHDEV is off, it returns an error. Fix that by returning the given unmodified idx. A similar fix was 0890cf6cb6ab ("switchdev: fix return value of switchdev_port_fdb_dump in case of error") but

Re: [PATCH v2] ip_tunnel: disable preemption when updating per-cpu tstats

On Thu, Nov 12, 2015, at 17:35, Jason A. Donenfeld wrote: > Drivers like vxlan use the recently introduced > udp_tunnel_xmit_skb/udp_tunnel6_xmit_skb APIs. udp_tunnel6_xmit_skb > makes use of ip6tunnel_xmit, and ip6tunnel_xmit, after sending the > packet, updates the struct stats using the usual >

Re: [PATCH net] be2net: check properly status in lancer_cmd_get_file_len()

On 11/16/2015 09:57 AM, Sathya Perla wrote: On Fri, Nov 13, 2015 at 3:22 PM, Ivan Vecera wrote: The lancer_cmd_get_file_len() calls lancer_cmd_read_object() to get the current size of registers for ethtool registers dump. The size is stored in data_read but only when the

[PATCH 0/2] mISDN: Deletion of an unnecessary check

From: Markus Elfring Date: Mon, 16 Nov 2015 10:40:11 +0100 Another update suggestion was taken into account after a patch was applied from static source code analysis. Markus Elfring (2): Delete an unnecessary check before the function call "kfree_skb" One

[PATCH 1/2] mISDN: Delete an unnecessary check before the function call "kfree_skb"

From: Markus Elfring Date: Mon, 16 Nov 2015 10:10:53 +0100 The kfree_skb() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software.

[PATCH] WiMAX-i2400m: Delete an unnecessary check before the function call "kfree_skb"

From: Markus Elfring Date: Mon, 16 Nov 2015 11:17:55 +0100 The kfree_skb() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software.

Re: [PATCH] wireless: change cfg80211 regulatory domain info as debug messages

> So maybe add some wrapper that does a pr_info then > a pr_debug for the second and subsequent uses like: > That seems like a bad idea - one might be tricked into think that one saw the current data, but the actually current data is later hidden. johannes -- To unsubscribe from this list:

[PATCH net] rtnetlink: fix frame size warning in rtnl_fill_ifinfo

Fix the following warning: CC net/core/rtnetlink.o net/core/rtnetlink.c: In function ‘rtnl_fill_ifinfo’: net/core/rtnetlink.c:1308:1: warning: the frame size of 2864 bytes is larger than 2048 bytes [-Wframe-larger-than=] } ^ By declaring the huge stack allocations as static. We can do

Re: [PATCH] net: switchdev: fix return code of fdb_dump stub

Mon, Nov 16, 2015 at 10:52:48AM CET, dra...@endocode.com wrote: >rtnl_fdb_dump always expects an index to be returned by the ndo_fdb_dump op, >but when CONFIG_NET_SWITCHDEV is off, it returns an error. > >Fix that by returning the given unmodified idx. > >A similar fix was 0890cf6cb6ab

[PATCH] ixp4xx_eth: Delete an unnecessary check before the function call "dma_pool_destroy"

From: Markus Elfring Date: Mon, 16 Nov 2015 12:23:23 +0100 The dma_pool_destroy() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software.

<    1   2