RE: next build: 235 warnings 3 failures (next/next-20151117)

2015-11-18 Thread David Laight
From: Will Deacon > Sent: 18 November 2015 12:28 > On Wed, Nov 18, 2015 at 12:11:25PM +, David Laight wrote: > > From: Will Deacon > > > Sent: 18 November 2015 10:14 > > > On Tue, Nov 17, 2015 at 08:17:17PM +0100, Arnd Bergmann wrote: > > > > On Tuesday 17 November 2015 17:12:37 Will Deacon

Re: [PATCH -next] net: tcp: move to timewait when receiving data post active-close

2015-11-18 Thread Eric Dumazet
On Wed, 2015-11-18 at 16:03 +0100, Florian Westphal wrote: > RFC 1122, 4.2.2.13: > [..] if new data is received after CLOSE is called, its TCP > SHOULD send a RST to show that data was lost. > > When a connection is closed actively, it MUST linger in > TIME-WAIT state [..]. > > We reset a

Re: [RFC][PATCH] net: arinc429: Add ARINC-429 stack

2015-11-18 Thread Marek Vasut
On Wednesday, November 18, 2015 at 05:38:02 PM, Aleksander Morgado wrote: > On Tue, Nov 10, 2015 at 5:15 PM, Marek Vasut wrote: > >> >> >>> > About the parity -- can we add some flag into the datagram to > >> >> >>> > indicate we want hardware to calculate the parity for that > >>

Re: [PATCH -next] net: tcp: move to timewait when receiving data post active-close

2015-11-18 Thread Hannes Frederic Sowa
On Wed, Nov 18, 2015, at 18:28, Eric Dumazet wrote: > On Wed, 2015-11-18 at 16:54 +0100, Hannes Frederic Sowa wrote: > > > Still, the RST packet can be dropped along the way. So the teardown of > > the socket on the other side might not happen. > > This is why it is better to send RST for every

Re: [PATCH] ethernet/atheros/alx: add Killer E2400 device ID

2015-11-18 Thread Sergei Shtylyov
On 11/18/2015 05:52 PM, Jason Gerard DeRose wrote: From: Ben Pope This patch adds the PCI device ID (0xe0a1) and alx_pci_tbl entry for the Killer E2400 Ethernet controller, modeled after the Killer E2200 controller support (0xe091) already present in the alx driver. This

Re: [PATCH -next] net: tcp: move to timewait when receiving data post active-close

2015-11-18 Thread Florian Westphal
Eric Dumazet wrote: > On Wed, 2015-11-18 at 16:54 +0100, Hannes Frederic Sowa wrote: > > > Still, the RST packet can be dropped along the way. So the teardown of > > the socket on the other side might not happen. > > This is why it is better to send RST for every

Re: [PATCH net] net/ip6_tunnel: fix dst leak

2015-11-18 Thread Martin KaFai Lau
On Wed, Nov 18, 2015 at 04:40:19PM +0100, Paolo Abeni wrote: > the commit cdf3464e6c6b ("ipv6: Fix dst_entry refcnt bugs in ip6_tunnel") > introduced percpu storage for ip6_tunnel dst cache, but while clearing > such cache it used raw_cpu_ptr to walk the per cpu entries, so cached > dst on non

[PATCH v7] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-11-18 Thread Mans Rullgard
This adds a driver for the Aurora VLSI NB8800 Ethernet controller. It is an almost complete rewrite of a driver originally found in a Sigma Designs 2.6.22 tree. Signed-off-by: Mans Rullgard --- Changes: - fix int / unsigned int mismatch - spell out "unsigned int" ---

Re: [PATCH -next] net: tcp: move to timewait when receiving data post active-close

2015-11-18 Thread Eric Dumazet
On Wed, 2015-11-18 at 16:54 +0100, Hannes Frederic Sowa wrote: > Still, the RST packet can be dropped along the way. So the teardown of > the socket on the other side might not happen. This is why it is better to send RST for every incoming in-excess packet Try following packetdrill test,

Re: [PATCH -next] net: tcp: move to timewait when receiving data post active-close

2015-11-18 Thread Eric Dumazet
On Wed, 2015-11-18 at 16:36 +0100, Florian Westphal wrote: > Yes, but we kill the socket. > > I should have added > > 0.400 `ss -nito state time-wait` > > as last line... > > Before patch: no output > after patch: tw socket shown. > > The on-wire behavior doesn't change unless further

RE: next build: 235 warnings 3 failures (next/next-20151117)

2015-11-18 Thread David Laight
From: Will Deacon [mailto:will.dea...@arm.com] > Sent: 18 November 2015 15:37 > On Wed, Nov 18, 2015 at 03:21:19PM +, David Laight wrote: > > From: Will Deacon > > > Sent: 18 November 2015 12:28 > > > On Wed, Nov 18, 2015 at 12:11:25PM +, David Laight wrote: > > > > From: Will Deacon > > >

Re: [PATCH -next] net: tcp: move to timewait when receiving data post active-close

2015-11-18 Thread Florian Westphal
Eric Dumazet wrote: > On Wed, 2015-11-18 at 16:03 +0100, Florian Westphal wrote: > > RFC 1122, 4.2.2.13: > > [..] if new data is received after CLOSE is called, its TCP > > SHOULD send a RST to show that data was lost. > > > > When a connection is closed actively, it

Re: next build: 235 warnings 3 failures (next/next-20151117)

2015-11-18 Thread Will Deacon
On Wed, Nov 18, 2015 at 03:21:19PM +, David Laight wrote: > From: Will Deacon > > Sent: 18 November 2015 12:28 > > On Wed, Nov 18, 2015 at 12:11:25PM +, David Laight wrote: > > > From: Will Deacon > > > > > > > >

Re: Add a SOCK_DESTROY operation to close sockets from userspace

2015-11-18 Thread Eric Dumazet
On Wed, 2015-11-18 at 15:56 +0100, Hannes Frederic Sowa wrote: > On Wed, Nov 18, 2015, at 15:45, Lorenzo Colitti wrote: > > On Wed, Nov 18, 2015 at 10:31 PM, Hannes Frederic Sowa > > wrote: > > > I was not saying using tcp_close literally, sorry for not making that > >

Re: Add a SOCK_DESTROY operation to close sockets from userspace

2015-11-18 Thread Hannes Frederic Sowa
On Wed, Nov 18, 2015, at 16:16, Eric Dumazet wrote: > On Wed, 2015-11-18 at 15:56 +0100, Hannes Frederic Sowa wrote: > > On Wed, Nov 18, 2015, at 15:45, Lorenzo Colitti wrote: > > > On Wed, Nov 18, 2015 at 10:31 PM, Hannes Frederic Sowa > > > wrote: > > > > I was not

Re: [PATCH -next] net: tcp: move to timewait when receiving data post active-close

2015-11-18 Thread Hannes Frederic Sowa
On Wed, Nov 18, 2015, at 16:46, Eric Dumazet wrote: > On Wed, 2015-11-18 at 16:36 +0100, Florian Westphal wrote: > > > Yes, but we kill the socket. > > > > I should have added > > > > 0.400 `ss -nito state time-wait` > > > > as last line... > > > > Before patch: no output > > after patch: tw

Re: [PATCH 13/14] mm: memcontrol: account socket memory in unified hierarchy memory controller

2015-11-18 Thread Michal Hocko
On Mon 16-11-15 13:18:10, Johannes Weiner wrote: > On Mon, Nov 16, 2015 at 04:59:25PM +0100, Michal Hocko wrote: > > On Thu 12-11-15 18:41:32, Johannes Weiner wrote: > > > Socket memory can be a significant share of overall memory consumed by > > > common workloads. In order to provide reasonable

Re: [PATCH v2 21/27] realtek: create separate Kconfig file

2015-11-18 Thread Larry Finger
On 11/18/2015 08:46 AM, Kalle Valo wrote: Add new a Kconfig file and a vendor config for realtek. Also update MAINTAINERS which we missed to do when earlier moving rtlwifi. Signed-off-by: Kalle Valo --- Acked-by: Larry Finger Thanks, Larry

[PATCH net] net/ip6_tunnel: fix dst leak

2015-11-18 Thread Paolo Abeni
the commit cdf3464e6c6b ("ipv6: Fix dst_entry refcnt bugs in ip6_tunnel") introduced percpu storage for ip6_tunnel dst cache, but while clearing such cache it used raw_cpu_ptr to walk the per cpu entries, so cached dst on non current cpu are not actually reset. This patch replaces raw_cpu_ptr

Re: [PATCH 14/14] mm: memcontrol: hook up vmpressure to socket pressure

2015-11-18 Thread Vladimir Davydov
On Tue, Nov 17, 2015 at 05:22:17PM -0500, Johannes Weiner wrote: > On Tue, Nov 17, 2015 at 11:18:50PM +0300, Vladimir Davydov wrote: > > AFAIK vmpressure was designed to allow userspace to tune hard limits of > > cgroups in accordance with their demands, in which case the way how > > vmpressure

Re: [RFC][PATCH] net: arinc429: Add ARINC-429 stack

2015-11-18 Thread Aleksander Morgado
On Tue, Nov 10, 2015 at 5:15 PM, Marek Vasut wrote: >> >> >>> > About the parity -- can we add some flag into the datagram to >> >> >>> > indicate we want hardware to calculate the parity for that >> >> >>> > particular datagram for us? And we'd also need to indicate what >> >> >>>

Re: Add a SOCK_DESTROY operation to close sockets from userspace

2015-11-18 Thread Hannes Frederic Sowa
On Wed, Nov 18, 2015, at 16:32, Hannes Frederic Sowa wrote: > On Wed, Nov 18, 2015, at 16:16, Eric Dumazet wrote: > > On Wed, 2015-11-18 at 15:56 +0100, Hannes Frederic Sowa wrote: > > > On Wed, Nov 18, 2015, at 15:45, Lorenzo Colitti wrote: > > > > On Wed, Nov 18, 2015 at 10:31 PM, Hannes

Your Package

2015-11-18 Thread FedExDelivery
-- We have a parcel right here in our office to be delivered to you... -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[iproute PATCH 2/2] lnstat: fix header displaying mechanism

2015-11-18 Thread Phil Sutter
The algorithm depends on the loop counter ('i') to increment by one in each iteration. Though if running endlessly (count==0), the counter was not incremented at all. Also change formatting of the header printing conditional a bit so it's hopefully easier to read. Fixes: e7e2913 ("lnstat: run

[iproute PATCH 0/2] lnstat: review --subject option

2015-11-18 Thread Phil Sutter
Add missing description in help output, fix algorithm. Phil Sutter (2): lnstat: describe -s option in help output lnstat: fix header displaying mechanism misc/lnstat.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) -- 2.5.0 -- To unsubscribe from this list: send the

[iproute PATCH 1/2] lnstat: describe -s option in help output

2015-11-18 Thread Phil Sutter
Signed-off-by: Phil Sutter --- misc/lnstat.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/misc/lnstat.c b/misc/lnstat.c index 1e547d0..529bc33 100644 --- a/misc/lnstat.c +++ b/misc/lnstat.c @@ -73,7 +73,10 @@ static int usage(char *name, int exit_code)

Re: [PATCH] unix: avoid use-after-free in ep_remove_wait_queue (w/ Fixes:)

2015-11-18 Thread Rainer Weikusat
David Miller writes: > From: Rainer Weikusat > Date: Mon, 16 Nov 2015 22:28:40 + > >> An AF_UNIX datagram socket being the client in an n:1 [...] > So because of a corner case of epoll handling and sender socket release, > every

Re: [PATCH V2 net-next 1/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem

2015-11-18 Thread David Miller
From: Salil Date: Wed, 18 Nov 2015 02:52:23 +0800 > @@ -387,19 +409,23 @@ static void hns_rcb_ring_get_cfg(struct hnae_queue *q, > int ring_type) > struct rcb_common_cb *rcb_common; > struct ring_pair_cb *ring_pair_cb; > u32 buf_size; > - u16

Re: [PATCH net-next] net: encx24j600: quiet logging noise on open

2015-11-18 Thread David Miller
From: j...@ringle.org Date: Tue, 17 Nov 2015 16:42:31 -0500 > From: Jon Ringle > > When encx24j600 is open and closed many times due to userspace polling the > interface, the log gets noise with this log message. Change logging level > to debug > > Signed-off-by: Jon

Re: [PATCH] ethernet/atheros/alx: add Killer E2400 device ID

2015-11-18 Thread Jason Gerard DeRose
On 11/18/2015 10:47 AM, Sergei Shtylyov wrote: On 11/18/2015 05:52 PM, Jason Gerard DeRose wrote: From: Ben Pope This patch adds the PCI device ID (0xe0a1) and alx_pci_tbl entry for the Killer E2400 Ethernet controller, modeled after the Killer E2200 controller support

Re: [PATCH -next] net: tcp: move to timewait when receiving data post active-close

2015-11-18 Thread Eric Dumazet
On Wed, 2015-11-18 at 18:35 +0100, Hannes Frederic Sowa wrote: > On Wed, Nov 18, 2015, at 18:28, Eric Dumazet wrote: > > On Wed, 2015-11-18 at 16:54 +0100, Hannes Frederic Sowa wrote: > > > > > Still, the RST packet can be dropped along the way. So the teardown of > > > the socket on the other

[PATCH iproute2] Add support for rt_tables.d

2015-11-18 Thread David Ahern
Add support for reading table id/name mappings from rt_tables.d directory. Signed-off-by: David Ahern --- lib/rt_names.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/lib/rt_names.c b/lib/rt_names.c index e87c65dad39e..d835ff9c7ee0 100644 ---

Re: lockdep problem? netlink_dump & rtnl_lock

2015-11-18 Thread Cong Wang
On Wed, Nov 18, 2015 at 2:11 AM, Arkadiusz Miskiewicz wrote: > > Hi. > > I'm running 4.3.0 kernel (+ few backported mm patches). Machine is doing many > rsnapshots > in parallel (so heavily loaded). > > I'm seeing this from time to time (below). What would be the reason

Re: [PATCH] net ipv4: use preferred log methods

2015-11-18 Thread David Miller
From: Bastian Stender Date: Fri, 13 Nov 2015 11:40:34 +0100 > Replace printk calls with preferred unconditional log method calls to keep > kernel messages clean. > > Added newline to "too small MTU" message. > > Signed-off-by: Bastian Stender Applied

Re: [PATCH 14/14] mm: memcontrol: hook up vmpressure to socket pressure

2015-11-18 Thread Johannes Weiner
On Wed, Nov 18, 2015 at 07:02:54PM +0300, Vladimir Davydov wrote: > On Tue, Nov 17, 2015 at 05:22:17PM -0500, Johannes Weiner wrote: > > On Tue, Nov 17, 2015 at 11:18:50PM +0300, Vladimir Davydov wrote: > > > And with this patch it will work this way, but only if sum limits < > > > total ram,

Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory

2015-11-18 Thread Hauke Mehrtens
On 11/18/2015 03:45 PM, Kalle Valo wrote: > Part of reorganising wireless drivers directory and Kconfig. Note that I had > to > edit Makefiles from subdirectories to use the new location. > > Signed-off-by: Kalle Valo > --- I would prefer to remove the brcm80211 directory

Re: [PATCH v3 net-next] net: hisilicon: fix binding document of mdio

2015-11-18 Thread David Miller
From: huangdaode Date: Wed, 18 Nov 2015 10:08:00 +0800 > This patch explains the occasion of "hisilcon,mdio" and > "hisilicon,hns-mdio" according to Arnd's comments. > and reformat it according to comments from Rob. > > Signed-off-by: huangdaode

Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory

2015-11-18 Thread Florian Fainelli
On 18/11/15 11:19, Hauke Mehrtens wrote: > On 11/18/2015 03:45 PM, Kalle Valo wrote: >> Part of reorganising wireless drivers directory and Kconfig. Note that I had >> to >> edit Makefiles from subdirectories to use the new location. >> >> Signed-off-by: Kalle Valo >> --- >

Re: [PATCH] hdlc: fix null-deref on allocation failure

2015-11-18 Thread David Miller
From: Stephen Hemminger Date: Tue, 17 Nov 2015 14:26:06 -0800 > If alloc_netdev() failed and return NULL, then the next instruction > would dereference it. Found by Coverity. > > Compile tested only. Not sure if anyone still uses this driver > (or the whole WAN subsystem).

Re: [PATCH] ethernet/atheros/alx: add Killer E2400 device ID

2015-11-18 Thread David Miller
From: Jason Gerard DeRose Date: Tue, 17 Nov 2015 18:21:07 -0700 > From: Ben Pope > > This patch adds the PCI device ID (0xe0a1) and alx_pci_tbl entry for the > Killer E2400 Ethernet controller, modeled after the Killer E2200 > controller support

Re: [PATCH] fm10k: fix memory leak

2015-11-18 Thread David Miller
From: Stephen Hemminger Date: Tue, 17 Nov 2015 14:24:27 -0800 > This was detected by Coverity. > The function skb_cow_head leaves skb alone on failure, so caller needs > to free. > > Signed-off-by: Stephen Hemminger Applied. -- To unsubscribe

Re: udp: remove duplicate include

2015-11-18 Thread David Miller
From: Stephen Hemminger Date: Tue, 17 Nov 2015 13:46:48 -0800 > Signed-off-by: Stephen Hemminger Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] net: macb: Add support for sgmii phy interface

2015-11-18 Thread David Miller
From: Punnaiah Choudary Kalluri Date: Wed, 18 Nov 2015 09:03:50 +0530 > This patch adds support for the sgmii phy interface. > > Signed-off-by: Punnaiah Choudary Kalluri Applied to net-next, thanks. -- To unsubscribe from this list:

[PATCH net,stable] net: qmi_wwan: add XS Stick W100-2 from 4G Systems

2015-11-18 Thread Bjørn Mork
Thomas reports " 4gsystems sells two total different LTE-surfsticks under the same name. .. The newer version of XS Stick W100 is from "omega" .. Under windows the driver switches to the same ID, and uses MI03\6 for network and MI01\6 for modem. .. echo "1c9e 9b01" >

Re: [PATCH] net: dns_resolver: convert time_t to time64_t

2015-11-18 Thread David Miller
From: Aya Mahfouz Date: Wed, 18 Nov 2015 08:36:44 +0200 > Changes the definition of the pointer _expiry from time_t to > time64_t. This is to handle the Y2038 problem where time_t > will overflow in the year 2038. The change is safe because > the kernel subsystems

[PATCH net] tcp: md5: fix lockdep annotation

2015-11-18 Thread Eric Dumazet
From: Eric Dumazet When a passive TCP is created, we eventually call tcp_md5_do_add() with sk pointing to the child. It is not owner by the user yet (we will add this socket into listener accept queue a bit later anyway) But we do own the spinlock, so amend the lockdep

Re: [PATCH net-next] be2net: remove local variable 'status'

2015-11-18 Thread David Miller
From: Ivan Vecera Date: Wed, 18 Nov 2015 14:06:34 +0100 > The lancer_cmd_get_file_len() uses lancer_cmd_read_object() to get > the current size of registers for ethtool registers dump. Returned status > value is stored but not checked. The check itself is not necessary as >

Re: [PATCH] arm64: bpf: fix buffer pointer

2015-11-18 Thread David Miller
From: Zi Shen Lim Date: Wed, 18 Nov 2015 00:56:02 -0800 > During code review, I noticed we were passing a bad buffer pointer > to bpf_load_pointer helper function called by jitted code. > > Point to the buffer allocated by JIT, so we don't silently corrupt > other parts of

Re: Add a SOCK_DESTROY operation to close sockets from userspace

2015-11-18 Thread David Miller
From: Lorenzo Colitti Date: Wed, 18 Nov 2015 19:47:21 +0900 > On Wed, Nov 18, 2015 at 7:19 PM, Hannes Frederic Sowa > wrote: >> I bet there will soon be a timewaitd which handles the not configurable >> (David has rejected all those patches so

Re: Add a SOCK_DESTROY operation to close sockets from userspace

2015-11-18 Thread Hannes Frederic Sowa
On Wed, Nov 18, 2015, at 21:35, David Miller wrote: > From: Lorenzo Colitti > Date: Wed, 18 Nov 2015 19:47:21 +0900 > > > On Wed, Nov 18, 2015 at 7:19 PM, Hannes Frederic Sowa > > wrote: > >> I bet there will soon be a timewaitd which handles the

Re: [PATCH] fm10k: fix memory leak

2015-11-18 Thread Jeff Kirsher
On Wed, 2015-11-18 at 15:06 -0500, David Miller wrote: > From: Stephen Hemminger > Date: Tue, 17 Nov 2015 14:24:27 -0800 > > > This was detected by Coverity. > > The function skb_cow_head leaves skb alone on failure, so caller > > needs > > to free. > > > > Signed-off-by:

lockdep problem? netlink_dump & rtnl_lock

2015-11-18 Thread Arkadiusz Miskiewicz
Hi. I'm running 4.3.0 kernel (+ few backported mm patches). Machine is doing many rsnapshots in parallel (so heavily loaded). I'm seeing this from time to time (below). What would be the reason for so long hangs? [ 2278.385668] INFO: task snmpd:1775 blocked for more than 120 seconds. [

Re: Add a SOCK_DESTROY operation to close sockets from userspace

2015-11-18 Thread Hannes Frederic Sowa
Hello, On Wed, Nov 18, 2015, at 02:43, Lorenzo Colitti wrote: > This patch series adds the ability for a privileged process to > destroy sockets belonging to other userspace processes via the > sock_diag interface, and implements that for TCP sockets. > > This functionality is needed on laptops

[PATCH 2/3] net/ceph: do not define list_entry_next

2015-11-18 Thread Sergey Senozhatsky
Cosmetic. Do not define list_entry_next() and use list_next_entry() from list.h. Signed-off-by: Sergey Senozhatsky --- net/ceph/messenger.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c

Re: Add a SOCK_DESTROY operation to close sockets from userspace

2015-11-18 Thread Lorenzo Colitti
On Wed, Nov 18, 2015 at 7:19 PM, Hannes Frederic Sowa wrote: > I bet there will soon be a timewaitd which handles the not configurable > (David has rejected all those patches so far) timeout of TIME_WAIT > sockets. And I bet it will be used. :/ No, SOCK_DESTROY has no

[iproute PATCH 1/2] bridge.8: document fdb replace command

2015-11-18 Thread Phil Sutter
Despite commit 45a82e5 ("iproute vxlan add support for fdb replace command"), the 'fdb replace' command was not mentioned in bridge.8. Signed-off-by: Phil Sutter --- man/man8/bridge.8 | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/man/man8/bridge.8

RE: next build: 235 warnings 3 failures (next/next-20151117)

2015-11-18 Thread David Laight
From: Will Deacon > Sent: 18 November 2015 10:14 > On Tue, Nov 17, 2015 at 08:17:17PM +0100, Arnd Bergmann wrote: > > On Tuesday 17 November 2015 17:12:37 Will Deacon wrote: > > > On Tue, Nov 17, 2015 at 06:03:40PM +0100, Arnd Bergmann wrote: > > > > On Tuesday 17 November 2015 16:44:53 Will

Re: net-scm: Macro for special pattern?

2015-11-18 Thread Eric Dumazet
On Wed, 2015-11-18 at 08:45 +0100, SF Markus Elfring wrote: > > You mean this likely() annotation of yours? > > How do you think about to express the software design pattern > which is applied at the mentioned source code place by a dedicated > preprocessor macro? likely()/unlikely() are not

[PATCH net-next] be2net: remove local variable 'status'

2015-11-18 Thread Ivan Vecera
The lancer_cmd_get_file_len() uses lancer_cmd_read_object() to get the current size of registers for ethtool registers dump. Returned status value is stored but not checked. The check itself is not necessary as the data_read output variable is initialized to 0 and status variable can be removed.

RE: Add a SOCK_DESTROY operation to close sockets from userspace

2015-11-18 Thread David Laight
From: Maciej Zenczykowski > Sent: 18 November 2015 03:57 > I don't know what the right fix is... > > However, speaking as an end user with laptops on wifi and/or home > gateways on dialup connections where the IP address occasionally (or > constantly) changes, I find it very frustrating that by

Re: [PATCH net] net: fix feature changes on devices without ndo_set_features

2015-11-18 Thread Sergei Shtylyov
Hello. On 11/18/2015 2:10 AM, Nikolay Aleksandrov wrote: From: Nikolay Aleksandrov When __netdev_update_features() was updated to ensure some features are disabled on new lower devices, an error was introduced for devices which don't have the ndo_set_features()

Re: Add a SOCK_DESTROY operation to close sockets from userspace

2015-11-18 Thread Hannes Frederic Sowa
On Wed, Nov 18, 2015, at 11:47, Lorenzo Colitti wrote: > On Wed, Nov 18, 2015 at 7:19 PM, Hannes Frederic Sowa > wrote: > > I bet there will soon be a timewaitd which handles the not configurable > > (David has rejected all those patches so far) timeout of TIME_WAIT >

[iproute PATCH 2/2] bridge.8: minor formatting cleanup

2015-11-18 Thread Phil Sutter
- Replace commas at end of subsection with dots. - Remove whitespace at EOL. - Replace double whitespace by single one. Signed-off-by: Phil Sutter --- man/man8/bridge.8 | 50 +- 1 file changed, 25 insertions(+), 25 deletions(-) diff

[iproute PATCH 0/2] minor update to bridge.8

2015-11-18 Thread Phil Sutter
This was originally some leftover in RHEL patches, as well. Though the question whether 'fdb replace' should be documented or not was not exactly trivial: - In August 2012, 'fdb change' and 'fdb replace' commands were removed (commit 57b9785). - In September 2012, bridge.8 was adjusted

Re: Add a SOCK_DESTROY operation to close sockets from userspace

2015-11-18 Thread Eric Dumazet
On Wed, 2015-11-18 at 12:19 +0100, Hannes Frederic Sowa wrote: > On Wed, Nov 18, 2015, at 11:47, Lorenzo Colitti wrote: > > On Wed, Nov 18, 2015 at 7:19 PM, Hannes Frederic Sowa > > wrote: > > > I bet there will soon be a timewaitd which handles the not configurable >

Re: next build: 235 warnings 3 failures (next/next-20151117)

2015-11-18 Thread Will Deacon
On Wed, Nov 18, 2015 at 12:11:25PM +, David Laight wrote: > From: Will Deacon > > Sent: 18 November 2015 10:14 > > On Tue, Nov 17, 2015 at 08:17:17PM +0100, Arnd Bergmann wrote: > > > On Tuesday 17 November 2015 17:12:37 Will Deacon wrote: > > > > On Tue, Nov 17, 2015 at 06:03:40PM +0100, Arnd

Re: Add a SOCK_DESTROY operation to close sockets from userspace

2015-11-18 Thread Lorenzo Colitti
On Wed, Nov 18, 2015 at 8:19 PM, Hannes Frederic Sowa wrote: > I was wondering why you didn't use tcp_close function, because still we > could have the address and we would like to do a proper shutdown of the > connection. While this patchset wants to tear down sockets

Re: [PATCH 2/3] net/ceph: do not define list_entry_next

2015-11-18 Thread Ilya Dryomov
On Wed, Nov 18, 2015 at 1:13 PM, Sergey Senozhatsky wrote: > Cosmetic. > > Do not define list_entry_next() and use list_next_entry() > from list.h. > > Signed-off-by: Sergey Senozhatsky > --- > net/ceph/messenger.c | 8 +++- > 1

Re: [PATCH 3/3] dl2k: Implement suspend

2015-11-18 Thread Ondrej Zary
On Tuesday 17 November 2015, Francois Romieu wrote: > Ondrej Zary : > [...] > > > diff --git a/drivers/net/ethernet/dlink/dl2k.c > > b/drivers/net/ethernet/dlink/dl2k.c index 9e9baa0..b53dfa7 100644 > > --- a/drivers/net/ethernet/dlink/dl2k.c > > +++

Re: [PATCH 1/2] can: m_can: Increase delay to ensure written INIT accepted

2015-11-18 Thread Marc Kleine-Budde
On 11/18/2015 11:04 AM, Wenyou Yang wrote: > Increase the delay time until the value written to INIT can be > read back to ensure that the previous value written to INIT has > been accepted. > > Signed-off-by: Wenyou Yang The patch looks ok, can you please add to your

RE: next build: 235 warnings 3 failures (next/next-20151117)

2015-11-18 Thread David Laight
From: Arnd Bergmann > Sent: 17 November 2015 19:17 > On Tuesday 17 November 2015 17:12:37 Will Deacon wrote: > > On Tue, Nov 17, 2015 at 06:03:40PM +0100, Arnd Bergmann wrote: > > > On Tuesday 17 November 2015 16:44:53 Will Deacon wrote: > > > > > 8< > > > > > Subject: ARM64: make

[PATCH] arm64: bpf: fix buffer pointer

2015-11-18 Thread Zi Shen Lim
During code review, I noticed we were passing a bad buffer pointer to bpf_load_pointer helper function called by jitted code. Point to the buffer allocated by JIT, so we don't silently corrupt other parts of the stack. Signed-off-by: Zi Shen Lim ---

Re: [PATCH v3 net-next] net: hisilicon: fix binding document of mdio

2015-11-18 Thread Arnd Bergmann
On Wednesday 18 November 2015 10:08:00 huangdaode wrote: > This patch explains the occasion of "hisilcon,mdio" and > "hisilicon,hns-mdio" according to Arnd's comments. > and reformat it according to comments from Rob. > > Signed-off-by: huangdaode >

Re: next build: 235 warnings 3 failures (next/next-20151117)

2015-11-18 Thread Will Deacon
On Tue, Nov 17, 2015 at 08:17:17PM +0100, Arnd Bergmann wrote: > On Tuesday 17 November 2015 17:12:37 Will Deacon wrote: > > On Tue, Nov 17, 2015 at 06:03:40PM +0100, Arnd Bergmann wrote: > > > On Tuesday 17 November 2015 16:44:53 Will Deacon wrote: > > > > > 8< > > > > > Subject: ARM64: make

Re: [PATCH 2/2] can: m_can: Add CAN clock generated by UPLLCK support

2015-11-18 Thread Marc Kleine-Budde
On 11/18/2015 11:04 AM, Wenyou Yang wrote: > As said SAMA5D2 datasheet, it is recommended to use the CAN clock > at frequencies of 20, 40 or 80 MHz. To achieve these frequencies, > PMC GCK3 must select the UPLLCK(480 MHz) as source clock and > divide by 24, 12 or 6. In this patch the CAN clock at

[PATCH 0/2] can: m_can: Add CAN clock generated by UPLLCK support

2015-11-18 Thread Wenyou Yang
This patch set is to make M_CAN work on SAMA5D2. The orignal delay is not enough for M_CAN on SAMA5D2 to syschronize the two clock domains. Increase the delay time to ensure the value written to INIT can be read back. Add CAN clock generated by UPLLCK(480 MHz) support, the implementation doesn't

[PATCH 2/2] can: m_can: Add CAN clock generated by UPLLCK support

2015-11-18 Thread Wenyou Yang
As said SAMA5D2 datasheet, it is recommended to use the CAN clock at frequencies of 20, 40 or 80 MHz. To achieve these frequencies, PMC GCK3 must select the UPLLCK(480 MHz) as source clock and divide by 24, 12 or 6. In this patch the CAN clock at 20 MHz. As it is configured through DT, it doesn't

[PATCH 1/2] can: m_can: Increase delay to ensure written INIT accepted

2015-11-18 Thread Wenyou Yang
Increase the delay time until the value written to INIT can be read back to ensure that the previous value written to INIT has been accepted. Signed-off-by: Wenyou Yang --- drivers/net/can/m_can/m_can.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 1/3] dl2k: Handle memory allocation errors in alloc_list

2015-11-18 Thread Ondrej Zary
On Tuesday 17 November 2015, Francois Romieu wrote: > Ondrej Zary : > > If memory allocation fails in alloc_list(), free the already allocated > > memory and return -ENODEV. In rio_open(), call alloc_list() first and > > abort if it fails. Move HW access (set

Re: Add a SOCK_DESTROY operation to close sockets from userspace

2015-11-18 Thread Hannes Frederic Sowa
Hi, On Wed, Nov 18, 2015, at 05:04, Eric Dumazet wrote: > On Tue, 2015-11-17 at 19:27 -0800, Stephen Hemminger wrote: > > > I understand why you might want this, but it smells like the same > > kind of problems that the "forced unmount" patch had which eventually > > led to it not being accepted

Re: [PATCH] ethernet/atheros/alx: add Killer E2400 device ID

2015-11-18 Thread Ben Pope
18/11/15 09:21, Jason Gerard DeRose wrote: From: Ben Pope This patch adds the PCI device ID (0xe0a1) and alx_pci_tbl entry for the Killer E2400 Ethernet controller, modeled after the Killer E2200 controller support (0xe091) already present in the alx driver. This patch

[PATCH v2 net-next 06/14] mlx5: add busy polling support

2015-11-18 Thread Eric Dumazet
It is now easy to add busy polling support to a NAPI driver, with very little impact on normal input path. This patch serves as a reference implementation. Note: A followup patch will add proper napi_complete_done() in mlx5, so that LINUX_MIB_BUSYPOLLRXPACKETS snmp counter is properly handled.

[PATCH v2 net-next 10/14] net: move skb_mark_napi_id() into core networking stack

2015-11-18 Thread Eric Dumazet
We would like to automatically provide busy polling support to all NAPI drivers, without them having to implement anything. skb_mark_napi_id() can be called from napi_gro_receive() and napi_get_frags(). Few drivers are still calling skb_mark_napi_id() because they use netif_receive_skb(). They

[PATCH v2 net-next 08/14] bnx2x: remove bnx2x_low_latency_recv() support

2015-11-18 Thread Eric Dumazet
Switch to native NAPI polling, as this reduces overhead and complexity. Normal path is faster, since one cmpxchg() is not anymore requested, and busy polling with the NAPI polling has same performance. Tested: lpk50:~# cat /proc/sys/net/core/busy_read 70 lpk50:~# nstat >/dev/null;./netperf -H

[PATCH v2 net-next 05/14] net: network drivers no longer need to implement ndo_busy_poll()

2015-11-18 Thread Eric Dumazet
Instead of having to implement complex ndo_busy_poll() method, drivers can simply rely on NAPI poll logic. Busy polling gains are mainly coming from polling itself, not on exact details on how we poll the device. ndo_busy_poll() if implemented can avoid touching napi state, but it adds extra

[PATCH v2 net-next 07/14] mlx5: support napi_complete_done()

2015-11-18 Thread Eric Dumazet
A NAPI poll handler should return number of RX packets processed, instead of 0 / budget. This allows proper busy poll accounting through LINUX_MIB_BUSYPOLLRXPACKETS SNMP counter. napi_complete_done() allows /sys/class/net/ethX/gro_flush_timeout to be used for finer GRO aggregation control.

[PATCH v2 26/27] ath: unify Kconfig with other vendors

2015-11-18 Thread Kalle Valo
Change menuconfig to config to keep the Kconfig entries unified. Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo --- drivers/net/wireless/Kconfig |3 +-- drivers/net/wireless/Makefile|3 +--

[PATCH v2 27/27] mac80211_hwsim: move Kconfig entry for sorting alphabetically

2015-11-18 Thread Kalle Valo
mac80211_hwsim was not placed alphabetically correctly in menuconfig, fix that. Signed-off-by: Kalle Valo --- drivers/net/wireless/Kconfig | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/net/wireless/Kconfig

[PATCH v2 16/27] zd1211rw: move under zydas vendor directory

2015-11-18 Thread Kalle Valo
Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo --- MAINTAINERS|2 +- drivers/net/wireless/Kconfig |1 - drivers/net/wireless/Makefile |1 -

[PATCH v2 02/27] airo: move under cisco vendor directory

2015-11-18 Thread Kalle Valo
Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo --- drivers/net/wireless/Kconfig | 43 + drivers/net/wireless/Makefile |4 +- drivers/net/wireless/cisco/Kconfig | 56

[PATCH v2 03/27] atmel: move under atmel vendor directory

2015-11-18 Thread Kalle Valo
Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo --- MAINTAINERS |2 +- drivers/net/wireless/Kconfig| 44 + drivers/net/wireless/Makefile |

[PATCH v2 00/27] wireless drivers vendor directories

2015-11-18 Thread Kalle Valo
Hi, I started to reorganise drivers/net/wireless directory and follow what drivers/net/ethernet has. The major change is that new vendor directories are created and most of the drivers are now under those vendor directories: admtek/ ath/ atmel/ broadcom/ cisco/ intel/ intersil/ marvell/

[PATCH v2 01/27] adm80211: move under admtek vendor directory

2015-11-18 Thread Kalle Valo
Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo --- MAINTAINERS |2 +- drivers/net/wireless/Kconfig| 29 ++- drivers/net/wireless/Makefile |4 +--

Re: [PATCH net-next 4/4] ravb: Add support for r8a7795 SoC

2015-11-18 Thread Sergei Shtylyov
Hello. On 9/30/2015 9:15 AM, Simon Horman wrote: From: Kazuya Mizuguchi This patch supports the r8a7795 SoC by: - Using two interrupts + One for E-MAC + One for everything else + Both can be handled by the existing common interrupt handler, which

[PATCH v2 18/27] p54: move under intersil vendor directory

2015-11-18 Thread Kalle Valo
Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo --- MAINTAINERS|2 +- drivers/net/wireless/Kconfig |1 - drivers/net/wireless/Makefile |2

Re: Hardware capabilities and bonding offload

2015-11-18 Thread Andrew Lunn
On Wed, Nov 18, 2015 at 03:29:23PM +0100, Jiri Pirko wrote: > Wed, Nov 18, 2015 at 03:05:12PM CET, and...@lunn.ch wrote: > >> To be honest though this is more of an argument in theory versus > >> some existing management agent I know of today. If you need to do > >> bonding type X in your network

[PATCH v2 21/27] realtek: create separate Kconfig file

2015-11-18 Thread Kalle Valo
Add new a Kconfig file and a vendor config for realtek. Also update MAINTAINERS which we missed to do when earlier moving rtlwifi. Signed-off-by: Kalle Valo --- MAINTAINERS |8 drivers/net/wireless/Kconfig |5 +

Re: Hardware capabilities and bonding offload

2015-11-18 Thread Jiri Pirko
Wed, Nov 18, 2015 at 03:05:12PM CET, and...@lunn.ch wrote: >> To be honest though this is more of an argument in theory versus >> some existing management agent I know of today. If you need to do >> bonding type X in your network and the particular switch doesn't support >> it I'm not even sure

[PATCH v2 23/27] rt2x00: move under ralink vendor directory

2015-11-18 Thread Kalle Valo
Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo --- MAINTAINERS|2 +- drivers/net/wireless/Kconfig |2 +- drivers/net/wireless/Makefile |3

[PATCH v2 20/27] prism54: move under intersil vendor directory

2015-11-18 Thread Kalle Valo
Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo --- MAINTAINERS|2 +- drivers/net/wireless/Kconfig | 20 drivers/net/wireless/Makefile

  1   2   >