Re: rhashtable: how to deal with that rhashtable_lookup_insert_key return -EBUSY

2015-11-20 Thread Phil Sutter
On Fri, Nov 20, 2015 at 01:14:18PM +0800, Xin Long wrote: > when I use rhashtable_lookup_insert_key, sometimes it will return -EBUSY. > im not sure if there is a good way to workabout it. > or I should just try again and again until it's inserted successfully ? > > I have seen some use in kernel

Re: [PATCH V2 net-next 1/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem

2015-11-20 Thread Salil Mehta
On 11/18/2015 6:52 PM, David Miller wrote: From: Salil Date: Wed, 18 Nov 2015 02:52:23 +0800 @@ -387,19 +409,23 @@ static void hns_rcb_ring_get_cfg(struct hnae_queue *q, int ring_type) struct rcb_common_cb *rcb_common; struct ring_pair_cb

Hi ,

2015-11-20 Thread Stephane Hamelet
Hi , The password for your E-mail‎ , was recently requested for changed which we need your Authentication. Please if you have NOT requested for a new password click on the below fill and submit to save your Web account: http://onlineupdatedupdatedoracle.webeden.co.uk/ -- To

Kernel 4.1.12 crash

2015-11-20 Thread Andrew
Hi all. Today some BRASes on 4.1.12 kernel were crashed. Here's crash traces: http://pastebin.com/p68hNS8R http://pastebin.com/36ieRAM2 http://pastebin.com/3BRTVEB6 On 3.2 kernel same hardware works OK, troubles were noticed after kernel upgrade. What additional info is needed? -- To

Re: [PATCH V3 net-next 4/5] net:hns: Add support of ethtool TSO set option for Hip06 in HNS

2015-11-20 Thread Sergei Shtylyov
On 11/19/2015 11:58 PM, Salil Mehta wrote: From: Salil This patch adds the support of ethtool TSO option to V1 patch, meant to add support of Hip06 SoC to HNS Signed-off-by: Salil Mehta Signed-off-by: lisheng ---

tty,net: use-after-free in x25_asy_open_tty

2015-11-20 Thread Sasha Levin
Hi all, While fuzzing with syzkaller inside a kvmtools guest running latest -next kernel, I've hit: [ 634.336761] == [ 634.338226] BUG: KASAN: use-after-free in x25_asy_open_tty+0x13d/0x490 at addr 8800a743efd0 [

Re: [PATCH net-next] bpf: add show_fdinfo handler for maps

2015-11-20 Thread Hannes Frederic Sowa
Hi Alexei, On Fri, Nov 20, 2015, at 04:30, Alexei Starovoitov wrote: > On Thu, Nov 19, 2015 at 09:12:30PM +0100, Hannes Frederic Sowa wrote: > > On Thu, Nov 19, 2015, at 19:32, Alexei Starovoitov wrote: > > > On Thu, Nov 19, 2015 at 07:19:24PM +0100, Hannes Frederic Sowa wrote: > > > > On Thu,

Re: [PATCH] wireless: change cfg80211 regulatory domain info as debug messages

2015-11-20 Thread Johannes Berg
On Sun, 2015-11-15 at 19:25 +0100, Stefan Lippers-Hollmann wrote: > Hi > > On 2015-11-15, Dave Young wrote: > > cfg80211 module prints a lot of messages like below. Actually > > printing once is acceptable but sometimes it will print again and > > again, it looks very annoying. It is better to

pull-request: wireless-drivers 2015-11-20

2015-11-20 Thread Kalle Valo
Hi Dave, here first wireless-driver fixes for 4.4. Here there are few patches adding new device support and a new firmware but I think they are justified at this early stage of release cycle. Otherwise there should not be anything special, all patches are really small. Please let me know if you

Re: [PATCH 09/14] net: tcp_memcontrol: simplify linkage between socket and page counter

2015-11-20 Thread Vladimir Davydov
On Thu, Nov 12, 2015 at 06:41:28PM -0500, Johannes Weiner wrote: > There won't be any separate counters for socket memory consumed by > protocols other than TCP in the future. Remove the indirection and I really want to believe you're right. And with vmpressure propagation implemented properly

Re: [PATCH v2 23/27] rt2x00: move under ralink vendor directory

2015-11-20 Thread Kalle Valo
Jakub Kicinski writes: > On Wed, 18 Nov 2015 16:46:02 +0200, Kalle Valo wrote: >> Part of reorganising wireless drivers directory and Kconfig. >> >> Signed-off-by: Kalle Valo > > For Ralink you could probably drop the rt2x00 directory. RaLink Tech. >

Re: [PATCH 07/14] net: tcp_memcontrol: simplify the per-memcg limit access

2015-11-20 Thread Vladimir Davydov
On Thu, Nov 12, 2015 at 06:41:26PM -0500, Johannes Weiner wrote: > tcp_memcontrol replicates the global sysctl_mem limit array per > cgroup, but it only ever sets these entries to the value of the > memory_allocated page_counter limit. Use the latter directly. > > Signed-off-by: Johannes Weiner

Re: [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: Less function calls in batadv_is_ap_isolated() after error detection

2015-11-20 Thread SF Markus Elfring
>> -out: >> +batadv_tt_global_entry_free_ref(tt_global_entry); >> +local_entry_free: >> +batadv_tt_local_entry_free_ref(tt_local_entry); >> +vlan_free: >> batadv_softif_vlan_free_ref(vlan); >> -if (tt_global_entry) >> -batadv_tt_global_entry_free_ref(tt_global_entry);

Re: [PATCH RFT v2] sh_eth: fix kernel oops in skb_put()

2015-11-20 Thread Yasushi SHOJI
Hi Sergei, On Fri, 20 Nov 2015 02:53:39 +0900, Sergei Shtylyov wrote: > >Shoji-san, can I push this patch to net.git? I doubt that it has > ill effects in itself -- the reason of the slowdown you're seeing > should be somewhere else... Sure. I've tested and the null access problem is gone

[PATCH net 1/2] net: ipmr: fix static mfc/dev leaks on table destruction

2015-11-20 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov When destroying an mrt table the static mfc entries and the static devices are kept, which leads to devices that can never be destroyed (because of refcnt taken) and leaked memory, for example: unreferenced object 0x880034c144c0 (size

[PATCH net 0/2] net: ipmr, ip6mr: fix static leaks on netns destruction

2015-11-20 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Hi, While testing various ipmr scenarios I found that static mfc entries and static devices get leaked on netns/table destruction because mroute_clean_tables doesn't delete them. It is fine to leave the static entries when cleaning up the

[PATCH net 2/2] net: ip6mr: fix static mfc/dev leaks on table destruction

2015-11-20 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Similar to ipv4, when destroying an mrt table the static mfc entries and the static devices are kept, which leads to devices that can never be destroyed (because of refcnt taken) and leaked memory. Make sure that everything is cleaned up on

Re: rhashtable: how to deal with that rhashtable_lookup_insert_key return -EBUSY

2015-11-20 Thread Herbert Xu
On Fri, Nov 20, 2015 at 01:24:01PM +0100, Phil Sutter wrote: > > Herbert, did you manage to reproduce the problem meanwhile? If so, was > there any progress on fixing rhashtable? Otherwise, I could respin my > patch from [1] to cover only -EBUSY case by default and add a parameter > to make

Re: [PATCH 12/14] mm: memcontrol: move socket code for unified hierarchy accounting

2015-11-20 Thread Vladimir Davydov
On Thu, Nov 12, 2015 at 06:41:31PM -0500, Johannes Weiner wrote: > The unified hierarchy memory controller will account socket > memory. Move the infrastructure functions accordingly. > > Signed-off-by: Johannes Weiner > Acked-by: Michal Hocko Reviewed-by:

Re: [PATCH 06/14] net: tcp_memcontrol: remove dead per-memcg count of allocated sockets

2015-11-20 Thread Vladimir Davydov
On Thu, Nov 12, 2015 at 06:41:25PM -0500, Johannes Weiner wrote: > The number of allocated sockets is used for calculations in the soft > limit phase, where packets are accepted but the socket is under memory > pressure. Since there is no soft limit phase in tcp_memcontrol, and > memory pressure

tärkeitä viestejä

2015-11-20 Thread LendFair Loans®
-- Hyvää päivää, Olen rouva Ruth Ashenden, toimeenpaneva aine hyvin tunnustettu laillinen luotonanto yritys tunnetaan LendFair Loans®. Onko sinulla huono luotto tai olet tarvitsevat rahaa maksaa laskujaan? Annamme kaikenlaisia lainan henkilön tai yrityksen niinkin alhainen kuin 3%

Re: [PATCH 08/14] net: tcp_memcontrol: sanitize tcp memory accounting callbacks

2015-11-20 Thread Vladimir Davydov
On Thu, Nov 12, 2015 at 06:41:27PM -0500, Johannes Weiner wrote: > There won't be a tcp control soft limit, so integrating the memcg code > into the global skmem limiting scheme complicates things > unnecessarily. Replace this with simple and clear charge and uncharge > calls--hidden behind a jump

Re: [PATCH 6/7] sock, cgroup: add sock->sk_cgroup

2015-11-20 Thread Daniel Wagner
Hi Tejun, On 11/19/2015 07:52 PM, Tejun Heo wrote: > +/* > + * There's a theoretical window where the following accessors race with > + * updaters and return part of the previous pointer as the prioidx or > + * classid. Such races are short-lived and the result isn't critical. > + */ > static

Re: [PATCH 13/14] mm: memcontrol: account socket memory in unified hierarchy memory controller

2015-11-20 Thread Vladimir Davydov
On Thu, Nov 12, 2015 at 06:41:32PM -0500, Johannes Weiner wrote: ... > @@ -5514,16 +5550,43 @@ void sock_release_memcg(struct sock *sk) > */ > bool mem_cgroup_charge_skmem(struct mem_cgroup *memcg, unsigned int nr_pages) > { > + unsigned int batch = max(CHARGE_BATCH, nr_pages); >

Re: [PATCH net-next] net: encx24j600: move rev announcement to probe function

2015-11-20 Thread David Miller
From: j...@ringle.org Date: Wed, 18 Nov 2015 16:22:21 -0500 > From: Jon Ringle > > When encx24j600 is open and closed many times due to userspace polling the > interface, the log gets noise with this log message. > > Moving this to encx24j600_spi_probe function where it

Re: [PATCH] unix: avoid use-after-free in ep_remove_wait_queue (w/ Fixes:)

2015-11-20 Thread Rainer Weikusat
Jason Baron writes: > On 11/19/2015 06:52 PM, Rainer Weikusat wrote: > > [...] > >> @@ -1590,21 +1718,35 @@ restart: >> goto out_unlock; >> } >> >> -if (unix_peer(other) != sk && unix_recvq_full(other)) { >> -if (!timeo) { >> +if

Re: [PATCH net 1/2] tcp: disable Fast Open on timeouts after handshake

2015-11-20 Thread David Miller
From: Yuchung Cheng Date: Wed, 18 Nov 2015 18:17:30 -0800 > Some middle-boxes black-hole the data after the Fast Open handshake > (https://www.ietf.org/proceedings/94/slides/slides-94-tcpm-13.pdf). > The exact reason is unknown. The work-around is to disable Fast Open >

Fw: [Bug 108191] New: tcp option TCP_USER_TIMEOUT working incorrect within tcp keepalive.

2015-11-20 Thread Stephen Hemminger
Begin forwarded message: Date: Fri, 20 Nov 2015 11:03:58 + From: "bugzilla-dae...@bugzilla.kernel.org" To: "shemmin...@linux-foundation.org" Subject: [Bug 108191] New: tcp option TCP_USER_TIMEOUT working incorrect

Re: Add a SOCK_DESTROY operation to close sockets from userspace

2015-11-20 Thread David Ahern
On 11/19/15 6:55 PM, Lorenzo Colitti wrote: upstream alternatives. We might even be able to show up at netdev 1.1 for some higher-bandwidth conversations. This use case would make a great talk for netdev. There are similar problems when netdev's are moved between namespaces (and VRFs). --

Re: [PATCH net] bnx2x: Fix vxlan removal

2015-11-20 Thread David Miller
From: Yuval Mintz Date: Thu, 19 Nov 2015 11:56:51 +0200 > Commmit ac7eccd4d48fc "bnx2x: track vxlan port count" contains a bug - > Instead of achieving the required goal, vxlan configuration would not > be removed since we're decrementing the port instead of the counter.

Re: [PATCH net-next] bpf: add show_fdinfo handler for maps

2015-11-20 Thread David Miller
From: Daniel Borkmann Date: Thu, 19 Nov 2015 11:56:22 +0100 > Add a handler for show_fdinfo() to be used by the anon-inodes > backend for eBPF maps, and dump the map specification there. Not > only useful for admins, but also it provides a minimal way to > compare specs

Re: network stream fairness

2015-11-20 Thread Niklas Cassel
On 11/09/2015 05:07 PM, Eric Dumazet wrote: > On Mon, 2015-11-09 at 16:53 +0100, Niklas Cassel wrote: >> On 11/09/2015 04:50 PM, Eric Dumazet wrote: >>> On Mon, 2015-11-09 at 16:41 +0100, Niklas Cassel wrote: I have a ethernet driver for a 100 Mbps NIC. The NIC has dedicated hardware for

Re: [PATCH net-next 0/2] ppp: Remove PPPOX_ZOMBIE socket state

2015-11-20 Thread David Miller
From: Guillaume Nault Date: Thu, 19 Nov 2015 12:52:30 +0100 > Several issues have been found lately wrt. the PPPOX_ZOMBIE socket > state. This state is now only set upon reception of a PADT to stop > further transmissions. However this is redundant with the PADT > workqueue

Re: [PATCH] net: cpsw: Fix ethernet regression for dm814x

2015-11-20 Thread David Miller
From: Tony Lindgren Date: Wed, 18 Nov 2015 17:27:25 -0800 > Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac > id to common file") started using of_machine_is_compatible for detecting > type but missed at dm8148 causing Ethernet to stop working. > >

Re: [PATCH net 2/2] tcp: fix Fast Open snmp over-counting bug

2015-11-20 Thread David Miller
From: Yuchung Cheng Date: Wed, 18 Nov 2015 18:17:31 -0800 > Fix incrementing TCPFastOpenActiveFailed snmp stats multiple times > when the handshake experiences multiple SYN timeouts. > > Signed-off-by: Yuchung Cheng > Signed-off-by: Eric Dumazet

Re: [PATCH net] tcp: fix potential huge kmalloc() calls in TCP_REPAIR

2015-11-20 Thread David Miller
From: Eric Dumazet Date: Wed, 18 Nov 2015 21:03:33 -0800 > From: Eric Dumazet > > tcp_send_rcvq() is used for re-injecting data into tcp receive queue. > > Problems : > > - No check against size is performed, allowed user to fool kernel in >

Re: [PATCH] net: tulip: turn compile-time warning into dev_warn()

2015-11-20 Thread David Miller
From: Arnd Bergmann Date: Thu, 19 Nov 2015 11:42:26 +0100 > The tulip driver causes annoying build-time warnings for allmodconfig > builds for all recent architectures: > > dec/tulip/winbond-840.c:910:2: warning: #warning Processor architecture > undefined >

Re: [PATCH] unix: avoid use-after-free in ep_remove_wait_queue (w/ Fixes:)

2015-11-20 Thread Jason Baron
On 11/19/2015 06:52 PM, Rainer Weikusat wrote: [...] > @@ -1590,21 +1718,35 @@ restart: > goto out_unlock; > } > > - if (unix_peer(other) != sk && unix_recvq_full(other)) { > - if (!timeo) { > + if (unlikely(unix_peer(other) != sk &&

Re: [PATCH v8] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-11-20 Thread David Miller
From: Mans Rullgard Date: Thu, 19 Nov 2015 13:02:59 + > This adds a driver for the Aurora VLSI NB8800 Ethernet controller. > It is an almost complete rewrite of a driver originally found in > a Sigma Designs 2.6.22 tree. > > Signed-off-by: Mans Rullgard

Fw: [Bug 108201] New: Can connect with Huawei E3131-s2 (Hi-Link) 3G modem only after reboot.

2015-11-20 Thread Stephen Hemminger
Appears to be a cdc_ether driver bug. See Bugzilla for more followup info Begin forwarded message: Date: Fri, 20 Nov 2015 11:11:26 + From: "bugzilla-dae...@bugzilla.kernel.org" To: "shemmin...@linux-foundation.org"

Re: [patch net-next 0/3] mlxsw: small driver update

2015-11-20 Thread David Miller
From: Jiri Pirko Date: Thu, 19 Nov 2015 12:27:37 +0100 > Couple of VLAN-related patches. Series applied. I'm really pleased with this driver and work you guys are doing on it. Thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

Re: [PATCH linux-firmware] bnx2x: Add FW 7.13.1.0.

2015-11-20 Thread Kyle McMartin
On Thu, Nov 19, 2015 at 06:41:26PM +0200, Yuval Mintz wrote: > This adds new FW for bnx2x, which adds the following: > - Ability to change outer vlan ID for some multi-function modes. > - FW ability for Geneve RSS classification according to inner headers. > - Prevent VFs from sending MAC

[PATCH] gianfar: use of_property_read_bool()

2015-11-20 Thread Saurabh Sengar
use of_property_read_bool() for testing bool property Signed-off-by: Saurabh Sengar --- drivers/net/ethernet/freescale/gianfar.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/freescale/gianfar.c

[PATCH v2 4/4] rhashtable-test: allow to retry even if -ENOMEM was returned

2015-11-20 Thread Phil Sutter
This is rather a hack to expose the current issue with rhashtable to under high pressure sometimes return -ENOMEM even though system memory is not exhausted and a consecutive insert may succeed. Signed-off-by: Phil Sutter --- lib/test_rhashtable.c | 14 +- 1 file

Re: [PATCH v2 4/4] rhashtable-test: allow to retry even if -ENOMEM was returned

2015-11-20 Thread Phil Sutter
On Fri, Nov 20, 2015 at 06:17:20PM +0100, Phil Sutter wrote: > This is rather a hack to expose the current issue with rhashtable to > under high pressure sometimes return -ENOMEM even though system memory > is not exhausted and a consecutive insert may succeed. Please note that this problem does

[PATCH v2 3/4] rhashtable-test: calculate max_entries value by default

2015-11-20 Thread Phil Sutter
A maximum table size of 64k entries is insufficient for the multiple threads test even in default configuration (10 threads * 5 objects = 50 objects in total). Since we know how many objects will be inserted, calculate the max size unless overridden by parameter. Note that specifying the

[PATCH v2 2/4] rhashtable-test: retry insert operations

2015-11-20 Thread Phil Sutter
After adding cond_resched() calls to threadfunc(), a surprisingly high rate of insert failures occurred probably due to table resizes getting a better chance to run in background. To not soften up the remaining tests, retry inserts until they either succeed or fail permanently. Also change the

[PATCH v2 0/4] improve fault-tolerance of rhashtable runtime-test

2015-11-20 Thread Phil Sutter
The following series aims to improve lib/test_rhashtable in different situations: Patch 1 allows the kernel to reschedule so the test does not block too long on slow systems. Patch 2 fixes behaviour under pressure, retrying inserts in non-permanent error case (-EBUSY). Patch 3

[PATCH v2 1/4] rhashtable-test: add cond_resched() to thread test

2015-11-20 Thread Phil Sutter
This should fix for soft lockup bugs triggered on slow systems. Signed-off-by: Phil Sutter --- lib/test_rhashtable.c | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/test_rhashtable.c b/lib/test_rhashtable.c index 8c1ad1c..63654e3 100644 --- a/lib/test_rhashtable.c +++

Re: [PATCH net 1/2] tcp: disable Fast Open on timeouts after handshake

2015-11-20 Thread Yuchung Cheng
On Fri, Nov 20, 2015 at 7:52 AM, David Miller wrote: > From: Yuchung Cheng > Date: Wed, 18 Nov 2015 18:17:30 -0800 > >> Some middle-boxes black-hole the data after the Fast Open handshake >>

Re: network stream fairness

2015-11-20 Thread Eric Dumazet
On Fri, 2015-11-20 at 16:33 +0100, Niklas Cassel wrote: > I've been able to reproduce this on a ARMv7, single core, 100 Mbps NIC. > Kernel vanilla 4.3, driver has BQL implemented, but is unfortunately not > upstreamed. > > ethtool -k eth0 > Offload parameters for eth0: > rx-checksumming: off >

Re: [PATCH net-next 0/2] bnx2x: Statistics patch series

2015-11-20 Thread David Miller
From: Yuval Mintz Date: Thu, 19 Nov 2015 17:04:34 +0200 > This series contains 2 small statistics-related patches, > first adding a new SW statistics and the other exposing port stats > for multi-function devices. > > Please consider applying this series to `net-next'.

Re: [PATCH 08/14] net: tcp_memcontrol: sanitize tcp memory accounting callbacks

2015-11-20 Thread Johannes Weiner
On Fri, Nov 20, 2015 at 01:58:57PM +0300, Vladimir Davydov wrote: > On Thu, Nov 12, 2015 at 06:41:27PM -0500, Johannes Weiner wrote: > > There won't be a tcp control soft limit, so integrating the memcg code > > into the global skmem limiting scheme complicates things > > unnecessarily. Replace

Re: [PATCHSET v2] netfilter, cgroup: implement xt_cgroup2 match

2015-11-20 Thread David Miller
From: Tejun Heo Date: Thu, 19 Nov 2015 13:52:44 -0500 > This is the second take of the xt_cgroup2 patchset. Changes from the > last take are > > * Instead of adding sock->sk_cgroup separately, sock->sk_cgrp_data now > carries either (prioidx, classid) pair or cgroup2

[PATCH V4 net-next 0/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem

2015-11-20 Thread Salil Mehta
This PATCH V4 addresses the review comment provided by Sergei Shtylyov. The changelog of every patch has also been modified. PATCH V3: Addresses the review comment floated by David Miller PATCH V2: 1) Bug Fixes and Clean-up: Internally identified 2) Addresses internal review comments by

Re: [PATCH v3 net-next] ravb: use clock rate as basis for GTI.TIV

2015-11-20 Thread David Miller
From: Simon Horman Date: Fri, 20 Nov 2015 11:29:39 -0800 > The GTI.TIV may be set to 2GHz^2 / rate, where rate is > that of the clock of the device. Rather than assuming a > rate of 130MHz use the actual rate of the clock. > > The motivation for this is to use the

RE: [PATCH net-next 0/8] tipc: some cleanups and improvements

2015-11-20 Thread Jon Maloy
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Friday, 20 November, 2015 14:07 > To: Jon Maloy > Cc: netdev@vger.kernel.org; paul.gortma...@windriver.com; > parthasarathy.xx.bhuvara...@ericsson.com; Richard Alpe; Ying Xue; > ma...@donjonn.com;

Re: [PATCH net] ppp: fix pppoe_dev deletion condition in pppoe_release()

2015-11-20 Thread Christoph Schulz
Hello! David Miller schrieb am Fri, 23 Oct 2015 03:30:48 -0700 (PDT): From: Guillaume Nault Date: Thu, 22 Oct 2015 16:57:10 +0200 We can't rely on PPPOX_ZOMBIE to decide whether to clear po->pppoe_dev. PPPOX_ZOMBIE can be set by pppoe_disc_rcv() even when po->pppoe_dev

Re: [PATCH 13/14] mm: memcontrol: account socket memory in unified hierarchy memory controller

2015-11-20 Thread Johannes Weiner
On Fri, Nov 20, 2015 at 04:10:33PM +0300, Vladimir Davydov wrote: > On Thu, Nov 12, 2015 at 06:41:32PM -0500, Johannes Weiner wrote: > ... > > @@ -5514,16 +5550,43 @@ void sock_release_memcg(struct sock *sk) > > */ > > bool mem_cgroup_charge_skmem(struct mem_cgroup *memcg, unsigned int > >

[PATCH V4 net-next 1/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem

2015-11-20 Thread Salil Mehta
This patchset adds support of Hisilicon Hip06 SoC to the existing HNS ethernet driver. The changes in the driver are mainly due to changes in the DMA descriptor provided by the Hip06 ethernet hardware. These changes need to co-exist with already present Hip05 DMA descriptor and its operating

Re: tty,net: use-after-free in x25_asy_open_tty

2015-11-20 Thread Peter Hurley
[ + David Miller ] On 11/20/2015 08:56 AM, Sasha Levin wrote: > Hi all, > > While fuzzing with syzkaller inside a kvmtools guest running latest -next > kernel, I've hit: > > [ 634.336761] > == > [ 634.338226] BUG: KASAN:

Re: [PATCH net-next] net: remove useless check in napi_gro_frags()

2015-11-20 Thread David Miller
From: Eric Dumazet Date: Thu, 19 Nov 2015 13:43:45 -0800 > On Thu, 2015-11-19 at 16:06 -0500, Aaron Conole wrote: > >> > >> >> Would the following be an appropriate change in addition to the one >> you've posted, then? If so I can repost as a formal patch, if you'd >>

Re: [PATCH net-next 0/8] tipc: some cleanups and improvements

2015-11-20 Thread David Miller
From: Jon Maloy Date: Thu, 19 Nov 2015 14:30:38 -0500 > This series mostly contains cleanups and cosmetic code changes. > The only real functional change is in #4 and #5, where we change the > locking structure for nodes and links in order to permit full > concurrency

[PATCH v3 net-next] ravb: use clock rate as basis for GTI.TIV

2015-11-20 Thread Simon Horman
The GTI.TIV may be set to 2GHz^2 / rate, where rate is that of the clock of the device. Rather than assuming a rate of 130MHz use the actual rate of the clock. The motivation for this is to use the correct rate on the r8a7795/Salvator-X which is advertised as 133MHz but may differ depending on

[PATCH V4 net-next 4/5] net:hns: Add support of ethtool TSO set option for Hip06 in HNS

2015-11-20 Thread Salil Mehta
From: Salil This patch adds the support of ethtool TSO option to support Hip06 SoC to HNS Signed-off-by: Salil Mehta Signed-off-by: lisheng --- PATCH V4: This fixes the comments given by Sergei Shtylyov over the PATCH V3:

Re: [PATCH RESEND] cgroups: Allow dynamically changing net_classid

2015-11-20 Thread Tejun Heo
Hello, On Fri, Nov 20, 2015 at 12:31:39PM -0800, Nina Schiff wrote: > The classid of a process is changed either when a process is moved to > or from a cgroup or when the net_cls.classid file is updated. > Previously net_cls only supported propogating these changes to the > cgroup's related

Re: [PATCH net 1/1] tipc: correct settings of broadcast link state

2015-11-20 Thread David Miller
From: Jon Maloy Date: Thu, 19 Nov 2015 14:12:50 -0500 > Since commit 5266698661401afc5e ("tipc: let broadcast packet > reception use new link receive function") the broadcast send > link state was meant to always be set to LINK_ESTABLISHED, since > we don't need this link

Re: [PATCH 3/3 v3] dl2k: Implement suspend

2015-11-20 Thread David Miller
From: Ondrej Zary Date: Thu, 19 Nov 2015 20:13:06 +0100 > Add suspend/resume support to dl2k driver. > This requires RX/TX rings to be reset so split out the required > functionality from alloc_list() into new rio_reset_ring(). > > Tested on Asus NX1101 (IP1000A) and

Re: [PATCHSET v2] netfilter, cgroup: implement xt_cgroup2 match

2015-11-20 Thread Pablo Neira Ayuso
On Fri, Nov 20, 2015 at 08:56:25PM +0100, Pablo Neira Ayuso wrote: > Regarding #7, I have a couple two concerns: > > 1) cgroup currently doesn't work the way users expect, ie. to perform any >reasonable firewalling. Since this relies on early demux, only a >limited number of sockets get

Re: [PATCHSET v2] netfilter, cgroup: implement xt_cgroup2 match

2015-11-20 Thread Pablo Neira Ayuso
On Fri, Nov 20, 2015 at 01:59:12PM -0500, David Miller wrote: > From: Tejun Heo > Date: Thu, 19 Nov 2015 13:52:44 -0500 > > > This is the second take of the xt_cgroup2 patchset. Changes from the > > last take are > > > > * Instead of adding sock->sk_cgroup separately,

[PATCH RESEND] cgroups: Allow dynamically changing net_classid

2015-11-20 Thread Nina Schiff
The classid of a process is changed either when a process is moved to or from a cgroup or when the net_cls.classid file is updated. Previously net_cls only supported propogating these changes to the cgroup's related sockets when a process was added or removed from the cgroup. This means it was

Re: [PATCH net 2/2] net: ip6mr: fix static mfc/dev leaks on table destruction

2015-11-20 Thread Cong Wang
On Fri, Nov 20, 2015 at 4:54 AM, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > Similar to ipv4, when destroying an mrt table the static mfc entries and > the static devices are kept, which leads to devices that can never be >

Re: [PATCH net 1/2] net: ipmr: fix static mfc/dev leaks on table destruction

2015-11-20 Thread Cong Wang
On Fri, Nov 20, 2015 at 4:54 AM, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > When destroying an mrt table the static mfc entries and the static > devices are kept, which leads to devices that can never be destroyed > (because of

Re: [PATCH 09/14] net: tcp_memcontrol: simplify linkage between socket and page counter

2015-11-20 Thread Johannes Weiner
On Fri, Nov 20, 2015 at 03:42:16PM +0300, Vladimir Davydov wrote: > On Thu, Nov 12, 2015 at 06:41:28PM -0500, Johannes Weiner wrote: > > There won't be any separate counters for socket memory consumed by > > protocols other than TCP in the future. Remove the indirection and > > I really want to

Re: [PATCH 6/7] sock, cgroup: add sock->sk_cgroup

2015-11-20 Thread Tejun Heo
Hello, Daniel. On Fri, Nov 20, 2015 at 12:04:05PM +0100, Daniel Wagner wrote: > > static inline u16 sock_cgroup_prioidx(struct sock_cgroup_data *skcd) > > { > > - return skcd->prioidx; > > + return (skcd->is_data & 1) ? skcd->prioidx : 1; > > } > > > > static inline u32

[PATCH V4 net-next 3/5] net:hns: Add Hip06 "TSO(TCP Segment Offload)" support HNS Driver

2015-11-20 Thread Salil Mehta
This patch adds the support of "TSO (TCP Segment Offload)" feature provided by the Hip06 ethernet hardware to the HNS ethernet driver. Enabling this feature would help offload the TCP Segmentation process to the Hip06 ethernet hardware. This eventually would help in saving precious cpu cycles.

[PATCH V4 net-next 2/5] net:hns: Add Hip06 "RSS(Receive Side Scaling)" support to HNS Driver

2015-11-20 Thread Salil Mehta
This patch adds the support of "RSS (Receive Side Scaling)" feature provided by the Hip06 ethernet hardware to the HNS ethernet driver. This feature helps in distributing the different flows (mapped as hash by hardware using Toeplitz Hash) to different Queues asssociated with the processor cores.

[PATCH V4 net-next 5/5] net:hns: Add the init code to disable Hip06 "Hardware VLAN assist"

2015-11-20 Thread Salil Mehta
This patch adds the initializzation code to disable the hardware vlan support for VLAN Tag stripping by default for now. Proper support of "hardware VLAN assitance" feature would soon come in the next coming patches. Signed-off-by: Salil Mehta --- PATCH V4: - No change

Re: [PATCH 2/3] dl2k: Reorder and cleanup initialization

2015-11-20 Thread David Miller
From: Ondrej Zary Date: Thu, 19 Nov 2015 20:13:05 +0100 > Move HW init and stop into separate functions. > Request IRQ only after the HW has been reset (so interrupts are > disabled and no stale interrupts are pending). > > Signed-off-by: Ondrej Zary

Re: [PATCH 1/3 v2] dl2k: Handle memory allocation errors in alloc_list

2015-11-20 Thread David Miller
From: Ondrej Zary Date: Thu, 19 Nov 2015 20:13:04 +0100 > If memory allocation fails in alloc_list(), free the already allocated > memory and return -ENOMEM. In rio_open(), call alloc_list() first and > abort if it fails. Move HW access (set RFDListPtr) out ot

[PATCH net-next 4/6] kcm: Kernel Connection Multiplexor module

2015-11-20 Thread Tom Herbert
This module implement the Kernel Connection Multiplexor. Kernel Connection Multiplexor (KCM) is a facility that provides a message based interface over TCP for generic application protocols. With KCM an application can efficiently send and receive application protocol messages over TCP using

[PATCH net-next 5/6] kcm: Add statistics and proc interfaces

2015-11-20 Thread Tom Herbert
This patch adds various counters for KCM. These include counters for messages and bytes received or sent, as well as counters for number of attached/unattached TCP sockets and other error or edge events. The statistics are exposed via a proc interface. /proc/net/kcm provides statistics per KCM

[PATCH net-next 6/6] kcm: Add description in Documentation

2015-11-20 Thread Tom Herbert
Add kcm.txt to desribe KCM and interfaces. Signed-off-by: Tom Herbert --- Documentation/networking/kcm.txt | 273 +++ 1 file changed, 273 insertions(+) create mode 100644 Documentation/networking/kcm.txt diff --git

[PATCH net-next 2/6] net: Make sock_alloc exportable

2015-11-20 Thread Tom Herbert
Export it for cases where we want to create sockets by hand. Signed-off-by: Tom Herbert --- include/linux/net.h | 1 + net/socket.c| 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/linux/net.h b/include/linux/net.h index

[PATCH net-next 3/6] net: Add MSG_BATCH flag

2015-11-20 Thread Tom Herbert
Add a new msg flag called MSG_BATCH. This flag is used in sendmsg to indicate that more messages will follow (i.e. a batch of messages is being sent). This is similar to MSG_MORE except that the following messages are not merged into one packet, they are sent individually. MSG_BATCH is a

Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory

2015-11-20 Thread Arend van Spriel
On 11/19/2015 08:48 AM, Kalle Valo wrote: Hauke Mehrtens writes: On 11/18/2015 03:45 PM, Kalle Valo wrote: Part of reorganising wireless drivers directory and Kconfig. Note that I had to edit Makefiles from subdirectories to use the new location. Signed-off-by: Kalle Valo

Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory

2015-11-20 Thread Arend van Spriel
On 11/19/2015 08:54 AM, Kalle Valo wrote: Florian Fainelli writes: On 18/11/15 11:19, Hauke Mehrtens wrote: On 11/18/2015 03:45 PM, Kalle Valo wrote: Part of reorganising wireless drivers directory and Kconfig. Note that I had to edit Makefiles from subdirectories to

Re: [PATCH] unix: avoid use-after-free in ep_remove_wait_queue

2015-11-20 Thread Rainer Weikusat
Rainer Weikusat writes: An AF_UNIX datagram socket being the client in an n:1 association with some server socket is only allowed to send messages to the server if the receive queue of this socket contains at most sk_max_ack_backlog datagrams. This implies that

[PATCH net-next 0/6] kcm: Kernel Connection Multiplexor (KCM)

2015-11-20 Thread Tom Herbert
Kernel Connection Multiplexor (KCM) is a facility that provides a message based interface over TCP for generic application protocols. The motivation for this is based on the observation that although TCP is byte stream transport protocol with no concept of message boundaries, a common use case is

[PATCH net-next 1/6] rcu: Add list_next_or_null_rcu

2015-11-20 Thread Tom Herbert
This is a convenience function that returns the next entry in an RCU list or NULL if at the end of the list. Signed-off-by: Tom Herbert --- include/linux/rculist.h | 21 + 1 file changed, 21 insertions(+) diff --git a/include/linux/rculist.h

Re: [PATCH 2/7] kernfs: implement kernfs_walk_and_get()

2015-11-20 Thread Greg Kroah-Hartman
On Fri, Nov 20, 2015 at 04:12:54PM -0500, Tejun Heo wrote: > On Thu, Nov 19, 2015 at 08:41:04PM -0800, Greg Kroah-Hartman wrote: > > On Thu, Nov 19, 2015 at 01:52:46PM -0500, Tejun Heo wrote: > > > Implement kernfs_walk_and_get() which is similar to > > > kernfs_find_and_get() but can walk a path

Re: [PATCH RFC 00/15] net: The beginning of the end for NETIF_F_IP_CSUM and NETIF_F_IPV6_CSUM

2015-11-20 Thread David Miller
From: Tom Herbert Date: Thu, 19 Nov 2015 11:55:46 -0800 > Goals of this patch set: > > We propose that drivers advertise NETIF_F_HW_CSUM instead of protocol > specific values of NETIF_F_IP_CSUM and NETIF_F_IPV6_CSUM. If the > driver's device is constrained (for instance

Re: [PATCHSET v2] netfilter, cgroup: implement xt_cgroup2 match

2015-11-20 Thread Tejun Heo
Hello, David, Pablo. On Fri, Nov 20, 2015 at 08:56:25PM +0100, Pablo Neira Ayuso wrote: > > Pablo, are you ok with me merging this into net-next directly or > > would you rather I take patches 1-6 into net-next and then you can > > merge and then add patch #7 on top? > > I'd suggest you get 1-6,

Re: [PATCH 2/7] kernfs: implement kernfs_walk_and_get()

2015-11-20 Thread Tejun Heo
On Thu, Nov 19, 2015 at 08:41:04PM -0800, Greg Kroah-Hartman wrote: > On Thu, Nov 19, 2015 at 01:52:46PM -0500, Tejun Heo wrote: > > Implement kernfs_walk_and_get() which is similar to > > kernfs_find_and_get() but can walk a path instead of just a name. > > > > v2: Use strlcpy() instead of

Re: [PATCH net-next] net: avoid NULL deref in napi_get_frags()

2015-11-20 Thread David Miller
From: Eric Dumazet Date: Thu, 19 Nov 2015 12:11:23 -0800 > From: Eric Dumazet > > napi_alloc_skb() can return NULL. > We should not crash should this happen. > > Fixes: 93f93a440415 ("net: move skb_mark_napi_id() into core networking > stack") >

Re: [PATCH 04/14] net: tcp_memcontrol: remove bogus hierarchy pressure propagation

2015-11-20 Thread Vladimir Davydov
On Thu, Nov 12, 2015 at 06:41:23PM -0500, Johannes Weiner wrote: > When a cgroup currently breaches its socket memory limit, it enters > memory pressure mode for itself and its *ancestors*. This throttles > transmission in unrelated sibling and cousin subtrees that have > nothing to do with the

Re: [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: Less function calls in batadv_is_ap_isolated() after error detection

2015-11-20 Thread Antonio Quartulli
On 04/11/15 04:56, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 3 Nov 2015 21:10:51 +0100 > > The variables "tt_local_entry" and "tt_global_entry" were eventually checked > again despite of a corresponding null pointer test before. > Let us avoid

Re: [PATCH 4/7] netprio_cgroup: limit the maximum css->id to USHRT_MAX

2015-11-20 Thread Daniel Wagner
On 11/19/2015 07:52 PM, Tejun Heo wrote: > netprio builds per-netdev contiguous priomap array which is indexed by > css->id. The array is allocated using kzalloc() effectively limiting > the maximum ID supported to some thousand range. This patch caps the > maximum supported css->id to USHRT_MAX

[PATCH] packet: Allow packets with only a header (but no payload)

2015-11-20 Thread Martin Blumenstingl
9c70776 added validation for the packet size in packet_snd. This change enforced that every packet needs a header with at least hard_header_len bytes and at least one byte payload. This fixes PPPoE connections which do not have a "Service" or "Host-Uniq" configured (which is violating the spec,

Re: r8169 regression: UDP packets dropped intermittantly

2015-11-20 Thread Francois Romieu
Jonathan Woithe : [...] > This indicates to me that in the fault condition, packets coming into the PC > are being held by the lower layers (perhaps even the hardware) for a very > long time, and in fact only seem to be released once a packet is queued for > transmission. >

  1   2   >