Re: [patch net-next 00/26] bonding/team offload + mlxsw implementation

Wed, Dec 02, 2015 at 09:21:37AM CET, gerlitz...@gmail.com wrote: >On Wed, Dec 2, 2015 at 9:58 AM, Jiri Pirko wrote: >> Wed, Dec 02, 2015 at 06:53:35AM CET, gerlitz...@gmail.com wrote: > >>> Another question relates to users bonding/teaming netdevice ports from >>> different HW

Re: [patch net-next 00/26] bonding/team offload + mlxsw implementation

On Wed, Dec 2, 2015 at 9:58 AM, Jiri Pirko wrote: > Wed, Dec 02, 2015 at 06:53:35AM CET, gerlitz...@gmail.com wrote: >>Another question relates to users bonding/teaming netdevice ports from >>different HW switches, or of two vlans over ports from the same HW switch. >>This is

[net-next 17/17] i40e: remove unused argument

From: Jesse Brandeburg With the final edition of the patches to remove sleeps from the driver's entry points, the grab_rtnl argument is no longer needed, so partially revert the commit that added it. Change-ID: Ib9778476242586cc9e58b670f5f48d415cb59003 Signed-off-by:

[net-next 15/17] i40e/i40evf: Bump i40e version to 1.4.4 and i40evf to 1.4.1

From: Catherine Sullivan Bump. Change-ID: I00ebbb2e5e5572f947502b8f6db4d94f666d6b14 Signed-off-by: Catherine Sullivan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher ---

[net-next 10/17] i40e: fix confusing message

From: Helin Zhang This patch fixes the confusing kernel message of enabled RSS size, by reporting it together with the hardware maximum RSS size. Change-ID: I64864dbfbc13beccc180a7871680def1f3d5a339 Signed-off-by: Helin Zhang Tested-by: Andrew

[net-next 08/17] i40evf: add new fields to store user configuration of RSS

From: Helin Zhang This patch adds new fields to i40e_vsi to store user configured RSS config data and code to use it. Change-ID: Ic5d3db8d9df52182b560248f8cdca9c5c7546879 Signed-off-by: Helin Zhang Tested-by: Andrew Bowers

[net-next 01/17] i40e: add new fields to store user configuration

From: Helin Zhang This patch adds new fields to i40e_vsi to store user configured RSS config data and code to use it. Change-ID: I73886469dca9e9f6b16d842182a87f3f4009f95d Signed-off-by: Helin Zhang Tested-by: Andrew Bowers

[net-next 04/17] i40e/i40evf: prefetch skb data on transmit

From: Jesse Brandeburg Issue a prefetch for data early in the transmit path. This should not be generally needed for Tx traffic, but it helps immensely for pktgen workloads and should help for forwarding workloads as well. Change-ID:

[net-next 11/17] i40e: make error message more useful

From: Mitch Williams If we get an invalid message from a VF, we should tell the user which VF is being naughty, rather than making them guess. Change-ID: I9252cef7baea3d8584043ed6ff12619a94e2f99c Signed-off-by: Mitch Williams Tested-by:

[net-next 16/17] i40e: fix: do not sleep in netdev_ops

From: Jesse Brandeburg The driver was being called by VLAN, bonding, teaming operations that expected to be able to hold locks like rcu_read_lock(). This causes the driver to be held to the requirement to not sleep, and was found by the kernel debug options for

[net-next 13/17] i40evf: allocate queue vectors dynamically

From: Mitch Williams Change the queue_vector array from a statically-sized member of the adapter structure to a dynamically-allocated and -sized array. This reduces the size of the adapter structure, and allows us to support any number of queue vectors in the future

[net-next 00/17][pull request] Intel Wired LAN Driver Updates 2015-12-01

This series contains updates to i40e and i40evf only. Helin adds new fields to i40e_vsi to store user configured RSS config data and the code to use it. Also renamed RSS items to clarify functionality and scope to users. Fixed a confusing kernel message of enabling RSS size by reporting it

[net-next 09/17] i40e: Update error messaging

From: Carolyn Wyborny This patch fixes an issue where adminq init failures always provided a message that NVM was newer than expected. This is not always the case for init_adminq failures. Without this patch, if adminq init fails for any reason, newer NVM message

[net-next 05/17] i40evf: rename VF adapter specific RSS function

From: Helin Zhang This patch renames old VF adapter specific RSS function to clarify its scope. Change-ID: Ie5253083a44c677ebb7709a8a3a18402ad2dc6a6 Signed-off-by: Helin Zhang Tested-by: Andrew Bowers Signed-off-by: Jeff

[net-next 07/17] i40evf: create a generic get RSS function

From: Helin Zhang There are two ways to get RSS, this patch implements two functions with the same input parameters, and creates a more generic function for getting RSS configuration. Change-ID: I12d3b712c21455d47dd0a5aae58fc9b7c680db59 Signed-off-by: Helin Zhang

[net-next 02/17] i40e: rename rss_size to alloc_rss_size in i40e_pf

From: Helin Zhang This patch renames rss_size to alloc_rss_size in i40e_pf, which is clearer and avoids confusion. It also adds comments to the other related structure members to help clarify usage. Change-ID: Ia90090609d006ab589cb639975bb8a0af795d16f Signed-off-by: Helin

[net-next 12/17] i40evf: quoth the VF driver, Nevermore

From: Mitch Williams If, upon a midnight dreary, the PF returns ERR_PARAM when the VF is requesting resources, that's fatal. Either the firmware or NVM is badly, badly misconfigured, or this VF has been disabled due to a previous VF driver sending a bunch of bogus

[net-next 03/17] i40e/i40evf: Fix RS bit update in Tx path and disable force WB workaround

From: Anjali Singhai Jain This patch fixes the issue of forcing WB too often causing us to not benefit from NAPI. Without this patch we were forcing WB/arming interrupt too often taking away the benefits of NAPI and causing a performance impact. With this patch we

[net-next 06/17] i40evf: create a generic config RSS function

From: Helin Zhang There are two ways to configure RSS, this patch adjusts those two functions with the same input parameters, and creates a more generic function for configuring RSS. Change-ID: Iace73bdeba4831909979bef221011060ab327f71 Signed-off-by: Helin Zhang

[net-next 14/17] i40evf: allocate ring structs dynamically

From: Mitch Williams Instead of awkwardly keeping a fixed array of pointers in the adapter struct and then allocating ring structs individually, just keep a single pointer and allocate a single blob for the arrays. This simplifies code, shrinks the adapter structure,

Re: [PATCH 00/13] mvneta Buffer Management and enhancements

Hi Florian, Can you please describe in more details, what would you expect from such special abstraction layer regarding buffer managers? I'd like to understand more of your expectations and evaluate possible work. Best regards, Marcin 2015-11-30 17:25 GMT+01:00 David Miller :

[PATCH] i40e: Fix i40e_print_features() VEB mode output

Commit 7fd89545f337 ("i40e: remove BUG_ON from feature string building") added defective output when I40E_FLAG_VEB_MODE_ENABLED was set in function i40e_print_features. Fix it. Miscellanea: o Remove unnecessary string variable o Add space before not after fixed strings o Use kmalloc not kzalloc

Re: [P.A. Semi] Does the ethernet interface work on your Electra, Chitra, Nemo, and Athena board?

On 11/30/15, Christian Zigotzky wrote: > Hi All, > > I have tested the PA Semi Ethernet with the kernels 4.2.3 and 4.3.0 > today. With the kernel 4.2.3 it works but with the kernel 4.3.0 final it > doesn't work. Looking at the changes in pasemi I don't see any significant

RE: [PATCH 3/6] net: thunderx: Increase transmit queue length

Hello! > Probably you might have to set "coherent_pool" size in bootargs to a > higher value. > Can you please check. I have tried to do this. I was able to enlarge the pool up to 4MB, and still got allocation failures. At 8MB pool preallocation stops working: --- cut --- Call trace: []

Re: [RESEND PATCH] arm64: bpf: add 'store immediate' instruction

On Tue, Dec 01, 2015 at 02:20:40PM -0800, Shi, Yang wrote: > On 11/30/2015 2:24 PM, Yang Shi wrote: > >aarch64 doesn't have native store immediate instruction, such operation > >has to be implemented by the below instruction sequence: > > > >Load immediate to register > >Store register > > >

Re: [PATCH] i40e: Fix i40e_print_features() VEB mode output

On Wed, 2015-12-02 at 15:48 -0500, David Miller wrote: > From: Joe Perches 02 Dec 2015 02:12:29 -0800 > > On Wed, 2015-12-02 at 01:56 -0800, Jeff Kirsher wrote: > >> On Wed, 2015-12-02 at 00:38 -0800, Joe Perches wrote: > >> > Noticed-by: Sergei Shtylyov

Re: ipsec impact on performance

On Wed, Dec 2, 2015 at 1:12 PM, Sowmini Varadhan wrote: > On (12/02/15 13:07), Tom Herbert wrote: >> That's easy enough to add to flow dissector, but is SPI really >> intended to be used an L4 entropy value? We would need to consider the > > yes. To quote

pull-request: mac80211 2015-12-02

> Please add them and send a new pull request, I'll just skip over your > existing one. Ok, here we go, below a new pull request. I've added the two commits I spoke about, fixing scanning and an uninitialized cookie variable that lead to problems if the value happened to be 0. Let me know if

[PATCH net-next v3 4/5] ila: Add generic ILA translation facility

This patch implements an ILA tanslation table. This table can be configured with identifier to locator mappings, and can be be queried to resolve a mapping. Queries can be parameterized based on interface, direction (incoming or outoing), and matching locator. The table is implemented using

Re: [net-next v4 4/8] dpaa_eth: add driver's Tx queue selection

On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote: > Allow the selection of the transmission queue based on the CPU id. Explain why. > > Signed-off-by: Madalin Bucur > --- > drivers/net/ethernet/freescale/dpaa/Kconfig | 10 ++ >

[PATCH net-next v3 2/5] rhashtable: add function to replace an element

Add the rhashtable_replace_fast function. This replaces one object in the table with another atomically. The hashes of the new and old objects must be equal. Signed-off-by: Tom Herbert --- include/linux/rhashtable.h | 82 ++ 1

[PATCH net-next v3 1/5] ila: Create net/ipv6/ila directory

Create ila directory in preparation for supporting other hooks in the kernel than LWT for doing ILA. This includes: - Moving ila.c to ila/ila_lwt.c - Splitting out some common functions into ila_common.c Signed-off-by: Tom Herbert --- net/ipv6/Makefile | 2 +-

[PATCH net-next v3 3/5] netlink: add a start callback for starting a netlink dump

The start callback allows the caller to set up a context for the dump callbacks. Presumably, the context can then be destroyed in the done callback. Signed-off-by: Tom Herbert --- include/linux/netlink.h | 2 ++ include/net/genetlink.h | 2 ++ net/netlink/af_netlink.c

[PATCH net-next v3 5/5] net: ILA iptables target

Add two target ILAIN and ILAOUT which hook into the ILA module. Signed-off-by: Tom Herbert --- net/netfilter/Kconfig | 12 net/netfilter/Makefile | 1 + net/netfilter/xt_ILA.c | 82 ++ 3 files changed, 95

[PATCH net-next v3 0/5] ila: Optimization to preserve value of early demux

In the current implementation of ILA, LWT is used to perform translation on both the input and output paths. This is functional, however there is a big performance hit in the receive path. Early demux occurs before the routing lookup (a hit actually obviates the route lookup). Therefore the stack

Re: ipsec impact on performance

On (12/02/15 13:07), Tom Herbert wrote: > That's easy enough to add to flow dissector, but is SPI really > intended to be used an L4 entropy value? We would need to consider the yes. To quote https://en.wikipedia.org/wiki/Security_Parameter_Index "This works like port numbers in TCP and UDP

[P.A. Semi] Does the ethernet interface work on your Electra, Chitra, Nemo, and Athena board?

Hi Michael, Thanks a lot for your answer. We tested some vanilla mainline 4.3 kernels on an Electra reference board. Additionally we tested some patched 4.3 kernels on our Nemo boards. It would be really fantastic, if you could fix the problem. Cheers, Christian On 02 December 2015 at

Re: ipsec impact on performance

On (12/02/15 14:01), Tom Herbert wrote: > No, please don't persist is this myopic "we'll get to IPv6 later" > model! IPv6 is a real protocol, it has significant deployment of the > Internet, and there are now whole data centers that are IPv6 only > (e.g. FB), and there are plenty of use cases of

Re: ipsec impact on performance

On Wed, 2015-12-02 at 16:12 -0500, Sowmini Varadhan wrote: > IPv6 would be an interesting academic exercise Really, you made my day ! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 00/13] mvneta Buffer Management and enhancements

Hi Marcin, On mer., déc. 02 2015, Marcin Wojtas wrote: >>> 2. Change condition in mvebu_mbus_get_dram_win_info to: if (cs->base <= phyaddr && phyaddr <= (cs->base + cs->size -1)) >>> >>> I think it would be the best solution. >> >> So I applied the following patch:

Re: ipsec impact on performance

On Wed, Dec 2, 2015 at 12:50 PM, Sowmini Varadhan wrote: > On (12/02/15 12:41), David Laight wrote: >> You are getting 0.7 Gbps with ass-ccm-a-128, scale the esp-null back to >> that and it would use 7/18*71 = 27% of the cpu. >> So 69% of the cpu in the a-128 case is

Re: ipsec impact on performance

On (12/02/15 13:44), Tom Herbert wrote: > > IPv6 would be an interesting academic exercise, but it's going > > to be a while before we get RDS-TCP to go over IPv6. > > > Huh? Who said anything about RDS-TCP? I thought you were trying to > improve IPsec performance... yes, and it would be nice to

Re: [patch net-next v2 4/6] mlxsw: core: Implement temperature hwmon interface

On Sun, Nov 29, 2015 at 12:49 PM, Jiri Pirko wrote: > Sun, Nov 29, 2015 at 10:04:07AM CET, gerlitz...@gmail.com wrote: >>[..] >>> +enum mlxsw_hwmon_attr_type { >>> + MLXSW_HWMON_ATTR_TYPE_TEMP, >>> + MLXSW_HWMON_ATTR_TYPE_TEMP_MAX, >>> +}; >>> + >>> +static void

[3.13.y-ckt stable] Patch "can: Use correct type in sizeof() in nla_put()" has been added to staging queue

This is a note to let you know that I have just added a patch titled can: Use correct type in sizeof() in nla_put() to the linux-3.13.y-queue branch of the 3.13.y-ckt extended stable tree which can be found at: http://kernel.ubuntu.com/git/ubuntu/linux.git/log/?h=linux-3.13.y-queue

Re: ipsec impact on performance

On Wed, Dec 2, 2015 at 1:47 PM, Sowmini Varadhan wrote: > On (12/02/15 13:44), Tom Herbert wrote: >> > IPv6 would be an interesting academic exercise, but it's going >> > to be a while before we get RDS-TCP to go over IPv6. >> > >> Huh? Who said anything about

Re: [patch net-next v2 4/6] mlxsw: core: Implement temperature hwmon interface

From: Jiri Pirko Date: Wed, 2 Dec 2015 23:25:52 +0100 > Again, there is no possible way to achieve this bugon, other than a > stack corruption. I don't think we should try to cope with a stack > corruption. Then remove the assertion. -- To unsubscribe from this list: send the

Re: [patch net-next v2 4/6] mlxsw: core: Implement temperature hwmon interface

Wed, Dec 02, 2015 at 11:28:47PM CET, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Wed, 2 Dec 2015 23:25:52 +0100 > >> Again, there is no possible way to achieve this bugon, other than a >> stack corruption. I don't think we should try to cope with a stack >> corruption. >

Re: [PATCH net] openvswitch: fix hangup on vxlan/gre/geneve device deletion

On Tue, Dec 1, 2015 at 9:33 AM, Paolo Abeni wrote: > Each openvswitch tunnel vport (vxlan,gre,geneve) holds a reference > to the underlying tunnel device, but never released it when such > device is deleted. > Deleting the underlying device via the ip tool cause the kernel to >

Re: [PATCH 00/13] mvneta Buffer Management and enhancements

Hi Gregory, 2015-12-02 17:21 GMT+01:00 Gregory CLEMENT : > Hi, > > On mer., déc. 02 2015, Gregory CLEMENT > wrote: > >>> >>> So far the issue may have been not noticed, because in every IO driver >>> using

Re: [patch net-next v2 4/6] mlxsw: core: Implement temperature hwmon interface

Wed, Dec 02, 2015 at 11:05:48PM CET, gerlitz...@gmail.com wrote: >On Sun, Nov 29, 2015 at 12:49 PM, Jiri Pirko wrote: >> Sun, Nov 29, 2015 at 10:04:07AM CET, gerlitz...@gmail.com wrote: >>>[..] +enum mlxsw_hwmon_attr_type { + MLXSW_HWMON_ATTR_TYPE_TEMP, +

Re: [patch net-next v2 00/28] bonding/team offload + mlxsw implementation

Dave, why this was marked "Changes Requested" in patchwork? Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [net-next 13/15] ixgbe: Handle extended IPv6 headers in tx path

Alexander Duyck wrote: > This doesn't look right. How come this doesn't match the implementation you > did for the ixgbevf driver? If I am not mistaken this approach had issues > where it could spin forever didn't it? Yes, this is the original version of the patch

Re: BUG: soft lockup happened for ixgbevf

On 2015/12/2 1:25, Alexander Duyck wrote: > On 11/30/2015 11:12 PM, Ding Tianhong wrote: >> Hi Everyone: >> >> I found this problem when using the Testgine to send package to the 82599 >> ethernet: >> 1.wait for the speed to 10G/bit, it's ok. >> 2.then down the eth and then up, loop for several

Re: [PATCH] sctp: convert sack_needed and sack_generation to bits

From: Marcelo Ricardo Leitner Date: Mon, 30 Nov 2015 12:17:06 -0200 > They don't need to be any bigger than that and with this we start a new > bitfield for tracking association runtime stuff, like zero window > situation. > > Signed-off-by: Marcelo Ricardo Leitner

Re: [PATCH] sctp: use GFP_USER for user-controlled kmalloc

From: Marcelo Ricardo Leitner Date: Mon, 30 Nov 2015 14:32:54 -0200 > Dmitry Vyukov reported that the user could trigger a kernel warning by > using a large len value for getsockopt SCTP_GET_LOCAL_ADDRS, as that > value directly affects the value used as a kmalloc()

Re: [PATCH net-next] sfc: use ALIGN macro for aligning frame sizes

From: Jarod Wilson Date: Mon, 30 Nov 2015 17:12:21 -0500 > Don't open-code it. > > CC: Solarflare linux maintainers > CC: Shradha Shah > CC: netdev@vger.kernel.org > Signed-off-by: Jarod Wilson

Re: [PATCH] net/neighbour: fix crash at dumping device-agnostic proxy entries

From: Konstantin Khlebnikov Date: Tue, 01 Dec 2015 01:14:48 +0300 > Proxy entries could have null pointer to net-device. > > Signed-off-by: Konstantin Khlebnikov > Fixes: 84920c1420e2 ("net: Allow ipv6 proxies and arp proxies be shown with > iproute2")

Re: [PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace

From: ebied...@xmission.com (Eric W. Biederman) Date: Mon, 30 Nov 2015 15:38:15 -0600 > + if (dev_net(br->dev) == _net) Please respin this using net_eq() as Hannes pointed out. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH net] ipv6: add complete rcu protection around np->opt

On Wed, 2015-12-02 at 23:38 -0500, David Miller wrote: > From: Eric Dumazet > Date: Sun, 29 Nov 2015 19:37:57 -0800 > > > From: Eric Dumazet > > > > This patch addresses multiple problems : > > > > UDP/RAW sendmsg() need to get a stable struct

Re: [PATCH net] ipv6: kill sk_dst_lock

On Wed, 2015-12-02 at 23:42 -0500, David Miller wrote: > Please update the commit log message with the details you > provided in a reply to this thread. Sure, I sent a v2. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC allocation

On Wed 2015-12-02 22:43:31, Chris Snook wrote: > On Tue, Dec 1, 2015 at 12:35 PM David Miller wrote: > > > From: Michal Hocko > > Date: Mon, 30 Nov 2015 14:21:29 +0100 > > > > > On Sat 28-11-15 15:51:13, Pavel Machek wrote: > > >> > > >> atl1c driver is

[PATCH net] ipv6: sctp: add rcu protection around np->opt

From: Eric Dumazet This patch completes the work I did in commit 45f6fad84cc3 ("ipv6: add complete rcu protection around np->opt"), as I missed sctp part. This simply makes sure np->opt is used with proper RCU locking and accessors. Signed-off-by: Eric Dumazet

Ethernet MII still negotiating status?

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 I'm looking into a problem with the mediatomb package not starting up correctly on recent Ubuntu releases, and I see that the problem is that the service depends on a network up event generated by network-manager to start. While it actually depends

Re: [PATCH net] ipv6: add complete rcu protection around np->opt

From: Eric Dumazet Date: Sun, 29 Nov 2015 19:37:57 -0800 > From: Eric Dumazet > > This patch addresses multiple problems : > > UDP/RAW sendmsg() need to get a stable struct ipv6_txoptions > while socket is not locked : Other threads can change

Re: [PATCH net] bpf: fix allocation warnings in bpf maps and integer overflow

From: Alexei Starovoitov Date: Sun, 29 Nov 2015 16:59:35 -0800 > From: Alexei Starovoitov > > For large map->value_size the user space can trigger memory allocation > warnings like: ... > To avoid never succeeding kmalloc with order >= MAX_ORDER

Re: [PATCH v2 net-next] tcp: suppress too verbose messages in tcp_send_ack()

From: Eric Dumazet Date: Mon, 30 Nov 2015 08:57:28 -0800 > From: Eric Dumazet > > If tcp_send_ack() can not allocate skb, we properly handle this > and setup a timer to try later. > > Use __GFP_NOWARN to avoid polluting syslog in the case host is >

Re: [patch net-next v2 01/28] net: dev: Check CHANGEUPPER notifier return value

On Thu, Dec 3, 2015 at 1:20 AM, John Fastabend wrote: > On 15-12-02 12:07 PM, Jiri Pirko wrote: >> From: Ido Schimmel >> >> switchdev drivers reflect the newly requested topology to hardware when >> CHANGEUPPER is received, after software links were

Re: [PATCH v2 1/1] atm: solos-pci: Replace simple_strtol by kstrtoint

On Wed, Dec 02, 2015 at 05:02:19PM +0300, Sergei Shtylyov wrote: > Hello. > > On 12/2/2015 3:54 PM, LABBE Corentin wrote: > > > The simple_strtol function is obsolete. > > This patch replace it by kstrtoint. > > This will simplify code, since some error case not handled by > > simple_strtol are

Re: [PATCH net] ipv6: kill sk_dst_lock

From: Eric Dumazet Date: Mon, 30 Nov 2015 08:35:15 -0800 > From: Eric Dumazet > > While testing the np->opt RCU conversion, I found that UDP/IPv6 was > using a mixture of xchg() and sk_dst_lock to protect concurrent changes > to sk->sk_dst_cache,

Re: [PATCH] net: smc911x: convert pxa dma to dmaengine

From: Robert Jarzmik Date: Mon, 30 Nov 2015 22:40:28 +0100 > Convert the dma transfers to be dmaengine based, now pxa has a dmaengine > slave driver. This makes this driver a bit more PXA agnostic. > > The driver was only compile tested. The risk is quite small as no >

[PATCH v2 net] ipv6: kill sk_dst_lock

From: Eric Dumazet While testing the np->opt RCU conversion, I found that UDP/IPv6 was using a mixture of xchg() and sk_dst_lock to protect concurrent changes to sk->sk_dst_cache, leading to possible corruptions and crashes. ip6_sk_dst_lookup_flow() uses sk_dst_check()

[PATCH] stmmac: ipq806x: Return error values instead of pointers

Typically we return error pointers when we want to use those pointers in the non-error case, but this function is just returning error pointers or NULL for success. Change the style to plain int to follow normal kernel coding styles. Cc: Joachim Eastwood Signed-off-by:

Re: [PATCH net-next 0/3] vxlan: IPv6 fill_metadata_dst support

On Wed, Dec 2, 2015 at 10:12 AM, Jiri Benc wrote: > This adds IPv6 support to ndo_fill_metadata_dst in vxlan together with > restructuring to avoid duplicate code. > We need the ndo_fill_metadata_dst IPv6 support in net branch, since OVS IPv6 tunnel support is there already.

Re: [patch net-next v2 00/28] bonding/team offload + mlxsw implementation

From: Jiri Pirko Date: Wed, 2 Dec 2015 23:53:53 +0100 > Dave, why this was marked "Changes Requested" in patchwork? Because you gotta kill that BUG_ON() as per our discussion. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

[PATCH 3.13.y-ckt 43/86] can: Use correct type in sizeof() in nla_put()

3.13.11-ckt31 -stable review patch. If anyone has any objections, please let me know. -- From: Marek Vasut commit 562b103a21974c2f9cd67514d110f918bb3e1796 upstream. The sizeof() is invoked on an incorrect variable, likely due to some copy-paste error, and this

Re: [patch net-next v2 01/28] net: dev: Check CHANGEUPPER notifier return value

On 15-12-02 12:07 PM, Jiri Pirko wrote: > From: Ido Schimmel > > switchdev drivers reflect the newly requested topology to hardware when > CHANGEUPPER is received, after software links were already formed. > However, the operation can fail and user will not be notified, as

Re: [patch net-next v2 4/6] mlxsw: core: Implement temperature hwmon interface

From: Jiri Pirko Date: Wed, 2 Dec 2015 23:35:31 +0100 > Why to continue to work if we know that we are making things wrong > (incorrect structure initialization in this case) ? What am I missing? The user might be able to continue to have connectivity and report the problem.

Re: [PATCH v1 1/6] net: Generalize udp based tunnel offload

[...] >> >> I wonder why we need protocol generic offloads? I know there are >> currently a lot of overlay encapsulation protocols. Are there many more >> coming? >> > Yes, and assume that there are more coming with an unbounded limit > (for instance I just noticed today that there is a netdev1.1

Re: gigaset: freeing an active object

On 11/30/2015 01:01 PM, Paul Bolle wrote: > On ma, 2015-11-30 at 00:23 +0100, Paul Bolle wrote: >> Relevant part of dmesg attached at the end of this message. This >> should give me (and Tilman too?) an entry to get to bottom of this. >> Since this is relevant for anyone with just the ser-gigaset

Re: [PATCH v1 1/6] net: Generalize udp based tunnel offload

On Wed, Dec 2, 2015 at 3:35 PM, John Fastabend wrote: > [...] > >>> >>> I wonder why we need protocol generic offloads? I know there are >>> currently a lot of overlay encapsulation protocols. Are there many more >>> coming? >>> >> Yes, and assume that there are more

[PATCH v2 5/5] net: thunderx: Enable BGX LMAC's RX/TX only after VF is up

From: Sunil Goutham Enable or disable BGX LMAC's RX/TX based on corresponding VF's status. If otherwise, when multiple LMAC's physical link is up then packets from all LMAC's whose corresponding VF is not yet initialized will get forwarded to VF0. This is due to VNIC's

[PATCH v2 2/5] net: thunderx: Wait for delayed work to finish before destroying it

From: Thanneeru Srinivasulu While VNIC or BGX driver teardown, wait for already scheduled delayed work to finish before destroying it. Signed-off-by: Thanneeru Srinivasulu Signed-off-by: Sunil Goutham ---

RE: [PATCH 3/6] net: thunderx: Increase transmit queue length

Hello! > > Probably you might have to set "coherent_pool" size in bootargs to a > > higher value. > > Can you please check. > > I have tried to do this. I was able to enlarge the pool up to 4MB, and still > got allocation > failures. At 8MB pool preallocation stops working: > --- cut --- >

Re: [patch net-next 08/26] net: add info struct for LAG changeupper

On 12/01/2015 02:48 PM, Jiri Pirko wrote: > From: Jiri Pirko > > This struct will be shared by bonding and team to pass internal > information to notifier listeners. > > Signed-off-by: Jiri Pirko > --- > include/linux/netdevice.h | 13 + > 1

Re: [patch net-next 08/26] net: add info struct for LAG changeupper

On 12/02/2015 12:06 PM, Jiri Pirko wrote: > Wed, Dec 02, 2015 at 11:59:59AM CET, niko...@cumulusnetworks.com wrote: >> On 12/01/2015 02:48 PM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> This struct will be shared by bonding and team to pass internal >>> information to

Re: [patch net-next 10/26] bonding: fill-up LAG changeupper info struct and pass it along

Wed, Dec 02, 2015 at 12:00:47PM CET, niko...@cumulusnetworks.com wrote: >On 12/01/2015 02:48 PM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Initialize netdev_lag_upper_info structure by TX type according to >> current bonding mode and pass it along via

Re: [PATCH] mac80211_hwsim: missing NULL check

On Mon, 2015-11-30 at 12:46 +0530, Rahul Jain wrote: > From: Amit Khatri > > txrate variable might be NULL and passing inside function > without NULL check. Applied. However, this comes with a big BUT. I seems to always be rewriting your static checker patches, or

[PATCH v2 1/5] net: thunderx: Force to load octeon-mdio before bgx driver.

From: Thanneeru Srinivasulu Signed-off-by: Thanneeru Srinivasulu Signed-off-by: Sunil Goutham --- drivers/net/ethernet/cavium/thunder/thunder_bgx.c |3 +++

[PATCH v2 0/5] net: thunderx: Miscellaneous fixes

From: Sunil Goutham This patch series contains fixes for various issues observed with BGX and NIC drivers. Changes from v1: - Fixed comment syle in the first patch of the series - Removed 'Increase transmit queue length' patch from the series, will recheck if it's a

Re: [PATCH 06/13] net: mvneta: enable mixed egress processing using HR timer

Hi Simon, I checked using hrtimer_is_queued instead of a custom flag and it resulted in ~20kpps drop in my setup. timer_scheduled flag is cleared in the tasklet, so no timer can be scheduled until the tasklet is executed. hr_timer flags do not cover this situation, so much more timers are

RE: [PATCH v2 4/5] net: thunderx: Switchon carrier only upon interface link up

Just a reminder, we have issue with this one too, which is not addressed yet. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia > -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of Sunil >

Re: [RFC] Stable interface index option

Hi, On Wed, Dec 02, 2015 at 12:58:58AM +0100, Hannes Frederic Sowa wrote: > Hello, > > On Tue, Dec 1, 2015, at 23:43, Maximilian Wilhelm wrote: > > How should net-snmp handle cases where new interfaces come up on old > > and now unused numbers? What should it report? That would escalate the > >

Re: Asterisk deadlocks since Kernel 4.1

Hi, here are the results. It works with 4.1. It works with 4.2. It does not work with 4.1.13. git bisect tells me it stopped working after those two commits were applied: commit d48623677191e0f035d7afd344f92cf880b01f8e Author: Herbert Xu Date: Tue Sep 22

Re: [PATCH] i40e: Fix i40e_print_features() VEB mode output

On Wed, 2015-12-02 at 00:38 -0800, Joe Perches wrote: > Commit 7fd89545f337 ("i40e: remove BUG_ON from feature string > building") > added defective output when I40E_FLAG_VEB_MODE_ENABLED was set in > function i40e_print_features. > > Fix it. > > Miscellanea: > > o Remove unnecessary string

Re: [PATCH 00/13] mvneta Buffer Management and enhancements

Hi Marcin, On mer., déc. 02 2015, Marcin Wojtas wrote: > Gregory, > > Please apply below patch: > http://pastebin.com/t42xyU3i > It will confirm if there's an overflow for CS0 size in your setup. > Please let know. Indeed it is an overflow. In v4.0 the size was correct

Re: pull-request: mac80211 2015-11-26

Hi, > > A small set of fixes for 4.4: >  * remove NL80211_FEATURE_FULL_AP_CLIENT_STATE again, it >    was broken and needs more work, we'll enable it for 4.5 >  * fix call_rcu() induced use-after-reset/free in mesh >    (that was

Re: [PATCH net 1/1] via-rhine: fix VLAN receive handling regression.

I faced this problem on 4.2.6, Debian Jessie, on PC Engines Alix6. I applied the patch. It solved the problem. Queue up for -stable? Teco > > From: Francois Romieu > Date: Thu, 15 Oct 2015 00:14:37 +0200 > > > From: Andrej Ota > > > > Because

[PATCH v2 4/5] net: thunderx: Switchon carrier only upon interface link up

From: Sunil Goutham Call netif_carrier_on() only if interface's link is up. Switching this on upon IFF_UP by default, is causing issues with ethernet channel bonding in LACP mode. Initial NETDEV_CHANGE notification was being skipped. Also fixed some issues with

[PATCH v2 3/5] net: thunderx: Set CQ timer threshold properly

From: Sunil Goutham Properly set CQ timer threshold and also set it to 2us. With previous incorrect settings it was set to 0.5us which is too less. Signed-off-by: Sunil Goutham --- drivers/net/ethernet/cavium/thunder/nic.h |5 ++---

Re: [PATCH] i40e: Fix i40e_print_features() VEB mode output

On Wed, 2015-12-02 at 01:56 -0800, Jeff Kirsher wrote: > On Wed, 2015-12-02 at 00:38 -0800, Joe Perches wrote: > > Commit 7fd89545f337 ("i40e: remove BUG_ON from feature string > > building") > > added defective output when I40E_FLAG_VEB_MODE_ENABLED was set in > > function i40e_print_features. >

<    1   2   3   >