Re: [patch net-next 10/26] bonding: fill-up LAG changeupper info struct and pass it along

2015-12-02 Thread Nikolay Aleksandrov
On 12/01/2015 02:48 PM, Jiri Pirko wrote: > From: Jiri Pirko > > Initialize netdev_lag_upper_info structure by TX type according to > current bonding mode and pass it along via netdev_master_upper_dev_link. > > Signed-off-by: Jiri Pirko > --- >

Re: [patch net-next 08/26] net: add info struct for LAG changeupper

2015-12-02 Thread Jiri Pirko
Wed, Dec 02, 2015 at 11:59:59AM CET, niko...@cumulusnetworks.com wrote: >On 12/01/2015 02:48 PM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> This struct will be shared by bonding and team to pass internal >> information to notifier listeners. >> >> Signed-off-by: Jiri Pirko

Re: [patch net-next 08/26] net: add info struct for LAG changeupper

2015-12-02 Thread Jiri Pirko
Wed, Dec 02, 2015 at 12:07:51PM CET, niko...@cumulusnetworks.com wrote: >On 12/02/2015 12:06 PM, Jiri Pirko wrote: >> Wed, Dec 02, 2015 at 11:59:59AM CET, niko...@cumulusnetworks.com wrote: >>> On 12/01/2015 02:48 PM, Jiri Pirko wrote: From: Jiri Pirko This

RE: [PATCH 3/6] net: thunderx: Increase transmit queue length

2015-12-02 Thread Pavel Fedin
Hello! > > swiotlb: coherent allocation failed for device 0002:01:08.4 size=4198400 > > CPU: 2 PID: 3655 Comm: NetworkManager Tainted: GW O4.2.6+ #201 > > Hardware name: Cavium ThunderX CN88XX > > Are you sure 4.2.6 kernel is suitable for backporting this patch aimed > for

Re: [P.A. Semi] Does the ethernet interface work on your Electra, Chitra, Nemo, and Athena board?

2015-12-02 Thread Michael Ellerman
On Wed, 2015-12-02 at 05:59 +0100, Christian Zigotzky wrote: > Hi all, > > We tested some 4.3 kernels on a P.A. Semi reference board. Ultimately, > ethernet does not work, though on the reference board, the interface is > detected, gets link, but will not pass any packets/traffic. > >

Re: [PATCH v4 net 0/6] Marvell Armada XP/370/38X Neta fixes

2015-12-02 Thread Gregory CLEMENT
Hi David, On mer., déc. 02 2015, David Miller wrote: > From: Marcin Wojtas > Date: Mon, 30 Nov 2015 13:27:40 +0100 > >> I'm sending v4 with corrected commit log of the last patch, in order >> to avoid possible conflicts between the branches as

Re: [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

2015-12-02 Thread Michael S. Tsirkin
On Tue, Dec 01, 2015 at 10:36:33AM -0800, Alexander Duyck wrote: > On Tue, Dec 1, 2015 at 9:37 AM, Michael S. Tsirkin wrote: > > On Tue, Dec 01, 2015 at 09:04:32AM -0800, Alexander Duyck wrote: > >> On Tue, Dec 1, 2015 at 7:28 AM, Michael S. Tsirkin wrote: > >

Re: [patch net-next 15/26] bonding: allow notifications for bond_set_slave_link_state

2015-12-02 Thread Jiri Pirko
Wed, Dec 02, 2015 at 12:27:09PM CET, niko...@cumulusnetworks.com wrote: >On 12/01/2015 02:48 PM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Similar to state notifications. >> >> We allow caller to indicate if the notification should happen now or later, >> depending on if he

RE: ipsec impact on performance

2015-12-02 Thread David Laight
From: Sowmini Varadhan > Sent: 01 December 2015 18:37 ... > I was using esp-null merely to not have the crypto itself perturb > the numbers (i.e., just focus on the s/w overhead for now), but here > are the numbers for the stock linux kernel stack > Gbps peak cpu util > esp-null

Re: [PATCH net-next 3/3] vhost_net: basic polling support

2015-12-02 Thread Michael S. Tsirkin
On Wed, Dec 02, 2015 at 01:04:03PM +0800, Jason Wang wrote: > > > On 12/01/2015 10:43 PM, Michael S. Tsirkin wrote: > > On Tue, Dec 01, 2015 at 01:17:49PM +0800, Jason Wang wrote: > >> > >> On 11/30/2015 06:44 PM, Michael S. Tsirkin wrote: > >>> On Wed, Nov 25, 2015 at 03:11:29PM +0800, Jason

Re: [PATCH v2 4/5] net: thunderx: Switchon carrier only upon interface link up

2015-12-02 Thread Sunil Kovvuri
Thanks for the confirmation. On Wed, Dec 2, 2015 at 5:00 PM, Pavel Fedin wrote: > Hello again! > >> Subject: RE: [PATCH v2 4/5] net: thunderx: Switchon carrier only upon >> interface link up >> >> Just a reminder, we have issue with this one too, which is not addressed

Re: Asterisk deadlocks since Kernel 4.1

2015-12-02 Thread Hannes Frederic Sowa
Hello Stefan, Stefan Priebe - Profihost AG writes: > here are the results. > > It works with 4.1. > It works with 4.2. > It does not work with 4.1.13. > > git bisect tells me it stopped working after those two commits were applied: > > commit

Re: [patch net-next 16/26] bonding: implement lower state change propagation

2015-12-02 Thread Nikolay Aleksandrov
On 12/01/2015 02:48 PM, Jiri Pirko wrote: > From: Jiri Pirko > > Let netdev notifier listeners know about link and slave state change. > > Signed-off-by: Jiri Pirko > --- > drivers/net/bonding/bond_main.c | 10 ++ > include/net/bonding.h

Re: [patch net-next 16/26] bonding: implement lower state change propagation

2015-12-02 Thread Nikolay Aleksandrov
On 12/02/2015 12:40 PM, Nikolay Aleksandrov wrote: > On 12/01/2015 02:48 PM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Let netdev notifier listeners know about link and slave state change. >> >> Signed-off-by: Jiri Pirko >> --- >>

Re: ipsec impact on performance

2015-12-02 Thread Sowmini Varadhan
On (12/02/15 11:56), David Laight wrote: > > Gbps peak cpu util > > esp-null 1.8 71% > > aes-gcm-c-2561.6 79% > > aes-ccm-a-1280.7 96% > > > > That trend made me think that if we can get esp-null to be as close > > as possible to GSO/GRO, the rest will

RE: [PATCH 3/6] net: thunderx: Increase transmit queue length

2015-12-02 Thread Pavel Fedin
Hello! > > So, i see several possible ways to solve this: > > > > 1. Introduce some mechanism which would allow the driver to tell the kernel > > that it needs > > coherent pool of large size. Can be problematic because the driver can be a > > module, and pool > > allocation happens early. >

[net-next 03/15] ixgbe: Use private workqueue to avoid certain possible hangs

2015-12-02 Thread Jeff Kirsher
From: Mark Rustad Use a private workqueue to avoid hangs that were otherwise possible when performing stress tests, such as creating and destroying many VFS repeatedly. Signed-off-by: Mark Rustad Tested-by: Darin Miller

[net-next 04/15] ixgbevf: Use a private workqueue to avoid certain possible hangs

2015-12-02 Thread Jeff Kirsher
From: Mark Rustad Use a private workqueue to avoid hangs that were otherwise possible when performing stress tests, such as creating and destroying many VFS repeatedly. Signed-off-by: Mark Rustad Tested-by: Darin Miller

[net-next 00/15][pull request] Intel Wired LAN Driver Updates 2015-12-02

2015-12-02 Thread Jeff Kirsher
This series contains updates to ixgbe and ixgbevf only. Mark cleans up ixgbe_init_phy_ops_x550em, since this was designed to initialize function pointers only and moves the KR PHY reset to the ixgbe_setup_internal_phy_t_x550em which was designed to detect which mode the PHY operates in and set it

Re: [patch net-next 15/26] bonding: allow notifications for bond_set_slave_link_state

2015-12-02 Thread Nikolay Aleksandrov
On 12/01/2015 02:48 PM, Jiri Pirko wrote: > From: Jiri Pirko > > Similar to state notifications. > > We allow caller to indicate if the notification should happen now or later, > depending on if he holds rtnl mutex or not. Introduce bond_slave_link_notify > function (similar

RE: [PATCH v2 4/5] net: thunderx: Switchon carrier only upon interface link up

2015-12-02 Thread Pavel Fedin
Hello again! > Subject: RE: [PATCH v2 4/5] net: thunderx: Switchon carrier only upon > interface link up > > Just a reminder, we have issue with this one too, which is not addressed yet. I have examined the problem thoroughly and discovered that it is a problem with experimental BGX driver

[PATCH] brcmfmac: only lock and unlock fws if fws is not null

2015-12-02 Thread Colin King
From: Colin Ian King There is a null ptr check for fws to set bcmc_credit_check, however, there a lock and unlock on fws should only performed if fwts is also not null to also avoid a potential null pointer deference. Signed-off-by: Colin Ian King

Re: [patch net-next 16/26] bonding: implement lower state change propagation

2015-12-02 Thread Jiri Pirko
Wed, Dec 02, 2015 at 12:40:51PM CET, niko...@cumulusnetworks.com wrote: >On 12/01/2015 02:48 PM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Let netdev notifier listeners know about link and slave state change. >> >> Signed-off-by: Jiri Pirko >> --- >>

Re: ipsec impact on performance

2015-12-02 Thread Sowmini Varadhan
On (12/02/15 07:53), Steffen Klassert wrote: > > I'm currently working on a GRO/GSO codepath for IPsec too. The GRO part > works already. I decapsulate/decrypt the packets on layer2 with a esp GRO > callback function and reinject them into napi_gro_receive(). So in case > the decapsulated packet

[net-next 14/15] ixgbe: Always turn PHY power on when requested

2015-12-02 Thread Jeff Kirsher
From: Mark Rustad Instead of inhibiting PHY power control when manageability is present, only inhibit turning PHY power off when manageability is present. Consequently, PHY power will always be turned on when requested. Without this patch, some systems with X540 or X550

[net-next 13/15] ixgbe: Handle extended IPv6 headers in tx path

2015-12-02 Thread Jeff Kirsher
From: Mark Rustad Check for and handle IPv6 extended headers so that Tx checksum offload can be done. Thanks to Tom Herbert for noticing this problem. Note that the goto back to process the final protocol value can never result in a loop, because it cannot be yet another

[net-next 02/15] ixgbe: Add support for newer thermal alarm

2015-12-02 Thread Jeff Kirsher
From: Mark Rustad The newer copper PHY implementation used with newer X550EM_x devices uses a different thermal alarm type than the earlier one. Make changes to support both types. Signed-off-by: Mark Rustad Tested-by: Darin Miller

[net-next 09/15] ixgbe: Update PTP to support X550EM_x devices

2015-12-02 Thread Jeff Kirsher
From: Mark Rustad The X550EM_x devices handle clocking differently, so update the PTP implementation to accommodate them. This involves significant changes to ixgbe's PTP code to accommodate the new range of behaviors including things like non-power-of-2 clock wrapping.

[net-next 07/15] ixgbe: Use __dev_uc_sync and __dev_uc_unsync for unicast addresses

2015-12-02 Thread Jeff Kirsher
From: Alexander Duyck This change replaces the ixgbe_write_uc_addr_list call in ixgbe_set_rx_mode with a call to __dev_uc_sync instead. This works much better with the MAC addr list code that was already in place and solves an issue in which you couldn't remove an FDB

[net-next 08/15] ixgbe: Allow FDB entries access to more RAR filters

2015-12-02 Thread Jeff Kirsher
From: Alexander Duyck This change makes it so that we allow the PF to make use of all free RAR entries for FDB use if needed. Previously the code limited us to 16 unicast entries, however this was shared between MACVLAN which wasn't limited and the FDB code which was. So

[net-next 01/15] ixgbe: Prevent KR PHY reset in ixgbe_init_phy_ops_x550em

2015-12-02 Thread Jeff Kirsher
From: Mark Rustad This patch removes KR PHY reset from ixgbe_init_phy_ops_x550em, since this function is meant to initialize function pointers for the detected PHY type. Internal PHY reset was moved to ixgbe_setup_internal_phy_t_x550em which will now detect which mode

[net-next 10/15] ixgbe: Correct spec violations by waiting after reset

2015-12-02 Thread Jeff Kirsher
From: Mark Rustad The ixgbe driver was violating the specification in the datasheet by not waiting 1ms before checking for the reset bit clearing. This is called out for devices supported by ixgbe, so implement the required delay. Reported-by: Dan Streetman

[net-next 15/15] ixgbevf: Handle extended IPv6 headers in Tx path

2015-12-02 Thread Jeff Kirsher
From: Mark Rustad Check for and handle IPv6 extended headers so that Tx checksum offload can be done. Also use skb_checksum_help for unexpected cases. Thanks to Tom Herbert for noticing these problems. Thanks to Alexander Duyck for seeing how to coalesce the error

[net-next 06/15] ixgbe: Refactor MAC address configuration code

2015-12-02 Thread Jeff Kirsher
From: Alexander Duyck In the process of tracking down a memory leak when adding/removing FDB entries I had to go through the MAC address configuration code for ixgbe. In the process of doing so I found a number of issues that impacted readability and performance. This

[net-next 12/15] ixgbe: Save VF info and take references

2015-12-02 Thread Jeff Kirsher
From: Mark Rustad Save VF device pointers and take references to speed accesses used to monitor the device behavior to avoid slot resets. The saved information avoids lock contention during the search used to access each of the VFs. Signed-off-by: Mark Rustad

[net-next 11/15] ixgbe: Wait for master disable to be set

2015-12-02 Thread Jeff Kirsher
From: Mark Rustad According to the datasheets, the driver should wait for the master disable bit to read as being set before checking the status register for master disable. Reported-by: Dan Streetman Signed-off-by: Mark Rustad

[net-next 05/15] ixgbevf: Minor cleanups

2015-12-02 Thread Jeff Kirsher
From: Mark Rustad Make some minor cleanups, such as simplifying return paths, deleting unneeded initializations, return values more directly and so forth. Signed-off-by: Mark Rustad Tested-by: Darin Miller

RE: ipsec impact on performance

2015-12-02 Thread David Laight
From: Sowmini Varadhan > Sent: 02 December 2015 12:12 > On (12/02/15 11:56), David Laight wrote: > > > Gbps peak cpu util > > > esp-null 1.8 71% > > > aes-gcm-c-2561.6 79% > > > aes-ccm-a-1280.7 96% > > > > > > That trend made me think that if we can get

[PATCH v2 0/1] atm: solos-pci: Replace simple_strtol by kstrtoint

2015-12-02 Thread LABBE Corentin
Hello Change since v1 - Always return error code from kstrtox. LABBE Corentin (1): atm: solos-pci: Replace simple_strtol by kstrtoint drivers/atm/solos-pci.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) -- 2.4.10 -- To unsubscribe from this list:

[PATCH v2 1/1] atm: solos-pci: Replace simple_strtol by kstrtoint

2015-12-02 Thread LABBE Corentin
The simple_strtol function is obsolete. This patch replace it by kstrtoint. This will simplify code, since some error case not handled by simple_strtol are handled by kstrtoint. Signed-off-by: LABBE Corentin --- drivers/atm/solos-pci.c | 28

Re: [PATCH 3/6] net: thunderx: Increase transmit queue length

2015-12-02 Thread Sunil Kovvuri
>After getting it working in guest i tried to apply it to host. With total of >128 virtual functions (= 128 interfaces) it does not work at all. > Even after bumping cma region size to insane value of 2GB more than half of > interfaces still failed to allocate queues. > And after setting cma=3G

Re: [v2] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-12-02 Thread Eric Dumazet
On Tue, 2015-12-01 at 22:18 -0600, Brent Taylor wrote: > Since commit 8437754c8335 ("ath6kl: Use vmalloc instead of kmalloc for > fw") ar->fw is expected to be pointing to memory allocated by vmalloc. > If the api1 method (via ath6kl_fetch_fw_api1) is used to allocate memory > for ar->fw, then

RE: [PATCH 3/6] net: thunderx: Increase transmit queue length

2015-12-02 Thread Pavel Fedin
Hello! > >After getting it working in guest i tried to apply it to host. With total of > >128 virtual > functions (= 128 interfaces) it does not work at all. > > Even after bumping cma region size to insane value of 2GB more than half of > > interfaces still > failed to allocate queues. > >

[iproute PATCH] route: ignore RTAX_HOPLIMIT of value -1

2015-12-02 Thread Phil Sutter
Older kernels use -1 internally as indicator to use the sysctl default, but they still export the setting. Newer kernels use 0 to indicate that (which is why the conversion from -1 to 0 was done here), but they also stopped exporting the value. Since the meaning of -1 is clear, treat it equally

Re: [PATCH] brcmfmac: only lock and unlock fws if fws is not null

2015-12-02 Thread Arend van Spriel
On 12/02/2015 12:45 PM, Colin King wrote: From: Colin Ian King There is a null ptr check for fws to set bcmc_credit_check, however, there a lock and unlock on fws should only performed if fwts is also not null to also avoid a potential null pointer deference.

Re: ipsec impact on performance

2015-12-02 Thread Sowmini Varadhan
On (12/02/15 12:41), David Laight wrote: > > Also what/how are you measuring cpu use. > I'm not sure anything on Linux gives you a truly accurate value > when processes are running for very short periods. I was using mpstat, while running iperf. Should I be using something else? or running it

Re: [PATCH 3/6] net: thunderx: Increase transmit queue length

2015-12-02 Thread Eric Dumazet
On Wed, 2015-12-02 at 11:18 +0530, Sunil Kovvuri wrote: > >The driver should successfully recover from out of memory situations > > and not stop RX/TX completely. > This memory allocation is while interface bringup/initialization and not > during > packet I/O. > > >Don't put this off as not

Re: [net-next 00/15][pull request] Intel Wired LAN Driver Updates 2015-12-02

2015-12-02 Thread David Miller
From: Jeff Kirsher Date: Wed, 2 Dec 2015 04:30:53 -0800 > This series contains updates to ixgbe and ixgbevf only. I've marked this "changed requested" pending resolution of the ipv6 header parsing feedback Alexander gave. -- To unsubscribe from this list: send the

Re: [PATCH v2 1/1] atm: solos-pci: Replace simple_strtol by kstrtoint

2015-12-02 Thread Sergei Shtylyov
Hello. On 12/2/2015 3:54 PM, LABBE Corentin wrote: The simple_strtol function is obsolete. This patch replace it by kstrtoint. This will simplify code, since some error case not handled by simple_strtol are handled by kstrtoint. Signed-off-by: LABBE Corentin ---

Re: [patch net-next 24/26] mlxsw: spectrum: Implement LAG port join/leave

2015-12-02 Thread Andy Gospodarek
On Tue, Dec 01, 2015 at 02:49:02PM +0100, Jiri Pirko wrote: > From: Jiri Pirko > > Implement basic procedures for joining/leaving port to/from LAG. That > includes HW setup of collector, core LAG mapping setup. > [...] > @@ -1937,6 +2153,18 @@ static int

Re: [patch net-next 24/26] mlxsw: spectrum: Implement LAG port join/leave

2015-12-02 Thread Jiri Pirko
Wed, Dec 02, 2015 at 03:01:32PM CET, go...@cumulusnetworks.com wrote: >On Tue, Dec 01, 2015 at 02:49:02PM +0100, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Implement basic procedures for joining/leaving port to/from LAG. That >> includes HW setup of collector, core LAG

Re: ipsec impact on performance

2015-12-02 Thread Rick Jones
On 12/02/2015 03:56 AM, David Laight wrote: From: Sowmini Varadhan Sent: 01 December 2015 18:37 ... I was using esp-null merely to not have the crypto itself perturb the numbers (i.e., just focus on the s/w overhead for now), but here are the numbers for the stock linux kernel stack

Re: [net-next 00/15][pull request] Intel Wired LAN Driver Updates 2015-12-02

2015-12-02 Thread Jeff Kirsher
On Wed, 2015-12-02 at 16:45 -0500, David Miller wrote: > From: Jeff Kirsher > Date: Wed,  2 Dec 2015 04:30:53 -0800 > > > This series contains updates to ixgbe and ixgbevf only. > > I've marked this "changed requested" pending resolution of the ipv6 > header parsing

Re: [PATCH v1 1/6] net: Generalize udp based tunnel offload

2015-12-02 Thread Alexei Starovoitov
On Wed, Dec 02, 2015 at 03:35:53PM -0800, John Fastabend wrote: > [...] > > BPF. Implementing protocol generic offloads are not just a HW concern > > either, adding kernel GRO code for every possible protocol that comes > > along doesn't scale well. This becomes especially obvious when we > >

<    1   2   3