Re: [PATCH net 1/2] net: cadence: macb: Disable USRIO register on some platforms

Hi Josh, 2015-12-07 20:32 GMT+01:00 Josh Cartwright : > On Mon, Dec 07, 2015 at 11:58:33AM +0100, Neil Armstrong wrote: >> On some platforms, the macb integration does not use the USRIO >> register to configure the (R)MII port and clocks. >> When the register is not implemented and

[PATCH 1/1] net:sctp: disable to inform ULP about transition from PF to active state

From: yzhu1 This feature is introduced in the commit 5aa93bc "sctp: Implement quick failover draft from tsvwg". This feature should be disabled if the quick failover feature is disabled. Signed-off-by: yzhu1 --- net/sctp/associola.c |3 ++- 1

Re: Fixing full name in patchwork

On Tue, Dec 08, 2015 at 09:54:41AM +0200, Kalle Valo wrote: > Sudip Mukherjee writes: > > > On Mon, Dec 07, 2015 at 08:03:54PM +0200, Kalle Valo wrote: > >> Hi Sudip, > >> > >> Sudip Mukherjee writes: > >> > > > > I have also noticed

Re: [PATCH net-next v2 2/5] rhashtable: add function to replace an element

David Miller wrote: > From: Tom Herbert > Date: Tue, 1 Dec 2015 15:11:09 -0800 > >> + lock = rht_bucket_lock(tbl, hash); >> + >> + spin_lock_bh(lock); >> + >> + pprev = >buckets[hash]; >> + rht_for_each(he, tbl, hash) { >> +

[RFC PATCHv2 net-next 1/2] tcp: RTO Restart (RTOR)

This patch implements the RTO restart modification (RTOR). When data is ACKed, and the RTO timer is restarted, the time elapsed since the last outstanding segment was transmitted is subtracted from the calculated RTO value. This way, the RTO timer will expire after exactly RTO seconds, and not RTO

[RFC PATCHv2 net-next 2/2] tcp: TLP restart (TLPR)

This patch implements the TLP restart modification (TLPR). When data is ACKed, and TLP's PTO timer is restarted, the time elapsed since the last outstanding segment was transmitted is subtracted from the calculated RTO value to not unnecessarily delay loss probes. Signed-off-by: Per Hurtig

[RFC PATCHv2 net-next 0/2] tcp: timer restart for tail loss

This is a request for comments. RTO and TLP restart is a modification to the restart process of the RTO and TLP timers in TCP. Currently, both timers are restarted with its corresponding timeout value when an acknowledgment (ACK) for correctly received data is received. In many situations,

Re: [PATCH v3 1/4] stmmac: create of compatible mdio bus for stmacc driver

On Tuesday 08 December 2015 13:12:59 Phil Reid wrote: > @@ -201,6 +201,25 @@ int stmmac_mdio_register(struct net_device *ndev) > struct stmmac_mdio_bus_data *mdio_bus_data = priv->plat->mdio_bus_data; > int addr, found; > > +#ifdef CONFIG_OF > + struct device_node *mdio_node =

Re: Fixing full name in patchwork

Sudip Mukherjee writes: > On Tue, Dec 08, 2015 at 09:54:41AM +0200, Kalle Valo wrote: >> Sudip Mukherjee writes: >> >> > On Mon, Dec 07, 2015 at 08:03:54PM +0200, Kalle Valo wrote: >> >> Hi Sudip, >> >> >> >> Sudip Mukherjee

Re: [RFC PATCH net-next 1/2] tcp: RTO Restart (RTOR)

> On 08 Dec 2015, at 03:05, Yuchung Cheng wrote: > > On Mon, Dec 7, 2015 at 1:00 AM, Per Hurtig wrote: >> This patch implements the RTO restart modification (RTOR). When data is >> ACKed, and the RTO timer is restarted, the time elapsed since the last >>

Re: [net-next,1/2] net: Set sk_txhash from a random number

29.07.2015 02:02, Tom Herbert wrote: This patch creates sk_set_txhash and eliminates protocol specific inet_set_txhash and ip6_set_txhash. sk_set_txhash simply sets a random number instead of performing flow dissection. sk_set_txash is also allowed to be called multiple times for the same

rhashtable: Remove unnecessary wmb for future_tbl

The patch 9497df88ab5567daa001829051c5f87161a81ff0 ("rhashtable: Fix reader/rehash race") added a pair of barriers. In fact the wmb is superfluous because every subsequent write to the old or new hash table uses rcu_assign_pointer, which itself carriers a full barrier prior to the assignment.

Re: [PATCH net 1/2] net: cadence: macb: Disable USRIO register on some platforms

Le 08/12/2015 10:21, Neil Armstrong a écrit : > Hi Josh, > > 2015-12-07 20:32 GMT+01:00 Josh Cartwright : >> On Mon, Dec 07, 2015 at 11:58:33AM +0100, Neil Armstrong wrote: >>> On some platforms, the macb integration does not use the USRIO >>> register to configure the (R)MII port

Re: [PATCH 00/13] mvneta Buffer Management and enhancements

Hi David, 2015-12-04 21:15 GMT+01:00 Florian Fainelli : > (no top posting please) > > On 02/12/15 00:26, Marcin Wojtas wrote: >> Hi Florian, >> >> Can you please describe in more details, what would you expect from >> such special abstraction layer regarding buffer managers?

Warning Mailbox Exceeded Quota Limit

Dear user, Your mailbox has Exceeded the quota limit set by the administrator, you will not be able to send or receive mail until you revalidates your account. Please click the link below or copy paste to your browser to validate your mailbox. http://www.jiffy1.com/limit-update Failure to do

Re: next-20151207 - crash in IPv6 code

Valdis Kletnieks wrote: [ CC Pablo ] > Seen this in 2 boots out of two on next-20151207 when IPV6 networking > was available. It was stable when no net was available. Also, next-20161127 > is OK. > Haven't bisected it yet - this ring any bells? Thanks for the report,

Re: [PATCH net-next] vrf: Add ip rules at vrf device create

Hi, On 12/08/2015 04:55 AM, David Ahern wrote: [snip] > > +static inline size_t vrf_fib_rule_nl_size(bool have_pref) > +{ > + size_t sz; > + > + sz = NLMSG_ALIGN(sizeof(struct fib_rule_hdr)) > + + nla_total_size(IFNAMSIZ) /* FRA_{I,O}IFNAME */ > +

Re: ipsec impact on performance

On (12/08/15 12:32), Steffen Klassert wrote: > > Would be nice if you could share the results. Comments are Sure, not a problem. Give me some time though, I'm also looking into the skb_cow_data and other memory-management issues that were flagged on this thread. I'll have all this info by

Re: [RFC PATCHv2 net-next 1/2] tcp: RTO Restart (RTOR)

On Tue, 8 Dec 2015, Per Hurtig wrote: > This patch implements the RTO restart modification (RTOR). When data is > ACKed, and the RTO timer is restarted, the time elapsed since the last > outstanding segment was transmitted is subtracted from the calculated RTO > value. This way, the RTO timer

[PATCH v2] r8152: fix lockup when runtime PM is enabled

When an interface is brought up which was previously suspended (via runtime PM), it would hang. This happens because napi_disable is called before napi_enable. Solve this by avoiding napi_enable in the resume during open function (netif_running is true when open is called, IFF_UP is set after a

RE: [PATCH v2] r8152: fix lockup when runtime PM is enabled

Peter Wu [mailto:pe...@lekensteyn.nl] > Sent: Tuesday, December 08, 2015 7:18 PM > > When an interface is brought up which was previously suspended (via > runtime PM), it would hang. This happens because napi_disable is called > before napi_enable. > > Solve this by avoiding napi_enable in the

Re: IPsec workshop/BoF at netdev1.1?

On Mon, Dec 07, 2015 at 08:20:01AM -0800, Eric Dumazet wrote: > On Mon, 2015-12-07 at 13:00 +0100, Steffen Klassert wrote: > > Is there any interest in doing an IPsec workshop/BoF at netdev1.1? > > > > This mail is to probe if we can gather enough discussion topics to run > > such a workshop/BoF.

Re: [RFC PATCHv2 net-next 1/2] tcp: RTO Restart (RTOR)

> On 08 Dec 2015, at 11:50, Ilpo Järvinen wrote: > > On Tue, 8 Dec 2015, Per Hurtig wrote: > >> This patch implements the RTO restart modification (RTOR). When data is >> ACKed, and the RTO timer is restarted, the time elapsed since the last >> outstanding segment

[PATCH 3/3] ser_gigaset: remove unnecessary kfree() calls from release method

device->platform_data and platform_device->resource are never used and remain NULL through their entire life. Drops the kfree() calls for them from the device release method. Signed-off-by: Tilman Schmidt Reported-by: Paul Bolle ---

[PATCH 0/3] ser_gigaset fixes

Hi Paul, this series is the result of our discussion on the "freeing an active object" bug. I split my proposed patch into two patches for the separate topics of moving the ser_cardstate kfree() and dropping the useless kfree()s, and also included an unrelated patch (1/3) that had fallen through

RE: [v9, 3/6] fsl/fman: Add FMan MAC support

Regards, Igal Liberman > -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Thursday, December 03, 2015 10:24 PM > To: Liberman Igal-B31950 > Cc: netdev@vger.kernel.org; linuxppc-...@lists.ozlabs.org; linux- >

Re: [PATCH v3 1/4] stmmac: create of compatible mdio bus for stmacc driver

On 2015-12-08 at 10:35:05 +0100, Arnd Bergmann wrote: > On Tuesday 08 December 2015 13:12:59 Phil Reid wrote: > > > @@ -201,6 +201,25 @@ int stmmac_mdio_register(struct net_device *ndev) > > struct stmmac_mdio_bus_data *mdio_bus_data = priv->plat->mdio_bus_data; > > int

Re: [PATCH] r8152: fix lockup when runtime PM is enabled

On Tue, Dec 08, 2015 at 03:18:59AM +, Hayes Wang wrote: > Peter Wu > > Sent: Tuesday, December 08, 2015 12:59 AM > [...] > > + if (tp->netdev->flags & IFF_UP) { > > Maybe you could just replace the checking of netif_running(tp->netdev) > with this. Simply replacing

Re: ipsec impact on performance

On Mon, Dec 07, 2015 at 06:27:48AM -0500, Sowmini Varadhan wrote: > On (12/07/15 09:40), Steffen Klassert wrote: > > > > I've pushed it to > > > > https://git.kernel.org/cgit/linux/kernel/git/klassert/linux-stk.git/log/?h=net-next-ipsec-offload > > > > It is just example code, nothing that I

[PATCH 5/6] Revert "VSOCK: Introduce virtio-vsock-common.ko"

This reverts commit 80a19e338d458abb5a700df3fd00795c51361f06. Keep virtio-vsock out-of-tree until the device specification is finalized. Signed-off-by: Stefan Hajnoczi --- include/linux/virtio_vsock.h| 209 - include/uapi/linux/virtio_ids.h |1

[PATCH 4/6] Revert "VSOCK: Introduce virtio-vsock.ko"

This reverts commit 32e61b06b6946ba137723c5b1de2a1fdb2e0e0a5. Keep virtio-vsock out-of-tree until the device specification is finalized. Signed-off-by: Stefan Hajnoczi --- net/vmw_vsock/virtio_transport.c | 466 --- 1 file changed, 466

[PATCH 3/6] Revert "VSOCK: Introduce vhost-vsock.ko"

This reverts commit 98bb892821c1ad3781b8c7daec2fc8a8de3390c9. Keep virtio-vsock out-of-tree until the device specification is finalized. Signed-off-by: Stefan Hajnoczi --- drivers/vhost/vsock.c | 631 -- drivers/vhost/vsock.h

[PATCH 1/6] Revert "VSOCK: fix returnvar.cocci warnings"

This reverts commit 0d76d6e8b2507983a2cae4c09880798079007421. Keep virtio-vsock out-of-tree until the virtio-vsock device specification is finalized. Signed-off-by: Stefan Hajnoczi --- drivers/vhost/vsock.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH 0/6] VSOCK: revert virtio-vsock until device spec is finalized

The virtio-vsock device specification is not finalized yet. Michael Tsirkin voiced concerned about merging this code when the hardware interface (and possibly the userspace interface) could still change. Please revert for now. I am working to finalize the virtio-vsock device specification and

[PATCH 2/6] Revert "VSOCK: Add Makefile and Kconfig"

This reverts commit 8a2a2029893b4c35d1aba2932111a1a164b9c948. Keep virtio-vsock out-of-tree until the device specification is finalized. Signed-off-by: Stefan Hajnoczi --- drivers/vhost/Kconfig | 4 drivers/vhost/Kconfig.vsock | 7 ---

[PATCH 6/6] Revert "VSOCK: Introduce vsock_find_unbound_socket and vsock_bind_dgram_generic"

This reverts commit 357ab2234d57f6c74386f64ded42dff8e3c0500b. Keep virtio-vsock out-of-tree until the device specification is finalized. Signed-off-by: Stefan Hajnoczi --- include/net/af_vsock.h | 2 -- net/vmw_vsock/af_vsock.c | 70

Re: [PATCH net-next 2/2] net: hns: enet specisies a reference to dsaf (config and documents)

On 2015/12/7 22:12, Rob Herring wrote: > On Sat, Dec 05, 2015 at 03:59:16PM +0800, yankejian wrote: >> when enet specisies a reference to dsaf, the correlative config and > s/when/When/ ok，i will pay attention to it on patch v3. thanks. >> documents needs to update. this patch updates the

Re: [net-next,1/2] net: Set sk_txhash from a random number

On Tue, 2015-12-08 at 11:33 +0300, Alexander Drozdov wrote: > 29.07.2015 02:02, Tom Herbert wrote: > > This patch creates sk_set_txhash and eliminates protocol specific > > inet_set_txhash and ip6_set_txhash. sk_set_txhash simply sets a > > random number instead of performing flow dissection.

Re: [PATCH 1/1] net:sctp: disable to inform ULP about transition from PF to active state

Hi, On Tue, Dec 08, 2015 at 05:47:22PM +0800, zyjzyj2...@gmail.com wrote: > From: yzhu1 > > This feature is introduced in the commit 5aa93bc "sctp: Implement > quick failover draft from tsvwg". This feature should be disabled > if the quick failover feature is disabled. >

[PATCH 1/3] ser_gigaset: fix up NULL checks

Commit f34d7a5b changed tty->driver to tty->ops but left NULL checks for tty->driver untouched. Fix. Signed-off-by: Tilman Schmidt Fixes: f34d7a5b7010 ("tty: The big operations rework") --- drivers/isdn/gigaset/ser-gigaset.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 2/3] ser_gigaset: fix deallocation of platform device structure

When shutting down the device, the struct ser_cardstate must not be kfree()d immediately after the call to platform_device_unregister() since the embedded struct platform_device is still in use. Move the kfree() call to the release method instead. Signed-off-by: Tilman Schmidt

Re: Checksum offload queries

On 07/12/15 19:38, David Miller wrote: > No, it is better to universally provide the 1's complement sum for > all receive packets. This allows the stack more flexibility in > checksum handling. I'm afraid I still don't see it. If a device can both provide the 1's complement sum _and_ validate

Re: [PATCH] I.MX6: Fix Ethernet PHY mode on Ventana boards

> This may be a stupid question but what does the Marvell phy driver > offer that the generic phy driver does not? It reliably configures the RGMII delays :-) No need to depend on your bootloader doing it. It allows interrupts to be used instead of polling the PHY all the time, assuming you

[PATCH 06/14] net: tcp_memcontrol: simplify the per-memcg limit access

tcp_memcontrol replicates the global sysctl_mem limit array per cgroup, but it only ever sets these entries to the value of the memory_allocated page_counter limit. Use the latter directly. Signed-off-by: Johannes Weiner Reviewed-by: Vladimir Davydov

[PATCH] net: ezchip: fix address space confusion in nps_enet.c

The nps_enet driver happily mixes virtual, physical and __iomem addresses, which are all different depending on the architecture and configuration. That causes a warning when building the code on ARM with LPAE mode enabled: drivers/net/ethernet/ezchip/nps_enet.c: In function

Re: [RFC] ipv6: use a random ifid for headerless devices

On 05.12.2015 20:02, Bjørn Mork wrote: > Hannes Frederic Sowa writes: >> On Thu, Dec 3, 2015, at 20:29, Bjørn Mork wrote: >> >>> After looking more at addrconf, I started wondering if we couldn't abuse >>> ipv6_generate_stable_address() for this purpose? We could add

Re: [PATCH v2 next 1/2] dts: hisi: fixes no syscon error when init mdio

On Mon, Dec 07, 2015 at 04:25:06PM +0800, yankejian wrote: > Signed-nux start up, we get the log below: > "Hi-HNS_MDIO 803c.mdio: no syscon hisilicon,peri-c-subctrl > mdio_bus mdio@803c: mdio sys ctl reg has not maped " > > the source code about the subctrl is dealled with syscon,

Re: [PATCH net 2/2] bindings: net: macb: add no-usrio optional property

On Mon, Dec 07, 2015 at 11:58:34AM +0100, Neil Armstrong wrote: > Add the no-usrio optional property to disable usage of the USRIO > register on platforms not implementing it. > --- > Documentation/devicetree/bindings/net/macb.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [PATCH] I.MX6: Fix Ethernet PHY mode on Ventana boards

Tim Harvey writes: > It sounds like your saying this controls whether the phy is in charge > of delay vs the MAC. I have never needed to set this and haven't found > where its actually used (in at least 4.3). Is this caused by something > new in the kernel I haven't seen

Re: [PATCH v1 1/6] net: Generalize udp based tunnel offload

On 15-12-08 02:33 AM, John Fastabend wrote: On 15-12-02 04:15 PM, Tom Herbert wrote: Just keying off the last statement there... I think BPF programs are going to be hard to translate into hardware for most devices. The problem is the BPF programs in general lack structure. A parse graph

[PATCH net 2/2] xfrm: add rcu protection to sk->sk_policy[]

XFRM can deal with SYNACK messages, sent while listener socket is not locked. We add proper rcu protection to __xfrm_sk_clone_policy() and xfrm_sk_policy_lookup() This might serve as the first step to remove xfrm.xfrm_policy_lock use in fast path. Fixes: fa76ce7328b2 ("inet: get rid of central

[PATCH net 1/2] xfrm: add rcu grace period in xfrm_policy_destroy()

We will soon switch sk->sk_policy[] to RCU protection, as SYNACK packets are sent while listener socket is not locked. This patch simply adds RCU grace period before struct xfrm_policy freeing, and the corresponding rcu_head in struct xfrm_policy. Signed-off-by: Eric Dumazet

Re: [RFC PATCHv2 net-next 1/2] tcp: RTO Restart (RTOR)

On Tue, 2015-12-08 at 10:19 +0100, Per Hurtig wrote: > +static u32 tcp_unsent_pkts(const struct sock *sk, u32 ulimit) > +{ > + struct sk_buff *skb = tcp_send_head(sk); > + u32 pkts = 0; > + > + if (skb) > + tcp_for_write_queue_from(skb, sk) { > + pkts

Re: [PATCH v2 net-next 2/3] net: ethernet: cadence-macb: Add fallback to read DT provided caps

On Tuesday 08 December 2015 14:52:05 Neil Armstrong wrote: > Add 1:1 mapping of software defines caps parsing from DT in case the > generic macb compatible form is used. > These properties will provide support for futures implementations > only defined from DT without need to update the driver

Re: [PATCH net] geneve: Fix IPv6 xmit stats update.

On Mon, Dec 07, 2015 at 07:17:30PM -0800, Pravin B Shelar wrote: > Call to iptunnel_xmit_stats() is not required after udp-tunnel6-xmit. > By calling iptunnel_xmit_stats() results in incorrect device stats. > Following patch drops this call. > > Signed-off-by: Pravin B Shelar

[PATCH v2 net-next 2/3] net: ethernet: cadence-macb: Add fallback to read DT provided caps

Add 1:1 mapping of software defines caps parsing from DT in case the generic macb compatible form is used. These properties will provide support for futures implementations only defined from DT without need to update the driver code to support new variants. Signed-off-by: Neil Armstrong

[PATCH v2 net-next 1/3] net: ethernet: cadence-macb: Add disabled usrio caps

On some platforms, the macb integration does not use the USRIO register to configure the (R)MII port and clocks. When the register is not implemented and the MACB error signal is connected to the bus error, reading or writing to the USRIO register can trigger some Imprecise External Aborts on ARM

[PATCH v2 net-next 0/3] Add new capability and parse from DT

The first patch introduces a new capability bit to disable usage of the USRIO register on platform not implementing it thus avoiding some external imprecise aborts on ARM based platforms. The two last patchs implements a DT fallback to get the software defined capabilities from DT in the case of

[PATCH v2 net-next 3/3] bindings: ethernet: macb: Add optional caps properties

Add generic caps properties to the binding in order to support future macb/gem implementations with the generic macb compatible form. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/net/macb.txt | 10 ++ 1 file changed, 10 insertions(+) diff

Re: [PATCH v2] r8152: fix lockup when runtime PM is enabled

On Tue, Dec 08, 2015 at 12:39:12PM +, Hayes Wang wrote: > Peter Wu [mailto:pe...@lekensteyn.nl] > > Sent: Tuesday, December 08, 2015 7:18 PM > > > > When an interface is brought up which was previously suspended (via > > runtime PM), it would hang. This happens because napi_disable is called

Re: [PATCH] fix inverted test in __skb_recv_datagram

David Miller writes: > From: Rainer Weikusat > Date: Mon, 07 Dec 2015 23:30:58 + > >> As the kernel generally uses negated error numbers, *err needs to be >> compared with -EAGAIN (d'oh). >> >> Signed-off-by: Rainer Weikusat

[PATCH] net: fsl: avoid 64-bit warning on pq_mdio

The pq_mdio driver can now be built for ARM64, where we get a format string warning: drivers/net/ethernet/freescale/fsl_pq_mdio.c: In function 'fsl_pq_mdio_probe': drivers/net/ethernet/freescale/fsl_pq_mdio.c:467:25: warning: format '%x' expects argument of type 'unsigned int', but argument 3

Re: [PATCH net-next] vrf: Add ip rules at vrf device create

On 12/8/15 4:54 AM, Nikolay Aleksandrov wrote: Hi, On 12/08/2015 04:55 AM, David Ahern wrote: [snip] +static inline size_t vrf_fib_rule_nl_size(bool have_pref) +{ + size_t sz; + + sz = NLMSG_ALIGN(sizeof(struct fib_rule_hdr)) ++ nla_total_size(IFNAMSIZ) /*

Re: [PATCH v1 1/6] net: Generalize udp based tunnel offload

On 15-12-08 09:23 AM, Jamal Hadi Salim wrote: On 15-12-08 02:33 AM, John Fastabend wrote: ;-> I feel a little vindicated with this discussion. Of course you can implement hardware using BPF! BTW - Just to be clear; I am not arguing for what that paper preaches. What the paper preaches is

[PATCH net-next] bnx2x: avoid soft lockup in bnx2x_poll()

From: Eric Dumazet Under heavy TX load, bnx2x_poll() can loop forever and trigger soft lockup bugs. A napi poll handler must yield after one TX completion round, risk of livelock is too high otherwise. Bug is very easy to trigger using a debug build, and udp flood, because

Re: [PATCH] I.MX6: Fix Ethernet PHY mode on Ventana boards

On Tue, Dec 8, 2015 at 6:13 AM, Krzysztof Hałasa wrote: > Tim Harvey writes: > >> It sounds like your saying this controls whether the phy is in charge >> of delay vs the MAC. I have never needed to set this and haven't found >> where its actually used (in

[PATCH net-next] ipv6: allow routes to be configured with expire values

Add the support for adding expire value to routes, requested by Tom Gundersen for systemd-networkd, and NetworkManager wants it too. add it by using the field rta_expires of rta_cacheinfo Signed-off-by: Xin Long Signed-off-by: Hannes Frederic Sowa

RE: 4.4-rc2 xfrm_lookup kasan trace

From: Of David Miller > Sent: 03 December 2015 16:59 > From: Eric Dumazet > Date: Mon, 30 Nov 2015 17:22:11 -0800 > > > @@ -2198,6 +2198,7 @@ struct dst_entry *xfrm_lookup(struct net *net, struct > > dst_entry *dst_orig, > > xdst = NULL; > > route = NULL; > > > >

Re: [PATCH] fix inverted test in __skb_recv_datagram

As the kernel generally uses negated error numbers, *err needs to be compared with -EAGAIN (d'oh). Signed-off-by: Rainer Weikusat Fixes: ea3793ee29d3 ("core: enable more fine-grained datagram reception control") --- diff --git a/net/core/datagram.c

[PATCH 05/14] net: tcp_memcontrol: remove dead per-memcg count of allocated sockets

The number of allocated sockets is used for calculations in the soft limit phase, where packets are accepted but the socket is under memory pressure. Since there is no soft limit phase in tcp_memcontrol, and memory pressure is only entered when packets are already dropped, this is actually dead

[PATCH 04/14] net: tcp_memcontrol: protect all tcp_memcontrol calls by jump-label

Move the jump-label from sock_update_memcg() and sock_release_memcg() to the callsite, and so eliminate those function calls when socket accounting is not enabled. This also eliminates the need for dummy functions because the calls will be optimized away if the Kconfig options are not enabled.

[PATCH 07/14] net: tcp_memcontrol: sanitize tcp memory accounting callbacks

There won't be a tcp control soft limit, so integrating the memcg code into the global skmem limiting scheme complicates things unnecessarily. Replace this with simple and clear charge and uncharge calls--hidden behind a jump label--to account skb memory. Note that this is not purely aesthetic:

[RFC 1/1] ethtool: support per queue coalesce options

From: Kan Liang Intruduce new coalesce option "queue" to get/set coalesce value to specific queue. If the queue is set to -1, the value will be applied to all queues. Example, [ethtool]$ sudo ./ethtool -C eth5 queue 4 rx-usecs 10 tx-usecs 20 [ethtool]$ sudo ./ethtool -C

Re: Checksum offload queries

On Tue, Dec 8, 2015 at 8:03 AM, Edward Cree wrote: > On 07/12/15 17:29, Tom Herbert wrote: >> On Mon, Dec 7, 2015 at 7:39 AM, Edward Cree wrote: >>> 2) Transmit checksums. >> It's analogous to CHECKSUM_COMPLETE, NETIF_F_HW_CSUM works for all >> cases

[PATCH 14/14] mm: memcontrol: switch to the updated jump-label API

According to the direct use of struct static_key is deprecated. Update the socket and slab accounting code accordingly. Reported-by: Jason Baron Signed-off-by: Johannes Weiner --- include/linux/memcontrol.h | 8 mm/memcontrol.c| 12

[PATCH 13/14] mm: memcontrol: hook up vmpressure to socket pressure

Let the networking stack know when a memcg is under reclaim pressure so that it can clamp its transmit windows accordingly. Whenever the reclaim efficiency of a cgroup's LRU lists drops low enough for a MEDIUM or HIGH vmpressure event to occur, assert a pressure state in the socket and tcp memory

Re: Checksum offload queries

On 07/12/15 17:29, Tom Herbert wrote: > On Mon, Dec 7, 2015 at 7:39 AM, Edward Cree wrote: >> 2) Transmit checksums. > It's analogous to CHECKSUM_COMPLETE, NETIF_F_HW_CSUM works for all > cases of checksum offload and any combination of protocol layering. ... until a

Fw: [Bug 109071] New: Kernel bug in skbuff.c: BUG_ON(len) crashes in combination with IPv6 and GRE tunnels

Begin forwarded message: Date: Tue, 8 Dec 2015 13:26:51 + From: "bugzilla-dae...@bugzilla.kernel.org" To: "shemmin...@linux-foundation.org" Subject: [Bug 109071] New: Kernel bug in skbuff.c: BUG_ON(len) crashes in

Re: netlink: Add missing goto statement to netlink_insert

From: Herbert Xu Date: Tue, 8 Dec 2015 14:13:19 +0800 > On Mon, Dec 07, 2015 at 07:58:25AM +0100, Stefan Priebe - Profihost AG wrote: >> >> Thanks, good. Can you help me to get this fix upstream into the stable >> lines? > > Sure. Greg, please apply this patch to

Re: [PATCH v2 net-next 2/3] net: ethernet: cadence-macb: Add fallback to read DT provided caps

Le 08/12/2015 16:00, Arnd Bergmann a écrit : > On Tuesday 08 December 2015 14:52:05 Neil Armstrong wrote: >> Add 1:1 mapping of software defines caps parsing from DT in case the >> generic macb compatible form is used. >> These properties will provide support for futures implementations >> only

RE: [PATCH net-next] bnx2x: avoid soft lockup in bnx2x_poll()

> Under heavy TX load, bnx2x_poll() can loop forever and trigger soft lockup > bugs. > > A napi poll handler must yield after one TX completion round, risk of > livelock is > too high otherwise. > > Bug is very easy to trigger using a debug build, and udp flood, because of > added > cpu

Re: Checksum offload queries

From: Edward Cree Date: Tue, 8 Dec 2015 14:42:19 + > I'm afraid I still don't see it. You assume that nothing in the stack mangles the packet and would benefit from having the 1's complement to work with in order to assist with checksum adjustments etc. So we want 1's

[PATCH 10/14] mm: memcontrol: do not account memory+swap on unified hierarchy

The unified hierarchy memory controller doesn't expose the memory+swap counter to userspace, but its accounting is hardcoded in all charge paths right now, including the per-cpu charge cache ("the stock"). To avoid adding yet more pointless memory+swap accounting with the socket memory support in

[PATCH 12/14] mm: memcontrol: account socket memory in unified hierarchy memory controller

Socket memory can be a significant share of overall memory consumed by common workloads. In order to provide reasonable resource isolation in the unified hierarchy, this type of memory needs to be included in the tracking/accounting of a cgroup under active memory resource control. Overhead is

[PATCH 11/14] mm: memcontrol: move socket code for unified hierarchy accounting

The unified hierarchy memory controller will account socket memory. Move the infrastructure functions accordingly. Signed-off-by: Johannes Weiner Acked-by: Michal Hocko Reviewed-by: Vladimir Davydov Acked-by: David S. Miller

[PATCH 2/2] netcp: add more __le32 annotations

The handling of epib and psdata remains a bit unclear in the driver, as we access the same fields both as CPU-endian and through DMA from the device. Sparse warns about this: ti/netcp_core.c:1147:21: warning: incorrect type in assignment (different base types) ti/netcp_core.c:1147:21:

[PATCH 1/2] netcp: try to reduce type confusion in descriptors

The netcp driver produces tons of warnings when CONFIG_LPAE is enabled on ARM: drivers/net/ethernet/ti/netcp_core.c: In function 'netcp_tx_map_skb': drivers/net/ethernet/ti/netcp_core.c:1084:13: warning: passing argument 1 of 'set_words' from incompatible pointer type

[PATCH] vhost: vsock: select CONFIG_VHOST

When building the new vsock code without vhost, we get a build error: drivers/built-in.o: In function `vhost_vsock_flush': :(.text+0x24d29c): undefined reference to `vhost_poll_flush' This adds an explicit 'select' like we have for the other vhost drivers. Signed-off-by: Arnd Bergmann

[PATCH 08/14] net: tcp_memcontrol: simplify linkage between socket and page counter

There won't be any separate counters for socket memory consumed by protocols other than TCP in the future. Remove the indirection and link sockets directly to their owning memory cgroup. Signed-off-by: Johannes Weiner Reviewed-by: Vladimir Davydov

RE: [PATCH] net: ezchip: fix address space confusion in nps_enet.c

>From: Arnd Bergmann [mailto:a...@arndb.de] >Sent: Tuesday, December 08, 2015 5:29 PM >To: David S. Miller >Cc: Noam Camus; Tal Zilcer; netdev@vger.kernel.org; >linux-ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org >Subject: [PATCH] net: ezchip: fix address space confusion in

Re: [PATCH 00/14] mm: memcontrol: account socket memory in unified hierarchy v4-RESEND

From: Johannes Weiner Date: Tue, 8 Dec 2015 10:30:10 -0500 > Hi Andrew, > > there was some build breakage in CONFIG_ combinations I hadn't tested > in the last revision, so here is a fixed-up resend with minimal CC > list. The only difference to the previous version is a

Re: [PATCH 14/14] mm: memcontrol: switch to the updated jump-label API

From: Johannes Weiner Date: Tue, 8 Dec 2015 10:30:24 -0500 > According to the direct use of struct static_key > is deprecated. Update the socket and slab accounting code accordingly. > > Reported-by: Jason Baron > Signed-off-by: Johannes Weiner

Re: [PATCH] fix inverted test in __skb_recv_datagram

From: Rainer Weikusat Date: Tue, 08 Dec 2015 14:46:36 + > David Miller writes: >> From: Rainer Weikusat >> Date: Mon, 07 Dec 2015 23:30:58 + >> >>> As the kernel generally uses negated error

Re: Checksum offload queries

From: Edward Cree Date: Tue, 8 Dec 2015 16:03:18 + > NETIF_F_HW_CSUM is limited to one checksum per packet. This is false. As we demux encapsulation layers, we re-adjust the provided 1's complement sum provided and use that to validate the next layer. This works for

[PATCH 00/14] mm: memcontrol: account socket memory in unified hierarchy v4-RESEND

Hi Andrew, there was some build breakage in CONFIG_ combinations I hadn't tested in the last revision, so here is a fixed-up resend with minimal CC list. The only difference to the previous version is a section in memcontrol.h, but it accumulates throughout the series and would have been a pain

[PATCH 01/14] mm: memcontrol: export root_mem_cgroup

A later patch will need this symbol in files other than memcontrol.c, so export it now and replace mem_cgroup_root_css at the same time. Signed-off-by: Johannes Weiner Acked-by: Michal Hocko Acked-by: David S. Miller Reviewed-by:

Re: Checksum offload queries

On Tue, Dec 8, 2015 at 6:42 AM, Edward Cree wrote: > On 07/12/15 19:38, David Miller wrote: >> No, it is better to universally provide the 1's complement sum for >> all receive packets. This allows the stack more flexibility in >> checksum handling. > I'm afraid I still

[PATCH 03/14] net: tcp_memcontrol: remove bogus hierarchy pressure propagation

When a cgroup currently breaches its socket memory limit, it enters memory pressure mode for itself and its *ancestors*. This throttles transmission in unrelated sibling and cousin subtrees that have nothing to do with the breached limit. On the contrary, breaching a limit should make that group

[PATCH 02/14] net: tcp_memcontrol: properly detect ancestor socket pressure

When charging socket memory, the code currently checks only the local page counter for excess to determine whether the memcg is under socket pressure. But even if the local counter is fine, one of the ancestors could have breached its limit, which should also force this child to enter socket

[PATCH 09/14] mm: memcontrol: generalize the socket accounting jump label

The unified hierarchy memory controller is going to use this jump label as well to control the networking callbacks. Move it to the memory controller code and give it a more generic name. Signed-off-by: Johannes Weiner Acked-by: Michal Hocko Reviewed-by:

  1   2   3   >