[net-next v2 04/11] i40evf: check rings before freeing resources

2015-12-12 Thread Jeff Kirsher
From: Mitch Williams If the driver gets unloaded during reset recovery, it's possible that it will attempt to free resources when they're already free. Add a check to make sure that the Tx and Rx rings actually exist before dereferencing them to free resources.

[net-next v2 01/11] i40e: chomp the BIT(_ULL)

2015-12-12 Thread Jeff Kirsher
From: Jesse Brandeburg BIT_ULL was used on a u32 or less where it can simply be BIT. This fixes some trivial static analyzer warnings. Chomp, chomp. Tested with objdump of binary before and after, no changes to code. Change-ID:

[net-next v2 06/11] i40e: Opcode and structures required by OEM Post Update AQ command and add new NVM arq message

2015-12-12 Thread Jeff Kirsher
From: Michal Kosiarz This is a part of implementation which contains data structures and opcode for new AQ command. There's a new ARQ message that gets sent near the end of the NVM update process that the driver should recognize and ignore, rather than printing an

[net-next v2 07/11] i40e: hush little warnings

2015-12-12 Thread Jeff Kirsher
From: Mitch Williams These messages seem big and scary, but they're really not. The driver can fully recover from any of these. The overflow error in particular can happen when enabling a bunch of VFs and the VF driver is not blacklisted. Since these messages are

[net-next v2 10/11] i40evf: change version string generation

2015-12-12 Thread Jeff Kirsher
From: Mitch Williams Generate version strings like the PF driver does. This gives us more flexibility to add suffixes to the version string at build time. Change-ID: I0a5ca0783dd8fb849516bfc1e37ea070127847bd Signed-off-by: Mitch Williams

[net-next v2 02/11] i40e: properly delete VF MAC filters

2015-12-12 Thread Jeff Kirsher
From: Mitch Williams The virtual channel interface was using incorrect semantics to remove MAC addresses, which would leave incorrect filters active when using VLANs. To correct this, add a new function that unconditionally removes MAC addresses from all VLANs, and

[net-next v2 08/11] i40e/i40evf: Add a new offload for RSS PCTYPE V2 for X722

2015-12-12 Thread Jeff Kirsher
From: Anjali Singhai Jain X722 supports Expanded version of TCP, UDP PCTYPES for RSS. Add a Virtchnl offload to support this. Without this patch with X722 devices, driver will set wrong PCTYPES for VF and UDP flows will not fan out. Change-ID:

[net-next v2 11/11] i40e/i40evf: Bump i40e to 1.4.8 and i40evf to 1.4.4

2015-12-12 Thread Jeff Kirsher
From: Catherine Sullivan Bump. Change-ID: I2b8976bde070244de144e2ed8990b083de39f332 Signed-off-by: Catherine Sullivan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher ---

[net-next v2 03/11] i40e: don't add zero MAC filter

2015-12-12 Thread Jeff Kirsher
From: Mitch Williams When VFs are created, the MAC address defaults to all zeros, indicating to the VF driver that it should use a random MAC address. However, the PF driver was incorrectly adding this zero MAC to the filter table, along with the VF's randomly

[net-next v2 09/11] i40e: clean whole mac filter list

2015-12-12 Thread Jeff Kirsher
From: Shannon Nelson Clean the whole mac filter list when resetting after an intermediate add or delete push to the firmware. The code had evolved from using a list from the stack to a heap allocation, but the memset() didn't follow the change correctly. This now

[net-next v2 00/11][pull request] 40GbE Intel Wired LAN Driver Updates 2015-12-12

2015-12-12 Thread Jeff Kirsher
This series contains updates to i40e and i40evf only. Jesse fixes some trivial static analyzer warnings where BIT() can be used instead of BIT_ULL(). Mitch fixes the virtual channel interface which was using incorrect semantics to remove MAC addresses and would leave incorrect filters active

[PATCH] [linux-next] net: Fix typo in skb_fclone_busy

2015-12-12 Thread Masanari Iida
This patch fix a typo found within comment of skb_fclone_busy. Signed-off-by: Masanari Iida --- include/linux/skbuff.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 9b9b9ea..af4f6ac 100644 ---

Re: [net-next v2 00/11][pull request] 40GbE Intel Wired LAN Driver Updates 2015-12-12

2015-12-12 Thread David Miller
From: Jeff Kirsher Date: Sat, 12 Dec 2015 21:17:26 -0800 > This series contains updates to i40e and i40evf only. Pulled, thanks Jeff. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More

[PATCH net] bnx2x: Prevent FW assertion when using Vxlan

2015-12-12 Thread Yuval Mintz
FW has a rare corner case in which a fragmented packet using lots of frags would not be linearized, causing the FW to assert while trying to transmit the packet. To prevent this, we need to make sure the window of fragements containing MSS worth of data contains 1 BD less than for regular packets

Re: ICMPv6 sockets

2015-12-12 Thread Jesse White
On 12/12/2015 08:26 PM, Eric Dumazet wrote: > But there is IPv6 support already, this was added in linux-3.11 by > Lorenzo Colitti. Thanks for the info, found it in 6d0bfe22611602f36617bc7aa2ffa1bbb2f54c67. -Jesse -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body

[net-next v2 05/11] i40e: use explicit cast from u16 to u8

2015-12-12 Thread Jeff Kirsher
From: Kamil Krawczyk Current implementation generates compilation warnings. Change-ID: Icceefb50fe62aefaf90a64afb7192e08355a4ec5 Signed-off-by: Kamil Krawczyk Acked-by: Shannon Nelson Tested-by: Andrew Bowers

[net-next 02/12] ixgbe: Fix SR-IOV VLAN pool configuration

2015-12-12 Thread Jeff Kirsher
From: Alexander Duyck The code for checking the PF bit in ixgbe_set_vf_vlan_msg was using the wrong offset and as a result it was pulling the VLAN off of the PF even if there were VFs numbered greater than 40 that still had the VLAN enabled. Signed-off-by: Alexander Duyck

[net-next 11/12] ixgbe: Clean stale VLANs when changing port VLAN or resetting

2015-12-12 Thread Jeff Kirsher
From: Alexander Duyck This patch guarantees that the VFs do not have access to VLANs that they were not supposed to. What this patch does is add code so that we delete the previous port VLAN after adding a new one, and if we reset the VF we clear all of the filters

[net-next 09/12] ixgbe: Fix VLAN promisc in relation to SR-IOV

2015-12-12 Thread Jeff Kirsher
From: Alexander Duyck This patch is a follow-on for enabling VLAN promiscuous and allowing the PF to add VLANs without adding a VLVF entry. What this patch does is go through and free the VLVF registers if they are not needed as the VLAN belongs only to the PF which is the

[net-next 08/12] ixgbe: Add support for VLAN promiscuous with SR-IOV

2015-12-12 Thread Jeff Kirsher
From: Alexander Duyck This patch adds support for VLAN promiscuous with SR-IOV enabled. The code prior to this patch was only adding the PF to VLANs that the VF had added. As such enabling promiscuous mode would actually not add any additional VLAN filters so visibility

[net-next 01/12] ixgbe: Return error on failure to allocate mac_table

2015-12-12 Thread Jeff Kirsher
From: Alexander Duyck Add a check to make certain mac_table was actually allocated and is not NULL. If it is NULL return -ENOMEM and allow the probe routine to fail rather then causing a NULL pointer dereference further down the line. Signed-off-by: Alexander Duyck

[net-next 04/12] ixgbe: Reduce VT code indent in set_vfta by introducing jump label

2015-12-12 Thread Jeff Kirsher
From: Alexander Duyck In order to clear the way for upcoming work I thought it best to drop the level of indent in the ixgbe_set_vfta_generic function. Most of the code is held in the virtualization specific section. So the easiest approach is to just add a jump label and

[net-next 12/12] ixgbe: do not report 2.5 Gbps as supported

2015-12-12 Thread Jeff Kirsher
From: Emil Tantilov Some X550 devices can connect at 2.5Gbps during fail-over, but only with certain link partners. Also setting the advertised speed will not work so we do not report it as supported to avoid confusion. Signed-off-by: Emil Tantilov

[net-next 03/12] ixgbe: Simplify definitions for regidx and bit in set_vfta

2015-12-12 Thread Jeff Kirsher
From: Alexander Duyck This patch simplifies the logic for setting the VFTA register by removing the number of conditional checks needed. Instead we just use some boolean logic to generate vfta_delta, and if that is set then we xor the vfta by that value and write it back.

[net-next 07/12] ixgbe: Reorder search to work from the top down instead of bottom up

2015-12-12 Thread Jeff Kirsher
From: Alexander Duyck This patch is meant to reduce the complexity of the search function used for finding a VLVF entry associated with a given VLAN ID. The previous code was searching from bottom to top. I reordered it to search from top to bottom. In addition I pulled

[net-next 06/12] ixgbe: Add support for adding/removing VLAN on PF bypassing the VLVF

2015-12-12 Thread Jeff Kirsher
From: Alexander Duyck This patch adds support for bypassing the VLVF entry creation when the PF is adding a new VLAN. The advantage to doing this is that we can then save the VLVF entries for the VFs which must have them in order to function, versus the PF which can fall

[net-next 05/12] ixgbe: Simplify configuration of setting VLVF and VLVFB

2015-12-12 Thread Jeff Kirsher
From: Alexander Duyck This patch addresses several issues within the VLVF and VLVFB configuration First was the fact that code was overly complicated with multiple conditional paths depending on if we adding or removing and which bit we were going to add or remove. Instead

[net-next 10/12] ixgbe: Clear stale pool mappings

2015-12-12 Thread Jeff Kirsher
From: Alexander Duyck This patch makes certain that we clear the pool mappings added when we configure default MAC addresses for the interface. Without this we run the risk of leaking an address into pool 0 which really belongs to VF 0 when SR-IOV is enabled.

[iproute PATCH] route: Fix printing of locked entries

2015-12-12 Thread Phil Sutter
Commit 0f7543322c5fd ("route: ignore RTAX_HOPLIMIT of value -1") accidentally reordered fprintf statements. This patch restores the original ordering. Fixes: 0f7543322c5fd ("route: ignore RTAX_HOPLIMIT of value -1") Signed-off-by: Phil Sutter --- ip/iproute.c | 5 +++-- 1 file

[net-next 05/11] i40e: use explicit cast from u16 to u8

2015-12-12 Thread Jeff Kirsher
From: Kamil Krawczyk Current implementation generates compilation warnings. Change-ID: Icceefb50fe62aefaf90a64afb7192e08355a4ec5 Signed-off-by: Kamil Krawczyk Acked-by: Shannon Nelson Tested-by: Andrew Bowers

[net-next 10/11] i40evf: change version string generation

2015-12-12 Thread Jeff Kirsher
From: Mitch Williams Generate version strings like the PF driver does. This gives us more flexibility to add suffixes to the version string at build time. Change-ID: I0a5ca0783dd8fb849516bfc1e37ea070127847bd Signed-off-by: Mitch Williams

[net-next 09/11] i40e: clean whole mac filter list

2015-12-12 Thread Jeff Kirsher
From: Shannon Nelson Clean the whole mac filter list when resetting after an intermediate add or delete push to the firmware. The code had evolved from using a list from the stack to a heap allocation, but the memset() didn't follow the change correctly. This now

[net-next 00/12][pull request] 10GbE Intel Wired LAN Driver Updates 2015-12-12

2015-12-12 Thread Jeff Kirsher
This series contains updates to ixgbe only. Alex Duyck provides almost off of the changes in this series. First, add a check to make sure mac_table was actually allocated and is not NULL to ensure we do not get a NULL pointer dereference further down the line. Fixed SR-IOV VLAN pool

[net-next 11/11] i40e/i40evf: Bump i40e to 1.4.8 and i40evf to 1.4.4

2015-12-12 Thread Jeff Kirsher
From: Catherine Sullivan Bump. Change-ID: I2b8976bde070244de144e2ed8990b083de39f332 Signed-off-by: Catherine Sullivan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher ---

[net-next 03/11] i40e: don't add zero MAC filter

2015-12-12 Thread Jeff Kirsher
From: Mitch Williams When VFs are created, the MAC address defaults to all zeros, indicating to the VF driver that it should use a random MAC address. However, the PF driver was incorrectly adding this zero MAC to the filter table, along with the VF's randomly

[net-next 02/11] i40e: properly delete VF MAC filters

2015-12-12 Thread Jeff Kirsher
From: Mitch Williams The virtual channel interface was using incorrect semantics to remove MAC addresses, which would leave incorrect filters active when using VLANs. To correct this, add a new function that unconditionally removes MAC addresses from all VLANs, and

[net-next 01/11] i40e: chomp the BIT(_ULL)

2015-12-12 Thread Jeff Kirsher
From: Jesse Brandeburg BIT_ULL was used on a u32 or less where it can simply be BIT. This fixes some trivial static analyzer warnings. Chomp, chomp. Tested with objdump of binary before and after, no changes to code. Change-ID:

[net-next 07/11] i40e: hush little warnings

2015-12-12 Thread Jeff Kirsher
From: Mitch Williams These messages seem big and scary, but they're really not. The driver can fully recover from any of these. The overflow error in particular can happen when enabling a bunch of VFs and the VF driver is not blacklisted. Since these messages are

[net-next 06/11] i40e: Opcode and structures required by OEM Post Update AQ command and add new NVM arq message

2015-12-12 Thread Jeff Kirsher
From: Michal Kosiarz This is a part of implementation which contains data structures and opcode for new AQ command. There's a new ARQ message that gets sent near the end of the NVM update process that the driver should recognize and ignore, rather than printing an

[net-next 08/11] i40e/i40evf: Add a new offload for RSS PCTYPE V2 for X722

2015-12-12 Thread Jeff Kirsher
From: Anjali Singhai Jain X722 supports Expanded version of TCP, UDP PCTYPES for RSS. Add a Virtchnl offload to support this. Without this patch with X722 devices, driver will set wrong PCTYPES for VF and UDP flows will not fan out. Change-ID:

[net-next 00/11][pull request] 40GbE Intel Wired LAN Driver Updates 2015-12-12

2015-12-12 Thread Jeff Kirsher
This series contains updates to i40e and i40evf only. Jesse fixes some trivial static analyzer warnings where BIT() can be used instead of BIT_ULL(). Mitch fixes the virtual channel interface which was using incorrect semantics to remove MAC addresses and would leave incorrect filters active

[net-next 04/11] i40evf: check rings before freeing resources

2015-12-12 Thread Jeff Kirsher
From: Mitch Williams If the driver gets unloaded during reset recovery, it's possible that it will attempt to free resources when they're already free. Add a check to make sure that the Tx and Rx rings actually exist before dereferencing them to free resources.

[PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev ' command

2015-12-12 Thread Dmitrii Shcherbakov
Hello, I noticed a quite an old change which I have a few questions about so maybe somebody could help me out. There are a few lines of code in tc/q_htb.c which were committed originally back in 2004 and have not changed since related to MPU (Minimum Packet Unit). I asked Stephen - this is

Re: [PATCH] drivers: net: cpsw: fix RMII/RGMII mode when used with fixed-link PHY

2015-12-12 Thread Markus Brunner
On Wednesday 09 December 2015 22:31:15 David Rivshin wrote: ... > This patch was originally developed in parallel with 1f71e8c96fc6 to > accomplish the same goal. When I replaced this patch with 1f71e8c96fc6, > I found that it did not work on my hardware (which uses RGMII), so I > am submitting

Re: Checksum offload queries

2015-12-12 Thread Tom Herbert
On Sat, Dec 12, 2015 at 8:41 AM, Sowmini Varadhan wrote: > On (12/11/15 15:50), Tom Herbert wrote: >> layers of encapsulation. For example, suppose send a UDP packet in >> VXLAN in VXLAN, where packet looks like: >> IP|UDP|VXLAN|Eth|IP|UDP|VXLAN|Eth|IP|UDP. I believe

Re: Checksum offload queries

2015-12-12 Thread Sowmini Varadhan
On (12/11/15 15:50), Tom Herbert wrote: > layers of encapsulation. For example, suppose send a UDP packet in > VXLAN in VXLAN, where packet looks like: > IP|UDP|VXLAN|Eth|IP|UDP|VXLAN|Eth|IP|UDP. I believe the kernel can set Without detracting from the fact that you have probably found a bug for

[PATCH V2 net-next] drivers/net: fix eisa_driver probe section mismatch

2015-12-12 Thread Fabian Frederick
Some eisa_driver structures used __init probe functions which generates a warning and could crash if function is called after being deleted. Signed-off-by: Fabian Frederick --- V2: -Remove scsi occurence for net-next(suggested by David S. Miller) -Fix checkpatch

Re: [PATCH 2/3] ser_gigaset: fix deallocation of platform device structure

2015-12-12 Thread Tilman Schmidt
Hi Peter, Am 10.12.2015 um 15:04 schrieb Peter Hurley: --- a/drivers/isdn/gigaset/ser-gigaset.c +++ b/drivers/isdn/gigaset/ser-gigaset.c @@ -370,19 +370,23 @@ static void gigaset_freecshw(struct cardstate *cs) tasklet_kill(>write_tasklet); if (!cs->hw.ser)

Re: [PATCH v3] sh_eth: fix kernel oops in skb_put()

2015-12-12 Thread Sergei Shtylyov
Hello. On 12/6/2015 1:46 AM, David Miller wrote: In a low memory situation the following kernel oops occurs: Unable to handle kernel NULL pointer dereference at virtual address 0050 pgd = 8490c000 [0050] *pgd=4651e831, *pte=, *ppte= Internal error: Oops: 17 [#1]

Re: [net-next 09/11] i40e: clean whole mac filter list

2015-12-12 Thread Sergei Shtylyov
Hello. On 12/12/2015 11:33 AM, Jeff Kirsher wrote: From: Shannon Nelson Clean the whole mac filter list when resetting after an intermediate add or delete push to the firmware. The code had evolved from using a list from the stack to a heap allocation, but the

ICMPv6 sockets

2015-12-12 Thread Jesse White
Hi all, Support for IPPROTO_ICMP socket binds was added in commit c319b4d76b9e583a5d88d6bf190e079c4e43213d which allow for process to send ICMP_ECHO messages (and receive the corresponding ICMP_ECHOREPLY messages) without any special privileges. There doesn't appear to be any similar

IPv6 route to gateway on fe80::1%eth0 when I have fe80::1%br0 locally

2015-12-12 Thread Marc Haber
Hi, one of my systems (Debian unstable, kernel 4.3.2) serves as host to virtualize other systems. It therefore has a Bridge interface br0 to talk to the virtual machines. To have simple configuration, I have configured fe80::1 on br0, and the VMs use that as a default gateway (in the case that

[cavium] weirdness in cnnic_alloc_aligned_dma()

2015-12-12 Thread Al Viro
IMO ptr = (void *)__get_free_pages(GFP_KERNEL, get_order(size)); if ((unsigned long)ptr & 0x07) { free_pages((unsigned long)ptr, get_order(size)); ptr =

Re: NFS issue on v4.4-rc3

2015-12-12 Thread Laurent Pinchart
Ping ? On Saturday 05 December 2015 00:53:24 Laurent Pinchart wrote: > Hello, > > I ran into the following warning when running v4.4-rc3 on a TI OMAP4 > (pandaboard) using nfsroot. > > [ 8063.208526] [ cut here ] > [ 8063.213653] WARNING: CPU: 1 PID: 81 at

Re: [PATCH 0/3] ser_gigaset fixes

2015-12-12 Thread Tilman Schmidt
Hi Paul, Am 10.12.2015 um 12:31 schrieb Paul Bolle: > 1/3 ran into objections and, I think, Alan Cox is working on an > alternative for it. Would you mind resending 2/3 and 3/3 as a two > patches series? Feel free to add > Acked-by: Paul Bolle > > to both. Alan's patch

Re: [PATCH 0/3] ser_gigaset fixes

2015-12-12 Thread Paul Bolle
Hi Tilman, On za, 2015-12-12 at 19:09 +0100, Tilman Schmidt wrote: > Am 10.12.2015 um 12:31 schrieb Paul Bolle: > > 1/3 ran into objections and, I think, Alan Cox is working on an > > alternative for it. Would you mind resending 2/3 and 3/3 as a two > > patches series? Feel free to add > >

Re: [PATCH net-next] bpf, inode: allow for rename and link ops

2015-12-12 Thread David Miller
From: Daniel Borkmann Date: Thu, 10 Dec 2015 22:33:49 +0100 > Add support for renaming and hard links to the fs. Most of this can be > implemented by using simple library operations under the same constraints > that we don't use a reserved name like elsewhere. Linking can

Re: [net-next 00/12][pull request] 10GbE Intel Wired LAN Driver Updates 2015-12-12

2015-12-12 Thread David Miller
From: Jeff Kirsher Date: Sat, 12 Dec 2015 03:14:38 -0800 > This series contains updates to ixgbe only. Pulled, thanks Jeff. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-12-12 Thread Andy Shevchenko
On Tue, Dec 1, 2015 at 7:41 AM, Brent Taylor wrote: > Since commit 8437754c83351d6213c1a47ff029c1126d6042a7, ar->fw is expected to > be pointing to memory allocated by vmalloc. If the api1 method (via > ath6kl_fetch_fw_api1) is used to allocate memory for ar->fw, then

Re: [PATCH 24/28] net: pch_gbe: add device tree support

2015-12-12 Thread Andy Shevchenko
On Mon, Nov 30, 2015 at 6:21 PM, Paul Burton wrote: > Introduce support for retrieving the PHY reset GPIO from device tree, > which will be used on the MIPS Boston development board. This requires > support for probe deferral in order to work correctly, since the order >

Re: ICMPv6 sockets

2015-12-12 Thread Eric Dumazet
On Sat, 2015-12-12 at 11:02 -0500, Jesse White wrote: > Hi all, > > Support for IPPROTO_ICMP socket binds was added in commit > c319b4d76b9e583a5d88d6bf190e079c4e43213d > which allow for process to send ICMP_ECHO messages (and receive the > corresponding ICMP_ECHOREPLY messages) > without any

Re: [PATCH v2] vhost: replace % with & on data path

2015-12-12 Thread Andy Shevchenko
On Fri, Dec 4, 2015 at 10:19 PM, Venkatesh Srinivas wrote: > On Mon, Nov 30, 2015 at 11:15:23AM +0200, Michael S. Tsirkin wrote: >> We know vring num is a power of 2, so use & >> to mask the high bits. >> >> Signed-off-by: Michael S. Tsirkin >> --- > > The

Re: [PATCH] sh_eth: move inline functions to the header file

2015-12-12 Thread Sergei Shtylyov
Hello. On 04/07/2015 10:33 PM, David Miller wrote: The explicitly inline functions belong to the header files, so move cpu_to_edmac() and edmac_to_cpu() into the driver header. While at it, make these functions return 'u32' instead of '__u32'. Signed-off-by: Sergei Shtylyov

[PATCH] sh_eth: uninline sh_eth_{write|read}()

2015-12-12 Thread Sergei Shtylyov
Commit 3365711df024 ("sh_eth: WARN on access to a register not implemented in in a particular chip") added WARN_ON() to sh_eth_{read|write}(), thus making it unacceptable for these functions to be *inline* anymore. Remove *inline* and move the functions from the header to the driver itself.