[PATCH v5 net-next 4/4] ila: Add generic ILA translation facility

2015-12-14 Thread Tom Herbert
This patch implements an ILA tanslation table. This table can be configured with identifier to locator mappings, and can be be queried to resolve a mapping. Queries can be parameterized based on interface, direction (incoming or outoing), and matching locator. The table is implemented using

[PATCH v5 net-next 1/4] ila: Create net/ipv6/ila directory

2015-12-14 Thread Tom Herbert
Create ila directory in preparation for supporting other hooks in the kernel than LWT for doing ILA. This includes: - Moving ila.c to ila/ila_lwt.c - Splitting out some common functions into ila_common.c Signed-off-by: Tom Herbert --- net/ipv6/Makefile | 2 +-

[PATCH v5 net-next 2/4] rhashtable: add function to replace an element

2015-12-14 Thread Tom Herbert
Add the rhashtable_replace_fast function. This replaces one object in the table with another atomically. The hashes of the new and old objects must be equal. Signed-off-by: Tom Herbert --- include/linux/rhashtable.h | 82 ++ 1

[PATCH v5 net-next 3/4] netlink: add a start callback for starting a netlink dump

2015-12-14 Thread Tom Herbert
The start callback allows the caller to set up a context for the dump callbacks. Presumably, the context can then be destroyed in the done callback. Signed-off-by: Tom Herbert --- include/linux/netlink.h | 2 ++ include/net/genetlink.h | 2 ++ net/netlink/af_netlink.c

[PATCH v5 net-next 0/4] ila: Optimization to preserve value of early demux

2015-12-14 Thread Tom Herbert
In the current implementation of ILA, LWT is used to perform translation on both the input and output paths. This is functional, however there is a big performance hit in the receive path. Early demux occurs before the routing lookup (a hit actually obviates the route lookup). Therefore the stack

Re: [PATCH] net: emac: emac gigabit ethernet controller driver

2015-12-14 Thread Florian Fainelli
On 14/12/15 16:19, Gilad Avidov wrote: [snip] > + "sgmii_irq"; > + qcom,emac-gpio-mdc = < 123 0>; > + qcom,emac-gpio-mdio = < 124 0>; > + qcom,emac-tstamp-en; > + qcom,emac-ptp-frac-ns-adj = <12500 1>; > +

Re: [PATCH net] pptp: validate sockaddr_len before binding

2015-12-14 Thread Hannes Frederic Sowa
On 14.12.2015 23:58, Cong Wang wrote: > On Mon, Dec 14, 2015 at 2:45 PM, Hannes Frederic Sowa > wrote: >> diff --git a/drivers/net/ppp/pptp.c b/drivers/net/ppp/pptp.c >> index fc69e41d09506e..f9ffdf070ad807 100644 >> --- a/drivers/net/ppp/pptp.c >> +++

WARN trace - skb_warn_bad_offload - vxlan - large udp packet - udp checksum disabled

2015-12-14 Thread Nelson, Shannon
Using a slightly modified version of udpspam (see diff below - hopefully not mangled by corporate email servers), where I set the SO_NO_CHECK socket option and can specify a large buffer size, I can reliably get the following WARN trace. I have reproduced this on both ixgbe and i40e drivers

RE: [PATCH net-next] net, cgroup: cgroup_sk_updat_lock was missing initializer

2015-12-14 Thread Dexuan Cui
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, December 15, 2015 3:21 > To: t...@kernel.org > Cc: Dexuan Cui ; pa...@netfilter.org; ka...@trash.net; > kad...@blackhole.kfki.hu; dan...@iogearbox.net; daniel.wag...@bmw-carit.de; >

[PATCH] gianfar: Don't enable RX Filer if not supported

2015-12-14 Thread Hamish Martin
After commit 15bf176db1fb ("gianfar: Don't enable the Filer w/o the Parser"), 'TSEC' model controllers (for example as seen on MPC8541E) always have 8 bytes stripped from the front of received frames. Only 'eTSEC' gianfar controllers have the RX Filer capability (amongst other enhancements).

linux-next: manual merge of the net-next tree with the net tree

2015-12-14 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/geneve.c between commit: a322a1bcf329 ("geneve: Fix IPv6 xmit stats update.") from the net tree and commit: abe492b4f50c ("geneve: UDP checksum configuration via netlink") from the net-next tree. I

RE: [PATCH 1/1] net: sctp: dynamically enable or disable pf state

2015-12-14 Thread David Laight
From: zyjzyj2...@gmail.com > Sent: 11 December 2015 09:06 ... > +pf_enable - INTEGER > + Enable or disable pf state. A value of pf_retrans > path_max_retrans > + also disables pf state. That is, one of both pf_enable and > + pf_retrans > path_max_retrans can disable pf state. Since

RE: use-after-free in sctp_do_sm

2015-12-14 Thread David Laight
From: Vlad Yasevich > Sent: 11 December 2015 18:38 ... > > Found a similar place in abort primitive handling like in this last > > patch update, it's probably the issue you're still triggering. > > > > Also found another place that may lead to this use after free, in case > > we receive a packet

[PATCH] ath9k_htc: fix handling return value of ath9k_hw_calibrate

2015-12-14 Thread Andrzej Hajda
The function can return negative values in case of error. Its result should be then tested for such case. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107

[PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert_port

2015-12-14 Thread Andrzej Hajda
The function can return negative values, so its result should be assigned to signed variable. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by:

Re: sbc8641: drop bogus PHY IRQ entries from DTS file

2015-12-14 Thread Michael Ellerman
On Tue, 2015-08-12 at 22:44:02 UTC, Paul Gortmaker wrote: > This file was originally cloned off of the MPC8641D-HPCN reference > platform, which actually had a PHY IRQ line connected. However > this board does not. The bogus entry was largely inert and went > undetected until commit

Information leak in pptp_bind

2015-12-14 Thread Dmitry Vyukov
Hello, The following program leak various uninit garbage including kernel addresses and whatever is on kernel stack, in particular defeating ASLR. The issue is in pptp_bind which does not verify sockaddr_len #include #include #include #include #include #include #include #include #include

[PATCH 5/6] netfilter: nf_dup: add missing dependencies with NF_CONNTRACK

2015-12-14 Thread Pablo Neira Ayuso
CONFIG_NF_CONNTRACK=m CONFIG_NF_DUP_IPV4=y results in: net/built-in.o: In function `nf_dup_ipv4': >> (.text+0xd434f): undefined reference to `nf_conntrack_untracked' Reported-by: kbuild test robot Signed-off-by: Pablo Neira Ayuso ---

[PATCH 6/6] netfilter: nf_tables: use reverse traversal commit_list in nf_tables_abort

2015-12-14 Thread Pablo Neira Ayuso
From: Xin Long When we use 'nft -f' to submit rules, it will build multiple rules into one netlink skb to send to kernel, kernel will process them one by one. meanwhile, it add the trans into commit_list to record every commit. if one of them's return value is -EAGAIN,

Re: [PATCH v6 0/4] stmmac: create of compatible mdio bus for stmacc driver

2015-12-14 Thread David Miller
From: Phil Reid Date: Mon, 14 Dec 2015 11:31:58 +0800 > Provide ability to specify a fixed phy in the device tree and > retain the mdio bus if no phy is found. This is needed where > a dsa is connected via a fixed phy and uses the mdio bus for config. > Fixed ptp ref

[net-next 7/9] e1000e: Do not read ICR in Other interrupt

2015-12-14 Thread Jeff Kirsher
From: Benjamin Poirier Removes the ICR read in the other interrupt handler, uses EIAC to autoclear the Other bit from ICR and IMS. This allows us to avoid interference with Rx and Tx interrupts in the Other interrupt handler. The information read from ICR is not needed. IMS

[net-next 0/9][pull request] 1GbE Intel Wired LAN Driver Updates 2015-12-14

2015-12-14 Thread Jeff Kirsher
This series contains updates to e1000e and igb. Alex Duyck changes e1000_up() to void since it always returned 0, also by making it void, we can drop some code since we no longer have to worry about non-zero return values. Aaron Sierra removes GS40G specific defines and functions since the i210

[PATCH iproute2 -next] bpf: minor fix in api and bpf_dump_error() usage

2015-12-14 Thread Daniel Borkmann
Fix a whitespace in bpf_dump_error() usage, and also a missing closing bracket in ntohl() macro for eBPF programs. Signed-off-by: Daniel Borkmann --- include/bpf_api.h | 2 +- tc/tc_bpf.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v3 1/4] geneve: Add geneve udp port offload for ethernet devices

2015-12-14 Thread Singhai, Anjali
On 12/11/2015 7:11 PM, Tom Herbert wrote: On Tue, Dec 8, 2015 at 10:12 AM, Anjali Singhai Jain wrote: Add ndo_ops to add/del UDP ports to a device that supports geneve offload. v3: Add some more comments about the use of the new ndo ops. Signed-off-by: Anjali

Re: [PATCH 0/6] netfilter fixes for net

2015-12-14 Thread David Miller
From: Pablo Neira Ayuso Date: Mon, 14 Dec 2015 12:25:40 +0100 > The following patchset contains Netfilter fixes for you net tree, > specifically for nf_tables and nfnetlink_queue, they are: Pulled, thanks a lot Pablo. -- To unsubscribe from this list: send the line

[PATCH net-next] net, cgroup: cgroup_sk_updat_lock was missing initializer

2015-12-14 Thread Tejun Heo
bd1060a1d671 ("sock, cgroup: add sock->sk_cgroup") added global spinlock cgroup_sk_update_lock but erroneously skipped initializer leading to uninitialized spinlock warning. Fix it by using DEFINE_SPINLOCK(). Signed-off-by: Tejun Heo Reported-by: Dexuan Cui

[PATCH 2/2] net: vxlan: enable local checksum offload on HW_CSUM devices

2015-12-14 Thread Edward Cree
Signed-off-by: Edward Cree --- drivers/net/vxlan.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 6369a57..c1660d6 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -1785,6 +1785,9 @@

[PATCH 1/2] net: udp: local checksum offload for encapsulation

2015-12-14 Thread Edward Cree
The arithmetic properties of the ones-complement checksum mean that a correctly checksummed inner packet, including its checksum, has a ones complement sum depending only on whatever value was used to initialise the checksum field before checksumming (in the case of TCP and UDP, this is the

Re: [PATCH iproute2] ip, route: fix minor compile warning

2015-12-14 Thread Phil Sutter
On Mon, Dec 14, 2015 at 04:34:29PM +0100, Daniel Borkmann wrote: > Seems like gcc (4.8.3) doesn't catch this false positive, triggering > after 0f7543322c5f ("route: ignore RTAX_HOPLIMIT of value -1"): > > iproute.c: In function 'print_route': > iproute.c:301:12: warning: 'val' may be used

Re: [PATCH iproute2] ip, route: fix minor compile warning

2015-12-14 Thread Daniel Borkmann
On 12/14/2015 04:51 PM, Phil Sutter wrote: On Mon, Dec 14, 2015 at 04:34:29PM +0100, Daniel Borkmann wrote: Seems like gcc (4.8.3) doesn't catch this false positive, triggering after 0f7543322c5f ("route: ignore RTAX_HOPLIMIT of value -1"): iproute.c: In function 'print_route':

Re: Another pppoe-related crash

2015-12-14 Thread Guillaume Nault
On Fri, Dec 11, 2015 at 05:07:54PM +0200, Andrew wrote: > I've got another pppoe-related crash on one PPPoE BRAS. > > Kernel is 4.1.13 with patch "pppoe: fix memory corruption in padt work > structure" > Commit 1acea4f6ce1b ("ppp: fix pppoe_dev deletion condition in pppoe_release()") is missing

[RFC PATCH net-next 0/2] Local checksum offload for VXLAN

2015-12-14 Thread Edward Cree
When the inner packet checksum is offloaded, the outer UDP checksum is easy to calculate as it doesn't depend on the payload (because the inner checksum cancels out everything from the inner packet except the pseudo header). Thus, transmit checksums for VXLAN (and in principle other

[PATCH iproute2] ip, route: fix minor compile warning

2015-12-14 Thread Daniel Borkmann
Seems like gcc (4.8.3) doesn't catch this false positive, triggering after 0f7543322c5f ("route: ignore RTAX_HOPLIMIT of value -1"): iproute.c: In function 'print_route': iproute.c:301:12: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized] features &=

Re: [V2 PATCH 1/1] net: sctp: dynamically enable or disable pf state

2015-12-14 Thread Marcelo Ricardo Leitner
On Mon, Dec 14, 2015 at 02:22:19PM +0800, zyjzyj2...@gmail.com wrote: > From: Zhu Yanjun > > As we all know, the value of pf_retrans >= max_retrans_path can > disable pf state. The variables of pf_retrans and max_retrans_path > can be changed by the user space application.

[PATCH net] net: add validation for the socket syscall protocol argument

2015-12-14 Thread Hannes Frederic Sowa
郭永刚 reported that one could simply crash the kernel as root by using a simple program: int socket_fd; struct sockaddr_in addr; addr.sin_port = 0; addr.sin_addr.s_addr = INADDR_ANY; addr.sin_family = 10; socket_fd = socket(10,3,0x4000);

Re: [PATCH v5 net-next 4/4] ila: Add generic ILA translation facility

2015-12-14 Thread David Miller
From: Tom Herbert Date: Mon, 14 Dec 2015 15:56:48 -0800 > +static int alloc_ila_locks(struct ila_net *ilan, gfp_t gfp) gfp is always GFP_KERNEL, thus this flexibility is never necessary. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

Re: [PATCH v2] net/macb: add support for resetting PHY using GPIO

2015-12-14 Thread Florian Fainelli
On December 14, 2015 2:56:34 PM PST, Rob Herring wrote: >On Fri, Dec 11, 2015 at 11:34:53AM +0100, Gregory CLEMENT wrote: >> With device tree it is no more possible to reset the PHY at board >> level. Furthermore, doing in the driver allow to power down the PHY >when >> the

Re: [Patch net] pptp: verify sockaddr_len in pptp_bind() and pptp_connect()

2015-12-14 Thread David Miller
From: Cong Wang Date: Mon, 14 Dec 2015 13:48:36 -0800 > Reported-by: Dmitry Vyukov > Signed-off-by: Cong Wang Applied and queued up for -stable, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev"

Re: [PATCH net] skbuff: Fix offset error in skb_reorder_vlan_header

2015-12-14 Thread David Miller
From: Vladislav Yasevich Date: Mon, 14 Dec 2015 17:44:10 -0500 > skb_reorder_vlan_header is called after the vlan header has > been pulled. As a result the offset of the begining of > the mac header has been incrased by 4 bytes (VLAN_HLEN). > When moving the mac addresses,

Re: [PATCH] sh_eth: fix descriptor access endianness

2015-12-14 Thread David Miller
From: Sergei Shtylyov Date: Sun, 13 Dec 2015 23:05:07 +0300 > The driver never calls cpu_to_edmac() when writing the descriptor address > and edmac_to_cpu() when reading it, although it should -- fix this. > > Note that the frame/buffer length descriptor

Re: [PATCH] sh_eth: fix TX buffer byte-swapping

2015-12-14 Thread David Miller
From: Sergei Shtylyov Date: Sun, 13 Dec 2015 21:27:04 +0300 > For the little-endian SH771x kernels the driver has to byte-swap the RX/TX > buffers, however yet unset physcial address from the TX descriptor is used > to call sh_eth_soft_swap(). Use 'skb->data'

Re: [PATCH net] ravb: Add disable 10base

2015-12-14 Thread David Miller
From: Yoshihiro Kaneko Date: Mon, 14 Dec 2015 00:15:58 +0900 > From: Kazuya Mizuguchi > > Ethernet AVB does not support 10 Mbps transfer speed. > > Signed-off-by: Kazuya Mizuguchi > Signed-off-by:

Re: [PATCH RFC 00/26] Phylink & SFP support

2015-12-14 Thread Dustin Byford
On Mon Dec 07 17:35, Russell King - ARM Linux wrote: > Hi, Hello. > SFP modules are hot-pluggable ethernet transceivers; they can be > detected at runtime and accordingly configured. There are a range of > modules offering many different features. > > Some SFP modules have PHYs conventional

[PATCH] 82xx: FCC: Fixing a bug causing to FCC port lock-up

2015-12-14 Thread Martin Roth
The patch fixes FCC port lock-up, which occurs as a result of a bug during underrun/collision handling. Within the tx_startup() function in mac-fcc.c, the address of last BD is not calculated correctly. As a result of wrong calculation of the last BD address, the next transmitted BD may be set to

Re: [PATCH v5 net-next 4/4] ila: Add generic ILA translation facility

2015-12-14 Thread Florian Westphal
Tom Herbert wrote: > +static int ila_add_mapping(struct net *net, struct ila_xlat_params *p) > +{ > + struct ila_net *ilan = net_generic(net, ila_net_id); > + struct ila_map *ila, *head; > + spinlock_t *lock = ila_get_lock(ilan, p->identifier); > + int err =

Re: [PATCH net] net: fix IP early demux races

2015-12-14 Thread David Miller
From: Eric Dumazet Date: Mon, 14 Dec 2015 14:08:53 -0800 > From: Eric Dumazet > > David Wilder reported crashes caused by dst reuse. > > > I am seeing a crash on a distro V4.2.3 kernel caused by a double > release of a dst_entry. In

Fwd: Query regarding Coverity tool

2015-12-14 Thread pavi1729
Hi, May I know if the community uses the Coverity tool and, if yes where can I find a repo of Coverity scans of kernels and IGNORE LIST; cause there obviously be false positives. Cheers, Pavi -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

[net-next 6/9] e1000e: Remove unreachable code

2015-12-14 Thread Jeff Kirsher
From: Benjamin Poirier msi-x interrupts are not shared so there's no need to check if the interrupt was really from this adapter. Signed-off-by: Benjamin Poirier Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher

[net-next 9/9] e1000e: Fix msi-x interrupt automask

2015-12-14 Thread Jeff Kirsher
From: Benjamin Poirier Since the introduction of 82574 support in e1000e, the driver has worked on the assumption that msi-x interrupt generation is automatically disabled after each irq. As it turns out, this is not the case. Currently, rx interrupts can fire multiple times

[net-next 4/9] igb: Improve cable length function for I210, etc.

2015-12-14 Thread Jeff Kirsher
From: Joe Schultz Previously, the PHY-specific code to get the cable length for the I210 internal and related PHYs was reporting the cable length of a single pair and reporting it as the min, max, and total cable length. Update it so that all four pairs are checked so the

[net-next 8/9] e1000e: Do not write lsc to ics in msi-x mode

2015-12-14 Thread Jeff Kirsher
From: Benjamin Poirier In msi-x mode, there is no handler for the lsc interrupt so there is no point in writing that to ics now that we always assume Other interrupts are caused by lsc. Reviewed-by: Jasna Hodzic Signed-off-by: Benjamin Poirier

[net-next 3/9] igb: Don't add PHY address to PCDL address

2015-12-14 Thread Jeff Kirsher
From: Aaron Sierra There is no reason to add the PHY address into the PCDL register address. Signed-off-by: Aaron Sierra Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher ---

[net-next 2/9] igb: Remove GS40G specific defines/functions

2015-12-14 Thread Jeff Kirsher
From: Aaron Sierra The I210 internal PHY can be accessed just as well with the access functions shared by 82580, I350, and I354 devices. A side effect of relying on the common functions, is that I210 cable length support is folded back into the common case which effectively

[net-next 5/9] igb: Explicitly label self-test result indices

2015-12-14 Thread Jeff Kirsher
From: Joe Schultz Previously, the ethtool self-test gstrings/data arrays were accessed via hardcoded indices, which made the code difficult to follow. This patch replaces the hardcoded values with enum-based labels. Signed-off-by: Joe Schultz

[net-next 1/9] e1000e: Switch e1000e_up to void, drop code checking for error result

2015-12-14 Thread Jeff Kirsher
From: Alexander Duyck The function e1000e_up always returns 0. As such we can convert it to a void and just ignore the results. This allows us to drop some code in a couple spots as we no longer need to worry about non-zero return values. Signed-off-by: Alexander Duyck

RE: [PATCHSET v4] netfilter, cgroup: implement cgroup2 path match in xt_cgroup

2015-12-14 Thread Dexuan Cui
|6 + > net/core/dev.c |3 > net/core/netclassid_cgroup.c | 11 +- > net/core/netprio_cgroup.c| 19 > net/core/scm.c |4 > net/core/sock.c

[RFCv4 bluetooth-next 2/2] ipv6: add 6co as icmpv6 userspace option

2015-12-14 Thread Alexander Aring
This patch adds the 6LoWPAN Context Option (6CO) as userspace option to processing such options inside RA messages in userspace. Cc: David S. Miller Cc: Alexey Kuznetsov Cc: James Morris Cc: Hideaki YOSHIFUJI

[RFCv4 bluetooth-next 0/2] 6lowpan: 6co and stateful compression support

2015-12-14 Thread Alexander Aring
Hi, this patch series adds stateful compression support and add 6co option as a new userspace option for processing RA messages inside userspace. I am not sure if "6CO" handling inside userspace is the best option here. I will send also "radvd" patches which introduce a very "basic" support for

Re: use-after-free in sctp_do_sm

2015-12-14 Thread Vlad Yasevich
On 12/14/2015 04:50 AM, David Laight wrote: > From: Vlad Yasevich >> Sent: 11 December 2015 18:38 > ... >>> Found a similar place in abort primitive handling like in this last >>> patch update, it's probably the issue you're still triggering. >>> >>> Also found another place that may lead to this

[RFCv4 bluetooth-next 1/2] 6lowpan: iphc: add support for stateful compression

2015-12-14 Thread Alexander Aring
This patch introduce support for IPHC stateful address compression. It will offer the context table via one debugfs entry. Example to setup a context id: A "cat /sys/kernel/debug/6lowpan/lowpan0/ctx_table" will display all contexts which are available. Example: ID ipv6-address/prefix-length

Re: [V2 PATCH 1/1] net: sctp: dynamically enable or disable pf state

2015-12-14 Thread Vlad Yasevich
On 12/14/2015 01:22 AM, zyjzyj2...@gmail.com wrote: > From: Zhu Yanjun > > As we all know, the value of pf_retrans >= max_retrans_path can > disable pf state. The variables of pf_retrans and max_retrans_path > can be changed by the user space application. > > Sometimes the

[PATCH] net: phy: mdio-mux: Check return value of mdiobus_alloc()

2015-12-14 Thread Tobias Klauser
mdiobus_alloc() might return NULL, but its return value is not checked in mdio_mux_init(). This could potentially lead to a NULL pointer dereference. Fix it by checking the return value Fixes: 0ca2997d1452 ("netdev/of/phy: Add MDIO bus multiplexer support.") Signed-off-by: Tobias Klauser

[PATCH net] openvswitch: fix trivial comment typo

2015-12-14 Thread Paolo Abeni
The commit 33db4125ec74 ("openvswitch: Rename LABEL->LABELS") left over an old OVS_CT_ATTR_LABEL instance, fix it. Fixes: 33db4125ec74 ("openvswitch: Rename LABEL->LABELS") Signed-off-by: Paolo Abeni --- include/uapi/linux/openvswitch.h | 2 +- 1 file changed, 1 insertion(+),

[RFC radvd 2/2] radvd: rework 6CO handling

2015-12-14 Thread Alexander Aring
Current issues with the 6CO handling: - Doesn't work on little endian at my side because forgotten byteordering handling at bitfields. - There can be multiple 6CO options. Up to 16 6CO options at maximum. - It doesn't work as it should. Maybe for some use-case somebody need that, but 6CO

[RFC radvd 0/2] radvd: 6lowpan 6CO testing patches

2015-12-14 Thread Alexander Aring
Hi, this patch is for testing 6CO fields in RA messages with the help of radvd. I tested it with the following configuration and two or more nodes which can directly reach each other. On one node (6LBR, if more 6LBR they need to have the same context information!): interface lowpan0 {

[RFC radvd 1/2] device-linux: replace ARPHRD_IEEE802154 to ARPHRD_6LOWPAN

2015-12-14 Thread Alexander Aring
This patch changes the ARPHRD_IEEE802154 to ARPHRD_6LOWPAN. The IEEE 802.15.4 6lowpan module changed the ARPHRD_IEEE802154 type to ARPHRD_6LOWPAN. Nowadays it's use ARPHRD_6LOWPAN which is also used by BTLE 6LoWPAN. Both interfaces uses an EUI64 address and the handling to get the link-layer

Re: [PATCH 1/1] net: bonding: remove redudant brackets

2015-12-14 Thread Nicolas Dichtel
Le 12/12/2015 02:03, David Miller a écrit : From: From: yzhu1 Signed-off-by: yzhu1 Does not apply to the net-next tree. Also three different emails ... -- To unsubscribe from this list: send the line "unsubscribe netdev"

Re: [PATCH 1/2] vlan: Fix untag operations of stacked vlans with REORDER_HEADER off

2015-12-14 Thread Nicolas Dichtel
Le 16/11/2015 21:43, Vladislav Yasevich a écrit : When we have multiple stacked vlan devices all of which have turned off REORDER_HEADER flag, the untag operation does not locate the ethernet addresses correctly for nested vlans. The reason is that in case of REORDER_HEADER flag being off, the

Re: Double free of dst_entry in ipv4_dst_destroy()

2015-12-14 Thread Eric Dumazet
On Mon, 2015-12-14 at 11:28 -0500, dwil...@us.ibm.com wrote: > Eric - > With this patch applied the test ran clean for 2 days. > > Thanks for your help. Excellent ! Thanks a lot David, I will submit it formally with your 'Reported-by' and 'Tested-by' I have no idea why this took so long to

[PATCH net] netlink: fix boolean evaluation on bound

2015-12-14 Thread Hannes Frederic Sowa
portid may be 0, thus bound will set the flag to false for in-kernel created netlink sockets. Fixes: da314c9923fed55 ("netlink: Replace rhash_portid with bound") Cc: Herbert Xu Signed-off-by: Hannes Frederic Sowa --- This patch should not

Re: [PATCH 1/2] net: udp: local checksum offload for encapsulation

2015-12-14 Thread Tom Herbert
On Mon, Dec 14, 2015 at 7:13 AM, Edward Cree wrote: > The arithmetic properties of the ones-complement checksum mean that a > correctly checksummed inner packet, including its checksum, has a ones > complement sum depending only on whatever value was used to initialise >

Re: [PATCH net] openvswitch: fix trivial comment typo

2015-12-14 Thread Joe Stringer
On 14 December 2015 at 05:29, Paolo Abeni wrote: > The commit 33db4125ec74 ("openvswitch: Rename LABEL->LABELS") left > over an old OVS_CT_ATTR_LABEL instance, fix it. > > Fixes: 33db4125ec74 ("openvswitch: Rename LABEL->LABELS") > Signed-off-by: Paolo Abeni

[PATCH v3 net] ravb: clear RIC1 in init instead of stop

2015-12-14 Thread Yoshihiro Kaneko
From: Kazuya Mizuguchi AVB-DMAC Receive FIFO Warning interrupt is not enabled, so it is not necessary to disable the interrupt in ravb_close(). On the other hand, this patch disables the interrupt in ravb_dmac_init() to prevent the possibility that the interrupt

Re: [PATCH net] netlink: fix boolean evaluation on bound

2015-12-14 Thread Herbert Xu
On Mon, Dec 14, 2015 at 05:55:25PM +0100, Hannes Frederic Sowa wrote: > portid may be 0, thus bound will set the flag to false for in-kernel > created netlink sockets. > > Fixes: da314c9923fed55 ("netlink: Replace rhash_portid with bound") > Cc: Herbert Xu >

Re: Double free of dst_entry in ipv4_dst_destroy()

2015-12-14 Thread dwilder
Eric - With this patch applied the test ran clean for 2 days. Thanks for your help. Quoting Eric Dumazet : On Fri, 2015-12-11 at 07:48 -0800, Eric Dumazet wrote: On Fri, 2015-12-11 at 06:23 -0800, Eric Dumazet wrote: > On Sun, 2015-12-06 at 17:58 -0800, Eric Dumazet

Re: [PATCH v2 net] ravb: Remove clear unhandled interrupt

2015-12-14 Thread Yoshihiro Kaneko
Hi, 2015-12-14 1:25 GMT+09:00 Sergei Shtylyov : > Hello. > > On 12/13/2015 06:12 PM, Yoshihiro Kaneko wrote: > >The subject doesn't seem to reflect what the patch is doing. > > >> From: Kazuya Mizuguchi >> >> AVB-DMAC

Re: [PATCH v3 net] ravb: clear RIC1 in init instead of stop

2015-12-14 Thread Sergei Shtylyov
On 12/14/2015 07:24 PM, Yoshihiro Kaneko wrote: From: Kazuya Mizuguchi AVB-DMAC Receive FIFO Warning interrupt is not enabled, so it is not necessary to disable the interrupt in ravb_close(). On the other hand, this patch disables the interrupt in

Re: [PATCHv2 net-next] ipv6: allow routes to be configured with expire values

2015-12-14 Thread Hannes Frederic Sowa
Hi, On 14.12.2015 12:48, Xin Long wrote: >> >> This is the wrong way to do this. >> >> Currently we only ever dump rta_cacheinfo values to the user. >> >> If we use it to set things, we have to completely consider every >> member of that structure as potentially having meaning either >> intended

Re: [PATCH net] netlink: fix boolean evaluation on bound

2015-12-14 Thread Hannes Frederic Sowa
On 14.12.2015 18:06, Herbert Xu wrote: > On Mon, Dec 14, 2015 at 05:55:25PM +0100, Hannes Frederic Sowa wrote: >> portid may be 0, thus bound will set the flag to false for in-kernel >> created netlink sockets. >> >> Fixes: da314c9923fed55 ("netlink: Replace rhash_portid with bound") >> Cc:

[PATCH v5 2/4] net: diag: split inet_diag_dump_one_icsk into two

2015-12-14 Thread Lorenzo Colitti
Currently, inet_diag_dump_one_icsk finds a socket and then dumps its information to userspace. Split it into a part that finds the socket and a part that dumps the information. Signed-off-by: Lorenzo Colitti --- include/linux/inet_diag.h | 5 + net/ipv4/inet_diag.c

Re: [PATCH] sh_eth: fix descriptor access endianness

2015-12-14 Thread Sergei Shtylyov
Hello. On 12/13/2015 11:05 PM, Sergei Shtylyov wrote: The driver never calls cpu_to_edmac() when writing the descriptor address and edmac_to_cpu() when reading it, although it should -- fix this. Note that the frame/buffer length descriptor field accesses also need fixing but since they are

[PATCH v5 1/4] net: diag: Add the ability to destroy a socket.

2015-12-14 Thread Lorenzo Colitti
This adds a diag_destroy pointer to struct proto that allows a socket to be administratively closed without any action from the process owning the socket or the socket protocol. This allows a privileged userspace process, such as a connection manager or system administration tool, to close

Re: Add a SOCK_DESTROY operation to close sockets from userspace

2015-12-14 Thread Lorenzo Colitti
Here is a an updated version. The external behaviour of this patchset is the same as v4; for more details, see that cover letter at http://www.spinics.net/lists/netdev/msg354303.html . This version fixes two bugs spotted by Eric, and implements Tom's suggestion of making the socket destroy code a

Re: [PATCH net] ravb: Add disable 10base

2015-12-14 Thread Sergei Shtylyov
Hello. On 12/13/2015 06:15 PM, Yoshihiro Kaneko wrote: From: Kazuya Mizuguchi Ethernet AVB does not support 10 Mbps transfer speed. Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko ---

[PATCH v5 4/4] net: diag: Support destroying TCP sockets.

2015-12-14 Thread Lorenzo Colitti
This implements SOCK_DESTROY for TCP sockets. It causes all blocking calls on the socket to fail fast with ECONNABORTED and causes a protocol close of the socket. It informs the other end of the connection by sending a RST, i.e., initiating a TCP ABORT as per RFC 793. ECONNABORTED was chosen for

[PATCH v5 3/4] net: diag: Support SOCK_DESTROY for inet sockets.

2015-12-14 Thread Lorenzo Colitti
This passes the SOCK_DESTROY operation to the underlying protocol diag handler, or returns -EINVAL if that handler does not define a destroy operation. Most of this patch is just renaming functions. This is not strictly necessary, but it would be fairly counterintuitive to have the code to

Re: [PATCH] sh_eth: uninline sh_eth_{write|read}()

2015-12-14 Thread David Miller
From: Sergei Shtylyov Date: Sun, 13 Dec 2015 01:44:50 +0300 > Commit 3365711df024 ("sh_eth: WARN on access to a register not implemented in > in a particular chip") added WARN_ON() to sh_eth_{read|write}(), thus making > it unacceptable for these functions

Re: [RFC] ipv6: use a random ifid for headerless devices

2015-12-14 Thread Hannes Frederic Sowa
Hello, On 08.12.2015 19:57, Bjørn Mork wrote: > Hannes Frederic Sowa writes: >> On 05.12.2015 20:02, Bjørn Mork wrote: >>> Hannes Frederic Sowa writes: On Thu, Dec 3, 2015, at 20:29, Bjørn Mork wrote: > After looking more at

Re: [RFC] ipv6: use a random ifid for headerless devices

2015-12-14 Thread Bjørn Mork
Hannes Frederic Sowa writes: > Sorry for answering so late... No problem. There is no rush here AFAICS. Thanks for taking the time to look at this. > What do you think about simply using IN6_ADDR_GEN_MODE_RANDOM? Yes, that's fine with me (actually what I first

[Patch net] pptp: verify sockaddr_len in pptp_bind() and pptp_connect()

2015-12-14 Thread Cong Wang
Reported-by: Dmitry Vyukov Signed-off-by: Cong Wang --- drivers/net/ppp/pptp.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ppp/pptp.c b/drivers/net/ppp/pptp.c index fc69e41..597c53e 100644 --- a/drivers/net/ppp/pptp.c +++

Re: [PATCH v4 1/5] geneve: Add geneve udp port offload for ethernet devices

2015-12-14 Thread Singhai, Anjali
Resending the series with a cover-letter that got missed. Thanks Anjali On 12/14/2015 11:57 AM, Anjali Singhai Jain wrote: Add ndo_ops to add/del UDP ports to a device that supports geneve offload. v2: Comment fix. Signed-off-by: Anjali Singhai Jain Signed-off-by:

[PATCH net-next] ipv6: addrconf: drop ieee802154 specific things

2015-12-14 Thread Alexander Aring
This patch removes ARPHRD_IEEE802154 from addrconf handling. In the earlier days of 802.15.4 6LoWPAN, the interface type was ARPHRD_IEEE802154 which introduced several issues, because 802.15.4 interfaces used the same type. Since commit 965e613d299c ("ieee802154: 6lowpan: fix ARPHRD to

re: [PATCH] chelsio: add support for other 10G boards

2015-12-14 Thread Dan Carpenter
Hello Stephen Hemminger, The patch f1d3d38af757: "[PATCH] chelsio: add support for other 10G boards" from Dec 1, 2006, leads to the following static checker warning: drivers/net/ethernet/chelsio/cxgb/subr.c:630 t1_link_start() warn: was shift intended here

[PATCH v5 4/5] geneve: Add geneve_get_rx_port support

2015-12-14 Thread Anjali Singhai Jain
This patch adds an op that the drivers can call into to get existing geneve ports. Signed-off-by: Anjali Singhai Jain --- drivers/net/geneve.c | 24 include/net/geneve.h | 8 2 files changed, 32 insertions(+) diff --git

[ANNOUNCE] Another round of NetDev 1.1 updates

2015-12-14 Thread Pablo Neira Ayuso
Hi! We would like to share with you another round of incremental updates on accepted sessions in netdev 1.1, the community-driven Linux networking conference held back-to-back with netconf in Sevilla, Spain, February 10-12, 2016. = Keynote = * "Hardware Checksumming: Less is More" (David S.

[PATCH v5 0/5] Add support for Geneve udp port offload

2015-12-14 Thread Anjali Singhai Jain
This patch series adds new ndo ops for Geneve add/del port, so as to help offload Geneve tunnel functionalities such as RX checksum, RSS, filters etc. i40e driver has been tested with the changes to make sure the offloads happen. We do understand that this is not the ideal solution and most

[PATCH v5 3/5] i40e: Kernel dependency update for i40e to support geneve offload

2015-12-14 Thread Anjali Singhai Jain
Update the Kconfig file with dependency for supporting GENEVE tunnel offloads. Signed-off-by: Anjali Singhai Jain Signed-off-by: Kiran Patil --- drivers/net/ethernet/intel/Kconfig | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH v5 2/5] i40e: geneve tunnel offload support

2015-12-14 Thread Anjali Singhai Jain
This patch adds driver hooks to implement ndo_ops to add/del udp port in the HW to identify GENEVE tunnels. Signed-off-by: Anjali Singhai Jain Signed-off-by: Kiran Patil --- drivers/net/ethernet/intel/i40e/i40e.h | 16 +--

[PATCH v5 1/5] geneve: Add geneve udp port offload for ethernet devices

2015-12-14 Thread Anjali Singhai Jain
Add ndo_ops to add/del UDP ports to a device that supports geneve offload. v2: Comment fix. Signed-off-by: Anjali Singhai Jain Signed-off-by: Kiran Patil --- drivers/net/geneve.c | 23 +++ include/linux/netdevice.h | 20

[PATCH v5 5/5] i40e: Call geneve_get_rx_port to get the existing Geneve ports

2015-12-14 Thread Anjali Singhai Jain
This patch adds a call to geneve_get_rx_port in i40e so that when it comes up it can learn about the existing geneve tunnels. Signed-off-by: Anjali Singhai Jain --- drivers/net/ethernet/intel/i40e/i40e_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

  1   2   >