[PATCH net] sctp: allow setting SCTP_SACK_IMMEDIATELY by the application

This patch extends commit b93d6471748d ("sctp: implement the sender side for SACK-IMMEDIATELY extension") as it didn't white list SCTP_SACK_IMMEDIATELY on sctp_msghdr_parse(), causing it to be understood as an invalid flag and returning -EINVAL to the application. Note that the actual handling of

Re: [Xen-devel] [PATCH 1/3] xen-netback: fix license ident used in MODULE_LICENSE

From: One Thousand Gnomes Date: Fri, 22 Jan 2016 20:25:21 + >> The fact what include/linux/license.h:license_is_gpl_compatible includes >> "Dual MIT/GPL" as an option seems to suggest that it is enough of a thing >> to be validly used as the contents of a

Re: Has RFC4821 been implemented?

Hi, On 22.01.2016 20:50, Tom Herbert wrote: Found it: tcp_mtu_probing Exactly. On Fri, Jan 22, 2016 at 11:39 AM, Tom Herbert wrote: This came up on in one of the IETF mailing lists in the context that PMTUD doesn't really work on the Internet so PLPMTUD is the way

Re: [PATCH 00/33] Compile-time stack metadata validation

On Fri, Jan 22, 2016 at 02:40:35PM -0600, Chris J Arges wrote: > On Fri, Jan 22, 2016 at 01:14:47PM -0600, Josh Poimboeuf wrote: > > On Fri, Jan 22, 2016 at 11:43:48AM -0600, Chris J Arges wrote: > > > On Thu, Jan 21, 2016 at 04:49:04PM -0600, Josh Poimboeuf wrote: > > > > This is v16 of the

Re: net: use-after-free in recvmmsg

Em Fri, Jan 22, 2016 at 09:39:53PM +0100, Dmitry Vyukov escreveu: > While running syzkaller fuzzer I've hit the following use-after-free: > Call Trace: > [] __asan_report_load8_noabort+0x3e/0x40 > mm/kasan/report.c:295 > [] __sys_recvmmsg+0x6fa/0x7f0 net/socket.c:2261 > [< inline >]

Re: [RFC PATCH net] net/core: don't increment rx_dropped on inactive slaves

Jarod Wilson wrote: >The network core tries to keep track of dropped packets, but some packets >you wouldn't really call dropped, so much as intentionally ignored, under >certain circumstances. One such case is that of bonding and team device >slaves that are currently

Re: [Xen-devel] [PATCH 1/3] xen-netback: fix license ident used in MODULE_LICENSE

> The fact what include/linux/license.h:license_is_gpl_compatible includes > "Dual MIT/GPL" as an option seems to suggest that it is enough of a thing > to be validly used as the contents of a MODULE_LICENSE() thing. Yes. The MIT licence most definitely exists, and people know what it means.

Re: [PATCH 00/33] Compile-time stack metadata validation

On Fri, Jan 22, 2016 at 01:14:47PM -0600, Josh Poimboeuf wrote: > On Fri, Jan 22, 2016 at 11:43:48AM -0600, Chris J Arges wrote: > > On Thu, Jan 21, 2016 at 04:49:04PM -0600, Josh Poimboeuf wrote: > > > This is v16 of the compile-time stack metadata validation patch set, > > > along with proposed

net: use-after-free in recvmmsg

Hello, While running syzkaller fuzzer I've hit the following use-after-free: == BUG: KASAN: use-after-free in __sys_recvmmsg+0x6fa/0x7f0 at addr 88003b689ce0 Read of size 8 by task syz-executor/11997

Re: [PATCH net 1/3] sctp: fix the transport dead race check by using atomic_add_unless on refcnt

On 01/22/2016 12:18 PM, Marcelo Ricardo Leitner wrote: > On Fri, Jan 22, 2016 at 11:50:20AM -0500, Vlad Yasevich wrote: >> On 01/21/2016 12:49 PM, Xin Long wrote: >>> Now when __sctp_lookup_association is running in BH, it will try to >>> check if t->dead is set, but meanwhile other CPUs may be

Re: [RFC PATCH v2] ethtool: add IPv6 to the NFC API

On Fri, Jan 22, 2016 at 10:04 AM, Edward Cree wrote: > Signed-off-by: Edward Cree > --- > changes from v1: > * split out separate spec structs for different flow types > * clarified the proto field in usr_ip6_spec > * changed IP6_USER_FLOW to 0x0e as I

[RFC PATCH net] net/core: don't increment rx_dropped on inactive slaves

The network core tries to keep track of dropped packets, but some packets you wouldn't really call dropped, so much as intentionally ignored, under certain circumstances. One such case is that of bonding and team device slaves that are currently inactive. Their respective rx_handler functions

[RFC PATCH v2] ethtool: add IPv6 to the NFC API

Signed-off-by: Edward Cree --- changes from v1: * split out separate spec structs for different flow types * clarified the proto field in usr_ip6_spec * changed IP6_USER_FLOW to 0x0e as I noticed there's a gap there include/uapi/linux/ethtool.h | 67

Has RFC4821 been implemented?

This came up on in one of the IETF mailing lists in the context that PMTUD doesn't really work on the Internet so PLPMTUD is the way to go. Looking at the code I only see inet_csk_update_pmtu called from ICMP PTB error. I am missing something? Thanks, Tom

Re: [PATCH 00/33] Compile-time stack metadata validation

On Fri, Jan 22, 2016 at 11:43:48AM -0600, Chris J Arges wrote: > On Thu, Jan 21, 2016 at 04:49:04PM -0600, Josh Poimboeuf wrote: > > This is v16 of the compile-time stack metadata validation patch set, > > along with proposed fixes for most of the warnings it found. It's based > > on the

Re: xen-netfront crash when detaching network while some network activity

On Thu, Jan 21, 2016 at 12:30:48PM +, Joao Martins wrote: > > > On 01/20/2016 09:59 PM, Konrad Rzeszutek Wilk wrote: > > On Tue, Dec 01, 2015 at 11:32:58PM +0100, Marek Marczykowski-Górecki wrote: > >> On Tue, Dec 01, 2015 at 05:00:42PM -0500, Konrad Rzeszutek Wilk wrote: > >>> On Tue, Nov

Re: Has RFC4821 been implemented?

Found it: tcp_mtu_probing On Fri, Jan 22, 2016 at 11:39 AM, Tom Herbert wrote: > This came up on in one of the IETF mailing lists in the context that > PMTUD doesn't really work on the Internet so PLPMTUD is the way to > go. Looking at the code I only see

Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration

On Thursday 21 January 2016 16:44:33 Kalle Valo wrote: > Pali Rohár writes: > > > On Thursday 21 January 2016 15:48:14 Kalle Valo wrote: > >> Pali Rohár writes: > >> > >> > On Thursday 14 January 2016 10:16:54 Pavel Machek wrote: > >> >> On Wed

[PATCH] net: simplify napi_synchronize() to avoid warnings

The napi_synchronize() function is defined twice: The definition for SMP builds waits for other CPUs to be done, while the uniprocessor variant just contains a barrier and ignores its argument. In the mvneta driver, this leads to a warning about an unused variable when we lookup the NAPI struct

Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR

On 22.01.2016 09:15, Shaohui Xie wrote: ___ From: Andrew Lunn Sent: Friday, January 22, 2016 5:12 AM To: Shaohui Xie Cc: Sebastian Hesselbarth; Florian Fainelli; shh@gmail.com; devicet...@vger.kernel.org; netdev@vger.kernel.org;

Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR

>> Looking at fsl_backplane_config_aneg() you expect phydev->speed to be >> set, and from the speed you then kick of either KR autoneg or KX >> autoneg. Could you also start the training at this point? Use the >> speed to indicate if training is needed? > > [S.H]The training cannot be started at

Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR

___ From: Andrew Lunn Sent: Friday, January 22, 2016 5:12 AM To: Shaohui Xie Cc: Sebastian Hesselbarth; Florian Fainelli; shh@gmail.com; devicet...@vger.kernel.org; netdev@vger.kernel.org; linuxppc-...@lists.ozlabs.org;

Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration

Pali Rohár writes: >> >> > Right, bt-coex is not for debugging purpose, but for normal usage, when >> >> > user want to use together bluetooth and wifi or just one of those. >> >> >> >> I think most of other drivers have a debugfs interface for btcoex, I >> >> guess mostly

Re: Optimizing instruction-cache, more packets at each stage

On Thu, 21 Jan 2016 09:48:36 -0800 Eric Dumazet wrote: > On Thu, 2016-01-21 at 08:38 -0800, Tom Herbert wrote: > > > Sure, but the receive path is parallelized. > > This is true for multiqueue processing, assuming you can dedicate many > cores to process RX. > > >

[PATCH 1/3] xen-netback: fix license ident used in MODULE_LICENSE

The comment at the beginning of the file is the canonical source of licenses for this module. Currently it contains GPL and MIT license. Fix the code to reflect the reality. Signed-off-by: Wei Liu --- drivers/net/xen-netback/netback.c | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH V2 5/5] net: can: ifi: Add IFI CANFD IP support

Marek Vasut wrote: I see, so adding u32 also here works. I'm starting to wonder if the BIT macro is really that nice and if I shouldn't just use (1 << n) as usual. Actually, (1 << n) is not so good either when n is 31 - it can trigger overflow warnings since it will be

[PATCH] dump_stack: avoid potential deadlocks

From: Eric Dumazet Some servers experienced fatal deadlocks because of a combination of bugs, leading to multiple cpus calling dump_stack(). The checksumming bug was fixed in commit 34ae6a1aa054 ("ipv6: update skb->csum when CE mark is propagated"). The second problem is a

Re: [PATCH] Netlink messages for multicast HW addr programming

Fri, Jan 22, 2016 at 04:49:36PM CET, pru...@brocade.com wrote: >On Fri, 2016-01-22 at 16:05 +0100, Jiri Pirko wrote: >> Fri, Jan 22, 2016 at 03:51:55PM CET, pru...@brocade.com wrote: >> >On Thu, 2016-01-21 at 21:04 +0100, Jiri Pirko wrote: >> >> Thu, Jan 21, 2016 at 12:47:54PM CET,

Re: [RFC PATCH] ethtool: add IPv6 to the NFC API

On 21/01/16 22:48, Alexander Duyck wrote: > On Thu, Jan 21, 2016 at 11:14 AM, Edward Cree wrote: >> + __be32 spi; > Is this supposed to be the flow label, or is this the IPSec security > parameter index? If it is the flow label you may want to rename it. > If it is

Re: Optimizing instruction-cache, more packets at each stage

On Fri, Jan 22, 2016 at 4:33 AM, Jesper Dangaard Brouer wrote: > On Thu, 21 Jan 2016 09:48:36 -0800 > Eric Dumazet wrote: > >> On Thu, 2016-01-21 at 08:38 -0800, Tom Herbert wrote: >> >> > Sure, but the receive path is parallelized. >> >> This is true

Re: Optimizing instruction-cache, more packets at each stage

On Fri, 22 Jan 2016 09:07:43 -0800 Tom Herbert wrote: > On Fri, Jan 22, 2016 at 4:33 AM, Jesper Dangaard Brouer > wrote: > > On Thu, 21 Jan 2016 09:48:36 -0800 > > Eric Dumazet wrote: > > > >> On Thu, 2016-01-21 at 08:38 -0800,

Re: [PATCH 23/33] x86/asm/bpf: Create stack frames in bpf_jit.S

On Fri, Jan 22, 2016 at 09:58:04AM -0600, Josh Poimboeuf wrote: > On Thu, Jan 21, 2016 at 08:18:46PM -0800, Alexei Starovoitov wrote: > > On Thu, Jan 21, 2016 at 09:55:31PM -0600, Josh Poimboeuf wrote: > > > On Thu, Jan 21, 2016 at 06:44:28PM -0800, Alexei Starovoitov wrote: > > > > On Thu, Jan

Re: [PATCH net 1/3] sctp: fix the transport dead race check by using atomic_add_unless on refcnt

On Fri, Jan 22, 2016 at 11:50:20AM -0500, Vlad Yasevich wrote: > On 01/21/2016 12:49 PM, Xin Long wrote: > > Now when __sctp_lookup_association is running in BH, it will try to > > check if t->dead is set, but meanwhile other CPUs may be freeing this > > transport and this assoc and if it happens

Re: [PATCH 31/33] bpf: Add __bpf_prog_run() to stacktool whitelist

On Thu, Jan 21, 2016 at 10:13:02PM -0600, Josh Poimboeuf wrote: > On Thu, Jan 21, 2016 at 06:55:41PM -0800, Alexei Starovoitov wrote: > > On Thu, Jan 21, 2016 at 04:49:35PM -0600, Josh Poimboeuf wrote: > > > stacktool reports the following false positive warnings: > > > > > > stacktool:

Re: [Xen-devel] [PATCH 1/3] xen-netback: fix license ident used in MODULE_LICENSE

On 22/01/16 12:34, Wei Liu wrote: > The comment at the beginning of the file is the canonical source of > licenses for this module. Currently it contains GPL and MIT license. Fix > the code to reflect the reality. "The MIT license" isn't really a thing. The closest is the X11 license[1], but

Re: [Xen-devel] [PATCH 1/3] xen-netback: fix license ident used in MODULE_LICENSE

On Fri, Jan 22, 2016 at 01:14:24PM +, David Vrabel wrote: > On 22/01/16 12:34, Wei Liu wrote: > > The comment at the beginning of the file is the canonical source of > > licenses for this module. Currently it contains GPL and MIT license. Fix > > the code to reflect the reality. > > "The MIT

[PATCH v2 1/3] xen-netback: fix license ident used in MODULE_LICENSE

The comment at the beginning of the file is the canonical source of licenses for this module. The license used to distribute outside of Linux kernel is not BSD license but X11 license. Instead of trying to determine whether X11 license can be mapped into Linux's "MIT" license ident, simply make

Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR

Hi, I'm not sure I explained myself clearly in previous reply, so I guess it's worth to rephrase it. 1000BASE-KX and 10GBASE-KR are backplane modes supported by Freescale's PCS PHY, but different modes need different hardware settings, not just different PHY init routines, this also needs

Re: [Xen-devel] [PATCH 1/3] xen-netback: fix license ident used in MODULE_LICENSE

On Fri, 2016-01-22 at 13:49 +, Wei Liu wrote: > On Fri, Jan 22, 2016 at 01:14:24PM +, David Vrabel wrote: > > On 22/01/16 12:34, Wei Liu wrote: > > > The comment at the beginning of the file is the canonical source of > > > licenses for this module. Currently it contains GPL and MIT

Re: Optimizing instruction-cache, more packets at each stage

On Fri, 2016-01-22 at 13:33 +0100, Jesper Dangaard Brouer wrote: > On Thu, 21 Jan 2016 09:48:36 -0800 > Eric Dumazet wrote: > > > On Thu, 2016-01-21 at 08:38 -0800, Tom Herbert wrote: > > > > > Sure, but the receive path is parallelized. > > > > This is true for

Re: [PATCH net 1/3] sctp: fix the transport dead race check by using atomic_add_unless on refcnt

On 01/21/2016 12:49 PM, Xin Long wrote: > Now when __sctp_lookup_association is running in BH, it will try to > check if t->dead is set, but meanwhile other CPUs may be freeing this > transport and this assoc and if it happens that > __sctp_lookup_association checked t->dead a bit too early, it

Re: struct pid memory leak

CC netdev, as it looks some af_unix issue ... On Fri, 2016-01-22 at 16:08 +0100, Dmitry Vyukov wrote: > Hello, > > The following program causes struct pid memory leak: > > // autogenerated by syzkaller (http://github.com/google/syzkaller) > #include > #include > #include > #include >

Re: [PATCH 23/33] x86/asm/bpf: Create stack frames in bpf_jit.S

On Thu, Jan 21, 2016 at 08:18:46PM -0800, Alexei Starovoitov wrote: > On Thu, Jan 21, 2016 at 09:55:31PM -0600, Josh Poimboeuf wrote: > > On Thu, Jan 21, 2016 at 06:44:28PM -0800, Alexei Starovoitov wrote: > > > On Thu, Jan 21, 2016 at 04:49:27PM -0600, Josh Poimboeuf wrote: > > > > bpf_jit.S has

Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR

> The reason I mentioned maybe I should put the backplane property in > fsl's binding is because the backplane implementation is really > vendor specific, it's heavily relay how hardware implements the > feature, maybe another vendor's hardware only needs a boolean > property for driver to tell it

Re: [PATCH] Netlink messages for multicast HW addr programming

Fri, Jan 22, 2016 at 03:51:55PM CET, pru...@brocade.com wrote: >On Thu, 2016-01-21 at 21:04 +0100, Jiri Pirko wrote: >> Thu, Jan 21, 2016 at 12:47:54PM CET, pru...@brocade.com wrote: >> >Add RTM_NEWADDR and RTM_DELADDR netlink messages to indicate >> >interest in specific multicast hardware

Re: [Xen-devel] [PATCH 1/3] xen-netback: fix license ident used in MODULE_LICENSE

On 22/01/16 14:15, Ian Campbell wrote: > On Fri, 2016-01-22 at 13:49 +, Wei Liu wrote: >> On Fri, Jan 22, 2016 at 01:14:24PM +, David Vrabel wrote: >>> On 22/01/16 12:34, Wei Liu wrote: The comment at the beginning of the file is the canonical source of licenses for this module.

Re: [PATCH] Netlink messages for multicast HW addr programming

On Thu, 2016-01-21 at 21:04 +0100, Jiri Pirko wrote: > Thu, Jan 21, 2016 at 12:47:54PM CET, pru...@brocade.com wrote: > >Add RTM_NEWADDR and RTM_DELADDR netlink messages to indicate > >interest in specific multicast hardware addresses. These messages > >are sent when addressed are added or deleted

Re: [PATCH] Netlink messages for multicast HW addr programming

On Fri, 2016-01-22 at 16:05 +0100, Jiri Pirko wrote: > Fri, Jan 22, 2016 at 03:51:55PM CET, pru...@brocade.com wrote: > >On Thu, 2016-01-21 at 21:04 +0100, Jiri Pirko wrote: > >> Thu, Jan 21, 2016 at 12:47:54PM CET, pru...@brocade.com wrote: > >> >Add RTM_NEWADDR and RTM_DELADDR netlink messages

Re: [PATCH 23/33] x86/asm/bpf: Create stack frames in bpf_jit.S

On Fri, Jan 22, 2016 at 09:18:23AM -0800, Alexei Starovoitov wrote: > On Fri, Jan 22, 2016 at 09:58:04AM -0600, Josh Poimboeuf wrote: > > On Thu, Jan 21, 2016 at 08:18:46PM -0800, Alexei Starovoitov wrote: > > > On Thu, Jan 21, 2016 at 09:55:31PM -0600, Josh Poimboeuf wrote: > > > > On Thu, Jan

Re: [PATCH 23/33] x86/asm/bpf: Create stack frames in bpf_jit.S

On Fri, Jan 22, 2016 at 11:36:14AM -0600, Josh Poimboeuf wrote: > On Fri, Jan 22, 2016 at 09:18:23AM -0800, Alexei Starovoitov wrote: > > On Fri, Jan 22, 2016 at 09:58:04AM -0600, Josh Poimboeuf wrote: > > > On Thu, Jan 21, 2016 at 08:18:46PM -0800, Alexei Starovoitov wrote: > > > > On Thu, Jan

Vr headset,vr box,Vr glasses,from the original factory

Dear Happy 2016, Hottest VR box,for mobile phone,Watch 3D movie and vr video,Play vr games Price only $6/pc now,only from the arcpeaks factory Alibaba link,http://arcpeaks.en.alibaba.com/product/60401287002-802634136/2016_hottest_product_virtual_reality_3d_games_and_video_3d_vr_glasses.html

Re: [PATCH 00/33] Compile-time stack metadata validation

On Thu, Jan 21, 2016 at 04:49:04PM -0600, Josh Poimboeuf wrote: > This is v16 of the compile-time stack metadata validation patch set, > along with proposed fixes for most of the warnings it found. It's based > on the tip/master branch. > Josh, Looks good, with my config [1] I do still get a few

Re: [PATCH net] lan78xx: changed to use updated phy-ignore-interrupts

On 21/01/2016 12:15, woojung@microchip.com wrote: > Update lan78xx to use patch of commit 4f2aaf7dd95b > ("Merge branch 'fix-phy-ignore-interrupts'") Looks fine, just one nit below: > > Signed-off-by: Woojung Huh > --- > drivers/net/usb/lan78xx.c | 28

[PATCH net] inet: frag: Always orphan skbs inside ip_defrag()

Later parts of the stack (including fragmentation) expect that there is never a socket attached to frag in a frag_list, however this invariant was not enforced on all defrag paths. This could lead to the BUG_ON(skb->sk) during ip_do_fragment(), as per the call stack at the end of this commit

Re: [PATCH net] inet: frag: Always orphan skbs inside ip_defrag()

On Fri, 2016-01-22 at 15:49 -0800, Joe Stringer wrote: > Later parts of the stack (including fragmentation) expect that there is > never a socket attached to frag in a frag_list, however this invariant > was not enforced on all defrag paths. This could lead to the > BUG_ON(skb->sk) during