[RESEND PATCH 9/9] ipv4: Namespaceify tcp_notsent_lowat sysctl knob

2016-02-02 Thread Nikolay Borisov
Signed-off-by: Nikolay Borisov --- include/net/netns/ipv4.h | 1 + include/net/tcp.h | 4 ++-- net/ipv4/sysctl_net_ipv4.c | 14 +++--- net/ipv4/tcp_ipv4.c| 1 + net/ipv4/tcp_output.c | 3 --- 5 files changed, 11 insertions(+), 12 deletions(-)

[RESEND PATCH 6/9] ipv4: Namespaceify tcp_retries2 sysctl knob

2016-02-02 Thread Nikolay Borisov
Signed-off-by: Nikolay Borisov --- include/net/netns/ipv4.h | 1 + include/net/tcp.h | 1 - net/ipv4/sysctl_net_ipv4.c | 14 +++--- net/ipv4/tcp_ipv4.c| 1 + net/ipv4/tcp_output.c | 3 ++- net/ipv4/tcp_timer.c | 5 ++--- 6 files

[RESEND PATCH 3/9] ipv4: Namespaceify tcp syncookies sysctl knob

2016-02-02 Thread Nikolay Borisov
Signed-off-by: Nikolay Borisov --- include/net/netns/ipv4.h | 2 ++ include/net/tcp.h | 1 - net/ipv4/syncookies.c | 4 +--- net/ipv4/sysctl_net_ipv4.c | 18 +- net/ipv4/tcp_input.c | 10 ++ net/ipv4/tcp_ipv4.c| 3 ++-

[RESEND PATCH 5/9] ipv4: Namespaceify tcp_retries1 sysctl knob

2016-02-02 Thread Nikolay Borisov
Signed-off-by: Nikolay Borisov --- include/net/netns/ipv4.h | 1 + include/net/tcp.h | 1 - net/ipv4/sysctl_net_ipv4.c | 16 net/ipv4/tcp_ipv4.c| 1 + net/ipv4/tcp_timer.c | 8 5 files changed, 14 insertions(+), 13

[RESEND PATCH 4/9] ipv4: Namespaceify tcp reordering sysctl knob

2016-02-02 Thread Nikolay Borisov
Signed-off-by: Nikolay Borisov --- include/net/netns/ipv4.h | 2 +- include/net/tcp.h | 4 +++- net/ipv4/sysctl_net_ipv4.c | 14 +++--- net/ipv4/tcp.c | 2 +- net/ipv4/tcp_input.c | 12 ++-- net/ipv4/tcp_ipv4.c| 2 +-

[PATCH net-next 2/4] drivers: net: xgene: Add support for RSS

2016-02-02 Thread Iyappan Subramanian
Signed-off-by: Iyappan Subramanian Signed-off-by: Khuong Dinh Signed-off-by: Tanmay Inamdar Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/xgene_enet_cle.c | 386 +++-

[PATCH net-next 0/4] Add support for Classifier and RSS

2016-02-02 Thread Iyappan Subramanian
This patch series enables (i) Classifier engine that is used for parsing through the packet and extracting a search string that is then used to search a database to find associative data. (ii) Receive Side Scaling (RSS) that does dynamic load balancing of the CPUs by controlling the number of

[RESEND PATCH 7/9] ipv4: Namespaceify tcp_orphan_retries sysctl knob

2016-02-02 Thread Nikolay Borisov
Signed-off-by: Nikolay Borisov --- include/net/netns/ipv4.h | 1 + include/net/tcp.h | 1 - net/ipv4/sysctl_net_ipv4.c | 14 +++--- net/ipv4/tcp_ipv4.c| 1 + net/ipv4/tcp_timer.c | 3 +-- 5 files changed, 10 insertions(+), 10 deletions(-)

[RESEND PATCH 8/9] ipv4: Namespaceify tcp_fin_timeout sysctl knob

2016-02-02 Thread Nikolay Borisov
Signed-off-by: Nikolay Borisov --- include/net/netns/ipv4.h | 1 + include/net/tcp.h | 3 +-- net/ipv4/sysctl_net_ipv4.c | 14 +++--- net/ipv4/tcp.c | 7 +++ net/ipv4/tcp_ipv4.c| 1 + 5 files changed, 13 insertions(+), 13

Re: [PATCH 1/1] net/ipv6: add sysctl option accept_ra_min_hop_limit

2016-02-02 Thread Yuki Machida
Hi Yoshifuji-san. On 2016年01月18日 17:33, YOSHIFUJI Hideaki wrote: > Hi, > > Yuki Machida wrote: >> Hi, Yoshifuji-san >> >> It is currently under investigation. >> It takes still time. >> >> Futher comment below. >> >> On 2016年01月05日 19:17, YOSHIFUJI Hideaki wrote: >>> Hi, Machida-san. >>> >>>

[PATCH] dwc_eth_qos: Reset hardware before PHY start

2016-02-02 Thread Rabin Vincent
From: Rabin Vincent The hardware reset is currently done after phy_start() is called, leading to a race where we can lose the link status if the phy state machine calls dwceqos_adjust_link() before we reset the MAC registers. Acked-by: Lars Persson

[PATCH] bonding: add slave device name for debug

2016-02-02 Thread Zhang Shengju
netdev_dbg() will add bond device name, it will be helpful if we print slave device name. Signed-off-by: Zhang Shengju --- drivers/net/bonding/bond_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bonding/bond_main.c

Re: [PATCH] mac80211: minstrel_ht: fix out-of-bound in minstrel_ht_set_best_prob_rate

2016-02-02 Thread Johannes Berg
On Fri, 2016-01-29 at 11:35 +0300, Konstantin Khlebnikov wrote: > Patch fixes this splat > > BUG: KASAN: slab-out-of-bounds in > minstrel_ht_update_stats.isra.7+0x6e1/0x9e0 > [mac80211] at addr 8800cee640f4 Read of size 4 by task > swapper/3/0 > > Signed-off-by: Konstantin Khlebnikov

Re: [PATCH net-next 5/5] vxlan: consolidate vxlan_xmit_skb and vxlan6_xmit_skb

2016-02-02 Thread Paolo Abeni
On Tue, 2016-02-02 at 11:13 +0100, Jiri Benc wrote: > There's a lot of code duplication. Factor out the duplicate code to a new > function shared between IPv4 and IPv6 xmit path. > > Signed-off-by: Jiri Benc > --- > drivers/net/vxlan.c | 141 >

[PATCH net V1 0/3] mlx5 driver fixes for 4.5-rc2

2016-02-02 Thread Or Gerlitz
Hi Dave, Saeed fixed the case where VFs probed to the host shared the PF ndo_set_vf_yyy NDOs which is wrong, now along the lines of what you were asking. We added here a patch from Matan and Alaa for addressing Linus comments on the mess w.r.t reserved field names in the driver/firmware

[PATCH net-next v2 2/2] virtio_net: add ethtool support for set and get of settings

2016-02-02 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch allows the user to set and retrieve speed and duplex of the virtio_net device via ethtool. Having this functionality is very helpful for simulating different environments and also enables the virtio_net device to participate in

Re: [PATCH net-next 5/5] vxlan: consolidate vxlan_xmit_skb and vxlan6_xmit_skb

2016-02-02 Thread Jiri Benc
On Tue, 02 Feb 2016 15:57:23 +0100, Paolo Abeni wrote: > I think there is an issue here: in vxlan_build_skb(), 'flags' will be > always tested against VXLAN_F_UDP_CSUM, but when tunneling over ipv6 we > should check VXLAN_F_UDP_ZERO_CSUM6_TX instead. You're correct. This IPv4/v6 flags schism is

Re: [PATCH net-next 4/8] be2net: SRIOV Queue distribution should factor in EQ-count of VFs

2016-02-02 Thread Sergei Shtylyov
Hello. On 2/2/2016 1:20 PM, Sriharsha Basavapatna wrote: The SRIOV resource distribution logic for RX/TX queue counts is not optimal when a small number of VFs are enabled. It does not take into account the VF's EQ count while computing the queue counts. Because of this, the VF gets a large

Re: [PATCH net-next v2 2/2] virtio_net: add ethtool support for set and get of settings

2016-02-02 Thread Nikolay Aleksandrov
On 02/02/2016 03:54 PM, Michael S. Tsirkin wrote: > On Tue, Feb 02, 2016 at 03:33:40PM +0100, Nikolay Aleksandrov wrote: >> From: Nikolay Aleksandrov >> >> This patch allows the user to set and retrieve speed and duplex of the >> virtio_net device via ethtool. Having

Re: [PATCH net-next v2 1/2] ethtool: add speed/duplex validation functions

2016-02-02 Thread Michael S. Tsirkin
On Tue, Feb 02, 2016 at 03:33:39PM +0100, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > Add functions which check if the speed/duplex are defined. > > Signed-off-by: Nikolay Aleksandrov Acked-by: Michael S. Tsirkin

Re: [PATCH net-next v2 2/2] virtio_net: add ethtool support for set and get of settings

2016-02-02 Thread Michael S. Tsirkin
On Tue, Feb 02, 2016 at 03:33:40PM +0100, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > This patch allows the user to set and retrieve speed and duplex of the > virtio_net device via ethtool. Having this functionality is very helpful > for simulating

[PATCH net-next v2 1/2] ethtool: add speed/duplex validation functions

2016-02-02 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add functions which check if the speed/duplex are defined. Signed-off-by: Nikolay Aleksandrov --- v2: new patch include/uapi/linux/ethtool.h | 34 ++ 1 file changed, 34

[PATCH net-next v2 0/2] virtio_net: add ethtool get/set settings support

2016-02-02 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Hi, Patch 1 adds ethtool speed/duplex validation functions which check if the value is defined. Patch 2 adds support for ethtool (get|set)_settings and uses the validation functions to check the user-supplied values. v2: split in 2 patches

Re: [RFC PATCH 0/7] tc cls_u32 hardware interface

2016-02-02 Thread John Fastabend
On 16-02-02 03:49 AM, Jiri Pirko wrote: > Mon, Feb 01, 2016 at 02:48:32AM CET, john.fastab...@gmail.com wrote: >> I was waiting for net-next to open to submit this but it seems like >> a good idea to get an RFC out there for folks to start looking over. >> >> This extends the setup_tc framework so

[PATCH net V1 1/3] net/mlx5e: Remove select queue ndo initialization

2016-02-02 Thread Or Gerlitz
From: Saeed Mahameed Currently mlx5e_select_queue is redundant since num_tc is always 1. We remove setting that as part of constifying the structures used for the netdev ops. Signed-off-by: Saeed Mahameed Signed-off-by: Or Gerlitz

[PATCH net V1 2/3] net/mlx5e: Use static constant netdevice ndos

2016-02-02 Thread Or Gerlitz
From: Saeed Mahameed Currently our netdevice ops is a one static global variable which is referenced by all mlx5e netdevice instances. This can be problematic when different driver instances do not share same HW capabilities (e.g SRIOV PF and VFs probed to the host). Now we

Re: [PATCH iproute2 -master 0/4] Minor BPF updates on frontend

2016-02-02 Thread Daniel Borkmann
Hi Stephen, On 02/02/2016 06:07 AM, Stephen Hemminger wrote: On Tue, 2 Feb 2016 01:12:25 +0100 Daniel Borkmann wrote: Couple of minor updates on tc frontend. Stephen, the patches are against iproute2 -master branch and *on top of* the two that are already lingering in

RE: [net PATCH] flow_dissector: Fix unaligned access in __skb_flow_dissector when used by eth_get_headlen

2016-02-02 Thread David Laight
From: Alexander Duyck > Sent: 01 February 2016 18:18 > >> 1) Unaligned accesses > > > > Remember the even if you do a 'realignment copy' of the IP header, > > at some point the 'userdata' of the packet has to be accessed. > > Mostly this will be with memcpy() and you want that copy to be aligned.

[PATCH net-next 1/6] i40e: call ndo_stop() instead of dev_close() when running offline selftest

2016-02-02 Thread Stefan Assmann
Calling dev_close() causes IFF_UP to be cleared which will remove the interfaces routes and some addresses. That's probably not what the user intended when running the offline selftest. Besides this does not happen if the interface is brought down before the test, so the current behaviour is

[PATCH net-next 5/6] e1000: call ndo_stop() instead of dev_close() when running offline selftest

2016-02-02 Thread Stefan Assmann
Calling dev_close() causes IFF_UP to be cleared which will remove the interfaces routes and some addresses. That's probably not what the user intended when running the offline selftest. Besides this does not happen if the interface is brought down before the test, so the current behaviour is

[PATCH net-next 2/6] ixgbe: call ndo_stop() instead of dev_close() when running offline selftest

2016-02-02 Thread Stefan Assmann
Calling dev_close() causes IFF_UP to be cleared which will remove the interfaces routes and some addresses. That's probably not what the user intended when running the offline selftest. Besides this does not happen if the interface is brought down before the test, so the current behaviour is

[PATCH net-next 0/6] net/intel: call ndo_stop() instead of dev_close() when running offline selftest

2016-02-02 Thread Stefan Assmann
Calling dev_close() causes IFF_UP to be cleared which will remove the interfaces routes and some addresses. That's probably not what the user intended when running the offline selftest. Besides this does not happen if the interface is brought down before the test, so the current behaviour is

[PATCH net-next 1/5] vxlan: cleanup types

2016-02-02 Thread Jiri Benc
include/net/vxlan.h is a kernel header, no need to prefix fixed size types with double underscore. Signed-off-by: Jiri Benc --- include/net/vxlan.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/net/vxlan.h b/include/net/vxlan.h

[PATCH net-next 2/5] vxlan: remove duplicated macros

2016-02-02 Thread Jiri Benc
VNI_HASH_BITS and VNI_HASH_SIZE are defined twice. Remove the extra definitions. Signed-off-by: Jiri Benc --- include/net/vxlan.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/net/vxlan.h b/include/net/vxlan.h index 5c64250619c5..234bf1ef2737 100644 ---

[PATCH net-next 0/5] vxlan: cleanup headers and tx path

2016-02-02 Thread Jiri Benc
This is first part of vxlan cleanup. It makes vxlan.h better organized and removes code duplication in the tx path. There's no change in functionality. This is in preparation for VXLAN-GPE support. Other sets will follow with cleanup of rx path, modifications of vxlan interface setup and

Re: [PATCH iproute2] tc: fix compilation with old gcc (< 4.6) (bis)

2016-02-02 Thread Nicolas Dichtel
Le 02/02/2016 10:08, Daniel Borkmann a écrit : On 02/02/2016 05:51 AM, Stephen Hemminger wrote: On Tue, 19 Jan 2016 11:01:45 + Nicolas Dichtel wrote: diff --git a/tc/tc_bpf.c b/tc/tc_bpf.c index 42c8841869f5..219ffa582c1a 100644 --- a/tc/tc_bpf.c +++

[PATCH net-next 7/8] benet: Add retry in case of error recovery failure

2016-02-02 Thread Sriharsha Basavapatna
From: Padmanabh Ratnakar Retry error recovery MAX_ERR_RECOVERY_RETRY_COUNT times in case of failure during error recovery. Signed-off-by: Padmanabh Ratnakar Signed-off-by: Sriharsha Basavapatna

[PATCH net-next 5/8] be2net: Don't run ethtool self-tests for VFs

2016-02-02 Thread Sriharsha Basavapatna
From: Somnath Kotur The CMD_SUBSYSTEM_LOWLEVEL cmds need DEV_CFG Privilege to run which VFs don't have by default. Self-tests need to be issued only for PFs. Signed-off-by: Somnath Kotur Signed-off-by: Sriharsha Basavapatna

[PATCH net-next 2/8] be2net: check for INSUFFICIENT_PRIVILEGES error

2016-02-02 Thread Sriharsha Basavapatna
From: Suresh Reddy The driver currently logs the message "VF is not privileged to issue opcode" by checking only the base_status field for UNAUTHORIZED_REQUEST. Add check to look for INSUFFICIENT_PRIVILEGES in the additional status field also as not all cmds fail with

[PATCH net-next 4/8] be2net: SRIOV Queue distribution should factor in EQ-count of VFs

2016-02-02 Thread Sriharsha Basavapatna
The SRIOV resource distribution logic for RX/TX queue counts is not optimal when a small number of VFs are enabled. It does not take into account the VF's EQ count while computing the queue counts. Because of this, the VF gets a large number of queues, though it doesn't have sufficient EQs,

[PATCH net-next 3/8] be2net: Fix be_vlan_rem_vid() to check vlan id being removed

2016-02-02 Thread Sriharsha Basavapatna
The driver decrements its vlan count without checking if it is really present in its list. This results in an invalid vlan count and impacts subsequent vlan add/rem ops. The function be_vlan_rem_vid() should be updated to fix this. Signed-off-by: Sriharsha Basavapatna

[PATCH net-next 1/8] be2net: return error status from be_set_phys_id()

2016-02-02 Thread Sriharsha Basavapatna
From: Suresh Reddy be_set_phys_id() returns 0 to ethtool when the command fails in the FW. This patch fixes the set_phys_id() to return -EIO in case the FW cmd fails. Signed-off-by: Suresh Reddy Signed-off-by: Sriharsha Basavapatna

[PATCH net-next 6/8] benet: Fix Lancer error recovery

2016-02-02 Thread Sriharsha Basavapatna
From: Padmanabh Ratnakar After error is detected, wait for adapter to move to ready state before destroying queues and cleanup of other resources. Also skip performing any cleanup for non-Lancer chips and move debug messages to correct routine. Signed-off-by:

[PATCH net-next v2 00/10] tipc: cleanups, fixes & improvements for topology server

2016-02-02 Thread Parthasarathy Bhuvaragan
This series contains topology server cleanups, fixes and improvements. Cleanups in #1-#4: We remove duplicate data structures and aligin the rest of the code accordingly. Fixes in #5-#8: The bugs occur either during configuration or while running on SMP targets, which are race conditions that

[PATCH net-next v2 05/10] tipc: fix connection abort during subscription cancellation

2016-02-02 Thread Parthasarathy Bhuvaragan
In 'commit 7fe8097cef5f ("tipc: fix nullpointer bug when subscribing to events")', we terminate the connection if the subscription creation fails. In the same commit, the subscription creation result was based on the value of subscription pointer (set in the function) instead of the return code.

[PATCH net-next v2 01/10] tipc: remove incorrect check for subscription timeout value

2016-02-02 Thread Parthasarathy Bhuvaragan
Until now, during subscription creation we set sub->timeout by converting the timeout request value in milliseconds to jiffies. This is followed by setting the timeout value in the timer if sub->timeout != TIPC_WAIT_FOREVER. For a subscription create request with a timeout value of

[PATCH net-next 8/8] benet: Fix interval calculation in interrupt moderation

2016-02-02 Thread Sriharsha Basavapatna
From: Padmanabh Ratnakar Interrupt moderation parameters need to be recalculated only after a time interval of 1 ms. Interval calculation is wrong when there is a rollover of jiffies. Using recommended way of interval calculation using jiffies to fix this.

Re: [PATCH V5] netfilter: h323: avoid potential attack

2016-02-02 Thread Sergei Shtylyov
Hello. On 2/2/2016 8:37 AM, Zhouyi Zhou wrote: I think hackers chould build a malicious h323 packet to overflow the pointer p which will panic during the memcpy(addr, p, len) For example, he may fabricate a very large taddr->ipAddress.ip. In order to avoid this, I add a valid memory reference

Re: [PATCH iproute2] tc: fix compilation with old gcc (< 4.6) (bis)

2016-02-02 Thread Daniel Borkmann
On 02/02/2016 05:51 AM, Stephen Hemminger wrote: On Tue, 19 Jan 2016 11:01:45 + Nicolas Dichtel wrote: diff --git a/tc/tc_bpf.c b/tc/tc_bpf.c index 42c8841869f5..219ffa582c1a 100644 --- a/tc/tc_bpf.c +++ b/tc/tc_bpf.c @@ -49,6 +49,10 @@ #include "tc_util.h"

[PATCH net-next v2 07/10] tipc: hold subscriber->lock for tipc_nametbl_subscribe()

2016-02-02 Thread Parthasarathy Bhuvaragan
Until now, while creating a subscription the subscriber lock protects only the subscribers subscription list and not the nametable. The call to tipc_nametbl_subscribe() is outside the lock. However, at subscription timeout and cancel both the subscribers subscription list and the nametable are

[PATCH net-next v2 03/10] tipc: remove struct tipc_name_seq from struct tipc_subscription

2016-02-02 Thread Parthasarathy Bhuvaragan
Until now, struct tipc_subscriber has duplicate fields for type, upper and lower (as member of struct tipc_name_seq) at: 1. as member seq in struct tipc_subscription 2. as member seq in struct tipc_subscr, which is contained in struct tipc_event The former structure contains the type, upper and

[PATCH net-next v2 08/10] tipc: protect tipc_subscrb_get() with subscriber spin lock

2016-02-02 Thread Parthasarathy Bhuvaragan
Until now, during subscription creation the mod_time() & tipc_subscrb_get() are called after releasing the subscriber spin lock. In a SMP system when performing a subscription creation, if the subscription timeout occurs simultaneously (the timer is scheduled to run on another CPU) then the timer

[PATCH net-next v2 06/10] tipc: fix connection abort when receiving invalid cancel request

2016-02-02 Thread Parthasarathy Bhuvaragan
Until now, the subscribers endianness for a subscription create/cancel request is determined as: swap = !(s->filter & (TIPC_SUB_PORTS | TIPC_SUB_SERVICE)) The checks are performed only for port/service subscriptions. The swap calculation is incorrect if the filter in the subscription

[PATCH net-next v2 10/10] tipc: use alloc_ordered_workqueue() instead of WQ_UNBOUND w/ max_active = 1

2016-02-02 Thread Parthasarathy Bhuvaragan
Until now, tipc_rcv and tipc_send workqueues in server are allocated with parameters WQ_UNBOUND & max_active = 1. This parameters passed to this function makes it equivalent to alloc_ordered_workqueue(). The later form is more explicit and can inherit future ordered_workqueue changes. In this

[PATCH net-next v2 09/10] tipc: donot create timers if subscription timeout = TIPC_WAIT_FOREVER

2016-02-02 Thread Parthasarathy Bhuvaragan
Until now, we create timers even for the subscription requests with timeout = TIPC_WAIT_FOREVER. This can be improved by avoiding timer creation when the timeout is set to TIPC_WAIT_FOREVER. In this commit, we introduce a check to creates timers only when timeout != TIPC_WAIT_FOREVER. Acked-by:

[PATCH net-next v2 02/10] tipc: remove filter and timeout elements from struct tipc_subscription

2016-02-02 Thread Parthasarathy Bhuvaragan
Until now, struct tipc_subscription has duplicate timeout and filter attributes present: 1. directly as members of struct tipc_subscription 2. in struct tipc_subscr, which is contained in struct tipc_event In this commit, we remove the references to these elements as members of struct

[PATCH net-next v2 04/10] tipc: introduce tipc_subscrb_subscribe() routine

2016-02-02 Thread Parthasarathy Bhuvaragan
In this commit, we split tipc_subscrp_create() into two: 1. tipc_subscrp_create() creates a subscription 2. A new function tipc_subscrp_subscribe() adds the subscription to the subscriber subscription list, activates the subscription timer and subscribes to the nametable updates. In

[PATCH net-next 4/5] vxlan: consolidate output route calculation

2016-02-02 Thread Jiri Benc
The code for output route lookup is duplicated for ndo_start_xmit and ndo_fill_metadata_dst. Move it to a common function. Signed-off-by: Jiri Benc --- This particular patch was already submitted but felt through cracks. https://patchwork.ozlabs.org/patch/552197/ ---

[PATCH net-next 5/5] vxlan: consolidate vxlan_xmit_skb and vxlan6_xmit_skb

2016-02-02 Thread Jiri Benc
There's a lot of code duplication. Factor out the duplicate code to a new function shared between IPv4 and IPv6 xmit path. Signed-off-by: Jiri Benc --- drivers/net/vxlan.c | 141 +++- 1 file changed, 29 insertions(+), 112

[PATCH net-next 3/5] vxlan: restructure vxlan.h definitions

2016-02-02 Thread Jiri Benc
RCO and GBP are VXLAN extensions, not specified in RFC 7348. Because of that, they need to be explicitly enabled when creating vxlan interface. By default, those extensions are not used and plain VXLAN header is sent and received. Reflect this in vxlan.h: first, the plain VXLAN header is defined.

[PATCH net-next 3/6] ixgbevf: call ndo_stop() instead of dev_close() when running offline selftest

2016-02-02 Thread Stefan Assmann
Calling dev_close() causes IFF_UP to be cleared which will remove the interfaces routes and some addresses. That's probably not what the user intended when running the offline selftest. Besides this does not happen if the interface is brought down before the test, so the current behaviour is

[PATCH net-next 4/6] igb: call ndo_stop() instead of dev_close() when running offline selftest

2016-02-02 Thread Stefan Assmann
Calling dev_close() causes IFF_UP to be cleared which will remove the interfaces routes and some addresses. That's probably not what the user intended when running the offline selftest. Besides this does not happen if the interface is brought down before the test, so the current behaviour is

[PATCH net-next 6/6] e1000e: call ndo_stop() instead of dev_close() when running offline selftest

2016-02-02 Thread Stefan Assmann
Calling dev_close() causes IFF_UP to be cleared which will remove the interfaces routes and some addresses. That's probably not what the user intended when running the offline selftest. Besides this does not happen if the interface is brought down before the test, so the current behaviour is

[PATCH] rtlwifi: Fix reusable codes in core.c

2016-02-02 Thread Byeoungwook Kim
rtl_*_delay() functions were reused same codes about addr variable. So i have converted to rtl_addr_delay() from code about addr variable. Conditional codes in rtl_addr_delay() were improved in readability and performance by using switch codes. Signed-off-by: Byeoungwook Kim

[PATCH net-next] net: Add support for filtering link dump by master device and kind

2016-02-02 Thread David Ahern
Add support for filtering link dumps by master device and kind, similar to the filtering implemented for neighbor dumps. Each net_device that exists adds between 1196 bytes (eth) and 1556 bytes (bridge) to the link dump. As the number of interfaces increases so does the amount of data pushed to

[PATCH net-next v3 0/2] virtio_net: add ethtool get/set settings support

2016-02-02 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Hi, Patch 1 adds ethtool speed/duplex validation functions which check if the value is defined. Patch 2 adds support for ethtool (get|set)_settings and uses the validation functions to check the user-supplied values. v2: split in 2 patches

Re: [PATCH net-next 4/8] be2net: SRIOV Queue distribution should factor in EQ-count of VFs

2016-02-02 Thread Sergei Shtylyov
On 02/02/2016 06:41 PM, Sriharsha Basavapatna wrote: The SRIOV resource distribution logic for RX/TX queue counts is not optimal when a small number of VFs are enabled. It does not take into account the VF's EQ count while computing the queue counts. Because of this, the VF gets a large number

Re: [RFC PATCH 6/7] net: ixgbe: add minimal parser details for ixgbe

2016-02-02 Thread John Fastabend
On 16-02-02 08:27 AM, Or Gerlitz wrote: > On Mon, Feb 1, 2016 at 3:52 AM, John Fastabend > wrote: >> This adds an ixgbe data structure that is used to determine what >> headers:fields can be matched and in what order they are supported. >> >> For hardware devices this

Keystone 2 boards boot failure

2016-02-02 Thread Franklin S Cooper Jr.
Hi All, Latest mainline is currently failing to boot for Keystone 2 Hawking but I'm assuming its true for other Keystone 2 boards. Bisect shows that this issue popped up after the patch "netcp: try to reduce type confusion in descriptors" (commit 89907779) was introduced. There was another patch

Re: [PATCH net-next v2 2/2] virtio_net: add ethtool support for set and get of settings

2016-02-02 Thread Michael S. Tsirkin
On Tue, Feb 02, 2016 at 03:59:52PM +0100, Nikolay Aleksandrov wrote: > On 02/02/2016 03:54 PM, Michael S. Tsirkin wrote: > > On Tue, Feb 02, 2016 at 03:33:40PM +0100, Nikolay Aleksandrov wrote: > >> From: Nikolay Aleksandrov > >> > >> This patch allows the user to set

[iproute2 net-next] vrf: Add support for slave_info

2016-02-02 Thread David Ahern
Print VRF slave_info attributes if present. Signed-off-by: David Ahern --- Requires IFLA_VRF_PORT_* from linux/if_link.h ip/iplink_vrf.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/ip/iplink_vrf.c b/ip/iplink_vrf.c index

[PATCH net-next] net: Add support for fill_slave_info to VRF device

2016-02-02 Thread David Ahern
Allows userspace to have direct access to VRF table association versus looking up master device and its table. Signed-off-by: David Ahern --- drivers/net/vrf.c| 21 + include/uapi/linux/if_link.h | 8 2 files changed, 29

Re: [v2,2/3] net: wireless: b43: Coding Style

2016-02-02 Thread Sudip Mukherjee
On Mon, Oct 19, 2015 at 05:02:22PM +0100, Paul Mcquade wrote: > Fixed Pointer Coding Style > > Signed-off-by: Paul McQuade > Acked-by: Michael Buesch Please fix the From: name like i just replied in another of your patch and this patch will not apply anymore

Re: [RFC PATCH 6/7] net: ixgbe: add minimal parser details for ixgbe

2016-02-02 Thread Or Gerlitz
On Mon, Feb 1, 2016 at 3:52 AM, John Fastabend wrote: > This adds an ixgbe data structure that is used to determine what > headers:fields can be matched and in what order they are supported. > > For hardware devices this can be a bit tricky because typically > only

Re: Optimizing instruction-cache, more packets at each stage

2016-02-02 Thread Eric Dumazet
On Tue, 2016-02-02 at 18:13 +0200, Or Gerlitz wrote: > Could you provide some details on the weaknesses of Toeplitz? > FYI, the admin is able to configure non-default keys for Toeplitz > through ethtool. Well, Toeplitz keys are no longer default anyway, I hope. d682d2bdc306 bnx2x: byte swap

Re: [RESEND,01/10] net: wireless: ath: Remove unnecessary semicolon

2016-02-02 Thread Sudip Mukherjee
On Wed, Oct 28, 2015 at 12:32:36AM +0530, punit vara wrote: > This patch is to the htt_rx.c that removes unneeded semicolon which is > reported by coccicheck. > > Here semicolon just create empty statement so please remote it. s/remote/remove Instead of "net: wireless: ath: Remove unnecessary

Re: [RFC PATCH 3/7] net: sched: add cls_u32 offload hooks for netdevs

2016-02-02 Thread John Fastabend
On 16-02-02 08:25 AM, Or Gerlitz wrote: > On Mon, Feb 1, 2016 at 3:50 AM, John Fastabend > wrote: >> This patch allows netdev drivers to consume cls_u32 offloads via >> the ndo_setup_tc ndo op. >> >> This works aligns with how network drivers have been doing qdisc >>

Re: [PATCH net-next 6/6] e1000e: call ndo_stop() instead of dev_close() when running offline selftest

2016-02-02 Thread kbuild test robot
Hi Stefan, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Stefan-Assmann/net-intel-call-ndo_stop-instead-of-dev_close-when-running-offline-selftest/20160202-182015 config: i386-defconfig (attached as .config) reproduce: # save the attached

Re: [PATCH net-next v1] xen-netback: implement dynamic multicast control

2016-02-02 Thread Wei Liu
On Mon, Feb 01, 2016 at 02:40:53PM +, Paul Durrant wrote: [...] > +static int xen_register_mcast_ctrl_watch(struct xenbus_device *dev, > + struct xenvif *vif) > +{ > + int err = 0; > + char *node; > + unsigned maxlen = strlen(dev->otherend) + >

Re: [PATCH net-next v2] xen-netback: implement dynamic multicast control

2016-02-02 Thread Wei Liu
On Tue, Feb 02, 2016 at 11:31:08AM +, Paul Durrant wrote: [...] > +static int xen_register_mcast_ctrl_watch(struct xenbus_device *dev, > + struct xenvif *vif) > +{ > + int err = 0; > + char *node; > + unsigned maxlen = strlen(dev->otherend) + >

Re: [RFC PATCH 0/7] tc cls_u32 hardware interface

2016-02-02 Thread Jiri Pirko
Mon, Feb 01, 2016 at 02:48:32AM CET, john.fastab...@gmail.com wrote: >I was waiting for net-next to open to submit this but it seems like >a good idea to get an RFC out there for folks to start looking over. > >This extends the setup_tc framework so it can support more than just >the mqprio

[PATCH net-next v3] xen-netback: implement dynamic multicast control

2016-02-02 Thread Paul Durrant
My recent patch to the Xen Project documents a protocol for 'dynamic multicast control' in netif.h. This extends the previous multicast control protocol to not require a shared ring reconnection to turn the feature off. Instead the backend watches the "request-multicast-control" key in xenstore

Re: [PATCH net-next v3] xen-netback: implement dynamic multicast control

2016-02-02 Thread Wei Liu
On Tue, Feb 02, 2016 at 11:55:05AM +, Paul Durrant wrote: > My recent patch to the Xen Project documents a protocol for 'dynamic > multicast control' in netif.h. This extends the previous multicast control > protocol to not require a shared ring reconnection to turn the feature off. > Instead

RE: [PATCH net-next v1] xen-netback: implement dynamic multicast control

2016-02-02 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 02 February 2016 11:09 > To: Paul Durrant > Cc: netdev@vger.kernel.org; xen-de...@lists.xenproject.org; Ian Campbell; > Wei Liu > Subject: Re: [PATCH net-next v1] xen-netback: implement dynamic multicast > control >

[PATCH net-next v2] xen-netback: implement dynamic multicast control

2016-02-02 Thread Paul Durrant
My recent patch to the Xen Project documents a protocol for 'dynamic multicast control' in netif.h. This extends the previous multicast control protocol to not require a shared ring reconnection to turn the feature off. Instead the backend watches the "request-multicast-control" key in xenstore

RE: [PATCH net-next v2] xen-netback: implement dynamic multicast control

2016-02-02 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 02 February 2016 11:47 > To: Paul Durrant > Cc: netdev@vger.kernel.org; xen-de...@lists.xenproject.org; Ian Campbell; > Wei Liu > Subject: Re: [PATCH net-next v2] xen-netback: implement dynamic multicast > control >

Re: [PATCH net-next v2] xen-netback: implement dynamic multicast control

2016-02-02 Thread Ian Campbell
On Tue, 2016-02-02 at 11:48 +, Paul Durrant wrote: > > -Original Message- > > From: Wei Liu [mailto:wei.l...@citrix.com] > > Sent: 02 February 2016 11:47 > > To: Paul Durrant > > Cc: netdev@vger.kernel.org; xen-de...@lists.xenproject.org; Ian > > Campbell; > > Wei Liu > > Subject: Re:

[PATCH net-next] ethtool: Declare netdev_rss_key as __read_mostly.

2016-02-02 Thread Kim Jones
netdev_rss_key is written to once and thereafter is read by drivers when they are initialising. The fact that it is mostly read and not written to makes it a candidate for a __read_mostly declaration. Signed-off-by: Kim Jones Signed-off-by: Alan Carey

RE: [PATCH net-next v2] xen-netback: implement dynamic multicast control

2016-02-02 Thread Paul Durrant
> -Original Message- > From: Ian Campbell [mailto:ian.campb...@citrix.com] > Sent: 02 February 2016 11:54 > To: Paul Durrant; Wei Liu > Cc: netdev@vger.kernel.org; xen-de...@lists.xenproject.org > Subject: Re: [PATCH net-next v2] xen-netback: implement dynamic multicast > control > > On

[PATCH] update be2net maintainers' email addresses

2016-02-02 Thread Sathya Perla
be2net maintainers' email addresses changed from avagotech.com to broadcom.com starting today. While updating the list, I'm also adding Somnath's name to the list. Signed-off-by: Sathya Perla --- MAINTAINERS | 9 + 1 file changed, 5 insertions(+), 4

Re: [PATCH net-next] virtio_net: add ethtool support for set and get of settings

2016-02-02 Thread Michael S. Tsirkin
On Tue, Feb 02, 2016 at 01:51:20PM +0100, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > This patch allows the user to set and retrieve speed and duplex of the > virtio_net device via ethtool. Having this functionality is very helpful > for simulating

[RFCv2 PATCH net-next 1/3] uapi: add MACsec bits

2016-02-02 Thread Sabrina Dubroca
Signed-off-by: Sabrina Dubroca Reviewed-by: Hannes Frederic Sowa --- RFCv2: - add include, detected by the kbuild robot - split off the attributes for RXSC and SA from enum macsec_attrs include/uapi/linux/Kbuild | 1 +

[RFCv2 PATCH net-next 3/3] macsec: introduce IEEE 802.1AE driver

2016-02-02 Thread Sabrina Dubroca
This is an implementation of MACsec/IEEE 802.1AE. This driver provides authentication and encryption of traffic in a LAN, typically with GCM-AES-128, and optional replay protection. http://standards.ieee.org/getieee802/download/802.1AE-2006.pdf Signed-off-by: Sabrina Dubroca

[RFCv2 PATCH net-next 2/3] net: add MACsec netdevice priv_flags and helper

2016-02-02 Thread Sabrina Dubroca
Signed-off-by: Sabrina Dubroca Reviewed-by: Hannes Frederic Sowa --- v2: add kerneldoc comment, detected by kbuild robot include/linux/netdevice.h | 8 1 file changed, 8 insertions(+) diff --git a/include/linux/netdevice.h

[RFCv2 PATCH net-next 0/3] MACsec IEEE 802.1AE implementation

2016-02-02 Thread Sabrina Dubroca
MACsec (IEEE 802.1AE [0]) is a protocol that provides security for wired ethernet LANs. MACsec offers two protection modes: authentication only, or authenticated encryption. MACsec defines "secure channels" that allow transmission from one node to one or more others. Communication on a channel

Re: [PATCH net] net: Allow flow dissector to handle non 4-byte aligned headers

2016-02-02 Thread Hannes Frederic Sowa
On 02.02.2016 04:56, Alexander Duyck wrote: @@ -394,7 +407,7 @@ ip_proto_again: data, hlen, &_eth); if (!eth) goto out_bad; - proto = eth->h_proto; +

[PATCH V6] netfilter: h323: avoid potential attack

2016-02-02 Thread Zhouyi Zhou
I think hackers chould build a malicious h323 packet to overflow the pointer p which will panic during the memcpy(addr, p, len) For example, he may fabricate a very large taddr->ipAddress.ip. In order to avoid this, I add a valid memory reference check in get_h2x5_addr functions. As suggested

[PATCH net-next v2 1/6] vxlan: cleanup types

2016-02-02 Thread Jiri Benc
include/net/vxlan.h is a kernel header, no need to prefix fixed size types with double underscore. Signed-off-by: Jiri Benc --- include/net/vxlan.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/net/vxlan.h b/include/net/vxlan.h

[PATCH net-next v2 0/6] vxlan: cleanup headers and tx path

2016-02-02 Thread Jiri Benc
This is first part of vxlan cleanup. It makes vxlan.h better organized and removes code duplication in the tx path. There's no change in functionality. This is in preparation for VXLAN-GPE support. Other sets will follow with cleanup of rx path, modifications of vxlan interface setup and

[RFC PATCH] bridge: mdb: add support for more attributes and export timer

2016-02-02 Thread Nikolay Aleksandrov
Hi, Sending this as an RFC to see first if it's acceptable at all to change the exported attribute and if the approach is okay with everyone. Since currently mdb entries are exported directly as a structure inside MDBA_MDB_ENTRY_INFO attribute, we can't really extend it without breaking

<    1   2   3   >