Re: [net-next PATCH 06/10] gre: Use GSO flags to determine csum need instead of GRE flags

On Fri, Feb 5, 2016 at 3:28 PM, Alexander Duyck wrote: > This patch updates the gre checksum path to follow something much closer to > the UDP checksum path. By doing this we can avoid needing to do as much > header inspection and can just make use of the fields we were

Re: [net-next PATCH 02/10] net: Move GSO csum into SKB_GSO_CB

On Fri, Feb 5, 2016 at 3:27 PM, Alexander Duyck wrote: > This patch moves the checksum maintained by GSO out of skb->csum and into > the GSO context block in order to allow for us to work on outer checksums > while maintaining the inner checksum offsets in the case of the

[PATCH net v2 2/4] net: phy: bcm7xxx: Fix 40nm EPHY features

The PHY entries for BCM7425/29/35 declare the 40nm Ethernet PHY as being 10/100/1000 capable, while this is just a 10/100 capable PHY device, fix that. Fixes: d068b02cfdfc2 ("net: phy: add BCM7425 and BCM7429 PHYs") Fixes: 9458ceab4917 ("net: phy: bcm7xxx: Add entry for BCM7435") Signed-off-by:

[PATCH net v2 3/4] net: phy: bcm7xxx: Fix bcm7xxx_config_init() check

Since we were wrongly advertising gigabit features for these 10/100 only Ethernet PHYs, bcm7xxx_config_init() which is supposed to apply workaround would have not run since the check would be true, now that we have fixed the PHY features, remove that check since it has no reasoning to be there

[PATCH net v2 4/4] net: phy: bcm7xxx: Remove wildcard entries

Remove the two wildcard entries, they serve no purpose and will match way too many devices, some of them being covered by the driver in drivers/net/phy/broadcom.c. Remove the now unused bcm7xxx_dummy_config_init() function which would produce a warning. Fixes: b560a58c45c6 ("net: phy: add

Re: [net-next PATCH 10/10] net: Allow tunnels to use inner checksum offloads with outer checksums needed

On Fri, Feb 5, 2016 at 3:28 PM, Alexander Duyck wrote: > This patch enables us to use inner checksum offloads if provided by > hardware with outer checksums computed by software. > > It basically reduces encap_hdr_csum to an advisory flag for now, but based > on the fact that

[PATCH net v2 0/4] net: phy: bcm7xxx 40nm PHY fixes

From: Florian Fainelli Hi David, Here is a collection of fixes for the 40nm Ethernet PHY supported by the 7xxx PHY driver, please also queue these fixes for stable. Changes in v2: - dropped the cleanup patch, not appropriate - added another patch removing bogus

[PATCH net v2 1/4] net: phy: bcm7xxx: Fix shadow mode 2 disabling

The clear and set masks in the call to phy_set_clr_bits() called from bcm7xxx_config_init() are inverted. We need to fix this by swapping the two arguments, that is, set 0 bits, but clear the shade mode 2 enable bit. Fixes: b560a58c45c66 ("net: phy: add Broadcom BCM7xxx internal PHY driver")

Re: [net-next PATCH 09/10] udp: Use uh->len instead of skb->len to compute checksum in segmentation

On Fri, Feb 5, 2016 at 3:28 PM, Alexander Duyck wrote: > The segmentation code was having to do a bunch of work to pull the > skb->len and strip the udp header offset before the value could be used to > adjust the checksum. Instead of doing all this work we can just use the

[PATCH net-next 1/2] net: phy: bcm7xxx: Make MII_BCM7XX_64CLK_MDIO naming consistent

The driver is BCM7xxx, we were missing an additional X in the constant naming, fix that to be consistent. Signed-off-by: Florian Fainelli --- drivers/net/phy/bcm7xxx.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/bcm7xxx.c

[PATCH net-next 2/2] net: phy: bcm7xxx: Reduce boilerplate code for 40nm EPHY

Introduce a macro which helps adding new 40NM EPHY entries and reduces the amount of boilerplate code. Signed-off-by: Florian Fainelli --- drivers/net/phy/bcm7xxx.c | 54 +++-- 1 files changed, 18 insertions(+), 36 deletions(-)

[PATCH net-next 0/2] net: phy: bcm7xxx: Misc cleanups

Hi David, These two patches are cleanups to the BCM7xxx internal PHY driver: - fix a constant name missing a X (as in BCM7XXX) - add a macro to reduce the amount of code duplication to add new entries Thanks! Florian Fainelli (2): net: phy: bcm7xxx: Make MII_BCM7XX_64CLK_MDIO naming

[PATCH v2] net: ethernet: davicom: fix devicetree irq resource

The dm9000 driver doesn't work in at least one device-tree configuration, spitting an error message on irq resource : [1.062495] dm9000 800.ethernet: insufficient resources [1.068439] dm9000 800.ethernet: not found (-2). [1.073451] dm9000: probe of 800.ethernet failed with

Re: [net-next PATCH 07/10] gre: Use inner_proto to obtain inner header protocol

On Fri, Feb 5, 2016 at 3:28 PM, Alexander Duyck wrote: > Instead of parsing headers to determine the inner protocol we can just pull > the value from inner_proto. > > Signed-off-by: Alexander Duyck > --- > net/ipv4/gre_offload.c |6 ++ > 1 file

Re: [net-next PATCH 08/10] udp: Clean up the use of flags in UDP segmentation offload

On Fri, Feb 5, 2016 at 3:28 PM, Alexander Duyck wrote: > This patch goes though and cleans up the logic related to several of the > control flags used in UDP segmentation. Specifically the use of dont_encap > isn't really needed as we can just check the skb for

Re: [net-next PATCH 05/10] net: Move skb_has_shared_frag check out of GRE code and into segmentation

On Fri, Feb 5, 2016 at 3:27 PM, Alexander Duyck wrote: > The call skb_has_shared_frag is used in the GRE path and skb_checksum_help > to verify that no frags can be modified by an external entity. This check > really doesn't belong in the GRE path but in the skb_segment

Re: [net-next PATCH 03/10] net: Update remote checksum segmentation to support use of GSO checksum

On Fri, Feb 5, 2016 at 3:27 PM, Alexander Duyck wrote: > This patch addresses two main issues. > > First in the case of remote checksum offload we were avoiding dealing with > scatter-gather issues. As a result it would be possible to assemble a > series of frames that used

Re: [PATCH] net: phy: dp83848: Add support for TI TLK10x Ethernet PHYs

Le 05/02/2016 15:13, Andrew F. Davis a écrit : > The TI TLK10x Ethernet PHYs are similar in the interrupt relevant > registers and so are compatible with the DP83848x devices already > supported. Add these and re-order code to support additional PHYs. This looks fine, but this could also be

Re: [PATCH net-next] tcp: fastopen: call tcp_fin() if FIN present in SYNACK

From: Eric Dumazet Date: Sat, 06 Feb 2016 11:16:28 -0800 > From: Eric Dumazet > > When we acknowledge a FIN, it is not enough to ack the sequence number > and queue the skb into receive queue. We also have to call tcp_fin() > to properly update

Re: [net-next PATCH 01/10] net: Drop unecessary enc_features variable from tunnel segmentation functions

On Fri, Feb 5, 2016 at 3:27 PM, Alexander Duyck wrote: > The enc_features variable isn't necessary since features isn't used > anywhere after we create enc_features so instead just use a destructive AND > on features itself and save ourselves the variable declaration. > >

[PATCH v2] net: smc91x: propagate irq return code

The smc91x driver doesn't honor the probe deferral mechanism when the interrupt source is not yet available, such as one provided by a gpio controller not probed. Fix this by propagating the platform_get_irq() error code as the probe return value. Signed-off-by: Robert Jarzmik

[PATCH 2/2] ravb: skip gPTP start/stop on R-Car gen3

When adding support for the R-Car gen3 gPTP active in configuration mode, some call sites of ravb_ptp_{init|stop}() were missed due to an oversight. Add checks for the R-Car gen2 SoCs around these... Fixes: f5d7837f96e5 ("ravb: ptp: Add CONFIG mode support") Signed-off-by: Sergei Shtylyov

[PATCH 1/2] ravb: kill duplicate setting of CCC.CSEL

When adding support for the R-Car gen3 gPTP active in configuration mode, the code setting the CCC.CSEL field was duplicated due to an oversight. For R-Car gen 2 it's just redundant and for R-Car gen3 the write at this time is probably ignored due to CCC.GAC bit being already set... Fixes:

Re: [PATCH net] net: dsa: mv88e6xxx: fix software VLAN deletion

On Fri, Feb 05, 2016 at 02:04:39PM -0500, Vivien Didelot wrote: > The current bridge code calls switchdev_port_obj_del on a VLAN port even > if the corresponding switchdev_port_obj_add call returned -EOPNOTSUPP. > > If the DSA driver doesn't return -EOPNOTSUPP for a software port VLAN in > its

Re: [PATCH net-next 0/2] tcp: fastopen: accept data/FIN present in SYNACK

On Sat, 2016-02-06 at 03:13 -0500, David Miller wrote: > From: Eric Dumazet > Date: Mon, 1 Feb 2016 21:03:06 -0800 > > > Implements RFC 7413 (TCP Fast Open) 4.2.2, accepting payload and/or FIN > > in SYNACK messages, and prepare removal of SYN flag in tcp_recvmsg() > >

[PATCH net-next] tcp: fastopen: call tcp_fin() if FIN present in SYNACK

From: Eric Dumazet When we acknowledge a FIN, it is not enough to ack the sequence number and queue the skb into receive queue. We also have to call tcp_fin() to properly update socket state and send proper poll() notifications. It seems we also had the problem if we

Re: [PATCH v2 net-next 2/4] net: dev: add batching to net_device notifiers

Hello, On Thu, 4 Feb 2016, Salam Noureddine wrote: > @@ -1572,12 +1583,17 @@ rollback: > call_netdevice_notifier(nb, NETDEV_GOING_DOWN, > dev); > call_netdevice_notifier(nb,

Re: [PATCH net-next 2/2] mpls: allow TTL propagation to/from IP packets to be configured

Robert Shearman writes: > It is sometimes desirable to present an MPLS transport network as a > single hop to traffic transiting it because it prevents confusion when > diagnosing failures. An example of where confusion can be generated is > when addresses used in the

Re: [patch net-next RFC 0/6] Introduce devlink interface and first drivers to use it

Fri, Feb 05, 2016 at 06:38:42PM CET, alexei.starovoi...@gmail.com wrote: >On Fri, Feb 05, 2016 at 11:01:22AM +0100, Hannes Frederic Sowa wrote: >> >> Okay. I see it more as changing mode of operation of hardware and thus has >> not really anything to do with networking. If you say you change

Re: [PATCH net] net: dsa: mv88e6xxx: do not leave reserved VLANs

On Fri, Feb 05, 2016 at 02:07:14PM -0500, Vivien Didelot wrote: > BRIDGE_VLAN_FILTERING automatically adds a newly bridged port to the > VLAN with the bridge's default_pvid. > > The mv88e6xxx driver currently reserves VLANs 4000+ for unbridged ports > isolation. When a port joins a bridge, it

Re: [2/3] net: wireless: rt2x00: Pointer issue

> Code Style: pointer is declared wrong > > Signed-off-by: Paul McQuade > Acked-by: Helmut Schaa This patch didn't apply, so please resend. Kalle

Re: [1/3] net: wireless: rt2x00: Space issue

> Removed empty spaces before/after parenthesis > > Signed-off-by: Paul McQuade > Acked-by: Helmut Schaa Thanks, 2 patches applied to wireless-drivers-next.git: b2cc2dd8ebb8 net: wireless: rt2x00: Space issue 5b451715e94d net: wireless:

Re: net: wireless: rt2x00: Fixed Spacing issues

> Removed empty spaces before/after parenthesis > > Signed-off-by: Paul McQuade > Acked-by: Helmut Schaa Thanks, applied to wireless-drivers-next.git. Kalle Valo

[PATCH iproute2 master resend 1/4] tc, bpf, examples: further bpf_api improvements

Add a couple of improvements to tc's BPF api, that facilitate program development. Signed-off-by: Daniel Borkmann --- examples/bpf/bpf_cyclic.c | 4 +--- examples/bpf/bpf_graft.c| 13 +++ examples/bpf/bpf_prog.c | 26 ++---

[PATCH iproute2 master resend 4/4] tc, bpf: use bind/type macros from gelf

Don't reimplement them and rather use the macros from the gelf header, that is, GELF_ST_BIND()/GELF_ST_TYPE(). Signed-off-by: Daniel Borkmann --- tc/tc_bpf.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tc/tc_bpf.c b/tc/tc_bpf.c index

[PATCH iproute2 master resend 2/4] tc, bpf: improve verifier logging

With a bit larger, branchy eBPF programs f.e. already ~BPF_MAXINSNS/7 in size, it happens rather quickly that bpf(2) rejects also valid programs when only the verifier log buffer size we have in tc is too small. Change that, so by default we don't do any logging, and only in error case we retry

[PATCH iproute2 master resend 0/4] Minor BPF updates on frontend

Couple of minor updates on tc frontend. Resending with no changes and with John's Acked-by kept, orignal version got set to 'Changes requested' by mistake. Thanks! Daniel Borkmann (4): tc, bpf, examples: further bpf_api improvements tc, bpf: improve verifier logging tc, bpf: give some

Re: [PATCH v2 net-next 4/4] net: fib: avoid calling fib_flush for each device when doing batch close and unregister

On Fri, Feb 5, 2016 at 8:04 AM, Sergei Shtylyov wrote: > On 02/05/2016 02:35 AM, Salam Noureddine wrote: >> >> if (event == NETDEV_UNREGISTER) { >> - fib_disable_ip(dev, event, true); >> + if (fib_sync_down_dev(dev, event,

Re: [PATCH v2 net-next 2/4] net: dev: add batching to net_device notifiers

On Sat, Feb 6, 2016 at 10:58 AM, Julian Anastasov wrote: > > I now see that we should split the loop > here, so that NETDEV_DOWN_BATCH is called only once per net: > > bool down = false; > > for_each_netdev(net, dev) { >

[PATCH] netfilter: nft_counter: fix erroneous return values

The nft_counter_init() and nft_counter_clone() functions should return negative error value -ENOMEM instead of positive ENOMEM. Signed-off-by: Anton Protopopov --- net/netfilter/nft_counter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] bonding: Return correct error code

The return value of kzalloc on failure of allocation of memory should be -ENOMEM and not -1. Found using Coccinelle. A simplified version of the semantic patch used is: // @@ expression *e; @@ e = kzalloc(...); if (e == NULL) { ... return - -1 + -ENOMEM ; } // The single call site only checks

Re: [PATCH net v3 0/4] net: add and use rx_nohandler stat counter

From: Jarod Wilson Date: Mon, 1 Feb 2016 18:51:03 -0500 ... > It seems additional counters never came to fruition, so this is a first > attempt at creating one of them, so that we stop calling these drops, > which for users monitoring rx_dropped, causes great alarm, and

Re: [PATCH v2] ipv6: addrconf: Fix recursive spin lock call

From: subas...@codeaurora.org Date: Tue, 2 Feb 2016 02:11:10 - > A rcu stall with the following backtrace was seen on a system with > forwarding, optimistic_dad and use_optimistic set. To reproduce, > set these flags and allow ipv6 autoconf. > > This occurs because the device write_lock is

Re: [PATCH net-next 1/2] mpls: packet stats

Robert Shearman : [...] > diff --git a/net/mpls/Makefile b/net/mpls/Makefile > index 9ca923625016..6fdd61b9eae3 100644 > --- a/net/mpls/Makefile > +++ b/net/mpls/Makefile [...] > @@ -98,6 +94,29 @@ bool mpls_pkt_too_big(const struct sk_buff *skb, unsigned > int mtu) > } >

Re: [v2] hostap: avoid uninitialized variable use in hfa384x_get_rid

> The driver reads a value from hfa384x_from_bap(), which may fail, > and then assigns the value to a local variable. gcc detects that > in in the failure case, the 'rlen' variable now contains > uninitialized data: > > In file included from >

Re: [net-next 13/20] i40evf: add new write-back mode

Hello. On 2/4/2016 2:49 PM, Jeff Kirsher wrote: From: Anjali Singhai Jain Add write-back on interrupt throttle rate timer expiration support for the i40evf driver, when running on X722 devices. Signed-off-by: Anjali Singhai Jain

Re: [PATCH net v4] r8169: Add bios support.

On Sat, 2016-02-06 at 02:39 -0500, David Miller wrote: > From: Corcodel Marian > Date: Sat, 6 Feb 2016 08:31:26 +0200 > > > @@ -8262,8 +8262,9 @@ static int rtl_init_one(struct pci_dev *pdev, > const struct pci_device_id *ent) > > rtl_hw_reset(tp); > > > >

Reply: [net] bonding: use return instead of goto

> On Fri, Feb 05, 2016 at 09:42:24AM +0800, 张胜举 wrote: > > > On Wed, Feb 03, 2016 at 06:15:22AM +, Zhang Shengju wrote: > > > > Replace 'goto' with 'return' to remove unnecessary check at label: > > > > err_undo_flags. > > > > > > I think you're going to have to explain how you came to the > >

Re: [PATCH net-next v2 00/10] tipc: cleanups, fixes & improvements for topology server

From: Parthasarathy Bhuvaragan Date: Tue, 2 Feb 2016 10:52:07 +0100 > This series contains topology server cleanups, fixes and improvements. > > Cleanups in #1-#4: > We remove duplicate data structures and aligin the rest of the code > accordingly. > >

Re: brcmfmac: sdio: Increase the default timeouts a bit

> On a Radxa Rock2 board with a Ampak AP6335 (Broadcom 4339 core) it seems > the card responds very quickly most of the time, unfortunately during > initialisation it sometimes seems to take just a bit over 2 seconds to > respond. > > This results intialization failing with message like: >

Re: [PATCH net-next V2 7/8] net: fec: don't transfer ownership until descriptor write is complete

Hello. On 2/6/2016 12:52 AM, Troy Kisky wrote: If you don't own it, you shouldn't write to it. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] net: smc911x: convert pxa dma to dmaengine

David Miller writes: > From: Robert Jarzmik > Date: Fri, 05 Feb 2016 22:44:56 +0100 > >> Apart from Alberto who answered he cannot test it by lack of hardware, the >> others didn't answer. >> >> So how can I move forward ? Would you want me to amend

Re: [PATCH net-next 0/2] tcp: fastopen: accept data/FIN present in SYNACK

From: Eric Dumazet Date: Mon, 1 Feb 2016 21:03:06 -0800 > Implements RFC 7413 (TCP Fast Open) 4.2.2, accepting payload and/or FIN > in SYNACK messages, and prepare removal of SYN flag in tcp_recvmsg() Series applied, thanks Eric.

Re: [PATCH] bgmac: add helper checking for BCM4707 / BCM53018 chip id

From: Rafał Miłecki Date: Tue, 2 Feb 2016 07:47:14 +0100 > Chipsets with BCM4707 / BCM53018 ID require special handling at a few > places in the code. It's likely there will be more IDs to check in the > future. To simplify it add this trivial helper. > > Signed-off-by: Rafał

Re: [PATCH] dscc4: Undefined signed int shift

Michael McConville : > My analysis in the below mail applies, although the second part is > unnecessary because i isn't used in arithmetic operations here: > > https://marc.info/?l=openbsd-tech=145377854103866=2 > > Thanks for your time. Acked-by: Francois Romieu

[PATCH 0/2] ravb: fix the fallout of R-Car gen3 gPTP support

Hello. Here's a set of 2 patches against DaveM's 'net.git' repo fixing up the incomplete commit f5d7837f96e5 ("ravb: ptp: Add CONFIG mode support"). I'm proposing these as fixes but they can be merged as cleanups as well... [1/2] ravb: kill duplicate setting of CCC.CSEL [2/2] ravb: skip gPTP