Re: [PATCH 2/2] net, thunderx: Use bool in structs where possible

2016-02-18 Thread David Miller
From: Robert Richter Date: Thu, 18 Feb 2016 17:42:17 +0100 > On 18.02.16 11:05:14, David Miller wrote: >> From: Robert Richter >> Date: Thu, 18 Feb 2016 13:39:09 +0100 >> >> > From: Robert Richter >> > >> > Looks like the :1 notation was accidentally introduced (this still >> > uses 1 byte pe

Re: [PATCHv2 3/4] ARM: tegra: use build-in device properties with rfkill_gpio

2016-02-18 Thread Johannes Berg
On Tue, 2016-01-26 at 09:42 +0100, Johannes Berg wrote: > On Mon, 2016-01-25 at 13:18 +0100, Thierry Reding wrote: > >   > > Johannes, I assume that you'll want to take this through your tree > > because of the dependency? In that case: > > > > Acked-by: Thierry Reding > > I can, but I don't rea

Re: [PATCH net] vxlan: do not use fdb in metadata mode

2016-02-18 Thread David Miller
From: Jiri Benc Date: Tue, 16 Feb 2016 22:18:26 +0100 > In metadata mode, the vxlan interface is not supposed to use the fdb control > plane but an external one (openvswitch or static routes). With the current > code, packets may leak into the fdb handling code which usually causes them > to be d

Re: [PATCH] appletalk: fix erroneous return value

2016-02-18 Thread David Miller
From: Anton Protopopov Date: Wed, 17 Feb 2016 10:53:59 -0500 > The atalk_sendmsg() function might return wrong value ENETUNREACH > instead of -ENETUNREACH. > > Signed-off-by: Anton Protopopov Applied.

[PATCH V6 6/8] i40e: queue-specific settings for interrupt moderation

2016-02-18 Thread Kan Liang
From: Kan Liang For i40e driver, each vector has its own ITR register. However, there are no concept of queue-specific settings in the driver proper. Only global variable is used to store ITR values. That will cause problems especially when resetting the vector. The specific ITR values could be l

[PATCH V8 2/8] test_bitmap: unit tests for lib/bitmap.c

2016-02-18 Thread Kan Liang
From: David Decotigny This is mainly testing bitmap construction and conversion to/from u32[] for now. Tested: qemu i386, x86_64, ppc, ppc64 BE and LE, ARM. Signed-off-by: David Decotigny --- lib/Kconfig.debug | 8 + lib/Makefile | 1 + lib/t

[PATCH V6 3/8] net/ethtool: introduce a new ioctl for per queue setting

2016-02-18 Thread Kan Liang
From: Kan Liang Introduce a new ioctl ETHTOOL_PERQUEUE for per queue parameters setting. The following patches will enable some SUB_COMMANDs for per queue setting. Signed-off-by: Kan Liang Reviewed-by: Ben Hutchings --- include/uapi/linux/ethtool.h | 17 + net/core/ethtool.c

[PATCH V8 1/8] lib/bitmap.c: conversion routines to/from u32 array

2016-02-18 Thread Kan Liang
From: David Decotigny Aimed at transferring bitmaps to/from user-space in a 32/64-bit agnostic way. Tested: unit tests (next patch) on qemu i386, x86_64, ppc, ppc64 BE and LE, ARM. Signed-off-by: David Decotigny Reviewed-by: Ben Hutchings --- include/linux/bitmap.h | 10 ++ lib/bitma

[PATCH V6 7/8] i40e/ethtool: support coalesce getting by queue

2016-02-18 Thread Kan Liang
From: Kan Liang This patch implements get_per_queue_coalesce for i40e driver. Signed-off-by: Kan Liang --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e

Re: [PATCH] net: caif: fix erroneous return value

2016-02-18 Thread David Miller
From: Anton Protopopov Date: Wed, 17 Feb 2016 10:54:13 -0500 > The cfrfml_receive() function might return positive value EPROTO > > Signed-off-by: Anton Protopopov Applied.

Re: [PATCH] mISDN: prevent possible NULL pointer dereference

2016-02-18 Thread David Miller
From: Anton Protopopov Date: Wed, 17 Feb 2016 11:19:56 -0500 > A return value of the bchannel_get_rxbuf() function is compared with the > positive ENOMEM value instead of the negative -ENOMEM value to detect a > memory allocation problem. Thus, after a possible memory allocation > failure the bc-

[PATCH V6 8/8] i40e/ethtool: support coalesce setting by queue

2016-02-18 Thread Kan Liang
From: Kan Liang This patch implements set_per_queue_coalesce for i40e driver. Signed-off-by: Kan Liang --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e

[PATCH V6 5/8] net/ethtool: support set coalesce per queue

2016-02-18 Thread Kan Liang
From: Kan Liang This patch implements sub command ETHTOOL_SCOALESCE for ioctl ETHTOOL_PERQUEUE. It introduces an interface set_per_queue_coalesce to set coalesce of each masked queue to device driver. The wanted coalesce information are stored in "data" for each masked queue, which can copy from

[PATCH V6 4/8] net/ethtool: support get coalesce per queue

2016-02-18 Thread Kan Liang
From: Kan Liang This patch implements sub command ETHTOOL_GCOALESCE for ioctl ETHTOOL_PERQUEUE. It introduces an interface get_per_queue_coalesce to get coalesce of each masked queue from device driver. Then the interrupt coalescing parameters will be copied back to user space one by one. Signed

[PATCH V6 0/8] ethtool per queue parameters support

2016-02-18 Thread Kan Liang
Modern network interface controllers usually support multiple receive and transmit queues. Each queue may have its own parameters. For example, Intel XL710/X710 hardware supports per queue interrupt moderation. However, current ethtool does not support per queue parameters option. User has to set p

Re: [PATCH v2] lance: Return correct error code

2016-02-18 Thread David Miller
From: Amitoj Kaur Chawla Date: Wed, 17 Feb 2016 20:33:26 +0530 > Failure of kzalloc should cause the enclosing function > to return -ENOMEM, not -ENODEV. > > Additionally, removed the following checkpatch warnings: > ERROR: spaces required around that '==' (ctx:VxV) > ERROR: space required befor

Re: [net PATCH] IFF_NO_QUEUE: Fix for drivers not calling ether_setup()

2016-02-18 Thread David Miller
From: Phil Sutter Date: Wed, 17 Feb 2016 15:37:43 +0100 > My implementation around IFF_NO_QUEUE driver flag assumed that leaving > tx_queue_len untouched (specifically: not setting it to zero) by drivers > would make it possible to assign a regular qdisc to them without having > to worry about se

Re: [PATCH net] vxlan: clear IFF_TX_SKB_SHARING

2016-02-18 Thread David Miller
From: Jiri Benc Date: Tue, 16 Feb 2016 22:16:53 +0100 > ether_setup sets IFF_TX_SKB_SHARING but this is not supported by vxlan as it > modifies the skb on xmit. > > Signed-off-by: Jiri Benc Applied.

Re: [PATCH net] geneve: clear IFF_TX_SKB_SHARING

2016-02-18 Thread David Miller
From: Jiri Benc Date: Wed, 17 Feb 2016 15:31:35 +0100 > ether_setup sets IFF_TX_SKB_SHARING but this is not supported by geneve as > it modifies the skb on xmit. > > Signed-off-by: Jiri Benc Applied.

Re: [PATCH net] gre: clear IFF_TX_SKB_SHARING

2016-02-18 Thread David Miller
From: Jiri Benc Date: Wed, 17 Feb 2016 15:32:53 +0100 > ether_setup sets IFF_TX_SKB_SHARING but this is not supported by gre as it > modifies the skb on xmit. > > Also, clean up whitespace in ipgre_tap_setup when we're already touching it. > > Signed-off-by: Jiri Benc Applied.

[PATCH iproute2] iplink: bridge: remove unnecessary returns

2016-02-18 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov invarg exits so no need to return, remove this c&p error from my recent patches Signed-off-by: Nikolay Aleksandrov --- ip/iplink_bridge.c | 50 -- 1 file changed, 20 insertions(+), 30 deletions(-) diff --git a/ip/iplink

[PATCH v1 2/4] soc: ti: knav_dma: rename pad in struct knav_dma_desc to sw_data

2016-02-18 Thread Murali Karicheri
Rename the pad to sw_data as per description of this field in the hardware spec(refer sprugr9 from www.ti.com). Latest version of the document is at http://www.ti.com/lit/ug/sprugr9h/sprugr9h.pdf and section 3.1 Host Packet Descriptor describes this field. Also define and use a constant for the si

Re: [PATCH net-next v8 05/19] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

2016-02-18 Thread David Decotigny
Sure, I will send an update: struct ethtool_link_settings { __u32 cmd; __u32 speed; __u8duplex; __u8port; __u8phy_address; __u8autoneg; __u8mdio_support; __u8eth_tp_mdix; __u8eth_tp_mdix_ctrl;

[PATCH v1 1/4] net: ti: netcp: restore get/set_pad_info() functionality

2016-02-18 Thread Murali Karicheri
From: Arnd Bergmann The commit 899077791403 ("netcp: try to reduce type confusion in descriptors") introduces a regression in Kernel 4.5-rc1 and it breaks get/set_pad_info() functionality. The TI NETCP driver uses pad0 and pad1 fields of knav_dma_desc to store DMA/MEM buffer pointer and buffer s

[PATCH v1 4/4] net: netcp: rework the code for get/set sw_data in dma desc

2016-02-18 Thread Murali Karicheri
SW data field in descriptor can be used by software to hold private data for the driver. As there are 4 words available for this purpose, use separate macros to place it or retrieve the same to/from descriptors. Also do type cast of data types accordingly. Cc: Wingman Kwok Cc: Mugunthan V N CC:

[PATCH v1 3/4] net: netcp: rename {get/set}pad_info to {get/set}_sw_data

2016-02-18 Thread Murali Karicheri
Rename the helpers to match with the updated dma desc field sw_data. Cc: Wingman Kwok Cc: Mugunthan V N CC: Arnd Bergmann CC: Grygorii Strashko CC: David Laight Signed-off-by: Murali Karicheri --- v1 - new patch to based on discussion at https://patchwork.ozlabs.org/patch/580860/ d

Re: [PATCH net-next 0/4] iptunnel: scrub packet in iptunnel_pull_header

2016-02-18 Thread David Miller
From: Jiri Benc Date: Thu, 18 Feb 2016 11:22:48 +0100 > As every IP tunnel has to scrub skb on decapsulation, iptunnel_pull_header > tried to do that and open coded part of skb_scrub_packet. Various tunneling > protocols (VXLAN, Geneve) then called full skb_scrub_packet on their own, > duplicatin

Re: [PATCH v7 0/8] Patchset enabling hardware based cross-timestamps for next gen Intel platforms

2016-02-18 Thread John Stultz
On Fri, Feb 12, 2016 at 12:25 PM, Christopher S. Hall wrote: > Modern Intel hardware adds an Always Running Timer (ART) that allows the > network and audio device clocks to precisely cross timestamp the device > clock with the system clock. This allows a precise correlation of the > device time an

Re: [PATCH net-next] net: bridge: log port STP state on change

2016-02-18 Thread David Miller
From: Vivien Didelot Date: Tue, 16 Feb 2016 10:09:51 -0500 > Remove the shared br_log_state function and print the info directly in > br_set_state, where the net_bridge_port state is actually changed. > > Signed-off-by: Vivien Didelot Applied, thanks Vivien.

Re: [PATCH net-next 0/2] cxgb4: Use __dev_[um]c_[un]sync for MAC address syncing

2016-02-18 Thread David Miller
From: Hariprasad Shenai Date: Tue, 16 Feb 2016 10:07:08 +0530 > This patch series adds support to use __dev_uc_sync/__dev_mc_sync to add > MAC address and __dev_uc_unsync/__dev_mc_unsync to delete MAC address. > > This patch series has been created against net-next tree and includes > patches on

RE: [PATCH V6 2/8] test_bitmap: unit tests for lib/bitmap.c

2016-02-18 Thread Liang, Kan
> > From: Kan Liang > Date: Tue, 16 Feb 2016 07:32:38 -0500 > > > @@ -43,6 +43,7 @@ obj-$(CONFIG_TEST_USER_COPY) += > test_user_copy.o > > obj-$(CONFIG_TEST_STATIC_KEYS) += test_static_keys.o > > obj-$(CONFIG_TEST_STATIC_KEYS) += test_static_key_base.o > > obj-$(CONFIG_TEST_PRINTF) += test_pr

Re: [PATCH V6 2/8] test_bitmap: unit tests for lib/bitmap.c

2016-02-18 Thread David Miller
From: Kan Liang Date: Tue, 16 Feb 2016 07:32:38 -0500 > @@ -43,6 +43,7 @@ obj-$(CONFIG_TEST_USER_COPY) += test_user_copy.o > obj-$(CONFIG_TEST_STATIC_KEYS) += test_static_keys.o > obj-$(CONFIG_TEST_STATIC_KEYS) += test_static_key_base.o > obj-$(CONFIG_TEST_PRINTF) += test_printf.o > +obj-$(CON

[PATCH] mrf24j40: fix security-enabled processing on inbound frames

2016-02-18 Thread zopieux
Fix the MRF24J40 handling of security-enabled frames so it does not block upon receiving such frames. Signed-off-by: Alexander Aring Reported-by: Alexandre Macabies Tested-by: Alexandre Macabies --- When receiving a security-enabled IEEE 802.15.4 frame, the MRF24J40 triggers a SECIF interrupt t

Re: [PATCH net-next] vxlan: tun_id is 64bit, not 32bit

2016-02-18 Thread Thadeu Lima de Souza Cascardo
On Thu, Feb 18, 2016 at 07:19:29PM +0100, Jiri Benc wrote: > The tun_id field in struct ip_tunnel_key is __be64, not __be32. We need to > convert the vni to tun_id correctly. > > Fixes: 54bfd872bf16 ("vxlan: keep flags and vni in network byte order") > Reported-by: Paolo Abeni > Tested-by: Paolo

Re: [PATCH net v3] geneve: Refine MTU limit

2016-02-18 Thread Jesse Gross
On Thu, Feb 18, 2016 at 9:43 AM, David Wragg wrote: > Calculate the maximum MTU taking into account the size of headers > involved in GENEVE encapsulation, as for other tunnel types. > > Changes in v3: > - Correct comment style > Changes in v2: > - Conform more closely to ip_tunnel_change_mtu > -

[PATCH net-next] vxlan: tun_id is 64bit, not 32bit

2016-02-18 Thread Jiri Benc
The tun_id field in struct ip_tunnel_key is __be64, not __be32. We need to convert the vni to tun_id correctly. Fixes: 54bfd872bf16 ("vxlan: keep flags and vni in network byte order") Reported-by: Paolo Abeni Tested-by: Paolo Abeni Signed-off-by: Jiri Benc --- drivers/net/vxlan.c | 5 +++-- in

Re: [PATCH next v3 1/3] ipvlan: scrub skb before routing in L3 mode.

2016-02-18 Thread Cong Wang
On Wed, Feb 17, 2016 at 7:52 PM, Mahesh Bandewar wrote: > From: Mahesh Bandewar > > Scrub skb before hitting the iptable hooks to ensure packets hit > these hooks in master's namespace. > > Signed-off-by: Mahesh Bandewar > --- > drivers/net/ipvlan/ipvlan_core.c | 4 ++-- > 1 file changed, 2 ins

Re: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev

2016-02-18 Thread Tejun Heo
Hello, Can you please do the followings? 1. Remove WQ_MEM_RECLAIM from the affected workqueue and see whether the problem is reproducible. WQ_MEM_RECLAIM on anything bluetooth doesn't make sense btw. Why is it there? 2. If WQ_MEM_RECLAIM makes the issue go away, see whether the attached

[PATCH net v3] geneve: Refine MTU limit

2016-02-18 Thread David Wragg
Calculate the maximum MTU taking into account the size of headers involved in GENEVE encapsulation, as for other tunnel types. Changes in v3: - Correct comment style Changes in v2: - Conform more closely to ip_tunnel_change_mtu - Exclude GENEVE options from max MTU calculation Signed-off-by: Davi

Re: [PATCH net v2] geneve: Refine MTU limit

2016-02-18 Thread David Wragg
Wrong comment style, fixed in v3. David

Re: [PATCH v2 net-next 0/8] API set for HW Buffer management

2016-02-18 Thread Gregory CLEMENT
Hi Willy, On mer., févr. 17 2016, Willy Tarreau wrote: > Hi Gregory, > > On Tue, Feb 16, 2016 at 04:33:35PM +0100, Gregory CLEMENT wrote: >> Hello, >> >> A few weeks ago I sent a proposal for a API set for HW Buffer >> management, to have a better view of the motivation for this API see >> th

re

2016-02-18 Thread info
Good Day Do you need an urgent business and personal loan at 2% rate?Kindly contact us now via (customerservi...@24hoursloan.com) for more information! Regard Tishman Niles

Re: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality

2016-02-18 Thread Murali Karicheri
On 02/16/2016 03:24 PM, David Miller wrote: > > I would like some of the feedback to be taken into consideration and > integrated into this patch. > > Part of the reason this regression was introduced was probably because > the purpose of some fields or descriptor semantics was not defined > prop

Re: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality

2016-02-18 Thread Murali Karicheri
On 02/09/2016 02:38 PM, Arnd Bergmann wrote: > On Tuesday 09 February 2016 16:55:42 Karicheri, Muralidharan wrote: >> >> The descriptors are usable by different drivers, one driver may use it as >> buf ptr/ len, other for something else. So they should remain as generic >> and it is up to individu

Re: [PATCH net-next V1 04/12] net/mlx5e: Support DCBNL IEEE ETS

2016-02-18 Thread Or Gerlitz
On Thu, Feb 18, 2016 at 12:32 PM, Saeed Mahameed wrote: > @@ -2164,6 +2233,9 @@ static void mlx5e_build_netdev(struct net_device > *netdev) > netdev->watchdog_timeo= 15 * HZ; > > netdev->ethtool_ops = &mlx5e_ethtool_ops; > +#ifdef CONFIG_MLX5_CORE_EN_DCB > + netde

Re: [PATCH net v2 2/3] geneve: Relax MTU constraints

2016-02-18 Thread David Wragg
Tom Herbert writes: > Please implement like in ip_tunnel_change_mtu (or better yet call it), > that is the precedent for tunnels. I've made geneve_change_mtu follow ip_tunnel_change_mtu in v2. If it were to call it instead, are you suggesting just passing in t_hlen? Or restructuring geneve.c to

Re: [PATCH -next 0/5] netlink: remove mmapped netlink support

2016-02-18 Thread David Miller
From: Florian Westphal Date: Thu, 18 Feb 2016 15:03:23 +0100 > As discussed during netconf 2016 in Seville, this series removes > CONFIG_NETLINK_MMAP. Series applied, thanks for following up on this so quickly.

Re: [PATCH 2/2] net, thunderx: Use bool in structs where possible

2016-02-18 Thread Robert Richter
On 18.02.16 11:05:14, David Miller wrote: > From: Robert Richter > Date: Thu, 18 Feb 2016 13:39:09 +0100 > > > From: Robert Richter > > > > Looks like the :1 notation was accidentally introduced (this still > > uses 1 byte per flag). Using bool instead, which is the common use. > > > > Signed-

Re: [PATCH net] geneve: Refine MTU limit

2016-02-18 Thread David Wragg
Jesse Gross writes: > In addition to Tom's comment about taking into account > dev->hard_header_len, can you please not include > GENEVE_MAX_OPTIONS_LEN in the MTU calculation based on the discussion > on the other thread? Otherwise, you are excluding some potentially > valid configurations. Addr

[PATCH net v2] geneve: Refine MTU limit

2016-02-18 Thread David Wragg
Calculate the maximum MTU taking into account the size of headers involved in GENEVE encapsulation, as for other tunnel types. Changes in v2: - Conform more closely to ip_tunnel_change_mtu - Exclude GENEVE options from max MTU calculation Signed-off-by: David Wragg --- drivers/net/geneve.c | 28

Re: [PATCH net] tcp/dccp: fix another race at listener dismantle

2016-02-18 Thread David Miller
From: Eric Dumazet Date: Thu, 18 Feb 2016 05:39:18 -0800 > Ilya reported following lockdep splat: ... > To properly fix this issue, inet_csk_reqsk_queue_add() needs > to return to its callers if the child as been queued > into accept queue. > > We also need to make sure listener is still there

Re: [PATCH] b43: fix memory leak

2016-02-18 Thread Michael Büsch
On Thu, 18 Feb 2016 18:04:36 +0530 Sudip Mukherjee wrote: > From: Sudip Mukherjee > > On error we jumped to the label bcma_out and returned the error code but > we missed freeing dev. > > Signed-off-by: Sudip Mukherjee > --- > drivers/net/wireless/broadcom/b43/main.c | 1 + > 1 file changed,

Re: [PATCH net] route: check and remove route cache when we get route

2016-02-18 Thread David Miller
From: Xin Long Date: Thu, 18 Feb 2016 21:21:19 +0800 > Since the gc of ipv4 route was removed, the route cached would has > no chance to be removed, and even it has been timeout, it still could > be used, cause no code to check it's expires. > > Fix this issue by checking and removing route cac

Re: [net-next PATCH 1/1] net_sched: Improve readability of filter processing

2016-02-18 Thread David Miller
From: Jamal Hadi Salim Date: Thu, 18 Feb 2016 08:04:43 -0500 > From: Jamal Hadi Salim > > Signed-off-by: Jamal Hadi Salim Applied.

Re: [patch net-next] bridge: switchdev: Offload VLAN flags to hardware bridge

2016-02-18 Thread David Miller
From: Jiri Pirko Date: Thu, 18 Feb 2016 14:01:46 +0100 > From: Ido Schimmel > > When VLANs are created / destroyed on a VLAN filtering bridge (MASTER > flag set), the configuration is passed down to the hardware. However, > when only the flags (e.g. PVID) are toggled, the configuration is done

Re: [net PATCH v3 1/1] net_sched fix: reclassification needs to consider ether protocol changes

2016-02-18 Thread David Miller
From: Jamal Hadi Salim Date: Thu, 18 Feb 2016 07:38:04 -0500 > From: Jamal Hadi Salim > > actions could change the etherproto in particular with ethernet > tunnelled data. Typically such actions, after peeling the outer header, > will ask for the packet to be reclassified. We then need to rest

Re: [PATCH] net: phy: Add SGMII support for Marvell 88E1510/1512/1514/1518

2016-02-18 Thread David Miller
From: Stefan Roese Date: Thu, 18 Feb 2016 10:59:07 +0100 > Add code to select SGMII-to-copper mode upon SGMII interface selection. > > Signed-off-by: Stefan Roese Applied to net-next, thanks.

Re: [RESEND PATCH v3] isdn: divamnt: use y2038-safe ktime_get_ts64() for trace data timestamps

2016-02-18 Thread David Miller
From: Alison Schofield Date: Wed, 17 Feb 2016 22:35:11 -0800 > divamnt stores a start_time at module init and uses it to calculate > elapsed time. The elapsed time, stored in secs and usecs, is part of > the trace data the driver maintains for the DIVA Server ISDN cards. > No change to the format

Re: [PATCH 2/2] net, thunderx: Use bool in structs where possible

2016-02-18 Thread David Miller
From: Robert Richter Date: Thu, 18 Feb 2016 13:39:09 +0100 > From: Robert Richter > > Looks like the :1 notation was accidentally introduced (this still > uses 1 byte per flag). Using bool instead, which is the common use. > > Signed-off-by: Robert Richter Such cleanups are not appropriate f

Re: [PATCH net-next V1 04/12] net/mlx5e: Support DCBNL IEEE ETS

2016-02-18 Thread Saeed Mahameed
On Thu, Feb 18, 2016 at 5:30 PM, John Fastabend wrote: > > Hi Saeed, > > I just changed the signature on the setup_tc ndo hook so you will > need to change this to something like, > > static int __mlx5e_setup_tc(struct net_device *dev, u32 handle, > __be16 proto, struct

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V4

2016-02-18 Thread John Holland
> On Feb 18, 2016, at 16:22, David Miller wrote: > > From: John Holland > Date: Thu, 18 Feb 2016 08:53:07 +0100 > >> The PCI path in eth_platform_get_mac_address() didn't return a devicetree >> node... > > Then fix your platform such that pci_device_to_OF_node() works > properly instead of a

Re: [patch net 0/2] mlxsw fixes

2016-02-18 Thread David Miller
From: Jiri Pirko Date: Thu, 18 Feb 2016 11:30:00 +0100 > Another bulk of fixes from Ido. Series applied, thanks.

Re: [net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2016-02-17

2016-02-18 Thread David Miller
From: Jeff Kirsher Date: Thu, 18 Feb 2016 01:03:57 -0800 > This series contains updates to i40e/i40evf once again. Pulled, althugh I hope you guys don't get audited on that page refcount donation.

Re: [PATCH net v2] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-18 Thread Jesse Gross
On Thu, Feb 18, 2016 at 1:42 AM, Paolo Abeni wrote: > On Wed, 2016-02-17 at 11:19 -0800, Jesse Gross wrote: >> On Wed, Feb 17, 2016 at 10:30 AM, Paolo Abeni wrote: >> > the commit 35e2d1152b22 ("tunnels: Allow IPv6 UDP checksums to be >> > correctly controlled.") changed the default xmit checksum

Re: [PATCH net-next V1 04/12] net/mlx5e: Support DCBNL IEEE ETS

2016-02-18 Thread John Fastabend
On 16-02-18 02:32 AM, Saeed Mahameed wrote: > Support the ndo_setup_tc callback and the needed methods > for multi TC/UP support, and removed the default_vlan_prio > from mlx5e_priv which is always 0, it was replaced with > hardcoded "0" in the new select queue method. > > For that we now create M

pull-request: wireless-drivers 2016-02-18

2016-02-18 Thread Kalle Valo
Hi Dave, I have some important fixes I would like to get 4.5 still, more info in the signed tag. Please let me know if you have problems. Kalle The following changes since commit f9ead9beef3f44be0db4b542a8c2ce698fb1530e: Merge tag 'iwlwifi-for-kalle-2016-01-26_2' of https://git.kernel.org/pu

Re: [PATCH net-next 1/4] geneve: implement geneve_get_sk_family helper

2016-02-18 Thread Jiri Benc
On Thu, 18 Feb 2016 09:44:10 -0500, John W. Linville wrote: > On Thu, Feb 18, 2016 at 11:22:49AM +0100, Jiri Benc wrote: > > +static sa_family_t geneve_get_sk_family(struct geneve_sock *gs) > > +{ > > + return gs->sock->sk->sk_family; > > +} > > + > > Should this be inline? AFAIK the kernel pol

Re: [net-next PATCH v3 3/8] net: sched: add cls_u32 offload hooks for netdevs

2016-02-18 Thread John Fastabend
On 16-02-18 04:14 AM, Jamal Hadi Salim wrote: > On 16-02-17 06:07 PM, John Fastabend wrote: >> [...] >> > >> Actually thinking about this a bit more I wrote this thinking >> that there existed some hardware that actually cared if it was >> a new rule or an existing rule. For me it doesn't matter I

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V4

2016-02-18 Thread David Miller
From: John Holland Date: Thu, 18 Feb 2016 08:53:07 +0100 > The PCI path in eth_platform_get_mac_address() didn't return a devicetree > node... Then fix your platform such that pci_device_to_OF_node() works properly instead of adding localized hacks to device drivers. Jeff, do not apply this pa

Re: [PATCH v4 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-02-18 Thread Eric Dumazet
On mar., 2016-02-16 at 14:51 +0100, Bendik Rønning Opstad wrote: > RDB is a mechanism that enables a TCP sender to bundle redundant > (already sent) data with TCP packets containing new data. By bundling > (retransmitting) already sent data with each TCP packet containing new > data, the connection

[PATCH net-next 1/2] qed: Lay infrastructure for vlan filtering offload

2016-02-18 Thread Yuval Mintz
Today, interfaces are working in vlan-promisc mode; But once vlan filtering offloaded would be supported, we'll need a method to control it directly [e.g., when setting device to PROMISC, or when running out of vlan credits]. This adds the necessary API for L2 client to manually choose whether to

Re: [PATCH 0/4] Namespacify inet_peer_* sysctl knobs

2016-02-18 Thread Nikolay Borisov
On 02/17/2016 09:15 PM, Eric W. Biederman wrote: > Nikolay Borisov writes: > >> This series make the inet_peer ttl sysctls to be namespace aware. >> >> Patch 1 adds a namespace association to the inet_peer_base struct, >> which in turn is used to make the sysctls namespace aware. The >> rest

[PATCH] sctp: Fix port hash table size computation

2016-02-18 Thread Neil Horman
Dmitry Vyukov noted recently that the sctp_port_hashtable had an error in its size computation, observing that the current method never guaranteed that the hashsize (measured in number of entries) would be a power of two, which the input hash function for that table requires. The root cause of the

[PATCH net-next 2/2] qede: Add vlan filtering offload support

2016-02-18 Thread Yuval Mintz
From: Sudarsana Reddy Kalluru Device would start receiving only vlan-tagged traffic with tags matching that of one of the configured vlan IDs, unless: - Device is expliicly placed in PROMISC mode. - Device exhausts its vlan filter credits. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-b

[PATCH net-next 0/2] qed{,e}: Add vlan filtering offload

2016-02-18 Thread Yuval Mintz
This series adds vlan filtering offload to qede. First patch introduces small additional infrastructure needed in qed to support it, while second contains the main bulk of driver changes. Dave, Please consider applying this series to `net-next'. Thanks, Yuval -- 1.8.3.1

[PATCH net] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam.

2016-02-18 Thread Chunhao Lin
There will be a log spam when there is no cable plugged. Please refer to following links. https://bugzilla.kernel.org/show_bug.cgi?id=104351 https://bugzilla.kernel.org/show_bug.cgi?id=107421 This issue is caused by runtime power management. When there is no cable plugged, the driver will be suspe

Re: [PATCH net-next 1/4] geneve: implement geneve_get_sk_family helper

2016-02-18 Thread John W. Linville
On Thu, Feb 18, 2016 at 11:22:49AM +0100, Jiri Benc wrote: > Similarly to the existing vxlan_get_sk_family. > > Signed-off-by: Jiri Benc > --- > drivers/net/geneve.c | 20 +++- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/geneve.c b/drivers/net

Re: [PATCH net-next,V2] net: macb: make magic-packet property generic

2016-02-18 Thread Rob Herring
On Tue, Feb 16, 2016 at 09:10:45PM -0200, Sergio Prado wrote: > As requested by Rob Herring on patch > https://patchwork.ozlabs.org/patch/580862/. > > This is a new property that it's still in net-next and has never been > used in production, so we are not breaking anything with the > incompatible

[PATCH v2 1/1] cxgb3: fix up vpd strings for kstrto*()

2016-02-18 Thread Steve Wise
The vpd strings are left justified, in a fixed length array, with possible trailing white space and no NUL. So fix them up before calling kstrto*(). This is a recent regression which causes cxgb3 to fail to load. Fixes:e72c932('cxgb3: Convert simple_strtoul to kstrtox') Signed-off-by: Steve Wis

Re: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev

2016-02-18 Thread Dmitry Vyukov
On Thu, Feb 18, 2016 at 3:00 PM, Jiri Slaby wrote: > Cc Tejun (workqueues), Takashi (debug patch) > > On 01/26/2016, 12:53 PM, Dmitry Vyukov wrote: >> Hello, >> >> I've hit the following warning while running syzkaller fuzzer: > > Hi, > > I am hitting it over and over again using syzkaller. > >> W

[PATCH net-next 2/5] openvswitch: Revert: "Enable memory mapped Netlink i/o"

2016-02-18 Thread Florian Westphal
revert commit 795449d8b846 ("openvswitch: Enable memory mapped Netlink i/o"). Following the mmaped netlink removal this code can be removed. Signed-off-by: Florian Westphal --- net/openvswitch/datapath.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/net/openvswit

[PATCH net-next 1/5] netlink: remove mmapped netlink support

2016-02-18 Thread Florian Westphal
mmapped netlink has a number of unresolved issues: - TX zerocopy support had to be disabled more than a year ago via commit 4682a0358639b29cf ("netlink: Always copy on mmap TX.") because the content of the mmapped area can change after netlink attribute validation but before message processi

[PATCH net-next 3/5] Revert "genl: Add genlmsg_new_unicast() for unicast message allocation"

2016-02-18 Thread Florian Westphal
This reverts commit bb9b18fb55b0 ("genl: Add genlmsg_new_unicast() for unicast message allocation")'. Nothing wrong with it; its no longer needed since this was only for mmapped netlink support. Signed-off-by: Florian Westphal --- include/net/genetlink.h| 4 net/netlink/genetlink.c

[PATCH net-next 5/5] nfnetlink: Revert "nfnetlink: add support for memory mapped netlink"

2016-02-18 Thread Florian Westphal
reverts commit 3ab1f683bf8b ("nfnetlink: add support for memory mapped netlink")' Like previous commits in the series, remove wrappers that are not needed after mmapped netlink removal. Signed-off-by: Florian Westphal --- include/linux/netlink.h | 10 -- net/netfilter/nfnetlink_

[PATCH net-next 4/5] nfnetlink: remove nfnetlink_alloc_skb

2016-02-18 Thread Florian Westphal
Following mmapped netlink removal this code can be simplified by removing the alloc wrapper. Signed-off-by: Florian Westphal --- include/linux/netfilter/nfnetlink.h | 2 -- net/netfilter/nfnetlink.c | 7 --- net/netfilter/nfnetlink_log.c | 5 ++--- 3 files changed, 2 insertio

[PATCH -next 0/5] netlink: remove mmapped netlink support

2016-02-18 Thread Florian Westphal
As discussed during netconf 2016 in Seville, this series removes CONFIG_NETLINK_MMAP. Close to three years after it was merged it has retained several problems that do not appear to be fixable. No official netfilter libmnl release contains support for mmap backed netlink sockets. No openvswitch r

Re: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev

2016-02-18 Thread Jiri Slaby
Cc Tejun (workqueues), Takashi (debug patch) On 01/26/2016, 12:53 PM, Dmitry Vyukov wrote: > Hello, > > I've hit the following warning while running syzkaller fuzzer: Hi, I am hitting it over and over again using syzkaller. > WARNING: CPU: 2 PID: 17409 at kernel/workqueue.c:3968 > destroy_work

Re: [PATCH net 1/3] sctp: move rcu_read_lock from __sctp_lookup_association to sctp_lookup_association

2016-02-18 Thread Xin Long
On Thu, Feb 18, 2016 at 12:11 AM, Neil Horman wrote: > On Mon, Feb 15, 2016 at 02:28:03PM +0800, Xin Long wrote: >> __sctp_lookup_association() is only invoked by sctp_v4_err() and >> sctp_rcv(), both which run on the rx BH, and it has been protected >> by rcu_read_lock [see ip_local_deliver_finis

Re: [net-next PATCH 1/1] net_sched: Improve readability of filter processing

2016-02-18 Thread Daniel Borkmann
On 02/18/2016 02:04 PM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim Signed-off-by: Jamal Hadi Salim Acked-by: Daniel Borkmann

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V5

2016-02-18 Thread John Holland
On 02/18/2016 12:10 PM, John Holland wrote: Hello, The Intel i211 LOM PCIe Ethernet controllers' iNVM operates as an OTP and has no external EEPROM interface [1]. The following allows the driver to pickup the MAC address from a device tree blob when CONFIG_OF has been enabled. + if (eth

Re: [PATCH] b43: fix memory leak

2016-02-18 Thread Rafał Miłecki
On 18 February 2016 at 13:34, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > On error we jumped to the label bcma_out and returned the error code but > we missed freeing dev. What if b43_one_core_attach fails? Won't we miss kfree then as well? Shouldn't you simply improve error path and mayb

[PATCH net] tcp/dccp: fix another race at listener dismantle

2016-02-18 Thread Eric Dumazet
Ilya reported following lockdep splat: kernel: = kernel: [ BUG: held lock freed! ] kernel: 4.5.0-rc1-ceph-00026-g5e0a311 #1 Not tainted kernel: - kernel: swapper/5/0 is freeing memory 880035c9d200-880035c9dbff, with a lock still held there! k

Re: [PATCH] net: fix bridge multicast packet checksum validation

2016-02-18 Thread Linus Lüssing
On Thu, Feb 18, 2016 at 01:51:34PM +0100, Steinar H. Gunderson wrote: > On Mon, Feb 15, 2016 at 03:07:06AM +0100, Linus Lüssing wrote: > > Steinar, can you check whether this fixes the bridge issues you reported on > > bugzilla #99081? Not quite sure whether it is the same as yours as you > > do no

[PATCH net] route: check and remove route cache when we get route

2016-02-18 Thread Xin Long
Since the gc of ipv4 route was removed, the route cached would has no chance to be removed, and even it has been timeout, it still could be used, cause no code to check it's expires. Fix this issue by checking and removing route cache when we get route. Signed-off-by: Xin Long Acked-by: Hannes

Re: [PATCH nf 2/3] netfilter: ipvs: allow rescheduling after RST

2016-02-18 Thread Sergei Shtylyov
Hello. On 2/18/2016 3:41 AM, Simon Horman wrote: From: Julian Anastasov "RFC 5961, 4.2. Mitigation" describes a mechanism to request client to confirm with RST the restart of TCP connection before resending its SYN. As result, IPVS can see SYNs for existing connection in CLOSE state. Add chec

[PATCH net v3.16]r8169: Start on full duplex 8101

2016-02-18 Thread Corcodel Marian
For more info send email. Signed-off-by: Corcodel Marian --- drivers/net/ethernet/realtek/r8169.c | 69 ++-- 1 file changed, 42 insertions(+), 27 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 61623e

RE: [PATCH] tipc: unlock in error path

2016-02-18 Thread Xue, Ying
Acked-by: Ying Xue -Original Message- From: Insu Yun [mailto:wuni...@gmail.com] Sent: 2016年2月18日 0:48 To: jon.ma...@ericsson.com; Xue, Ying; da...@davemloft.net; netdev@vger.kernel.org; tipc-discuss...@lists.sourceforge.net; linux-ker...@vger.kernel.org Cc: tae...@gatech.edu; yeongjin

[PATCH 2/2] net, thunderx: Use bool in structs where possible

2016-02-18 Thread Robert Richter
From: Robert Richter Looks like the :1 notation was accidentally introduced (this still uses 1 byte per flag). Using bool instead, which is the common use. Signed-off-by: Robert Richter --- drivers/net/ethernet/cavium/thunder/nic.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletion

[PATCH 0/2] net: thunderx: Small cleanups

2016-02-18 Thread Robert Richter
From: Robert Richter Sending two small cleanups of the driver fixing issues found during code review. Robert Richter (2): net: thunderx: Fix const type in nicvf_set_rxfh() net, thunderx: Use bool in structs where possible drivers/net/ethernet/cavium/thunder/nic.h | 12 ++-

[PATCH 1/2] net: thunderx: Fix const type in nicvf_set_rxfh()

2016-02-18 Thread Robert Richter
From: Robert Richter >From struct ethtool_ops: int (*set_rxfh)(struct net_device *, const u32 *indir, const u8 *key, const u8 hfunc); Change function arg of hfunc to const type. Signed-off-by: Robert Richter --- drivers/net/ethernet/cavium/thunder/nicv

<    1   2   3   >