Re: [RFC PATCH] tcp: Add SOF_TIMESTAMPING_TX_EOR and allow MSG_EOR in tcp_sendmsg

On Fri, Mar 25, 2016 at 04:05:51PM -0700, Yuchung Cheng wrote: > Looks like an interesting and useful patch. Since HTTP2 allows > multiplexing data stream frames from multiple logical streams on a > single socket, > how would you instrument to measure the latency of each stream? e.g., > > sendmsg

Re: [RFC PATCH 7/9] GSO: Support partial segmentation offload

On Wed, Mar 23, 2016 at 7:53 PM, Alexander Duyck wrote: > On Wed, Mar 23, 2016 at 6:37 PM, Jesse Gross wrote: >> That being said, I actually think that it is good to have the DF bit >> on by default for encapsulation headers being added. Unintentional

Re: [RFC PATCH 7/9] GSO: Support partial segmentation offload

On Fri, Mar 18, 2016 at 4:25 PM, Alexander Duyck wrote: > diff --git a/net/core/dev.c b/net/core/dev.c > index edb7179bc051..666cf427898b 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -2711,6 +2711,19 @@ struct sk_buff *__skb_gso_segment(struct sk_buff *skb, [...]

Re: [RFC PATCH 1/9] ipv4/GRO: Allow multiple frames to use the same IP ID

On Wed, Mar 23, 2016 at 7:21 PM, Alexander Duyck wrote: > On Wed, Mar 23, 2016 at 6:43 PM, Jesse Gross wrote: >> On Fri, Mar 18, 2016 at 4:24 PM, Alexander Duyck wrote: >>> In RFC 6864 it is stated that we can essentially ignore

Re: [PATCH net v2 2/3] tunnels: Don't apply GRO to multiple layers of encapsulation.

On Sat, Mar 26, 2016 at 12:41 PM, Tom Herbert wrote: > On Sat, Mar 19, 2016 at 9:32 AM, Jesse Gross wrote: >> When drivers express support for TSO of encapsulated packets, they >> only mean that they can do it for one layer of encapsulation. >> Supporting

Re: [PATCH] brcmfmac: sdio: remove unused variable retry_limit

Hi All, On Mon, Mar 21, 2016 at 4:34 AM, Colin King wrote: > From: Colin Ian King > > retry_limit has never been used during the life of this driver, so > we may as well remove it as it is redundant. > > Signed-off-by: Colin Ian King

Re: [PATCH] Drivers: isdn: hisax: isac.c: Fix assignment and check into one expression.

From: Cosmin-Gabriel Samoila Date: Sat, 26 Mar 2016 02:49:50 +0200 > Fix variable assignment inside if statement. It is error-prone and hard to > read. > > Signed-off-by: Cosmin-Gabriel Samoila Applied.

Re: [PATCH] ravb: fix software timestamping

From: Lino Sanfilippo Date: Sun, 27 Mar 2016 12:22:02 +0200 > In ravb_start_xmit dont call skb_tx_timestamp only when hardware > timestamping is requested: in the latter case software timestamps are > suppressed and thus the call of skb_tx_timestamp does not have any

Re: [PATCH] net: sxgbe: fix error paths in sxgbe_platform_probe()

From: Rasmus Villemoes Date: Sat, 26 Mar 2016 22:24:09 +0100 > We need to use post-decrement to ensure that irq_dispose_mapping is > also called on priv->rxq[0]->irq_no; moreover, if one of the above for > loops failed already at i==0 (so we reach one of these labels

Re: [PATCH] net: sxgbe: fix error paths in sxgbe_platform_probe()

From: Francois Romieu Date: Sun, 27 Mar 2016 10:22:54 +0200 > Two years after the initial submission, there is zero change regarding use > of sxgbe_core_ops for extension or manageability. The extra indirection is > ripe for removal during next net-next. I completely

Re: [PATCH] Fix returned tc and hoplimit values for route with IPv6 encapsulation

From: Quentin Armitage Date: Sun, 27 Mar 2016 17:06:11 +0100 > For a route with IPv6 encapsulation, the traffic class and hop limit > values are interchanged when returned to userspace by the kernel. > For example, see below. > >># ip route add 192.168.0.1 dev eth0.2

Re: [PATCH TRIVIAL] drivers/net/usb/plusb.c: Fix typo

From: Diego Viola Date: Sun, 27 Mar 2016 20:58:15 -0300 > Signed-off-by: Diego Viola Applied, thanks.

Re: [PATCH net] inet: add proper locking in __inet{6}_lookup()

From: Eric Dumazet Date: Fri, 25 Mar 2016 15:15:15 -0700 > From: Eric Dumazet > > Blocking BH in __inet{6}_lookup() is not correct, as the lookups > are done using RCU protection. > > It matters only starting from Lorenzo Colitti patches to destroy

[PATCH TRIVIAL] drivers/net/usb/plusb.c: Fix typo

Signed-off-by: Diego Viola --- drivers/net/usb/plusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/plusb.c b/drivers/net/usb/plusb.c index 1bfe0fc..22e1a9a 100644 --- a/drivers/net/usb/plusb.c +++ b/drivers/net/usb/plusb.c @@ -38,7

[RFC] r8169: Module parameter for opt-in of ASPM

Hello, this patch adds a module parameter in order to activate ASPM. Basically it reapplies d64ec841517a25f6d468bde9f67e5b4cffdc67c7, which was reverted as some people reported delayed link status detection and increased boot times: https://lkml.org/lkml/2013/2/6/372. The differences to this

Re: BUG: net/netfilter: KASAN: stack-out-of-bounds in tcp_packet

On Mon, 28 Mar 2016, Jozsef Kadlecsik wrote: > On Sun, 27 Mar 2016, Baozeng Ding wrote: > > > The following program triggers stack-out-of-bounds in tcp_packet. The > > kernel version is 4.5 (on Mar 16 commit > > 09fd671ccb2475436bd5f597f751ca4a7d177aea). > > Uncovered with syzkaller. Thanks. > >

Re: BUG: net/netfilter: KASAN: stack-out-of-bounds in tcp_packet

On Sun, 27 Mar 2016, Baozeng Ding wrote: > The following program triggers stack-out-of-bounds in tcp_packet. The > kernel version is 4.5 (on Mar 16 commit > 09fd671ccb2475436bd5f597f751ca4a7d177aea). > Uncovered with syzkaller. Thanks. > >

Re: [PATCH] net: sxgbe: fix error paths in sxgbe_platform_probe()

On Sun, Mar 27 2016, Francois Romieu wrote: > Rasmus Villemoes : >> We need to use post-decrement to ensure that irq_dispose_mapping is >> also called on priv->rxq[0]->irq_no; moreover, if one of the above for >> loops failed already at i==0 (so

Re: [PATCH iproute2 1/2] vxlan: Follow kernel defaults for outer UDP checksum.

On Fri, 18 Mar 2016 17:51:08 -0700 Jesse Gross wrote: > On recent kernels, UDP checksum computation has become more efficient and > the default behavior was changed, however, the ip command overrides this > by always specifying a particular behavior. > > If the user does not

Re: [PATCH iproute2 v1 1/1] lib/utils: fix get_addr() and get_prefix() error messages

On Tue, 22 Mar 2016 13:02:02 + "Varlese, Marco" wrote: > An attempt to add invalid address to interface would print "???" string > instead of the address family name. > > For example: > $ ip address add 256.10.166.1/24 dev ens8 > Error: ??? prefix is expected rather

Re: [patch iproute2 v2 1/2] include: add linked list implementation from kernel

On Tue, 22 Mar 2016 10:02:20 +0100 Jiri Pirko wrote: > From: Jiri Pirko > > Rename hlist.h to list.h while adding it to be aligned with kernel > > Signed-off-by: Jiri Pirko > --- > v1->v2: > - fix some checkpatch issues Applied, I did

Re: [PATCH iproute2 master 0/2] setting flow label support

On Thu, 24 Mar 2016 16:49:54 +0100 Daniel Borkmann wrote: > On top of Jesse's csum patches for vxlan, geneve: > > - http://patchwork.ozlabs.org/patch/599746/ > - http://patchwork.ozlabs.org/patch/599747/ > > Thanks! > > Daniel Borkmann (2): > vxlan: add support to

Re: [iproute PATCH v3] Use ARRAY_SIZE macro everywhere

On Tue, 22 Mar 2016 16:52:53 +0100 Phil Sutter wrote: > This patch was generated by the following semantic patch (a trimmed down > version of what is shipped with Linux sources): > > @@ > type T; > T[] E; > @@ > ( > - (sizeof(E)/sizeof(*E)) > + ARRAY_SIZE(E) > | > -

Re: [iproute PATCH 0/7] Refactor some internal library functions

On Tue, 22 Mar 2016 19:35:12 +0100 Phil Sutter wrote: > The following series is a result of reviewing color output support and > some formatting helpers usually used with struct rtattr fields. > > Phil Sutter (7): > color: introduce color helpers and COLOR_CLEAR > ipaddress:

Re: [PATCH iproute2 v1 1/1] lib/utils: fix get_addr() and get_prefix() error messages

On Tue, 22 Mar 2016 13:02:02 + "Varlese, Marco" wrote: > An attempt to add invalid address to interface would print "???" string > instead of the address family name. > > For example: > $ ip address add 256.10.166.1/24 dev ens8 > Error: ??? prefix is expected rather

Re: [PATCH 1/2 net-next v3.16]r8169: Disable set bit multicast enable per multicast address.

On Sat, 26 Mar 2016 10:18:46 -0700 Eric Dumazet wrote: > On Sat, 2016-03-26 at 12:57 +0200, Corcodel Marian wrote: > > This patch correct set bit multicast enable only once per > > set_rx_mode invocation. > > > > Signed-off-by: Corcodel Marian >

[PATCH] Fix returned tc and hoplimit values for route with IPv6 encapsulation

For a route with IPv6 encapsulation, the traffic class and hop limit values are interchanged when returned to userspace by the kernel. For example, see below. ># ip route add 192.168.0.1 dev eth0.2 encap ip6 dst 0x50 tc 0x50 hoplimit 100 >table 1000 ># ip route show table 1000 192.168.0.1 encap

Re: [PATCH v8 net-next] ravb: Add dma queue interrupt support

Hello. On 03/22/2016 06:22 PM, Yoshihiro Kaneko wrote: From: Kazuya Mizuguchi This patch supports the following interrupts. - One interrupt for multiple (timestamp, error, gPTP) - One interrupt for emac - Four interrupts for dma queue (best effort rx/tx,

Re: [PATCH] ravb: fix software timestamping

Hello. On 03/27/2016 01:22 PM, Lino Sanfilippo wrote: In ravb_start_xmit dont call skb_tx_timestamp only when hardware timestamping is requested: in the latter case software timestamps are suppressed and thus the call of skb_tx_timestamp does not have any effect. Instead call skb_tx_timestamp

BUG: net/netfilter: KASAN: stack-out-of-bounds in tcp_packet

Hi all, The following program triggers stack-out-of-bounds in tcp_packet. The kernel version is 4.5 (on Mar 16 commit 09fd671ccb2475436bd5f597f751ca4a7d177aea). Uncovered with syzkaller. Thanks. == BUG: KASAN: stack-out-of-bounds

Re: [PATCH] drivers : Remove unnecessary void pointer conversions

Hello. On 3/27/2016 6:42 AM, Bhaskar Jupudi wrote: Explicit void pointer conversion is unnecessary because the conversions to and from a void pointer are always implicit in 'C'. Changed two instances of such conversions. Signed-off-by: Bhaskar Jupudi --- This patch is

[PATCH] ravb: fix software timestamping

In ravb_start_xmit dont call skb_tx_timestamp only when hardware timestamping is requested: in the latter case software timestamps are suppressed and thus the call of skb_tx_timestamp does not have any effect. Instead call skb_tx_timestamp unconditionally in ravb_start_xmit, since the function

Re: [PATCH] net: sxgbe: fix error paths in sxgbe_platform_probe()

Rasmus Villemoes : > We need to use post-decrement to ensure that irq_dispose_mapping is > also called on priv->rxq[0]->irq_no; moreover, if one of the above for > loops failed already at i==0 (so we reach one of these labels with > that value of i), we'll enter an

[PATCH 31/31] ethernet: broadcom: use parity8 in tg3.c

From: Zeng Zhaoxiu Signed-off-by: Zeng Zhaoxiu --- drivers/net/ethernet/broadcom/tg3.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index

[PATCH 25/31] ethernet: use parity8 in sun/niu.c

From: Zeng Zhaoxiu Signed-off-by: Zeng Zhaoxiu --- drivers/net/ethernet/sun/niu.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/sun/niu.c b/drivers/net/ethernet/sun/niu.c index

Re: [PATCH -next 0/5] netlink: remove mmapped netlink support

On Thu, Feb 18, 2016 at 3:03 PM, Florian Westphal wrote: > As discussed during netconf 2016 in Seville, this series removes > CONFIG_NETLINK_MMAP. Sorry for hopping in so^Wtoo late. I always thought mmaped netlink is the way to go for userspace packet processing. Sure, the

[PATCH 12/31] sunrpc: auth_gss: use parity8

From: Zeng Zhaoxiu Signed-off-by: Zeng Zhaoxiu --- net/sunrpc/auth_gss/gss_krb5_keys.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/net/sunrpc/auth_gss/gss_krb5_keys.c b/net/sunrpc/auth_gss/gss_krb5_keys.c index