[PATCH net-next 1/3] sock: fix lockdep annotation in release_sock

2016-04-05 Thread Hannes Frederic Sowa
During release_sock we use callbacks to finish the processing of outstanding skbs on the socket. We actually are still locked, sk_locked.owned == 1, but we already told lockdep that the mutex is released. This could lead to false positives in lockdep for lockdep_sock_is_held (we don't hold the sloc

[PATCH net-next 2/3] net: introduce lockdep_is_held and update various places to use it

2016-04-05 Thread Hannes Frederic Sowa
The socket is either locked if we hold the slock spin_lock for lock_sock_fast and unlock_sock_fast or we own the lock (sk_lock.owned != 0). Check for this and at the same time improve that the current thread/cpu is really holding the lock. Signed-off-by: Hannes Frederic Sowa --- include/net/sock

[PATCH net-next 0/3] sock: lockdep tightening

2016-04-05 Thread Hannes Frederic Sowa
First patch is from Eric Dumazet and improves lockdep accuracy for socket locks. After that, second patch introduces lockdep_sock_is_held and uses it. Final patch reverts and reworks the lockdep fix from Daniel in the filter code, as we now have tighter lockdep support. Hannes Frederic Sowa (3):

Re: [net PATCH v2 2/2] ipv4/GRO: Make GRO conform to RFC 6864

2016-04-05 Thread Edward Cree
On 05/04/16 05:32, Herbert Xu wrote: > On Mon, Apr 04, 2016 at 09:26:55PM -0700, Alexander Duyck wrote: >> The question I would have is what are you really losing with increment >> from 0 versus fixed 0? From what I see it is essentially just garbage >> in/garbage out. > GRO is meant to be lossles

Re: [PATCH net-next 1/6] net: skbuff: don't use union for napi_id and sender_cpu

2016-04-05 Thread Michael S. Tsirkin
On Fri, Apr 01, 2016 at 06:04:19AM -0700, Eric Dumazet wrote: > On Fri, 2016-04-01 at 12:49 +0800, Jason Wang wrote: > > > > On 04/01/2016 10:55 AM, Eric Dumazet wrote: > > > On Fri, 2016-04-01 at 10:13 +0800, Jason Wang wrote: > > > > > > > > >> The problem is we want to support busy polling for

Re: [PATCH net-next] net: intel: remove dead links

2016-04-05 Thread Jiri Benc
[removing intel-wired-...@lists.osuosl.org as I have no interest in the annoying "awaits moderator approval" emails] On Tue, 5 Apr 2016 16:25:07 +0200, Jiri Benc wrote: > The Kconfig for Intel NICs references two different URLs for the "Adapter > & Driver ID Guide". Neither of those two links wor

[PATCH net] MAINTAINERS: intel-wired-lan list is moderated

2016-04-05 Thread Jiri Benc
I got the following message: > Your mail to 'Intel-wired-lan' with the subject > > [PATCH net-next] net: intel: remove dead links > > Is being held until the list moderator can review it for approval. > > The reason it is being held: > > Post by non-member to a members-only list Mark the

[PATCH net-next] net: intel: remove dead links

2016-04-05 Thread Jiri Benc
The Kconfig for Intel NICs references two different URLs for the "Adapter & Driver ID Guide". Neither of those two links works. The current URL seems to be http://www.intel.com/content/www/us/en/support/network-and-i-o/ethernet-products/05584.html but given it's apparently constantly changing,

Re: [PATCH net-next 2/8] perf, bpf: allow bpf programs attach to tracepoints

2016-04-05 Thread Peter Zijlstra
On Mon, Apr 04, 2016 at 09:52:48PM -0700, Alexei Starovoitov wrote: > introduce BPF_PROG_TYPE_TRACEPOINT program type and allow it to be > attached to tracepoints. More specifically the perf tracepoint handler, not tracepoints directly. > The tracepoint will copy the arguments in the per-cpu buff

[PATCH] ipsec: Fix error handling in the function xfrm6_get_addr

2016-04-05 Thread Bastien Philbert
This fixes the error handling in the function xfrm_get_addr by checking if the call to ipv6_dev_get_saddr has failed and if so return -EADDRNOTAVAIL to signal to the caller of xfrm6_get_addr that the call has failed the error should be handled by the caller while also freeing the dst_entry structur

[PATCH V2 1/2] net: socket: return EADDRNOTAVAIL when source address becomes nonlocal

2016-04-05 Thread Liping Zhang
From: Liping Zhang A socket can use bind(directly) or connect(indirectly) to bind to a local ip address, and later if the network becomes down, that cause the source address becomes nonlocal, then send() call will fail and return EINVAL. But this error code is confusing, acctually we did not pass

[PATCH V2 0/2] net: socket: return a proper error code when source address becomes nonlocal

2016-04-05 Thread Liping Zhang
From: Liping Zhang This patch version 2 spilt the original patch into 2 patches, because it fix two separate problems actually. Liping Zhang (2): net: socket: return EADDRNOTAVAIL when source address becomes nonlocal net: socket: return EADDRNOTAVAIL when IPV6_PKTINFO's ipi6_addr is

[PATCH V2 2/2] net: socket: return EADDRNOTAVAIL when IPV6_PKTINFO's ipi6_addr is not available

2016-04-05 Thread Liping Zhang
From: Liping Zhang We can use IPV6_PKTINFO to specify the ipv6 source address when call sendmsg() to send packet, but if the address is not available, call will fail and EINVAL is returned. This error code is not very appropriate, it failed maybe just because of a temporary network problem, i.e.

Hiking Enthusiasts List

2016-04-05 Thread Connie Garrett
Hi, Hope this email finds you well! Would you be interested in acquiring an email list of "Hiking Enthusiasts List" from USA? We also have data for Fishing Enthusiasts, Sports Enthusiasts, Outdoor Enthusiasts, Spa and Resort visitors, Camping Enthusiasts, Food Enthusiasts, Scuba Divers Lis

Re: [PATCH net-next v3 4/4] vxlan: implement GPE

2016-04-05 Thread Jiri Benc
On Tue, 5 Apr 2016 10:50:57 -0300, Tom Herbert wrote: > I requested input from VXLAN protocol experts on whether RCO is > architecturally correct in VXLAN and whether we are using the right > fields both on the mailing list and in WG meeting yesterday @IETF. > Have not gotten any response, so I am

Re: [PATCH net-next v3 4/4] vxlan: implement GPE

2016-04-05 Thread Tom Herbert
On Tue, Apr 5, 2016 at 9:47 AM, Jiri Benc wrote: > Implement VXLAN-GPE. Only COLLECT_METADATA is supported for now (it is > possible to support static configuration, too, if there is demand for it). > > The GPE header parsing has to be moved before iptunnel_pull_header, as we > need to know the pr

RE: [Intel-wired-lan] [PATCH-RFC] drivers: net: ethernet: intel: e1000e: fix ethtool autoneg off for fiber

2016-04-05 Thread Ruinskiy, Dima
Sure, please send. It will be reviewed like any other patch. :) -Original Message- From: Daniel Walker [mailto:danie...@cisco.com] Sent: Tuesday, April 05, 2016 02:04 To: Ruinskiy, Dima; Kirsher, Jeffrey T; Brandeburg, Jesse; Nelson, Shannon; Wyborny, Carolyn; Skidmore, Donald C; Allan,

Re: [PREEMPT-RT] [PATCH] net: mvneta: Remove superfluous SMP function call

2016-04-05 Thread Anna-Maria Gleixner
On Mon, 4 Apr 2016, Anna-Maria Gleixner wrote: > Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to > hotplugged cpu") it is ensured that callbacks of CPU_ONLINE and > CPU_DOWN_PREPARE are processed on the hotplugged cpu. Due to this SMP > function calls are no longer required. > > Rep

[PATCH net-next] net: add the AF_KCM entries to family name tables

2016-04-05 Thread Dexuan Cui
This is for the recent kcm driver, which introduces AF_KCM(41) in b7ac4eb(kcm: Kernel Connection Multiplexor module). Signed-off-by: Dexuan Cui Cc: Signed-off-by: Tom Herbert --- net/core/sock.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/net/core/sock.c b/net/c

[PATCH net-next v3 1/4] vxlan: move Ethernet initialization to a separate function

2016-04-05 Thread Jiri Benc
This will allow to initialize vxlan in ARPHRD_NONE mode based on the passed rtnl attributes. v2: renamed "l2mode" to "ether". Signed-off-by: Jiri Benc --- drivers/net/vxlan.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/

[PATCH net-next v3 3/4] ip_tunnel: implement __iptunnel_pull_header

2016-04-05 Thread Jiri Benc
Allow calling of iptunnel_pull_header without special casing ETH_P_TEB inner protocol. Signed-off-by: Jiri Benc --- New in v2. --- include/net/ip_tunnels.h | 11 +-- net/ipv4/ip_tunnel_core.c | 8 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/include/net/ip_t

[PATCH net-next v3 2/4] vxlan: move fdb code to common location in vxlan_xmit

2016-04-05 Thread Jiri Benc
Handle VXLAN_F_COLLECT_METADATA before VXLAN_F_PROXY. The latter does not make sense with the former, as it needs populated fdb which does not happen in metadata mode. After this cleanup, the fdb code in vxlan_xmit is moved to a common location and can be later skipped for VXLAN-GPE which does not

[PATCH net-next v3 4/4] vxlan: implement GPE

2016-04-05 Thread Jiri Benc
Implement VXLAN-GPE. Only COLLECT_METADATA is supported for now (it is possible to support static configuration, too, if there is demand for it). The GPE header parsing has to be moved before iptunnel_pull_header, as we need to know the protocol. v2: Removed what was called "L2 mode" in v1 of the

[PATCH net-next v3 0/4] vxlan: implement Generic Protocol Extension (GPE)

2016-04-05 Thread Jiri Benc
v3: just rebased on top of the current net-next, no changes This patchset implements VXLAN-GPE. It follows the same model as the tun/tap driver: depending on the chosen mode, the vxlan interface is created either as ARPHRD_ETHER (non-GPE) or ARPHRD_NONE (GPE). Note that the internal fdb control p

AF_VSOCK status

2016-04-05 Thread Antoine Martin
Hi, Forgive me if these questions are obvious, I am not a kernel developer. >From what I am reading here: http://lists.linuxfoundation.org/pipermail/virtualization/2015-December/030935.html The code has been removed from mainline, is it queued for 4.6? If not, when are you planning on re-submittin

Re: [PATCH net-next 1/8] perf: optimize perf_fetch_caller_regs

2016-04-05 Thread Peter Zijlstra
On Mon, Apr 04, 2016 at 09:52:47PM -0700, Alexei Starovoitov wrote: > avoid memset in perf_fetch_caller_regs, since it's the critical path of all > tracepoints. > It's called from perf_sw_event_sched, perf_event_task_sched_in and all of > perf_trace_##call > with this_cpu_ptr(&__perf_regs[..]) wh

Re: [v7, 0/5] Fix eSDHC host version register bug

2016-04-05 Thread Ulf Hansson
On 1 April 2016 at 05:07, Yangbo Lu wrote: > This patchset is used to fix a host version register bug in the > T4240-R1.0-R2.0 > eSDHC controller. To get the SoC version and revision, it's needed to add the > GUTS driver to access the global utilities registers. > > So, the first three patches ar

Re: [PATCH net-next 05/10] bnxt_en: Add get_eee() and set_eee() ethtool support.

2016-04-05 Thread Michael Chan
On Tue, Apr 5, 2016 at 3:07 AM, Ben Hutchings wrote: > On Tue, 2016-04-05 at 04:22 -0400, Michael Chan wrote: > >> Allow users to get|set EEE parameters. >> >> Signed-off-by: Michael Chan >> --- >> drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 73 >> +++ >> 1 file chan

Re: [v7, 4/5] powerpc/fsl: move mpc85xx.h to include/linux/fsl

2016-04-05 Thread Joerg Roedel
On Fri, Apr 01, 2016 at 11:07:30AM +0800, Yangbo Lu wrote: > Move mpc85xx.h to include/linux/fsl and rename it to svr.h as > a common header file. It has been used for mpc85xx and it will > be used for ARM-based SoC as well. > > Signed-off-by: Yangbo Lu > Acked-by: Wolfram Sang Acked-by: Joerg

ADMtek ADM8511 "Pegasus II" USB Ethernet causes oops

2016-04-05 Thread Lincoln Ramsay
Hello, I have this (rather old) USB ethernet device but I cannot use it because it crashes my machine. Simply plugging in the adapter and causing some traffic (pinging the gateway will do) causes an oops. With older kernels (3.10-3.19) this was generally nearly instant. With the current kern

Re: [PATCH net-next 05/10] bnxt_en: Add get_eee() and set_eee() ethtool support.

2016-04-05 Thread Ben Hutchings
On Tue, 2016-04-05 at 04:22 -0400, Michael Chan wrote: > Allow users to get|set EEE parameters. > > Signed-off-by: Michael Chan > --- >  drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 73 > +++ >  1 file changed, 73 insertions(+) > > diff --git a/drivers/net/ethernet/br

[PATCH net 3/4] lib/test_bpf: Add test to check for result of 32-bit add that overflows

2016-04-05 Thread Naveen N. Rao
BPF_ALU32 and BPF_ALU64 tests for adding two 32-bit values that results in 32-bit overflow. Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: "David S. Miller" Cc: Ananth N Mavinakayanahalli Cc: Michael Ellerman Cc: Paul Mackerras Signed-off-by: Naveen N. Rao --- lib/test_bpf.c | 64 +

[PATCH net 4/4] lib/test_bpf: Add additional BPF_ADD tests

2016-04-05 Thread Naveen N. Rao
Some of these tests proved useful with the powerpc eBPF JIT port due to sign-extended 16-bit immediate loads. Though some of these aspects get covered in other tests, it is better to have explicit tests so as to quickly tag the precise problem. Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: "Dav

[PATCH net 2/4] lib/test_bpf: Add tests for unsigned BPF_JGT

2016-04-05 Thread Naveen N. Rao
Unsigned Jump-if-Greater-Than. Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: "David S. Miller" Cc: Ananth N Mavinakayanahalli Cc: Michael Ellerman Cc: Paul Mackerras Signed-off-by: Naveen N. Rao --- lib/test_bpf.c | 29 + 1 file changed, 29 insertions(+) diff

[PATCH net 1/4] lib/test_bpf: Fix JMP_JSET tests

2016-04-05 Thread Naveen N. Rao
JMP_JSET tests incorrectly used BPF_JNE. Fix the same. Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: "David S. Miller" Cc: Ananth N Mavinakayanahalli Cc: Michael Ellerman Cc: Paul Mackerras Signed-off-by: Naveen N. Rao --- lib/test_bpf.c | 8 1 file changed, 4 insertions(+), 4 de

NETLINK_URELEASE non-bound socket problem (was: [PATCH] Fix local DoS in cfg80211 subsystem)

2016-04-05 Thread Johannes Berg
Hi Dmitrijs, Thanks for reporting this problem. > The patch below corrects this problem in kernel space. I don't think that this is correct, there are four more users of NETLINK_URELEASE (nfnetlink, NFC), and afaict all of them have the same bug as nl80211. Rather than fix all of them, I think

Re: [RFC PATCH 1/5] bpf: add PHYS_DEV prog type for early driver filter

2016-04-05 Thread Jesper Dangaard Brouer
On Mon, 4 Apr 2016 13:00:34 -0700 Alexei Starovoitov wrote: > As seen in 'perf report' from patch 5: > 3.32% ksoftirqd/1[kernel.vmlinux] [k] sk_load_byte_positive_offset > this is 14Mpps and 4 assembler instructions in the above function > are consuming 3% of the cpu. At this level we

Re: [PATCH] mac80211: remove description of dropped member

2016-04-05 Thread Johannes Berg
On Fri, 2016-03-18 at 19:23 +, Luis de Bethencourt wrote: > Commit 976bd9efdae6 ("mac80211: move beacon_loss_count into ifmgd") > removed the member from the sta_info struct but the description > stayed > lingering. Remove it. > Also applied. johannes

Re: [PATCH] mac80211: add doc for RX_FLAG_DUP_VALIDATED flag

2016-04-05 Thread Johannes Berg
On Fri, 2016-03-18 at 16:09 +, Luis de Bethencourt wrote: > Add documentation for the flag for duplication check. > > Fixes the following warning when running make htmldocs: > warning: Enum value 'RX_FLAG_DUP_VALIDATED' not described in enum > 'mac80211_rx_flags' > Applied, thanks. johannes

[PATCH] VSOCK: Detach QP check should filter out non matching QPs.

2016-04-05 Thread Jorgen Hansen
The check in vmci_transport_peer_detach_cb should only allow a detach when the qp handle of the transport matches the one in the detach message. Testing: Before this change, a detach from a peer on a different socket would cause an active stream socket to register a detach. Reviewed-by: George Zh

[PATCH net-next 09/10] bnxt_en: Check for valid forced speed during ethtool -s.

2016-04-05 Thread Michael Chan
Check that the forced speed is a valid speed supported by firmware. If not supported, return -EINVAL. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 48 ++- 1 file changed, 38 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethern

[PATCH net-next 10/10] bnxt_en: Improve ethtool .get_settings().

2016-04-05 Thread Michael Chan
If autoneg is off, we should always report the speed and duplex settings even if it is link down so the user knows the current settings. The unknown speed and duplex should only be used for autoneg when link is down. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtoo

[PATCH net-next 08/10] bnxt_en: Provide NVM information via Ethtool GEEPROM

2016-04-05 Thread Michael Chan
From: Rob Swindell Provide details about the NVM device and the firmware version, etc, via the Ethtool GEEPROM command. Signed-off-by: Rob Swindell Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 60 +-- 1 file changed, 55 insertions(+),

[PATCH net-next 04/10] bnxt_en: Add EEE setup code.

2016-04-05 Thread Michael Chan
1. Add bnxt_hwrm_set_eee() function to setup EEE firmware parameters based on the bp->eee settings. 2. The new function bnxt_eee_config_ok() will check if EEE parameters need to be modified due to autoneg changes. 3. bnxt_hwrm_set_link() has added a new parameter to update EEE. If the parameter is

[PATCH net-next 02/10] bnxt_en: Improve flow control autoneg with Firmware 1.2.1 interface.

2016-04-05 Thread Michael Chan
Make use of the new AUTONEG_PAUSE bit in the new interface to better control autoneg flow control settings, independent of RX and TX advertisement settings. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 28 +++ drivers/net/ethernet/broadc

[PATCH net-next 06/10] bnxt_en: Set async event bits when registering with the firmware.

2016-04-05 Thread Michael Chan
Currently, the driver only sets bit 0 of the async_event_fwd fields. To be compatible with the latest spec, we need to set the appropriate event bits handled by the driver. We should be handling link change and PF driver unload events, so these 2 bits should be set. Signed-off-by: Michael Chan -

[PATCH net-next 01/10] bnxt_en: Update to Firmware 1.2.2 spec.

2016-04-05 Thread Michael Chan
Use new field names in API structs and stop using deprecated fields auto_link_speed and auto_duplex in phy_cfg/phy_qcfg structs. Update copyright year to 2016. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 20 +- drivers/net/ethernet/broadcom/bnxt/bnxt.h

[PATCH net-next 03/10] bnxt_en: Add basic EEE support.

2016-04-05 Thread Michael Chan
Get EEE capability and the initial EEE settings from firmware. Add "EEE is active | not active" to link up dmesg. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 82 ++- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 4 ++ drivers/net

[PATCH net-next 07/10] bnxt_en: Add unsupported SFP+ module warnings.

2016-04-05 Thread Michael Chan
Add the PORT_CONN_NOT_ALLOWED async event handling logic. The driver will print an appropriate warning to reflect the SFP+ module enforcement policy done in the firmware. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 55 +++ drivers/net/

[PATCH net-next 00/10] bnxt_en: Updates for net-next.

2016-04-05 Thread Michael Chan
Update to latest firmware interface, add EEE feature, unsupported SFP+ module warning, GEEPROM support, and ethtool -s improvements. Michael Chan (9): bnxt_en: Update to Firmware 1.2.2 spec. bnxt_en: Improve flow control autoneg with Firmware 1.2.1 interface. bnxt_en: Add basic EEE support.

[PATCH net-next 05/10] bnxt_en: Add get_eee() and set_eee() ethtool support.

2016-04-05 Thread Michael Chan
Allow users to get|set EEE parameters. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 73 +++ 1 file changed, 73 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethto

Re: [RFC PATCH 1/5] bpf: add PHYS_DEV prog type for early driver filter

2016-04-05 Thread Jesper Dangaard Brouer
On Tue, 5 Apr 2016 00:07:14 +0200 Thomas Graf wrote: > On 04/03/16 at 12:02am, Brenden Blanco wrote: > > On Sat, Apr 02, 2016 at 12:39:45PM -0400, Tom Herbert wrote: > > > Is there a hard restriction that this could only work with physical > > > devices? > > I suppose not, but there wouldn'

[patch net-next 2/3] switchdev: Use switch ID in suggested udev rule

2016-04-05 Thread Jiri Pirko
From: Ido Schimmel Since there can be multiple switch ASICs on the same system we should use the switch ID in order to differentiate between them and set the switch name (e.g. swX) accordingly. Also, replace the order of the "Switch ID" and "Port Netdev Naming" sections following the above chang

[patch net-next 0/3] mlxsw: small driver update, including switchdev doc update

2016-04-05 Thread Jiri Pirko
From: Jiri Pirko Ido Schimmel (3): mlxsw: spectrum: Reduce number of supported 802.1D bridges switchdev: Use switch ID in suggested udev rule mlxsw: spectrum: Add support for physical port names Documentation/networking/switchdev.txt | 28 drivers/net/ethernet/mel

Re: am335x: cpsw at high broadcast load

2016-04-05 Thread Yegor Yefremov
Hi Mugunthan, On Fri, Jul 31, 2015 at 2:22 PM, Yegor Yefremov wrote: > We experience massive problems, when putting am335x based devices into > high broadcast load environment (customer reports). To reproduce the > issue we've written following Python script > > #!/usr/bin/python > # Send UDP bro

[patch net-next 1/3] mlxsw: spectrum: Reduce number of supported 802.1D bridges

2016-04-05 Thread Jiri Pirko
From: Ido Schimmel Resources allocated for these bridges at init time cannot be later used for other purposes. While current number is supported by the device, it's mostly theoretical with regards to any real use case, which leads to poor utilization of device's resources. Solve that by reducing

[patch net-next 3/3] mlxsw: spectrum: Add support for physical port names

2016-04-05 Thread Jiri Pirko
From: Ido Schimmel Export to userspace the front panel name of the port, so that udev can rename the ports accordingly. The convention suggested by switchdev documentation is used: 1) Non-split: pX 2) Split: pXsY Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/

Re: [net-next 03/16] fm10k: Avoid crashing the kernel

2016-04-05 Thread Joe Perches
On Tue, 2016-04-05 at 01:01 -0700, Jeff Kirsher wrote: > From: Bruce Allan > > Use BUILD_BUG_ON() instead of BUG_ON() where appropriate to get a compile > error rather than crash the kernel. > > Signed-off-by: Bruce Allan > Acked-by: Alexander Duyck > Tested-by: Krishneil Singh > Signed-off-b

Re: [RFC PATCH 1/5] bpf: add PHYS_DEV prog type for early driver filter

2016-04-05 Thread Jesper Dangaard Brouer
On Mon, 4 Apr 2016 19:25:08 -0700 Alexei Starovoitov wrote: > On Tue, Apr 05, 2016 at 12:04:39AM +0200, Thomas Graf wrote: > > On 04/04/16 at 01:00pm, Alexei Starovoitov wrote: > > > Exactly. That the most important part of this rfc. > > > Right now redirect to different queue, batching, prefe

[net-next 09/16] fm10k: base queue scheme covered by RSS

2016-04-05 Thread Jeff Kirsher
From: Jacob Keller In fm10k_set_num_queues, we previously assigned the base template. This would always be overwritten by either fm10k_set_qos_queues or fm10k_set_rss_queues. In either case, we don't need the base values, so we can just remove them. Signed-off-by: Jacob Keller Tested-by: Krishn

[net-next 00/16][pull request] 100GbE Intel Wired LAN Driver Updates 2016-04-05

2016-04-05 Thread Jeff Kirsher
This series contains updates to fm10k only. Bruce provides nearly half of the patches in the series, most of which do general cleanup of the driver. These include semantic cleanups, checkpatch.pl fixes, update driver to use BIT() kernel macro, use BUILD_BUG_ON() where appropriate and use ether_ad

[net-next 13/16] fm10k: prevent possibly uninitialized variable

2016-04-05 Thread Jeff Kirsher
From: Bruce Allan If 'attr_flag < (1 << (2 * FM10K_TEST_MSG_NESTED))' is ever false, err will be used uninitialized. Signed-off-by: Bruce Allan Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c | 2 +- 1 file changed, 1 insertion(+),

[net-next 10/16] fm10k: print error message when stop_hw fails

2016-04-05 Thread Jeff Kirsher
From: Jacob Keller fm10k_stop_hw_generic calls fm10k_disable_queues_generic, which may return an error code indicating that the queues were not stopped within the time limit. Notify the user by displaying a message in the kernel message ring, in a similar way to how we notify the user when reset_

[net-next 16/16] fm10k: use ethtool_rxfh_indir_default for default redirection table

2016-04-05 Thread Jeff Kirsher
From: Jacob Keller The fm10k driver used its own code for generating a default indirection table on device load, which was not the same as the default generated by ethtool when indir_size of 0 is passed to SRXFH. Take advantage of ethtool_rxfh_indir_default() and simplify code to write the redire

[net-next 03/16] fm10k: Avoid crashing the kernel

2016-04-05 Thread Jeff Kirsher
From: Bruce Allan Use BUILD_BUG_ON() instead of BUG_ON() where appropriate to get a compile error rather than crash the kernel. Signed-off-by: Bruce Allan Acked-by: Alexander Duyck Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c |

[net-next 08/16] fm10k: don't initialize service task until later in probe

2016-04-05 Thread Jeff Kirsher
From: Jacob Keller Delay initialization of the service timer and service task until late probe. If we don't wait, failures in probe do not properly cleanup the service timer or service task items, which results in the kernel panic below, potentially freezing the whole system. In addition, ensure

[net-next 01/16] fm10k: Move constants to the right of binary operators

2016-04-05 Thread Jeff Kirsher
From: Bruce Allan The semantic patch that makes this change is available in scripts/coccinelle/misc/compare_const_fl.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Bruce Allan Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --

[net-next 11/16] fm10k: free MBX IRQ before clearing interrupt scheme

2016-04-05 Thread Jeff Kirsher
From: Jacob Keller During fm10k_io_error_detected we were clearing the interrupt scheme before we freed the MBX IRQ. This causes a kernel panic because the MBX IRQ are assigned after MSI-X initialization. Clearing the interrupt scheme results in removing the MSI-X entry table. Fix this by freeing

[net-next 07/16] fm10k: prevent null pointer dereference of msix_entries table

2016-04-05 Thread Jeff Kirsher
From: Jacob Keller According to the C standard dereferencing a variable before it is checked invokes undefined behavior, and thus compilers are free to assume the check for NULL isn't necessary. Prevent this by re-ordering the NULL check of msix_entries in fm10k_free_mbx_irq. Signed-off-by: Jaco

[net-next 04/16] fm10k: demote BUG_ON() to WARN_ON() where appropriate

2016-04-05 Thread Jeff Kirsher
From: Bruce Allan We don't need to crash the kernel in this instance so just warn about the condition and play on. Signed-off-by: Bruce Allan Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[net-next 06/16] fm10k: use ether_addr_copy to copy MAC address

2016-04-05 Thread Jeff Kirsher
From: Bruce Allan Cleanup the remaining instances of using memcpy() instead of the preferred ether_addr_copy(). Signed-off-by: Bruce Allan Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 dele

[net-next 05/16] fm10k: cleanup SPACE_BEFORE_TAB checkpatch warning

2016-04-05 Thread Jeff Kirsher
From: Bruce Allan Signed-off-by: Bruce Allan Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k_ptp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_ptp.c b/drivers/net/ethernet/intel/f

[net-next 15/16] fm10k: fix a minor typo in some comments

2016-04-05 Thread Jeff Kirsher
From: Jacob Keller s/funciton/function to resolve a typo, and cleanup grammar on a few comments regarding processing the VF mailboxes. Signed-off-by: Jacob Keller Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k_iov.c| 4 ++-- drivers/net/

[net-next 12/16] fm10k: add helper functions to set strings and data for ethtool stats

2016-04-05 Thread Jeff Kirsher
From: Jacob Keller Reduce duplicate code and the amount of indentation by adding fm10k_add_stat_strings and fm10k_add_ethtool_stats functions which help add fm10k_stat structures to the ethtool stats callbacks. This helps increase ease of use for future stat additions, and increases code readabil

[net-next 02/16] fm10k: cleanup remaining right-bit-shifted 1

2016-04-05 Thread Jeff Kirsher
From: Bruce Allan Use BIT() macro instead. Signed-off-by: Bruce Allan Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k.h | 12 ++-- drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c | 20 +--- drivers/net/etherne

[net-next 14/16] fm10k: correctly clean up when init_queueing_scheme fails

2016-04-05 Thread Jeff Kirsher
From: Jacob Keller Fix a kernel panic that occurs during surprise removal. Clear the interface queue counts upon fm10k_init_msix_capability failure. This prevents further code (fm10k_update_stats etc.) from attempting to access unallocated queue vector or ring memory. [ 628.692648] BUG: unable

Re: [RESEND PATCH V4 2/3] IB/hns: Add HiSilicon RoCE driver support

2016-04-05 Thread oulijun
Hi, Leon Romanovsky On 2016/4/2 9:58, Leon Romanovsky wrote: > On Fri, Apr 01, 2016 at 05:21:31PM +0800, Lijun Ou wrote: >> The driver for HiSilicon RoCE is a platform driver. >> The driver will support multiple versions of hardware. Currently only "v1" >> for hip06 SoC is supported. >> The driver

<    1   2   3