Re: [PATCH for-next 2/2] net/mlx5: Update mlx5_ifc hardware features

On Tue, Apr 12, 2016 at 8:15 AM, Leon Romanovsky wrote: > On Tue, Apr 12, 2016 at 12:37:34AM +0300, Or Gerlitz wrote: >> On Tue, Apr 12, 2016 at 12:24 AM, Saeed Mahameed >> wrote: >> > On Tue, Apr 12, 2016 at 12:17 AM, Or Gerlitz

[REGRESSION, bisect] pci: cxgb4 probe fails after commit 104daa71b3961434 ("PCI: Determine actual VPD size on first access")

Hi All, The following patch introduced a regression, causing cxgb4 driver to fail in PCIe probe. commit 104daa71b39614343929e1982170d5fcb0569bb5 Author: Hannes Reinecke Author: Hannes Reinecke Date: Mon Feb 15 09:42:01 2016 +0100 PCI: Determine actual VPD

Re: [PATCH for-next 2/2] net/mlx5: Update mlx5_ifc hardware features

On Tue, Apr 12, 2016 at 12:37:34AM +0300, Or Gerlitz wrote: > On Tue, Apr 12, 2016 at 12:24 AM, Saeed Mahameed > wrote: > > On Tue, Apr 12, 2016 at 12:17 AM, Or Gerlitz wrote: > > >> feature --> features > > > Correct, will fix. > > >>> * Add

Re: [PATCH net-next v2 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

On 4/10/16, 11:28 AM, roopa wrote: > On 4/10/16, 1:16 AM, Thomas Graf wrote: [snip] >> >> This currently ties everything to a net_device with a selector to >> include certain bits of that net_device. How about we take it half a >> step further and allow for non net_device stats such as IP, TCP, >>

Re: [PATCH net-next 0/7] DSA refactoring: set 1

Andrew Lunn writes: > There has been a long running effort to refractor DSA probing to make > the switches true linux devices. Here are a small collection of > patches moving in this direction. Most have been seen before. > > We take a little step forward by passing the dsa

Re: [PATCH net-next 7/7] dsa: mv88e6xxx: Use bus in mv88e6xxx_lookup_name()

Andrew Lunn writes: > mv88e6xxx_lookup_name() returns the model name of a switch at a given > address on an MII bus. Using mii_bus to identify the bus rather than > the host device is more logical, so change the parameter. > > Signed-off-by: Andrew Lunn

Re: [PATCH RFC] net: decrease the length of backlog queue immediately after it's detached from sk

On 2016/4/11 20:13, Eric Dumazet wrote: On Mon, 2016-04-11 at 19:57 +0800, Yang Yingliang wrote: On 2016/4/8 22:44, Eric Dumazet wrote: On Fri, 2016-04-08 at 19:18 +0800, Yang Yingliang wrote: I expand tcp_adv_win_scale and tcp_rmem. It has no effect. Try : echo -2

Re: [PATCH RFC 1/5] net: phy: sun8i-h3-ephy: Add bindings for Allwinner H3 Ethernet PHY

On Tue, Apr 12, 2016 at 3:23 AM, Florian Fainelli wrote: > On 04/04/16 09:22, Chen-Yu Tsai wrote: >> The Allwinner H3 SoC incorporates an Ethernet PHY. This is enabled and >> configured through a memory mapped hardware register. >> >> This same register also configures the

Re: [PATCH] devlink: add missing install of header

From: Stephen Hemminger Date: Mon, 11 Apr 2016 13:39:08 -0700 > The new devlink.h in uapi was not being installed by > make headers_install > > Signed-off-by: Stephen Hemminger Applied, thanks Stephen. I wish we could just have

Re: Configuring ethernet link fails with No such device

From: Stefan Agner Date: Mon, 11 Apr 2016 15:46:08 -0700 > What is the expectation/definition when link configuration should be > possible? Only after the network device got opened or before? Only after it is open. Drivers almost always have the entire chip in powerdown state

Re: [PATCH net-next] net: mdio: Fix lockdep falls positive splat

From: Andrew Lunn Date: Mon, 11 Apr 2016 21:40:05 +0200 > MDIO devices can be stacked upon each other. The current code supports > two levels, which until recently has been enough for a DSA mdio bus on > top of another bus. Now we have hardware which has an MDIO mux in the >

Re: [PATCH 0/9] RxRPC: 2nd rewrite part 1

From: David Howells Date: Mon, 11 Apr 2016 23:01:39 +0100 > David Miller wrote: > >> Series applied, but I had to fix up some trailing whitespace (reported by >> GIT) by hand. > > Do you perchance have a git hook script for checking for trailing

Re: [PATCH net v2] net: sched: do not requeue a NULL skb

On Mon, 2016-04-11 at 16:19 -0700, Cong Wang wrote: > My point is, for example, in OOM case, we don't know processin > more SKB would make it better or worse. Maybe we really need to > check the error code to decide to continue to exit? Really, given this bug has been there for a long time

Re: [PATCH net v2] net: sched: do not requeue a NULL skb

On Mon, Apr 11, 2016 at 11:30 AM, Eric Dumazet wrote: > On Mon, 2016-04-11 at 11:26 -0700, Eric Dumazet wrote: >> On Mon, 2016-04-11 at 11:02 -0700, Cong Wang wrote: >> >> > I am fine with either way as long as the loop stops on failure. > > > Note that skb that could not

Re: Configuring ethernet link fails with No such device

On 11/04/16 15:46, Stefan Agner wrote: > Hi All, > > I traced an issue in which we tried configuring duplex mode and speed in > a systemd-udevd .link file failed with the following error: > "Could not set speed or duplex of eth0 to 0 Mbps (half): No such device" > > The FEC driver (fec_main.c)

Configuring ethernet link fails with No such device

Hi All, I traced an issue in which we tried configuring duplex mode and speed in a systemd-udevd .link file failed with the following error: "Could not set speed or duplex of eth0 to 0 Mbps (half): No such device" The FEC driver (fec_main.c) does not initialize phy_dev until the device has been

Re: [PATCH RFT 1/2] phylib: add device reset GPIO support

On Mon, Apr 11, 2016 at 2:28 PM, Sergei Shtylyov wrote: > On 04/11/2016 10:25 PM, Rob Herring wrote: > >>> The PHY devices sometimes do have their reset signal (maybe even power >>> supply?) tied to some GPIO and sometimes it also does happen that a boot >>>

Re: [PATCH 0/9] RxRPC: 2nd rewrite part 1

David Howells wrote: > > Series applied, but I had to fix up some trailing whitespace (reported by > > GIT) by hand. > > Do you perchance have a git hook script for checking for trailing whitespace? No matter - there's already such a script installed by git clone - I just

[PATCH v2 net 3/4] ipv6: datagram: Update dst cache of a connected datagram sk during pmtu update

There is a case in connected UDP socket such that getsockopt(IPV6_MTU) will return a stale MTU value. The reproducible sequence could be the following: 1. Create a connected UDP socket 2. Send some datagrams out 3. Receive a ICMPV6_PKT_TOOBIG 4. No new outgoing datagrams to trigger the

[PATCH v2 net 4/4] ipv6: udp: Do a route lookup and update during release_cb

This patch adds a release_cb for UDPv6. It does a route lookup and updates sk->sk_dst_cache if it is needed. It picks up the left-over job from ip6_sk_update_pmtu() if the sk was owned by user during the pmtu update. It takes a rcu_read_lock to protect the __sk_dst_get() operations because

[PATCH v2 net 1/4] ipv6: datagram: Refactor flowi6 init codes to a new function

Move flowi6 init codes for connected datagram sk to a newly created function ip6_datagram_flow_key_init(). Notes: 1. fl6_flowlabel is used instead of fl6.flowlabel in __ip6_datagram_connect 2. ipv6_addr_is_multicast(>daddr) is used instead of (addr_type & IPV6_ADDR_MULTICAST) in

[PATCH v2 net 0/4] ipv6: datagram: Update dst cache of a connected udp sk during pmtu update

v2: ~ Protect __sk_dst_get() operations with rcu_read_lock in release_cb() because another thread may do ip6_dst_store() for a udp sk without taking the sk lock (e.g. in sendmsg). ~ Do a ipv6_addr_v4mapped(>sk_v6_daddr) check before calling ip6_datagram_dst_update() in patch 3 and 4. It is

[PATCH v2 net 2/4] ipv6: datagram: Refactor dst lookup and update codes to a new function

This patch moves the route lookup and update codes for connected datagram sk to a newly created function ip6_datagram_dst_update() It will be reused during the pmtu update in the later patch. Signed-off-by: Martin KaFai Lau Cc: Cong Wang Cc: Eric Dumazet

Re: [Lsf] [Lsf-pc] [LSF/MM TOPIC] Generic page-pool recycle facility?

On Mon, Apr 11, 2016 at 11:41:57PM +0200, Jesper Dangaard Brouer wrote: > > On Sun, 10 Apr 2016 21:45:47 +0300 Sagi Grimberg wrote: > > > >> This is also very interesting for storage targets, which face the same > > >> issue. SCST has a mode where it caches some fully

Re: [PATCH iproute2 0/4] vxlan: add VXLAN-GPE support

On Thu, 7 Apr 2016 14:36:25 +0200 Jiri Benc wrote: > This patchset adds a couple of refinements to the 'external' keyword and > adds support for configuring VXLAN-GPE interfaces. > > The VXLAN-GPE support was recently merged to net-next. > > The first patch is not intended

Re: [PATCH] iproute2: tc_bpf.c: fix building with musl libc

On Fri, 8 Apr 2016 09:59:33 -0300 Gustavo Zacarias wrote: > We need limits.h for PATH_MAX, fixes: > > tc_bpf.c: In function ‘bpf_map_selfcheck_pinned’: > tc_bpf.c:222:12: error: ‘PATH_MAX’ undeclared (first use in this > function) > char file[PATH_MAX], buff[4096]; >

Re: [Lsf] [Lsf-pc] [LSF/MM TOPIC] Generic page-pool recycle facility?

On Mon, Apr 11, 2016 at 2:41 PM, Jesper Dangaard Brouer wrote: > > On Sun, 10 Apr 2016 21:45:47 +0300 Sagi Grimberg wrote: > >> >> This is also very interesting for storage targets, which face the same >> >> issue. SCST has a mode where it caches some fully

Re: [PATCH 0/9] RxRPC: 2nd rewrite part 1

David Miller wrote: > Series applied, but I had to fix up some trailing whitespace (reported by > GIT) by hand. Do you perchance have a git hook script for checking for trailing whitespace? David

Re: [PATCH iproute2 -master 0/3] Minor tc/bpf updates

On Sat, 9 Apr 2016 00:32:02 +0200 Daniel Borkmann wrote: > Some minor updates to improve error reporting, add signatures > and recently introduced map flags attribute. Set is against > master branch. > > Thanks! > > Daniel Borkmann (3): > tc, bpf: add new csum and

Re: [Lsf] [Lsf-pc] [LSF/MM TOPIC] Generic page-pool recycle facility?

On Sun, 10 Apr 2016 21:45:47 +0300 Sagi Grimberg wrote: > >> This is also very interesting for storage targets, which face the same > >> issue. SCST has a mode where it caches some fully constructed SGLs, > >> which is probably very similar to what NICs want to do. > > > >

Re: [PATCH for-next 2/2] net/mlx5: Update mlx5_ifc hardware features

On Tue, Apr 12, 2016 at 12:24 AM, Saeed Mahameed wrote: > On Tue, Apr 12, 2016 at 12:17 AM, Or Gerlitz wrote: >> feature --> features > Correct, will fix. >>> * Add vport to steering commands for SRIOV ACL support >>> * Add mlcr, pcmr and mcia

Re: [Lsf] [LSF/MM TOPIC] Generic page-pool recycle facility?

On Mon, 2016-04-11 at 22:23 +0200, Jesper Dangaard Brouer wrote: > If we have a page-pool recycle facility, then we could use the trick, > right? (As we know that get_page_unless_zero() cannot happen for pages > in the pool). Well, if you disable everything that possibly use

Re: [PATCH for-next 2/2] net/mlx5: Update mlx5_ifc hardware features

On Tue, Apr 12, 2016 at 12:17 AM, Or Gerlitz wrote: > > feature --> features Correct, will fix. > >> * Add vport to steering commands for SRIOV ACL support >> * Add mlcr, pcmr and mcia registers for dump module EEPROM >> * Add support for FCS, baeacon led and disable_link

Re: Getting at the UDP headers from ->data_ready()

Willem de Bruijn wrote: > The network and transport header pointers are still valid. Commit e6afc8ace6dd > only changes where skb->data points to. It does not discard the data between > skb->head and skb->data. This rxrpc follow-up patch fixes some offset >

Re: [PATCHv2 net-next 4/6] sctp: add the sctp_diag.c file

On Fri, Apr 08, 2016 at 10:51:56PM -0700, Eric Dumazet wrote: > On Sat, 2016-04-09 at 12:53 +0800, Xin Long wrote: > > This one will implement all the interface of inet_diag, inet_diag_handler. > > which includes sctp_diag_dump, sctp_diag_dump_one and sctp_diag_get_info. > > > > +static int

Re: Getting at the UDP headers from ->data_ready()

On Mon, Apr 11, 2016 at 5:04 PM, David Howells wrote: > Hi Willem, > > With regards to: > > commit 4d0fc73ebe94ac984a187f21fbf4f3a1ac846f5a > Author: Willem de Bruijn > Date: Thu Apr 7 11:44:59 2016 -0400 > > rxrpc: do not pull udp

Re: [PATCH for-next 2/2] net/mlx5: Update mlx5_ifc hardware features

On Mon, Apr 11, 2016 at 11:10 PM, Saeed Mahameed wrote: > Adding the needed mlx5_ifc hardware bits and structs > for the following feature: feature --> features > * Add vport to steering commands for SRIOV ACL support > * Add mlcr, pcmr and mcia registers for dump module

Re: [Lsf] [Lsf-pc] [LSF/MM TOPIC] Generic page-pool recycle facility?

On Mon, 2016-04-11 at 21:47 +0200, Jesper Dangaard Brouer wrote: > On Mon, 11 Apr 2016 09:53:54 -0700 > Eric Dumazet wrote: > > > On Mon, 2016-04-11 at 18:19 +0200, Jesper Dangaard Brouer wrote: > > > > > Drivers also do tricks where they fallback to smaller order pages.

Getting at the UDP headers from ->data_ready()

Hi Willem, With regards to: commit 4d0fc73ebe94ac984a187f21fbf4f3a1ac846f5a Author: Willem de Bruijn Date: Thu Apr 7 11:44:59 2016 -0400 rxrpc: do not pull udp headers on receive Commit e6afc8ace6dd modified the udp receive path by pulling the udp

[PATCH] devlink: add missing install of header

The new devlink.h in uapi was not being installed by make headers_install Signed-off-by: Stephen Hemminger --- include/uapi/linux/Kbuild | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild index b71fd0b..813ffb2e

Re: [PATCH 0/9] RxRPC: 2nd rewrite part 1

David Miller wrote: > Series applied, but I had to fix up some trailing whitespace (reported by > GIT) by hand. Okay, thanks. David

Re: [PATCH net-next 6/7] dsa: Rename phys_port_mask to user_port_mask

On Mon, Apr 11, 2016 at 01:03:52PM -0700, Florian Fainelli wrote: > On 11/04/16 12:50, Andrew Lunn wrote: > > The phys in phys_port_mask suggests this mask is about PHYs. In fact, > > it means physical ports. Rename to user_port_mask, indicating user > > ports of the switch, which is hopefully

Re: [Lsf] [LSF/MM TOPIC] Generic page-pool recycle facility?

On Sat, 09 Apr 2016 05:34:38 -0700 Eric Dumazet wrote: > On Sat, 2016-04-09 at 11:11 +0200, Jesper Dangaard Brouer wrote: > > > Above code is okay. But do you think we also can get away with the same > > trick we do with the SKB refcnf? Where we avoid an atomic

[PATCH for-next 2/2] net/mlx5: Update mlx5_ifc hardware features

Adding the needed mlx5_ifc hardware bits and structs for the following feature: * Add vport to steering commands for SRIOV ACL support * Add mlcr, pcmr and mcia registers for dump module EEPROM * Add support for FCS, baeacon led and disable_link bits to hca caps * Add CQE period mode bit in CQ

[PATCH for-next 1/2] net/mlx5: Fix mlx5 ifc cmd_hca_cap bad offsets

From: Tariq Toukan All reserved fields after early_vf_enable are off by 1, since early_vf_enable was not explicitly declared as array of size 1. Reserved field before cqe_zip had a wrong size, it should be 0x80 + 0x3f. Fixes: b084590e ("net/mlx5_core: Introduce access

[PATCH for-next 0/2] mlx5_core: mlx5_ifc updates

Hi Dave and Doug This series include mlx5_core updates for both net-next and rdma trees for 4.7 kernel cycle. This is the only shared code planned for 4.7 between rdma and net trees. Hopefully, this will prevent future conflicts when merging between ib-next and net-next once 4.7 cycle is over

Re: [PATCH net-next 6/7] dsa: Rename phys_port_mask to user_port_mask

On 11/04/16 12:50, Andrew Lunn wrote: > The phys in phys_port_mask suggests this mask is about PHYs. In fact, > it means physical ports. Rename to user_port_mask, indicating user > ports of the switch, which is hopefully less confusing. Even though the change looks fine in principle, I am more

[PATCH net-next 7/7] dsa: mv88e6xxx: Use bus in mv88e6xxx_lookup_name()

mv88e6xxx_lookup_name() returns the model name of a switch at a given address on an MII bus. Using mii_bus to identify the bus rather than the host device is more logical, so change the parameter. Signed-off-by: Andrew Lunn --- v2: Check bus is valid before using it. ---

[PATCH net-next 5/7] net: dsa: Rename DSA probe function.

Rename the function called from the DSA to perform a probe for the switch. This makes the normal _probe() name available for a standard Linux device driver probe function. Signed-off-by: Andrew Lunn --- drivers/net/dsa/bcm_sf2.c | 7 --- drivers/net/dsa/mv88e6060.c | 7

[PATCH net-next 3/7] net: dsa: Remove allocation of driver private memory

The drivers now allocate their own memory for private usage. Remove the allocation from the core code. Signed-off-by: Andrew Lunn Acked-by: Florian Fainelli --- include/net/dsa.h | 1 - net/dsa/dsa.c | 2 +- 2 files changed, 1 insertion(+), 2

[PATCH net-next 6/7] dsa: Rename phys_port_mask to user_port_mask

The phys in phys_port_mask suggests this mask is about PHYs. In fact, it means physical ports. Rename to user_port_mask, indicating user ports of the switch, which is hopefully less confusing. Signed-off-by: Andrew Lunn --- drivers/net/dsa/bcm_sf2.c | 10 +-

[PATCH net-next 4/7] net: dsa: Keep the mii bus and address in the private structure

Rather than looking up the mii bus and address every time, do it once at probe, and keep it in the private structure. Centralise this probe code in mv88e6xxx. Signed-off-by: Andrew Lunn Acked-by: Florian Fainelli --- v2: Add check for valid mii_bus. ---

[PATCH net-next 1/7] net: dsa: Pass the dsa device to the switch drivers

By passing a device structure to the switch devices, it allows them to use devm_* methods for resource management. Signed-off-by: Andrew Lunn Acked-by: Florian Fainelli --- drivers/net/dsa/bcm_sf2.c | 3 ++- drivers/net/dsa/mv88e6060.c | 3 ++-

[PATCH net-next 0/7] DSA refactoring: set 1

There has been a long running effort to refractor DSA probing to make the switches true linux devices. Here are a small collection of patches moving in this direction. Most have been seen before. We take a little step forward by passing the dsa device point to the driver, thus allowing it to

[PATCH net-next 2/7] net: dsa: Have the switch driver allocate there own private memory

Now the switch devices have a dev pointer, make use of it for allocating the drivers private data structures using a devm_kzalloc(). Signed-off-by: Andrew Lunn Acked-by: Florian Fainelli --- v2: Added missing assignment of priv to ds->priv. ---

Re: FWD: [PATCH v2] Marvell phy: add fiber status check for some components

On 04/04/16 06:25, Andrew Lunn wrote: >> >From 564b767163d19355a3b5efaad195e93796570c71 Mon Sep 17 00:00:00 2001 >> From: Charles-Antoine Couret >> Date: Fri, 1 Apr 2016 16:16:35 +0200 >> Subject: [PATCH] Marvell phy: add fiber status check for some components

Re: [Lsf] [Lsf-pc] [LSF/MM TOPIC] Generic page-pool recycle facility?

On Mon, 11 Apr 2016 09:53:54 -0700 Eric Dumazet wrote: > On Mon, 2016-04-11 at 18:19 +0200, Jesper Dangaard Brouer wrote: > > > Drivers also do tricks where they fallback to smaller order pages. E.g. > > lookup function mlx4_alloc_pages(). I've tried to simulate that >

[PATCH net-next] net: mdio: Fix lockdep falls positive splat

MDIO devices can be stacked upon each other. The current code supports two levels, which until recently has been enough for a DSA mdio bus on top of another bus. Now we have hardware which has an MDIO mux in the middle. Define an MDIO MUTEX class with three levels. Signed-off-by: Andrew Lunn

Re: [PATCH 0/9] RxRPC: 2nd rewrite part 1

From: David Howells Date: Thu, 07 Apr 2016 17:22:56 +0100 > Okay, I'm in the process of rewriting the RxRPC rewrite. The primary aim of > this second rewrite is to strictly control the number of active connections we > know about and to get rid of connections we don't need

Re: [PATCH net-next 0/2] fix udp pull header breakage

From: Willem de Bruijn Date: Thu, 7 Apr 2016 11:44:57 -0400 > Commit e6afc8ace6dd ("udp: remove headers from UDP packets before > queueing") modified udp receive processing to pull headers before > enqueue and to not expect them on dequeue. > > The patch missed

Re: [PATCH RFT 1/2] phylib: add device reset GPIO support

On 04/11/2016 10:25 PM, Rob Herring wrote: The PHY devices sometimes do have their reset signal (maybe even power supply?) tied to some GPIO and sometimes it also does happen that a boot loader does not leave it deasserted. So far this issue has been attacked from (as I believe) a wrong angle:

Re: [Lsf] [Lsf-pc] [LSF/MM TOPIC] Generic page-pool recycle facility?

On Mon, 11 Apr 2016 19:07:03 +0100 Mel Gorman wrote: > On Mon, Apr 11, 2016 at 06:19:07PM +0200, Jesper Dangaard Brouer wrote: > > > http://git.kernel.org/cgit/linux/kernel/git/mel/linux.git/log/?h=mm-vmscan-node-lru-v4r5 > > > > > > > The cost decreased to: 228 cycles(tsc),

Re: [PATCH RFC 5/5] ARM: dts: sun8i: Enable Ethernet controller on the Orange PI PC

On 04/04/16 09:22, Chen-Yu Tsai wrote: > The Orange PI PC uses the H3's internal Ethernet PHY with the EMAC > Ethernet controller. > > Set a proper address for the PHY and enable the EMAC. > > Signed-off-by: Chen-Yu Tsai > --- > > This patch depends on "ARM: dts: sun8i-h3: Add

Re: [PATCH RFT 1/2] phylib: add device reset GPIO support

On Sat, Apr 09, 2016 at 01:22:47AM +0300, Sergei Shtylyov wrote: > The PHY devices sometimes do have their reset signal (maybe even power > supply?) tied to some GPIO and sometimes it also does happen that a boot > loader does not leave it deasserted. So far this issue has been attacked > from

Re: [PATCH RFC 1/5] net: phy: sun8i-h3-ephy: Add bindings for Allwinner H3 Ethernet PHY

On 04/04/16 09:22, Chen-Yu Tsai wrote: > The Allwinner H3 SoC incorporates an Ethernet PHY. This is enabled and > configured through a memory mapped hardware register. > > This same register also configures the MAC interface mode and TX clock > source. Also covered by the register, but not

Re: [PATCH RFC 2/5] net: phy: sun8i-h3-ephy: Add driver for Allwinner H3 Ethernet PHY

On 04/04/16 09:22, Chen-Yu Tsai wrote: > The Allwinner H3 SoC incorporates an Ethernet PHY. This is enabled and > configured through a memory mapped hardware register. > > This same register also configures the MAC interface mode and TX clock > source. Also covered by the register, but not

Re: [PATCH net 0/2] tipc: name distributor pernet queue

From: Jon Maloy Date: Thu, 7 Apr 2016 10:40:42 -0400 > Commit #1 fixes a potential issue with deferred binding table > updates being pushed to the wrong namespace. > > Commit #2 solves a problem with deferred binding table updates > remaining in the the defer queue

Re: [PATCH v6 net-next] net: ipv4: Consider failed nexthops in multipath routes

From: David Ahern Date: Thu, 7 Apr 2016 07:21:00 -0700 > Multipath route lookups should consider knowledge about next hops and not > select a hop that is known to be failed. > > Example: ... > The failed path can be avoided by considering known neighbor information >

Re: [PATCH 0/2] drivers: net: cpsw: fix ale calls and drop host_port field from cpsw_priv

From: Grygorii Strashko Date: Thu, 7 Apr 2016 15:16:42 +0300 > This clean up series intended to: > - fix port_mask parameters in ale calls and drop unnecessary shifts > - drop host_port field from struct cpsw_priv > > Nothing critical. Tested on am437x-idk-evm in

Re: [PATCH net-next] vxlan: fix incorrect type

From: Jiri Benc Date: Mon, 11 Apr 2016 17:06:08 +0200 > The protocol is 16bit, not 32bit. > > Fixes: e1e5314de08ba ("vxlan: implement GPE") > Reported-by: Dan Carpenter > Signed-off-by: Jiri Benc Applied.

Re: [PATCH] net: fjes: Use resource_size

From: Vaishali Thakkar Date: Mon, 11 Apr 2016 15:58:17 +0530 > Use the function resource_size instead of explicit computation. > > Problem found using Coccinelle. > > Signed-off-by: Vaishali Thakkar Applied.

Re: [PATCH RFT 2/2] macb: kill PHY reset code

On 04/11/2016 09:51 PM, Andrew Lunn wrote: The code you are deleting would of ignored the flags in the gpio property, i.e. active low. Hm, you're right -- I forgot about that... :-/ The new code in the previous patch does however take the flags into account. Did you check if there are

Re: [PATCH net-next 0/4] bnxt_en: Update for net-next

From: Michael Chan Date: Mon, 11 Apr 2016 04:11:10 -0400 > Misc. changes for link speed and VF MAC address change. Applied, thanks Michael.

Re: [Lsf] [Lsf-pc] [LSF/MM TOPIC] Generic page-pool recycle facility?

On 04/11/2016 11:37 AM, Jesper Dangaard Brouer wrote: On Mon, 11 Apr 2016 14:46:25 -0300 Thadeu Lima de Souza Cascardo wrote: So, Jesper, please take into consideration that this pool design would rather be per device. Otherwise, we allow some device to write into

Re: [PATCH RFT 2/2] macb: kill PHY reset code

On Mon, Apr 11, 2016 at 09:39:02PM +0300, Sergei Shtylyov wrote: > Hello. > > On 04/11/2016 09:19 PM, Andrew Lunn wrote: > > >>>The code you are deleting would of ignored the flags in the gpio > >>>property, i.e. active low. > >> > >>Hm, you're right -- I forgot about that... :-/ > >> >

Re: [PATCH RFT 2/2] macb: kill PHY reset code

Hello. On 04/11/2016 09:19 PM, Andrew Lunn wrote: The code you are deleting would of ignored the flags in the gpio property, i.e. active low. Hm, you're right -- I forgot about that... :-/ The new code in the previous patch does however take the flags into account. Did you check if

Re: [PATCH] mwifiex: fix possible NULL dereference

On Mon, Apr 11, 2016 at 8:27 AM, Sudip Mukherjee wrote: > > From: Sudip Mukherjee > > We have a check for card just after dereferencing it. So if it is NULL > we have already dereferenced it before its check. Lets dereference it >

Re: [Lsf] [Lsf-pc] [LSF/MM TOPIC] Generic page-pool recycle facility?

On Mon, 11 Apr 2016 14:46:25 -0300 Thadeu Lima de Souza Cascardo wrote: > So, Jesper, please take into consideration that this pool design > would rather be per device. Otherwise, we allow some device to write > into another's device/driver memory. Yes, that was my intended

Re: [PATCH net v2] net: sched: do not requeue a NULL skb

On Mon, 2016-04-11 at 11:26 -0700, Eric Dumazet wrote: > On Mon, 2016-04-11 at 11:02 -0700, Cong Wang wrote: > > > I am fine with either way as long as the loop stops on failure. Note that skb that could not be validated is already freed. So I do not see any value from stopping the loop, since

Re: [PATCH net v2] net: sched: do not requeue a NULL skb

On Mon, 2016-04-11 at 11:02 -0700, Cong Wang wrote: > I am fine with either way as long as the loop stops on failure. > Folding the test "if (skb)" into one also requires to retake the spinlock. Adding the likely() in this path would probably help as well. diff --git a/net/sched/sch_generic.c

Re: Unhandled fault during system suspend in sky2_shutdown

On Mon, 11 Apr 2016 17:24:37 +0100 Sudeep Holla wrote: > Hi, > > I am seeing unhandled fault during system suspend in sky2_shutdown. > I am not sure if it's something missing in the firmware, but just wanted > to check. I see that networkmanager is invoking calling to >

Re: [PATCH RFT 2/2] macb: kill PHY reset code

> >The code you are deleting would of ignored the flags in the gpio > >property, i.e. active low. > >Hm, you're right -- I forgot about that... :-/ > > >The new code in the previous patch does > >however take the flags into account. Did you check if there are any > >device trees which have

Re: [Lsf] [Lsf-pc] [LSF/MM TOPIC] Generic page-pool recycle facility?

On Mon, Apr 11, 2016 at 06:19:07PM +0200, Jesper Dangaard Brouer wrote: > > http://git.kernel.org/cgit/linux/kernel/git/mel/linux.git/log/?h=mm-vmscan-node-lru-v4r5 > > > > The cost decreased to: 228 cycles(tsc), but there are some variations, > sometimes it increase to 238 cycles(tsc). > In

Re: [PATCH net v2] net: sched: do not requeue a NULL skb

On Mon, Apr 11, 2016 at 8:52 AM, Eric Dumazet wrote: > On Mon, 2016-04-11 at 17:17 +0200, Lars Persson wrote: >> >> On 04/11/2016 04:22 PM, Eric Dumazet wrote: >> > On Mon, 2016-04-11 at 15:38 +0200, Lars Persson wrote: >> > >> >> I though it would be prudent because the

Re: [RFC PATCH net 3/4] ipv6: datagram: Update dst cache of a connected datagram sk during pmtu update

On Tue, Apr 05, 2016 at 07:56:54PM -0400, David Miller wrote: > From: Cong Wang > Date: Mon, 4 Apr 2016 13:45:02 -0700 > > > On Sat, Apr 2, 2016 at 7:33 PM, Martin KaFai Lau wrote: > >> One thing to note is that this patch uses the addresses from the sk >

Re: [PATCH net v2] net: sched: do not requeue a NULL skb

On Mon, Apr 11, 2016 at 8:17 AM, Lars Persson wrote: > > > On 04/11/2016 04:22 PM, Eric Dumazet wrote: >> >> On Mon, 2016-04-11 at 15:38 +0200, Lars Persson wrote: >> >>> I though it would be prudent because the queue can be non-empty even for >>> the case of skb=NULL. So

Re: [Lsf] [Lsf-pc] [LSF/MM TOPIC] Generic page-pool recycle facility?

On Mon, Apr 11, 2016 at 12:20:47PM -0400, Matthew Wilcox wrote: > On Mon, Apr 11, 2016 at 02:08:27PM +0100, Mel Gorman wrote: > > On Mon, Apr 11, 2016 at 02:26:39PM +0200, Jesper Dangaard Brouer wrote: > > > On arch's like PowerPC, the DMA API is the bottleneck. To workaround > > > the cost of

Re: [PATCH RFT 2/2] macb: kill PHY reset code

Hello. On 04/11/2016 05:28 AM, Andrew Lunn wrote: With the 'phylib' now being aware of the "reset-gpios" PHY node property, there should be no need to frob the PHY reset in this driver anymore... Signed-off-by: Sergei Shtylyov ---

Re: [PATCH] sh_eth: re-enable-E-MAC interrupts in sh_eth_set_ringparam()

Hello. On 04/10/2016 04:27 AM, David Miller wrote: The E-MAC interrupts are left disabled when the ring parameters are changed via 'ethtool'. In order to fix this, it's enough to call sh_eth_dev_init() with 'true' instead of 'false' for the second argument (which conveniently allows us to

Re: [Lsf] [Lsf-pc] [LSF/MM TOPIC] Generic page-pool recycle facility?

On Mon, 2016-04-11 at 18:19 +0200, Jesper Dangaard Brouer wrote: > Drivers also do tricks where they fallback to smaller order pages. E.g. > lookup function mlx4_alloc_pages(). I've tried to simulate that > function here: >

Re: [PATCH net-next 2/2] net: exit busy loop when another process is runnable

On Fri, Aug 22, 2014 at 09:36:53AM +0200, Ingo Molnar wrote: > > > > diff --git a/include/net/busy_poll.h b/include/net/busy_poll.h > > > index 1d67fb6..8a33fb2 100644 > > > --- a/include/net/busy_poll.h > > > +++ b/include/net/busy_poll.h > > > @@ -109,7 +109,8 @@ static inline bool

Unhandled fault during system suspend in sky2_shutdown

Hi, I am seeing unhandled fault during system suspend in sky2_shutdown. I am not sure if it's something missing in the firmware, but just wanted to check. I see that networkmanager is invoking calling to netlink_sendmsg which calls sky2_get_stats after the device is shutdown. Unhandled fault:

Re: pull-request: wireless-drivers-next 2016-04-11

From: Kalle Valo Date: Mon, 11 Apr 2016 15:48:48 +0300 > here's a pull request for 4.7. More features, but nothing really > standing out. Please let me know if you have any problems. Pulled, thanks.

Re: [PATCH net] cxgb4: Stop Rx Queues before freeing it up

From: Hariprasad Shenai Date: Mon, 11 Apr 2016 11:07:58 +0530 > Stop all Ethernet RX Queues before freeing up various Ingress/Egress > Queues, etc. We were seeing cases of Ingress Queues not getting serviced > during the shutdown process leading to Ingress Paths jamming

Re: [Lsf] [Lsf-pc] [LSF/MM TOPIC] Generic page-pool recycle facility?

On Mon, Apr 11, 2016 at 02:08:27PM +0100, Mel Gorman wrote: > On Mon, Apr 11, 2016 at 02:26:39PM +0200, Jesper Dangaard Brouer wrote: > > On arch's like PowerPC, the DMA API is the bottleneck. To workaround > > the cost of DMA calls, NIC driver alloc large order (compound) pages. > > (dma_map

Re: [Lsf] [Lsf-pc] [LSF/MM TOPIC] Generic page-pool recycle facility?

On Mon, 11 Apr 2016 14:08:27 +0100 Mel Gorman wrote: > On Mon, Apr 11, 2016 at 02:26:39PM +0200, Jesper Dangaard Brouer wrote: [...] > > > > It is always great if you can optimized the page allocator. IMHO the > > page allocator is too slow. > > It's why I

Re: [PATCH net-next 00/11] FUJITSU Extended Socket driver version 1.1

This submission is of an extremely low quality. All of your ioctl additions are completely inappropriate, as are your debugfs facilities. You must remove all of them completely.

Re: [PATCH net v2] net: sched: do not requeue a NULL skb

On Mon, 2016-04-11 at 17:17 +0200, Lars Persson wrote: > > On 04/11/2016 04:22 PM, Eric Dumazet wrote: > > On Mon, 2016-04-11 at 15:38 +0200, Lars Persson wrote: > > > >> I though it would be prudent because the queue can be non-empty even for > >> the case of skb=NULL. So should it be there in

[PATCH iproute2 v2 3/3] bridge: vlan: add support to filter by vlan id

Add the optional keyword "vid" to bridge vlan show so the user can request filtering by a specific vlan id. Currently the filtering is implemented only in user-space. The argument name has been chosen to match the add/del one - "vid". This filtering can be used also with the "-compressvlans"

[PATCH iproute2 v2 0/3] bridge: filtering by vlan id

Hi, This set adds support for filtering by a vlan id when showing fdb/mdb/vlan entries. Currently the filtering is implemented entirely in user-space, but the plan is to add kernel support as well. The vlan show part is also needed for the future per-vlan statistics in order to be able to show

  1   2   >