RE: [PATCH 5/6] Documentation: Binding doc for ethernet master in NS2

Hi Rob, Thanks for review and providing your valuable comments. > -Original Message- > From: Rob Herring [mailto:r...@kernel.org] > Sent: 23 April 2016 01:44 > To: Pramod Kumar > Cc: Catalin Marinas; Will Deacon; Masahiro Yamada; Chen-Yu Tsai; BCM Kernel > Feedback; Pawel Moll; Mark

RE: [PATCH 2/6] Documentation: DT binding doc for iProc Shared MDIO Controller.

Hi Rob, Thanks for reviewing and providing your valuable comments. > -Original Message- > From: Rob Herring [mailto:r...@kernel.org] > Sent: 23 April 2016 01:41 > To: Pramod Kumar > Cc: Catalin Marinas; Will Deacon; Masahiro Yamada; Chen-Yu Tsai; Mark > Rutland;

[PATCH v2 net-next] net: ipv6: Use passed in table for nexthop lookups

Similar to 3bfd847203c6 ("net: Use passed in table for nexthop lookups") for IPv4, if the route spec contains a table id use that to lookup the next hop first and fall back to a full lookup if it fails (per the fix 4c9bcd117918b ("net: Fix nexthop lookups")). Example: root@kenny:~# ip -6 ro

RE: [PATCH 1/6] bus: Add shared MDIO bus framework

Hi David, Thanks for providing input over the patch. Will address the comment as described below. > -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: 24 April 2016 23:48 > To: pramod.ku...@broadcom.com > Cc: robh...@kernel.org; catalin.mari...@arm.com;

Re: [PATCH net-next] hv_netvsc: Fix the list processing for network change event

From: Haiyang Zhang Date: Thu, 21 Apr 2016 16:13:01 -0700 > RNDIS_STATUS_NETWORK_CHANGE event is handled as two "half events" -- > media disconnect & connect. The second half should be added to the list > head, not to the tail. So all events are processed in normal order.

Re: [PATCH net] ipv4/fib: don't warn when primary address is missing if in_dev is dead

From: Paolo Abeni Date: Thu, 21 Apr 2016 22:23:31 +0200 > After commit fbd40ea0180a ("ipv4: Don't do expensive useless work > during inetdev destroy.") when deleting an interface, > fib_del_ifaddr() can be executed without any primary address > present on the dead interface. >

RE: [PATCH net 1/1] net: fec: update dirty_tx even if no skb

From: Troy Kisky Sent: Saturday, April 23, 2016 12:12 AM > To: Fugang Duan ; netdev@vger.kernel.org; > da...@davemloft.net; lzn...@gmail.com > Cc: Fabio Estevam ; l.st...@pengutronix.de; > and...@lunn.ch;

Re: [PATCH 2/2] sh_eth: rename ARSTR register bit

On Sun, Apr 24, 2016 at 11:46:15PM +0300, Sergei Shtylyov wrote: > The Renesas RZ/A1H manual names the software reset bit in the software reset > register (ARSTR) ARST which makes a bit more sense than the ARSTR_ARSTR name > used now by the driver -- rename the latter to ARSTR_ARST. > >

Re: [PATCH 1/2] sh_eth: use EDMR_SRST_GETHER in sh_eth_check_reset()

On Sun, Apr 24, 2016 at 11:45:23PM +0300, Sergei Shtylyov wrote: > sh_eth_check_reset() uses a bare number where EDMR_SRST_GETHER would fit, > i.e. the receive/trasmit software reset bits that comprise EDMR_SRST_GETHER > read as 1 while the corresponding reset is in progress and thus, when both >

Re: [PATCH] sh_eth: get rid of the 2nd parameter to sh_eth_dev_init()

On Sun, Apr 24, 2016 at 07:11:07PM +0300, Sergei Shtylyov wrote: > sh_eth_dev_init() is now always called with 'true' as the 2nd argument, > so that there's no more sense in having 2 parameters to this function... > > Signed-off-by: Sergei Shtylyov

Re: VRF_DEVICE integration plan

On 4/23/16 10:07 PM, Elluru, Krishna Mohan wrote: HI Netdev team, Greetings. We have been monitoring the vrf device approach for l3 isolation from cumulus networks and we are currently interested in validating it. We have following questions on them and hoping to get answers from

Re: linux-next: build failure after merge of the net-next tree

On Fri, Apr 22, 2016 at 04:20:43PM -0700, Jeff Kirsher wrote: > On Fri, 2016-04-22 at 10:20 +0100, Mark Brown wrote: > > > Jeff, please have your folks look into this.  Probably just a > > simple > > > conversion to mdelay(). > > This is still present, it's been breaking ARM allmodconfig builds

[PATCH v2 net-next] net: ethernet: enc28j60: add device tree support

The following patch adds the required match table for device tree support (and while at, fix the indent). It's also possible to specify the MAC address in the DT blob. Also add the corresponding binding documentation file. Signed-off-by: Michael Heimpold --- v2: * took care

Re: linux-next: zillions of lockdep whinges in include/net/sock.h:1408

On Sun, 2016-04-24 at 14:25 -0700, Eric Dumazet wrote: > On Sun, 2016-04-24 at 17:13 -0400, valdis.kletni...@vt.edu wrote: > > On Sun, 24 Apr 2016 14:00:17 -0700, Eric Dumazet said: > > > On Sun, 2016-04-24 at 15:56 -0400, valdis.kletni...@vt.edu wrote: > > > > On Sun, 24 Apr 2016 12:46:42 -0700,

Re: linux-next: zillions of lockdep whinges in include/net/sock.h:1408

On Sun, 2016-04-24 at 17:13 -0400, valdis.kletni...@vt.edu wrote: > On Sun, 24 Apr 2016 14:00:17 -0700, Eric Dumazet said: > > On Sun, 2016-04-24 at 15:56 -0400, valdis.kletni...@vt.edu wrote: > > > On Sun, 24 Apr 2016 12:46:42 -0700, Eric Dumazet said: > > > > > > > >>> + return !debug_locks ||

Re: linux-next: zillions of lockdep whinges in include/net/sock.h:1408

On Sun, 24 Apr 2016 14:00:17 -0700, Eric Dumazet said: > On Sun, 2016-04-24 at 15:56 -0400, valdis.kletni...@vt.edu wrote: > > On Sun, 24 Apr 2016 12:46:42 -0700, Eric Dumazet said: > > > > > >>> + return !debug_locks || > > > >>> +lockdep_is_held(>sk_lock) || > > > > > Issue here

Re: linux-next: zillions of lockdep whinges in include/net/sock.h:1408

On Sun, 2016-04-24 at 15:56 -0400, valdis.kletni...@vt.edu wrote: > On Sun, 24 Apr 2016 12:46:42 -0700, Eric Dumazet said: > > > >>> + return !debug_locks || > > >>> + lockdep_is_held(>sk_lock) || > > > Issue here is that once lockdep detected a problem (not necessarily in > >

[PATCH 2/2] sh_eth: rename ARSTR register bit

The Renesas RZ/A1H manual names the software reset bit in the software reset register (ARSTR) ARST which makes a bit more sense than the ARSTR_ARSTR name used now by the driver -- rename the latter to ARSTR_ARST. Signed-off-by: Sergei Shtylyov ---

[PATCH 1/2] sh_eth: use EDMR_SRST_GETHER in sh_eth_check_reset()

sh_eth_check_reset() uses a bare number where EDMR_SRST_GETHER would fit, i.e. the receive/trasmit software reset bits that comprise EDMR_SRST_GETHER read as 1 while the corresponding reset is in progress and thus, when both are 0, the reset is complete. Signed-off-by: Sergei Shtylyov

[PATCH 0/2] sh_eth: couple of software reset bit cleanups

Hello. Here's a set of 2 patches against DaveM's 'net-next.git' repo. We clean up the use of the software reset bits... [1/2] sh_eth: use EDMR_SRST_GETHER in sh_eth_check_reset() [2/2] sh_eth: rename ARSTR register bit MBR, Sergei

[PATCH net] RDMA/nes: don't leak skb if carrier down

Alternatively one could free the skb, OTOH I don't think this test is useful so just remove it. Cc: Signed-off-by: Florian Westphal --- Noticed this while working on the TX_LOCKED removal. diff --git a/drivers/infiniband/hw/nes/nes_nic.c

Re: linux-next: zillions of lockdep whinges in include/net/sock.h:1408

On Sun, 2016-04-24 at 14:54 -0400, David Miller wrote: > From: Hannes Frederic Sowa > Date: Sun, 24 Apr 2016 20:48:24 +0200 > > > Eric's patch is worth to apply anyway, but I am not sure if it solves > > the (fundamental) problem. I couldn't reproduce it with the

[PATCH net-next V1 03/11] net/mlx5e: Rename VPort counters

From: Gal Pressman VPort and software counters names are confusing and may be unclear, all VPort counters now have a prefix of rx/tx_vport_*. Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed ---

Re: linux-next: zillions of lockdep whinges in include/net/sock.h:1408

On Sun, 24 Apr 2016 12:46:42 -0700, Eric Dumazet said: > >>> + return !debug_locks || > >>> +lockdep_is_held(>sk_lock) || > Issue here is that once lockdep detected a problem (not necessarily in > net/ tree btw), your helper always 'detect' a problem, since lockdep > automatically

[PATCH net-next V1 00/11] Mellanox 100G extending mlx5 ethtool support

Hi Dave, Changes from V0: - Dropped: net/mlx5e: Disable link up on INIT HCA command Due to Ido's and Or's requests we will submit this patch to net and will need it for -stable. - Rebased to: 11afbff86168 ("Merge

[PATCH net-next V1 08/11] net/mlx5e: Add ethtool support for interface identify (LED blinking)

From: Gal Pressman Add the needed hardware command and mlx5_ifc structs for managing LED control. Add set_phys_id ethtool callback to support ethtool -p flag. Signed-off-by: Gal Pressman Signed-off-by: Eugenia Emantayev

[PATCH net-next V1 10/11] net/mlx5e: Add ethtool support for rxvlan-offload (vlan stripping)

From: Gal Pressman Use ethtool -K rxvlan to enable/disable C-TAG vlan stripping by hardware. Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h |3 +

[PATCH net-next V1 05/11] net/mlx5e: Add link down events counter

From: Gal Pressman Expose link_down_events counter through ethtool -S. This counter is read from PPort statistics, then proccessed and stored as a special handling software counter. This counter is stored along software counters since it is the only PPort counter that it's

[PATCH net-next V1 09/11] net/mlx5e: Add ethtool support for dump module EEPROM

From: Gal Pressman Add query MCIA, PMLP registers infrastructure and commands. Add ethtool support for get_module_info() and get_module_eeprom() callbacks. Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed ---

[PATCH net-next V1 02/11] net/mlx5e: Statistics handling refactoring

From: Gal Pressman Redesign ethtool statistics handling and reporting in the driver: 1. Move counters to a separate file (en_stats.h). 2. Remove unnecessary dependencies between stats and strings. 3. Use counter descriptors which hold a name and offset for each counter, and

[PATCH net-next V1 01/11] net/mlx5e: Report additional error statistics in get stats ndo

From: Gal Pressman Provide rtnl_link_stats64 with information regarding physical errors to be seen in ifconfig and ip tool. Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed ---

[PATCH net-next V1 06/11] net/mlx5e: Improve set features ndo resiliency

From: Gal Pressman In current mlx5e ndo_set_features implementation, setting some features can success while others can fail. Today, we return one error code which doesn't reflect the current features status of the netdev at the end of the ndo callback. Set netdev->features

[PATCH net-next V1 07/11] net/mlx5e: Add support for RXALL netdev feature

From: Eran Ben Elisha Introduce new access register named Ports Check Mask Register (PCMR) to control all HW checks on port. With this register, the driver can enable/disable Hardware FCS validation. When RXALL is enabled/disabled using ndo_set_features, enable/disable fcs

[PATCH net-next V1 11/11] net/mlx5e: Fix checksum handling for non-stripped vlan packets

Now as rx-vlan offload can be disabled, packets can be received with vlan tag not stripped, which means is_first_ethertype_ip will return false, for that we need to check if the hardware reported csum OK so we will report CHECKSUM_UNNECESSARY for those packets. Signed-off-by: Saeed Mahameed

[PATCH net-next V1 04/11] net/mlx5e: Add per priority group to PPort counters

From: Gal Pressman Expose counters providing information for each priority level (PCP) through ethtool -S option and DCBNL. This includes rx/tx bytes, frames, and pause counters. Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed

Re: linux-next: zillions of lockdep whinges in include/net/sock.h:1408

On Sun, 2016-04-24 at 20:48 +0200, Hannes Frederic Sowa wrote: > On 24.04.2016 20:38, David Miller wrote: > > From: Hannes Frederic Sowa > > Date: Thu, 21 Apr 2016 15:49:37 +0200 > > > >> On 21.04.2016 15:31, Eric Dumazet wrote: > >>> On Thu, 2016-04-21 at 05:05

[PATCH net-next 5/6] drivers: net: remove NETDEV_TX_LOCKED

replace the trylock by a full spin_lock and remove TX_LOCKED return value. Followup patch will remove TX_LOCKED from the kernel. Cc: Jon Mason Cc: Andy Gospodarek Signed-off-by: Florian Westphal --- drivers/net/ethernet/chelsio/cxgb/sge.c

[PATCH net-next 0/6] net: core: remove TX_LOCKED support

Not that many users left, lets kill it. TX_LOCKED was meant to be used by LLTX drivers when spin_trylock() failed. Stack then re-queued if collisions happened on different cpus or free'd the skb to prevent deadlocks. Most of the driver removal patches fall into one of three categories: 1.

[PATCH net-next 2/6] atl1c: remove private tx lock

AFAICS this is safe: the lock is only used in the .ndo_start_xmit function and this driver does not set LLTX. Gets rid of TX_LOCKED return value, followup patches will remove it. Cc: Jay Cliburn Cc: Chris Snook Signed-off-by: Florian Westphal

[PATCH net-next 4/6] drivers: net: use NETDEV_TX_OK instead of NETDEV_TX_LOCKED

These drivers already call netif_stop_queue() so we should not be called unless tx space is available. Just free the skb and return TX_OK. Followup patch will remove NETDEV_TX_LOCKED from the kernel. Cc: linux-par...@vger.kernel.org Cc: linux-h...@vger.kernel.org Cc: Thomas Sailer

[PATCH net-next 3/6] atle1: remove LLTX support and TX_UNLOCKED

similar to atl1c: lock is only used in ndo_start_xmit, but we also advertised LLTX, so remove that as well and let core stack handle tx locking. Allows to remove the TX_LOCKED return value from the driver. Cc: Jay Cliburn Cc: Chris Snook

[PATCH net-next 6/6] net: remove NETDEV_TX_LOCKED support

No more users in the tree, remove NETDEV_TX_LOCKED support. Adds another hole in softnet_stats struct, but better than keeping the unused collision counter around. Signed-off-by: Florian Westphal --- Documentation/networking/netdev-features.txt | 10 -

[PATCH net-next 1/6] RDMA/nes: remove use of NETDEV_TX_LOCKED

ndo_start_xmit never returns it to stack, but nes_nic_send helper used it if skb could not be queued to hardware. Switch to bool instead. Cc: Signed-off-by: Florian Westphal --- drivers/infiniband/hw/nes/nes_nic.c | 13 + 1 file changed,

Re: linux-next: zillions of lockdep whinges in include/net/sock.h:1408

From: Hannes Frederic Sowa Date: Sun, 24 Apr 2016 20:48:24 +0200 > Eric's patch is worth to apply anyway, but I am not sure if it solves > the (fundamental) problem. I couldn't reproduce it with the exact next- > tag provided in the initial mail. All other reports

Re: [PATCH net V1 0/8] mlx5 driver updates and fixes

From: Saeed Mahameed Date: Fri, 22 Apr 2016 00:32:59 +0300 > Changes from V0: > - Dropped: ("net/mlx5e: Reset link modes upon setting speed to zero") > - Fixed compilation issue introduced to mlx5_ib driver. > - Rebased to df637193906a ('Revert "Prevent

Re: linux-next: zillions of lockdep whinges in include/net/sock.h:1408

On 24.04.2016 20:38, David Miller wrote: > From: Hannes Frederic Sowa > Date: Thu, 21 Apr 2016 15:49:37 +0200 > >> On 21.04.2016 15:31, Eric Dumazet wrote: >>> On Thu, 2016-04-21 at 05:05 -0400, valdis.kletni...@vt.edu wrote: On Thu, 21 Apr 2016 09:42:12 +0200,

Re: [PATCH net 1/1] qlcnic: Update version to 5.3.64

From: Manish Chopra Date: Thu, 21 Apr 2016 13:25:20 -0400 > Just updating the version as many fixes got > accumulated over 5.3.63 > > Signed-off-by: Manish Chopra Applied.

Re: [PATCH v2 net-next] tcp-tso: do not split TSO packets at retransmit time

From: Eric Dumazet Date: Thu, 21 Apr 2016 10:55:23 -0700 > Linux TCP stack painfully segments all TSO/GSO packets before retransmits. > > This was fine back in the days when TSO/GSO were emerging, with their > bugs, but we believe the dark age is over. > > Keeping big

Re: [PATCH V3] net: stmmac: socfpga: Remove re-registration of reset controller

From: Marek Vasut Date: Thu, 21 Apr 2016 14:11:50 +0200 > Both socfpga_dwmac_parse_data() in dwmac-socfpga.c and stmmac_dvr_probe() > in stmmac_main.c functions call devm_reset_control_get() to register an > reset controller for the stmmac. This results in an attempt to register >

Re: linux-next: zillions of lockdep whinges in include/net/sock.h:1408

From: Hannes Frederic Sowa Date: Thu, 21 Apr 2016 15:49:37 +0200 > On 21.04.2016 15:31, Eric Dumazet wrote: >> On Thu, 2016-04-21 at 05:05 -0400, valdis.kletni...@vt.edu wrote: >>> On Thu, 21 Apr 2016 09:42:12 +0200, Hannes Frederic Sowa said: Hi, On

Re: [PATCH net-next v1 1/1] tipc: fix stale links after re-enabling bearer

From: Parthasarathy Bhuvaragan Date: Thu, 21 Apr 2016 15:51:13 +0200 > Commit 42b18f605fea ("tipc: refactor function tipc_link_timeout()"), > introduced a bug which prevents sending of probe messages during > link synchronization phase. This leads to

Re: [PATCH net v2 0/9] macsec: a few fixes

From: Sabrina Dubroca Date: Fri, 22 Apr 2016 11:28:00 +0200 > Some small fixes for the macsec driver: > - possible NULL pointer dereferences > - netlink dumps fixes: RTNL locking, consistent dumps > - a reference counting bug > - wrong name for uapi constant > - a few

Re: [patch net 0/3] bridge: mdb: Couple of fixes

From: Jiri Pirko Date: Thu, 21 Apr 2016 12:52:42 +0200 > From: Jiri Pirko > > Elad says: > > This patchset fixes two problems reported by Nikolay Aleksandrov. The first > problem is that the MDB offload flag might be accesed without helding the >

Re: [PATCH v2] MAINTAINERS: net: add entry for TI Ethernet Switch drivers

From: Grygorii Strashko Date: Thu, 21 Apr 2016 13:13:56 +0300 > Add record for TI Ethernet Switch Driver CPSW/CPDMA/MDIO HW > (am33/am43/am57/dr7/davinci) to ensure that related patches > will go through dedicated linux-omap list. > > Also add Mugunthan as maintainer

Re: [PATCH 1/6] bus: Add shared MDIO bus framework

From: Pramod Kumar Date: Thu, 21 Apr 2016 14:48:38 +0530 > +struct shared_mdio_master *shared_mdio_alloc_master(struct device *parent, > + struct device_node *node) > +{ > + int ret = 0; > + struct

Re: [PATCH net-next] macvtap: add namespace support to the sysfs device class

From: Marc Angel Date: Wed, 20 Apr 2016 16:11:31 +0200 > However, doing this has the side effect of changing > /sys/devices/virtual/net/macvtapX/tapNN into > /sys/devices/virtual/net/macvtapX/macvtap/tapNN I'm really not comfortable at all with having this sysfs device name

[PATCH v3 03/21] io-mapping: Specify mapping size for io_mapping_map_wc()

The ioremap() hidden behind the io_mapping_map_wc() convenience helper can be used for remapping multiple pages. Extend the helper so that future callers can use it for larger ranges. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Daniel

Re: [PATCH net-next 0/2] tcp: Handle txstamp_ack when fragmenting/coalescing skbs

From: Martin KaFai Lau Date: Tue, 19 Apr 2016 22:50:46 -0700 > This patchset is to handle the txstamp-ack bit when > fragmenting/coalescing skbs. ... Series applied, thanks.

Re: [PATCH 5/5] of_mdio: get_phy_device() doesn't return NULL anymore

On 04/24/2016 08:31 PM, Sergei Shtylyov wrote: Now that get_phy_device() no longer returns NULL on error, we don't need to check for it... Signed-off-by: Sergei Shtylyov Oops, forgot to CC: the DT people, doing that now... --- drivers/of/of_mdio.c

[PATCH 5/5] of_mdio: get_phy_device() doesn't return NULL anymore

Now that get_phy_device() no longer returns NULL on error, we don't need to check for it... Signed-off-by: Sergei Shtylyov --- drivers/of/of_mdio.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: net-next/drivers/of/of_mdio.c

[PATCH 4/5] mdio_bus: get_phy_device() doesn't return NULL anymore

Now that get_phy_device() no longer returns NULL on error, we don't need to check for it... Signed-off-by: Sergei Shtylyov --- drivers/net/phy/mdio_bus.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: net-next/drivers/net/phy/mdio_bus.c

[PATCH 3/5] fixed_phy: get_phy_device() doesn't return NULL anymore

Now that get_phy_device() no longer returns NULL on error, we don't need to check for it... Signed-off-by: Sergei Shtylyov --- drivers/net/phy/fixed_phy.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: net-next/drivers/net/phy/fixed_phy.c

[PATCH 2/5] xgene: get_phy_device() doesn't return NULL anymore

Now that get_phy_device() no longer returns NULL on error, we don't need to check for it... Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index:

[PATCH 1/5] phylib: don't return NULL from get_phy_device()

Arnd Bergmann asked that get_phy_device() returns either NULL or the error value, not both on error. Do as he said, return ERR_PTR(-ENODEV) instead of NULL when the PHY ID registers read as all ones. Suggested-by: Arnd Bergmann Signed-off-by: Sergei Shtylyov

[PATCH 0/5] Don't return NULL from get_phy_device() anymore

Hello. Here's the set of 5 patches against DaveM's 'net-next.git' repo. The first patch makes get_phy_device() return only error values on error, the rest of the patches clean up the callers of that function... [1/5] phylib-don-t-return-NULL-from-get_phy_device.patch [2/5]

[PATCH net-next] ravb: Remove rx buffer ALIGN

From: Kazuya Mizuguchi Aligning the reception data size is not required. Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko --- This patch is based on the master branch of David Miller's

[PATCH] sh_eth: get rid of the 2nd parameter to sh_eth_dev_init()

sh_eth_dev_init() is now always called with 'true' as the 2nd argument, so that there's no more sense in having 2 parameters to this function... Signed-off-by: Sergei Shtylyov --- The patch is against DaveM's 'net-next.git' repo.

[PATCH net-next] sctp: sctp_diag should fill RMEM_ALLOC with asoc->rmem_alloc when rcvbuf_policy is set

For sctp assoc, when rcvbuf_policy is set, it will has it's own rmem_alloc, when we dump asoc info in sctp_diag, we should use that value on RMEM_ALLOC as well, just like WMEM_ALLOC. Signed-off-by: Xin Long --- net/sctp/sctp_diag.c | 6 +- 1 file changed, 5

Re: [PATCH net v2 1/3] gre: do not assign header_ops in collect metadata mode

Hello. On 4/24/2016 2:00 PM, Jiri Benc wrote: In ipgre mode (i.e. not gretap) with collect metadata flag set, the tunnel is incorrectly assumed to be mGRE in NBMA mode (see commit 6a5f44d7a048c). Didn't checkpatch.pl complain about the commit citing style? This is not the case, we're

[PATCH net v2 1/3] gre: do not assign header_ops in collect metadata mode

In ipgre mode (i.e. not gretap) with collect metadata flag set, the tunnel is incorrectly assumed to be mGRE in NBMA mode (see commit 6a5f44d7a048c). This is not the case, we're controlling the encapsulation addresses by lwtunnel metadata. And anyway, assigning dev->header_ops in collect metadata

[PATCH net v2 0/3] gre: fix lwtunnel support

This patchset fixes a few bugs in gre metadata mode implementation, mainly with ipgre. As an example, in this setup: ip a a 192.168.1.1/24 dev eth0 ip l a gre1 type gre external ip l s gre1 up ip a a 192.168.99.1/24 dev gre1 ip r a 192.168.99.2/32 encap ip dst 192.168.1.2 ttl 10 dev gre1 ping

[PATCH net v2 3/3] gre: allow creation of gretap interfaces in metadata mode

The IFLA_GRE_REMOTE attribute does not make sense together with collect metadata and is ignored in such case. However, iproute2 always sets it; it will be zero if there's no remote address specified on the command line. Remove the check for non-zero IFLA_GRE_REMOTE when collect medata flag is

[PATCH net v2 2/3] gre: build header correctly for collect metadata tunnels

In ipgre (i.e. not gretap) + collect metadata mode, the skb was assumed to contain Ethernet header and was encapsulated as ETH_P_TEB. This is not the case, the interface is ARPHRD_IPGRE and the protocol to be used for encapsulation is skb->protocol. Fixes: 2e15ea390e6f4 ("ip_gre: Add support to

Re: [PATCH net 3/3] gre: receive also TEB packets for lwtunnels

On Fri, 22 Apr 2016 20:40:13 -0700, pravin shelar wrote: > But skb->protocol is not set to ETH_P_TEB anywhere in ip-gre module. > Am I missing something? Ah, I see your point. It needs to be solved a bit differently, though, we need to call __iptunnel_pull_header instead of iptunnel_pull_header

Re: [PATCH net 3/3] gre: receive also TEB packets for lwtunnels

On Sat, 23 Apr 2016 15:09:16 +1000, Simon Horman wrote: > On Sat, Apr 23, 2016 at 03:49:38AM +0200, Thomas Graf wrote: > > I may be missing some context. Is anyone using this already or is this > > preparing the stage for another user? It's not clear to me from the > > commit message. > > Hi

Re: [PATCH net 1/3] gre: do not assign header_ops in collect metadata mode

On Sat, 23 Apr 2016 03:41:43 +0200, Thomas Graf wrote: > On 04/22/16 at 11:20pm, Jiri Benc wrote: > > On Fri, 22 Apr 2016 14:04:48 -0700, pravin shelar wrote: > > > I think we should we return error in case of such configuration rather > > > than silently ignoring it. > > > > I thought about it

Re: [PATCH net] net/mlx4_en: fix spurious timestamping callbacks

On Sat, Apr 23, 2016 at 9:35 PM, Eric Dumazet wrote: > From: Eric Dumazet > > When multiple skb are TX-completed in a row, we might incorrectly keep > a timestamp of a prior skb and cause extra work. > > Fixes: ec693d47010e8 ("net/mlx4_en: Add HW

Re: [PATCH v5 09/21] IB/hns: Add hca support

On Sat, Apr 23, 2016 at 06:26:47PM +0800, Lijun Ou wrote: > This patch mainly setup hca for RoCE. it will do a series of > initial works as follows: > 1. init uar table, allocate uar resource > 2. init pd table > 3. init cq table > 4. init mr table > 5. init qp table

Re: [PATCH v5 00/21] Add HiSilicon RoCE driver

On Sat, Apr 23, 2016 at 06:26:38PM +0800, Lijun Ou wrote: > The HiSilicon Network Substem is a long term evolution IP which is > supposed to be used in HiSilicon ICT SoCs. HNS (HiSilicon Network > Sybsystem) also has a hardware support of performing RDMA with > RoCEE. > The driver for HiSilicon

[PATCH v2 03/21] io-mapping: Specify mapping size for io_mapping_map_wc()

The ioremap() hidden behind the io_mapping_map_wc() convenience helper can be used for remapping multiple pages. Extend the helper so that future callers can use it for larger ranges. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Daniel

[PATCH 03/21] io-mapping: Specify mapping size for io_mapping_map_wc()

The ioremap() hidden behind the io_mapping_map_wc() convenience helper can be used for remapping multiple pages. Extend the helper so that future callers can use it for larger ranges. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Daniel