[PATCH v2 next-next 06/12] fou: Split out {fou,gue}_build_header

2016-05-06 Thread Tom Herbert
Create __fou_build_header and __gue_build_header. These implement the protocol generic parts of building the fou and gue header. fou_build_header and gue_build_header implement the IPv4 specific functions and call the __*_build_header functions. Signed-off-by: Tom Herbert

[PATCH v2 next-next 07/12] fou: Add encap ops for IPv6 tunnels

2016-05-06 Thread Tom Herbert
Thsi packet adds IP tunnel encapsulation operations for IPv6. This includes the infrastructure to add and delete operations. IPv6 variants for fou6_build_header and gue6_build_header are added in a new fou6 module. These encapsulation operations for fou and gue are automatically added when the

[PATCH v2 next-next 10/12] fou: Support IPv6 in fou

2016-05-06 Thread Tom Herbert
This patch adds receive path support for IPv6 with fou. - Add address family to fou structure for open sockets. This supports AF_INET and AF_INET6. Lookups for fou ports are performed on both the port number and family. - In fou and gue receive adjust tot_len in IPv4 header or payload_len

[PATCH v2 next-next 09/12] ipv6: Change "final" protocol processing for encapsulation

2016-05-06 Thread Tom Herbert
When performing foo-over-UDP, UDP are receveived processed by the encapsulation header which returns another protocol to process. This may result in processing two (or more) protocols in the loop that are marked as INET6_PROTO_FINAL. The actions taken for hitting a final protocol, in particular

[PATCH v2 next-next 03/12] gre6: Fix flag translations

2016-05-06 Thread Tom Herbert
GRE for IPv6 does not properly translate for GRE flags to tunnel flags and vice versa. This patch fixes that. Signed-off-by: Tom Herbert --- net/ipv6/ip6_gre.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/net/ipv6/ip6_gre.c

[PATCH v2 next-next 11/12] ip6_tun: Add infrastructure for doing encapsulation

2016-05-06 Thread Tom Herbert
Add encap_hlen and ip_tunnel_encap structure to ip6_tnl. Add functions for getting encap hlen, setting up encap on a tunnel, performing encapsulation operation. Signed-off-by: Tom Herbert --- include/net/ip6_tunnel.h | 8 +- net/ipv6/ip6_tunnel.c | 4 +++

[PATCH v2 next-next 00/12] ipv6: Enable GUEoIPv6 and more fixes for v6 tunneling

2016-05-06 Thread Tom Herbert
This patch set: - Fixes GRE6 to process translate flags correctly from configuration - Adds support for GSO and GRO for ip6ip6 and ip4ip6 - Add support for FOU and GUE in IPv6 - Support GRE, ip6ip6 and ip4ip6 over FOU/GUE - Fixes ip6_input to deal with UDP encapsulations - Some other

[PATCH v2 next-next 01/12] gso: Remove arbitrary checks for unsupported GSO

2016-05-06 Thread Tom Herbert
In several gso_segment functions there are checks of gso_type against a seemingly arbitrary list of SKB_GSO_* flags. This seems like an attempt to identify unsupported GSO types, but since the stack is the one that set these GSO types in the first place this seems unnecessary to do. If a

[PATCH v2 next-next 02/12] net: define gso types for IPx over IPv4 and IPv6

2016-05-06 Thread Tom Herbert
This patch defines two new GDO definitions SKB_GSO_IPXIP4 and SKB_GSO_IPXIP6 along with corresponding NETIF_F_GSO_IPXIP4 and NETIF_F_GSO_IPXIP6. These are used to described IP in IP tunnel and what the outer protocol is. The inner protocol can be deduced from other GSO types (e.g. SKB_GSO_TCPV4

[PATCH v2 next-next 05/12] fou: Call setup_udp_tunnel_sock

2016-05-06 Thread Tom Herbert
Use helper function to set up UDP tunnel related information for a fou socket. Signed-off-by: Tom Herbert --- net/ipv4/fou.c | 50 -- 1 file changed, 16 insertions(+), 34 deletions(-) diff --git a/net/ipv4/fou.c

[PATCH v2 next-next 12/12] ip6_gre: Add support for fou/gue encapsulation

2016-05-06 Thread Tom Herbert
Add netlink and setup for encapsulation Signed-off-by: Tom Herbert --- net/ipv6/ip6_gre.c | 75 ++ 1 file changed, 75 insertions(+) diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c index 70a1f72..ed5ddcc 100644 ---

[PATCH v2 next-next 04/12] udp: Don't set skb->encapsulation with RCO

2016-05-06 Thread Tom Herbert
When RCO is in effect we want to ensure that the outer checksum is properly offloaded. Don't set skb->encapsulation in this case to ensure that checksum offload is later considered for hw_features instead of hw_enc_features. Signed-off-by: Tom Herbert ---

[PATCH v2 next-next 08/12] ipv6: Fix nexthdr for reinjection

2016-05-06 Thread Tom Herbert
In ip6_input_finish the protocol handle returns a value greater than zero the packet needs to be resubmitted using the returned protocol. The returned protocol is being ignored and each time through resubmit nexthdr is taken from an offest in the packet. This patch fixes that so that nexthdr is

Re: [PATCH net-next] ipv4: tcp: ip_send_unicast_reply() is not BH safe

2016-05-06 Thread David Miller
From: Eric Dumazet Date: Fri, 06 May 2016 09:46:18 -0700 > From: Eric Dumazet > > I forgot that ip_send_unicast_reply() is not BH safe (yet). > > Disabling preemption before calling it was not a good move. > > Fixes: c10d9310edf5 ("tcp: do not

Re: [PATCH net-next 0/7] bpf: introduce direct packet access

2016-05-06 Thread David Miller
From: Alexei Starovoitov Date: Thu, 5 May 2016 19:49:08 -0700 > This set of patches introduce 'direct packet access' from > cls_bpf and act_bpf programs (which are root only). Series applied, thanks Alexei.

Re: [patch net 0/3] mlxsw: Couple of fixes

2016-05-06 Thread David Miller
From: Jiri Pirko Date: Fri, 6 May 2016 11:17:21 +0200 > From: Jiri Pirko > > Ido Schimmel (2): > mlxsw: spectrum: Fix rollback order in LAG join failure > mlxsw: spectrum: Add missing rollback in flood configuration > > Jiri Pirko (1): > mlxsw:

Re: [net-next 00/11][pull request] 40GbE Intel Wired LAN Driver Updates 2016-05-05

2016-05-06 Thread David Miller
From: Jeff Kirsher Date: Fri, 6 May 2016 00:03:37 -0700 > This series contains updates to i40e and i40evf. Looks good, pulled, thanks!

Re: [PATCH net-next v2] net: vrf: Create FIB tables on link create

2016-05-06 Thread David Miller
From: David Ahern Date: Wed, 4 May 2016 21:46:12 -0700 > Tables have to exist for VRFs to function. Ensure they exist > when VRF device is created. > > Signed-off-by: David Ahern > --- > v2 > - create table before rt6 allocation per comment

Re: [PATCH net 1/1] qede: prevent chip hang when increasing channels

2016-05-06 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Thu, 5 May 2016 00:35:16 -0400 > qede requires qed to provide enough resources to accommodate 16 combined > channels, but that upper-bound isn't actually being enforced by it. > Instead, qed inform back to qede how many channels

Re: [PATCH net v3 2/2] udp_offload: Set encapsulation before inner completes.

2016-05-06 Thread Alexander Duyck
On Fri, May 6, 2016 at 12:34 PM, David Miller wrote: > From: Jarno Rajahalme > Date: Tue, 3 May 2016 16:10:21 -0700 > >> UDP tunnel segmentation code relies on the inner offsets being set for >> an UDP tunnel GSO packet, but the inner *_complete() functions

Re: [PATCH] net: ipv6: tcp reset, icmp need to consider L3 domain

2016-05-06 Thread David Miller
From: David Ahern Date: Wed, 4 May 2016 21:26:08 -0700 > Responses for packets to unused ports are getting lost with L3 domains. > > IPv4 has ip_send_unicast_reply for sending TCP responses which accounts > for L3 domains; update the IPv6 counterpart

Re: [PATCH net v3] vlan: Propagate MAC address to VLANs

2016-05-06 Thread Alexander Duyck
On Fri, May 6, 2016 at 12:36 PM, Mike Manning wrote: > On 05/06/2016 06:02 PM, Alexander Duyck wrote: >> On Fri, May 6, 2016 at 6:26 AM, Mike Manning wrote: >>> The MAC address of the physical interface is only copied to the VLAN >>> when it is first

Re: [Y2038] [RESEND PATCH 2/3] fs: poll/select/recvmmsg: use timespec64 for timeout events

2016-05-06 Thread David Miller
From: John Stultz Date: Wed, 4 May 2016 17:01:24 -0700 > On Wed, May 4, 2016 at 4:51 PM, Andrew Morton > wrote: >> On Wed, 04 May 2016 23:08:11 +0200 Arnd Bergmann wrote: >> >>> > But I'm less comfortable making the call on

Re: [PATCH net-next] cnic: call cp->stop_hw() in cnic_start_hw() on allocation failure

2016-05-06 Thread David Miller
From: Jon Maxwell Date: Thu, 5 May 2016 09:55:51 +1000 > We recently had a system crash in the cnic module. Vmcore analysis confirmed > that "ip link up" was executed which failed due to an allocation failure > because of memory fragmentation. Futher analysis revealed

Re: OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] fq_codel_drop vs a udp flood)

2016-05-06 Thread Dave Taht
On Fri, May 6, 2016 at 11:56 AM, Roman Yeryomin wrote: > On 6 May 2016 at 21:43, Roman Yeryomin wrote: >> On 6 May 2016 at 15:47, Jesper Dangaard Brouer wrote: >>> >>> I've created a OpenWRT ticket[1] on this issue, as it seems

Re: [PATCH 2/3] net/mlx5e: make VXLAN support conditional

2016-05-06 Thread David Miller
From: Arnd Bergmann Date: Thu, 05 May 2016 20:09:19 +0200 > For reference, I've tried it out on the MLX4 driver, and it does > seem nicer that way, see below. Is it possible to wind down this conversation and have someone submit whatever final patch everyone agrees to? Thanks.

[PATCH] e1000e: prevent division by zero if TIMINCA is zero

2016-05-06 Thread Denys Vlasenko
Users report that under VMWare, er32(TIMINCA) returns zero. This causes division by zero at init time as follows: ==>incvalue = er32(TIMINCA) & E1000_TIMINCA_INCVALUE_MASK; for (i = 0; i < E1000_MAX_82574_SYSTIM_REREADS; i++) { /* latch SYSTIMH

Re: [PATCH net] netfilter: nf_conntrack: Use net_mutex for helper unregistration.

2016-05-06 Thread Joe Stringer
On 6 May 2016 at 04:03, Pablo Neira Ayuso wrote: > Hi Joe, > > On Thu, May 05, 2016 at 03:50:37PM -0700, Joe Stringer wrote: >> diff --git a/net/netfilter/nf_conntrack_helper.c >> b/net/netfilter/nf_conntrack_helper.c >> index 3b40ec575cd5..6860b19be406 100644 >> ---

Re: [PATCH net-next 1/2] sfc: Support setting rss_cpus to 'cores', 'packages' or 'hyperthreads'

2016-05-06 Thread David Miller
From: Edward Cree Date: Wed, 4 May 2016 18:01:52 +0100 > These settings autoconfigure the number of RSS channels to match the number of > CPUs present. > > Signed-off-by: Edward Cree I can't believe I allowed this 'rss_cpus' thing into the tree to

Re: [PATCH net v3] vlan: Propagate MAC address to VLANs

2016-05-06 Thread Mike Manning
On 05/06/2016 06:02 PM, Alexander Duyck wrote: > On Fri, May 6, 2016 at 6:26 AM, Mike Manning wrote: >> The MAC address of the physical interface is only copied to the VLAN >> when it is first created, resulting in an inconsistency after MAC >> address changes of only newly

Re: [PATCH net v3 2/2] udp_offload: Set encapsulation before inner completes.

2016-05-06 Thread David Miller
From: Jarno Rajahalme Date: Tue, 3 May 2016 16:10:21 -0700 > UDP tunnel segmentation code relies on the inner offsets being set for > an UDP tunnel GSO packet, but the inner *_complete() functions will > set the inner offsets only if 'encapsulation' is set before calling > them.

Re: OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] fq_codel_drop vs a udp flood)

2016-05-06 Thread Roman Yeryomin
On 6 May 2016 at 21:43, Roman Yeryomin wrote: > On 6 May 2016 at 15:47, Jesper Dangaard Brouer wrote: >> >> I've created a OpenWRT ticket[1] on this issue, as it seems that someone[2] >> closed Felix'es OpenWRT email account (bad choice! emails

Re: [PATCH] Add support for configuring Infiniband GUIDs

2016-05-06 Thread Stephen Hemminger
On Fri, 6 May 2016 10:43:25 -0500 Eli Cohen wrote: > Add two NLA's that allow configuration of Infiniband node or port GUIDs > by referencing the IPoIB net device set over then physical function. The > format to be used is as follows: > > ip link set dev ib0 vf 0 node_guid

Re: [PATCH iproute2 0/2] ip link gre: fix external mode handling

2016-05-06 Thread Stephen Hemminger
On Wed, 27 Apr 2016 16:11:12 +0200 Jiri Benc wrote: > Fix two bugs with handling of the 'external' keyword for GRE. > > Jiri Benc (2): > ip link gre: create interfaces in external mode correctly > ip link gre: print only relevant info in external mode > > ip/link_gre.c |

Re: OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] fq_codel_drop vs a udp flood)

2016-05-06 Thread Roman Yeryomin
On 6 May 2016 at 15:47, Jesper Dangaard Brouer wrote: > > I've created a OpenWRT ticket[1] on this issue, as it seems that someone[2] > closed Felix'es OpenWRT email account (bad choice! emails bouncing). > Sounds like OpenWRT and the LEDE https://www.lede-project.org/ project

Re: [REGRESSION] asix: Lots of asix_rx_fixup() errors and slow transmissions

2016-05-06 Thread John Stultz
On Tue, May 3, 2016 at 2:16 PM, Dean Jenkins wrote: > A good test would be to run "ping -c 1 -s $packet_length $ip_address" inside > a script which has a loop with an increasing payload length $packet_length > with a small delay between ping calls. This will show whether

Re: [PATCH] netdev: enc28j60 kernel panic fix.

2016-05-06 Thread David Russell
I kind of thought my patch was at best incomplete. When you state this change silences the bug but does not fix it, what are the implications of systems running this patch? We have some production systems using this patch. They reboot daily, but have been solid. In addition, if we sent you a

Re: [PATCH v2] rtlwifi: pci: use dev_kfree_skb_irq instead of kfree_skb in rtl_pci_reset_trx_ring

2016-05-06 Thread Alexander Duyck
On Fri, May 6, 2016 at 11:01 AM, Larry Finger wrote: > On 05/06/2016 12:13 PM, Alexander Duyck wrote: >> >> On Fri, May 6, 2016 at 9:33 AM, Wang YanQing wrote: >>> >>> We can't use kfree_skb in irq disable context, because spin_lock_irqsave >>> make

Re: [PATCH v2] rtlwifi: pci: use dev_kfree_skb_irq instead of kfree_skb in rtl_pci_reset_trx_ring

2016-05-06 Thread Larry Finger
On 05/06/2016 12:13 PM, Alexander Duyck wrote: On Fri, May 6, 2016 at 9:33 AM, Wang YanQing wrote: We can't use kfree_skb in irq disable context, because spin_lock_irqsave make sure we are always in irq disable context, use dev_kfree_skb_irq instead of kfree_skb is better

[PATCH v1 1/1] ISDN: eicon: replace custom hex_asc_lo() / hex_pack_byte()

2016-05-06 Thread Andy Shevchenko
Instead of custom approach re-use generic helpers to convert byte to hex format. Signed-off-by: Andy Shevchenko --- drivers/isdn/hardware/eicon/message.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git

Re: [REGRESSION] asix: Lots of asix_rx_fixup() errors and slow transmissions

2016-05-06 Thread John Stultz
On Fri, May 6, 2016 at 8:00 AM, Dean Jenkins wrote: > My conclusion is that your USB to Ethernet Adaptor is not running at high > speed (480Mbps) mode which is causing a partial loss (corruption) of > Ethernet frames across the USB link. A USB Protocol Analyser or

[PATCH v2] Documentation/networking: more accurate LCO explanation

2016-05-06 Thread Shmulik Ladkani
In few places the term "ones-complement sum" was used but the actual meaning is "the complement of the ones-complement sum". Also, avoid enclosing long statements with underscore, to ease readability. Signed-off-by: Shmulik Ladkani Acked-by: Edward Cree

Re: [PATCH v2] rtlwifi: pci: use dev_kfree_skb_irq instead of kfree_skb in rtl_pci_reset_trx_ring

2016-05-06 Thread Alexander Duyck
On Fri, May 6, 2016 at 9:33 AM, Wang YanQing wrote: > We can't use kfree_skb in irq disable context, because spin_lock_irqsave > make sure we are always in irq disable context, use dev_kfree_skb_irq > instead of kfree_skb is better than dev_kfree_skb_any. > > This patch fix

Re: [REGRESSION] asix: Lots of asix_rx_fixup() errors and slow transmissions

2016-05-06 Thread John Stultz
On Thu, May 5, 2016 at 1:11 AM, Dean Jenkins wrote: > On 05/05/16 00:45, John Stultz wrote: >> >> Just as a sample point, I have managed to reproduce exactly this issue >> on an x86_64 system by simply scp'ing a large file. > > Please tell us the x86_64 kernel version

Re: [PATCH] Add support for configuring Infiniband GUIDs

2016-05-06 Thread Sergei Shtylyov
Hello. On 05/06/2016 06:43 PM, Eli Cohen wrote: Add two NLA's that allow configuration of Infiniband node or port GUIDs by referencing the IPoIB net device set over then physical function. The format to be used is as follows: ip link set dev ib0 vf 0 node_guid 00:02:c9:03:00:21:6e:70 ip link

Re: [PATCH v2] rtlwifi: pci: use dev_kfree_skb_irq instead of kfree_skb in rtl_pci_reset_trx_ring

2016-05-06 Thread Larry Finger
On 05/06/2016 11:33 AM, Wang YanQing wrote: We can't use kfree_skb in irq disable context, because spin_lock_irqsave make sure we are always in irq disable context, use dev_kfree_skb_irq instead of kfree_skb is better than dev_kfree_skb_any. This patch fix below kernel warning: [ 7612.095528]

Re: [PATCH v9 net-next 1/2] hv_sock: introduce Hyper-V Sockets

2016-05-06 Thread David Miller
From: Dexuan Cui Date: Wed, 4 May 2016 09:56:57 -0700 > +#define VMBUS_RINGBUFFER_SIZE_HVSOCK_RECV (5 * PAGE_SIZE) > +#define VMBUS_RINGBUFFER_SIZE_HVSOCK_SEND (5 * PAGE_SIZE) > + > +#define HVSOCK_RCV_BUF_SZVMBUS_RINGBUFFER_SIZE_HVSOCK_RECV ... > +struct hvsock_sock {

Re: [PATCH net v3] vlan: Propagate MAC address to VLANs

2016-05-06 Thread Alexander Duyck
On Fri, May 6, 2016 at 6:26 AM, Mike Manning wrote: > The MAC address of the physical interface is only copied to the VLAN > when it is first created, resulting in an inconsistency after MAC > address changes of only newly created VLANs having an up-to-date MAC. > > The

Re: [PATCHv2 net] bridge: fix igmp / mld query parsing

2016-05-06 Thread David Miller
From: Linus Lüssing Date: Wed, 4 May 2016 17:25:02 +0200 > With the newly introduced helper functions the skb pulling is hidden > in the checksumming function - and undone before returning to the > caller. > > The IGMP and MLD query parsing functions in the bridge

Re: [REGRESSION] asix: Lots of asix_rx_fixup() errors and slow transmissions

2016-05-06 Thread Dean Jenkins
On 06/05/16 16:27, Andrew Lunn wrote: In other words, the full-speed hub is restricting the USB to Ethernet Adaptor to a 12Mbps (half-duplex) bandwidth to support Ethernet 100Mbps (full-duplex) traffic. That is not going to work very well because Ethernet frames (perhaps partial Ethernet frames)

Re: [PATCH] Documentation/networking: more accurate LCO explanation

2016-05-06 Thread David Miller
From: Alexander Duyck Date: Fri, 6 May 2016 09:29:56 -0700 > I don't really see the point of using an underscore before and after > that statement. If it was only one or two words it might work for > emphasis but the statement is large enough that starting it with an

[PATCH v2] rtlwifi: pci: use dev_kfree_skb_irq instead of kfree_skb in rtl_pci_reset_trx_ring

2016-05-06 Thread Wang YanQing
We can't use kfree_skb in irq disable context, because spin_lock_irqsave make sure we are always in irq disable context, use dev_kfree_skb_irq instead of kfree_skb is better than dev_kfree_skb_any. This patch fix below kernel warning: [ 7612.095528] [ cut here ] [

[PATCH net-next] ipv4: tcp: ip_send_unicast_reply() is not BH safe

2016-05-06 Thread Eric Dumazet
From: Eric Dumazet I forgot that ip_send_unicast_reply() is not BH safe (yet). Disabling preemption before calling it was not a good move. Fixes: c10d9310edf5 ("tcp: do not assume TCP code is non preemptible") Signed-off-by: Eric Dumazet Reported-by:

Re: [PATCH] Documentation/networking: more accurate LCO explanation

2016-05-06 Thread Alexander Duyck
On Fri, May 6, 2016 at 8:57 AM, Shmulik Ladkani wrote: > In few places the term "ones-complement sum" was used but the actual > meaning is "the complement of the ones-complement sum". Looks like there might still be a few minor corrections needed. Comments inline

RE: [Intel-wired-lan] NULL dereference on v4.1.x while enabling VF

2016-05-06 Thread Skidmore, Donald C
Hey William, My validation hasn't be able to recreate the dereference on v4.1.x, v4.5.x or net_next. Where exactly did you place the two line script in your rc scripts. Our validation was able to run it as soon as ~14 second after the first boot message logged in dmesg. Is this anywhere

Re: [PATCH] Documentation/networking: more accurate LCO explanation

2016-05-06 Thread Edward Cree
On 06/05/16 16:57, Shmulik Ladkani wrote: > In few places the term "ones-complement sum" was used but the actual > meaning is "the complement of the ones-complement sum". > > Signed-off-by: Shmulik Ladkani Acked-by: Edward Cree

Re: [PATCH] rtlwifi: pci: use dev_kfree_skb_irq instead of kfree_skb in rtl_pci_reset_trx_ring

2016-05-06 Thread Larry Finger
On 05/05/2016 12:19 PM, Wang YanQing wrote: We can't use kfree_skb in irq disable context, because spin_lock_irqsave make sure we are always in irq disable context, use dev_kfree_skb_irq instead of kfree_skb is better than dev_kfree_skb_any. This patch fix below kernel warning: [ 7612.095528]

[PATCH] Documentation/networking: more accurate LCO explanation

2016-05-06 Thread Shmulik Ladkani
In few places the term "ones-complement sum" was used but the actual meaning is "the complement of the ones-complement sum". Signed-off-by: Shmulik Ladkani --- I assume readers interpret the term "ones-complement sum" as the sum using one's complement arithmentic,

[PATCH net-next] fq_codel: add memory limitation per queue

2016-05-06 Thread Eric Dumazet
From: Eric Dumazet On small embedded routers, one wants to control maximal amount of memory used by fq_codel, instead of controlling number of packets or bytes, since GRO/TSO make these not practical. Assuming skb->truesize is accurate, we have to keep track of

[PATCH] Add support for configuring Infiniband GUIDs

2016-05-06 Thread Eli Cohen
Add two NLA's that allow configuration of Infiniband node or port GUIDs by referencing the IPoIB net device set over then physical function. The format to be used is as follows: ip link set dev ib0 vf 0 node_guid 00:02:c9:03:00:21:6e:70 ip link set dev ib0 vf 0 port_guid 00:02:c9:03:00:21:6e:78

Re: [PATCH iproute2] geneve: fix IPv6 remote address reporting

2016-05-06 Thread Phil Sutter
On Fri, May 06, 2016 at 04:14:11PM +0100, Edward Cree wrote: > On 06/05/16 15:43, Phil Sutter wrote: > > On Fri, May 06, 2016 at 03:28:25PM +0100, Edward Cree wrote: > >> Since we can only configure unicast, we probably want to be able to > >> display unicast, rather than multicast. > >

Re: [REGRESSION] asix: Lots of asix_rx_fixup() errors and slow transmissions

2016-05-06 Thread Andrew Lunn
> In other words, the full-speed hub is restricting the USB to > Ethernet Adaptor to a 12Mbps (half-duplex) bandwidth to support > Ethernet 100Mbps (full-duplex) traffic. That is not going to work > very well because Ethernet frames (perhaps partial Ethernet frames) > need to be discarded within

Re: [PATCH iproute2] geneve: fix IPv6 remote address reporting

2016-05-06 Thread Edward Cree
On 06/05/16 15:43, Phil Sutter wrote: > On Fri, May 06, 2016 at 03:28:25PM +0100, Edward Cree wrote: >> Since we can only configure unicast, we probably want to be able to >> display unicast, rather than multicast. > Furthermore, the kernel even rejects multicast peer addresses. Yes, but a future

Re: [RFC PATCH net-next 14/20] net: dsa: mv88e6xxx: factorize VLAN Ethertype

2016-05-06 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> @@ -55,6 +58,7 @@ static const struct mv88e6xxx_info mv88e6131_table[] = { >> .num_databases = 256, >> .num_ports = 10, >> .flags = MV88E6XXX_FLAG_ATU | >> +MV88E6XXX_FLAG_CORE_TAG_TYPE

Re: [REGRESSION] asix: Lots of asix_rx_fixup() errors and slow transmissions

2016-05-06 Thread Dean Jenkins
On 05/05/16 13:19, Guodong Xu wrote: Hi, Dean I am not sure why do you insist 'not full speed'. Actually, the tests I run on ARM-64bit is at USB full speed mode. I pasted my log here: http://paste.ubuntu.com/16236442/ , which includes the information you requested above, ifconfig, dmesg. The

Re: [PATCH iproute2] geneve: fix IPv6 remote address reporting

2016-05-06 Thread Phil Sutter
On Fri, May 06, 2016 at 03:28:25PM +0100, Edward Cree wrote: > Since we can only configure unicast, we probably want to be able to > display unicast, rather than multicast. Furthermore, the kernel even rejects multicast peer addresses. > I'm assuming this is what was intended, but tbh I don't

[PATCH iproute2] geneve: fix IPv6 remote address reporting

2016-05-06 Thread Edward Cree
Since we can only configure unicast, we probably want to be able to display unicast, rather than multicast. Fixes: 906ac5437ab8 ("geneve: add support for IPv6 link partners") Signed-off-by: Edward Cree --- I'm assuming this is what was intended, but tbh I don't know why we

[PATCH v4 1/2] soc: qcom: smd: Introduce compile stubs

2016-05-06 Thread Bjorn Andersson
Introduce compile stubs for the SMD API, allowing consumers to be compile tested. Acked-by: Andy Gross Signed-off-by: Bjorn Andersson --- Changes since v3: - None Changes since v2: - Introduce this patch, to allow compile testing of QRTR_SMD

[PATCH v4 2/2] net: Add Qualcomm IPC router

2016-05-06 Thread Bjorn Andersson
From: Courtney Cavin Add an implementation of Qualcomm's IPC router protocol, used to communicate with service providing remote processors. Signed-off-by: Courtney Cavin Signed-off-by: Bjorn Andersson

[PATCH net v3] vlan: Propagate MAC address to VLANs

2016-05-06 Thread Mike Manning
The MAC address of the physical interface is only copied to the VLAN when it is first created, resulting in an inconsistency after MAC address changes of only newly created VLANs having an up-to-date MAC. The VLANs should continue inheriting the MAC address of the physical interface, unless

[PATCH net] macvtap: segmented packet is consumed

2016-05-06 Thread Eric Dumazet
From: Eric Dumazet If GSO packet is segmented and its segments are properly queued, we call consume_skb() instead of kfree_skb() to be drop monitor friendly. Fixes: 3e4f8b7873709 ("macvtap: Perform GSO on forwarding path.") Signed-off-by: Eric Dumazet

Re: OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] fq_codel_drop vs a udp flood)

2016-05-06 Thread Jesper Dangaard Brouer
I've created a OpenWRT ticket[1] on this issue, as it seems that someone[2] closed Felix'es OpenWRT email account (bad choice! emails bouncing). Sounds like OpenWRT and the LEDE https://www.lede-project.org/ project is in some kind of conflict. OpenWRT ticket [1]

[PATCH v2] net: arc/emac: Move arc_emac_tx_clean() into arc_emac_tx() and disable tx interrut

2016-05-06 Thread Caesar Wang
From: Shuyu Wei Doing tx_clean() inside poll() may scramble the tx ring buffer if tx() is running. This will cause tx to stop working, which can be reproduced by simultaneously downloading two large files at high speed. Moving tx_clean() into tx() will prevent this. And tx

Re: [PATCH net] netfilter: nf_conntrack: Use net_mutex for helper unregistration.

2016-05-06 Thread Pablo Neira Ayuso
Hi Joe, On Thu, May 05, 2016 at 03:50:37PM -0700, Joe Stringer wrote: > diff --git a/net/netfilter/nf_conntrack_helper.c > b/net/netfilter/nf_conntrack_helper.c > index 3b40ec575cd5..6860b19be406 100644 > --- a/net/netfilter/nf_conntrack_helper.c > +++ b/net/netfilter/nf_conntrack_helper.c > @@

Re: ixgbe: cannot enable LRO

2016-05-06 Thread Otto Sabart
> On Wed, Apr 27, 2016 at 2:36 AM, Otto Sabart wrote: > > > > Hello everyone, > > does anybody have a problem with LRO on ixge (on latest 4.6-rc5)? > > I cannot find a way to enable it. > > > > On stable RHEL7.2 kernel everything works fine. > > > > I opened a bug report [0].

Re: [PATCHv2 bluetooth-next 07/10] ipv6: introduce neighbour discovery ops

2016-05-06 Thread Alexander Aring
Hi, On 05/06/2016 11:47 AM, Alexander Aring wrote: > > Hi, > > On 05/04/2016 02:23 PM, Stefan Schmidt wrote: >> Hello. >> >> On 20/04/16 10:19, Alexander Aring wrote: >>> This patch introduces neighbour discovery ops callback structure. The >>> structure contains at first receive and transmit

Re: [PATCHv2 bluetooth-next 07/10] ipv6: introduce neighbour discovery ops

2016-05-06 Thread Alexander Aring
Hi, On 05/04/2016 02:23 PM, Stefan Schmidt wrote: > Hello. > > On 20/04/16 10:19, Alexander Aring wrote: >> This patch introduces neighbour discovery ops callback structure. The >> structure contains at first receive and transmit handling for NS/NA and >> userspace option field functionality.

OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] fq_codel_drop vs a udp flood)

2016-05-06 Thread Jesper Dangaard Brouer
Hi Felix, This is an important fix for OpenWRT, please read! OpenWRT changed the default fq_codel sch->limit from 10240 to 1024, without also adjusting q->flows_cnt. Eric explains below that you must also adjust the buckets (q->flows_cnt) for this not to break. (Just adjust it to 128)

Re: [PATCHv2 bluetooth-next 07/10] ipv6: introduce neighbour discovery ops

2016-05-06 Thread Alexander Aring
Hi, On 05/03/2016 08:17 PM, Stefan Schmidt wrote: > Hello. > > On 02/05/16 21:36, Hannes Frederic Sowa wrote: >> On 20.04.2016 10:19, Alexander Aring wrote: >>> This patch introduces neighbour discovery ops callback structure. The >>> structure contains at first receive and transmit handling

Re: [PATCH v9 net-next 4/7] openvswitch: add layer 3 flow/port support

2016-05-06 Thread Jiri Benc
On Wed, 4 May 2016 16:36:30 +0900, Simon Horman wrote: > +static int push_eth(struct sk_buff *skb, struct sw_flow_key *key, > + const struct ovs_action_push_eth *ethh) > +{ > + int err; > + > + /* De-accelerate any hardware accelerated VLAN tag added to a previous > +

Re: [PATCHv2 bluetooth-next 02/10] 6lowpan: add 802.15.4 short addr slaac

2016-05-06 Thread Alexander Aring
Hi, On 05/03/2016 08:16 PM, Stefan Schmidt wrote: > Hello. > > On 20/04/16 10:19, Alexander Aring wrote: >> This patch adds the autoconfiguration if a valid 802.15.4 short address >> is available for 802.15.4 6LoWPAN interfaces. >> >> Cc: David S. Miller >> Cc: Alexey

Re: [PATCH v9 net-next 4/7] openvswitch: add layer 3 flow/port support

2016-05-06 Thread Jiri Benc
On Fri, 6 May 2016 14:57:07 +0900, Simon Horman wrote: > On Thu, May 05, 2016 at 10:37:08AM -0700, pravin shelar wrote: > > On transmit side you are using mac_len to detect l3 packet, why not do > > same while extracting the key? I agree. The skb should be self-contained, i.e. it should be

[patch net 1/3] mlxsw: spectrum: Fix rollback order in LAG join failure

2016-05-06 Thread Jiri Pirko
From: Ido Schimmel Make the leave procedure in the error path symmetric to the join procedure and first remove the port from the collector before potentially destroying the LAG. Fixes: 0d65fc13042f ("mlxsw: spectrum: Implement LAG port join/leave") Signed-off-by: Ido

[patch net 0/3] mlxsw: Couple of fixes

2016-05-06 Thread Jiri Pirko
From: Jiri Pirko Ido Schimmel (2): mlxsw: spectrum: Fix rollback order in LAG join failure mlxsw: spectrum: Add missing rollback in flood configuration Jiri Pirko (1): mlxsw: spectrum: Fix ordering in mlxsw_sp_fini drivers/net/ethernet/mellanox/mlxsw/spectrum.c

[patch net 2/3] mlxsw: spectrum: Add missing rollback in flood configuration

2016-05-06 Thread Jiri Pirko
From: Ido Schimmel When we fail to set the flooding configuration for the broadcast and unregistered multicast traffic, we should revert the flooding configuration of the unknown unicast traffic. Fixes: 0293038e0c36 ("mlxsw: spectrum: Add support for flood control")

[patch net 3/3] mlxsw: spectrum: Fix ordering in mlxsw_sp_fini

2016-05-06 Thread Jiri Pirko
From: Jiri Pirko Fixes: 0f433fa0ec ("mlxsw: spectrum_buffers: Implement shared buffer configuration") Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH v9 net-next 7/7] openvswitch: use ipgre tunnel rather than gretap tunnel

2016-05-06 Thread Jiri Benc
On Fri, 6 May 2016 15:54:02 +0900, Simon Horman wrote: > -int ovs_netdev_send_raw_tun(struct sk_buff *skb) > -{ > - if (skb->mac_len) > - skb->protocol = ntohs(ETH_P_TEB); > + if (dev->type != ARPHRD_ETHER && skb->mac_len) { > + skb->protocol = htons(ETH_P_TEB); > +

Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching support

2016-05-06 Thread Wei-Ning Huang
On Fri, May 6, 2016 at 12:07 AM, Dan Williams wrote: > > On Thu, 2016-05-05 at 14:44 +0800, Wei-Ning Huang wrote: > > Recent new hardware has the ability to switch between tablet mode and > > clamshell mode. To optimize WiFi performance, we want to be able to > > use > >

Re: [PATCH net-next] vxlan: if_arp: introduce ARPHRD_VXLANGPE

2016-05-06 Thread Simon Horman
On Thu, May 05, 2016 at 04:56:43PM -0300, Thadeu Lima de Souza Cascardo wrote: > On Thu, May 05, 2016 at 09:31:41PM +0200, Jiri Benc wrote: > > On Thu, 5 May 2016 13:36:44 -0300, Thadeu Lima de Souza Cascardo wrote: > > > Use ARPHRD_VXLANGPE to identify VxLAN GPE interfaces. This is going to be

[GIT PULL nf-next 0/1] Second Round of IPVS Updates for v4.7

2016-05-06 Thread Simon Horman
Hi Pablo, please consider these enhancements to the IPVS. They allow its DoS mitigation strategy effective in conjunction with the SIP persistence engine. The following changes since commit cb39ad8b8ef224c544074962780bf763077d6141: netfilter: nf_tables: allow set names up to 32 bytes

[PATCH nf-next 1/1] ipvs: make drop_entry protection effective for SIP-pe

2016-05-06 Thread Simon Horman
From: Marco Angaroni DoS protection policy that deletes connections to avoid out of memory is currently not effective for SIP-pe plus OPS-mode for two reasons: 1) connection templates (holding SIP call-id) are always skipped in ip_vs_random_dropentry() 2)

[net-next 05/11] i40evf: Drop packet split receive routine

2016-05-06 Thread Jeff Kirsher
From: Jesse Brandeburg As part of preparation for the rx-refactor, remove the packet split receive routine and ancillary code. Some of the split related context set up code stays in i40e_virtchnl_pf.c in case an older VF driver tries to load and still wants to use

[net-next 06/11] i40evf: refactor receive routine

2016-05-06 Thread Jeff Kirsher
From: Jesse Brandeburg This is part 2 of the Rx refactor series, just including changes to i40evf. This refactor aligns the receive routine with the one in ixgbe which was highly optimized. This reduces the code we have to maintain and allows for (hopefully) more

[net-next 08/11] i40evf: Allocate Rx buffers properly

2016-05-06 Thread Jeff Kirsher
From: Mitch Williams Allocate the correct number of RX buffers, and don't fiddle with next_to_use. The common RX code handles all of this. This fixes a memory leak of one page each time the driver is opened. Change-Id: Id06eca353086e084921f047acad28c14745684ee

[net-next 07/11] i40e/i40evf: Remove unused hardware receive descriptor code

2016-05-06 Thread Jeff Kirsher
From: Jesse Brandeburg The hardware supports a 16 byte descriptor for receive, but the driver was never using it in production. There was no performance benefit to the real driver of 16 byte descriptors, so drop a whole lot of complexity while getting rid of the

[net-next 02/11] i40e: Drop packet split receive routine

2016-05-06 Thread Jeff Kirsher
From: Jesse Brandeburg As part of preparation for the rx-refactor, remove the packet split receive routine and ancillary code. Signed-off-by: Jesse Brandeburg Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

[net-next 09/11] i40e: Test memory before ethtool alloc succeeds

2016-05-06 Thread Jeff Kirsher
From: Jesse Brandeburg When testing on systems with very limited amounts of RAM, a bug was found where, while changing the number of descriptors using ethtool, the driver didn't test the limits of system memory before permanently assuming it would be able to get

[net-next 04/11] i40e: Refactor receive routine

2016-05-06 Thread Jeff Kirsher
From: Jesse Brandeburg This is part 1 of the Rx refactor series, just including changes to i40e. This refactor aligns the receive routine with the one in ixgbe which was highly optimized. This reduces the code we have to maintain and allows for (hopefully) more

[net-next 01/11] i40e/i40evf: Refactor tunnel interpretation

2016-05-06 Thread Jeff Kirsher
From: Jesse Brandeburg Refactor the interpretation of a tunnel. This removes some code and lets us start using the hardware's parsing. Signed-off-by: Jesse Brandeburg Tested-by: Andrew Bowers Signed-off-by:

[net-next 00/11][pull request] 40GbE Intel Wired LAN Driver Updates 2016-05-05

2016-05-06 Thread Jeff Kirsher
This series contains updates to i40e and i40evf. The theme behind this series is code reduction, yeah! Jesse provides most of the changes starting with a refactor of the interpretation of a tunnel which lets us start using the hardware's parsing. Removed the packet split receive routine and

<    1   2   3   >