Re: [PATCH net-next] fq_codel: add memory limitation per queue

2016-05-08 Thread Cong Wang
On Sun, May 8, 2016 at 9:31 PM, Eric Dumazet wrote: > On Sun, 2016-05-08 at 21:14 -0700, Cong Wang wrote: > >> So when the packet is dropped due to memory over limit, should >> we return failure for this case? Or I miss anything? > > Same behavior than before. > > If we

Re: [PATCH iproute2 net-next] ifstat: move to new RTM_GETSTATS api

2016-05-08 Thread Roopa Prabhu
On 4/30/16, 8:15 AM, Roopa Prabhu wrote: > On 4/30/16, 3:21 AM, Jamal Hadi Salim wrote: >> On 16-04-30 02:41 AM, Roopa Prabhu wrote: >>> From: Roopa Prabhu >>> >>> This patch modifies ifstat to use the new RTM_GETSTATS api >>> to query stats from the kernel. In the

[GIT] Networking

2016-05-08 Thread David Miller
1) Check klogctl failure correctly, from Colin Ian King. 2) Prevent OOM when under memory pressure in flowcache, from Steffen Klassert. 3) Fix info leak in llc and rtnetlink ifmap code, from Kangjie Lu. 4) Memory barrier and multicast handling fixes in bnxt_en, from Michael Chan. 5)

Re: [net-next PATCH v2 0/6] net sched: Fix broken late binding of actions

2016-05-08 Thread David Miller
From: Jamal Hadi Salim Date: Sun, 8 May 2016 13:29:05 -0400 > On 16-05-08 01:26 PM, Jamal Hadi Salim wrote: >> From: Jamal Hadi Salim >> >> Some actions were broken in allowing for late binding of actions. > > Dave, these deserve to go into -stable as

Re: [net-next PATCH 1/1] export tc ife uapi header

2016-05-08 Thread David Miller
From: Jamal Hadi Salim Date: Sat, 7 May 2016 09:19:59 -0400 > From: Jamal Hadi Salim > > Signed-off-by: Jamal Hadi Salim Again, this looks like a bug fix appropriate for 'net' not 'net-next'.

Re: [PATCH net-next] fq_codel: add memory limitation per queue

2016-05-08 Thread Eric Dumazet
On Sun, 2016-05-08 at 21:14 -0700, Cong Wang wrote: > So when the packet is dropped due to memory over limit, should > we return failure for this case? Or I miss anything? Same behavior than before. If we dropped some packets of this flow, we return NET_XMIT_CN

Re: [PATCH 2/2] net: Use ns_capable_noaudit() when determining net sysctl permissions

2016-05-08 Thread Serge Hallyn
Quoting Tyler Hicks (tyhi...@canonical.com): > The capability check should not be audited since it is only being used > to determine the inode permissions. A failed check does not indicate a > violation of security policy but, when an LSM is enabled, a denial audit > message was being generated. >

Re: [PATCH 1/2] kernel: Add noaudit variant of ns_capable()

2016-05-08 Thread Serge Hallyn
Quoting Tyler Hicks (tyhi...@canonical.com): > When checking the current cred for a capability in a specific user > namespace, it isn't always desirable to have the LSMs audit the check. > This patch adds a noaudit variant of ns_capable() for when those > situations arise. > > The common logic

Re: [PATCH net 0/2] net/mlx5e: Kconfig fixes for VxLAN

2016-05-08 Thread David Miller
From: Saeed Mahameed Date: Sun, 8 May 2016 14:55:23 +0300 > Reposting to net the build errors fixes posted by Arnd last week. > > Originally Arnd posted those fixes to net-next, while the issue > is also seen in net. For net-next a different approach is required > for

Re: [PATCH 0/2] sh_eth: couple of software reset bit cleanups

2016-05-08 Thread David Miller
From: Sergei Shtylyov Date: Sun, 08 May 2016 00:06:53 +0300 >Here's a set of 2 patches against DaveM's 'net-next.git' repo. We can save > on the repetitive chip reset code... > > [1/2] sh_eth: call sh_eth_tsu_write() from sh_eth_chip_reset_giga() > [2/2]

Re: [PATCH net-next] fq_codel: add memory limitation per queue

2016-05-08 Thread Cong Wang
On Fri, May 6, 2016 at 8:55 AM, Eric Dumazet wrote: > @@ -193,6 +199,7 @@ static int fq_codel_enqueue(struct sk_buff *skb, struct > Qdisc *sch) > unsigned int idx, prev_backlog, prev_qlen; > struct fq_codel_flow *flow; > int uninitialized_var(ret);

Re: [PATCH] pxa168_eth: mdiobus_scan() doesn't return NULL anymore

2016-05-08 Thread David Miller
From: Sergei Shtylyov Date: Sat, 07 May 2016 22:53:40 +0300 > Now that mdiobus_scan() doesn't return NULL on failure anymore, this driver > no longer needs to check for it... > > Signed-off-by: Sergei Shtylyov Applied.

Re: pull request: bluetooth-next 2016-05-07

2016-05-08 Thread David Miller
From: Johan Hedberg Date: Sat, 7 May 2016 21:56:23 +0300 > Here are a few more Bluetooth patches for the 4.7 kernel: > > - NULL pointer fix in hci_intel driver > - New Intel Bluetooth controller id in btusb driver > - Added device tree binding documentation for

Re: [PATCH net] macsec: key identifier is 128 bits, not 64

2016-05-08 Thread David Miller
From: Sabrina Dubroca Date: Sat, 7 May 2016 20:19:29 +0200 > The MACsec standard mentions a key identifier for each key, but > doesn't specify anything about it, so I arbitrarily chose 64 bits. > > IEEE 802.1X-2010 specifies MKA (MACsec Key Agreement), and defines the >

Re: [PATCH net-next] tcp: refactor struct tcp_skb_cb

2016-05-08 Thread David Miller
From: Lawrence Brakmo Date: Fri, 6 May 2016 20:35:35 -0700 > Refactor tcp_skb_cb to create two overlaping areas to store > state for incoming or outgoing skbs based on comments by > Neal Cardwell to tcp_nv patch: > >AFAICT this patch would not require an increase in the size

Re: [PATCH net-next] tcp: replace cnt & rtt with struct in pkts_acked()

2016-05-08 Thread David Miller
From: Lawrence Brakmo Date: Fri, 6 May 2016 20:28:34 -0700 > + if (icsk->icsk_ca_ops->pkts_acked) { > + struct ack_sample sample = {pkts_acked, ca_rtt_us}; Please use named initializers. Thanks.

Re: [PATCH v2 net-next] ifb: support more features

2016-05-08 Thread David Miller
From: Eric Dumazet Date: Fri, 06 May 2016 18:19:59 -0700 > From: Eric Dumazet > > When using ifb+netem on ingress on SIT/IPIP/GRE traffic, > GRO packets are not properly processed. > > Segmentation should not be forced, since ifb is already adding

Re: [PATCH] tools: bpf_jit_disasm: check for klogctl failure

2016-05-08 Thread David Miller
From: Daniel Borkmann Date: Fri, 06 May 2016 00:46:56 +0200 > On 05/06/2016 12:39 AM, Colin King wrote: >> From: Colin Ian King >> >> klogctl can fail and return -ve len, so check for this and >> return NULL to avoid passing a (size_t)-1 to

Re: [PATCH net-next] fq_codel: add memory limitation per queue

2016-05-08 Thread David Miller
From: Eric Dumazet Date: Fri, 06 May 2016 08:55:12 -0700 > From: Eric Dumazet > > On small embedded routers, one wants to control maximal amount of > memory used by fq_codel, instead of controlling number of packets or > bytes, since GRO/TSO make

Re: [PATCH 0/2] Quiet noisy LSM denial when accessing net sysctl

2016-05-08 Thread David Miller
From: Tyler Hicks Date: Fri, 6 May 2016 18:04:12 -0500 > This pair of patches does away with what I believe is a useless denial > audit message when a privileged process initially accesses a net sysctl. The LSM folks can apply this if they agree with you.

Re: [PATCH v1 1/1] ISDN: eicon: replace custom hex_asc_lo() / hex_pack_byte()

2016-05-08 Thread David Miller
From: Andy Shevchenko Date: Fri, 6 May 2016 20:55:23 +0300 > Instead of custom approach re-use generic helpers to convert byte to hex > format. > > Signed-off-by: Andy Shevchenko Applied.

Re: [PATCH v2] Documentation/networking: more accurate LCO explanation

2016-05-08 Thread David Miller
From: Shmulik Ladkani Date: Fri, 6 May 2016 20:27:43 +0300 > In few places the term "ones-complement sum" was used but the actual > meaning is "the complement of the ones-complement sum". > > Also, avoid enclosing long statements with underscore, to ease >

Re: [PATCH net-next] net: make sch_handle_ingress() drop monitor ready

2016-05-08 Thread David Miller
From: Eric Dumazet Date: Fri, 06 May 2016 15:55:50 -0700 > From: Eric Dumazet > > TC_ACT_STOLEN is used when ingress traffic is mirred/redirected > to say ifb. > > Packet is not dropped, but consumed. > > Only TC_ACT_SHOT is a clear indication

Re: [PATCH v2] net: arc/emac: Move arc_emac_tx_clean() into arc_emac_tx() and disable tx interrut

2016-05-08 Thread David Miller
From: Caesar Wang Date: Fri, 6 May 2016 20:19:16 +0800 > Doing tx_clean() inside poll() may scramble the tx ring buffer if > tx() is running. This will cause tx to stop working, which can be > reproduced by simultaneously downloading two large files at high speed. > >

Re: [PATCH v4 1/2] soc: qcom: smd: Introduce compile stubs

2016-05-08 Thread David Miller
From: Bjorn Andersson Date: Fri, 6 May 2016 07:09:07 -0700 > Introduce compile stubs for the SMD API, allowing consumers to be > compile tested. > > Acked-by: Andy Gross > Signed-off-by: Bjorn Andersson Applied.

Re: [PATCH v4 2/2] net: Add Qualcomm IPC router

2016-05-08 Thread David Miller
From: Bjorn Andersson Date: Fri, 6 May 2016 07:09:08 -0700 > From: Courtney Cavin > > Add an implementation of Qualcomm's IPC router protocol, used to > communicate with service providing remote processors. > > Signed-off-by:

Re: [PATCH net] macvtap: segmented packet is consumed

2016-05-08 Thread David Miller
From: Eric Dumazet Date: Fri, 06 May 2016 05:58:21 -0700 > From: Eric Dumazet > > If GSO packet is segmented and its segments are properly queued, > we call consume_skb() instead of kfree_skb() to be drop monitor > friendly. > > Fixes:

Re: [net-next PATCH v2 6/6] net sched: ife action fix late binding

2016-05-08 Thread Cong Wang
On Sun, May 8, 2016 at 10:26 AM, Jamal Hadi Salim wrote: > @@ -689,7 +695,7 @@ static int tcf_ife_encode(struct sk_buff *skb, const > struct tc_action *a, > /* >OUTERHDR:TOTMETALEN:{TLVHDR:Metadatum:TLVHDR..}:ORIGDATA >where ORIGDATA = original

Re: [patch] qede: uninitialized variable in qede_start_xmit()

2016-05-08 Thread David Miller
From: Dan Carpenter Date: Thu, 5 May 2016 16:21:30 +0300 > "data_split" was never set to false. It's just uninitialized. > > Fixes: 2950219d87b0 ('qede: Add basic network device support') > Signed-off-by: Dan Carpenter Applied, thanks Dan.

Re: [net-next PATCH v2 5/6] net sched: skbedit action fix late binding

2016-05-08 Thread Cong Wang
On Sun, May 8, 2016 at 10:26 AM, Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > The process below was broken and is fixed with this patch. > > //add a skbedit action and give it an instance id of 1 > sudo tc actions add action skbedit mark 10 index 1 >

Re: [net-next PATCH v2 3/6] net sched: mirred action fix late binding

2016-05-08 Thread Cong Wang
On Sun, May 8, 2016 at 10:26 AM, Jamal Hadi Salim wrote: > -static int tcf_mirred_dump(struct sk_buff *skb, struct tc_action *a, int > bind, int ref) > +static int tcf_mirred_dump(struct sk_buff *skb, struct tc_action *a, int > bind, > + int ref) > {

Re: [net-next PATCH v2 1/6] net sched: vlan action fix late binding

2016-05-08 Thread Cong Wang
On Sun, May 8, 2016 at 10:26 AM, Jamal Hadi Salim wrote: > diff --git a/net/sched/act_vlan.c b/net/sched/act_vlan.c > index c1682ab..352653f 100644 > --- a/net/sched/act_vlan.c > +++ b/net/sched/act_vlan.c > @@ -77,7 +77,7 @@ static int tcf_vlan_init(struct net *net, struct

RE: [PATCH net 1/1] net: fec: update dirty_tx even if no skb

2016-05-08 Thread Fugang Duan
From: Troy Kisky Sent: Friday, April 22, 2016 10:01 AM > To: netdev@vger.kernel.org; da...@davemloft.net; Fugang Duan > ; lzn...@gmail.com > Cc: Fabio Estevam ; l.st...@pengutronix.de; > and...@lunn.ch;

RE: [PATCH net 1/1] net: fec: update dirty_tx even if no skb

2016-05-08 Thread Fugang Duan
From: Troy Kisky Sent: Sunday, May 08, 2016 2:57 AM > To: Fugang Duan ; netdev@vger.kernel.org; > da...@davemloft.net; lzn...@gmail.com > Cc: Fabio Estevam ; l.st...@pengutronix.de; > and...@lunn.ch; trem...@gmail.com;

RE: [PATCH v2 0/3] net: ethtool: add ethtool_op_{get|set}_link_ksettings

2016-05-08 Thread Fugang Duan
Fom: Philippe Reynes Sent: Monday, May 09, 2016 5:45 AM > To: Fugang Duan ; da...@davemloft.net; > b...@decadent.org.uk; kan.li...@intel.com; de...@googlers.com; > adu...@mirantis.com; j...@mellanox.com; jacob.e.kel...@intel.com; > t...@herbertland.com;

networking/ip-sysctl.txt: SRR or SSRR

2016-05-08 Thread Christian Kujau
In Documentation/networking/ip-sysctl.txt, the accept_source_route parameter is described with: Accept packets with SRR option. I could not find anything describing an "SRR option". The closest thing was something called "SSR - Strict Source Route"[0] - is that what is meant here? If so,

linux-next: manual merge of the net-next tree with the net tree

2016-05-08 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: include/linux/netdevice.h between commit: 229740c63169 ("udp_offload: Set encapsulation before inner completes.") from the net tree and commit: 46aa2f30aa7f ("udp: Remove udp_offloads") from the net-next tree. I

linux-next: manual merge of the net-next tree with the wireless-drivers tree

2016-05-08 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/wireless/intel/iwlwifi/mvm/tx.c between commit: 5c08b0f5026f ("iwlwifi: mvm: don't override the rate with the AMSDU len") from the wireless-drivers tree and commit: d8fe484470dd ("iwlwifi: mvm: add

Re: [PATCH net-next 5/7] Driver: Vmxnet3: Add support for get_coalesce, set_coalesce ethtool operations

2016-05-08 Thread Ben Hutchings
On Sun, 2016-05-08 at 13:55 -0700, Shrikrishna Khare wrote: > > On Sat, 7 May 2016, Ben Hutchings wrote: > > > On Fri, 2016-05-06 at 16:12 -0700, Shrikrishna Khare wrote: > > [...] > > > +static int > > > +vmxnet3_set_coalesce(struct net_device *netdev, struct ethtool_coalesce > > > *ec) > > >

Re: [PATCH v2 2/3] net: ethernet: fec: use phydev from struct net_device

2016-05-08 Thread Ben Hutchings
On Mon, 2016-05-09 at 00:47 +0200, Philippe Reynes wrote: > On 09/05/16 00:22, Ben Hutchings wrote: > > > > On Sun, 2016-05-08 at 23:44 +0200, Philippe Reynes wrote: > > > > > > The private structure contain a pointer to phydev, but the structure > > > net_device already contain such pointer. So

[PATCH nf-next,v2] gtp: add initial driver for datapath of GPRS Tunneling Protocol (GTP-U)

2016-05-08 Thread Pablo Neira Ayuso
This is an initial implementation of a netdev driver for GTP datapath (GTP-U) v0 and v1, according to the GSM TS 09.60 and 3GPP TS 29.060 standards. This tunneling protocol is used to prevent subscribers from accessing mobile carrier core network infrastructure. This implementation requires a

Re: [PATCH v2 2/3] net: ethernet: fec: use phydev from struct net_device

2016-05-08 Thread Philippe Reynes
On 09/05/16 00:22, Ben Hutchings wrote: On Sun, 2016-05-08 at 23:44 +0200, Philippe Reynes wrote: The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phydev in the private structure, and update the driver to

[PATCH 1/1] net: thunderx: avoid exposing kernel stack

2016-05-08 Thread Heinrich Schuchardt
Reserved fields should be set to zero to avoid exposing bits from the kernel stack. Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH v2 2/3] net: ethernet: fec: use phydev from struct net_device

2016-05-08 Thread Ben Hutchings
On Sun, 2016-05-08 at 23:44 +0200, Philippe Reynes wrote: > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the one > contained in struct

Re: [GIT PULL nf-next 0/1] Second Round of IPVS Updates for v4.7

2016-05-08 Thread Pablo Neira Ayuso
On Fri, May 06, 2016 at 04:32:38PM +0900, Simon Horman wrote: > Hi Pablo, > > please consider these enhancements to the IPVS. They allow its > DoS mitigation strategy effective in conjunction with the SIP persistence > engine. > > The following changes since commit

[PATCH net-next] gtp: add initial driver for datapath of GPRS Tunneling Protocol (GTP-U)

2016-05-08 Thread Pablo Neira Ayuso
This is an initial implementation of a netdev driver for GTP datapath (GTP-U) v0 and v1, according to the GSM TS 09.60 and 3GPP TS 29.060 standards. This tunneling protocol is used to prevent subscribers from accessing mobile carrier core network infrastructure. This implementation requires a

[PATCH v2 1/3] net: core: ethtool: add ethtool_op_{get|set}_link_ksettings

2016-05-08 Thread Philippe Reynes
Ethtool callbacks {get|set}_link_ksettings are often the same, so we add two generics functions ethtool_op_{get|set}_link_ksettings to avoid writing severals times the same function. Signed-off-by: Philippe Reynes --- include/linux/ethtool.h |5 + net/core/ethtool.c

[PATCH v2 2/3] net: ethernet: fec: use phydev from struct net_device

2016-05-08 Thread Philippe Reynes
The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phydev in the private structure, and update the driver to use the one contained in struct net_device. Signed-off-by: Philippe Reynes ---

[PATCH v2 0/3] net: ethtool: add ethtool_op_{get|set}_link_ksettings

2016-05-08 Thread Philippe Reynes
Ethtool callbacks {get|set}_link_ksettings may be the same for many drivers. So we add two generics callbacks ethtool_op_{get|set}_link_ksettings. To use those generics callbacks, the ethernet driver must use the pointer phydev contained in struct net_device, and not use a private structure to

[PATCH v2 3/3] net: ethernet: fec: use ethtool_op_{get|set}_link_ksettings

2016-05-08 Thread Philippe Reynes
There are two generics functions ethtool_op_{get|set}_link_ksettings, so we can use them instead of defining the same code in the driver. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/freescale/fec_main.c | 26 ++ 1 files changed, 2

Re: [PATCH net-next 5/7] Driver: Vmxnet3: Add support for get_coalesce, set_coalesce ethtool operations

2016-05-08 Thread Shrikrishna Khare
On Sat, 7 May 2016, Ben Hutchings wrote: > On Fri, 2016-05-06 at 16:12 -0700, Shrikrishna Khare wrote: > [...] > > +static int > > +vmxnet3_set_coalesce(struct net_device *netdev, struct ethtool_coalesce > > *ec) > > +{ > [...] > > + switch (ec->rx_coalesce_usecs) { > > + case

Re: [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings

2016-05-08 Thread Florian Fainelli
On May 7, 2016 3:56:34 PM PDT, Philippe Reynes wrote: >On 07/05/16 13:59, Ben Hutchings wrote: >> On Sat, 2016-05-07 at 01:18 +0200, Philippe Reynes wrote: >>> The callback {get|set}_link_ksettings are often defined >>> in a very close way. There are mainly two differences in

Re: [PATCH v9 net-next 1/2] hv_sock: introduce Hyper-V Sockets

2016-05-08 Thread David Miller
From: Dexuan Cui Date: Sun, 8 May 2016 06:11:04 + > Thanks for pointing this out! > I understand, so I think I should add a module parameter, e.g., > "hv_sock.max_socket_number" with a default value, say, 1024? No, you should get rid of the huge multi-page buffers.

Re: [PATCH v2 net-next] ifb: support more features

2016-05-08 Thread Eric Dumazet
On Sun, 2016-05-08 at 09:08 -0700, Eric Dumazet wrote: > So we probably need to make sure the network header is properly set for > the segments. Then skb_reset_mac_len(nskb); would work as intended. > > Since skb_segment() is called from the deepest point in GSO path, > it always see the inner

Re: [net-next PATCH v2 0/6] net sched: Fix broken late binding of actions

2016-05-08 Thread Jamal Hadi Salim
On 16-05-08 01:26 PM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim Some actions were broken in allowing for late binding of actions. Dave, these deserve to go into -stable as well. cheers, jamal

[net-next PATCH v2 2/6] net sched: ipt action fix late binding

2016-05-08 Thread Jamal Hadi Salim
From: Jamal Hadi Salim This was broken and is fixed with this patch. //add an ipt action and give it an instance id of 1 sudo tc actions add action ipt -j mark --set-mark 2 index 1 //create a filter which binds to ipt action id 1 sudo tc filter add dev $DEV parent :

[net-next PATCH v2 3/6] net sched: mirred action fix late binding

2016-05-08 Thread Jamal Hadi Salim
From: Jamal Hadi Salim The process below was broken and is fixed with this patch. //add an mirred action and give it an instance id of 1 sudo tc actions add action mirred egress mirror dev $MDEV index 1 //create a filter which binds to mirred action id 1 sudo tc filter add

[net-next PATCH v2 4/6] net sched: simple action fix late binding

2016-05-08 Thread Jamal Hadi Salim
From: Jamal Hadi Salim The process below was broken and is fixed with this patch. //add a simple action and give it an instance id of 1 sudo tc actions add action simple sdata "foobar" index 1 //create a filter which binds to simple action id 1 sudo tc filter add dev $DEV

[net-next PATCH v2 6/6] net sched: ife action fix late binding

2016-05-08 Thread Jamal Hadi Salim
From: Jamal Hadi Salim The process below was broken and is fixed with this patch. //add an ife action and give it an instance id of 1 sudo tc actions add action ife encode \ type 0xDEAD allow mark dst 02:15:15:15:15:15 index 1 //create a filter which binds to skbedit action

[net-next PATCH v2 5/6] net sched: skbedit action fix late binding

2016-05-08 Thread Jamal Hadi Salim
From: Jamal Hadi Salim The process below was broken and is fixed with this patch. //add a skbedit action and give it an instance id of 1 sudo tc actions add action skbedit mark 10 index 1 //create a filter which binds to skbedit action id 1 sudo tc filter add dev $DEV parent

[net-next PATCH v2 1/6] net sched: vlan action fix late binding

2016-05-08 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Late binding was broken and is fixed with this patch. //add a vlan action to pop and give it an instance id of 1 sudo tc actions add action vlan pop index 1 //create filter which binds to vlan action id 1 sudo tc filter add dev $DEV parent :

[net-next PATCH v2 0/6] net sched: Fix broken late binding of actions

2016-05-08 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Some actions were broken in allowing for late binding of actions. Late binding workflow is as follows: a) create an action and provide all necessary parameters for it Optionally provide an index or let the kernel give you one. Example: sudo tc actions

Re: [net-next PATCH 0/6] Fix broken late binding of actions

2016-05-08 Thread Jamal Hadi Salim
On 16-05-08 01:16 PM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim Some actions were broken in allowing for late binding of actions. Late binding workflow is as follows: a) create an action and provide all necessary parameters for it Optionally provide an index or let the

[net-next PATCH 6/6] tc ife action fix late binding

2016-05-08 Thread Jamal Hadi Salim
From: Jamal Hadi Salim The process below was broken and is fixed with this patch. //add an ife action and give it an instance id of 1 sudo tc actions add action ife encode \ type 0xDEAD allow mark dst 02:15:15:15:15:15 index 1 //create a filter which binds to skbedit action

[net-next PATCH 2/6] tc ipt action fix late binding

2016-05-08 Thread Jamal Hadi Salim
From: Jamal Hadi Salim This was broken and is fixed with this patch. //add an ipt action and give it an instance id of 1 sudo tc actions add action ipt -j mark --set-mark 2 index 1 //create a filter which binds to ipt action id 1 sudo tc filter add dev $DEV parent :

[net-next PATCH 5/6] tc skbedit action fix late binding

2016-05-08 Thread Jamal Hadi Salim
From: Jamal Hadi Salim The process below was broken and is fixed with this patch. //add a skbedit action and give it an instance id of 1 sudo tc actions add action skbedit mark 10 index 1 //create a filter which binds to skbedit action id 1 sudo tc filter add dev $DEV parent

[net-next PATCH 4/6] tc simple action fix late binding

2016-05-08 Thread Jamal Hadi Salim
From: Jamal Hadi Salim The process below was broken and is fixed with this patch. //add a simple action and give it an instance id of 1 sudo tc actions add action simple sdata "foobar" index 1 //create a filter which binds to simple action id 1 sudo tc filter add dev $DEV

[net-next PATCH 3/6] tc mirred action fix late binding

2016-05-08 Thread Jamal Hadi Salim
From: Jamal Hadi Salim The process below was broken and is fixed with this patch. //add an mirred action and give it an instance id of 1 sudo tc actions add action mirred egress mirror dev $MDEV index 1 //create a filter which binds to mirred action id 1 sudo tc filter add

[net-next PATCH 1/6] tc vlan action fix late binding

2016-05-08 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Late binding was broken and is fixed with this patch. //add a vlan action to pop and give it an instance id of 1 sudo tc actions add action vlan pop index 1 //create filter which binds to vlan action id 1 sudo tc filter add dev $DEV parent :

[net-next PATCH 0/6] Fix broken late binding of actions

2016-05-08 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Some actions were broken in allowing for late binding of actions. Late binding workflow is as follows: a) create an action and provide all necessary parameters for it Optionally provide an index or let the kernel give you one. Example: sudo tc actions

Re: [PATCH v2 net-next] ifb: support more features

2016-05-08 Thread Eric Dumazet
On Sat, 2016-05-07 at 22:41 -0700, Eric Dumazet wrote: > On Fri, 2016-05-06 at 18:19 -0700, Eric Dumazet wrote: > > From: Eric Dumazet > > > > When using ifb+netem on ingress on SIT/IPIP/GRE traffic, > > GRO packets are not properly processed. > > > > Segmentation should

[PATCH] fix a kernel infoleak in x25 module

2016-05-08 Thread Kangjie Lu
Stack object "dte_facilities" is allocated in x25_rx_call_request(), which is supposed to be initialized in x25_negotiate_facilities. However, 5 fields (8 bytes in total) are not initialized. This object is then copied to userland via copy_to_user, thus infoleak occurs. Signed-off-by: Kangjie Lu

[iproute2 PATCH 1/1] tc fix ife late binding

2016-05-08 Thread Jamal Hadi Salim
From: Jamal Hadi Salim following late action binding didn't work: sudo tc actions add action ife encode \ type 0xDEAD allow mark dst 02:15:15:15:15:15 index 1 sudo tc filter add dev lo parent : protocol ip prio 2 u32\ match ip src 127.0.0.2/32 flowid 1:2 action ife index

[iproute2 PATCH v2 1/1] tc simple action update and breakage

2016-05-08 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Brings it closer to more serious actions (adding branching and allowing for late binding) Unfortunately this breaks old syntax of the simple action. But because simple is a pedagogical example unlikely to be used in production environments (i.e its role

Re: [iproute2 PATCH 1/1] tc simple action update and breakage

2016-05-08 Thread Jamal Hadi Salim
On 16-05-08 10:44 AM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim Brings it closer to more serious actions (adding branching and allowing for late binding) Unfortunately this breaks old syntax of the simple action. But because simple is a pedagogical example unlikely to

[iproute2 PATCH 1/1] tc simple action update and breakage

2016-05-08 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Brings it closer to more serious actions (adding branching and allowing for late binding) Unfortunately this breaks old syntax of the simple action. But because simple is a pedagogical example unlikely to be used in production environments (i.e its role

RE: [PATCH v2 1/2] net: nps_enet: Sync access to packet sent flag

2016-05-08 Thread Elad Kanfi
Hi Lino, > Please see sections "SMP BARRIER PAIRING" and "EXAMPLES OF MEMORY BARRIER > SEQUENCES" in > memory-barriers.txt for a description why smp barriers have to be paired and > a smp write barrier on CPU A without a read barrier on CPU B is _not_ > sufficient. > > Furthermore after having

Re: [PATCH 2/3] net/mlx5e: make VXLAN support conditional

2016-05-08 Thread Saeed Mahameed
On Fri, May 6, 2016 at 10:35 PM, David Miller wrote: > From: Arnd Bergmann > Date: Thu, 05 May 2016 20:09:19 +0200 > >> For reference, I've tried it out on the MLX4 driver, and it does >> seem nicer that way, see below. > > Is it possible to wind down this

[PATCH net 0/2] net/mlx5e: Kconfig fixes for VxLAN

2016-05-08 Thread Saeed Mahameed
Reposting to net the build errors fixes posted by Arnd last week. Originally Arnd posted those fixes to net-next, while the issue is also seen in net. For net-next a different approach is required for fixing the issue as VXLAN and Device Drivers are no longer dependent, but there is no harm for

[PATCH net 1/2] Revert "net/mlx5: Kconfig: Fix MLX5_EN/VXLAN build issue"

2016-05-08 Thread Saeed Mahameed
From: Arnd Bergmann This reverts commit 69976fb1045850a742deb9790ea49cbc6f497531. We cannot select VXLAN when IPv4 support is disabled, that just gives us additional build errors, including: warning: (MLX5_CORE_EN) selects VXLAN which has unmet direct dependencies (NETDEVICES

[PATCH net 2/2] net/mlx5e: make VXLAN support conditional

2016-05-08 Thread Saeed Mahameed
From: Arnd Bergmann VXLAN can be disabled at compile-time or it can be a loadable module while mlx5 is built-in, which leads to a link error: drivers/net/built-in.o: In function `mlx5e_create_netdev': ntb_netdev.c:(.text+0x106de4): undefined reference to `vxlan_get_rx_port' This

[PATCH net-next] stmmac: dwmac-socfpga: make socfpga_dwmac_pm_ops static

2016-05-08 Thread Joachim Eastwood
Fix the following sparse warning: drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:274:1: warning: symbol 'socfpga_dwmac_pm_ops' was not declared. Should it be static? Signed-off-by: Joachim Eastwood --- Hi, Noticed this sparse warning after my last batch of patches.

Re: [PATCHv2 bluetooth-next 08/10] ipv6: export ndisc functions

2016-05-08 Thread Alexander Aring
Hi, On 05/02/2016 09:39 PM, Hannes Frederic Sowa wrote: > On 20.04.2016 10:19, Alexander Aring wrote: >> This patch exports some neighbour discovery functions which can be used >> by 6lowpan neighbour discovery ops functionality then. >> >> Cc: David S. Miller >> Cc: Alexey

Re: [PATCHv2 bluetooth-next 04/10] ndisc: add addr_len parameter to ndisc_opt_addr_space

2016-05-08 Thread Alexander Aring
Hi, On 05/07/2016 12:23 AM, Hannes Frederic Sowa wrote: > On 04.05.2016 14:30, Alexander Aring wrote: >> Hi, >> >> On 05/02/2016 09:37 PM, Hannes Frederic Sowa wrote: >>> On 20.04.2016 10:19, Alexander Aring wrote: This patch makes the address length as argument for the

RE: [PATCH v9 net-next 1/2] hv_sock: introduce Hyper-V Sockets

2016-05-08 Thread Dexuan Cui
> From: David Miller [mailto:da...@davemloft.net] > Sent: Sunday, May 8, 2016 1:41 > To: Dexuan Cui > Cc: gre...@linuxfoundation.org; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com;