[PATCH net] tipc: fix potential null-ptr dereference bugs in netlink compat functions

Before calling the nla_parse_nested function, its third argument should be checked to make sure it is not null. This patch fixes several potential null pointer dereference vulnerabilities in the tipc netlink functions. Signed-off-by: Baozeng Ding ---

[PATCH net] tipc: fix potential null pointer dereference in some compat, functions

Before calling the nla_parse_nested function, make sure the pointer to the attribute is not null. This patch fixes several potential null pointer dereference vulnerabilities in the tipc netlink functions. Signed-off-by: Baozeng Ding --- net/tipc/netlink_compat.c | 111

Re: IPv6 extension header privileges

On 21.05.2016 19:46, Sowmini Varadhan wrote: > Tom Herbert wrote: > If you don't mind I'll change this to make specific options are > privileged and not all hbh and destopt. There is talk in IETF about > reinventing IP extensibility within UDP since the kernel APIs don't > allow

Re: [PATCH 0043/1529] Fix typo

I'm not applying a ton of patches that all have the same Subject line. How can anyone looking at the GIT shortlog figure out what might be different amongst any of these 1529 patches? You must prefix your Subject line with the subsystem or area that your patch is changing, followed by a colon

Re: [PATCH v2] ethernet:arc: Fix racing of TX ring buffer

On 21.05.2016 21:47, Francois Romieu wrote: > Shuyu Wei : > [...] >> diff --git a/drivers/net/ethernet/arc/emac_main.c >> b/drivers/net/ethernet/arc/emac_main.c >> index a3a9392..c2447b0 100644 >> --- a/drivers/net/ethernet/arc/emac_main.c >> +++

Re: [PATCH v2] ethernet:arc: Fix racing of TX ring buffer

On 21.05.2016 18:09, Shuyu Wei wrote: > Looks like I got it wrong in the first place. > > priv->tx_buff is not for the device, so there's no need to move it. > The race has been fixed by commit c278c253f3d9, I forgot to check > it out. That's my fault. > > I do find another problem. We need to

Re: Missing INET6_PROTO_FINAL in l2tp_ip6_protocol?

On Sat, 21 May 2016 17:55:59 +0200 Hannes Frederic Sowa wrote: > On 21.05.2016 14:50, Shmulik Ladkani wrote: > > Hi, > > > > inet6_protocol's INET6_PROTO_FINAL flag denotes handler is expected not > > to request resubmission for local delivery. > > > > For an

Re: [PATCH v2] ethernet:arc: Fix racing of TX ring buffer

Shuyu Wei : [...] > diff --git a/drivers/net/ethernet/arc/emac_main.c > b/drivers/net/ethernet/arc/emac_main.c > index a3a9392..c2447b0 100644 > --- a/drivers/net/ethernet/arc/emac_main.c > +++ b/drivers/net/ethernet/arc/emac_main.c > @@ -686,6 +686,9 @@ static int

Re: [PATCH net] uapi glibc compat: fix compilation when !__USE_MISC in glibc

On Thu, May 19, 2016 at 05:26:29PM +0200, Nicolas Dichtel wrote: > These structures are defined only if __USE_MISC is set in glibc net/if.h > headers, ie when _BSD_SOURCE or _SVID_SOURCE are defined. Also, reading /usr/include/features.h from Debian glibc 2.22-4: ... The `-ansi' switch to the

Re: IPv6 extension header privileges

Tom Herbert wrote: > >>> If you don't mind I'll change this to make specific options are > >>> privileged and not all hbh and destopt. There is talk in IETF about > >>> reinventing IP extensibility within UDP since the kernel APIs don't > >>> allow setting EH. I would like to avoid that :-) Do

Re: IPv6 extension header privileges

On 21.05.2016 18:00, Tom Herbert wrote: > On Sat, May 21, 2016 at 8:33 AM, Hannes Frederic Sowa > wrote: >> On 21.05.2016 17:19, Tom Herbert wrote: >>> On Sat, May 21, 2016 at 2:34 AM, Hannes Frederic Sowa >>> wrote: On Sat, May 21,

[PATCH] net/tipc: fix potential null pointer dereference in several tipc netlink compat functions

Before calling the nla_parse_nested funciton, its third argument should be checked to make sure it is not null. This patch fixes several potential null pointer dereference vulnerability in the tipc netlink functions. Signed-off-by: Baozeng Ding ---

Re: IPv6 extension header privileges

On 21.05.2016 18:00, Tom Herbert wrote: > On Sat, May 21, 2016 at 8:33 AM, Hannes Frederic Sowa > wrote: >> On 21.05.2016 17:19, Tom Herbert wrote: >>> On Sat, May 21, 2016 at 2:34 AM, Hannes Frederic Sowa >>> wrote: On Sat, May 21,

Re: [PATCH v2] ethernet:arc: Fix racing of TX ring buffer

Looks like I got it wrong in the first place. priv->tx_buff is not for the device, so there's no need to move it. The race has been fixed by commit c278c253f3d9, I forgot to check it out. That's my fault. I do find another problem. We need to use a barrier to make sure skb_tx_timestamp() is

Re: IPv6 extension header privileges

On Sat, May 21, 2016 at 8:33 AM, Hannes Frederic Sowa wrote: > On 21.05.2016 17:19, Tom Herbert wrote: >> On Sat, May 21, 2016 at 2:34 AM, Hannes Frederic Sowa >> wrote: >>> On Sat, May 21, 2016, at 03:56, Sowmini Varadhan wrote: On

Re: Missing INET6_PROTO_FINAL in l2tp_ip6_protocol?

On 21.05.2016 14:50, Shmulik Ladkani wrote: > Hi, > > inet6_protocol's INET6_PROTO_FINAL flag denotes handler is expected not > to request resubmission for local delivery. > > For an INET6_PROTO_FINAL handler, the following actions gets executed > prior delivery, in ip6_input_finish: > >

Re: 4.5.0 on sun7i-a20-olinuxino-lime2: libphy: PHY stmmac-0:ffffffff not found (regression from rc7)

Hi, On 2016-05-20 12:36, Marc Zyngier wrote: On 20/05/16 11:30, Andre Heider wrote: Hi, On Fri, May 20, 2016 at 10:14 AM, Giuseppe CAVALLARO wrote: On 5/20/2016 9:56 AM, Marc Zyngier wrote: On 20/05/16 06:44, Andre Heider wrote: Giuseppe, Alexandre, et al., On

Re: IPv6 extension header privileges

On 21.05.2016 17:19, Tom Herbert wrote: > On Sat, May 21, 2016 at 2:34 AM, Hannes Frederic Sowa > wrote: >> On Sat, May 21, 2016, at 03:56, Sowmini Varadhan wrote: >>> On (05/21/16 02:20), Hannes Frederic Sowa wrote: There are some options inherently protocol

Re: IPv6 extension header privileges

On Sat, May 21, 2016 at 2:34 AM, Hannes Frederic Sowa wrote: > On Sat, May 21, 2016, at 03:56, Sowmini Varadhan wrote: >> On (05/21/16 02:20), Hannes Frederic Sowa wrote: >> > >> > There are some options inherently protocol depending like the jumbo >> > payload option,

Re: [PATCH 0043/1529] Fix typo

On Sat, May 21, 2016 at 01:41:21PM +0200, Andrea Gelmini wrote: > Signed-off-by: Andrea Gelmini > --- > Documentation/isdn/HiSax.cert | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/isdn/HiSax.cert b/Documentation/isdn/HiSax.cert

Re: [PATCH v2] ethernet:arc: Fix racing of TX ring buffer

On Thu, May 19, 2016 at 11:15:56PM +0200, Lino Sanfilippo wrote: > drivers/net/ethernet/arc/emac_main.c | 33 + > 1 file changed, 17 insertions(+), 16 deletions(-) > > diff --git a/drivers/net/ethernet/arc/emac_main.c > b/drivers/net/ethernet/arc/emac_main.c >

Missing INET6_PROTO_FINAL in l2tp_ip6_protocol?

Hi, inet6_protocol's INET6_PROTO_FINAL flag denotes handler is expected not to request resubmission for local delivery. For an INET6_PROTO_FINAL handler, the following actions gets executed prior delivery, in ip6_input_finish: nf_reset(skb);

[PATCH 0051/1529] Fix typo

Signed-off-by: Andrea Gelmini --- Documentation/networking/vortex.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/networking/vortex.txt b/Documentation/networking/vortex.txt index 97282da..40f1ab2 100644 ---

[PATCH 0043/1529] Fix typo

Signed-off-by: Andrea Gelmini --- Documentation/isdn/HiSax.cert | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/isdn/HiSax.cert b/Documentation/isdn/HiSax.cert index f2a6fcb..1483cd9d 100644 --- a/Documentation/isdn/HiSax.cert +++

[PATCH v2 2/2] ip6_gre: Set flowi6_proto as IPPROTO_GRE in xmit path.

In gre6 xmit path, we are sending a GRE packet, so set fl6 proto to IPPROTO_GRE properly. Signed-off-by: Haishuang Yan --- Changes in v2: - Initialize the flow protocol in ip6gre_tnl_link_config --- net/ipv6/ip6_gre.c | 1 + 1 file changed, 1 insertion(+)

[PATCH v2 1/2] ip6_gre: Fix MTU setting for ip6gretap

When creat an ip6gretap interface with an unreachable route, the MTU is about 14 bytes larger than what was needed. If the remote address is reachable: ping6 2001:0:130::1 -c 2 PING 2001:0:130::1(2001:0:130::1) 56 data bytes 64 bytes from 2001:0:130::1: icmp_seq=1 ttl=64 time=1.46 ms 64 bytes

Re: IPv6 extension header privileges

On (05/21/16 11:34), Hannes Frederic Sowa wrote: > > My wording directly from the RFC was too strong, true, but given that > there is a CALIPSO patch already floating around for the kernel and > those options are strictly controlled by selinux policy and build the > foundation for the networking

Re: IPv6 extension header privileges

On Sat, May 21, 2016, at 03:56, Sowmini Varadhan wrote: > On (05/21/16 02:20), Hannes Frederic Sowa wrote: > > > > There are some options inherently protocol depending like the jumbo > > payload option, which should be under control of the kernel, or the > > router alert option for igmp, which