Re: [net-next:master 17/24] DockBook: net/core/skbuff.c:4404: warning: No description found for parameter 'mtu'

2016-06-03 Thread David Miller
From: kbuild test robot Date: Sat, 4 Jun 2016 08:48:17 +0800 > tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > master > head: 330348d94223346f855357fab2517f6c903001c7 > commit: ae7ef81ef000adeee7a87585b9135ff8a8064acc [17/24] skbuff:

Re: [net-next:master 20/29] net/sctp/output.c:185:21: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'size_t {aka unsigned int}'

2016-06-03 Thread David Miller
I fixed this as follows: [PATCH] sctp: Fix warning in sctp_packet_transmit_chunk() size_t objects should be printed with %Z printf format. Reported-by: kbuild test robot Signed-off-by: David S. Miller --- net/sctp/output.c |

RE: [PATCH net] bnx2x: allow adding VLANs while interface is down

2016-06-03 Thread Yuval Mintz
> Since implementing VLAN filtering in commit 05cc5a39ddb74 > ("bnx2x: add vlan filtering offload") bnx2x refuses to add a VLAN while the > interface is down. Hi Michal - thanks; I'll review this one on Sunday.

Re: [PATCH net-next] qed: Fix next-ptr chains for BE / 32-bit

2016-06-03 Thread David Miller
From: Yuval Mintz Date: Sat, 4 Jun 2016 08:20:16 +0300 > Commit a91eb52abb50 ("qed: Revisit chain implementation") contains an > incorrect implementation for BE platforms, as device's regpairs containing > addresses are LE and they're not converted correctly when read

Re: [PATCH net-next 00/17] New DSA bind, switches as devices

2016-06-03 Thread David Miller
From: Andrew Lunn Date: Fri, 3 Jun 2016 18:43:59 +0200 > The interesting patches here are the last three. They implement a new > binding for DSA, which removes a few limitations of the current DSA > binding. In particular, it allows switches to be true Linux devices. > These

[PATCH net-next] qed: Fix next-ptr chains for BE / 32-bit

2016-06-03 Thread Yuval Mintz
Commit a91eb52abb50 ("qed: Revisit chain implementation") contains an incorrect implementation for BE platforms, as device's regpairs containing addresses are LE and they're not converted correctly when read back. In addition, it raises a compilation warning for 32-bit platforms where dma_addr_t

[PATCH v2 2/2] b43: Completely remove support for phy_a

2016-06-03 Thread Guenter Roeck
Per Michael Büsch: "All a-phy code is usused", so remove it all. Signed-off-by: Guenter Roeck --- v2: Added patch drivers/net/wireless/broadcom/b43/main.c | 31 +--- drivers/net/wireless/broadcom/b43/wa.c | 283 +++

[PATCH v2 1/2] b43: Remove unused phy_a code

2016-06-03 Thread Guenter Roeck
gcc-6 reports the following error with -Werror=unused-const-variable. drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error: 'b43_phyops_a' defined but not used Per Michael Büsch: "All a-phy code is usused", so remove phy_a.c completely. Move the remaining Type-G initialization code

[net-next:master 25/29] drivers/net/ethernet/qlogic/qed/qed_dev.c:1802:57: warning: left shift count >= width of type

2016-06-03 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 03c7f70beee4c5d34881e5d3dd2b6f3e848047ef commit: a91eb52abb504a1dd3248a5d07b54e7f95d5fcf1 [25/29] qed: Revisit chain implementation config: i386-allyesconfig (attached as .config) compiler: gcc-6 (Debian

[net-next:master 20/29] net/sctp/output.c:185:21: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'size_t {aka unsigned int}'

2016-06-03 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 03c7f70beee4c5d34881e5d3dd2b6f3e848047ef commit: 942b3235bf77e5600a05d6e85f0415bdeb8068bb [20/29] sctp: improve debug message to also log curr pkt and new chunk size config: i386-allyesconfig (attached as

[net-next:master 25/29] include/linux/qed/qed_chain.h:27:48: warning: left shift count >= width of type

2016-06-03 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 03c7f70beee4c5d34881e5d3dd2b6f3e848047ef commit: a91eb52abb504a1dd3248a5d07b54e7f95d5fcf1 [25/29] qed: Revisit chain implementation config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian

[PATCH 2/3] staging: r8712u: Fix leak of skb

2016-06-03 Thread Larry Finger
There are two types of messages queued for RX. The major type, which does I/O on the device, was being handled properly. The skbs that communicated with the firmware were being leaked. While rewriting the code that sets up the skb, it was possible to remove the private variable indicating that

[PATCH 3/3] staging: r8712u: Handle some false positives from kmemleak

2016-06-03 Thread Larry Finger
When this driver preallocates some URBs, kmemleak is unable to find that allocated memory when it scans. When the driver is unloaded, that memory is reclaimed, therefore, the report is a false positive. Signed-off-by: Larry Finger ---

[PATCH 0/3] Some fixes got r8712u

2016-06-03 Thread Larry Finger
While testing the patches that removed the semaphores from this driver, kmemleak reported some leaked skbs. There were also some false positives. I also found code that dereferenced a pointer before it was checked. All of these conditions are fixed. Signed-off-by: Larry Finger

[PATCH 1/3] staging: r8712u: Check pointer before use

2016-06-03 Thread Larry Finger
Routine r8712_usb_read_port() dereferences "precvbuf" before testing it for NULL. Signed-off-by: Larry Finger --- drivers/staging/rtl8712/usb_ops_linux.c | 72 - 1 file changed, 34 insertions(+), 38 deletions(-) diff --git

[net-next:master 17/24] DockBook: net/core/skbuff.c:4404: warning: No description found for parameter 'mtu'

2016-06-03 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 330348d94223346f855357fab2517f6c903001c7 commit: ae7ef81ef000adeee7a87585b9135ff8a8064acc [17/24] skbuff: introduce skb_gso_validate_mtu reproduce: make htmldocs All warnings (new ones prefixed by >>):

Re: [PATCH] b43: Remove unused phy_a code

2016-06-03 Thread Guenter Roeck
On 06/03/2016 02:35 PM, Michael Büsch wrote: On Fri, 3 Jun 2016 14:32:46 -0700 Guenter Roeck wrote: gcc-6 reports the following error with -Werror=unused-const-variable. drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error: 'b43_phyops_a' defined but not used

[net-next:master 20/24] net/sctp/output.c:37:21: note: in expansion of macro 'KBUILD_MODNAME'

2016-06-03 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 330348d94223346f855357fab2517f6c903001c7 commit: 942b3235bf77e5600a05d6e85f0415bdeb8068bb [20/24] sctp: improve debug message to also log curr pkt and new chunk size config: sh-allyesconfig (attached as

[net-next:master 20/24] net/sctp/output.c:185:2: note: in expansion of macro 'pr_debug'

2016-06-03 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 330348d94223346f855357fab2517f6c903001c7 commit: 942b3235bf77e5600a05d6e85f0415bdeb8068bb [20/24] sctp: improve debug message to also log curr pkt and new chunk size config: m68k-allyesconfig (attached as

Re: [PATCH net-next 0/4] qed: RocE & iSCSI infrastructure

2016-06-03 Thread David Miller
From: Yuval Mintz Date: Fri, 3 Jun 2016 14:35:31 +0300 > We plan on sending 2 new protocol drivers in the imminent future - > both our RoCE [qedr] and iSCSI [qedi] drivers. As both submissions > would be rather massive and in order to avoid collisions between them, > the

Re: [PATCH net-next 0/9] net: dsa: misc improvements

2016-06-03 Thread Florian Fainelli
On 06/03/2016 05:05 PM, Florian Fainelli wrote: > Hi all, > > This patch series builds on top of Andrew's "New DSA bind, switches as > devices" > patch set and does the following: > > - add support for the old DSA binding with the new dsa_register_switch() API > which is needed by some

[net-next:master 20/24] net/sctp/output.c:185:2: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t'

2016-06-03 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 330348d94223346f855357fab2517f6c903001c7 commit: 942b3235bf77e5600a05d6e85f0415bdeb8068bb [20/24] sctp: improve debug message to also log curr pkt and new chunk size config: cris-allyesconfig (attached as

Re: [PATCH 1/5] ethernet: add sun8i-emac driver

2016-06-03 Thread David Miller
From: LABBE Corentin Date: Fri, 3 Jun 2016 11:56:26 +0200 > +static int nbdesc_tx = 256; > +module_param(nbdesc_tx, int, S_IRUGO | S_IWUSR); > +MODULE_PARM_DESC(nbdesc_tx, "Number of descriptors in the TX list"); > +static int nbdesc_rx = 128; >

[PATCH net-next 5/9] net: dsa: Export suspend/resume functions

2016-06-03 Thread Florian Fainelli
In preparation for allowing switch drivers to implement system-wide suspend/resume functions, export dsa_switch_suspend and dsa_switch_resume() such that these are callable from the appropriate driver specific suspend/resume functions. Signed-off-by: Florian Fainelli ---

[PATCH net-next 7/7] net: dsa: bcm_sf2: Register our slave MDIO bus

2016-06-03 Thread Florian Fainelli
Register a slave MDIO bus which allows us to divert problematic read/writes towards conflicting pseudo-PHY address (30). Do no longer rely on DSA's slave_mii_bus, but instead provide our own implementation which offers more flexibility as to what to do, and when to register it. Signed-off-by:

[PATCH net-next 4/9] net: dsa: Initialize ds->enabled_port_mask and ds->phys_mii_mask

2016-06-03 Thread Florian Fainelli
Some drivers heavily rely on these two bitmasks to contain the correct values for them to successfully probe and initialize at drv->setup() time, calculate correct values to put in both masks. To avoid multiple ports lookup, we also try to set dst->cpu_port during dsa_parse_ports_dn(), which is

Re: [PATCH net-next] net: dsa: bcm_sf2: Implement FDB operations

2016-06-03 Thread Florian Fainelli
On 06/03/2016 05:05 PM, Florian Fainelli wrote: > Add support for the FDB add, delete, and dump operations. The add and > delete operations are implemented using directed ARL operations using > the specified MAC address and consist in a read operation, write and > readback operation. > > The dump

[PATCH net-next 6/9] net: dsa: Add initialization helper for CPU port ethtool_ops

2016-06-03 Thread Florian Fainelli
Add a helper function: dsa_cpu_port_ethtool_init() which initializes a custom ethtool_ops structure with custom DSA ethtool operations for CPU ports. This is a preliminary change to move the initialization outside of net/dsa/slave.c. Signed-off-by: Florian Fainelli ---

[PATCH net-next 7/9] net: dsa: Initialize CPU port ethtool ops per tree

2016-06-03 Thread Florian Fainelli
Now that we can properly support multiple distinct trees in the system, using a global variable: dsa_cpu_port_ethtool_ops is getting clobbered as soon as the second switch tree gets probed, and we don't want that. We need to move this to be dynamically allocated, and since we can't really be

[PATCH net-next 2/9] net: dsa: Add support for parsing the old binding

2016-06-03 Thread Florian Fainelli
Extend dsa2.c to support parsing for the old binding, which mostly means looking for more or less the same properties in different places. Signed-off-by: Florian Fainelli --- net/dsa/dsa2.c | 142 ++--- 1 file changed,

[PATCH net-next 9/9] net: dsa: bcm_sf2: Register our slave MDIO bus

2016-06-03 Thread Florian Fainelli
Register a slave MDIO bus which allows us to divert problematic read/writes towards conflicting pseudo-PHY address (30). Do no longer rely on DSA's slave_mii_bus, but instead provide our own implementation which offers more flexibility as to what to do, and when to register it. Signed-off-by:

Re: [PATCH net-next] net: dsa: Provide CPU port statistics to master netdev

2016-06-03 Thread Florian Fainelli
On 06/03/2016 05:05 PM, Florian Fainelli wrote: > This patch overloads the DSA master netdev, aka CPU Ethernet MAC to also > include switch-side statistics, which is useful for debugging purposes, > when the switch is not properly connected to the Ethernet MAC (duplex > mismatch, (RG)MII

[PATCH net-next 3/9] net: dsa: Provide unique DSA slave MII bus names

2016-06-03 Thread Florian Fainelli
In case we have multiples trees and switches with the same index, we need to add another discriminating id: the switch tree. Signed-off-by: Florian Fainelli --- net/dsa/slave.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/dsa/slave.c

[PATCH net-next 6/7] net: dsa: bcm_sf2: Make it a real platform device driver

2016-06-03 Thread Florian Fainelli
The Broadcom Starfighter 2 switch driver should be a proper platform driver, now that the DSA code has been updated to allow that, register a switch device, feed it with the proper configuration data coming from Device Tree and register our switch device with DSA. The bulk of the changes consist

[PATCH net-next] net: dsa: bcm_sf2: Implement FDB operations

2016-06-03 Thread Florian Fainelli
Add support for the FDB add, delete, and dump operations. The add and delete operations are implemented using directed ARL operations using the specified MAC address and consist in a read operation, write and readback operation. The dump operation consists in using the ARL search and software

[PATCH net-next 8/9] net: dsa: bcm_sf2: Make it a real platform device driver

2016-06-03 Thread Florian Fainelli
The Broadcom Starfighter 2 switch driver should be a proper platform driver, now that the DSA code has been updated to allow that, register a switch device, feed it with the proper configuration data coming from Device Tree and register our switch device with DSA. The bulk of the changes consist

[PATCH net-next 1/9] net: dsa: Prepare to support legacy DT binding

2016-06-03 Thread Florian Fainelli
In preparation for supporting the legacy DT binding, call dsa_get_ports() early on to allow two different parsing code paths to be called. Signed-off-by: Florian Fainelli --- net/dsa/dsa2.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git

[PATCH net-next 0/9] net: dsa: misc improvements

2016-06-03 Thread Florian Fainelli
Hi all, This patch series builds on top of Andrew's "New DSA bind, switches as devices" patch set and does the following: - add support for the old DSA binding with the new dsa_register_switch() API which is needed by some platforms where the Device Tree is pretty much frozen - add a few

[PATCH net-next] net: dsa: Provide CPU port statistics to master netdev

2016-06-03 Thread Florian Fainelli
This patch overloads the DSA master netdev, aka CPU Ethernet MAC to also include switch-side statistics, which is useful for debugging purposes, when the switch is not properly connected to the Ethernet MAC (duplex mismatch, (RG)MII electrical issues etc.). We accomplish this by retaining the

Re: [PATCH V4 0/4] net-next: mediatek: improve phy support

2016-06-03 Thread David Miller
From: John Crispin Date: Fri, 3 Jun 2016 10:17:05 +0200 > The current driver did not handle the RGMII delay modes and asymmetric flow > control properly. The mii_bus is not freed properly. Also add support for > fixed-phy allowing the driver to work on SoCs that have an

Re: [PATCH net] ethernet/sfc: report supported link speeds on SFP connections

2016-06-03 Thread David Miller
From: Jarod Wilson Date: Thu, 2 Jun 2016 21:33:24 -0400 > My solarflare cards connected to a 10GbE switch with an SFP+ module/cable > don't currently report any supported link speeds: ... > CC: Solarflare linux maintainers > CC: Edward Cree

Re: [PATCH v4 net-next 00/13] net: hns: add support of ACPI

2016-06-03 Thread David Miller
From: "Rafael J. Wysocki" Date: Fri, 03 Jun 2016 23:34:50 +0200 > On Friday, June 03, 2016 10:55:08 AM Yisen Zhuang wrote: >> From: Kejian Yan ... >> Kejian Yan (13): >> ACPI: bus: add stub acpi_dev_found() to linux/acpi.h >> ACPI: bus: add stub

Re: [PATCH] net: ethernet: ti: cpsw: remove unused priv lock

2016-06-03 Thread David Miller
From: Ivan Khoronzhuk Date: Fri, 3 Jun 2016 01:37:08 +0300 > There is no reason in this lock. At least for now. > > Signed-off-by: Ivan Khoronzhuk Applied to net-next.

Re: [PATCH] rxrpc: Use pr_ and pr_fmt, reduce object size a few KB

2016-06-03 Thread David Miller
From: Joe Perches Date: Thu, 2 Jun 2016 12:08:52 -0700 > Use the more common kernel logging style and reduce object size. > > The logging message prefix changes from a mixture of > "RxRPC:" and "RXRPC:" to "af_rxrpc: ". > > $ size net/rxrpc/built-in.o* >text

Re: [PATCH net-next] hv_netvsc: Fix VF register on vlan devices

2016-06-03 Thread David Miller
From: Haiyang Zhang Date: Thu, 2 Jun 2016 12:02:04 -0700 > Added a condition to avoid vlan devices with same MAC registering > as VF. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied.

Re: [PATCH v3 0/7] sctp: Add GSO support

2016-06-03 Thread David Miller
From: Marcelo Ricardo Leitner Date: Thu, 2 Jun 2016 15:05:37 -0300 > This patchset adds sctp GSO support. > > Performance tests indicates that increases throughput by 10% if using > bigger chunk sizes, specially if bigger than MTU. For small chunks, it > doesn't help

Re: [PATCH] net: ethernet: ti: cpsw: fix rx-usecs interrupt pacing consistency

2016-06-03 Thread David Miller
From: Ivan Khoronzhuk Date: Thu, 2 Jun 2016 16:14:52 +0300 > The rx-usecs shouldn't be changed while interface down/up. > Currently, for instance, if it's set to 100us, after interface > down/up it's 500us. It's a hidden bug that can lead to lavish > interrupt pacing

Re: [PATCH] gianfar: fix the last transmit buffer descriptor

2016-06-03 Thread David Miller
From: Yangbo Lu Date: Thu, 2 Jun 2016 17:36:28 +0800 > When the transmit hardware timestamping is enabled, an additional > TxBD would be added and would be set as the last TxBD with TXBD_LAST > and TXBD_INTERRUPT. However this has been broken by a patch recently. > This made

Re: [Patch net] act_police: fix a crash during removal

2016-06-03 Thread David Miller
From: Cong Wang Date: Wed, 1 Jun 2016 16:15:20 -0700 > The police action is using its own code to initialize tcf hash > info, which makes us to forgot to initialize a->hinfo correctly. > Fix this by calling the helper function tcf_hash_create() directly. > > This

Re: [Patch net] sch_prio: update backlog as well

2016-06-03 Thread David Miller
From: Cong Wang Date: Wed, 1 Jun 2016 16:15:16 -0700 > We need to update backlog too when we update qlen. > > Joint work with Stas. > > Reported-by: Stas Nichiporovich > Tested-by: Stas Nichiporovich > Fixes: 2f5fb43f

Re: [Patch net] sch_tbf: update backlog as well

2016-06-03 Thread David Miller
From: Cong Wang Date: Wed, 1 Jun 2016 16:15:19 -0700 > Fixes: 2f5fb43f ("net_sched: update hierarchical backlog too") > Cc: Jamal Hadi Salim > Signed-off-by: Cong Wang Applied.

Re: [Patch net] sch_hfsc: always keep backlog updated

2016-06-03 Thread David Miller
From: Cong Wang Date: Wed, 1 Jun 2016 16:15:15 -0700 > hfsc updates backlog lazily, that is only when we > dump the stats. This is problematic after we begin to > update backlog in qdisc_tree_reduce_backlog(). > > Reported-by: Stas Nichiporovich >

Re: [Patch net] sch_red: update backlog as well

2016-06-03 Thread David Miller
From: Cong Wang Date: Wed, 1 Jun 2016 16:15:18 -0700 > Fixes: 2f5fb43f ("net_sched: update hierarchical backlog too") > Cc: Jamal Hadi Salim > Signed-off-by: Cong Wang Applied.

Re: [Patch net] sch_drr: update backlog as well

2016-06-03 Thread David Miller
From: Cong Wang Date: Wed, 1 Jun 2016 16:15:17 -0700 > Fixes: 2f5fb43f ("net_sched: update hierarchical backlog too") > Cc: Jamal Hadi Salim > Signed-off-by: Cong Wang Applied.

Re: latest net-next does not build on sparc?

2016-06-03 Thread David Miller
From: Sowmini Varadhan Date: Fri, 3 Jun 2016 18:39:25 -0400 > Just pulled 4.7.0-rc1, and I find a build error > > kernel/locking/rwsem.c: In function ?down_write_killable?: > kernel/locking/rwsem.c:65: error: implicit declaration of function >

[PATCH 4.4-stable 1/3] vxlan: Relax MTU constraints

2016-06-03 Thread Dan Streetman
From: David Wragg Allow the MTU of vxlan devices without an underlying device to be set to larger values (up to a maximum based on IP packet limits and vxlan overhead). Previously, their MTUs could not be set to higher than the conventional ethernet value of 1500. This is a

[PATCH 4.4-stable 2/3] geneve: Relax MTU constraints

2016-06-03 Thread Dan Streetman
From: David Wragg Allow the MTU of geneve devices to be set to large values, in order to exploit underlying networks with larger frame sizes. GENEVE does not have a fixed encapsulation overhead (an openvswitch rule can add variable length options), so there is no relevant

[PATCH 4.4-stable 0/3] Set a large MTU on ovs-created tunnel devices

2016-06-03 Thread Dan Streetman
Can you queue these for 4.4 stable? The first 2 are cherry-picked cleanly into 4.4, the last required only context changes to apply. The commits are only needed in 4.4, as the bugs they fix were introduced after 4.1. David Wragg (3): vxlan: Relax MTU constraints geneve: Relax MTU

[PATCH 4.4-stable 3/3] vxlan, gre, geneve: Set a large MTU on ovs-created tunnel devices

2016-06-03 Thread Dan Streetman
From: David Wragg Prior to 4.3, openvswitch tunnel vports (vxlan, gre and geneve) could transmit vxlan packets of any size, constrained only by the ability to send out the resulting packets. 4.3 introduced netdevs corresponding to tunnel vports. These netdevs have an MTU,

latest net-next does not build on sparc?

2016-06-03 Thread Sowmini Varadhan
Just pulled 4.7.0-rc1, and I find a build error kernel/locking/rwsem.c: In function ?down_write_killable?: kernel/locking/rwsem.c:65: error: implicit declaration of function ?__down_write_killable? make[2]: *** [kernel/locking/rwsem.o] Error 1 I had to pull in this patch:

Re: [PATCH v2] soreuseport: add compat case for setsockopt SO_ATTACH_REUSEPORT_CBPF

2016-06-03 Thread Daniel Borkmann
On 06/03/2016 11:49 PM, Helge Deller wrote: Commit 538950a1b752 ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF") missed to add the compat case for the SO_ATTACH_REUSEPORT_CBPF option. Signed-off-by: Helge Deller LGTM, thanks! Acked-by: Daniel Borkmann

Re: [PATCH] b43: Remove unused phy_a code

2016-06-03 Thread Michael Büsch
On Fri, 3 Jun 2016 14:32:46 -0700 Guenter Roeck wrote: > gcc-6 reports the following error with -Werror=unused-const-variable. > > drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error: > 'b43_phyops_a' defined but not used > > Turns out a lot of code in this file

[Patch net] net_sched: keep backlog updated with qlen

2016-06-03 Thread Cong Wang
For gso_skb we only update qlen, backlog should be updated too. Note, it is correct to just update these stats at one layer, because the gso_skb is cached there. Reported-by: Stas Nichiporovich Fixes: 2f5fb43f ("net_sched: update hierarchical backlog too") Cc: Jamal Hadi

Re: [PATCH v2] soreuseport: add compat case for setsockopt SO_ATTACH_REUSEPORT_CBPF

2016-06-03 Thread Helge Deller
Commit 538950a1b752 ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF") missed to add the compat case for the SO_ATTACH_REUSEPORT_CBPF option. Signed-off-by: Helge Deller diff --git a/net/compat.c b/net/compat.c index 5cfd26a..1373947 100644 --- a/net/compat.c +++

[PATCH] iwlwifi: Remove unused array 'iwlagn_loose_lookup'

2016-06-03 Thread Guenter Roeck
gcc-6 reports the following error if -Werror=unused-const-variable is enabled. drivers/net/wireless/intel/iwlwifi/dvm/lib.c:210:21: error: 'iwlagn_loose_lookup' defined but not used Signed-off-by: Guenter Roeck --- drivers/net/wireless/intel/iwlwifi/dvm/lib.c | 17

Re: [PATCH] soreuseport: add compat case for setsockopt SO_ATTACH_REUSEPORT_CBPF

2016-06-03 Thread Alexei Starovoitov
On Fri, Jun 03, 2016 at 05:33:09PM -0400, Craig Gallek wrote: > On Fri, Jun 3, 2016 at 5:09 PM, Helge Deller wrote: > > Any idea for a better naming than "do_sockopt_fix_sock_fprog()" ? > Thanks for catching and fixing this. I'd suggest simply leaving the > function name as-is.

[PATCH] b43: Remove unused phy_a code

2016-06-03 Thread Guenter Roeck
gcc-6 reports the following error with -Werror=unused-const-variable. drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error: 'b43_phyops_a' defined but not used Turns out a lot of code in this file is unused, so let's remove it. Reported-by: Fengguang Wu

Re: [PATCH] soreuseport: add compat case for setsockopt SO_ATTACH_REUSEPORT_CBPF

2016-06-03 Thread Craig Gallek
On Fri, Jun 3, 2016 at 5:09 PM, Helge Deller wrote: > Any idea for a better naming than "do_sockopt_fix_sock_fprog()" ? Thanks for catching and fixing this. I'd suggest simply leaving the function name as-is. Your fix to the condition in that function is sufficient to address the

Re: [PATCH net-next 16/17] arm: dt: vf610-zii-devel-b: Make use of new DSA binding

2016-06-03 Thread Vivien Didelot
Andrew Lunn writes: > Hang the three switches of the three MDIO busses using the new DSA > binding. Also, make use of the mdio-bus and explicitly list the phys > on one device. This is not required, but good for testing. > > Signed-off-by: Andrew Lunn

Re: [PATCH v4 net-next 00/13] net: hns: add support of ACPI

2016-06-03 Thread Rafael J. Wysocki
On Friday, June 03, 2016 10:55:08 AM Yisen Zhuang wrote: > From: Kejian Yan > > This series adds HNS support of acpi. The routine will call some ACPI > helper functions, like acpi_dev_found() and acpi_evaluate_dsm(), which > are not included in other cases. In order to make

Re: [PATCH] soreuseport: Fix reuseport_bpf testcase on 32bit architectures

2016-06-03 Thread Craig Gallek
On Fri, Jun 3, 2016 at 1:19 PM, Helge Deller wrote: > This fixes the following compiler warnings when compiling the > reuseport_bpf testcase on a 32 bit platform: > > reuseport_bpf.c: In function ‘attach_ebpf’: > reuseport_bpf.c:114:15: warning: cast from pointer to integer of

Re: [PATCH net-next 17/17] net: dsa: Document new binding

2016-06-03 Thread Vivien Didelot
Andrew Lunn writes: > Add the new binding to the documentation of the existing binding. > Mark the old binding as deprecated. > > Signed-off-by: Andrew Lunn > Signed-off-by: Florian Fainelli Reviewed-by: Vivien Didelot

Re: [PATCH net-next 09/17] net: dsa: Split up creating/destroying of DSA and CPU ports

2016-06-03 Thread Florian Fainelli
On 06/03/2016 09:44 AM, Andrew Lunn wrote: > Refactor the code to setup a single DSA/CPU port into a function of > its own, and export it, so it can be used by the new binding. > > Similarly, refactor the destroy code into a function. When destroying > the ports, don't put the of node. They

Re: [PATCH net-next 08/17] net: dsa: Copy the routing table into the switch structure

2016-06-03 Thread Florian Fainelli
On 06/03/2016 09:44 AM, Andrew Lunn wrote: > The new binding will not have a chip data structure, it will place the > routing directly into the switch structure. To enable backwards > compatibility, copy the routing from the chip data into the switch > structure. > > Signed-off-by: Andrew Lunn

Re: [PATCH net-next 10/17] net: dsa: mv88e6xxx: Only support EDSA tagging

2016-06-03 Thread Florian Fainelli
On 06/03/2016 09:44 AM, Andrew Lunn wrote: > The merged driver no longer offers the option to use DSA tagging. So > remove the code to setup the switch to do DSA tagging and hard code > the use of EDSA. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli

Re: [PATCH net-next 15/17] net: dsa: Add new binding implementation

2016-06-03 Thread Florian Fainelli
On 06/03/2016 09:44 AM, Andrew Lunn wrote: > The existing DSA binding has a number of limitations and problems. The > main problem is that it cannot represent a switch as a linux device, > hanging off some bus. It is limited to one CPU port. The DSA platform > device is artificial, and does not

Re: [PATCH net-next 02/17] net: dsa: mv88e6xxx: fix circular lock in PPU work

2016-06-03 Thread Florian Fainelli
On 06/03/2016 09:44 AM, Andrew Lunn wrote: > From: Vivien Didelot > > Lock debugging shows that there is a possible circular lock in the PPU > work code. Switch the lock order of smi_mutex and ppu_mutex to fix this. > > Here's the full trace: > > [

Re: [PATCH net-next 07/17] net: dsa: Remove dynamic allocate of routing table

2016-06-03 Thread Florian Fainelli
On 06/03/2016 09:44 AM, Andrew Lunn wrote: > With a maximum of four switches, the size of the routing table is the > same as the pointer to it. Removing it makes the code simpler. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH] soreuseport: add compat case for setsockopt SO_ATTACH_REUSEPORT_CBPF

2016-06-03 Thread Helge Deller
On 03.06.2016 20:11, Sergei Shtylyov wrote: > Hello. > > On 06/03/2016 08:18 PM, Helge Deller wrote: > >> Commit 538950a ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF") > >At least 12 digits must be specified for SHA1. checkpatch.pl should've > caught this. Ok. >> missed to add

[PATCHv2 net-next] net: igb: Only dma sync frame length

2016-06-03 Thread Andrew Lunn
On some platforms, syncing a buffer for DMA is expensive. Rather than sync the whole 2K receive buffer, only synchronise the length of the frame, which will typically be the MTU, or a much smaller TCP ACK. For an IMX6Q, this gives around 6% increased TCP receive performance, which is cache

[PATCH v3] virtio-net: Add initial MTU advice feature

2016-06-03 Thread Aaron Conole
This commit adds the feature bit and associated mtu device entry for the virtio network device. When a virtio device comes up, it checks the feature bit for the VIRTIO_NET_F_MTU feature. If such feature bit is enabled, the driver will read the advised MTU and use it as the initial value.

Re: [RFC PATCH 0/4] Make inotify instance/watches be accounted per userns

2016-06-03 Thread Eric W. Biederman
Nikolay Borisov writes: > On 06/02/2016 07:58 PM, Eric W. Biederman wrote: >> >> Nikolay please see my question for you at the end. [snip] >> All of that said there is definitely a practical question that needs to >> be asked. Nikolay how did you get into this situation? A

[PATCH] libertas_tf: Drop unused variable and define

2016-06-03 Thread Guenter Roeck
gcc-6 reports: drivers/net/wireless/marvell/libertas_tf/main.c:30:19: error: 'lbtf_driver_version' defined but not used with -Werror=unused-const-variable=. Reported-by: Fengguang Wu [0-day test robot] Signed-off-by: Guenter Roeck ---

[PATCH net-next 0/2] tcp: add NV congestion control

2016-06-03 Thread Lawrence Brakmo
This version of NV does much better than previous versions when things are very congested and also adds a couple of experimental features. Tested in a rack using between 1 and 380 active TCP-NV flows. Consists of the following patches: [PATCH net-next 1/2] tcp: add in_flight to tcp_skb_cb [PATCH

[PATCH net-next 1/2] tcp: add in_flight to tcp_skb_cb

2016-06-03 Thread Lawrence Brakmo
Add in_flight (bytes in flight when packet was sent) field to tx component of tcp_skb_cb and make it available to congestion modules' pkts_acked() function through the ack_sample function argument. Signed-off-by: Lawrence Brakmo Acked-by: Yuchung Cheng ---

Re: [PATCH net-next 00/17] New DSA bind, switches as devices

2016-06-03 Thread Vivien Didelot
Andrew Lunn writes: > The interesting patches here are the last three. They implement a new > binding for DSA, which removes a few limitations of the current DSA > binding. In particular, it allows switches to be true Linux devices. > These devices can be on any type of bus,

[PATCH net-next 2/2] tcp: add NV congestion control

2016-06-03 Thread Lawrence Brakmo
TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of NV was presented at 2010's LPC. It is a delayed based congestion avoidance for the data center. This version has been tested within a 10G rack where the HW RTTs are 20-50us. A description of TCP-NV, including implementation

Re: [Intel-wired-lan] [PATCH] net: igb: Only dma sync frame length

2016-06-03 Thread Alexander Duyck
On Fri, Jun 3, 2016 at 10:45 AM, Andrew Lunn wrote: > On some platforms, syncing a buffer for DMA is expensive. Rather than > sync the whole 2K receive buffer, only synchronise the length of the > frame, which will typically be the MTU, or a much smaller TCP ACK. > > For an IMX6Q,

Re: [PATCH net-next] cxgb4: Reduce resource allocation in kdump kernel

2016-06-03 Thread Casey Leedom
Looks good to me. Of course I came up with those changes so maybe we should get another reviewer? :-) Also, don't forget to mention "Bug #29998" in the commit message ... Casey From: Hariprasad Shenai Sent: Friday, June 3,

Re: [PATCH stable] Set a large MTU on ovs-created tunnel devices

2016-06-03 Thread Dan Streetman
On Fri, Jun 3, 2016 at 2:44 PM, David Miller wrote: > From: Dan Streetman > Date: Fri, 3 Jun 2016 13:49:09 -0400 > >> Can you queue up these commits for stable? > > This stuff doesn't cleanly backport, I tried several times already. ah sorry.

Re: [PATCH net-next 15/17] net: dsa: Add new binding implementation

2016-06-03 Thread Vivien Didelot
Andrew Lunn writes: > The existing DSA binding has a number of limitations and problems. The > main problem is that it cannot represent a switch as a linux device, > hanging off some bus. It is limited to one CPU port. The DSA platform > device is artificial, and does not really

Re: [PATCH net-next 14/17] net: dsa: mv88e6xxx: Refactor MDIO so driver registers mdio bus

2016-06-03 Thread Vivien Didelot
Andrew Lunn writes: > Have the switch driver register its own MDIO bus. This allows for an > mdio property in the device tree, with child nodes for phys, which > can be referenced via phandles, etc. > > Signed-off-by: Andrew Lunn Reviewed-by: Vivien Didelot

Re: [PATCH net-next] tcp: accept RST if SEQ matches right edge of SACK block

2016-06-03 Thread Neal Cardwell
On Fri, Jun 3, 2016 at 3:44 PM, Neal Cardwell wrote: > On Fri, Jun 3, 2016 at 12:24 PM, Eric Dumazet wrote: >> On Fri, 2016-06-03 at 11:45 -0400, Neal Cardwell wrote: >>> But I would also vote to tighten up the proposed logic slightly, and >>> only

Re: [PATCH net-next] tcp: accept RST if SEQ matches right edge of SACK block

2016-06-03 Thread Neal Cardwell
On Fri, Jun 3, 2016 at 12:24 PM, Eric Dumazet wrote: > On Fri, 2016-06-03 at 11:45 -0400, Neal Cardwell wrote: >> But I would also vote to tighten up the proposed logic slightly, and >> only check the seq of the incoming RST against the right edge of the >> *right-most*

Re: [PATCH net-next 13/17] net: dsa: mv88e6xxx: Rename _phy_ to _mdio_

2016-06-03 Thread Vivien Didelot
Andrew Lunn writes: > The switch implements a generic MDIO bus, which could host more than > PHYs. It is conventional to use _mdio_ or _mii_ in the function name, > so rename them. Also postfix make the historically first read/write > function with _direct, to help distinguish it

[PATCH net-next v3 1/2] net: Add l3mdev rule

2016-06-03 Thread David Ahern
Currently, VRFs require 1 oif and 1 iif rule per address family per VRF. As the number of VRF devices increases it brings scalability issues with the increasing rule list. All of the VRF rules have the same format with the exception of the specific table id to direct the lookup. Since the table id

[PATCH net-next v3 0/2] net: vrf: Improve use of FIB rules

2016-06-03 Thread David Ahern
Currently, VRFs require 1 oif and 1 iif rule per address family per VRF. As the number of VRF devices increases it brings scalability issues with the increasing rule list. All of the VRF rules have the same format with the exception of the specific table id to direct the lookup. Since the table id

[PATCH net-next v3 2/2] net: vrf: Add l3mdev rules on first device create

2016-06-03 Thread David Ahern
Add l3mdev rule per address family when the first VRF device is created. Remove them when the last is deleted. Signed-off-by: David Ahern --- v3 - per Nik's comment changed num_vrfs from atomic to unsigned int; all accesses are with rtnl held v2 - added EXCL flag and

Re: [PATCH] net: ethernet: ti: cpsw: remove rx_descs property

2016-06-03 Thread Ivan Khoronzhuk
On 03.06.16 22:13, Grygorii Strashko wrote: On 06/03/2016 09:25 PM, Ivan Khoronzhuk wrote: On 03.06.16 19:50, Grygorii Strashko wrote: On 06/03/2016 01:43 AM, Ivan Khoronzhuk wrote: There is no reason to hold s/w dependent parameter in device tree. Even more, there is no reason in this

Re: [PATCH] rtl8xxxu: fix typo on variable name, compare against correct variable

2016-06-03 Thread Jes Sorensen
Colin King writes: > From: Colin Ian King > > path_b_ok is being assigned but immediately after path_a_ok is being > compared to the value 0x03. This appears to be a typo on the > variable name, compare path_b_ok instead. > > Signed-off-by:

  1   2   3   >