Re: [PATCH net-next v10 2/5] openvswitch: set skb protocol and mac_len when receiving on internal device

2016-06-16 Thread Simon Horman
On Tue, Jun 07, 2016 at 03:45:27PM -0700, pravin shelar wrote: > On Mon, Jun 6, 2016 at 8:08 PM, Simon Horman > wrote: > > On Thu, Jun 02, 2016 at 03:01:47PM -0700, pravin shelar wrote: > >> On Wed, Jun 1, 2016 at 11:24 PM, Simon Horman > >>

Re: [PATCH net-next] net, cls: also reject deleting all filters when TCA_KIND present

2016-06-16 Thread David Miller
From: Daniel Borkmann Date: Thu, 16 Jun 2016 23:19:29 +0200 > When we check for RTM_DELTFILTER, we should also reject the request > for deleting all filters under a given parent when TCA_KIND attribute > is present. If present, it's currently just ignored but there's also >

Re: net: stmmac: dwmac-rk: fixes for Wake-on-Lan on RK3288

2016-06-16 Thread Giuseppe CAVALLARO
On 6/16/2016 4:51 PM, Vincent Palatin wrote: Hi Giuseppe, On Thu, Jun 16, 2016 at 6:37 AM, Giuseppe CAVALLARO wrote: Hi Vincent On 6/15/2016 7:04 PM, Vincent Palatin wrote: On Sun, Jun 12, 2016 at 11:46 PM, Giuseppe CAVALLARO wrote: On

Re: [BUG] act_ife: sleeping functions called in atomic context

2016-06-16 Thread Cong Wang
On Thu, Jun 16, 2016 at 7:14 PM, Cong Wang wrote: > > I think we can just remove that tcf_lock, I am testing a patch now. Please try the attached patch, I will do more tests tomorrow. Thanks! diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c index 658046d..859fb02

Re: [PATCH net-next v5 0/7] vmxnet3: upgrade to version 3

2016-06-16 Thread David Miller
From: Shrikrishna Khare Date: Thu, 16 Jun 2016 10:51:52 -0700 > vmxnet3 emulation has recently added several new features which includes > support for new commands the driver can issue to emulation, change in > descriptor fields etc. This patch series extends the vmxnet3

Re: [PATCH 4.7 FIX] brcmfmac: fix lockup when removing P2P interface after event timeout

2016-06-16 Thread Rafał Miłecki
On 17 June 2016 at 07:13, Kalle Valo wrote: > Rafał Miłecki writes: > >> On 16 June 2016 at 17:10, Kalle Valo wrote: >>> Rafał Miłecki writes: >>> Removing P2P interface is handled by sending a proper request

Re: [PATCH net-next 00/13] s390: qeth patches

2016-06-16 Thread David Miller
From: Ursula Braun Date: Thu, 16 Jun 2016 16:18:50 +0200 > here are patches for the s390 qeth driver for net-next: > > Patch 01 is a minor improvement for the bridgeport code in qeth. > > Patches 02-07 take care about scatter/gather handling in qeth. > > Patch 08

Re: [PATCH 4.7 FIX] brcmfmac: fix lockup when removing P2P interface after event timeout

2016-06-16 Thread Kalle Valo
Rafał Miłecki writes: > On 16 June 2016 at 17:10, Kalle Valo wrote: >> Rafał Miłecki writes: >> >>> Removing P2P interface is handled by sending a proper request to the >>> firmware. On success firmware triggers an event and driver's

Re: [PATCH 7/8] net: xfrm: fix old-style declaration

2016-06-16 Thread David Miller
From: Arnd Bergmann Date: Thu, 16 Jun 2016 15:59:25 +0200 > Modern C standards expect the '__inline__' keyword to come before the return > type in a declaration, and we get a couple of warnings for this with "make > W=1" > in the xfrm{4,6}_policy.c files: > >

Re: [PATCH 5/8] isdn: eicon: fix old-style declarations

2016-06-16 Thread David Miller
From: Arnd Bergmann Date: Thu, 16 Jun 2016 15:52:12 +0200 > Modern C standards expect the '__inline__' keyword to come before the return > type in a declaration, and we get many warnings for this with "make W=1" > because the eicon driver has this in a header file: > >

Re: [PATCH 6/8] net: gianfar: fix old-style declaration

2016-06-16 Thread David Miller
From: Arnd Bergmann Date: Thu, 16 Jun 2016 15:52:13 +0200 > Modern C standards expect the '__inline__' keyword to come before the return > type in a declaration, and we get a warning for this with "make W=1": > > drivers/net/ethernet/freescale/gianfar.c:2278:1: error: 'inline' is

Re: [PATCH 4/8] hamradio: baycom: fix old-style declaration

2016-06-16 Thread David Miller
From: Arnd Bergmann Date: Thu, 16 Jun 2016 15:52:11 +0200 > Modern C standards expect the '__inline__' keyword to come before the return > type in a declaration, and we get a warning for this with "make W=1": > > drivers/net/hamradio/baycom_par.c:159:1: error: '__inline__' is not

Re: [PATCH net] nfp: use correct index to mask link state irq

2016-06-16 Thread David Miller
From: Jakub Kicinski Date: Thu, 16 Jun 2016 14:42:50 +0100 > We were using an incorrect define to get the irq vector number. > NFP_NET_CFG_LSC is a control BAR offset, LSC interrupt vector > index is called NFP_NET_IRQ_LSC_IDX. For machines with less > than 30 CPUs

Re: [PATCH 4.7 FIX] brcmfmac: fix lockup when removing P2P interface after event timeout

2016-06-16 Thread Rafał Miłecki
On 16 June 2016 at 17:10, Kalle Valo wrote: > Rafał Miłecki writes: > >> Removing P2P interface is handled by sending a proper request to the >> firmware. On success firmware triggers an event and driver's handler >> removes a matching interface. >> >>

Re: [PATCH net-next v6] tcp: Add RFC4898 tcpEStatsPerfDataSegsOut/In

2016-06-16 Thread Eric Dumazet
On Mon, 2016-03-14 at 10:52 -0700, Martin KaFai Lau wrote: > Per RFC4898, they count segments sent/received > containing a positive length data segment (that includes > retransmission segments carrying data). Unlike > tcpi_segs_out/in, tcpi_data_segs_out/in excludes segments > carrying no data

Re: [BUG] act_ife: sleeping functions called in atomic context

2016-06-16 Thread Cong Wang
On Thu, Jun 16, 2016 at 5:38 PM, Jamal Hadi Salim wrote: > On 16-06-16 05:43 PM, Cong Wang wrote: >> >> On Thu, Jun 16, 2016 at 1:50 PM, Alexey Khoroshilov >> wrote: >>> >>> tcf_ife_init() contains a big chunk of code executed with >>> ife->tcf_lock

Re: [net-next,v2] openvswitch: Add skb->len info to upcall.

2016-06-16 Thread pravin shelar
On Thu, Jun 16, 2016 at 11:17 AM, William Tu wrote: > The commit f2a4d086ed4c ("openvswitch: Add packet truncation support.") > introduces packet truncation before sending to userspace upcall receiver. > This patch passes up the skb->len before truncation so that the upcall >

Re: [PATCH v9 03/22] IB/hns: Add initial main frame driver and get cfg info

2016-06-16 Thread Wei Hu (Xavier)
On 2016/6/9 14:39, Leon Romanovsky wrote: On Wed, Jun 01, 2016 at 11:37:45PM +0800, Lijun Ou wrote: This patch mainly added the initial bare main driver. It could get the relative configure information of net node. Signed-off-by: Wei Hu Signed-off-by: Nenglong Zhao

Re: [PATCH v9 09/22] IB/hns: Add hca support

2016-06-16 Thread Wei Hu (Xavier)
On 2016/6/9 15:10, Leon Romanovsky wrote: On Wed, Jun 01, 2016 at 11:37:51PM +0800, Lijun Ou wrote: This patch mainly setup hca for RoCE. It will do a series of initial works, as follows: 1. init uar table, allocate uar resource 2. init pd table 3. init cq table 4. init mr

Re: [PATCH v9 11/22] IB/hns: Add IB device registration

2016-06-16 Thread Wei Hu (Xavier)
On 2016/6/13 20:46, Leon Romanovsky wrote: On Sun, Jun 12, 2016 at 05:41:06PM +0800, Wei Hu (Xavier) wrote: On 2016/6/9 14:26, Leon Romanovsky wrote: On Wed, Jun 01, 2016 at 11:37:53PM +0800, Lijun Ou wrote: This patch registered IB device when loaded, and unregistered IB device when

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-06-16 Thread Matt Wilson
On Thu, Jun 16, 2016 at 10:46:23PM +0200, Francois Romieu wrote: > Netanel Belgazal : > [...] > > Very limited review below. I'll comment on the documentation (since I edited it heavily) but will leave some the other parts for Netanel to answer. > > diff --git

Re: [PATCH net-next V2] tun: introduce tx skb ring

2016-06-16 Thread Michael S. Tsirkin
On Wed, Jun 15, 2016 at 04:38:17PM +0800, Jason Wang wrote: > We used to queue tx packets in sk_receive_queue, this is less > efficient since it requires spinlocks to synchronize between producer > and consumer. > > This patch tries to address this by: > > - introduce a new mode which will be

Re: [PATCH] net: do not initialise statics to 0

2016-06-16 Thread David Miller
From: Wei Tang Date: Thu, 16 Jun 2016 21:17:49 +0800 > This patch fixes the checkpatch.pl error to dev.c: > > ERROR: do not initialise statics to 0 > > Signed-off-by: Wei Tang Applied.

Re: [PATCH] net: the space is required after ','

2016-06-16 Thread David Miller
From: Wei Tang Date: Thu, 16 Jun 2016 21:30:12 +0800 > The space is missing after ',', and this will introduce much more > noise when checking patch around. > > Signed-off-by: Wei Tang Applied.

Re: [BUG] act_ife: sleeping functions called in atomic context

2016-06-16 Thread Jamal Hadi Salim
On 16-06-16 05:43 PM, Cong Wang wrote: On Thu, Jun 16, 2016 at 1:50 PM, Alexey Khoroshilov wrote: tcf_ife_init() contains a big chunk of code executed with ife->tcf_lock spinlock held. But that code contains several calls to sleeping functions: populate_metalist() and

Re: [PATCH 2/5] net: tlan: don't set unused function argument

2016-06-16 Thread David Miller
From: Arnd Bergmann Date: Thu, 16 Jun 2016 13:38:23 +0200 > We get a warning for tlan_handle_tx_eoc when building with "make W=1" > > drivers/net/ethernet/ti/tlan.c: In function 'tlan_handle_tx_eoc': > drivers/net/ethernet/ti/tlan.c:1647:59: error: parameter 'host_int' set but >

Re: [PATCH 1/5] net: qlcnic: don't set unused function argument

2016-06-16 Thread David Miller
From: Arnd Bergmann Date: Thu, 16 Jun 2016 13:38:22 +0200 > We get a warning for qlcnic_83xx_get_mac_address when building with > "make W=1": > > drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c: In function > 'qlcnic_83xx_get_mac_address': >

Re: [PATCH 0/4] net-next: mediatek: IRQ cleanups, fixes and grouping

2016-06-16 Thread David Miller
From: John Crispin Date: Thu, 16 Jun 2016 11:44:44 +0200 > > > On 16/06/2016 07:20, David Miller wrote: >> From: John Crispin >> Date: Wed, 15 Jun 2016 16:58:46 +0200 >> >>> This series contains 2 small code cleanups that are leftovers from the >>> MIPS

Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats

2016-06-16 Thread David Miller
From: Jiri Pirko Date: Thu, 16 Jun 2016 10:37:13 +0200 > Until now we had stats functions return SW statistics. However, it makes > a lot of sense to return HW stats as default. The existing apps count with > having the defaults stats complete, but that is not true now as the

Re: [patch net-next v4 3/4] net: core: add SW stats to if_stats_msg

2016-06-16 Thread David Miller
From: Jiri Pirko Date: Thu, 16 Jun 2016 10:37:16 +0200 > @@ -1068,6 +1068,11 @@ static int rtnl_phys_switch_id_fill(struct sk_buff > *skb, struct net_device *dev) > return 0; > } > > +static void copy_rtnl_link_stats64(void *v, const struct rtnl_link_stats64 > *b) >

Re: [PATCH] dsa: b53: fix big-endian register access

2016-06-16 Thread David Miller
From: Arnd Bergmann Date: Thu, 16 Jun 2016 11:00:05 +0200 > The b53 dsa register access confusingly uses __raw register accessors > when both the CPU and the device are big-endian, but it uses little- > endian accessors when the same device is used from a little-endian > CPU,

Re: [PATCH net-next] mpls: allow routes on ipgre devices

2016-06-16 Thread David Miller
From: Simon Horman Date: Thu, 16 Jun 2016 17:09:09 +0900 > This appears to be necessary and sufficient to provide > MPLS in GRE (RFC4023) support. > > This can be used by establishing an ipgre tunnel device > and then routing MPLS over it. > > The following example

Re: [PATCH] sit: correct IP protocol used in ipip6_err

2016-06-16 Thread David Miller
From: Simon Horman Date: Thu, 16 Jun 2016 17:06:19 +0900 > Since 32b8a8e59c9c ("sit: add IPv4 over IPv4 support") > ipip6_err() may be called for packets whose IP protocol is > IPPROTO_IPIP as well as those whose IP protocol is IPPROTO_IPV6. > > In the case of

Re: [PATCH net-next] r8152: modify the check of the flag of PHY_RESET in set_speed function

2016-06-16 Thread David Miller
From: Hayes Wang Date: Thu, 16 Jun 2016 14:08:29 +0800 > In set_speed(), BMCR_RESET would be set when the flag of PHY_RESET > is set. Use BMCR_RESET to replace testing the flag of PHY_RESET. > > Signed-off-by: Hayes Wang Applied, thanks.

Re: [PATCH 2/2] net: ethernet: ax88796: use phy_ethtool_{get|set}_link_ksettings

2016-06-16 Thread David Miller
From: Philippe Reynes Date: Thu, 16 Jun 2016 00:12:49 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 1/2] net: ethernet: ax88796: use phydev from struct net_device

2016-06-16 Thread David Miller
From: Philippe Reynes Date: Thu, 16 Jun 2016 00:12:48 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the > one

Re: [PATCH net-next V2] tun: introduce tx skb ring

2016-06-16 Thread David Miller
From: Jason Wang Date: Wed, 15 Jun 2016 16:38:17 +0800 > We used to queue tx packets in sk_receive_queue, this is less > efficient since it requires spinlocks to synchronize between producer > and consumer. > > This patch tries to address this by: > > - introduce a new

Re: [PATCH RFC 1/3] ipv4: make flow functions more grepable by removing flowi4_init_output

2016-06-16 Thread David Miller
From: Hannes Frederic Sowa Date: Thu, 16 Jun 2016 23:39:12 +0200 > Most of the time a new attribute that gets added to flow4i only > decreases the scope of the actual lookup, thus a missing attribute > doesn't necessarily indicate a bug. That's true, and it works

[PATCH net-next 2/3] net: vrf: Implement get_saddr for IPv6

2016-06-16 Thread David Ahern
IPv6 source address selection needs to consider the real egress route. Similar to IPv4 implement a get_saddr6 method which is called if source address has not been set. The get_saddr6 method does a full lookup which means pulling a route from the VRF FIB table and properly considering

[PATCH net-next 1/3] net: ipv6: Move ip6_route_get_saddr to inline

2016-06-16 Thread David Ahern
VRF driver needs access to ip6_route_get_saddr code. Since it does little beyond ipv6_dev_get_saddr and ipv6_dev_get_saddr is already exported for modules move ip6_route_get_saddr to the header as an inline. Code move only; no functional change. Signed-off-by: David Ahern

[PATCH net-next 0/3] net: vrf: Fix ipv6 source address selection

2016-06-16 Thread David Ahern
IPv6 address selection is currently messed up for several use cases such as unnumbered deployments with global addresses on the VRF device and none on the enslaved devices. Update the source address selection to consider the real output route as opposed to the VRF route that sends packets to the

[PATCH net-next 3/3] net: ipv6: Address selection needs to consider L3 domains

2016-06-16 Thread David Ahern
IPv6 version of 3f2fb9a834cb ("net: l3mdev: address selection should only consider devices in L3 domain") and the follow up commit, a17b693cdd876 ("net: l3mdev: prefer VRF master for source address selection"). That is, if outbound device is given then the address preference order is an address

Re: [PATCH net-next 0/8] tou: Transports over UDP - part I

2016-06-16 Thread Hannes Frederic Sowa
On 16.06.2016 19:51, Tom Herbert wrote: > Transports over UDP is intended to encapsulate TCP and other transport > protocols directly and securely in UDP. > > The goal of this work is twofold: > > 1) Allow applications to run their own transport layer stack (i.e.from >userspace). This

Re: [net-next PATCH v3 06/17] bnxt: Move GENEVE support from hard-coded port to using port notifier

2016-06-16 Thread Michael Chan
On Thu, Jun 16, 2016 at 12:21 PM, Alexander Duyck wrote: > The port number for GENEVE is hard coded into the bnxt driver. This is the > kind of thing we want to avoid going forward. For now I will integrate > this back into the port notifier so that we can change the GENEVE

Re: [net-next PATCH v3 01/17] vxlan/geneve: Include udp_tunnel.h in vxlan/geneve.h and fixup includes

2016-06-16 Thread Hannes Frederic Sowa
On 16.06.2016 21:20, Alexander Duyck wrote: > This patch makes it so that we add udp_tunnel.h to vxlan.h and geneve.h > header files. This is useful as I plan to move the generic handlers for > the port offloads into the udp_tunnel header file and leave the vxlan and > geneve headers to be a bit

Re: [net-next PATCH v3 17/17] vxlan: Add new UDP encapsulation offload type for VXLAN-GPE

2016-06-16 Thread Hannes Frederic Sowa
On 16.06.2016 21:23, Alexander Duyck wrote: > The fact is VXLAN with Generic Protocol Extensions cannot be supported by > the same hardware parsers that support VXLAN. The protocol extensions > allow for things like a Next Protocol field which in turn allows for things > other than Ethernet to be

Re: [net-next PATCH v3 16/17] net: Remove deprecated tunnel specific UDP offload functions

2016-06-16 Thread Hannes Frederic Sowa
On 16.06.2016 21:23, Alexander Duyck wrote: > Now that we have all the drivers using udp_tunnel_get_rx_ports, > ndo_add_udp_enc_rx_port, and ndo_del_udp_enc_rx_port we can drop the > function calls that were specific to VXLAN and GENEVE. > > Signed-off-by: Alexander Duyck

Re: [net-next PATCH v3 03/17] net: Merge VXLAN and GENEVE push notifiers into a single notifier

2016-06-16 Thread Hannes Frederic Sowa
On 16.06.2016 21:21, Alexander Duyck wrote: > This patch merges the notifiers for VXLAN and GENEVE into a single UDP > tunnel notifier. The idea is that we will want to only have to make one > notifier call to receive the list of ports for VXLAN and GENEVE tunnels > that need to be offloaded. >

Re: [net-next PATCH v3 02/17] net: Combine GENEVE and VXLAN port notifiers into single functions

2016-06-16 Thread Hannes Frederic Sowa
On 16.06.2016 21:20, Alexander Duyck wrote: > This patch merges the GENEVE and VXLAN code so that both functions pass > through a shared code path. This way we can start the effort of using a > single function on the network device drivers to handle both of these > tunnel types. > >

Re: [BUG] act_ife: sleeping functions called in atomic context

2016-06-16 Thread Cong Wang
On Thu, Jun 16, 2016 at 1:50 PM, Alexey Khoroshilov wrote: > tcf_ife_init() contains a big chunk of code executed with > ife->tcf_lock spinlock held. But that code contains several calls > to sleeping functions: > populate_metalist() and use_all_metadata() > ->

Re: [PATCH RFC 1/3] ipv4: make flow functions more grepable by removing flowi4_init_output

2016-06-16 Thread Hannes Frederic Sowa
On 16.06.2016 23:18, David Miller wrote: > From: David Ahern > Date: Wed, 15 Jun 2016 14:29:28 -0600 > >> On 6/15/16 1:48 PM, David Miller wrote: >>> But if people don't use the helpers, and initialize flow structures >>> on their own, yeah that defeats the whole

Re: [PATCH net-next] sctp: change sk state to CLOSED instead of CLOSING in sctp_sock_migrate

2016-06-16 Thread David Miller
From: marcelo.leit...@gmail.com Date: Thu, 16 Jun 2016 18:13:22 -0300 > On Thu, Jun 16, 2016 at 02:11:39PM -0700, David Miller wrote: >> From: Xin Long >> Date: Thu, 16 Jun 2016 01:15:06 +0800 >> >> > Commit d46e416c11c8 ("sctp: sctp should change socket state when >> >

Re: [net PATCH] mlx4e: Do not attempt to offload VXLAN ports that are unrecognized

2016-06-16 Thread David Miller
From: Alexander Duyck Date: Wed, 15 Jun 2016 14:42:11 -0700 > The mlx4e driver does not support more than one port for VXLAN offload. As > such expecting the hardware to offload other ports is invalid since it > appears the parsing logic is used to perform Tx checksum and

Re: [PATCH] net: sfc: avoid -Wtype-limits warning

2016-06-16 Thread David Miller
From: Arnd Bergmann Date: Wed, 15 Jun 2016 22:31:10 +0200 > When building with -Wextra, we get a harmless warning from the > EFX_EXTRACT_OWORD32 macro: > > ethernet/sfc/farch.c: In function 'efx_farch_test_registers': > ethernet/sfc/farch.c:119:30: error: comparison of unsigned

[PATCH net-next] net, cls: also reject deleting all filters when TCA_KIND present

2016-06-16 Thread Daniel Borkmann
When we check for RTM_DELTFILTER, we should also reject the request for deleting all filters under a given parent when TCA_KIND attribute is present. If present, it's currently just ignored but there's also no point to let it pass in the first place either since this doesn't have any meaning with

[PATCH] net: lantiq_etop: remove unused variable

2016-06-16 Thread Sudip Mukherjee
The variable i was declared but was never used and we were getting a build warning for that. Signed-off-by: Sudip Mukherjee --- drivers/net/ethernet/lantiq_etop.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/lantiq_etop.c

Re: [PATCH RFC 1/3] ipv4: make flow functions more grepable by removing flowi4_init_output

2016-06-16 Thread David Miller
From: David Ahern Date: Wed, 15 Jun 2016 14:29:28 -0600 > On 6/15/16 1:48 PM, David Miller wrote: >> But if people don't use the helpers, and initialize flow structures >> on their own, yeah that defeats the whole mechanism and things will >> seem harder and

Re: [PATCH v2 0/3] net: stmmac: dwmac-rk: fixes for Wake-on-Lan on RK3288

2016-06-16 Thread David Miller
From: Vincent Palatin Date: Wed, 15 Jun 2016 11:32:20 -0700 > In order to support Wake-On-Lan when using the RK3288 integrated MAC > (with an external RGMII PHY), we need to avoid shutting down the regulator > of the external PHY when the MAC is suspended as it's currently

Re: [PATCH net-next] sctp: change sk state to CLOSED instead of CLOSING in sctp_sock_migrate

2016-06-16 Thread marcelo . leitner
On Thu, Jun 16, 2016 at 02:11:39PM -0700, David Miller wrote: > From: Xin Long > Date: Thu, 16 Jun 2016 01:15:06 +0800 > > > Commit d46e416c11c8 ("sctp: sctp should change socket state when > > shutdown is received") may set sk_state CLOSING in sctp_sock_migrate, > > but

Re: [PATCH net-next] sctp: change sk state to CLOSED instead of CLOSING in sctp_sock_migrate

2016-06-16 Thread David Miller
From: Xin Long Date: Thu, 16 Jun 2016 01:15:06 +0800 > Commit d46e416c11c8 ("sctp: sctp should change socket state when > shutdown is received") may set sk_state CLOSING in sctp_sock_migrate, > but inet_accept doesn't allow the sk_state other than ESTABLISHED/ > CLOSED for

Re: [CRIU] TCP_REPAIR MSS issue

2016-06-16 Thread Andrey Vagin
On Thu, Jun 16, 2016 at 07:51:22AM +, Eggert, Lars wrote: > Hi, > > On 2016-06-14, at 23:21, Andrey Vagin wrote: > > On my host, I see that dst is set in tcp_v4_connect() -> sk_setup_caps() > > sorry, are you saying that you don't see the issue with

Re: [PATCH] Add comment to warn about deprecated netlink rings attribute request

2016-06-16 Thread David Miller
From: Fabien Siron Date: Wed, 15 Jun 2016 15:37:49 + > Signed-off-by: Fabien Siron Applied.

[BUG] act_ife: sleeping functions called in atomic context

2016-06-16 Thread Alexey Khoroshilov
tcf_ife_init() contains a big chunk of code executed with ife->tcf_lock spinlock held. But that code contains several calls to sleeping functions: populate_metalist() and use_all_metadata() -> add_metainfo() -> find_ife_oplist(metaid) -> read_lock() ->

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-06-16 Thread Francois Romieu
Netanel Belgazal : [...] Very limited review below. > diff --git a/Documentation/networking/ena.txt > b/Documentation/networking/ena.txt > new file mode 100644 > index 000..528544f > --- /dev/null > +++ b/Documentation/networking/ena.txt > @@ -0,0 +1,330 @@ >

Re: [PATCH net-next 1/8] net: Change SKB_GSO_DODGY to be a tx_flag

2016-06-16 Thread Alexander Duyck
On Thu, Jun 16, 2016 at 1:18 PM, Tom Herbert wrote: > On Thu, Jun 16, 2016 at 11:58 AM, Alexander Duyck > wrote: >> On Thu, Jun 16, 2016 at 10:51 AM, Tom Herbert wrote: >>> This replaces gso_type SKB_GSO_DODGY with a new

Re: [PATCH net-next 1/8] net: Change SKB_GSO_DODGY to be a tx_flag

2016-06-16 Thread Tom Herbert
On Thu, Jun 16, 2016 at 11:58 AM, Alexander Duyck wrote: > On Thu, Jun 16, 2016 at 10:51 AM, Tom Herbert wrote: >> This replaces gso_type SKB_GSO_DODGY with a new tx_flag named >> SKBTX_UNTRUSTED_SOURCE. This more generically desrcibes the skb >>

Re: [PATCH 1/2] net: smsc911x: Fix bug where PHY interrupts are overwritten by 0

2016-06-16 Thread Sergei Shtylyov
On 06/16/2016 09:55 PM, Sergei Shtylyov wrote: By default, mdiobus_alloc() sets the PHY's to polling mode, but a Rather "PHYs". pointer size memcpy means that couple IRQs (depending Could be more words on this line, it's broken too early, I think. on 32-bit or 64-bit kernels) end

[net-next PATCH v3 12/17] mlx5_en: Replace ndo_add/del_vxlan_port with ndo_add/del_udp_enc_port

2016-06-16 Thread Alexander Duyck
This change replaces the network device operations for adding or removing a VXLAN port with operations that are more generically defined to be used for any UDP offload port but provide a type. As such by just adding a line to verify that the offload type is VXLAN we can maintain the same

[net-next PATCH v3 13/17] nfp: Replace ndo_add/del_vxlan_port with ndo_add/del_udp_enc_port

2016-06-16 Thread Alexander Duyck
This change replaces the network device operations for adding or removing a VXLAN port with operations that are more generically defined to be used for any UDP offload port but provide a type. As such by just adding a line to verify that the offload type is VXLAN we can maintain the same

[net-next PATCH v3 17/17] vxlan: Add new UDP encapsulation offload type for VXLAN-GPE

2016-06-16 Thread Alexander Duyck
The fact is VXLAN with Generic Protocol Extensions cannot be supported by the same hardware parsers that support VXLAN. The protocol extensions allow for things like a Next Protocol field which in turn allows for things other than Ethernet to be passed over the tunnel. Most existing parsers will

[net-next PATCH v3 14/17] qede: Move all UDP port notifiers to single function

2016-06-16 Thread Alexander Duyck
This patch goes through and combines the notifiers for VXLAN and GENEVE into a single function for each action. So there is now one combined function for getting ports, one for adding the ports, and one for deleting the ports. Signed-off-by: Alexander Duyck ---

[net-next PATCH v3 16/17] net: Remove deprecated tunnel specific UDP offload functions

2016-06-16 Thread Alexander Duyck
Now that we have all the drivers using udp_tunnel_get_rx_ports, ndo_add_udp_enc_rx_port, and ndo_del_udp_enc_rx_port we can drop the function calls that were specific to VXLAN and GENEVE. Signed-off-by: Alexander Duyck --- include/linux/netdevice.h | 38

[net-next PATCH v3 15/17] qlcnic: Replace ndo_add/del_vxlan_port with ndo_add/del_udp_enc_port

2016-06-16 Thread Alexander Duyck
This change replaces the network device operations for adding or removing a VXLAN port with operations that are more generically defined to be used for any UDP offload port but provide a type. As such by just adding a line to verify that the offload type is VXLAN we can maintain the same

[net-next PATCH v3 08/17] fm10k: Replace ndo_add/del_vxlan_port with ndo_add/del_udp_enc_port

2016-06-16 Thread Alexander Duyck
This change replaces the network device operations for adding or removing a VXLAN port with operations that are more generically defined to be used for any UDP offload port but provide a type. As such by just adding a line to verify that the offload type if VXLAN we can maintain the same

[net-next PATCH v3 10/17] ixgbe: Replace ndo_add/del_vxlan_port with ndo_add/del_udp_enc_port

2016-06-16 Thread Alexander Duyck
This change replaces the network device operations for adding or removing a VXLAN port with operations that are more generically defined to be used for any UDP offload port but provide a type. As such by just adding a line to verify that the offload type is VXLAN we can maintain the same

[net-next PATCH v3 11/17] mlx4_en: Replace ndo_add/del_vxlan_port with ndo_add/del_udp_enc_port

2016-06-16 Thread Alexander Duyck
This change replaces the network device operations for adding or removing a VXLAN port with operations that are more generically defined to be used for any UDP offload port but provide a type. As such by just adding a line to verify that the offload type is VXLAN we can maintain the same

[net-next PATCH v3 09/17] i40e: Move all UDP port notifiers to single function

2016-06-16 Thread Alexander Duyck
This patch goes through and combines the notifiers for VXLAN and GENEVE into a single function for each action. So there is now one combined function for getting ports, one for adding the ports, and one for deleting the ports. Signed-off-by: Alexander Duyck ---

[net-next PATCH v3 05/17] bnxt: Update drivers to support unified UDP encapsulation offload functions

2016-06-16 Thread Alexander Duyck
This patch ends up doing several things. First it updates the driver to make use of the new unified UDP tunnel offload notifier functions. In addition I updated the code so that we can work around the bits that were checking for if VXLAN was enabled since we are now using a notifier based setup.

[net-next PATCH v3 00/17] Future-proof tunnel offload handlers

2016-06-16 Thread Alexander Duyck
s patch is meant to address two things. First we are currently using the ndo_add/del_vxlan_port calls with VXLAN-GPE tunnels and we cannot really support that as it is likely to cause more harm than good since VXLAN-GPE can support tunnels without a MAC address on the inner header. As such we

[net-next PATCH v3 02/17] net: Combine GENEVE and VXLAN port notifiers into single functions

2016-06-16 Thread Alexander Duyck
This patch merges the GENEVE and VXLAN code so that both functions pass through a shared code path. This way we can start the effort of using a single function on the network device drivers to handle both of these tunnel types. Signed-off-by: Alexander Duyck ---

[net-next PATCH v3 03/17] net: Merge VXLAN and GENEVE push notifiers into a single notifier

2016-06-16 Thread Alexander Duyck
This patch merges the notifiers for VXLAN and GENEVE into a single UDP tunnel notifier. The idea is that we will want to only have to make one notifier call to receive the list of ports for VXLAN and GENEVE tunnels that need to be offloaded. In addition we add a new set of ndo functions named

[net-next PATCH v3 07/17] benet: Replace ndo_add/del_vxlan_port with ndo_add/del_udp_enc_port

2016-06-16 Thread Alexander Duyck
This change replaces the network device operations for adding or removing a VXLAN port with operations that are more generically defined to be used for any UDP offload port but provide a type. As such by just adding a line to verify that the offload type if VXLAN we can maintain the same

[net-next PATCH v3 04/17] bnx2x: Move all UDP port notifiers to single function

2016-06-16 Thread Alexander Duyck
This patch goes through and combines the notifiers for VXLAN and GENEVE into a single function for each action. So there is now one combined function for getting ports, one for adding the ports, and one for deleting the ports. I also went through and dropped the BNX2X VXLAN and GENEVE specific

[net-next PATCH v3 06/17] bnxt: Move GENEVE support from hard-coded port to using port notifier

2016-06-16 Thread Alexander Duyck
The port number for GENEVE is hard coded into the bnxt driver. This is the kind of thing we want to avoid going forward. For now I will integrate this back into the port notifier so that we can change the GENEVE port number if we need to in the future. Signed-off-by: Alexander Duyck

[net-next PATCH v3 01/17] vxlan/geneve: Include udp_tunnel.h in vxlan/geneve.h and fixup includes

2016-06-16 Thread Alexander Duyck
This patch makes it so that we add udp_tunnel.h to vxlan.h and geneve.h header files. This is useful as I plan to move the generic handlers for the port offloads into the udp_tunnel header file and leave the vxlan and geneve headers to be a bit more protocol specific. I also went through and

Re: [PATCH net-next 1/8] net: Change SKB_GSO_DODGY to be a tx_flag

2016-06-16 Thread Alexander Duyck
On Thu, Jun 16, 2016 at 10:51 AM, Tom Herbert wrote: > This replaces gso_type SKB_GSO_DODGY with a new tx_flag named > SKBTX_UNTRUSTED_SOURCE. This more generically desrcibes the skb > being created from a untrusted source as a characteristic of and skbuff. > This also frees

Re: [PATCH 1/2] net: smsc911x: Fix bug where PHY interrupts are overwritten by 0

2016-06-16 Thread Sergei Shtylyov
On 06/16/2016 06:54 PM, Jeremy Linton wrote: By default, mdiobus_alloc() sets the PHY's to polling mode, but a Rather "PHYs". pointer size memcpy means that couple IRQs (depending Could be more words on this line, it's broken too early, I think. on 32-bit or 64-bit kernels) end up

rfc: netfilter: Unhide FWINV macro arguments ?

2016-06-16 Thread Joe Perches
There are several FWINV #defines with identical form that hide a specific structure variable and dereference it with a invflags member. $ git grep "define FWINV" include/linux/netfilter_bridge/ebtables.h:#define FWINV(bool,invflg) ((bool) ^ !!(info->invflags & invflg))

[net-next,v2] openvswitch: Add skb->len info to upcall.

2016-06-16 Thread William Tu
The commit f2a4d086ed4c ("openvswitch: Add packet truncation support.") introduces packet truncation before sending to userspace upcall receiver. This patch passes up the skb->len before truncation so that the upcall receiver knows the original packet size. Potentially this will be used by sFlow,

Re: [PATCH 6/8] net: gianfar: fix old-style declaration

2016-06-16 Thread Joe Perches
On Thu, 2016-06-16 at 21:02 +0300, Sergei Shtylyov wrote: > On 06/16/2016 04:52 PM, Arnd Bergmann wrote: > > Modern C standards expect the '__inline__' keyword to come before the return > > type in a declaration, and we get a warning for this with "make W=1": [] > > diff --git

Re: [PATCH net-next 0/8] tou: Transports over UDP - part I

2016-06-16 Thread Rick Jones
On 06/16/2016 10:51 AM, Tom Herbert wrote: Note that #1 is really about running a transport stack in userspace applications in clients, not necessarily servers. For servers we intend to modified the kernel stack in order to leverage existing implementation for building scalable serves (hence

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-06-16 Thread Ben Hutchings
On Thu, 2016-06-16 at 10:55 -0700, Benjamin Poirier wrote: > On 2016/06/13 11:46, Netanel Belgazal wrote: [...] > > +static ssize_t ena_show_small_copy_len(struct device *dev, > > +    struct device_attribute *attr, char *buf) > > +{ > > + struct ena_adapter

Re: [PATCH 6/8] net: gianfar: fix old-style declaration

2016-06-16 Thread Sergei Shtylyov
Hello. On 06/16/2016 04:52 PM, Arnd Bergmann wrote: Modern C standards expect the '__inline__' keyword to come before the return type in a declaration, and we get a warning for this with "make W=1": drivers/net/ethernet/freescale/gianfar.c:2278:1: error: 'inline' is not at beginning of

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-06-16 Thread Benjamin Poirier
On 2016/06/13 11:46, Netanel Belgazal wrote: [...] > + > +static int ena_set_coalesce(struct net_device *net_dev, > + struct ethtool_coalesce *coalesce) > +{ > + struct ena_adapter *adapter = netdev_priv(net_dev); > + struct ena_com_dev *ena_dev = adapter->ena_dev;

Re: [PATCH] dsa: b53: fix big-endian register access

2016-06-16 Thread Florian Fainelli
On 06/16/2016 02:00 AM, Arnd Bergmann wrote: > The b53 dsa register access confusingly uses __raw register accessors > when both the CPU and the device are big-endian, but it uses little- > endian accessors when the same device is used from a little-endian > CPU, which makes no sense. > > This

[PATCH net-next v5 5/7] vmxnet3: add support for get_coalesce, set_coalesce ethtool operations

2016-06-16 Thread Shrikrishna Khare
The emulation supports a variety of coalescing modes viz. disabled (no coalescing), adaptive, static (number of packets to batch before raising an interrupt), rate based (number of interrupts per second). This patch implements get_coalesce and set_coalesce methods to allow querying and

[PATCH net-next v5 3/7] vmxnet3: allow variable length transmit data ring buffer

2016-06-16 Thread Shrikrishna Khare
vmxnet3 driver supports transmit data ring viz. a set of fixed size buffers used by the driver to copy packet headers. Small packets that fit these buffers are copied into these buffers entirely. Currently this buffer size of fixed at 128 bytes. This patch extends transmit data ring

[PATCH net-next v5 0/7] vmxnet3: upgrade to version 3

2016-06-16 Thread Shrikrishna Khare
vmxnet3 emulation has recently added several new features which includes support for new commands the driver can issue to emulation, change in descriptor fields etc. This patch series extends the vmxnet3 driver to leverage these new features. Compatibility is maintained using existing vmxnet3

[PATCH net-next v5 1/7] vmxnet3: prepare for version 3 changes

2016-06-16 Thread Shrikrishna Khare
vmxnet3 is currently at version 2, but some command definitions from previous vmxnet3 versions are missing. Add those definitions before moving to version 3. Also, introduce utility macros for vmxnet3 version comparison and update Copyright information and Maintained by. Signed-off-by:

[PATCH net-next v5 7/7] vmxnet3: update to version 3

2016-06-16 Thread Shrikrishna Khare
With all vmxnet3 version 3 changes incorporated in the vmxnet3 driver, the driver can configure emulation to run at vmxnet3 version 3, provided the emulation advertises support for version 3. Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_drv.c | 7 ++-

  1   2   3   >