Re: tcp md5: one more crypto-sg-on-the-stack instance

On Sat, 2016-06-25 at 06:26 +0200, Eric Dumazet wrote: > On Sat, 2016-06-25 at 06:11 +0200, Eric Dumazet wrote: > > > Simply extend tcp_md5sig_pool to contain a copy of the TCP headers ? > > > > At most 40 bytes of extra per cpu storage is not a big problem. > > > > Correction : This is

Re: tcp md5: one more crypto-sg-on-the-stack instance

On Sat, 2016-06-25 at 06:11 +0200, Eric Dumazet wrote: > Simply extend tcp_md5sig_pool to contain a copy of the TCP headers ? > > At most 40 bytes of extra per cpu storage is not a big problem. > Correction : This is exactly 20 bytes for tcphdr, not 40.

Re: tcp md5: one more crypto-sg-on-the-stack instance

On Fri, 2016-06-24 at 18:51 -0700, Andy Lutomirski wrote: > Hi all- > > tcp_md5_hash_header does crypto using an sg that points to the stack. > This will break with virtually mapped stacks. It also looks like it's > probably much slower than it deserves to be (it's trying to compute > the MD5

[PATCH] notifier: Fix soft lockup for notifier_call_chain().

The problem was occurs in my system that a lot of drviers register its own handler to the notifier call chain for netdev_chain, and then create 4095 vlan dev for one nic, and add several ipv6 address on each one of them, just like this: for i in `seq 1 4095`; do ip link add link eth0 name eth0.$i

[RFC] tun: Support VIRTIO_NET_HDR_F_DATA_VALID in tun_get_user

Userspace applications might sometimes process packets from hardware which has already validated checksum, perform trivial operations and then queue them back to the network stack. By not recomputing the checksum here, we can see significant improvement in performance. Sample application here is

tcp md5: one more crypto-sg-on-the-stack instance

Hi all- tcp_md5_hash_header does crypto using an sg that points to the stack. This will break with virtually mapped stacks. It also looks like it's probably much slower than it deserves to be (it's trying to compute the MD5 hash of a few tens of bytes -- going through a scatterlist is a lot of

DMA from stack in virtio_net and virtio_console

virtio_net does DMA on the stack when it calls sg_init_one in virtio_set_queues, virtnet_vlan_rx_add_vid, and virtnet_vlan_rx_kill_vid. Michael, I think these are examples we missed somehow when fixing these issues earlier on. virtio_console does it here: sg_init_one(sg, , sizeof(cpkt)); This

[perf core] c5dfd78eb7: BUG: unable to handle kernel NULL pointer dereference at 00000c40

3 Merge tag 'upstream-4.7-rc5' of git://git.infradead.org/linux-ubifs # extra tests on tree/branch linus/master git bisect bad 63c04ee7d3b7c8d8e2726cb7c5f8a5f6fcc1e3b2 # 08:23 0- 5 Merge tag 'upstream-

Re: [PATCH net-next 0/8] tou: Transports over UDP - part I

On 06/24/2016 04:43 PM, Tom Herbert wrote: Here's Christoph's slides on TFO in the wild which presents a good summary of the middlebox problem. There is one significant difference in that ECN needs network support whereas TFO didn't. Given that experience, I'm doubtful other new features at L4

[PATCH] [v6] net: emac: emac gigabit ethernet controller driver

Add supports for ethernet controller HW on Qualcomm Technologies, Inc. SoC. This driver supports the following features: 1) Checksum offload. 2) Interrupt coalescing support. 3) SGMII phy. 4) phylib interface for external phy Based on original work by Niranjana Vishwanathapura

Re: [PATCH net-next 0/8] tou: Transports over UDP - part I

On Fri, Jun 24, 2016 at 3:06 PM, Rick Jones wrote: > On 06/24/2016 02:46 PM, Tom Herbert wrote: >> >> On Fri, Jun 24, 2016 at 2:36 PM, Rick Jones wrote: >>> >>> How would you define "severely?" Has it actually been more severe than >>> for >>> say ECN?

[PATCH] net: phy: Manage fixed PHY address space using IDA

If we have a system which uses fixed PHY devices and calls fixed_phy_register() then fixed_phy_unregister() we can exhaust the number of fixed PHYs available after a while, since we keep incrementing the variable phy_fixed_addr, but we never decrement it. This patch fixes that by converting the

Re: [PATCH net] net: phy: Decrement phy_fixed_addr during unregister

On 06/24/2016 04:06 PM, Russell King - ARM Linux wrote: > On Fri, Jun 24, 2016 at 03:58:39PM -0700, Florian Fainelli wrote: >> On 06/24/2016 03:55 PM, Russell King - ARM Linux wrote: >>> On Fri, Jun 24, 2016 at 03:44:11PM -0700, Florian Fainelli wrote: If we have a system which uses fixed PHY

Re: [PATCH net] net: phy: Decrement phy_fixed_addr during unregister

On Fri, Jun 24, 2016 at 03:58:39PM -0700, Florian Fainelli wrote: > On 06/24/2016 03:55 PM, Russell King - ARM Linux wrote: > > On Fri, Jun 24, 2016 at 03:44:11PM -0700, Florian Fainelli wrote: > >> If we have a system which uses fixed PHY devices and calls > >> fixed_phy_register() then

Re: [PATCH net] net: phy: Decrement phy_fixed_addr during unregister

On 06/24/2016 03:55 PM, Russell King - ARM Linux wrote: > On Fri, Jun 24, 2016 at 03:44:11PM -0700, Florian Fainelli wrote: >> If we have a system which uses fixed PHY devices and calls >> fixed_phy_register() then fixed_phy_unregister() we can exhaust the >> number of fixed PHYs available after a

[PATCH] samples/bpf: set resource limit to infinity.

Signed-off-by: William Tu --- samples/bpf/test_maps.c | 4 1 file changed, 4 insertions(+) diff --git a/samples/bpf/test_maps.c b/samples/bpf/test_maps.c index 47bf085..d2bc96e 100644 --- a/samples/bpf/test_maps.c +++ b/samples/bpf/test_maps.c @@ -16,6 +16,7 @@

Re: [PATCH net] net: phy: Decrement phy_fixed_addr during unregister

On Fri, Jun 24, 2016 at 03:44:11PM -0700, Florian Fainelli wrote: > If we have a system which uses fixed PHY devices and calls > fixed_phy_register() then fixed_phy_unregister() we can exhaust the > number of fixed PHYs available after a while, since we keep incrementing > the variable

[PATCH net] net: phy: Decrement phy_fixed_addr during unregister

If we have a system which uses fixed PHY devices and calls fixed_phy_register() then fixed_phy_unregister() we can exhaust the number of fixed PHYs available after a while, since we keep incrementing the variable phy_fixed_addr, but we never decrement it. This patch fixes that by decrementing

Re: [PATCH net] sock_diag: invert socket destroy broadcast check

On Fri, Jun 24, 2016 at 4:41 PM, Eric W. Biederman wrote: > Willem de Bruijn writes: > >> From: Willem de Bruijn >> >> Socket destruction is only broadcast for a socket sk if a diag >> listener is registered and sk is

Re: [PATCH net-next 0/8] tou: Transports over UDP - part I

On 06/24/2016 02:46 PM, Tom Herbert wrote: On Fri, Jun 24, 2016 at 2:36 PM, Rick Jones wrote: How would you define "severely?" Has it actually been more severe than for say ECN? Or it was for say SACK or PAWS? ECN is probably even a bigger disappointment in terms of

Re: switch / linux STP interoperation issues.

On 2016-06-24 23:09, Elad Raz wrote: On Fri, Jun 24, 2016 at 10:14 PM, Michal Soltys wrote: Hi, The switch respected BPDUs sent to it (if applicable) - for example it complied properly if it's priority was less (numerically higher) than linux's - showing linux box as root

Re: [PATCH net-next 0/8] tou: Transports over UDP - part I

On Fri, Jun 24, 2016 at 2:36 PM, Rick Jones wrote: > On 06/24/2016 02:12 PM, Tom Herbert wrote: >> >> The client OS side is only part of the story. Middlebox intrusion at >> L4 is also a major issue we need to address. The "failure" of TFO is a >> good case study. Both the

Re: [PATCH net-next 0/8] tou: Transports over UDP - part I

On 06/24/2016 02:12 PM, Tom Herbert wrote: The client OS side is only part of the story. Middlebox intrusion at L4 is also a major issue we need to address. The "failure" of TFO is a good case study. Both the upgrade issues on clients and the tendency for some middleboxes to drop SYN packets

Re: [PATCH net-next 0/8] tou: Transports over UDP - part I

On Thu, Jun 23, 2016 at 12:50 AM, Richard Weinberger wrote: > Am 23.06.2016 um 09:40 schrieb David Miller: >> From: Richard Weinberger >> Date: Thu, 23 Jun 2016 00:15:04 +0200 >> >>> On Thu, Jun 16, 2016 at 7:51 PM, Tom Herbert

Re: switch / linux STP interoperation issues.

On Fri, Jun 24, 2016 at 10:14 PM, Michal Soltys wrote: > Hi, > > In the last week I've been trying to get STP on the linux side (both its > builtin STP implementation as well as mstpd userspace daemon). Initially I > started with more complex setups (vlan aware bridge, bonds,

Re: [PATCH] mac80211_hwsim: Added vendor echo command

On Fri, Jun 24, 2016 at 10:13:54AM +0200, Erik Stromdahl wrote: > The purpose of the echo command is to provide a test > facility for user space programs. > diff --git a/drivers/net/wireless/mac80211_hwsim.c > b/drivers/net/wireless/mac80211_hwsim.c > @@ -332,14 +332,16 @@ static const struct

Re: [PATCH net] sock_diag: invert socket destroy broadcast check

Willem de Bruijn writes: > From: Willem de Bruijn > > Socket destruction is only broadcast for a socket sk if a diag > listener is registered and sk is not a kernel socket. > > Invert the test to not even check for listeners for kernel

[PATCH v3] netfilter/nflog: nflog-range does not truncate packets (userspace)

Added tests to libxt_NFLOG.t for the new option --nflog-size -- netfilter/nflog: nflog-range does not truncate packets The option --nflog-range has never worked, but we cannot just fix this because users might be using this feature option and their behavior would change. Instead add a new

[PATCH] netfilter: Convert FWINV<[foo]> macros and uses to NF_INVF

netfilter uses multiple FWINV #defines with identical form that hide a specific structure variable and dereference it with a invflags member. $ git grep "#define FWINV" include/linux/netfilter_bridge/ebtables.h:#define FWINV(bool,invflg) ((bool) ^ !!(info->invflags & invflg))

[PATCH net] sock_diag: invert socket destroy broadcast check

From: Willem de Bruijn Socket destruction is only broadcast for a socket sk if a diag listener is registered and sk is not a kernel socket. Invert the test to not even check for listeners for kernel sockets. The sock_diag_has_destroy_listeners invocation dereferences

[PATCH net] sock_diag: do not broadcast raw socket destruction

From: Willem de Bruijn Diag intends to broadcast tcp_sk and udp_sk socket destruction. Testing sk->sk_protocol for IPPROTO_TCP/IPPROTO_UDP alone is not sufficient for this. Raw sockets can have the same type. Add a test for sk->sk_type. Fixes: eb4cb008529c ("sock_diag:

Re: [PATCH] Maxim/driver: Add driver for maxim ds26522

From: Qiang Zhao Date: Fri, 24 Jun 2016 02:00:33 + > On Thu, 2016-06-23 at 10:59PM, David Miller wrote: >> -Original Message- >> From: David Miller [mailto:da...@davemloft.net] >> Sent: Thursday, June 23, 2016 10:59 PM >> To: Qiang Zhao >> Cc:

switch / linux STP interoperation issues.

Hi, In the last week I've been trying to get STP on the linux side (both its builtin STP implementation as well as mstpd userspace daemon). Initially I started with more complex setups (vlan aware bridge, bonds, mst) and gradually (with identical problems on each step) ended with the most

Re: [PATCH] net: ethernet: ti: cpdma: switch to use genalloc

On Fri, Jun 24, 2016 at 07:58:32PM +0300, Grygorii Strashko wrote: > Oh. nice :( So, seems, I'd need to send v3. Right? > By the way, this code hasn't been introduced by this patch - I've > just moved whole function from one place to another. Well since it is moving I would think that was a handy

[PATCH] etherdevice.h & bridge: netfilter: Add and use ether_addr_equal_masked

There are code duplications of a masked ethernet address comparison here so make it a separate function instead. Miscellanea: o Neaten alignment of FWINV macro uses to make it clearer for the reader Signed-off-by: Joe Perches --- include/linux/etherdevice.h | 23

[PATCH v2 01/15] drivers: net: cpsw: fix suspend when all ethX devices are down

The cpsw_suspend() could trigger L3 error and CPSW will stop functioning if System enters suspend when all ethX net-devices are down - in this case CPSW could be already suspended by PM runtime, but cpsw_suspend() will try to call soft_reset_slave() unconditionally and access CPSW registers.

[PATCH v2 02/15] drivers: net: cpsw: check return code from pm runtime calls

Add missed check of return code from PM runtime get() calls. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ti/cpsw.c

[PATCH v2 00/15] drivers: net: cpsw: improve runtime pm

This series intended to improve runtime PM and allow CPSW to be RPM suspended when all ethX netdevices are down. To achieve above goal it is required to relax runtime PM constraints for Davinci MDIO which blocks CPSW runtime PM now, because Davinci MDIO is always powered on during probe and

[PATCH v2 03/15] drivers: net: cpsw: remove pm runtime calls from suspend callbacks

PM runtime is properly handled in cpsw_ndo_open/stop(), as result it isn't required to duplicate these calls in .suspend()/.resume() callbacks. Moreover, it might cause unnecessary RPM resume of CPSW during System suspend in the case it's already suspended because all ethX interfaces are down

[PATCH v2 05/15] drivers: net: cpsw: ndev: fix accessing to suspended device

The CPSW might be suspended by RPM if all ethX interfaces are down, but it still could be accesible through net_device_ops interfce. In this case net_device_ops operations requiring registers access will cause L3 errors and CPSW crash. Hence, fix it by adding RPM get/put calls in net_device_ops

[PATCH v2 11/15] drivers: net: davinci_mdio: implement pm runtime auto mode

Davinci MDIO is always used as slave device which services read/write requests from MDIO/PHY core. It doesn't use IRQ also. As result, It's possible to relax PM runtime constraints for Davinci MDIO and enable it on demand, instead of powering it during probe and powering off during removal.

[PATCH v2 09/15] drivers: net: davinci_mdio: split reset function on init_clk and enable

The Davinci MDIO MDIO_CONTROL.CLKDIV can be calculated only once during probe, hence split __davinci_mdio_reset() on davinci_mdio_init_clk() and davinci_mdio_enable(). Initialize and save CLKDIV in .probe(). Then just use saved value. Signed-off-by: Grygorii Strashko

[PATCH v2 04/15] drivers: net: cpsw: ethtool: fix accessing to suspended device

The CPSW might be suspended by RPM if all ethX interfaces are down, but it still could be accesible through ethtool interfce. In this case ethtool operations, requiring registers access, will cause L3 errors and CPSW crash. ethtool callbcaks which need to access CPSW registers now:

Re: [PATCH iptables 3/3] libxt_hashlimit: iptables-restore does not work as expected with xt_hashlimit

On 06/23/2016 06:25 AM, Pablo Neira Ayuso wrote: > On Wed, Jun 01, 2016 at 08:17:59PM -0400, Vishwanath Pai wrote: >> libxt_hashlimit: iptables-restore does not work as expected with xt_hashlimit >> >> Add the following iptables rule. >> >> $ iptables -A INPUT -m hashlimit --hashlimit-above

[PATCH v2 06/15] drivers: net: davinci_mdio: do pm runtime initialization later in probe

Do PM runtime initialization later in probe - this allows to simplify error handling a bit. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/davinci_mdio.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git

[PATCH v2 07/15] drivers: net: davinci_mdio: remove pm runtime calls from suspend callbacks

PM runtime is disabled when Davinci MDIO .suspend_late() and .resume_early() callbacks are called. As result, any PM runtime calls here will be just a nop and can be removed. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/davinci_mdio.c | 3 --- 1 file

[PATCH v2 10/15] drivers: net: davinci_mdio: add pm runtime callbacks

Add PM runtime .runtime_suspend()/.runtime_resume() callbacks and perform Davinci MDIO enabling/disabling from these callbacks. This allows to reuse pm_runtime_force_suspend/resume() APIs during System suspend and required for further implementation of PM runtime autosuspend. Signed-off-by:

[PATCH v2 13/15] net: davinci_mdio: introduce "ti,cpsw-mdio" compat string

Introduce "ti,cpsw-mdio" compatible string for Davinci MDIO, because it's required to distinguish the case when MDIO is part of TI CPSW to enable features supported by TI CPSW (for example, enable PM management). Signed-off-by: Grygorii Strashko ---

[PATCH v2 08/15] drivers: net: davinci_mdio: drop suspended and lock fields from mdio_data

It's not expected Davinci MDIO to be accessible after its suspend callbacks have been called: - all consumers of Davinci MDIO will stop/disconnect phys at Device suspend stage; - all phys are expected to be suspned already by PHY/MDIO core; - MDIO locking is done by MDIO Bus code. Hence, it's

[PATCH v2 12/15] net: davinci_mdio: document missed "ti,am4372-mdio" compat string

Document missed "ti,am4372-mdio" compat string used for TI am437x SoC (am4372.dtsi). Signed-off-by: Grygorii Strashko --- Documentation/devicetree/bindings/net/davinci-mdio.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH v2 14/15] drivers: net: davinci_mdio: enable pm runtime auto for ti cpsw-mdio

Use "ti,cpsw-mdio" to enable PM runtime auto-suspend on supported platforms, where MDIO is implemented as part of TI CPSW. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/davinci_mdio.c | 45 +- 1 file changed, 34

[PATCH v2 15/15] ARM: dts: am335x/am437x/dra7: use new "ti,cpsw-mdio" compat string

Add "ti,cpsw-mdio" for am335x/am437x/dra7 SoCs where MDIO is implemented as part of TI CPSW and, this way, enable PM runtime auto suspend for Davinci MDIO driver on these paltforms. Signed-off-by: Grygorii Strashko --- arch/arm/boot/dts/am33xx.dtsi | 2 +-

Re: [PATCH 3/8] wireless: ipw2200: fix old-style declaration

On 16 June 2016 at 17:52, Arnd Bergmann wrote: > Modern C standards expect the 'inline' keyword to come before the return > type in a declaration, and we get a warning for this with "make W=1": > > drivers/net/wireless/intel/ipw2x00/ipw2200.c:4096:1: error: 'inline' is not > at

Re: [PATCH net-next 0/5] qed/qede: Tunnel hardware GRO support

On 24/06/16 17:31, Tom Herbert wrote: > Ed, > Because you took this OT... ;-) > > LRO/GRO is the one of the five common offloads that has no generic > analogue and requires protocol specific logic. For instance each > IP-over-foo encapsulation needs kernel code for GRO, device/driver > code for

Re: [PATCH] net: ethernet: ti: cpdma: switch to use genalloc

On 06/24/2016 07:15 PM, Lennart Sorensen wrote: > On Fri, Jun 24, 2016 at 11:35:15AM +0530, Mugunthan V N wrote: +static void cpdma_desc_pool_destroy(struct cpdma_desc_pool *pool) +{ +if (!pool) +return; + +WARN_ON(pool->used_desc); +if

Re: [PATCH net-next 0/5] qed/qede: Tunnel hardware GRO support

On Thu, Jun 23, 2016 at 10:20 PM, Yuval Mintz wrote: >>We already know of one firmware bug you guys have which makes >>it clear that the bnx2x is not doing hardware assisted GRO it is doing >>something else since it performs much worse than GRO if the MSS is >>less than

Re: [PATCH net-next 0/5] qed/qede: Tunnel hardware GRO support

On Fri, Jun 24, 2016 at 6:09 AM, Edward Cree wrote: > On 23/06/16 18:07, Alexander Duyck wrote: >> I would prefer to see us extend LRO to support "close enough GRO" >> instead of have us extend GRO to also include LRO. > This reminds me of something I've been meaning to

[RFT][PATCH 2/2] phy: bcm-ns2-pcie: Set missing .owner field in ns2_pci_phy_ops

Add missing .owner field in ns2_pci_phy_ops, which is used for refcounting. While at it, also makes ns2_pci_phy_ops const as it's never modified. Signed-off-by: Axel Lin --- drivers/phy/phy-bcm-ns2-pcie.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[RFT][PATCH 1/2] phy: bcm-ns2-pcie: Get rid of struct ns2_pci_phy

By setting phy_set_drvdata(phy, mdiodev), struct ns2_pci_phy can be removed. Signed-off-by: Axel Lin --- I don't have this h/w. Appreciate if someone can test this patch serial. drivers/phy/phy-bcm-ns2-pcie.c | 25 + 1 file changed, 5 insertions(+),

Re: [REGRESSION, bisect]cxgb4 port failure with TSO traffic after commit 10d3be569243def8("tcp-tso: do not split TSO packets at retransmit time")

On Fri, 2016-06-24 at 07:25 -0700, Eric Dumazet wrote: > Please do not top post on netdev mailing list > > On Fri, Jun 24, 2016 at 4:38 AM, Arjun V. wrote: > > Eric, > > We are seeing skb's with length(skb->len) greater than 65536 coming into > > our ndo_start_xmit() callback

Re: [PATCH] net: ethernet: ti: cpdma: switch to use genalloc

On Fri, Jun 24, 2016 at 11:35:15AM +0530, Mugunthan V N wrote: > >> +static void cpdma_desc_pool_destroy(struct cpdma_desc_pool *pool) > >> +{ > >> +if (!pool) > >> +return; > >> + > >> +WARN_ON(pool->used_desc); > >> +if (pool->cpumap) { > >> +

Re: [PATCH v10 07/22] IB/hns: Add event queue support

On 06/24/2016 11:46 AM, Leon Romanovsky wrote: > On Thu, Jun 16, 2016 at 10:35:15PM +0800, Lijun Ou wrote: >> /*ROCEE_REG DEFINITION/ >> #define ROCEE_VENDOR_ID_REG 0x0 >> @@ -44,8 +93,29 @@ >> #define ROCEE_SYS_IMAGE_GUID_L_REG 0xC >>

Re: [PATCH v10 00/22] Add HiSilicon RoCE driver

On Thu, Jun 16, 2016 at 10:35:08PM +0800, Lijun Ou wrote: > The HiSilicon Network Substem is a long term evolution IP which is > supposed to be used in HiSilicon ICT SoCs. HNS (HiSilicon Network > Sybsystem) also has a hardware support of performing RDMA with > RoCEE. > The driver for HiSilicon

Re: [PATCH v10 09/22] IB/hns: Add hca support

On Thu, Jun 16, 2016 at 10:35:17PM +0800, Lijun Ou wrote: > This patch mainly setup hca for RoCE. It will do a series of > initial works, as follows: > 1. init uar table, allocate uar resource > 2. init pd table > 3. init cq table > 4. init mr table > 5. init qp table > >

Re: [PATCH v10 07/22] IB/hns: Add event queue support

On Thu, Jun 16, 2016 at 10:35:15PM +0800, Lijun Ou wrote: > This patch added event queue support for RoCE driver. It is used > for RoCE interrupt. RoCE includes 32 synchronous event irqs, 1 > asynchronous event irq and 1 common overflow irq. > > Signed-off-by: Wei Hu >

Re: [PATCH v10 05/22] IB/hns: Add initial profile resource

On Thu, Jun 16, 2016 at 10:35:13PM +0800, Lijun Ou wrote: > This patch added the operation for cmd, and added some functions > for initializing eq table and selecting cmd mode. > > Signed-off-by: Wei Hu > Signed-off-by: Nenglong Zhao >

Re: [PATCH v10 04/22] IB/hns: Add RoCE engine reset function

On Thu, Jun 16, 2016 at 10:35:12PM +0800, Lijun Ou wrote: > This patch mainly added reset flow of RoCE engine in RoCE > driver. It is necessary when RoCE is loaded and removed. > > Signed-off-by: Wei Hu > Signed-off-by: Nenglong Zhao >

Re: [ldv-project] [net] rtl8188ee: a potential race condition

On 06/24/2016 09:17 AM, Vaishali Thakkar wrote: On Friday 10 June 2016 01:51 PM, Pavel Andrianov wrote: Hi! There is a potential data race in drivers/net/wireless/realtek/rtlwifi/rtl8188ee/rtl8188ee.ko. In the function rtl88ee_gpio_radio_on_off_checking the flag ppsc->rfchange_inprogress

Re: [REGRESSION, bisect]cxgb4 port failure with TSO traffic after commit 10d3be569243def8("tcp-tso: do not split TSO packets at retransmit time")

Please do not top post on netdev mailing list On Fri, Jun 24, 2016 at 4:38 AM, Arjun V. wrote: > Eric, > We are seeing skb's with length(skb->len) greater than 65536 coming into our > ndo_start_xmit() callback routine. > We can add a check in our eth_xmit() routine to skip

Re: [ldv-project] [net] rtl8188ee: a potential race condition

On Friday 10 June 2016 01:51 PM, Pavel Andrianov wrote: > Hi! > > There is a potential data race in > drivers/net/wireless/realtek/rtlwifi/rtl8188ee/rtl8188ee.ko. > > In the function rtl88ee_gpio_radio_on_off_checking the flag > ppsc->rfchange_inprogress is set with a spinlock protection. In

Re: [PATCH] vsock: make listener child lock ordering explicit

> On Jun 23, 2016, at 5:28 PM, Stefan Hajnoczi wrote: > > There are several places where the listener and pending or accept queue > child sockets are accessed at the same time. Lockdep is unhappy that > two locks from the same class are held. > > Tell lockdep that it is

[PATCH (net-next.git) 1/3] drivers: net: stmmac: reworking the PCS code.

The 3.xx and 4.xx synopsys gmacs have a very similar PCS embedded module and they share almost the same registers: for example: AN_Control, AN_Status, AN_Advertisement, AN_Link_Partner_Ability, AN_Expansion, TBI_Extended_Status. Just the RGMII/SMII Control/Status register differs. So This

[PATCH (net-next.git) 2/3] drivers: net: stmmac: rework core ISR to better manage PCS and PMT

By default, all gmac cores disable the PCS block and always enable the PMT. Note that this is done in a different way by 3.x and 4.x cores. With this rework, PCS and PMT interrupt masks can be driven by parameters now moved inside the mac_device_info structure and the settings follow what the HW

[PATCH (net-next.git) 0/3] stmmac: rework and enhance the PCS support

The 3.xx and 4.xx synopsys gmacs have a very similar PCS embedded module and they share almost the same registers; for example: AN_Control, AN_Status, AN_Advertisement, AN_Link_Partner_Ability, AN_Expansion, TBI_Extended_Status. Just the RGMII/SMII Control/Status register differs. So these

[PATCH (net-next.git) 3/3] drivers: net: stmmac: add port selection programming

In case of SGMII more, for example when a MAC2MAC connection is needed, the port selection bits (inside the MAC configuration registers) have to be programmed according to the link selected. So the patch adds a new DT parameter to pass the port selection and to programmed related PCS and CORE to

Re: [PATCH net] Bridge: Fix ipv6 mc snooping if bridge has no ipv6 address

On Fri, Jun 24, 2016 at 12:35:18PM +0200, Daniel Danzberger wrote: > The bridge is falsly dropping ipv6 mulitcast packets if there is: > 1. No ipv6 address assigned on the brigde. > 2. No external mld querier present. > 3. The internal querier enabled. > > When the bridge fails to build mld

[PATCH] net: smc91x: ACPI Enable lan91x adapters

Enable lan91x adapters in some ARM machines and models when booted with an ACPI kernel. Signed-off-by: Jeremy Linton --- drivers/net/ethernet/smsc/smc91x.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/smsc/smc91x.c

[PATCH] connector: fix out-of-order cn_proc netlink message delivery

The proc connector messages include a sequence number, allowing userspace programs to detect lost messages. However, performing this detection is currently more difficult than necessary, since netlink messages can be delivered to the application out-of-order. To fix this, leave pre-emption

Re: [iproute PATCH v3 0/6] Big C99 style initializer rework

Le 23/06/2016 19:34, Phil Sutter a écrit : > This is v3 of my C99-style initializer related patch series. The changes > since v2 are: Compile-tested with a gcc 4.4.7. Regards, Nicolas

Re: [PATCH net-next 0/5] qed/qede: Tunnel hardware GRO support

On 23/06/16 18:07, Alexander Duyck wrote: > I would prefer to see us extend LRO to support "close enough GRO" > instead of have us extend GRO to also include LRO. This reminds me of something I've been meaning to bring up (sorry for slightly OT, but it might turn out relevant after all). In sfc we

Re: vmw_vsock sk_ack_backlog double decrement bug

Hi Stefan, Good catch. Thanks for pointing this out. I'll take care of fixing and testing this. Thanks, Jørgen From: Stefan Hajnoczi Sent: Thursday, June 23, 2016 5:40 PM To: Jorgen S. Hansen Cc: netdev@vger.kernel.org

Re: [PATCH] net: ethernet: ti: cpdma: switch to use genalloc

Hi, On Fri, Jun 24, 2016 at 11:35:15AM +0530, Mugunthan V N wrote: > On Thursday 23 June 2016 06:26 PM, Ivan Khoronzhuk wrote: > >> +if (pool->cpumap) { > >> +dma_free_coherent(pool->dev, pool->mem_size, pool->cpumap, > >> + pool->phys); > >> +} else { > >> +

Re: [iproute PATCH v3 6/6] misc/ifstat: simplify unsigned value comparison

On Fri, Jun 24, 2016 at 09:20:32AM +, David Laight wrote: > From: Phil Sutter > > Sent: 23 June 2016 18:34 > > > > By directly comparing the value of both unsigned variables, casting to > > signed becomes unnecessary. > > > > This also fixes for compiling with older versions of gcc (at least

Re: [PATCH v10 01/22] net: hns: Add reset function support for RoCE driver

On Thu, Jun 16, 2016 at 10:35:09PM +0800, Lijun Ou wrote: > It added reset function for RoCE driver. RoCE is a feature of hns. > In hip06 SoC, in RoCE reset process, it's needed to configure dsaf > channel reset, port and sl map info. Reset function of RoCE is > located in dsaf module, we only

Re: [PATCH v10 03/22] IB/hns: Add initial main frame driver and get cfg info

On Thu, Jun 16, 2016 at 10:35:11PM +0800, Lijun Ou wrote: > This patch mainly added the initial bare main driver. It > could get the relative configure information of net node. > > Signed-off-by: Wei Hu > Signed-off-by: Nenglong Zhao >

Re: [iproute PATCH v3 0/6] Big C99 style initializer rework

Hi, On Fri, Jun 24, 2016 at 09:17:07AM +, David Laight wrote: > From: Phil Sutter > > Sent: 23 June 2016 18:34 > > > > This is v3 of my C99-style initializer related patch series. > ... > > It would be interesting to know how this affect the kernel code size? > > While gcc will generate a

[PATCH v2] net: ethernet: ti: cpdma: switch to use genalloc

TI CPDMA currently uses a bitmap for tracking descriptors alloactions allocations, but The genalloc already handles the same and can be used as with special memory (SRAM) as with DMA cherent memory chank (dma_alloc_coherent()). Hence, switch to using genalloc and add desc_num property for each

[PATCH net] Bridge: Fix ipv6 mc snooping if bridge has no ipv6 address

The bridge is falsly dropping ipv6 mulitcast packets if there is: 1. No ipv6 address assigned on the brigde. 2. No external mld querier present. 3. The internal querier enabled. When the bridge fails to build mld queries, because it has no ipv6 address, it slilently returns, but keeps the

[iproute PATCH] man: ip-address, ip-link: Document 'type' quirk

This covers the fact that calling 'ip {link|addr} show type foobar' does not return an error. Signed-off-by: Phil Sutter --- man/man8/ip-address.8.in | 6 ++ man/man8/ip-link.8.in| 6 ++ 2 files changed, 12 insertions(+) diff --git a/man/man8/ip-address.8.in

[PATCH V5 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga

From: Tien Hock Loh This adds support for TSE PCS that uses SGMII adapter when the phy-mode of the dwmac is set to sgmii. Signed-off-by: Tien Hock Loh Acked-by: Giuseppe Cavallaro Acked-by: Rob Herring --- v2: -

[PATCH] of_mdio: select fixed phy support unconditionally

Calling the fixed-phy functions when CONFIG_FIXED_PHY=m as a previous change tried cannot work if the caller is in built-in code: drivers/of/built-in.o: In function `of_phy_register_fixed_link': of_reserved_mem.c:(.text+0x85e0): undefined reference to `fixed_phy_register' Making of_mdio depend

RE: [iproute PATCH v3 6/6] misc/ifstat: simplify unsigned value comparison

From: Phil Sutter > Sent: 23 June 2016 18:34 > > By directly comparing the value of both unsigned variables, casting to > signed becomes unnecessary. > > This also fixes for compiling with older versions of gcc (at least > <=3.4.6) which emit the following warning: > > | ifstat.c: In function

RE: [iproute PATCH v3 0/6] Big C99 style initializer rework

From: Phil Sutter > Sent: 23 June 2016 18:34 > > This is v3 of my C99-style initializer related patch series. ... It would be interesting to know how this affect the kernel code size? While gcc will generate a memset() call for 'struct foo = {0}' if you initialise some members it might generate

[PATCH v12 net-next 1/1] hv_sock: introduce Hyper-V Sockets

Hyper-V Sockets (hv_sock) supplies a byte-stream based communication mechanism between the host and the guest. It's somewhat like TCP over VMBus, but the transportation layer (VMBus) is much simpler than IP. With Hyper-V Sockets, applications between the host and the guest can talk to each other

Re: [PATCH] bridge: netfilter: spanning tree: Add masked_ether_addr_equal and neatening

On Fri, Jun 24, 2016 at 10:51:28AM +0200, Pablo Neira Ayuso wrote: > On Thu, Jun 23, 2016 at 12:00:00PM -0700, Joe Perches wrote: > > On Thu, 2016-06-23 at 19:36 +0200, Pablo Neira Ayuso wrote: > > > On Wed, Jun 15, 2016 at 01:58:45PM -0700, Joe Perches wrote: > > > > > > > > There is code

Re: [PATCH] bridge: netfilter: spanning tree: Add masked_ether_addr_equal and neatening

On Thu, Jun 23, 2016 at 12:00:00PM -0700, Joe Perches wrote: > On Thu, 2016-06-23 at 19:36 +0200, Pablo Neira Ayuso wrote: > > On Wed, Jun 15, 2016 at 01:58:45PM -0700, Joe Perches wrote: > > > > > > There is code duplication of a masked ethernet address comparison here > > > so make it a

Re: [RFC PATCH] gro: Partly revert "net: gro: allow to build full sized skb"

Sorry for replying to old mail, but wanted to keep the context. On Fri, Apr 22, 2016 at 10:14:22AM -0700, Alexander Duyck wrote: > On Fri, Apr 22, 2016 at 1:51 AM, Steffen Klassert > wrote: > > On Thu, Apr 21, 2016 at 09:02:48AM -0700, Alexander Duyck wrote: > >> On

[PATCH v12 net-next 0/1] introduce Hyper-V VM Sockets(hv_sock)

Hyper-V Sockets (hv_sock) supplies a byte-stream based communication mechanism between the host and the guest. It's somewhat like TCP over VMBus, but the transportation layer (VMBus) is much simpler than IP. With Hyper-V Sockets, applications between the host and the guest can talk to each other

[PATCH] mac80211_hwsim: Added vendor echo command

The purpose of the echo command is to provide a test facility for user space programs. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/mac80211_hwsim.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v4 01/16] bluetooth: Switch SMP to crypto_cipher_encrypt_one()

On Thu, Jun 23, 2016, Andy Lutomirski wrote: > SMP does ECB crypto on stack buffers. This is complicated and > fragile, and it will not work if the stack is virtually allocated. > > Switch to the crypto_cipher interface, which is simpler and safer. > > Cc: Marcel Holtmann

  1   2   >