Re: [PATCH v4 01/29] bluetooth: Switch SMP to crypto_cipher_encrypt_one()

Hi Andy, > SMP does ECB crypto on stack buffers. This is complicated and > fragile, and it will not work if the stack is virtually allocated. > > Switch to the crypto_cipher interface, which is simpler and safer. > > Cc: Marcel Holtmann > Cc: Gustavo Padovan

Re: [PATCH] net: stmmac: Fix null-function call in ISR on stmmac1000

Thanks Matt for the fix On 6/25/2016 9:35 PM, Matt Corallo wrote: At least on Meson GXBB, the CORE_IRQ_MTL_RX_OVERFLOW interrupt is thrown with the stmmac1000 driver, which does not support set_rx_tail_ptr. With this patch and the clock fixes, 1G ethernet works on ODROID-C2. Signed-off-by:

[PATCH net-next 1/6] r8152: add aldps_enable for rtl_ops

Add aldps_enable() for rtl_ops. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 11178f9..b253003 100644 ---

[PATCH net-next 6/6] r8152: add byte_enable for ocp_read_word function

Add byte_enable for ocp_read_word() to replace reading 4 bytes data with reading the desired 2 bytes data. This is used to avoid the issue which is described in commit:b4d99def. The origin method always reads 4 bytes data, and it may have problem when reading the PHY regiters. The new method is

Re: linux-next: manual merge of the net-next tree with the net tree

On Mon, 2016-06-27 at 11:46 +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > net/sched/sch_netem.c > > between commit: > > 21de12ee5568 ("netem: fix a use after free") > > from the net tree and commit: > > 520ac30f4551

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

On Sun, Jun 26, 2016 at 11:15 AM, Jiri Pirko wrote: > Sun, Jun 26, 2016 at 08:06:40PM CEST, ro...@cumulusnetworks.com wrote: >>On 6/26/16, 2:33 AM, Jiri Pirko wrote: >>> Sat, Jun 25, 2016 at 05:50:59PM CEST, ro...@cumulusnetworks.com wrote: On Thu, Jun 23, 2016 at 8:40 AM,

Re: [PATCH] rtlwifi: Add missing newlines to RT_TRACE calls

On 06/26/2016 08:26 PM, Joe Perches wrote: On Sun, 2016-06-26 at 18:13 -0700, Joe Perches wrote: On Sun, 2016-06-26 at 19:18 -0500, Larry Finger wrote: On 06/26/2016 02:34 PM, Joe Perches wrote: RT_TRACE does not add a newline to the end of a message and always emits at KERN_DEBUG so these

linux-next: manual merge of the net-next tree with the net tree

Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/sched/sch_netem.c between commit: 21de12ee5568 ("netem: fix a use after free") from the net tree and commit: 520ac30f4551 ("net_sched: drop packets after root qdisc lock is released") from the net-next tree.

[PATCH v2] Maxim/driver: Add driver for maxim ds26522

Signed-off-by: Zhao Qiang --- Changes for v2: - remove MODULE_DESCRIPTION of driver - add dependence on 'FSL_SOC || ARCH_MXC || ARCH_LAYERSCAPE" drivers/net/wan/Kconfig| 11 ++ drivers/net/wan/Makefile | 1 + drivers/net/wan/slic_ds26522.c |

Re: [PATCH] rtlwifi: Add missing newlines to RT_TRACE calls

On Sun, 2016-06-26 at 18:13 -0700, Joe Perches wrote: > On Sun, 2016-06-26 at 19:18 -0500, Larry Finger wrote: > > > > On 06/26/2016 02:34 PM, Joe Perches wrote: > > > > > > > > > RT_TRACE does not add a newline to the end of a message and always > > > emits at KERN_DEBUG so these are

Re: [PATCH] rtlwifi: Add missing newlines to RT_TRACE calls

On Sun, 2016-06-26 at 19:18 -0500, Larry Finger wrote: > On 06/26/2016 02:34 PM, Joe Perches wrote: > > > > RT_TRACE does not add a newline to the end of a message and always > > emits at KERN_DEBUG so these are susceptible to message interleaving > > from other processes without the newline. > >

Re: [PATCH] geneve: fix max_mtu setting

> On Jun 26, 2016, at 8:35 PM, zhuyj wrote: > > + if (geneve->remote.sa.sa_family == AF_INET) > + max_mtu -= sizeof(struct iphdr); > + else > + max_mtu -= sizeof(struct ipv6hdr); > > Sorry, if sa_family is not AF_NET, it is

Re: [PATCH] rtlwifi: Create _rtl_dbg_trace function to reduce RT_TRACE code size

On 06/25/2016 05:46 PM, Joe Perches wrote: This debugging macro can expand to a lot of code. Make it a function to reduce code size. (x86-64 defconfig w/ all rtlwifi drivers and allyesconfig) $ size drivers/net/wireless/realtek/rtlwifi/built-in.o* text data bss dec hex

Re: [PATCH] rtlwifi: Add missing newlines to RT_TRACE calls

On 06/26/2016 02:34 PM, Joe Perches wrote: RT_TRACE does not add a newline to the end of a message and always emits at KERN_DEBUG so these are susceptible to message interleaving from other processes without the newline. Signed-off-by: Joe Perches --- This patch does not

Re: [ethtool PATCH v1 2/2] ethtool:QSFP Plus/QSFP28 Diagnostics Information Support

On Mon, 2016-06-27 at 00:02 +0200, Ben Hutchings wrote: > On Sun, 2016-06-26 at 09:40 -0700, Vidya Sagar Ravipati wrote: > > On Sun, Jun 26, 2016 at 2:33 AM, Ben Hutchings wrote: > [...] > > > This looks very similar to sff8472_diags, only with the actual values > > >

[PATCH v4 01/29] bluetooth: Switch SMP to crypto_cipher_encrypt_one()

SMP does ECB crypto on stack buffers. This is complicated and fragile, and it will not work if the stack is virtually allocated. Switch to the crypto_cipher interface, which is simpler and safer. Cc: Marcel Holtmann Cc: Gustavo Padovan Cc: Johan

Re: [ethtool PATCH v1 2/2] ethtool:QSFP Plus/QSFP28 Diagnostics Information Support

On Sun, 2016-06-26 at 09:40 -0700, Vidya Sagar Ravipati wrote: > On Sun, Jun 26, 2016 at 2:33 AM, Ben Hutchings wrote: [...] > > This looks very similar to sff8472_diags, only with the actual values > > separated from the arrays of thresholds. > > > > Can the structure and

Saudações

Saudações,   Eu sou a senhora Annie Ethan de uma empresa de crédito privado conhecido como Aspire dinheiro Loan®. Oferecemos todos os tipos de empréstimo a taxa de juro de 3%. Se você está na necessidade de empréstimo favor contacte-nos com as informações abaixo. Nome completo: Gênero:

Re: [ethtool PATCH v1 2/2] ethtool:QSFP Plus/QSFP28 Diagnostics Information Support

Hi Vidya, Thanks a lot for your your work! Here are my 2 cents: > + /* SFP voltage in 0.1mV units */ > + __u16 sfp_voltage; > + /* SFP Temp in 16-bit signed 1/256 Celcius */ > + __s16 sfp_temp; > + /* [4] tables are low/high warn, low/high alarm */ You already had

Re: [PATCH net] net: avoid vlan ptype specific match to be leaked on real device

From: Jiri Pirko Date: Wed, 22 Jun 2016 14:40:50 +0200 > The patch only unified the behaviour so everyone know what to expect > regardless of the device type. +1 And reverting this behavior back is going to hurt more people than it will help, so I am not going to apply this,

Re: [PATCH net-next 00/14] rxrpc: Get rid of conn bundle and transport structs [ver #2]

From: David Howells Date: Wed, 22 Jun 2016 17:06:19 +0100 > David Howells wrote: > >> The patches can be found here also: >> >> >> http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite >> >> Tagged thusly: >>

Re: [PATCH net-next 0/5] qed/qede: Tunnel hardware GRO support

From: Rick Jones Date: Wed, 22 Jun 2016 14:52:34 -0700 > To get that disabled, one must also get the bnx2x module loaded with > "disable-tpa=1" so the Linux stack GRO gets used instead. And people wonder why I'm difficult about module parameters in drivers

[ethtool PATCH v2 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G

From: Vidya Sagar Ravipati Enhancing link mode bits to support 25G/50G/100G for supported and advertised speed mode bits Signed-off-by: Vidya Sagar Ravipati --- ethtool.c | 27 +++ 1 file changed, 27 insertions(+)

[ethtool PATCH v2 2/4] ethtool:Reorganizing SFF-8024 fields for SFP/QSFP

From: Vidya Sagar Ravipati This patch provides following support a) Reorganized fields based out of SFF-8024 fields i.e. Identifier/ Encoding/Connector types which are common across SFP/SFP+ (SFF-8472) and QSFP+/QSFP28 (SFF-8436/SFF-8636) modules into sff-common

[ethtool PATCH v2 1/4] ethtool-copy.h:sync with net

From: Vidya Sagar Ravipati This covers kernel changes upto: commit 3851112e4737cd52aaeda0ce8d084be9ee128106 Author: Vidya Sagar Ravipati Date: Sun May 22 23:59:00 2016 -0700 ethtool: add support for 25G/50G/100G speed modes This

[ethtool PATCH v2 3/4] ethtool:QSFP Plus/QSFP28 Diagnostics Information Support

From: Vidya Sagar Ravipati This patch provides following support a) Support for diagnostics information for QSFP Plus/QSFP28 modules based on SFF-8436/SFF-8636 Standards for QSFP+/QSFP28 a) QSFP+/QSFP28 - SFF 8636 Rev 2.7 dated January 26,2016 b) SFF-8024 Rev 4.0

Re: [PATCH v2] net: stmmac: dwmac-rk: add rk3228-specific data

From: Xing Zheng Date: Tue, 21 Jun 2016 20:33:28 +0800 > Add constants and callback functions for the dwmac on rk3228/rk3229 socs. > As can be seen, the base structure is the same, only registers and the > bits in them moved slightly. > > Signed-off-by: Xing Zheng

Re: [PATCH RESEND] ipconfig : Fix null reference to the freed dev_addr

From: Chanho Min Date: Wed, 22 Jun 2016 19:08:13 +0900 > To fix this, I suggested patch that checks if device is available > before the DHCP packet is sended. The bug is more fundamental than this. The code is not taking a reference to the netdevice, and that's the only

[ethtool PATCH v2 0/4] Add support for QSFP+/QSFP28 Diagnostics and 25G/50G/100G port speeds

From: Vidya Sagar Ravipati This patch series provides following support a) Reorganized fields based out of SFF-8024 fields i.e. Identifier/ Encoding/Connector types which are common across SFP/SFP+ (SFF-8472) and QSFP+/QSFP28 (SFF-8436/SFF-8636) modules into

[PATCH] rtlwifi: Add missing newlines to RT_TRACE calls

RT_TRACE does not add a newline to the end of a message and always emits at KERN_DEBUG so these are susceptible to message interleaving from other processes without the newline. Signed-off-by: Joe Perches --- drivers/net/wireless/realtek/rtlwifi/core.c| 2 +-

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

Sun, Jun 26, 2016 at 08:06:40PM CEST, ro...@cumulusnetworks.com wrote: >On 6/26/16, 2:33 AM, Jiri Pirko wrote: >> Sat, Jun 25, 2016 at 05:50:59PM CEST, ro...@cumulusnetworks.com wrote: >>> On Thu, Jun 23, 2016 at 8:40 AM, Jiri Pirko wrote: Thu, Jun 23, 2016 at 05:11:26PM

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

On 6/26/16, 2:33 AM, Jiri Pirko wrote: > Sat, Jun 25, 2016 at 05:50:59PM CEST, ro...@cumulusnetworks.com wrote: >> On Thu, Jun 23, 2016 at 8:40 AM, Jiri Pirko wrote: >>> Thu, Jun 23, 2016 at 05:11:26PM CEST, anurad...@cumulusnetworks.com wrote: we can't separate CPU and

Re: [ethtool PATCH v1 2/2] ethtool:QSFP Plus/QSFP28 Diagnostics Information Support

On Sun, Jun 26, 2016 at 2:33 AM, Ben Hutchings wrote: > On Mon, 2016-06-13 at 16:27 -0700, Vidya Sagar Ravipati wrote: >> From: Vidya Sagar Ravipati >> >> This patch series provides following support >> a) Reorganized fields based out of SFF-8024

ethtool needs a new maintainer

I've become steadily less enthusiastic and less responsive as a maintainer over the past year or so.  I no longer work on networking regularly, so it takes a lot more time to get into the right state of mind to think about ethtool code, while I have other demands on my time that tend to take

ethtool 4.6 released

ethtool version 4.6 has been released. Home page: https://www.kernel.org/pub/software/network/ethtool/ Download link: https://www.kernel.org/pub/software/network/ethtool/ethtool-4.6.tar.xz Release notes: * Feature: Support register dump on Intel X550 NICs (-d option) * Fix:

[PATCH ethtool 2/2] ethtool.8.in, ethtool.c: Add myself to authors and copyright notices

Signed-off-by: Ben Hutchings --- ethtool.8.in | 3 ++- ethtool.c| 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/ethtool.8.in b/ethtool.8.in index 9dc5e252a1dc..e08c9a714551 100644 --- a/ethtool.8.in +++ b/ethtool.8.in @@ -947,7 +947,8 @@ Scott

[PATCH ethtool 1/2] configure.ac: Remove feature test for

has been a hard dependency for as back as git history goes (2005, shortly after version 3). Signed-off-by: Ben Hutchings --- I spotted this while reviewing David Decotigny's patch to use netlink sockets. Ben. configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH 2/5] ethtool: move cmdline_coalesce out of do_scoalesce

On Sun, 2016-05-15 at 00:14 -0700, kan.li...@intel.com wrote: > From: Kan Liang > > Moving cmdline_coalesce out of do_scoalesce, so it can be shared with > other functions. > No behavior change. I spent some time getting rid of static variables, and I think the only ones

[PATCH v4] wlcore: spi: add wl18xx support

Add support for using with both wl12xx and wl18xx. - all wilink family needs special init command for entering wspi mode. extra clock cycles should be sent after the spi init command while the cs pin is high. - Use inverted chip select for sending a dummy 4 bytes command that completes the

Re: [PATCH v3] net/mlx5: use mlx5_buf_alloc_node instead of mlx5_buf_alloc in mlx5_wq_ll_create

On Fri, Jun 24, 2016 at 3:52 AM, Wang Sheng-Hui wrote: > Commit 311c7c71c9bb ("net/mlx5e: Allocate DMA coherent memory on > reader NUMA node") introduced mlx5_*_alloc_node() but missed changing > some calling and warn messages. This patch introduces 2 changes: > * Use

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

Sat, Jun 25, 2016 at 05:50:59PM CEST, ro...@cumulusnetworks.com wrote: >On Thu, Jun 23, 2016 at 8:40 AM, Jiri Pirko wrote: >> Thu, Jun 23, 2016 at 05:11:26PM CEST, anurad...@cumulusnetworks.com wrote: >>> we can't separate CPU and HW stats there. In some cases (or ASICs) HW

Re: [ethtool PATCH v1 2/2] ethtool:QSFP Plus/QSFP28 Diagnostics Information Support

On Mon, 2016-06-13 at 16:27 -0700, Vidya Sagar Ravipati wrote: > From: Vidya Sagar Ravipati > > This patch series provides following support > a) Reorganized fields based out of SFF-8024 fields i.e. Identifier/ >    Encoding/Connector types which are common across

[PATCH net 3/5] batman-adv: Fix double-put of vlan object

From: Ben Hutchings Each batadv_tt_local_entry hold a single reference to a batadv_softif_vlan. In case a new entry cannot be added to the hash table, the error path puts the reference, but the reference will also now be dropped by batadv_tt_local_entry_release(). Fixes:

[PATCH net 4/5] batman-adv: Fix ICMP RR ethernet access after skb_linearize

The skb_linearize may reallocate the skb. This makes the calculated pointer for ethhdr invalid. But it the pointer is used later to fill in the RR field of the batadv_icmp_packet_rr packet. Instead re-evaluate eth_hdr after the skb_linearize+skb_cow to fix the pointer and avoid the invalid read.

[PATCH net 5/5] batman-adv: Clean up untagged vlan when destroying via rtnl-link

The untagged vlan object is only destroyed when the interface is removed via the legacy sysfs interface. But it also has to be destroyed when the standard rtnl-link interface is used. Fixes: 5d2c05b21337 ("batman-adv: add per VLAN interface attribute framework") Signed-off-by: Sven Eckelmann

[PATCH net 2/5] batman-adv: Fix use-after-free/double-free of tt_req_node

The tt_req_node is added and removed from a list inside a spinlock. But the locking is sometimes removed even when the object is still referenced and will be used later via this reference. For example batadv_send_tt_request can create a new tt_req_node (including add to a list) and later

[PATCH net 1/5] batman-adv: replace WARN with rate limited output on non-existing VLAN

From: Simon Wunderlich If a VLAN tagged frame is received and the corresponding VLAN is not configured on the soft interface, it will splat a WARN on every packet received. This is a quite annoying behaviour for some scenarios, e.g. if bat0 is bridged with eth0, and

[PATCH net 0/5] batman-adv: Fixes for Linux 4.7

Hi David, Antonio currently seems to be occupied. This is currently rather unfortunate because there are patches waiting in the batman-adv development repository maint(enance) branch [1] since up to 6 weeks. I am now getting asked when these patches will hit the distribution kernels and

Re: [PATCH] net: smc91x: ACPI Enable lan91x adapters

Jeremy Linton writes: > Enable lan91x adapters in some ARM machines and models > when booted with an ACPI kernel. > > Signed-off-by: Jeremy Linton Hi Jeremy, I launched your change in my Jenkins yesterday (on Linus's mainline, not linux-next), and

Re: [ethtool 0/3][pull request] Intel Wired LAN Driver Updates 2016-05-03

On Wed, 2016-05-04 at 09:44 -0700, Jeff Kirsher wrote: > This series contains updates to ixgbe in ethtool. > > Preethi adds missing device IDs and mac_type definitions, also updated > the display registers for x550, x550em_x/a.  Cleaned up the format string > storage by taking advantage of "for"

Re: [PATCH ethtool] ethtool.c: fix memory leaks

On Fri, 2016-03-18 at 13:24 +0100, Ivan Vecera wrote: > Memory allocated at several places is not appropriately freed. Given that ethtool is not a library or a long-running application - why does that matter? Ben. > Signed-off-by: Ivan Vecera > --- >  ethtool.c | 60

Re: [ethtool PATCH v7 2/2] ethtool: use netlink socket when AF_INET not available

On Fri, 2016-03-25 at 09:21 -0700, David Decotigny wrote: > From: David Decotigny > > To benefit from this, kernel commit 025c68186e07 ("netlink: add support > for NIC driver ioctls") is needed. > > > Signed-off-by: David Decotigny > --- >  

Re: [ethtool PATCH v7 1/2] ethtool.c: add support for ETHTOOL_xLINKSETTINGS ioctls

On Fri, 2016-03-25 at 09:21 -0700, David Decotigny wrote: > From: David Decotigny > > More info with kernel commit 8d3f2806f8fb ("Merge branch > 'ethtool-ksettings'"). > > Note: The new features implemented in this patch depend on kernel > commit 793cf87de9d1 ("Set cmd field

RE: [PATCH net-next 0/5] qed/qede: Tunnel hardware GRO support

> Fundamentally I believe that robust, responsive hardware LRO is not workable > as > the hardware would have to decide to hold onto packets in the hope of merge > candidates arriving soon after. Whereas in the software layer (GRO, > bundling...), the packets are already coming in bursts thanks