[PATCH v3 5/5] drivers: net: xgene: Fix module load/unload crash

2016-07-04 Thread Iyappan Subramanian
When the driver is configured as kernel module and when it gets unloaded and reloaded, kernel crash was observed, due to incomplete hardware cleanup. This patch addresses this issue with the following changes, - Reordered mac enable and disable - Added hardware prefetch buffer cleanup - Added Tx

Re: [PATCH v2 3/5] drivers: net: phy: Add MDIO driver

2016-07-04 Thread Iyappan Subramanian
Hi Andrew, Thanks for the review. On Tue, May 31, 2016 at 6:11 PM, Andrew Lunn wrote: > On Tue, May 31, 2016 at 05:10:38PM -0700, Iyappan Subramanian wrote: >> +static int xgene_mdio_reset(struct xgene_mdio_pdata *pdata) >> +{ >> + int ret; >> + >> + if (pdata->mdio_id

[PATCH v3 4/5] dtb: xgene: Add MDIO node

2016-07-04 Thread Iyappan Subramanian
Added mdio node for mdio driver. Also added phy-handle reference to the ethernet nodes. Removed unused mdio subnode within storm menet ethernet node. Removed unused clock node from storm sgenet1. Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen

[PATCH v3 2/5] drivers: net: xgene: Backward compatibility with older firmware

2016-07-04 Thread Iyappan Subramanian
This patch looks for CONFIG_MDIO_XGENE and based on phy-handle DT/ACPI fields, sets the mdio_driver flag. The rest of the driver uses the this flag for any MDIO management, in the case of backward compatibility. Also, some code clean up done around mdio configuration/remove. Signed-off-by:

[PATCH v3 1/5] drivers: net: xgene: MAC and PHY configuration changes

2016-07-04 Thread Iyappan Subramanian
This patch fixes MAC configuration to support 10/100GbE for SGMII and link_state call back. It also sets pdata->mdio_driver flag based on ethernet mdio subnode and prepare for MDIO driver support. In summary, following are the changes, - Added set_speed function pointer in mac_ops - Changed

[PATCH v3 0/5] drivers: net: xgene: Fix 1G hot-plug and module support

2016-07-04 Thread Iyappan Subramanian
This patchset addresses the following issues, 1. hot-plug issue on the SGMII 1G interface - by adding a driver for MDIO management 2. fixes the kernel crash when the driver loaded as an kernel module - by fixing hardware cleanups and rearrange kernel API calls Signed-off-by:

[PATCH v3 3/5] drivers: net: phy: Add MDIO driver

2016-07-04 Thread Iyappan Subramanian
Currently, SGMII based 1G rely on the hardware registers for link state and sometimes it's not reliable. To get most accurate link state, this interface has to use the MDIO bus to poll the PHY. In X-Gene SoC, MDIO bus is shared across RGMII and SGMII based 1G interfaces, so adding this driver to

RE: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-07-04 Thread Dexuan Cui
> From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Dexuan Cui > Sent: Thursday, June 30, 2016 23:59 > diff --git a/include/linux/socket.h b/include/linux/socket.h > index b5cc5a6..0b68b58 100644 > --- a/include/linux/socket.h > +++

Re: [PATCH 2/2] net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings

2016-07-04 Thread Florian Fainelli
Le 04/07/2016 16:03, David Miller a écrit : > From: Philippe Reynes > Date: Sun, 3 Jul 2016 17:33:57 +0200 > >> There are two generics functions phy_ethtool_{get|set}_link_ksettings, >> so we can use them instead of defining the same code in the driver. >> >> Signed-off-by:

Re: PROBLEM: MTU of ipsec tunnel drops continuously until traffic stops

2016-07-04 Thread Matt Bennett
On 07/04/2016 11:12 PM, Steffen Klassert wrote: > On Mon, Jul 04, 2016 at 03:52:50AM +, Matt Bennett wrote: >> *Resending as plain text so the mailing list accepts it.. Sorry Steffen and >> Herbert* >> >> ​Hi, >> >> During long run testing of an ipsec tunnel over a PPP link it was found that

Problem: BUG_ON hit in ppp_pernet() when re-connect after changing shared key on LAC

2016-07-04 Thread Matt Bennett
Hi, I am producing the attached bug trace when testing PPP connections. Specifically the steps I am doing are: 1. Configure PPP client and LAC with shared key and wait for client to negotiate an IP address. 2. Change the shared key on the LAC. 3. Bring the PPP client interface down and up to

[PATCH net-next] net: vrf: Add support for PREROUTING rules on vrf device

2016-07-04 Thread David Ahern
Add support for PREROUTING rules with skb->dev set to the vrf device. INPUT rules are already allowed. Provides symmetry with the output path which allows POSTROUTING rules. Signed-off-by: David Ahern --- drivers/net/vrf.c | 21 + 1 file changed, 21

Re: [patch net-next 00/14] mlxsw: Implement basic FIB offload and router interfaces

2016-07-04 Thread David Miller
From: Jiri Pirko Date: Mon, 4 Jul 2016 08:23:03 +0200 > Introduce LPM trees management including virtual router management for HW. > Implement basic FIB offloading using switchdev FIB objects. For now only > support > local routes and direct routes (next-hop support will be

Re: [PATCH net-next] tun: fix build warnings

2016-07-04 Thread David Miller
From: Jason Wang Date: Mon, 4 Jul 2016 13:53:38 +0800 > Stephen Rothwell reports a build warnings(powerpc ppc64_defconfig) > > drivers/net/tun.c: In function 'tun_do_read.part.5': > /home/sfr/next/next/drivers/net/tun.c:1491:6: warning: 'err' may be > used uninitialized in

Re: [PATCH] fsl/fman: fix error handling

2016-07-04 Thread David Miller
From: Christophe JAILLET Date: Mon, 4 Jul 2016 07:46:42 +0200 > This is likely that checking 'fman->fifo_offset' instead of > 'fman->cam_offset' is expected here. > > Signed-off-by: Christophe JAILLET > --- > > The type of

Re: PATCH 1/1] AX.25: Close socket connection on session completion

2016-07-04 Thread David Miller
From: David Ranch Date: Mon, 4 Jul 2016 15:48:40 -0700 > How can we get this critical fix applied to the other stable kernel > versions? Networking patches are submitted to -stable when people ask me to do so. So simply ask for this when you submit your patch.

Re: [PATCH net-next V2 00/10] liquidio updates and bug fixes

2016-07-04 Thread David Miller
From: Raghu Vatsavayi Date: Sun, 3 Jul 2016 13:56:46 -0700 > Following V2 patchset contains updates and bug fixes for > liquidio driver. This patchset also has changes that you > suggested in vxlan code. Please apply the patches in following > order as some of the

Re: [PATCH] RDS: fix rds_tcp_init() error path

2016-07-04 Thread David Miller
From: Vegard Nossum Date: Sun, 3 Jul 2016 10:54:54 +0200 > If register_pernet_subsys() fails, we shouldn't try to call > unregister_pernet_subsys(). > > Fixes: 467fa15356 ("RDS-TCP: Support multiple RDS-TCP listen endpoints, one > per netns.") > Cc:

Re: [PATCH net-next] bpf: add bpf_get_hash_recalc helper

2016-07-04 Thread David Miller
From: Daniel Borkmann Date: Sun, 3 Jul 2016 01:28:47 +0200 > If skb_clear_hash() was invoked due to mangling of relevant headers and > BPF program needs skb->hash later on, we can add a helper to trigger hash > recalculation via bpf_get_hash_recalc(). > > The helper will

Re: [net-next PATCH v2 2/2] net: samples: pktgen mode samples/tests for qdisc layer

2016-07-04 Thread David Miller
From: John Fastabend Date: Sat, 02 Jul 2016 14:13:13 -0700 > This adds samples for pktgen to use with new mode to inject pkts into > the qdisc layer. This also doubles as nice test cases to test any > patches against qdisc layer. > > Signed-off-by: John Fastabend

Re: [net-next PATCH v2 1/2] net: pktgen: support injecting packets for qdisc testing

2016-07-04 Thread David Miller
From: John Fastabend Date: Sat, 02 Jul 2016 14:12:54 -0700 > Add another xmit_mode to pktgen to allow testing xmit functionality > of qdiscs. The new mode "queue_xmit" injects packets at > __dev_queue_xmit() so that qdisc is called. > > Signed-off-by: John Fastabend

Re: [PATCH 1/2] net: ethernet: arc: emac: use phydev from struct net_device

2016-07-04 Thread David Miller
From: Philippe Reynes Date: Sat, 2 Jul 2016 20:06:51 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phy in the private structure, and update the driver to use the > one

Re: [PATCH 1/2] net: ethernet: bcmgenet: use phydev from struct net_device

2016-07-04 Thread David Miller
From: Philippe Reynes Date: Sun, 3 Jul 2016 17:33:56 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phy in the private structure, and update the driver to use the > one

Re: [PATCH 2/2] net: ethernet: lantiq_etop: use phy_ethtool_{get|set}_link_ksettings

2016-07-04 Thread David Miller
From: Philippe Reynes Date: Sun, 3 Jul 2016 00:05:05 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 2/2] net: ethernet: arc: emac: use phy_ethtool_{get|set}_link_ksettings

2016-07-04 Thread David Miller
From: Philippe Reynes Date: Sat, 2 Jul 2016 20:06:52 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 2/2] net: ethernet: cavium: octeon: use phy_ethtool_{get|set}_link_ksettings

2016-07-04 Thread David Miller
From: Philippe Reynes Date: Sat, 2 Jul 2016 23:37:00 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 1/2] net: ethernet: cavium: octeon: use phydev from struct net_device

2016-07-04 Thread David Miller
From: Philippe Reynes Date: Sat, 2 Jul 2016 23:36:59 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phy in the private structure, and update the driver to use the > one

Re: [PATCH 2/2] net: ethernet: smsc: smsc911x: use phy_ethtool_{get|set}_link_ksettings

2016-07-04 Thread David Miller
From: Philippe Reynes Date: Sun, 3 Jul 2016 01:14:21 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 1/2] net: ethernet: ixp4xx_eth: use phydev from struct net_device

2016-07-04 Thread David Miller
From: Philippe Reynes Date: Sat, 2 Jul 2016 14:06:14 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phy in the private structure, and update the driver to use the > one

Re: [PATCH 1/2] net: ethernet: lantiq_etop: use phydev from struct net_device

2016-07-04 Thread David Miller
From: Philippe Reynes Date: Sun, 3 Jul 2016 00:05:04 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phy in the private structure, and update the driver to use the > one

Re: [PATCH 1/2] net: ethernet: smsc: smsc911x: use phydev from struct net_device

2016-07-04 Thread David Miller
From: Philippe Reynes Date: Sun, 3 Jul 2016 01:14:20 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phy in the private structure, and update the driver to use the > one

Re: [PATCH 2/2] net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings

2016-07-04 Thread David Miller
From: Philippe Reynes Date: Sun, 3 Jul 2016 17:33:57 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 2/2] net: ethernet: ixp4xx_eth: use phy_ethtool_{get|set}_link_ksettings

2016-07-04 Thread David Miller
From: Philippe Reynes Date: Sat, 2 Jul 2016 14:06:15 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Applied.

Re: PATCH 1/1] AX.25: Close socket connection on session completion

2016-07-04 Thread David Ranch
Hello David, Unless I'm doing something wrong, it seems this patch has only been applied to the newest kernel: Git/linux-stable$ git tag -l --contains 4a7d99ea1b27734558feb6833f180cd38a159940 v4.7-rc6 How can we get this critical fix applied to the other stable kernel versions? I

Re: [PATCH] net/mlx4: Fix some indent inconsistancy

2016-07-04 Thread David Miller
From: Christophe JAILLET Date: Sat, 2 Jul 2016 14:31:05 +0200 > Silent a few smatch warnings about indentation. > This include the removal of a 'return' statement in 'resource_tracker.c'. > This 'return' will still be performed when breaking out of the >

Re: [PATCH] net: check for NULL net_device in FIB tables

2016-07-04 Thread Julian Anastasov
Hello, On Tue, 5 Jul 2016, Vegard Nossum wrote: > > [PATCH RFC] ipv4: reject RTNH_F_LINKDOWN for incompatible routes > > > > The RTNH_F_LINKDOWN flag is used only for link routes. > > Reject it for error routes and local routes. > > > > Signed-off-by: Julian Anastasov > >

Re: [PATCH v2 net-next 1/1] net sched actions: mirred add support for setting Dst MAC address

2016-07-04 Thread David Miller
From: Jamal Hadi Salim Date: Sat, 2 Jul 2016 10:34:25 -0400 > From: Jamal Hadi Salim > > Often redirecting or mirroring requires that we set the dstMAC address > of the target device. While it is possible to pipe to a pedit action, > this patch obsoletes

Re: [PATCH v2 net-next 3/3] net sched actions: skbedit convert to use more modern nla_put_xxx

2016-07-04 Thread David Miller
From: Jamal Hadi Salim Date: Sat, 2 Jul 2016 06:43:16 -0400 > From: Jamal Hadi Salim > > Signed-off-by: Jamal Hadi Salim Applied.

Re: [PATCH v2 net-next 2/3] net sched actions: skbedit add support for mod-ing skb pkt_type

2016-07-04 Thread David Miller
From: Jamal Hadi Salim Date: Sat, 2 Jul 2016 06:43:15 -0400 > From: Jamal Hadi Salim > > Extremely useful for setting packet type to host so i dont > have to modify the dst mac address using pedit (which requires > that i know the mac address) > >

Re: [PATCH v2 net-next 1/3] net: simplify and make pkt_type_ok() available for other users

2016-07-04 Thread David Miller
From: Jamal Hadi Salim Date: Sat, 2 Jul 2016 06:43:14 -0400 > From: Jamal Hadi Salim > > Suggested-by: Daniel Borkmann > Signed-off-by: Jamal Hadi Salim Applied.

Re: [PATCH net-next 0/6] net: dsa: Platform data for dsa2.c

2016-07-04 Thread David Miller
From: Florian Fainelli Date: Mon, 4 Jul 2016 14:40:28 -0700 > That is correct, although patches 1-4 could be applied immediately as > they are mostly preparatory steps to patches 5-6, I don't mind resending > this at a later time though (probably for the next net-next merge

Re: 4.6.3 kernel panic on ppp interface termination (__tcf_hash_release / spinlock )

2016-07-04 Thread Cong Wang
On Mon, Jul 4, 2016 at 12:07 PM, wrote: > A little bit more details: > > ~ # tc -s -d filter show dev ppp0 parent : > filter protocol ip pref 100 u32 > filter protocol ip pref 100 u32 fh 800: ht divisor 1 > filter protocol ip pref 100 u32 fh 800::1 order 1 key ht

Re: [PATCH] net: check for NULL net_device in FIB tables

2016-07-04 Thread Vegard Nossum
On 07/04/2016 11:24 PM, Julian Anastasov wrote: Hello, On Mon, 4 Jul 2016, Vegard Nossum wrote: Alright. Thanks for the review! I can submit a new patch to only check the one place above that actually crashed. Otherwise, if you think it's better to go with your fc_flags suggestion,

Re: [PATCH v2] geneve: fix max_mtu setting

2016-07-04 Thread David Miller
From: Haishuang Yan Date: Sat, 2 Jul 2016 15:02:48 +0800 > For ipv6+udp+geneve encapsulation data, the max_mtu should subtract > sizeof(ipv6hdr), instead of sizeof(iphdr). > > Signed-off-by: Haishuang Yan Applied and

[PATCH -next] connector: make cn_proc explicitly non-modular

2016-07-04 Thread Paul Gortmaker
The Kconfig controlling build of this code is currently: drivers/connector/Kconfig:config PROC_EVENTS drivers/connector/Kconfig: bool "Report process events to userspace" ...meaning that it currently is not being built as a module by anyone. Lets remove the two modular references, so that

Re: [PATCH net-next 0/6] net: dsa: Platform data for dsa2.c

2016-07-04 Thread Florian Fainelli
Le 29/06/2016 03:12, David Miller a écrit : > From: Florian Fainelli > Date: Mon, 27 Jun 2016 18:19:28 -0700 > >> 2016-06-27 18:05 GMT-07:00 Andrew Lunn : >>> On Mon, Jun 27, 2016 at 05:52:37PM -0700, Florian Fainelli wrote: Hi all, This patch

[PATCH net-next 8/9] net: r6040: Update my email

2016-07-04 Thread Florian Fainelli
Update my email address in the driver and MAINTAINERS file. Signed-off-by: Florian Fainelli --- MAINTAINERS | 2 +- drivers/net/ethernet/rdc/r6040.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS

[PATCH net-next 9/9] net: r6040: Bump version and date

2016-07-04 Thread Florian Fainelli
Bump version to 0.28 and date to 4th of July 2016. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/rdc/r6040.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/rdc/r6040.c b/drivers/net/ethernet/rdc/r6040.c index

[PATCH net-next 4/9] net: r6040: Reclaim transmitted buffers in NAPI

2016-07-04 Thread Florian Fainelli
Instead of taking one interrupt per packet transmitted, re-use the same NAPI context to free transmitted buffers. Since we are no longer in hard IRQ context replace dev_kfree_skb_irq() by dev_kfree_skb(). Signed-off-by: Florian Fainelli --- drivers/net/ethernet/rdc/r6040.c

[PATCH net-next 5/9] net: r6040: Check for skb->xmit_more

2016-07-04 Thread Florian Fainelli
Kick the transmission only if this is the last SKB to transmit or the queue is not already stopped. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/rdc/r6040.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/rdc/r6040.c

[PATCH net-next 6/9] net: r6040: Utilize __napi_schedule_irqoff

2016-07-04 Thread Florian Fainelli
We are already in hard IRQ context, so we can use __napi_schedule_irqoff() to save a few operations. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/rdc/r6040.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/rdc/r6040.c

[PATCH net-next 2/9] net: r6040: Increase statistics upon transmit completion

2016-07-04 Thread Florian Fainelli
r6040_xmit() is increasing transmit statistics during transmission while this may still fail, do this in r6040_tx() where we complete transmitted buffers instead. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/rdc/r6040.c | 8 +--- 1 file changed, 5

[PATCH net-next 7/9] net: r6040: Utilize napi_complete_done()

2016-07-04 Thread Florian Fainelli
We maintain how much work we did in NAPI context, so provide that with napi_complete_done(). Signed-off-by: Florian Fainelli --- drivers/net/ethernet/rdc/r6040.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/rdc/r6040.c

[PATCH net-next 3/9] net: r6040: Utilize skb_put_padto()

2016-07-04 Thread Florian Fainelli
Pad the SKB to the minimum length of ETH_ZLEN by using skb_put_padto() and take this operation out of the critical section since there is no need to check any HW resources before doing that. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/rdc/r6040.c | 9 -

[PATCH net-next 0/9] net: r6040: Misc updates

2016-07-04 Thread Florian Fainelli
Hi David, Here are some various updates for the r6040 driver, mostly to make it more modern and catch up with the latest API improvements. Thanks! Florian Fainelli (9): net: r6040: Utilize phy_print_status net: r6040: Increase statistics upon transmit completion net: r6040: Utilize

[PATCH net-next 1/9] net: r6040: Utilize phy_print_status

2016-07-04 Thread Florian Fainelli
Instead of open coding our own version utilize the library provided function. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/rdc/r6040.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/rdc/r6040.c

Re: [PATCH] net: check for NULL net_device in FIB tables

2016-07-04 Thread Julian Anastasov
Hello, On Mon, 4 Jul 2016, Vegard Nossum wrote: > Alright. > > Thanks for the review! I can submit a new patch to only check the one > place above that actually crashed. Otherwise, if you think it's better > to go with your fc_flags suggestion, feel free to send a patch for that. > As

Re: [PATCH] net: check for NULL net_device in FIB tables

2016-07-04 Thread Vegard Nossum
On 07/04/2016 09:45 PM, Julian Anastasov wrote: Hello, On Mon, 4 Jul 2016, Vegard Nossum wrote: struct fib_nh->nh_dev can be NULL, so we should check it before calling __in_dev_get_rcu on it. Multiple places seem to want this (and check the return value), so we can add a convenience

Re: [PATCH] net: check for NULL net_device in FIB tables

2016-07-04 Thread Julian Anastasov
Hello, On Mon, 4 Jul 2016, Vegard Nossum wrote: > struct fib_nh->nh_dev can be NULL, so we should check it before calling > __in_dev_get_rcu on it. > > Multiple places seem to want this (and check the return value), so we can > add a convenience wrapper for this. > > This fixes a

Re: 4.6.3 kernel panic on ppp interface termination (__tcf_hash_release / spinlock )

2016-07-04 Thread nuclearcat
A little bit more details: ~ # tc -s -d filter show dev ppp0 parent : filter protocol ip pref 100 u32 filter protocol ip pref 100 u32 fh 800: ht divisor 1 filter protocol ip pref 100 u32 fh 800::1 order 1 key ht 800 bkt 0 flowid :1 (rule hit 156 success 156) match / at

Re: ethtool needs a new maintainer

2016-07-04 Thread Ben Hutchings
On Fri, 2016-07-01 at 10:33 +0800, zhuyj wrote: > I am interested in this, too. You didn't say anything about your experience with Linux networking, and I couldn't find many contributions from you.  So you are welcome to help with ethtool but I've selected John as the maintainer. Ben. -- Ben

4.6.3 kernel panic on ppp interface termination (__tcf_hash_release / spinlock )

2016-07-04 Thread nuclearcat
Hi! On vanilla 4.6.0 and 4.6.3 i am getting reproducible kernel panic when i terminate user in accel-pppd. Here is kernel panic message received over netconsole: [ 465.469514] BUG: unable to handle kernel Jul 4 20:33:36 NULL pointer dereference at 000c [ 465.469671] IP:

Re: [PATCH -next] hfsc: reduce hfsc_sched to 14 cachelines

2016-07-04 Thread Michal Soltys
On 2016-07-04 16:22, Florian Westphal wrote: > hfsc_sched is huge (size: 920, cachelines: 15), but we can get it to 14 > cachelines by placing level after filter_cnt (covering 4 byte hole) and > reducing period/nactive/flags to u32 (period is just a counter, > incremented when class becomes active

Re: [PATCH v4 01/29] bluetooth: Switch SMP to crypto_cipher_encrypt_one()

2016-07-04 Thread Marcel Holtmann
Hi Andy, > SMP does ECB crypto on stack buffers. This is complicated and > fragile, and it will not work if the stack is virtually allocated. > > Switch to the crypto_cipher interface, which is simpler and safer. > > Cc: Marcel Holtmann > Cc:

Re: ethtool needs a new maintainer

2016-07-04 Thread Ben Hutchings
On Thu, 2016-06-30 at 14:37 -0500, Jorge Alberto Garcia wrote: > El 30/06/2016 02:32 p.m., "Ben Hutchings" escribió: > > > > On Thu, 2016-06-30 at 14:27 -0500, Jorge Alberto Garcia wrote: > > > On Thu, Jun 30, 2016 at 1:15 PM, John W. Linville > > >

Re: ethtool needs a new maintainer

2016-07-04 Thread Ben Hutchings
On Mon, 2016-06-27 at 09:51 -0400, John W. Linville wrote: > On Sun, Jun 26, 2016 at 06:11:41PM +0200, Ben Hutchings wrote: > > I've become steadily less enthusiastic and less responsive as a > > maintainer over the past year or so.  I no longer work on networking > > regularly, so it takes a lot

Re: [PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac

2016-07-04 Thread Ray Jui
On 7/1/2016 8:42 AM, Arnd Bergmann wrote: On Friday, July 1, 2016 11:17:25 AM CEST Jon Mason wrote: On Fri, Jul 1, 2016 at 5:46 AM, Arnd Bergmann wrote: On Thursday, June 30, 2016 6:59:13 PM CEST Jon Mason wrote: + +Required properties: + - compatible: "brcm,bgmac-nsp" + -

Re: [PATCH net-next] lpc_eth: remove unused variable

2016-07-04 Thread Sylvain Lemieux
On Mon, 2016-07-04 at 15:19 +0200, Arnd Bergmann wrote: > A cleanup patch removed the only user of a local variable, as > indicated by a gcc warning. > > drivers/net/ethernet/nxp/lpc_eth.c: In function 'lpc_eth_ioctl': > drivers/net/ethernet/nxp/lpc_eth.c:1183:24: error: unused variable 'pldat'

Re: [PATCH v2 net-next 1/1] net sched actions: mirred add support for setting Dst MAC address

2016-07-04 Thread Jiri Pirko
Sat, Jul 02, 2016 at 04:34:25PM CEST, j...@mojatatu.com wrote: >From: Jamal Hadi Salim > >Often redirecting or mirroring requires that we set the dstMAC address >of the target device. While it is possible to pipe to a pedit action, >this patch obsoletes the need for that. This

[PATCH -next] dwc_eth_qos: remove unused including

2016-07-04 Thread weiyj_lk
From: Wei Yongjun Remove including that don't need it. Signed-off-by: Wei Yongjun --- drivers/net/ethernet/synopsys/dwc_eth_qos.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/synopsys/dwc_eth_qos.c

[PATCH -next] net: hns: fix return value check in hns_dsaf_get_cfg()

2016-07-04 Thread weiyj_lk
From: Wei Yongjun In case of error, function devm_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Also removed unneeded error handling on the result of call to

Re: ethtool needs a new maintainer

2016-07-04 Thread Jiri Pirko
Mon, Jun 27, 2016 at 03:51:47PM CEST, linvi...@tuxdriver.com wrote: >On Sun, Jun 26, 2016 at 06:11:41PM +0200, Ben Hutchings wrote: >> I've become steadily less enthusiastic and less responsive as a >> maintainer over the past year or so.  I no longer work on networking >> regularly, so it takes a

[PATCH net-next 6/8] net/mlx5e: Add support to get ethtool flow rules

2016-07-04 Thread Saeed Mahameed
From: Maor Gottlieb Enhance the existing get_rxnfc callback: 1. Get flow rule of specific ID. 2. Get all flow rules. 3. Get number of rules. Signed-off-by: Maor Gottlieb Signed-off-by: Saeed Mahameed ---

[PATCH net-next 1/8] net/mlx5: Refactor mlx5_add_flow_rule

2016-07-04 Thread Saeed Mahameed
From: Maor Gottlieb Reduce the set of arguments passed to mlx5_add_flow_rule by introducing flow_spec structure. Signed-off-by: Maor Gottlieb Signed-off-by: Saeed Mahameed --- drivers/infiniband/hw/mlx5/main.c |

[PATCH net-next 3/8] net/mlx5: Properly remove all steering objects

2016-07-04 Thread Saeed Mahameed
From: Maor Gottlieb Instead of explicitly cleaning up the well known parts of the steering tree, we use the generic tree structure to traverse for cleanup. No functional changes. Signed-off-by: Maor Gottlieb Signed-off-by: Saeed Mahameed

[PATCH net-next 2/8] net/mlx5: Introduce mlx5_flow_steering structure

2016-07-04 Thread Saeed Mahameed
From: Maor Gottlieb Instead of having all steering private name spaces and steering module fields flat in mlx5_core_priv, we wrap them in mlx5_flow_steering for better modularity and API exposure. Signed-off-by: Maor Gottlieb Signed-off-by: Saeed

[PATCH net-next 5/8] net/mlx5e: Support l3/l4 flow type specs in ethtool flow steering

2016-07-04 Thread Saeed Mahameed
From: Maor Gottlieb Add support to add flow steering rules with ethtool of L3/L4 flow types (ip4/tcp4/udp4). Those rules will be in higher priority than l2 flow rules, in order to prefer more specific rules. Mask is not supported for l3/l4 flow types. Signed-off-by: Maor

[PATCH net-next 8/8] net/mlx5e: Expose flow control counters to ethtool

2016-07-04 Thread Saeed Mahameed
From: Gal Pressman Just like per prio counters, the global flow counters are queried from per priority counters register. Global flow control counters are stored in priority 0 PFC counters. Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed

[PATCH net-next 4/8] net/mlx5e: Add ethtool flow steering support

2016-07-04 Thread Saeed Mahameed
From: Maor Gottlieb Implement etrhtool set_rxnfc callback to support ethtool flow spec direct steering. This patch adds only the support of ether flow type spec. L3/L4 flow specs support will be added in downstream patches. Signed-off-by: Maor Gottlieb

[PATCH net-next 0/8] Mellanox 100G mlx5 ethtool ntuple steering

2016-07-04 Thread Saeed Mahameed
Hi Dave, This series adds Ethernet ethtool ntuple steering 'ethtool -N|U' and exposes two more counter sets to Ethtool statistics, RDMA vport and global flow control statistics. We start from three refactoring patches of the flow steering infrastructure - mlx5_add_flow_rule will now

[PATCH net-next 7/8] net/mlx5e: Expose RDMA VPort counters to ethtool

2016-07-04 Thread Saeed Mahameed
From: Gal Pressman Add the needed descriptors to expose RoCE RDMA counters. Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_stats.h | 16 1 file changed, 16

[PATCH -next] hfsc: reduce hfsc_sched to 14 cachelines

2016-07-04 Thread Florian Westphal
hfsc_sched is huge (size: 920, cachelines: 15), but we can get it to 14 cachelines by placing level after filter_cnt (covering 4 byte hole) and reducing period/nactive/flags to u32 (period is just a counter, incremented when class becomes active -- 2**32 is plenty for this purpose, also, long is

Re: [RFC PATCH v2 1/4] Documentation: DT: net: Add Xilinx gmiitorgmii converter device tree binding documentation

2016-07-04 Thread Andrew Lunn
On Mon, Jul 04, 2016 at 02:34:41PM +0530, Kedareswara rao Appana wrote: > Device-tree binding documentation for xilinx gmiitorgmii converter. > > Signed-off-by: Kedareswara rao Appana > --- > Changes for v2: > --> New patch. > >

Re: [PATCH] net: check for NULL net_device in FIB tables

2016-07-04 Thread Vegard Nossum
On 07/04/2016 02:47 PM, Vegard Nossum wrote: struct fib_nh->nh_dev can be NULL, so we should check it before calling __in_dev_get_rcu on it. That should say __in_dev_get_rtnl(), obviously. Multiple places seem to want this (and check the return value), so we can add a convenience wrapper

Re: [PATCH] net-next: mediatek: remove superfluous free_irq() call

2016-07-04 Thread Arnd Bergmann
On Monday, July 4, 2016 3:37:10 PM CEST John Crispin wrote: > Commit 8067302973a1 ("net-next: mediatek: add support for IRQ grouping") > adds handling for irq 1 and 2 to the uninit function but did not remove > irq 0 which is not used since irq grouping was introduced. Fix this by > removing the

[PATCH] net-next: mediatek: remove superfluous free_irq() call

2016-07-04 Thread John Crispin
Commit 8067302973a1 ("net-next: mediatek: add support for IRQ grouping") adds handling for irq 1 and 2 to the uninit function but did not remove irq 0 which is not used since irq grouping was introduced. Fix this by removing the superfluous call to free_irq(). Reported-by: Arnd Bergmann

[PATCH net-next] lpc_eth: remove unused variable

2016-07-04 Thread Arnd Bergmann
A cleanup patch removed the only user of a local variable, as indicated by a gcc warning. drivers/net/ethernet/nxp/lpc_eth.c: In function 'lpc_eth_ioctl': drivers/net/ethernet/nxp/lpc_eth.c:1183:24: error: unused variable 'pldat' [-Werror=unused-variable] This removes the variable as well.

[PATCH] net: lpc_eth: Remove unused 'pldat' variable

2016-07-04 Thread Fabio Estevam
Since commit f786f3564c4f02d5026 ("net: ethernet: lpc_eth: use phydev from struct net_device") the 'pldat' variable became unused, so just remove it. Reported-by: Olof's autobuilder Signed-off-by: Fabio Estevam --- drivers/net/ethernet/nxp/lpc_eth.c | 1 -

[PATCH 06/11] batman-adv: Fix bat_(iv|v) function declaration header

2016-07-04 Thread Simon Wunderlich
From: Sven Eckelmann The bat_algo.h had some functions declared which were not part of the bat_algo.c file. These are instead stored in bat_v.c and bat_iv_ogm.c. The declaration should therefore be also in bat_v.h and bat_iv_ogm,h to make them easier to find. Signed-off-by:

[PATCH 03/11] batman-adv: split tvlv into a separate file

2016-07-04 Thread Simon Wunderlich
From: Markus Pargmann The tvlv functionality in main.c is mostly unrelated to the rest of the content. It still takes up a large portion of this source file (~45%, 588 lines). Moving it to a separate file makes it better visible as a main component of the batman-adv

Re: [PATCH net,stable] cdc_ncm: workaround for EM7455 "silent" data interface

2016-07-04 Thread Oliver Neukum
On Mon, 2016-07-04 at 13:40 +0200, Bjørn Mork wrote: > Oliver Neukum writes: > > On Sun, 2016-07-03 at 22:24 +0200, Bjørn Mork wrote: > >> Several Lenovo users have reported problems with their Sierra > >> Wireless EM7455 modem. The driver has loaded successfully and > >> the

[PATCH 05/11] batman-adv: Consolidate logging related functions

2016-07-04 Thread Simon Wunderlich
From: Sven Eckelmann There are several places in batman-adv which provide logging related functions. These should be grouped together in the log.* files to make them easier to find. Reported-by: Markus Pargmann Signed-off-by: Sven Eckelmann

[PATCH 10/11] batman-adv: throughput meter implementation

2016-07-04 Thread Simon Wunderlich
From: Antonio Quartulli The throughput meter module is a simple, kernel-space replacement for throughtput measurements tool like iperf and netperf. It is intended to approximate TCP behaviour. It is invoked through batctl: the protocol is connection oriented,

[PATCH 07/11] batman-adv: add generic netlink family for batman-adv

2016-07-04 Thread Simon Wunderlich
From: Matthias Schiffer debugfs is currently severely broken virtually everywhere in the kernel where files are dynamically added and removed (see http://lkml.iu.edu/hypermail/linux/kernel/1506.1/02196.html for some details). In addition to that, debugfs is not

[PATCH 08/11] batman-adv: add netlink command to query generic mesh information files

2016-07-04 Thread Simon Wunderlich
From: Matthias Schiffer BATADV_CMD_GET_MESH_INFO is used to query basic information about a batman-adv softif (name, index and MAC address for both the softif and the primary hardif; routing algorithm; batman-adv version). Signed-off-by: Matthias Schiffer

[PATCH 01/11] batman-adv: Include main.h in bat_v_ogm.h

2016-07-04 Thread Simon Wunderlich
From: Sven Eckelmann main.h includes statements which (re)define preprocessor variables which influence the compiled code. This makes it necessary to include it in all files. For example, it redefines pr_fmt used to the module as prefix for each pr_* message. Reported-by:

[PATCH 11/11] batman-adv: split routing API data structure in subobjects

2016-07-04 Thread Simon Wunderlich
From: Antonio Quartulli The routing API data structure contains several function pointers that can easily be grouped together based on the component they work with. Split the API in subobjects in order to improve definition readability. At the same time, remove the "bat_"

[PATCH 09/11] batman-adv: return netdev status in the TX path

2016-07-04 Thread Simon Wunderlich
From: Antonio Quartulli Return the proper netdev TX status along the TX path so that the tp_meter can understand when the queue is full and should stop sending packets. Signed-off-by: Antonio Quartulli Signed-off-by: Sven

[PATCH 02/11] batman-adv: Keep includes ordered by filename

2016-07-04 Thread Simon Wunderlich
From: Sven Eckelmann It is easier to detect if a include is already there for a used functionality when the includes are ordered. Using an alphabetic order together with the grouping in commit 1e2c2a4fe4a5 ("batman-adv: Add required includes to all files") makes includes

[PATCH 04/11] batman-adv: move bat_algo functions into a separate file

2016-07-04 Thread Simon Wunderlich
From: Sven Eckelmann The bat_algo functionality in main.c is mostly unrelated to the rest of the content. It still takes up a large portion of this source file (~15%, 103 lines). Moving it to a separate file makes it better visible as a main component of the batman-adv

  1   2   >