[PATCH] net/irda: fix NULL pointer dereference on memory allocation failure

2016-07-22 Thread Vegard Nossum
I ran into this: kasan: CONFIG_KASAN_INLINE enabled kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] PREEMPT SMP KASAN CPU: 2 PID: 2012 Comm: trinity-c3 Not tainted 4.7.0-rc7+ #19 Hardware name: QEMU Standard PC (i440FX +

[PATCH net-next] sctp: also point GSO head_skb to the sk when it's available

2016-07-22 Thread Marcelo Ricardo Leitner
The head skb for GSO packets won't travel through the inner depths of SCTP stack as it doesn't contain any chunks on it. That means skb->sk doesn't get set and then when sctp_recvmsg() calls sctp_inet6_skb_msgname() on the head_skb it panics, as this last needs to check flags at the socket

[PATCH net] sctp: fix BH handling on socket backlog

2016-07-22 Thread Marcelo Ricardo Leitner
Now that the backlog processing is called with BH enabled, we have to disable BH before taking the socket lock via bh_lock_sock() otherwise it may dead lock: sctp_backlog_rcv() bh_lock_sock(sk); if (sock_owned_by_user(sk)) { if

Re: [PATCH net-next v3] cdc_ether: Improve ZTE MF823/831/910 handling

2016-07-22 Thread kbuild test robot
Hi, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Kristian-Evensen/cdc_ether-Improve-ZTE-MF823-831-910-handling/20160723-093100 config: x86_64-randconfig-i0-201629 (attached as .config) compiler: gcc-4.9 (Debian 4.9.3-14) 4.9.3 reproduce:

Re: [PATCH v2 00/10] userns: sysctl limits for namespaces

2016-07-22 Thread Eric W. Biederman
Kees Cook writes: > On Fri, Jul 22, 2016 at 11:45 AM, Eric W. Biederman > wrote: >> Colin Walters writes: >> >>> On Thu, Jul 21, 2016, at 12:39 PM, Eric W. Biederman wrote: This patchset addresses two use cases: -

[PATCH v18 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-07-22 Thread Dexuan Cui
Hyper-V Sockets (hv_sock) supplies a byte-stream based communication mechanism between the host and the guest. It's somewhat like TCP over VMBus, but the transportation layer (VMBus) is much simpler than IP. With Hyper-V Sockets, applications between the host and the guest can talk to each other

[PATCH v18 net-next 0/1] introduce Hyper-V VM Sockets(hv_sock)

2016-07-22 Thread Dexuan Cui
Hyper-V Sockets (hv_sock) supplies a byte-stream based communication mechanism between the host and the guest. It's somewhat like TCP over VMBus, but the transportation layer (VMBus) is much simpler than IP. With Hyper-V Sockets, applications between the host and the guest can talk to each other

[PATCH net-next 2/2] be2net: query temperature on probe and decrease its frequency on be_worker()

2016-07-22 Thread Guilherme G. Piccoli
Currently the be2net driver queries the temperature from fw in regular intervals on be_worker(), which is a delayed work procedure that reschedules itself to run in next second. The interval for temperature query is currently set to 64, meaning at each 64 seconds the query will happen on

[PATCH net-next 1/2] be2net: set temperature value for all adapter's functions

2016-07-22 Thread Guilherme G. Piccoli
Temperature values on be2net driver are made available to userspace via hwmon abstraction, so tools like lm-sensors can present them to the user. The driver provides hwmon structures for each adapter's function. Nevertheless, the temperature information come from fw queries performed by

Re: [PATCH v4 1/2] bpf: Add bpf_probe_write BPF helper to be called in tracers (kprobes)

2016-07-22 Thread Sargun Dhillon
On Fri, Jul 22, 2016 at 11:53:52AM +0200, Daniel Borkmann wrote: > On 07/22/2016 04:14 AM, Alexei Starovoitov wrote: > >On Thu, Jul 21, 2016 at 06:09:17PM -0700, Sargun Dhillon wrote: > >>This allows user memory to be written to during the course of a kprobe. > >>It shouldn't be used to implement

[PATCH net-next] hv_netvsc: Fix VF register on bonding devices

2016-07-22 Thread Haiyang Zhang
From: Haiyang Zhang Added a condition to avoid bonding devices with same MAC registering as VF. Signed-off-by: Haiyang Zhang Reviewed-by: K. Y. Srinivasan --- drivers/net/hyperv/netvsc_drv.c |4 ++-- 1 files changed, 2

Re: [PATCH] iproute2: ip: add udp_csum, udp6_csum_tx, udp6_csum_rx control flags to ip l2tp add tunnel

2016-07-22 Thread Stephen Hemminger
On Thu, 21 Jul 2016 18:59:10 +0800 Shanker Wang wrote: > Three options are added for the user to control > whether the checksum is enabled > > Signed-off-by: Miao Wang Applied. I changed the subject (commit summary) to be

Re: ref count of ib_ipoib.ko not incremented when an ip address is set

2016-07-22 Thread Stephen Hemminger
On Fri, 22 Jul 2016 11:16:02 +0300 Nikolay Borisov wrote: > Hello, > > I accidentally saw that even having an ip address on an > ipoib interface doesn't increment the usage count of the > ib_ipoib.ko module: > > ip a l dev ib0 > 14: ib0:

[PATCH RFC 1/1] xfrm: dst lookup doesn't account for fwmark

2016-07-22 Thread Doug Applegate
If route table includes routing based on fwmark, xfrm will not take it into account when routing ipsec traffic. We address this issue by adding fwmark information before calling route lookup. Signed-off-by: Doug Applegate --- include/net/xfrm.h | 3 ++-

[PATCH RFC 0/1] xfrm: dst lookup doesn't account for fwmark

2016-07-22 Thread Doug Applegate
I ran into an issue trying to route outgoing ipsec traffic from an ipsec responder hub that uses fwmark to route out a specific interface. The fwmark points to a route table that contains a default route out a specific interface. The fwmark is applied based on incoming interface of incoming

Re: [PATCH v2 00/10] userns: sysctl limits for namespaces

2016-07-22 Thread Kees Cook
On Fri, Jul 22, 2016 at 11:45 AM, Eric W. Biederman wrote: > Colin Walters writes: > >> On Thu, Jul 21, 2016, at 12:39 PM, Eric W. Biederman wrote: >>> >>> This patchset addresses two use cases: >>> - Implement a sane upper bound on the number of

Re: [PATCH] net: davinci_cpdma: remove excessive dump of register values to kernel log

2016-07-22 Thread kbuild test robot
Hi, [auto build test WARNING on net-next/master] [also build test WARNING on v4.7-rc7 next-20160722] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Uwe-Kleine-K-nig/net-davinci_cpdma-remove

[PATCH 7/9] staging: slicoss: dont use a structure but offsets for register accesses

2016-07-22 Thread Lino Sanfilippo
Use the new register accessors that use offsets instead of the slic_regs structure to read/write registers. Since not longer needed remove the structure completley. Signed-off-by: Lino Sanfilippo --- drivers/staging/slicoss/slic.h| 1 -

[PATCH 8/9] staging: slicoss: improve implementation concerning the shared memory

2016-07-22 Thread Lino Sanfilippo
Remove the volatile specifiers of struct slic_shmem. Furthermore store the bus addresses for the isr pointer, link status and statistics separately and access the upper and lower word of these addresses by means of [lower|upper]_32_bits(). By doing this take the endianness into account.

[PATCH 6/9] staging: slicoss: avoid PCI write posting

2016-07-22 Thread Lino Sanfilippo
Introduce the function slic_flush_write() which reads from the HOSTID register and can be used to avoid PCI write posting. Use the function at several critical places in the code. Signed-off-by: Lino Sanfilippo --- drivers/staging/slicoss/slic.h| 5 +

[PATCH 9/9] staging: slicoss: simplify struct for statistics

2016-07-22 Thread Lino Sanfilippo
Merge several structures for statistics to one structure and remove unnecessary union nesting. Signed-off-by: Lino Sanfilippo --- drivers/staging/slicoss/slic.h| 18 + drivers/staging/slicoss/slichw.h | 79 ---

[PATCH 5/9] staging: slicoss: introduce register accessors that use register offsets

2016-07-22 Thread Lino Sanfilippo
Introduce accessor functions that read and write registers by using a register offset. This is in preparation to replace the register addressing by means of the slic_regs struct with an addressing by means of offsets. Signed-off-by: Lino Sanfilippo ---

[PATCH 2/9] staging: slicoss: notifiy network stack about change in link state

2016-07-22 Thread Lino Sanfilippo
Notify the network stack about link states via netif_carrier_[off|on](). Also set the link state off initially and when the interface is brought down. Signed-off-by: Lino Sanfilippo --- drivers/staging/slicoss/slicoss.c | 8 1 file changed, 8 insertions(+) diff

[PATCH 1/9] staging: slicoss: handle allocation failure in slic_init_adapter

2016-07-22 Thread Lino Sanfilippo
The memory allocation in slic_init_adapter() can fail. Return an error in this case and unwind properly. Also make sure that the allocated memory is properly freed in case of an error in the calling probe() function. By doing this also replace the alloc() followed by memset to zero the memory with

Slicoss fixes and improvements

2016-07-22 Thread Lino Sanfilippo
Hi, this patch series tries to get the slicoss driver code closer to a state in which it is ready to be moved out of staging. Patch 1 is a resend of patch I sent a week ago and handles an allocation failure in slic_init_adapter(). Patch 2 fixes link state notification. Patch 3 turns the

[PATCH 4/9] staging: slicoss: start tx queue when interface is brought up

2016-07-22 Thread Lino Sanfilippo
There is no reason to delay tx queue activation until a link is detected. So start the queue when the interface is brought up and stop it when the interface is brought down. Signed-off-by: Lino Sanfilippo --- drivers/staging/slicoss/slicoss.c | 5 +++-- 1 file changed, 3

[PATCH 3/9] staging: slicoss: ensure mapping of io-memory is uncached

2016-07-22 Thread Lino Sanfilippo
From: Lino Sanfilippo Writes to registers should be done uncached for various reasons. Ensure this by replacing ioremap() with ioremap_nocache(). Signed-off-by: Lino Sanfilippo --- drivers/staging/slicoss/slicoss.c | 2 +- 1 file changed, 1

Re: strange Mac OSX RST behavior

2016-07-22 Thread Jason Baron
Hi, After looking at this further we found that there is actually a rate limit on 'rst' packets sent by OSX on a closed socket. Its set to 250 per second and controlled via: net.inet.icmp.icmplim. Increasing that limit resolves the issue, but the default is apparently 250. Thanks, -Jason On

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-22 Thread Stefan Lippers-Hollmann
Hi On 2016-07-22, Arnd Bergmann wrote: > On Friday, July 22, 2016 7:55:36 AM CEST Jes Sorensen wrote: > > Stefan Lippers-Hollmann writes: > > > On 2016-07-20, Arnd Bergmann wrote: > > >> On Wednesday, July 20, 2016 11:33:43 AM CEST Jes Sorensen wrote: > > >> > Arnd Bergmann

[PATCH] net: davinci_cpdma: remove excessive dump of register values to kernel log

2016-07-22 Thread Uwe Kleine-König
Such a big dump of register values is hardly useful on a production system. Another downside of the now removed functions is that calling emac_dump_regs resulted in at least 87 calls to dev_info while holding a spinlock and having irqs off which is a big source of latency. Signed-off-by: Uwe

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-22 Thread Arnd Bergmann
On Friday, July 22, 2016 7:55:36 AM CEST Jes Sorensen wrote: > Stefan Lippers-Hollmann writes: > > Hi > > > > On 2016-07-20, Arnd Bergmann wrote: > >> On Wednesday, July 20, 2016 11:33:43 AM CEST Jes Sorensen wrote: > >> > Arnd Bergmann writes: > >> > > On

Re: [patch net-next v2 0/9] mlxsw: implement port mirroring offload

2016-07-22 Thread Jiri Pirko
Fri, Jul 22, 2016 at 09:26:30PM CEST, f.faine...@gmail.com wrote: >On 07/22/2016 12:20 PM, Jiri Pirko wrote: >> Fri, Jul 22, 2016 at 08:24:31PM CEST, f.faine...@gmail.com wrote: >>> On 07/21/2016 03:03 AM, Jiri Pirko wrote: From: Jiri Pirko This patchset

Re: iproute2 mpls max labels

2016-07-22 Thread Eric W. Biederman
Magnus Bergroth writes: >> Eric W. Biederman >> a) I just looked and the kernel netlink protocol does not have a limit. >>The kernel does have a limit but the netlink protocol does not so >>there is no point in exporting a limit in a

Re: iproute2 mpls max labels

2016-07-22 Thread Eric W. Biederman
Roopa Prabhu writes: > On 7/21/16, 1:00 PM, Eric W. Biederman wrote: >> Roopa Prabhu writes: >> >>> On 7/16/16, 11:24 AM, Magnus Bergroth wrote: Wanted to use more than the default maximum of 8 mpls labels. Max labels seems to be

Re: [patch net-next v2 0/9] mlxsw: implement port mirroring offload

2016-07-22 Thread Florian Fainelli
On 07/22/2016 12:20 PM, Jiri Pirko wrote: > Fri, Jul 22, 2016 at 08:24:31PM CEST, f.faine...@gmail.com wrote: >> On 07/21/2016 03:03 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> This patchset introduces tc matchall classifier and its offload >>> to Spectrum hardware. In

Re: [patch net-next v2 0/9] mlxsw: implement port mirroring offload

2016-07-22 Thread Jiri Pirko
Fri, Jul 22, 2016 at 08:24:31PM CEST, f.faine...@gmail.com wrote: >On 07/21/2016 03:03 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> This patchset introduces tc matchall classifier and its offload >> to Spectrum hardware. In combination with mirred action, defined port >>

Re: [patch net-next v2 1/9] mlxsw: pci: Add resources query implementation.

2016-07-22 Thread Jiri Pirko
Fri, Jul 22, 2016 at 07:17:14PM CEST, d...@cumulusnetworks.com wrote: >On 7/21/16 4:03 AM, Jiri Pirko wrote: >>From: Nogah Frankel >> >>Add resources query implementation. If exists, query the HW for its >>builtin resources instead of having them as consts in the code. >>

Re: [PATCH v2 00/10] userns: sysctl limits for namespaces

2016-07-22 Thread Eric W. Biederman
Colin Walters writes: > On Thu, Jul 21, 2016, at 12:39 PM, Eric W. Biederman wrote: >> >> This patchset addresses two use cases: >> - Implement a sane upper bound on the number of namespaces. >> - Provide a way for sandboxes to limit the attack surface from >> namespaces.

Re: [patch net-next v2 0/9] mlxsw: implement port mirroring offload

2016-07-22 Thread Florian Fainelli
On 07/21/2016 03:03 AM, Jiri Pirko wrote: > From: Jiri Pirko > > This patchset introduces tc matchall classifier and its offload > to Spectrum hardware. In combination with mirred action, defined port > mirroring > setup is offloaded by mlxsw/spectrum driver. > > The

[PATCH] kcm: remove redundant -ve error check and return path

2016-07-22 Thread Colin King
From: Colin Ian King The check for a -ve error is redundant, remove it and just immediately return the return value from the call to seq_open_net. Signed-off-by: Colin Ian King --- net/kcm/kcmproc.c | 6 +- 1 file changed, 1

Re: [PATCH v2] net: ipv6: Always leave anycast and multicast groups on link down

2016-07-22 Thread David Ahern
On 7/22/16 11:32 AM, Mike Manning wrote: Default kernel behavior is to delete IPv6 addresses on link down, which entails deletion of the multicast and the subnet-router anycast addresses. These deletions do not happen with sysctl setting to keep global IPv6 addresses on link down, so every link

[PATCH v2] net: ipv6: Always leave anycast and multicast groups on link down

2016-07-22 Thread Mike Manning
Default kernel behavior is to delete IPv6 addresses on link down, which entails deletion of the multicast and the subnet-router anycast addresses. These deletions do not happen with sysctl setting to keep global IPv6 addresses on link down, so every link down/up causes an increment of the anycast

[patch iproute2 2/2] devlink: add option to generate JSON output

2016-07-22 Thread Jiri Pirko
From: Jiri Pirko For parsing by another app it is convenient to produce output in JSON format. Signed-off-by: Jiri Pirko --- devlink/devlink.c | 455 +++--- 1 file changed, 362 insertions(+), 93 deletions(-)

[patch iproute2 1/2] devlink: write usage help messages to stderr

2016-07-22 Thread Jiri Pirko
From: Jiri Pirko In order to not confuse reader, write help messages into stderr. Signed-off-by: Jiri Pirko --- devlink/devlink.c | 46 +++--- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git

Re: [PATCH 1/3] net: ethernet: ti: cpdma: fix lockup in cpdma_ctlr_destroy()

2016-07-22 Thread kbuild test robot
Hi, [auto build test WARNING on net-next/master] [also build test WARNING on v4.7-rc7 next-20160722] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Grygorii-Strashko/drivers-net-cpsw-fix-driver

Re: [PATCH v4 1/2] bpf: Add bpf_probe_write BPF helper to be called in tracers (kprobes)

2016-07-22 Thread Alexei Starovoitov
On Fri, Jul 22, 2016 at 11:53:52AM +0200, Daniel Borkmann wrote: > On 07/22/2016 04:14 AM, Alexei Starovoitov wrote: > >On Thu, Jul 21, 2016 at 06:09:17PM -0700, Sargun Dhillon wrote: > >>This allows user memory to be written to during the course of a kprobe. > >>It shouldn't be used to implement

[PATCH net] bridge: Fix incorrect re-injection of LLDP packets

2016-07-22 Thread Ido Schimmel
Commit 8626c56c8279 ("bridge: fix potential use-after-free when hook returns QUEUE or STOLEN verdict") caused LLDP packets arriving through a bridge port to be re-injected to the Rx path with skb->dev set to the bridge device, but this breaks the lldpad daemon. The lldpad daemon opens a packet

Re: [PATCH V2] Add flow control to the portmapper

2016-07-22 Thread Shiraz Saleem
On Thu, Jul 21, 2016 at 08:29:42PM +0300, Leon Romanovsky wrote: > On Wed, Jul 20, 2016 at 09:47:50PM -0500, Shiraz Saleem wrote: > > On Tue, Jul 19, 2016 at 08:32:53PM +0300, Leon Romanovsky wrote: > > > On Tue, Jul 19, 2016 at 09:50:24AM -0500, Shiraz Saleem wrote: > > > > On Tue, Jul 19, 2016

Re: [PATCH 1/1] netfilter: udp: Remove a bit misleading comment in udp_pkt_to_tuple

2016-07-22 Thread Pablo Neira Ayuso
On Thu, Jul 21, 2016 at 05:26:47PM +0800, f...@ikuai8.com wrote: > From: Gao Feng Please, add description to your patches. Cc'ing netfilter-de...@vger.kernel.org is sufficient for netfilter patches unless you really want to attract attention from other netdev developers, and

pull-request: wireless-drivers-next 2016-07-22

2016-07-22 Thread Kalle Valo
Hi Dave, I'm sick so I have to keep this short, but here's the last pull request to net-next. This time there's a trivial conflict with mtd tree: http://lkml.kernel.org/g/20160720123133.44dab...@canb.auug.org.au We concluded with Brian (CCed) that it's best that we ask Linus to fix this. The

[PATCH -next] libcxgb: remove unused including

2016-07-22 Thread Wei Yongjun
Remove including that don't need it. Signed-off-by: Wei Yongjun --- drivers/net/ethernet/chelsio/libcxgb/libcxgb_ppm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/chelsio/libcxgb/libcxgb_ppm.c b/drivers/net/ethernet/chelsio/libcxgb/libcxgb_ppm.c

[PATCH 1/3] net: ethernet: ti: cpdma: fix lockup in cpdma_ctlr_destroy()

2016-07-22 Thread Grygorii Strashko
Fix deadlock in cpdma_ctlr_destroy() which is triggered now on cpsw module removal: cpsw_remove() - cpdma_ctlr_destroy() - spin_lock_irqsave(>lock, flags) - cpdma_ctlr_stop() - spin_lock_irqsave(>lock, flags); <- deadlock - cpdma_chan_destroy() - spin_lock_irqsave(>lock,

[PATCH 3/3] drivers: net: cpsw: use of_platform_depopulate()

2016-07-22 Thread Grygorii Strashko
Use of_platform_depopulate() in cpsw_remove() instead of of_device_unregister(), because CSPW child devices will not be recreated otherwise on next insmod. of_platform_depopulate() is correct way now as it will ensure that all steps done in of_platform_populate() are reverted, including cleaning

[PATCH 0/3] drivers: net: cpsw: fix driver loading/unloading

2016-07-22 Thread Grygorii Strashko
This series fixes set of isssues observed when CPSW driver module is unloaded/loaded: 1) rmmod: deadlock in cpdma_ctlr_destroy 2) rmmod: L3 back-trace and crash if all net interfaces are down, because CPSW can be powerred down by PM runtime in this case. 3) insmod: mdio device is not recreated on

[PATCH 2/3] drivers: net: cpsw: fix wrong regs access in cpsw_remove

2016-07-22 Thread Grygorii Strashko
The L3 error will be generated and system will crash during unloading of CPSW driver if CPSW is used as module and ethX devices are down. This happens because CPSW can be power off by PM runtime now when ethX devices are down. Hence, ensure that CPSW powered up by PM runtime before performing any

Re: [PATCH net-next] sctp: use inet_recvmsg to support sctp RFS well

2016-07-22 Thread Marcelo Ricardo Leitner
On Fri, Jul 22, 2016 at 09:25:42PM +0800, Xin Long wrote: > Commit 486bdee0134c ("sctp: add support for RPS and RFS") > saves skb->hash into sk->sk_rxhash so that the inet_* can > record it to flow table. > > But sctp uses sock_common_recvmsg as .recvmsg instead > of inet_recvmsg,

Re: [PATCH v2 00/10] userns: sysctl limits for namespaces

2016-07-22 Thread Colin Walters
On Thu, Jul 21, 2016, at 12:39 PM, Eric W. Biederman wrote: > > This patchset addresses two use cases: > - Implement a sane upper bound on the number of namespaces. > - Provide a way for sandboxes to limit the attack surface from > namespaces. Perhaps this is obvious, but since you didn't

[PATCH net-next] sctp: use inet_recvmsg to support sctp RFS well

2016-07-22 Thread Xin Long
Commit 486bdee0134c ("sctp: add support for RPS and RFS") saves skb->hash into sk->sk_rxhash so that the inet_* can record it to flow table. But sctp uses sock_common_recvmsg as .recvmsg instead of inet_recvmsg, sock_common_recvmsg doesn't invoke sock_rps_record_flow to record the flow. It may

Re: [PATCH net-next] sctp: support ipv6 nonlocal bind

2016-07-22 Thread Marcelo Ricardo Leitner
On Fri, Jul 22, 2016 at 05:38:51PM +0800, Xin Long wrote: > This patch makes sctp support ipv6 nonlocal bind by adding > sp->inet.freebind and net->ipv6.sysctl.ip_nonlocal_bind > check in sctp_v6_available as what sctp did to support > ipv4 nonlocal bind (commit cdac4e077489). Next time please

[PATCH net 0/3] macsec: fix configurable ICV length

2016-07-22 Thread Davide Caratti
This series provides a fix for macsec configurable ICV length. The maximum length of ICV element has been made compliant to IEEE 802.1AE, and error reporting in case of cipher suite configuration failure has been improved. Finally, a test has been added to netlink verify() callback in order to

[PATCH net 2/3] macsec: fix error codes when a SA is created

2016-07-22 Thread Davide Caratti
preserve the return value of AEAD functions that are called when a SA is created, to avoid inappropriate display of "RTNETLINK answers: Cannot allocate memory" message. Signed-off-by: Davide Caratti --- drivers/net/macsec.c | 58

[PATCH net 1/3] macsec: limit ICV length to 16 octets

2016-07-22 Thread Davide Caratti
IEEE 802.1AE-2006 standard recommends that the ICV element in a MACsec frame should not exceed 16 octets: add MACSEC_STD_ICV_LEN in uapi definitions accordingly, and avoid accepting configurations where the ICV length exceeds the standard value. Leave definition of MACSEC_MAX_ICV_LEN unchanged for

[PATCH net 3/3] macsec: validate ICV length on link creation

2016-07-22 Thread Davide Caratti
Test the cipher suite initialization in case ICV length has a value different than its default. If this test fails, creation of a new macsec link will also fail. This avoids situations where further security associations can't be added due to failures of crypto_aead_setauthsize(), caused by

Re: [PATCH] net: neigh: disallow state transition DELAY->STALE in neigh_update()

2016-07-22 Thread Chunhui He
Hi, On Fri, 22 Jul 2016 10:20:01 +0300 (EEST), Julian Anastasov wrote: > > Hello, > > On Thu, 21 Jul 2016, Chunhui He wrote: > >> If neigh entry was CONNECTED and address is not changed, and if new state is >> STALE, entry state will not change. Because DELAY is not in

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-22 Thread Jes Sorensen
Stefan Lippers-Hollmann writes: > Hi > > On 2016-07-20, Arnd Bergmann wrote: >> On Wednesday, July 20, 2016 11:33:43 AM CEST Jes Sorensen wrote: >> > Arnd Bergmann writes: >> > > On Wednesday, July 20, 2016 7:25:19 AM CEST Jes Sorensen wrote: >> > >> Arnd

Aw: Re: BUG: Wrong dma queue handling in ixp4 driver

2016-07-22 Thread Lino Sanfilippo
Hi Krzysztof, > > Not really: there is one pool for all ports, but each port uses > a separate desc_tab (allocated from that pool). right, but even then using a dma pool seems to be a bit of overhead for only a few allocations. As far as I understood those pools are meant for hundrets or

[net-next PATCH 2/4] be2net: do not remove vids from driver table if be_vid_config() fails.

2016-07-22 Thread Sathya Perla
The driver currently removes a new vid from the adapter->vids[] array if be_vid_config() returns an error, which occurs when there is an error in HW/FW. This is wrong. After the HW/FW error is recovered from, we need the complete vids[] array to re-program the vlan list. Signed-off-by: Sathya

[net-next PATCH 1/4] be2net: clear vlan-promisc setting before programming the vlan list

2016-07-22 Thread Sathya Perla
From: Somnath Kotur The Lancer FW has a bug due to which in some cases vlan-promisc setting is cleared eventhough the vlan-list programming did not succeed (via VLAN_CONFIG) cmd. The driver has no way of knowing if the vlan-promisc mode was cleared or not when this cmd

[net-next PATCH 0/4] be2net: patch set

2016-07-22 Thread Sathya Perla
Hi David, pls consider applying this patch-set to the net-next tree. Patch 1 fixes the driver to workaournd a bug in the Lancer FW in the vlan-config cmd processing. The FW in some cases clears the vlan-promisc setting even if it cannot apply the vlan filter. The driver has no means of knowing if

[net-next PATCH 4/4] be2net: replace polling with sleeping in the FW completion path

2016-07-22 Thread Sathya Perla
The ndo_set_rx_mode() and ndo_add/del_vxlan_port() calls may be called with BHs disabled. The driver currently issues the required cmds to the FW in these contexts and polls on completions from the FW, while BHs remain disabled. This can cause either packet loss or packet reception to be delayed

[net-next PATCH 3/4] be2net: Avoid unnecessary firmware updates of multicast list

2016-07-22 Thread Sathya Perla
From: Sriharsha Basavapatna Eachtime the ndo_set_rx_mode() routine is called, the driver programs the multicast list in the adapter without checking if there are any changes to the list. This leads to a flood of RX_FILTER cmds when a number of vlan interfaces

Re: Aw: BUG: Wrong dma queue handling in ixp4 driver

2016-07-22 Thread Krzysztof Hałasa
Hi Lino, "Lino Sanfilippo" writes: >> maybe I miss something, but the ixp4 ethernet driver seems to handle dma >> pools >> in a wrong way: In init_queues() it creates a dma pool for descriptors and >> then >> only allocates a single descriptor from this pool. The

Re: [net-next PATCH 1/3] net: phy: dp83867: Add documentation for optional impedance control

2016-07-22 Thread Mugunthan V N
Rob, On Friday 22 July 2016 02:44 AM, Rob Herring wrote: > On Thu, Jul 21, 2016 at 11:52:36AM +0530, Sekhar Nori wrote: >> Nishanth, >> >> On Wednesday 20 July 2016 09:03 PM, Nishanth Menon wrote: >>> On 07/20/2016 09:56 AM, Mugunthan V N wrote: Add documention of ti,impedance-control which

Re: [PATCH v4 1/2] bpf: Add bpf_probe_write BPF helper to be called in tracers (kprobes)

2016-07-22 Thread Daniel Borkmann
On 07/22/2016 04:14 AM, Alexei Starovoitov wrote: On Thu, Jul 21, 2016 at 06:09:17PM -0700, Sargun Dhillon wrote: This allows user memory to be written to during the course of a kprobe. It shouldn't be used to implement any kind of security mechanism because of TOC-TOU attacks, but rather to

Re: [PATCH] net: neigh: disallow state transition DELAY->STALE in neigh_update()

2016-07-22 Thread Hannes Frederic Sowa
On 22.07.2016 09:20, Julian Anastasov wrote: > > Hello, > > On Thu, 21 Jul 2016, Chunhui He wrote: > >> If neigh entry was CONNECTED and address is not changed, and if new state is >> STALE, entry state will not change. Because DELAY is not in CONNECTED, it's >> possible to change state

[PATCH net-next] sctp: support ipv6 nonlocal bind

2016-07-22 Thread Xin Long
This patch makes sctp support ipv6 nonlocal bind by adding sp->inet.freebind and net->ipv6.sysctl.ip_nonlocal_bind check in sctp_v6_available as what sctp did to support ipv4 nonlocal bind (commit cdac4e077489). Reported-by: Shijoe George Signed-off-by: Xin Long

ref count of ib_ipoib.ko not incremented when an ip address is set

2016-07-22 Thread Nikolay Borisov
Hello, I accidentally saw that even having an ip address on an ipoib interface doesn't increment the usage count of the ib_ipoib.ko module: ip a l dev ib0 14: ib0: mtu 65520 qdisc pfifo_fast state UP qlen 256 link/infiniband

Re: [PATCH 1/1] lvs: Use IS_ERR_OR_NULL(svc) instead of IS_ERR(svc) || svc == NULL

2016-07-22 Thread Simon Horman
On Fri, Jul 22, 2016 at 08:04:50AM +0300, Julian Anastasov wrote: > > Hello, > > On Fri, 22 Jul 2016, f...@ikuai8.com.aqb.so wrote: > > > From: Gao Feng > > > > This minor refactoring does not change the logic of function > > ip_vs_genl_dump_dests. > > > >

[net-next 05/11] i40evf: add hyperv dev ids

2016-07-22 Thread Jeff Kirsher
From: Joshua Hay This patch adds the Hyper-V specific VF device ids. Change-ID: I9c4fe6d8dfd34f7f68ebc9fdae225c8768439c89 Signed-off-by: Joshua Hay Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

[net-next 06/11] i40e: refactor Rx filter handling

2016-07-22 Thread Jeff Kirsher
From: Mitch Williams Properly track filter adds and deletes so the driver doesn't lose filters during resets and up/down cycles. Add a tracking mechanism so that the driver knows when to enter and leave promiscuous mode. Implement a simple state machine so the driver

[net-next 08/11] i40e: Remove redundant memset

2016-07-22 Thread Jeff Kirsher
From: Amitoj Kaur Chawla Remove redundant call to memset before a call to memcpy. The Coccinelle semantic patch used to make this change is as follows: @@ expression e1,e2,e3,e4; @@ - memset(e1,e2,e3); memcpy(e1,e4,e3); Signed-off-by: Amitoj Kaur Chawla

[net-next 02/11] i40e: Fix to show correct Advertised Link Modes when link is down

2016-07-22 Thread Jeff Kirsher
From: Avinash Dayanand When link is down, Advertised Link Modes was wrongly displaying full supported link modes instead of Advertised link mode. Added conditional checks in order to make sure correct Advertised link modes are displayed when the link is down.

[net-next 10/11] i40e: add missing link advertise setting

2016-07-22 Thread Jeff Kirsher
From: Stefan Assmann Adding the missing link advertise for some X710 NICs. This can be observed by simply calling ethtool on the interface. root@rhel7:~ # ethtool eth0 Settings for eth0: Supported ports: [ FIBRE ] Supported link modes: 1baseT/Full

[net-next 04/11] i40e: Remove device ID 0x37D4

2016-07-22 Thread Jeff Kirsher
From: Catherine Sullivan This device ID is not needed, so take it out. Change-ID: I148d29f68a1f58b03980ecd83047a1b440f4f74d Signed-off-by: Catherine Sullivan Tested-by: Andrew Bowers Signed-off-by: Jeff

[net-next 09/11] i40e: Move the mutex lock in i40e_client_unregister

2016-07-22 Thread Jeff Kirsher
From: Catherine Sullivan We need to lock the client list around the i40e_client_release call to prevent the release from interrupting the client instances while they are being added. Change-Id: I3f20179aaf8730207833e7d0869d2ccffa1d Signed-off-by: Catherine

[net-next 00/11][pull request] 40GbE Intel Wired LAN Driver Updates 2016-07-22

2016-07-22 Thread Jeff Kirsher
This series contains updates to i40e and i40evf. Heinrich Schuchardt found a possible null pointer being dereferenced in i40e_debug_aq(), fixed the issue by doing the variable assignment after we are sure the pointer is not null. Avinash fixed an issue when link was down, we were not showing the

[net-next 01/11] i40e: avoid null pointer dereference

2016-07-22 Thread Jeff Kirsher
From: Heinrich Schuchardt In function i40e_debug_aq parameter desc is assumed to be possibly NULL. Do not dereference it before checking the value. Fixes: f905dd62be88 ("i40e/i40evf: add max buf len to aq debug print helper") Signed-off-by: Heinrich Schuchardt

[net-next 07/11] i40e/i40evf-bump version to 1.6.11

2016-07-22 Thread Jeff Kirsher
From: Bimmy Pujari Signed-off-by: Bimmy Pujari Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-

[net-next 03/11] i40e/i40evf: remove useless initializer

2016-07-22 Thread Jeff Kirsher
From: Mitch Williams This initializer isn't needed because the variable is assigned right away. Change-ID: I6ce3edb3f4e0364db248a7a0bcc62ca95c01d941 Signed-off-by: Mitch Williams Tested-by: Andrew Bowers

[net-next 11/11] i40e: Explicitly write platform-specific mac address after PF reset

2016-07-22 Thread Jeff Kirsher
From: Tushar Dave i40e PF reset clears mac filters. If platform-specific mac address is used, driver has to explicitly write default mac address to mac filters otherwise all incoming traffic destined to default mac address will be dropped after reset. This issue was

Re: [PATCH] net: neigh: disallow state transition DELAY->STALE in neigh_update()

2016-07-22 Thread Julian Anastasov
Hello, On Thu, 21 Jul 2016, Chunhui He wrote: > If neigh entry was CONNECTED and address is not changed, and if new state is > STALE, entry state will not change. Because DELAY is not in CONNECTED, it's > possible to change state from DELAY to STALE. > > That is bad. Consider a host in

[PATCH net-next v1 0/5] tipc: netlink updates for neighbour monitor

2016-07-22 Thread Parthasarathy Bhuvaragan
This series contains the updates to configure and read the attributes for neighbour monitor. Parthasarathy Bhuvaragan (5): tipc: introduce constants for tipc address validation tipc: make cluster size threshold for monitoring configurable tipc: get monitor threshold for the cluster tipc:

[PATCH net-next v1 1/5] tipc: introduce constants for tipc address validation

2016-07-22 Thread Parthasarathy Bhuvaragan
In this commit, we introduce defines for tipc address size, offset and mask specification for Zone.Cluster.Node. There is no functional change in this commit. Signed-off-by: Parthasarathy Bhuvaragan Reviewed-by: Jon Maloy ---

[PATCH net-next v1 4/5] tipc: add a function to get the bearer name

2016-07-22 Thread Parthasarathy Bhuvaragan
Introduce a new function to get the bearer name from its id. This is used in subsequent commit. Signed-off-by: Parthasarathy Bhuvaragan Reviewed-by: Jon Maloy --- net/tipc/bearer.c | 21 + net/tipc/bearer.h | 1

[PATCH net-next v1 5/5] tipc: dump monitor attributes

2016-07-22 Thread Parthasarathy Bhuvaragan
In this commit, we dump the monitor attributes when queried. The link monitor attributes are separated into two kinds: 1. general attributes per bearer 2. specific attributes per node/peer This style resembles the socket attributes and the nametable publications per socket. Signed-off-by:

[PATCH net-next v1 3/5] tipc: get monitor threshold for the cluster

2016-07-22 Thread Parthasarathy Bhuvaragan
In this commit, we add support to fetch the configured cluster monitoring threshold. Signed-off-by: Parthasarathy Bhuvaragan Reviewed-by: Jon Maloy --- include/uapi/linux/tipc_netlink.h | 1 + net/tipc/monitor.c|

[PATCH net-next v1 2/5] tipc: make cluster size threshold for monitoring configurable

2016-07-22 Thread Parthasarathy Bhuvaragan
In this commit, we introduce support to configure the minimum threshold to activate the new link monitoring algorithm. Signed-off-by: Parthasarathy Bhuvaragan Reviewed-by: Jon Maloy --- include/uapi/linux/tipc_netlink.h | 11

Re: iproute2 mpls max labels

2016-07-22 Thread Roopa Prabhu
On 7/21/16, 1:00 PM, Eric W. Biederman wrote: > Roopa Prabhu writes: > >> On 7/16/16, 11:24 AM, Magnus Bergroth wrote: >>> Wanted to use more than the default maximum of 8 mpls labels. Max labels >>> seems to be hardcode to 8 in two places. >>> >>> ---