Re: [PATCH 15/15] ethernet: ti: davinci_emac: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Mugunthan V N
On Wednesday 27 July 2016 07:50 AM, Peter Chen wrote: > of_node_put needs to be called when the device node which is got > from of_parse_phandle has finished using. > > Signed-off-by: Peter Chen > --- > drivers/net/ethernet/ti/davinci_emac.c | 1 + > 1 file changed, 1

RE: [PATCH net] be2net: perform temperature query in adapter regardless of its interface state

2016-07-26 Thread Sathya Perla
> -Original Message- > From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com] > > The be2net driver performs fw temperature queries on be_worker() routine, which is executed each second for > each be_adapter. There is a frequency threshold to avoid fw query to happens at each call

Re: [PATCH] xfrm: use printk instead of WARN for bad policy reporting

2016-07-26 Thread Herbert Xu
On Wed, Jul 20, 2016 at 01:53:12PM +0200, Vegard Nossum wrote: > On 07/20/2016 10:32 AM, Vegard Nossum wrote: > >AFAICT this message is just printed whenever input validation fails. > >This is a normal failure and we shouldn't be dumping the stack over it. > > > >Looks like it was originally a

linux-next: manual merge of the net-next tree with the arm-soc tree

2016-07-26 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: arch/arm64/boot/dts/apm/apm-shadowcat.dtsi between commit: cafc4cd0c8b8 ("arm64: dts: apm: Use lowercase consistently for hex constants") from the arm-soc tree and commit: 8e694cd2762c ("dtb: xgene: Add MDIO

[PATCH 14/15] ethernet: stmicro: stmmac: stmmac_platform: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH 15/15] ethernet: ti: davinci_emac: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/ti/davinci_emac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/ti/davinci_emac.c

[PATCH 12/15] ethernet: renesas: sh_eth: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/renesas/sh_eth.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/renesas/sh_eth.c

[PATCH 09/15] ethernet: marvell: mvpp2: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/marvell/mvpp2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/marvell/mvpp2.c

[PATCH 13/15] ethernet: stmicro: stmmac: dwmac-socfpga: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- .../net/ethernet/stmicro/stmmac/dwmac-socfpga.c| 36 -- 1 file changed, 26 insertions(+), 10 deletions(-) diff

[PATCH 08/15] ethernet: marvell: mvneta: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/marvell/mvneta.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/marvell/mvneta.c

[PATCH 11/15] ethernet: renesas: ravb_main: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/renesas/ravb_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/renesas/ravb_main.c

[PATCH 06/15] ethernet: hisilicon: hns: hns_dsaf_mac: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

[PATCH 07/15] ethernet: hisilicon: hns: hns_dsaf_main: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH 10/15] ethernet: marvell: pxa168_eth: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/marvell/pxa168_eth.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c

[PATCH 04/15] ethernet: aurora: nb8800: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/aurora/nb8800.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/aurora/nb8800.c

[PATCH 05/15] ethernet: cavium: octeon: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/cavium/octeon/octeon_mgmt.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 03/15] ethernet: arc: emac_main: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/arc/emac_main.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git

[PATCH 01/15] ethernet: altera: add missing of_node_put

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle (or of_node_get) has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/altera/altera_tse_main.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 02/15] ethernet: apm: xgene: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 00/15] ethernet: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
Hi David, This patch set fixes missing of_node_put issue at ethernet driver. of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Thanks. Peter Chen (15): ethernet: altera: add missing of_node_put ethernet: apm: xgene: add missing

Re: [PATCH] qed: Add and use specific logging functions to reduce object size

2016-07-26 Thread Joe Perches
On Tue, 2016-07-26 at 14:25 -0700, Joe Perches wrote: > Current DP_ macros generate a lot of code. > Using functions with vsprintf extension %pV helps reduce that size. Yuval, I used the same KERN_ output types, but it is unusual that DP_INFO outputs at KERN_NOTICE. Was that a copy/paste defect

Re: PROBLEM: network data corruption (bisected to e5a4b0bb803b)

2016-07-26 Thread Alan Curry
Christian Lamparter wrote: > Thanks, I gave the program a try with my WNDA3100 and a WN821N v2 devices. > I did not see any corruptions in any of the tests though. Can you tell me > something about your wireless network too? I would like to know what router > and firmware are you using? Also

Re: question: tg3 driver/nics and inconsistent RX ring count

2016-07-26 Thread Michael Chan
On Tue, Jul 26, 2016 at 1:32 PM, Michal Soltys wrote: > On 2016-07-26 22:06, Alexander Duyck wrote: >> On Tue, Jul 26, 2016 at 12:52 PM, Michal Soltys wrote: >>> Hi, >>> >>> I have a few of BCM5720 and BCM5719 kinds sitting in Dell R320 and R520 >>> servers -

Re: [PATCH v2] net/mlx5_core/health: Remove deprecated create_singlethread_workqueue

2016-07-26 Thread David Miller
From: Bhaktipriya Shridhar Date: Tue, 26 Jul 2016 22:38:24 +0530 > The workqueue health->wq was used as per device private health thread. > This was done to perform delayed work. > > The workqueue has a single workitem(>work) and > hence doesn't require ordering. It is

Re: [PATCH net] l2tp: Correctly return -EBADF from pppol2tp_getname.

2016-07-26 Thread David Miller
From: Phil Turnbull Date: Tue, 26 Jul 2016 15:14:35 -0400 > If 'tunnel' is NULL we should return -EBADF but the 'end_put_sess' path > unconditionally sets 'error' back to zero. Rework the error path so it > more closely matches pppol2tp_sendmsg. > > Fixes: fd558d186df2

Re: [PATCH net-next v2] net: ipmr/ip6mr: update lastuse on entry change

2016-07-26 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 26 Jul 2016 18:54:52 +0200 > Currently lastuse is updated on entry creation and cache hit, but it should > also be updated on entry change. Since both on add and update the ttl array > is updated we can simply update the lastuse

Re: [PATCH v2] net: davinci_cpdma: remove excessive dump of register values to kernel log

2016-07-26 Thread Ivan Khoronzhuk
On 26.07.16 17:26, Grygorii Strashko wrote: + CC: Ivan On 07/26/2016 05:09 PM, Grygorii Strashko wrote: On 07/26/2016 03:57 AM, David Miller wrote: From: Uwe Kleine-König Date: Mon, 25 Jul 2016 11:54:45 +0200 Such a big dump of register values is hardly

Re: [PATCH 1/3] net: asix: Add in_pm parameter

2016-07-26 Thread Grant Grundler
On Tue, Jul 26, 2016 at 2:14 PM, Robert Foss wrote: ... > Thanks for the feedback (for this patch and the other ones)! > I'm preparing a v2 and will submit it withing a day or two. Excellent! very welcome and thanks again for picking this up. ... >> FTR, current

Re: [PATCH net-next V2 0/2] Mellanox 100G mlx5 minimum inline header mode

2016-07-26 Thread David Miller
From: Hadar Hen Zion Date: Tue, 26 Jul 2016 13:30:46 +0300 > In the default case eth_get_headlen() won't be called, it will happen > only if PF administrator changes the mode from default to L4. > > In L4 mode, we need to copy all the packet headers including L4, do >

Re: [PATCH] macsec: ensure rx_sa is set when validation is disabled

2016-07-26 Thread David Miller
From: Beniamino Galvani Date: Tue, 26 Jul 2016 12:24:53 +0200 > macsec_decrypt() is not called when validation is disabled and so > macsec_skb_cb(skb)->rx_sa is not set; but it is used later in > macsec_post_decrypt(), ensure that it's always initialized. > > Signed-off-by:

Re: [PATCH net-next v2 0/5] tipc: netlink updates for neighbour monitor

2016-07-26 Thread David Miller
From: Parthasarathy Bhuvaragan Date: Tue, 26 Jul 2016 08:47:17 +0200 > This series contains the updates to configure and read the attributes for > neighbour monitor. > > v2: rebase on top of net-next Series applied, thanks.

Re: [PATCH v2] net: neigh: disallow transition to NUD_STALE if lladdr is unchanged in neigh_update()

2016-07-26 Thread David Miller
From: Chunhui He Date: Tue, 26 Jul 2016 06:16:52 + > NUD_STALE is used when the caller(e.g. arp_process()) can't guarantee > neighbour reachability. If the entry was NUD_VALID and lladdr is unchanged, > the entry state should not be changed. > > Currently the code

[PATCH] qed: Add and use specific logging functions to reduce object size

2016-07-26 Thread Joe Perches
Current DP_ macros generate a lot of code. Using functions with vsprintf extension %pV helps reduce that size. $ size drivers/net/ethernet/qlogic/built-in.o* (x86-64) textdata bss dec hex filename 165161 28470 32812 226443 3748b

Re: [PATCH 1/3] net: asix: Add in_pm parameter

2016-07-26 Thread Robert Foss
From: Grant Grundler For the record, I believe I am not the author of these patches. I believe the original author is Signed-off-by: Freddy Xin as recorded in the following code reviews (and testing) that I was responsible for:

Re: [PATCH 1/3] net: ethernet: ti: cpdma: fix lockup in cpdma_ctlr_destroy()

2016-07-26 Thread ivan.khoronzhuk
On 26.07.16 19:02, Grygorii Strashko wrote: On 07/23/2016 09:24 AM, Ivan Khoronzhuk wrote: On 22.07.16 16:58, Grygorii Strashko wrote: Fix deadlock in cpdma_ctlr_destroy() which is triggered now on cpsw module removal: cpsw_remove() - cpdma_ctlr_destroy() - spin_lock_irqsave(>lock,

Re: [PATCH v2 00/10] userns: sysctl limits for namespaces

2016-07-26 Thread Kees Cook
On Tue, Jul 26, 2016 at 10:29 AM, Michael Kerrisk (man-pages) wrote: > On 26 July 2016 at 18:52, Kees Cook wrote: >> On Tue, Jul 26, 2016 at 8:06 AM, Eric W. Biederman >> wrote: >>> "Michael Kerrisk (man-pages)"

[PATCH net] be2net: perform temperature query in adapter regardless of its interface state

2016-07-26 Thread Guilherme G. Piccoli
The be2net driver performs fw temperature queries on be_worker() routine, which is executed each second for each be_adapter. There is a frequency threshold to avoid fw query to happens at each call to be_worker(); instead, currently a fw query occurs once in 64 runs of the procedure.

Re: question: tg3 driver/nics and inconsistent RX ring count

2016-07-26 Thread Michal Soltys
On 2016-07-26 22:06, Alexander Duyck wrote: > On Tue, Jul 26, 2016 at 12:52 PM, Michal Soltys wrote: >> Hi, >> >> I have a few of BCM5720 and BCM5719 kinds sitting in Dell R320 and R520 >> servers - and all of them have certain peculiarity: they claim to have >> up to 4 TX and RX

Re: [PATCH net-next 1/2] be2net: set temperature value for all adapter's functions

2016-07-26 Thread Guilherme G. Piccoli
On 07/26/2016 05:26 AM, Sathya Perla wrote: -Original Message- From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com] On 07/25/2016 07:48 AM, Sathya Perla wrote: -Original Message- From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com] Temperature values on

Re: [PATCH v2 09/10] netns: Add a limit on the number of net namespaces

2016-07-26 Thread Eric W. Biederman
Andrei Vagin writes: > On Thu, Jul 21, 2016 at 9:40 AM, Eric W. Biederman > wrote: >> index 2c2eb1b629b1..a489f192d619 100644 >> --- a/net/core/net_namespace.c >> +++ b/net/core/net_namespace.c >> @@ -266,6 +266,16 @@ struct net *get_net_ns_by_id(struct

Re: question: tg3 driver/nics and inconsistent RX ring count

2016-07-26 Thread Alexander Duyck
On Tue, Jul 26, 2016 at 12:52 PM, Michal Soltys wrote: > Hi, > > I have a few of BCM5720 and BCM5719 kinds sitting in Dell R320 and R520 > servers - and all of them have certain peculiarity: they claim to have > up to 4 TX and RX rings (and this can be set/verified just fine

question: tg3 driver/nics and inconsistent RX ring count

2016-07-26 Thread Michal Soltys
Hi, I have a few of BCM5720 and BCM5719 kinds sitting in Dell R320 and R520 servers - and all of them have certain peculiarity: they claim to have up to 4 TX and RX rings (and this can be set/verified just fine through ethtool -l/-L, with driver defaulting to 4 rings), indirection table (ethtool

[PATCH net] l2tp: Correctly return -EBADF from pppol2tp_getname.

2016-07-26 Thread Phil Turnbull
If 'tunnel' is NULL we should return -EBADF but the 'end_put_sess' path unconditionally sets 'error' back to zero. Rework the error path so it more closely matches pppol2tp_sendmsg. Fixes: fd558d186df2 ("l2tp: Split pppol2tp patch into separate l2tp and ppp parts") Signed-off-by: Phil Turnbull

Re: [iovisor-dev] XDP seeking input from NIC hardware vendors

2016-07-26 Thread Tom Herbert
On Tue, Jul 26, 2016 at 10:53 AM, John Fastabend wrote: > On 16-07-26 09:08 AM, Tom Herbert wrote: >> On Tue, Jul 26, 2016 at 6:31 AM, Thomas Monjalon >> wrote: >>> Hi, >>> >>> About RX filtering, there is an ongoing effort in DPDK to write an

Re: [iovisor-dev] XDP seeking input from NIC hardware vendors

2016-07-26 Thread Jesper Dangaard Brouer
On Tue, 26 Jul 2016 10:53:05 -0700 John Fastabend wrote: > On 16-07-26 09:08 AM, Tom Herbert wrote: > > On Tue, Jul 26, 2016 at 6:31 AM, Thomas Monjalon > > wrote: > >> Hi, > >> > >> About RX filtering, there is an ongoing effort in DPDK to

[PATCH net-next v3 1/2] e1000e: factor out systim sanitization

2016-07-26 Thread Jarod Wilson
This is prepatory work for an expanding list of adapter families that have occasional ~10 hour clock jumps when being used for PTP. Factor out the sanitization function and convert to using a feature (bug) flag, per suggestion from Jesse Brandeburg. Littering functional code with device-specific

Re: PROBLEM: network data corruption (bisected to e5a4b0bb803b)

2016-07-26 Thread alexmcwhirter
On 2016-07-26 09:59, Christian Lamparter wrote: Thanks, I gave the program a try with my WNDA3100 and a WN821N v2 devices. I did not see any corruptions in any of the tests though. Can you tell me something about your wireless network too? I would like to know what router and firmware are you

[PATCH v3 net-next 0/2] e1000e: fix PTP on e1000_pch_variants

2016-07-26 Thread Jarod Wilson
This little series factors out the systim sanitization code first, then adds e1000_pch_lpt as a new case in the switch that calls the sanitize function, fixing PTP clock issues I've had reported against an Intel I-218V NIC in an Intel NUC5ik5RYH system. Jarod Wilson (2): e1000e: factor out

[PATCH net-next v3 2/2] e1000e: fix PTP on e1000_pch_lpt variants

2016-07-26 Thread Jarod Wilson
I've got reports that the Intel I-218V NIC in Intel NUC5i5RYH systems used as a PTP slave experiences random ~10 hour clock jumps, which are resolved if the same workaround for the 82574 and 82583 is employed, so set the appropriate flag2 in e1000_pch_lpt_info too. Reported-by: Rupesh Patel

Re: [PATCH net-next v2 0/3] virtio: style cleanups

2016-07-26 Thread Michael S. Tsirkin
On Tue, Jul 26, 2016 at 09:37:12AM -0700, Stephen Hemminger wrote: > Minor things found while doing some inspection code review. Acked-by: Michael S. Tsirkin I guess I'll just queue it up for this release. -- MST

Re: [PATCH v2] net/mlx5_core/health: Remove deprecated create_singlethread_workqueue

2016-07-26 Thread Leon Romanovsky
On Tue, Jul 26, 2016 at 10:38:24PM +0530, Bhaktipriya Shridhar wrote: > The workqueue health->wq was used as per device private health thread. > This was done to perform delayed work. > > The workqueue has a single workitem(>work) and > hence doesn't require ordering. It is involved in handling

Re: [PATCH net-next 0/3] qed*: Janitorial series [semantic & prints]

2016-07-26 Thread David Miller
From: Yuval Mintz Date: Tue, 26 Jul 2016 16:58:34 +0300 > Some day 1 slips in coding style exist in the qed* code > [incorrect alignments, conditions using (== 0), etc.]. > This series comes to address those, and do some additional > cosmetic changes along the way [such

Re: [PATCH net-next 3/3] virtio: use kcalloc and kmalloc_array

2016-07-26 Thread David Miller
From: Stephen Hemminger Date: Tue, 26 Jul 2016 09:35:43 -0700 > On Tue, 26 Jul 2016 09:20:11 -0700 > Stephen Hemminger wrote: > >> Preferred style is to use kcalloc and kmalloc_array. >> >> Signed-off-by: Stephen Hemminger

Re: [PATCH net-next 3/2] e1000e: convert systim overflow check to use flags2

2016-07-26 Thread Jarod Wilson
On Tue, Jul 26, 2016 at 10:53:55AM -0700, Jeff Kirsher wrote: > On Tue, 2016-07-26 at 13:39 -0400, Jarod Wilson wrote: > > Per Jesse Brandeburg, e1000e should be using flags for this sort of > > thing. > > > > Littering functional code with device-specific checks is much messier > > than > >

Re: [PATCH net-next 3/2] e1000e: convert systim overflow check to use flags2

2016-07-26 Thread Jeff Kirsher
On Tue, 2016-07-26 at 13:39 -0400, Jarod Wilson wrote: > Per Jesse Brandeburg, e1000e should be using flags for this sort of > thing. > > Littering functional code with device-specific checks is much messier > than > simply checking a flag, and having device-specific init set flags as > needed. >

Re: [iovisor-dev] XDP seeking input from NIC hardware vendors

2016-07-26 Thread John Fastabend
On 16-07-26 09:08 AM, Tom Herbert wrote: > On Tue, Jul 26, 2016 at 6:31 AM, Thomas Monjalon > wrote: >> Hi, >> >> About RX filtering, there is an ongoing effort in DPDK to write an API >> which could leverage most of the hardware capabilities of any NICs: >>

Re: [PATCH v18 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-07-26 Thread David Miller
From: Dexuan Cui Date: Tue, 26 Jul 2016 07:09:41 + > I googled "S390 hypervisor socket" but didn't find anything related (I think). That would be net/iucv/ There's also VMWare's stuff under net/vmw_vsock It's just absolutely rediculous to make a new hypervisor socket

[PATCH net-next 3/2] e1000e: convert systim overflow check to use flags2

2016-07-26 Thread Jarod Wilson
Per Jesse Brandeburg, e1000e should be using flags for this sort of thing. Littering functional code with device-specific checks is much messier than simply checking a flag, and having device-specific init set flags as needed. There are probably a number of other cases in the e1000e code that

Re: [PATCH v2 00/10] userns: sysctl limits for namespaces

2016-07-26 Thread Michael Kerrisk (man-pages)
On 26 July 2016 at 18:52, Kees Cook wrote: > On Tue, Jul 26, 2016 at 8:06 AM, Eric W. Biederman > wrote: >> "Michael Kerrisk (man-pages)" writes: >> >>> Hello Eric, >>> >>> I realized I had a question after the last mail. >>>

[PATCH v2] net/mlx5_core/health: Remove deprecated create_singlethread_workqueue

2016-07-26 Thread Bhaktipriya Shridhar
The workqueue health->wq was used as per device private health thread. This was done to perform delayed work. The workqueue has a single workitem(>work) and hence doesn't require ordering. It is involved in handling the health of the device and is not being used on a memory reclaim path. Hence,

Re: patch for PCH_GBE rotten packet (Intel EG20T Platform Controller).

2016-07-26 Thread Alexander Duyck
On Tue, Jul 26, 2016 at 9:00 AM, Tom Walsh wrote: > Not sure how this goes, but, we found a race condition in > drivers/net/ethernet/oki-semi/pch_gbe/ > > The attached patch corrects for this. > > TomW So a few minor changes are probably needed. First we don't recommend

Re: [PATCH net-next v2 1/3] virtio: whitespace cleanups

2016-07-26 Thread Michael S. Tsirkin
On Tue, Jul 26, 2016 at 09:37:13AM -0700, Stephen Hemminger wrote: > Adjust whitespace to match current favored style. > > Signed-off-by: Stephen Hemminger > > --- a/drivers/net/virtio_net.c2016-07-20 08:12:24.035656119 -0700 > +++ b/drivers/net/virtio_net.c

[PATCH net-next v2] net: ipmr/ip6mr: update lastuse on entry change

2016-07-26 Thread Nikolay Aleksandrov
Currently lastuse is updated on entry creation and cache hit, but it should also be updated on entry change. Since both on add and update the ttl array is updated we can simply update the lastuse in ipmr_update_thresholds. Signed-off-by: Nikolay Aleksandrov CC: Roopa

Re: [PATCH v2 00/10] userns: sysctl limits for namespaces

2016-07-26 Thread Kees Cook
On Tue, Jul 26, 2016 at 8:06 AM, Eric W. Biederman wrote: > "Michael Kerrisk (man-pages)" writes: > >> Hello Eric, >> >> I realized I had a question after the last mail. >> >> On 07/21/2016 06:39 PM, Eric W. Biederman wrote: >>> >>> This patchset

[PATCH net-next v2 0/3] virtio: style cleanups

2016-07-26 Thread Stephen Hemminger
Minor things found while doing some inspection code review.

[PATCH net-next v2 2/3] virtio: cleanup sizeof usage

2016-07-26 Thread Stephen Hemminger
Although sizeof is an operator in C. Preferred usage is to use it as a function. Signed-off-by: Stephen Hemminger --- a/drivers/net/virtio_net.c 2016-07-26 09:13:16.173384238 -0700 +++ b/drivers/net/virtio_net.c 2016-07-26 09:13:16.169384220 -0700 @@ -272,7 +272,7

[PATCH net-next v2 3/3] virtio: use kcalloc and kmalloc_array

2016-07-26 Thread Stephen Hemminger
Preferred style is to use kcalloc and kmalloc_array. Signed-off-by: Stephen Hemminger --- a/drivers/net/virtio_net.c 2016-07-26 09:28:21.401557546 -0700 +++ b/drivers/net/virtio_net.c 2016-07-26 09:36:05.107695337 -0700 @@ -1551,13 +1551,13 @@ static int

[PATCH net-next v2 1/3] virtio: whitespace cleanups

2016-07-26 Thread Stephen Hemminger
Adjust whitespace to match current favored style. Signed-off-by: Stephen Hemminger --- a/drivers/net/virtio_net.c 2016-07-20 08:12:24.035656119 -0700 +++ b/drivers/net/virtio_net.c 2016-07-26 09:11:06.988788668 -0700 @@ -201,7 +201,9 @@ static void

Re: [PATCH net-next 3/3] virtio: use kcalloc and kmalloc_array

2016-07-26 Thread Stephen Hemminger
On Tue, 26 Jul 2016 09:20:11 -0700 Stephen Hemminger wrote: > Preferred style is to use kcalloc and kmalloc_array. > > Signed-off-by: Stephen Hemminger Do not apply, needs redo. Wasn't updated. properly

Re: [PATCH net-next 3/3] virtio: use kcalloc and kmalloc_array

2016-07-26 Thread Michael S. Tsirkin
On Tue, Jul 26, 2016 at 09:20:11AM -0700, Stephen Hemminger wrote: > Preferred style is to use kcalloc and kmalloc_array. > > Signed-off-by: Stephen Hemminger > > --- a/drivers/net/virtio_net.c2016-07-26 09:13:19.805400983 -0700 > +++

[PATCH net-next] net: ipmr/ip6mr: update lastuse on entry change

2016-07-26 Thread Nikolay Aleksandrov
Currently lastuse is updated on entry creation and cache hit, but it should also be updated on entry change. Signed-off-by: Nikolay Aleksandrov CC: Roopa Prabhu CC: Donald Sharp CC: David S. Miller

Re: [PATCH net-next 3/3] virtio: use kcalloc and kmalloc_array

2016-07-26 Thread Nikolay Aleksandrov
On 26/07/16 18:20, Stephen Hemminger wrote: > Preferred style is to use kcalloc and kmalloc_array. > > Signed-off-by: Stephen Hemminger > > --- a/drivers/net/virtio_net.c2016-07-26 09:13:19.805400983 -0700 > +++ b/drivers/net/virtio_net.c2016-07-26

Re: [e1000_netpoll] BUG: sleeping function called from invalid context at kernel/irq/manage.c:110

2016-07-26 Thread Eric Dumazet
On Tue, 2016-07-26 at 23:32 +0800, Fengguang Wu wrote: > Hi Eric, > > It works! > > On Tue, Jul 26, 2016 at 11:14:52AM +0200, Eric Dumazet wrote: > >On Tue, 2016-07-26 at 11:50 +0800, Fengguang Wu wrote: > >> Greetings, > >> > >> This BUG message can be found in recent kernels as well as v4.4

[PATCH net-next 0/3] virtio: style cleanups

2016-07-26 Thread Stephen Hemminger

[PATCH net-next 1/3] virtio: whitespace cleanups

2016-07-26 Thread Stephen Hemminger
Adjust whitespace to match current favored style. Signed-off-by: Stephen Hemminger --- a/drivers/net/virtio_net.c 2016-07-20 08:12:24.035656119 -0700 +++ b/drivers/net/virtio_net.c 2016-07-26 09:11:06.988788668 -0700 @@ -201,7 +201,9 @@ static void

[PATCH net-next 2/3] virtio: cleanup sizeof usage

2016-07-26 Thread Stephen Hemminger
Although sizeof is an operator in C. Preferred usage is to use it as a function. Signed-off-by: Stephen Hemminger --- a/drivers/net/virtio_net.c 2016-07-26 09:13:16.173384238 -0700 +++ b/drivers/net/virtio_net.c 2016-07-26 09:13:16.169384220 -0700 @@ -272,7 +272,7

[PATCH net-next 3/3] virtio: use kcalloc and kmalloc_array

2016-07-26 Thread Stephen Hemminger
Preferred style is to use kcalloc and kmalloc_array. Signed-off-by: Stephen Hemminger --- a/drivers/net/virtio_net.c 2016-07-26 09:13:19.805400983 -0700 +++ b/drivers/net/virtio_net.c 2016-07-26 09:13:19.801400965 -0700 @@ -1551,13 +1551,13 @@ static int

Re: [iovisor-dev] XDP seeking input from NIC hardware vendors

2016-07-26 Thread Tom Herbert
On Tue, Jul 26, 2016 at 6:31 AM, Thomas Monjalon wrote: > Hi, > > About RX filtering, there is an ongoing effort in DPDK to write an API > which could leverage most of the hardware capabilities of any NICs: >

Re: [PATCH 1/3] net: ethernet: ti: cpdma: fix lockup in cpdma_ctlr_destroy()

2016-07-26 Thread Grygorii Strashko
On 07/23/2016 09:24 AM, Ivan Khoronzhuk wrote: > > > On 22.07.16 16:58, Grygorii Strashko wrote: >> Fix deadlock in cpdma_ctlr_destroy() which is triggered now on >> cpsw module removal: >> cpsw_remove() >> - cpdma_ctlr_destroy() >>- spin_lock_irqsave(>lock, flags) >>-

patch for PCH_GBE rotten packet (Intel EG20T Platform Controller).

2016-07-26 Thread Tom Walsh
Not sure how this goes, but, we found a race condition in drivers/net/ethernet/oki-semi/pch_gbe/ The attached patch corrects for this. TomW -- Tom Walsh - WN3L - Embedded Systems Consultant http://openhardware.net "Windows? No thanks, I have work to do..."

Re: [e1000_netpoll] BUG: sleeping function called from invalid context at kernel/irq/manage.c:110

2016-07-26 Thread Fengguang Wu
Hi Eric, It works! On Tue, Jul 26, 2016 at 11:14:52AM +0200, Eric Dumazet wrote: On Tue, 2016-07-26 at 11:50 +0800, Fengguang Wu wrote: Greetings, This BUG message can be found in recent kernels as well as v4.4 and linux-stable. It happens when running modprobe netconsole

Re: [PATCH v2 00/10] userns: sysctl limits for namespaces

2016-07-26 Thread Eric W. Biederman
"Michael Kerrisk (man-pages)" writes: > Hello Eric, > > On 07/21/2016 06:39 PM, Eric W. Biederman wrote: >> >> This patchset addresses two use cases: >> - Implement a sane upper bound on the number of namespaces. >> - Provide a way for sandboxes to limit the attack

Re: [PATCH v2 00/10] userns: sysctl limits for namespaces

2016-07-26 Thread Eric W. Biederman
"Michael Kerrisk (man-pages)" writes: > Hello Eric, > > I realized I had a question after the last mail. > > On 07/21/2016 06:39 PM, Eric W. Biederman wrote: >> >> This patchset addresses two use cases: >> - Implement a sane upper bound on the number of namespaces. >> -

RE: [RFC PATCH v2 1/4] Documentation: DT: net: Add Xilinx gmiitorgmii converter device tree binding documentation

2016-07-26 Thread Appana Durga Kedareswara Rao
Hi Andrew, Thanks for the inputs... > > > > > > Hi Kedareswara > > > > > > > > So looking at the device tree, you have the gmiitorgmii as an mdio > > > > device. It will get probed as an mdio device, and from that you > > > > know the address on the bus. However, your driver does not > >

[PATCH -next] i40e: Use list_move instead of list_del/list_add

2016-07-26 Thread Wei Yongjun
Using list_move() instead of list_del() + list_add(). Signed-off-by: Wei Yongjun --- drivers/net/ethernet/intel/i40e/i40e_client.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_client.c

Re: [PATCH 0/2] net: davinci_cpdma: reduce latency on -rt

2016-07-26 Thread Grygorii Strashko
On 07/26/2016 03:02 PM, Uwe Kleine-König wrote: Hello, these patches are based on next-20160726. I didn't check yet how latency improves by using these patches, but even if the improvment is small, it's still a good idea to have them. Sry, but how this will affect on -RT? This is not a raw

[PATCH v2 1/1] Add timer to handle OOM situations

2016-07-26 Thread ggarcia
From: Gerard Garcia v2: * Use of ERR_PTR/PTR_ERR/IS_ERR * Timer cleaned on device release. * Do not process more packets on error. Signed-off-by: Gerard Garcia --- drivers/vhost/vsock.c | 55 +-- 1

[PATCH v2 0/1] virtio-vsock: Add timer to handle OOM situations

2016-07-26 Thread ggarcia
From: Gerard Garcia This patch applies over the stefanha/vsock-next repository: https://github.com/stefanha/linux/tree/vsock-next Once the guest puts a packet in the virtqueue it is guaranteed that it will be delivered. This patch addresses the problem of packets being

Re: [PATCH v2] net: davinci_cpdma: remove excessive dump of register values to kernel log

2016-07-26 Thread Grygorii Strashko
+ CC: Ivan On 07/26/2016 05:09 PM, Grygorii Strashko wrote: On 07/26/2016 03:57 AM, David Miller wrote: From: Uwe Kleine-König Date: Mon, 25 Jul 2016 11:54:45 +0200 Such a big dump of register values is hardly useful on a production system. Another downside

Re: [PATCH 2/2] net: davinci_cpdma: reduce time holding chan->lock in cpdma_chan_submit

2016-07-26 Thread Grygorii Strashko
On 07/26/2016 03:02 PM, Uwe Kleine-König wrote: > Allocating and preparing a dma descriptor doesn't need to happen under > the channel's lock. So do this before taking the channel's lock. The only > down side is that the dma descriptor might be allocated even though the > channel is about to be

Re: [iproute PATCH 3/4] tc: use action_a2n() everywhere

2016-07-26 Thread Jamal Hadi Salim
On 16-07-23 07:28 AM, Phil Sutter wrote: Signed-off-by: Phil Sutter Thanks for the nice work Phil. Acked-by: Jamal Hadi Salim cheers, jamal

Re: [iproute PATCH 2/4] tc: util: bore up action_a2n()

2016-07-26 Thread Jamal Hadi Salim
On 16-07-23 07:28 AM, Phil Sutter wrote: It's a pitty this function is used nowhere, so let's polish it for use: * Loop over branch names, makes it clear that every former conditional was exactly identical. * Support 'pipe' branch name, too. * Make number parsing optional. Signed-off-by:

Re: [PATCH v2] net: davinci_cpdma: remove excessive dump of register values to kernel log

2016-07-26 Thread Grygorii Strashko
On 07/26/2016 03:57 AM, David Miller wrote: From: Uwe Kleine-König Date: Mon, 25 Jul 2016 11:54:45 +0200 Such a big dump of register values is hardly useful on a production system. Another downside of the now removed functions is that calling emac_dump_regs

Re: PROBLEM: network data corruption (bisected to e5a4b0bb803b)

2016-07-26 Thread Christian Lamparter
On Tuesday, July 26, 2016 4:57:03 AM CEST Alan Curry wrote: > Al Viro wrote: > > On Sun, Jul 24, 2016 at 07:45:13PM +0200, Christian Lamparter wrote: > > > > > > The symptom is that downloaded files (http, ftp, and probably other > > > > protocols) have small corrupted segments (about 1-2

Re: [Patch net-next v2 1/2] net_sched: move tc_action into tcf_common

2016-07-26 Thread Jamal Hadi Salim
On 16-07-25 07:09 PM, Cong Wang wrote: struct tc_action is confusing, currently we use it for two purposes: 1) Pass in arguments and carry out results from helper functions 2) A generic representation for tc actions The first one is error-prone, since we need to make sure we don't miss

[PATCH net-next 1/3] qed*: Semantic changes

2016-07-26 Thread Yuval Mintz
Make semantic-only adjustments to qed* drivers, such as: - Changes in code indentation. - Usage of BIT() macro. - re-naming of variables. - Re-ordering of variable declerations. - Removal of (== 0) and (!= 0) in conditions. Signed-off-by: Yuval Mintz ---

[PATCH net-next 3/3] qed*: Add and modify some prints

2016-07-26 Thread Yuval Mintz
This patch touches various prints in the driver - it reduces the verbosity of some prints [which were previously logged by default] while adding several new debug prints and modifying others. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_dev.c|

[PATCH net-next 2/3] qed*: Trivial modifications

2016-07-26 Thread Yuval Mintz
Change qed* code in trivial manner; This isn't necessarily semantic-only, but the end result is the same, i.e., no change should occur from user perspective. Changes include: - Using temporary variables to better fit 80-character restrictions. - Removal of unused variables & code with no

[PATCH net-next 0/3] qed*: Janitorial series [semantic & prints]

2016-07-26 Thread Yuval Mintz
Hi Dave, Some day 1 slips in coding style exist in the qed* code [incorrect alignments, conditions using (== 0), etc.]. This series comes to address those, and do some additional cosmetic changes along the way [such as reducing the number of lines for function declerations]. The series is broken

Re: [iproute PATCH 0/3] improve MACsec support

2016-07-26 Thread Sabrina Dubroca
2016-07-26, 11:03:17 +0200, Davide Caratti wrote: > parsing of 'cipher' and 'icvlen' arguments has been improved; while at it, > a couple of missing printouts have been added to usage() functions in > "ip addr help" and "ip link help". Finally, some errors in the man pages > have been fixed. > >

  1   2   >